)]}'
{"tools/cleanup-images":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"305a7489e1d79bae0c9915b78dae728b76836891","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":". tools/validate-docker-execute.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IMAGES\u003d$(docker images -a | tail -n +2 | awk \u0027!/registry/{print $3;}\u0027)"},{"line_number":10,"context_line":"if [[ -z \"$IMAGES\" ]]; then"},{"line_number":11,"context_line":"    echo \"No images to cleanup, exit now.\""},{"line_number":12,"context_line":"    exit 0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a122d0e_48bea6ae","line":9,"updated":"2016-04-28 12:52:32.000000000","message":"agreed. only exclude the regitry image is not enough.","commit_id":"dab8750bc56787683aae94203f9018039f516462"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"218cee05bb9492f71c7f650f427aa0cc8379463f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":". tools/validate-docker-execute.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IMAGES\u003d$(docker images -a | tail -n +2 | awk \u0027!/registry/{print $3;}\u0027)"},{"line_number":10,"context_line":"if [[ -z \"$IMAGES\" ]]; then"},{"line_number":11,"context_line":"    echo \"No images to cleanup, exit now.\""},{"line_number":12,"context_line":"    exit 0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a122d0e_aa83f201","line":9,"range":{"start_line":9,"start_character":48,"end_line":9,"end_character":56},"updated":"2016-04-28 11:54:46.000000000","message":"since you are on this, can we do a change which includes the kolla specific images?","commit_id":"dab8750bc56787683aae94203f9018039f516462"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"80f9bfd6eda4eac8030e3397588fec4c24082c42","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":". tools/validate-docker-execute.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IMAGES\u003d$(docker images -a | tail -n +2 | awk \u0027!/registry/{print $3;}\u0027)"},{"line_number":10,"context_line":"if [[ -z \"$IMAGES\" ]]; then"},{"line_number":11,"context_line":"    echo \"No images to cleanup, exit now.\""},{"line_number":12,"context_line":"    exit 0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a122d0e_233ebfb7","line":9,"in_reply_to":"1a122d0e_48bea6ae","updated":"2016-04-29 18:33:15.000000000","message":"A bug has already been reported https://bugs.launchpad.net/kolla/+bug/1551933","commit_id":"dab8750bc56787683aae94203f9018039f516462"},{"author":{"_account_id":17731,"name":"Carlos Cesario","email":"carloscesario@gmail.com","username":"ccesario"},"change_message_id":"d3bb3b8362b5263e738104f22948b52612d57e7a","unresolved":false,"context_lines":[{"line_number":7,"context_line":". tools/validate-docker-execute.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"base\u003d$(awk -F \" \u003d \" \u0027/^base/{print $2;}\u0027 /etc/kolla/kolla-build.conf)"},{"line_number":10,"context_line":"if [ -z $base ]; then"},{"line_number":11,"context_line":"    base\u003d\"centos\""},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":"install_type\u003d$(awk -F \" \u003d \" \u0027/^install_type/{print $2;}\u0027 /etc/kolla/kolla-build.conf)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a122d0e_275eab79","line":10,"updated":"2016-05-02 12:57:17.000000000","message":"This check can fails. Because kolla-build.conf is not mandatory. Kolla build can works without kolla-build.conf. The base param can be passed by cli.","commit_id":"73b3457a1404ed55911a611a088c26c2b9eb8f39"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"bf211241c6a1a913a098f7b0df24ee8d4a86d920","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":". tools/validate-docker-execute.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IMAGES\u003d\""},{"line_number":10,"context_line":"    centos-binary-base"},{"line_number":11,"context_line":"    centos-source-base"},{"line_number":12,"context_line":"    debian-binary-base"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a122d0e_908c8936","line":9,"updated":"2016-05-05 14:44:08.000000000","message":"Despite the previous approach as being somewhat \"ban hammer\", at least the image list didn\u0027t need to be maintained. Could this be changed to dynamically create this list based of the directories somehow?","commit_id":"90709a4048d407f5baa66a25dc4f8f4e56e7ae88"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"695fc20d68bc64a0feddbbf2b3f7f91bd0865b0d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":". tools/validate-docker-execute.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IMAGES\u003d\""},{"line_number":10,"context_line":"    centos-binary-base"},{"line_number":11,"context_line":"    centos-source-base"},{"line_number":12,"context_line":"    debian-binary-base"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a122d0e_33ce5f83","line":9,"in_reply_to":"1a122d0e_908c8936","updated":"2016-05-05 14:59:52.000000000","message":"Or maybe (looking at another review) could have some name sharing with the containers clean up script...","commit_id":"90709a4048d407f5baa66a25dc4f8f4e56e7ae88"}]}