)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"0b2985e0748ceeb7cb8ce19b9497db7d25a1b559","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the code and determined that these don\u0027t represent security issues"},{"line_number":11,"context_line":"so we should add a #nosec tag that tells Bandit not to find these"},{"line_number":12,"context_line":"issues in the future."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic37216c08442c700c64118c78cfb46e6cedd237c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_7d866bdc","line":13,"updated":"2016-05-02 17:36:22.000000000","message":"Please, add TrivialFix tag","commit_id":"b9f689f82b5324eb2aa80cf8143a62303c334c27"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d9636fb8356f9a04f5205a8e112ca87f515f8909","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the code and determined that these don\u0027t represent security issues"},{"line_number":11,"context_line":"so we should add a #nosec tag that tells Bandit not to find these"},{"line_number":12,"context_line":"issues in the future."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic37216c08442c700c64118c78cfb46e6cedd237c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_00b55030","line":13,"updated":"2016-05-02 17:49:24.000000000","message":"this needs a bug id to be backported.  Since we plan to gate on bandit, we need bug ids track the backporting happens correctly.","commit_id":"7eb92228eb49f5427aabc35a58b542c391dac3ab"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"2d4dc3f81298dbc014280c3904562e68c963c676","unresolved":false,"context_lines":[{"line_number":11,"context_line":"so we should add a #nosec tag that tells Bandit not to find these"},{"line_number":12,"context_line":"issues in the future."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1577498"},{"line_number":17,"context_line":"Change-Id: Ic37216c08442c700c64118c78cfb46e6cedd237c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a122d0e_6086c417","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":10},"updated":"2016-05-02 18:02:18.000000000","message":"You can remove the trivialfix tag since this ps has a bug id","commit_id":"1ce588ceaa209ad791c07b53ded31d8b4fc0f6c3"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c736983d650840b9dec93d64e09bf9d3477a2809","unresolved":false,"context_lines":[{"line_number":11,"context_line":"so we should add a #nosec tag that tells Bandit not to find these"},{"line_number":12,"context_line":"issues in the future."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TrivialFix"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1577498"},{"line_number":17,"context_line":"Change-Id: Ic37216c08442c700c64118c78cfb46e6cedd237c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a122d0e_4092a84c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":10},"in_reply_to":"1a122d0e_6086c417","updated":"2016-05-02 18:04:11.000000000","message":"no reason to churn the review -\u003d its fine as is","commit_id":"1ce588ceaa209ad791c07b53ded31d8b4fc0f6c3"}],"kolla/cmd/build.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"befd5576262fa758277de36599b899cb394d7597","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            template_name \u003d \"Dockerfile.j2\""},{"line_number":476,"context_line":"            env \u003d jinja2.Environment("},{"line_number":477,"context_line":"                loader\u003djinja2.FileSystemLoader(path))  # nosec :"},{"line_number":478,"context_line":"            # template not used to render HTML; autoescape not needed"},{"line_number":479,"context_line":"            template \u003d env.get_template(template_name)"},{"line_number":480,"context_line":"            values \u003d {\u0027base_distro\u0027: self.base,"},{"line_number":481,"context_line":"                      \u0027base_distro_tag\u0027: self.base_tag,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_bc7660a1","line":478,"updated":"2016-04-30 12:15:38.000000000","message":"just understand. This line explain the #nosec line. \nBut isn\u0027t it better to move this line to the above of # nosec?\nnormally, the comments explain the following lines.","commit_id":"34f71b9daa825de700b3ac2399b7b711ac3eeb65"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f4c019dd31699c081da693a01aa566609cb6871e","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            template_name \u003d \"Dockerfile.j2\""},{"line_number":476,"context_line":"            env \u003d jinja2.Environment("},{"line_number":477,"context_line":"                loader\u003djinja2.FileSystemLoader(path))  # nosec :"},{"line_number":478,"context_line":"            # template not used to render HTML; autoescape not needed"},{"line_number":479,"context_line":"            template \u003d env.get_template(template_name)"},{"line_number":480,"context_line":"            values \u003d {\u0027base_distro\u0027: self.base,"},{"line_number":481,"context_line":"                      \u0027base_distro_tag\u0027: self.base_tag,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_411dc00d","line":478,"updated":"2016-04-29 14:16:26.000000000","message":"what do you mean by adding this?\nI am sorry i can not understand. Could u explain this?","commit_id":"34f71b9daa825de700b3ac2399b7b711ac3eeb65"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"20f05198ae9cec593859a74229487cc667e57a1c","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            template_name \u003d \"Dockerfile.j2\""},{"line_number":476,"context_line":"            env \u003d jinja2.Environment("},{"line_number":477,"context_line":"                loader\u003djinja2.FileSystemLoader(path))  # nosec :"},{"line_number":478,"context_line":"            # template not used to render HTML; autoescape not needed"},{"line_number":479,"context_line":"            template \u003d env.get_template(template_name)"},{"line_number":480,"context_line":"            values \u003d {\u0027base_distro\u0027: self.base,"},{"line_number":481,"context_line":"                      \u0027base_distro_tag\u0027: self.base_tag,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_e1de8c0f","line":478,"in_reply_to":"1a122d0e_411dc00d","updated":"2016-04-29 14:21:08.000000000","message":"Since jinja2 templates are so often used to render HTML, there is an auto-escape feature that helps to prevent XSS vulnerabilities.\n\nThe #nosec tag here indicates that somebody (me) has looked at this code, determined that auto-escape is not needed here, and that Bandit shouldn\u0027t find this issue anymore.","commit_id":"34f71b9daa825de700b3ac2399b7b711ac3eeb65"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"849b0b94d7c587ab1b595fdd22ef17b37680128b","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            template_name \u003d \"Dockerfile.j2\""},{"line_number":476,"context_line":"            env \u003d jinja2.Environment("},{"line_number":477,"context_line":"                loader\u003djinja2.FileSystemLoader(path))  # nosec :"},{"line_number":478,"context_line":"            # template not used to render HTML; autoescape not needed"},{"line_number":479,"context_line":"            template \u003d env.get_template(template_name)"},{"line_number":480,"context_line":"            values \u003d {\u0027base_distro\u0027: self.base,"},{"line_number":481,"context_line":"                      \u0027base_distro_tag\u0027: self.base_tag,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_53dba54f","line":478,"in_reply_to":"1a122d0e_bc7660a1","updated":"2016-05-02 15:30:37.000000000","message":"Yeah, ideally I would have liked to have it after the nosec itself but we didn\u0027t have room.  Good point though, fixing","commit_id":"34f71b9daa825de700b3ac2399b7b711ac3eeb65"}]}