)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"89a74317a1e76cf4cd86722998ea6516bad45af6","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN rpm --import http://yum.mariadb.org/RPM-GPG-KEY-MariaDB \\"},{"line_number":36,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-Percona \\"},{"line_number":37,"context_line":"    \u0026\u0026 rpm --import https://packages.elastic.co/GPG-KEY-elasticsearch"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    {% if install_metatype in [\u0027rdo\u0027, \u0027mixed\u0027] %}"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dab17558_85af0029","line":37,"updated":"2016-05-10 21:30:13.000000000","message":"will these keys be impacted if the repos changes?","commit_id":"ad84bb93b516603659fd710ace1a709743c2c508"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"4c50c2350e15daf72f2f6332373aa24fcb77b177","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN rpm --import http://yum.mariadb.org/RPM-GPG-KEY-MariaDB \\"},{"line_number":36,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-Percona \\"},{"line_number":37,"context_line":"    \u0026\u0026 rpm --import https://packages.elastic.co/GPG-KEY-elasticsearch"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    {% if install_metatype in [\u0027rdo\u0027, \u0027mixed\u0027] %}"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dab17558_884d479c","line":37,"in_reply_to":"dab17558_85af0029","updated":"2016-05-11 07:27:17.000000000","message":"we can customize the rpm imports as well.","commit_id":"ad84bb93b516603659fd710ace1a709743c2c508"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"9d3f673452844ed6dcb3dde1fa2301883f1f0913","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN rpm --import http://yum.mariadb.org/RPM-GPG-KEY-MariaDB \\"},{"line_number":36,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-Percona \\"},{"line_number":37,"context_line":"    \u0026\u0026 rpm --import https://packages.elastic.co/GPG-KEY-elasticsearch"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    {% if install_metatype in [\u0027rdo\u0027, \u0027mixed\u0027] %}"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dab17558_aa7595cb","line":37,"in_reply_to":"dab17558_884d479c","updated":"2016-05-14 15:03:07.000000000","message":"These will be customized","commit_id":"ad84bb93b516603659fd710ace1a709743c2c508"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"57c04804b712e46a95e65da837fe66288809607b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"RUN cat /tmp/kolla_bashrc \u003e\u003e /etc/bashrc"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#### BEGIN REPO ENABLEMENT"},{"line_number":31,"context_line":"# Turns on Elasticsearch repos"},{"line_number":32,"context_line":"COPY elasticsearch.yum.repo /etc/yum.repos.d/elasticsearch.repo"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Turns on Kibana repo"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dab17558_0cb13de0","side":"PARENT","line":31,"updated":"2016-05-17 19:20:54.000000000","message":"I think includes would be better","commit_id":"27580054dbaa1249c2aacd817487a62e9c1a7cb3"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"6d269a178fb526098c456362b74e0cbd9f88fefd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"RUN cat /tmp/kolla_bashrc \u003e\u003e /etc/bashrc"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#### BEGIN REPO ENABLEMENT"},{"line_number":31,"context_line":"{% for cmd in global_repo_setup %}"},{"line_number":32,"context_line":"{{ cmd }}"},{"line_number":33,"context_line":"{% endfor %}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dab17558_905f490e","line":31,"updated":"2016-05-16 17:08:44.000000000","message":"These repos are really just global for the rht variants though. What about Ubuntu?","commit_id":"fb806d2fc182bc9e8fcb5196d8a786227d02758b"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"282ec103cf8b51f4b57ac01498f0e3b192120841","unresolved":false,"context_lines":[{"line_number":177,"context_line":"COPY sources.list /etc/apt/"},{"line_number":178,"context_line":"COPY apt_preferences /etc/apt/preferences"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"RUN apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 199369E5404BD5FC7D2FE43BCBCB082A1BB943DB \\"},{"line_number":181,"context_line":"    \u0026\u0026 apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 391A9AA2147192839E9DB0315EDB1B62EC4926EA \\"},{"line_number":182,"context_line":"    \u0026\u0026 apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 430BDF5C56E7C94E848EE60C1C4CBDCDCD2EFD2A \\"},{"line_number":183,"context_line":"    \u0026\u0026 apt-key adv --recv-keys --keyserver hkp://keyserver.ubuntu.com:80 08B73419AC32B4E966C1A330E84AC2C0460F3994 \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dab17558_9c903a50","line":180,"range":{"start_line":180,"start_character":4,"end_line":180,"end_character":7},"updated":"2016-05-15 01:11:37.000000000","message":"Shouldn\u0027t we add this to the customization as well?","commit_id":"fb806d2fc182bc9e8fcb5196d8a786227d02758b"}],"kolla/common/config.py":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"08514e6358817323ca6bc5f06b09505de3584525","unresolved":false,"context_lines":[{"line_number":24,"context_line":"DELOREAN_DEPS \u003d \"{}/delorean-deps.repo\".format(RDO_MIRROR)"},{"line_number":25,"context_line":"INSTALL_TYPE_CHOICES \u003d [\u0027binary\u0027, \u0027source\u0027, \u0027rdo\u0027, \u0027rhos\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Global Repos"},{"line_number":28,"context_line":"ELASTIC_SEARCH \u003d \"elasticsearch.yum.repo\""},{"line_number":29,"context_line":"KIBANA \u003d \"kibana.yum.repo\""},{"line_number":30,"context_line":"MARIADB \u003d \"mariadb.yum.repo\""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_11d6ba4e","line":27,"updated":"2016-05-16 18:36:21.000000000","message":"yug - i can see this getting out of hand quickly.  What would make more sense is an ini file in the docker/base directory containing all the stuff - that way its stored with the dockerfile rather then hidden away hardcoded in python somewhere","commit_id":"fb806d2fc182bc9e8fcb5196d8a786227d02758b"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"c7afa5c4c9d4decd6c56629a0ca36cd05270f6e2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"DELOREAN_DEPS \u003d \"{}/delorean-deps.repo\".format(RDO_MIRROR)"},{"line_number":25,"context_line":"INSTALL_TYPE_CHOICES \u003d [\u0027binary\u0027, \u0027source\u0027, \u0027rdo\u0027, \u0027rhos\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Global Repos"},{"line_number":28,"context_line":"ELASTIC_SEARCH \u003d \"elasticsearch.yum.repo\""},{"line_number":29,"context_line":"KIBANA \u003d \"kibana.yum.repo\""},{"line_number":30,"context_line":"MARIADB \u003d \"mariadb.yum.repo\""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_0ce5e207","line":27,"in_reply_to":"dab17558_11d6ba4e","updated":"2016-05-17 09:11:50.000000000","message":"+1","commit_id":"fb806d2fc182bc9e8fcb5196d8a786227d02758b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"08514e6358817323ca6bc5f06b09505de3584525","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                deprecated_group\u003d\u0027kolla-build\u0027,"},{"line_number":161,"context_line":"                help\u003d(\u0027Comma separated list of .rpm or .repo file(s) \u0027"},{"line_number":162,"context_line":"                      \u0027or URL(s) to install before building containers\u0027)),"},{"line_number":163,"context_line":"    cfg.ListOpt(\u0027global_repo_setup\u0027, default\u003d[ELASTIC_SEARCH, KIBANA, MARIADB,"},{"line_number":164,"context_line":"                                              PERCONA],"},{"line_number":165,"context_line":"                help\u003d(\u0027Comma separated list of global repos that will \u0027"},{"line_number":166,"context_line":"                      \u0027be used to install Elastic search, Kibana, \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_d14f1232","line":163,"updated":"2016-05-16 18:36:21.000000000","message":"I guess this part is ok - I just don\u0027t like the hardcodes of the repositories being mixed up in the build.py.  I also don\u0027t like how delorean is in build.py as well.  They could be stored in build.conf but I\u0027d rather see them next to the dockerfile.","commit_id":"fb806d2fc182bc9e8fcb5196d8a786227d02758b"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"c7afa5c4c9d4decd6c56629a0ca36cd05270f6e2","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                deprecated_group\u003d\u0027kolla-build\u0027,"},{"line_number":161,"context_line":"                help\u003d(\u0027Comma separated list of .rpm or .repo file(s) \u0027"},{"line_number":162,"context_line":"                      \u0027or URL(s) to install before building containers\u0027)),"},{"line_number":163,"context_line":"    cfg.ListOpt(\u0027global_repo_setup\u0027, default\u003d[ELASTIC_SEARCH, KIBANA, MARIADB,"},{"line_number":164,"context_line":"                                              PERCONA],"},{"line_number":165,"context_line":"                help\u003d(\u0027Comma separated list of global repos that will \u0027"},{"line_number":166,"context_line":"                      \u0027be used to install Elastic search, Kibana, \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_2cd1c623","line":163,"in_reply_to":"dab17558_d14f1232","updated":"2016-05-17 09:11:50.000000000","message":"+1","commit_id":"fb806d2fc182bc9e8fcb5196d8a786227d02758b"}]}