)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6f5984aca61067e4aad0b93d5e09478c4ce38d3a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- write ansible code to deploy and bootstrap the container."},{"line_number":18,"context_line":"- support injecting images/ssh keys into running container"},{"line_number":19,"context_line":"  as part of deploy/bootstrap via external config."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7d895839b11cbf916be33225875465c3358b5aa4"},{"line_number":22,"context_line":"Depends: Ifdfc935f594e29eb361ac31e8ae328744848258b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_e934d24a","line":20,"updated":"2016-05-23 00:14:49.000000000","message":"- todo add reno note\n- todo add blueprint","commit_id":"b70dea63863558e5095e01f12ef102db949a06f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"TODO:"},{"line_number":15,"context_line":"- make doc/biforst.rst and a valid rst"},{"line_number":16,"context_line":"- document how to use the container propperly"},{"line_number":17,"context_line":"- write ansible code to deploy and bootstrap the container."},{"line_number":18,"context_line":"- support injecting images/ssh keys into running container"},{"line_number":19,"context_line":"  as part of deploy/bootstrap via external config."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7d895839b11cbf916be33225875465c3358b5aa4"},{"line_number":22,"context_line":"Depends: Ifdfc935f594e29eb361ac31e8ae328744848258b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_9b229b50","line":19,"range":{"start_line":17,"start_character":2,"end_line":19,"end_character":50},"updated":"2016-07-01 00:41:29.000000000","message":"this will be move to a separate commit.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"}],"doc/bifrost.rst":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1cc6e9ff2ac34e95acc5e22264ca9ba1cc1775db","unresolved":false,"context_lines":[{"line_number":2,"context_line":"sudo mkdir -m 777 /repo"},{"line_number":3,"context_line":"cd /repo"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# clone kolla biforst poc  "},{"line_number":6,"context_line":"git clone http://github.com/openstack/kolla"},{"line_number":7,"context_line":"# fetch this review ..."},{"line_number":8,"context_line":"# https://review.openstack.org/#/c/319703"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_7a6c3235","line":5,"range":{"start_line":5,"start_character":25,"end_line":5,"end_character":27},"updated":"2016-07-06 19:16:46.000000000","message":"remove whitespace","commit_id":"079a83fc62c1ee0244aa191cfbde584e86bc1526"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1cc6e9ff2ac34e95acc5e22264ca9ba1cc1775db","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# fetch this review ..."},{"line_number":8,"context_line":"# https://review.openstack.org/#/c/319703"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"cd kolla "},{"line_number":11,"context_line":"# set up koll dependcies as normal"},{"line_number":12,"context_line":"# generate kolla build"},{"line_number":13,"context_line":"tox -e genconfig"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_da7566fa","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":9},"updated":"2016-07-06 19:16:46.000000000","message":"remove whitespace","commit_id":"079a83fc62c1ee0244aa191cfbde584e86bc1526"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1cc6e9ff2ac34e95acc5e22264ca9ba1cc1775db","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"#optionally customise your build via /tmp/bootstrap_args"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"skip_package_install: true "},{"line_number":69,"context_line":"mysql_service_name: mysql"},{"line_number":70,"context_line":"ansible_python_interpreter: /var/lib/kolla/venv/bin/python"},{"line_number":71,"context_line":"network_interface: \u003c add you network interface here \u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_ba721a0f","line":68,"range":{"start_line":68,"start_character":26,"end_line":68,"end_character":27},"updated":"2016-07-06 19:16:46.000000000","message":"remove whitespace","commit_id":"079a83fc62c1ee0244aa191cfbde584e86bc1526"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"74c58b232c6990881f238716976d8af41b5dd6af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Bifrost Guide"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_6f773802","line":1,"updated":"2016-07-21 11:19:25.000000000","message":"Add it in index.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Bifrost Guide"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_6c9c810e","line":1,"in_reply_to":"dada55a8_6f773802","updated":"2016-07-26 20:13:24.000000000","message":"oh i did not know there was an index.rst\nwill do thanks.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"dcf78bb11e7f5eefec724bace1c459e0c2a38e1e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"clone kolla"},{"line_number":10,"context_line":"-----------"},{"line_number":11,"context_line":"sudo mkdir -m 777 /repo"},{"line_number":12,"context_line":"cd /repo"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"git clone http://github.com/openstack/kolla"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_a9c66b97","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":13},"updated":"2016-07-20 21:05:51.000000000","message":"777 ??  Does it really need to be this open... and on the root of the filesystem?","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"clone kolla"},{"line_number":10,"context_line":"-----------"},{"line_number":11,"context_line":"sudo mkdir -m 777 /repo"},{"line_number":12,"context_line":"cd /repo"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"git clone http://github.com/openstack/kolla"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_8611d654","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":13},"in_reply_to":"dada55a8_a9c66b97","updated":"2016-07-26 20:13:24.000000000","message":"no in fact you could just use your current users home directory\ni just personally create a /repo folder on my dev systems.\nthis rst is based on  taking the command form my bash history so not best practice.\n\nill just remove this and the next line.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e03708605a5fff696d394bcec93f1b0c09736ead","unresolved":false,"context_lines":[{"line_number":11,"context_line":"sudo mkdir -m 777 /repo"},{"line_number":12,"context_line":"cd /repo"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"git clone http://github.com/openstack/kolla"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"cd kolla"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_04fc9a3c","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":16},"updated":"2016-07-21 13:44:27.000000000","message":"Users should ideally clone with HTTPS instead of HTTP as HTTPS provides some level of server verification","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":11,"context_line":"sudo mkdir -m 777 /repo"},{"line_number":12,"context_line":"cd /repo"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"git clone http://github.com/openstack/kolla"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"cd kolla"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_062cc697","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":16},"in_reply_to":"dada55a8_04fc9a3c","updated":"2016-07-26 20:13:24.000000000","message":"yes you are correct.\nill update this.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e03708605a5fff696d394bcec93f1b0c09736ead","unresolved":false,"context_lines":[{"line_number":16,"context_line":"cd kolla"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set up kolla dependcies `doc`:quickstart.rst"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"fix hosts file"},{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"docker bind mount /etc/hosts into the container from a volumn."}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_84b52a7f","line":19,"updated":"2016-07-21 13:44:27.000000000","message":"Not a kolla user, but wouldn\u0027t the above commands of making a folder, cloning the repo, etc be covered in the quickstart?","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":16,"context_line":"cd kolla"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"set up kolla dependcies `doc`:quickstart.rst"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"fix hosts file"},{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"docker bind mount /etc/hosts into the container from a volumn."}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_26eaaa0f","line":19,"in_reply_to":"dada55a8_84b52a7f","updated":"2016-07-26 20:13:24.000000000","message":"yes it would the location where you keep the repo is not important.\n\nin the first version of this file i was using patches version of bifrost so it was simpler to tell people to place it in a specific location as it was easier to refer too later.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"74c58b232c6990881f238716976d8af41b5dd6af","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"fix hosts file"},{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"docker bind mount /etc/hosts into the container from a volumn."},{"line_number":23,"context_line":"this prevent atomic renames which will prevent ansible from fixing"},{"line_number":24,"context_line":"the /etc/host file automatically."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_6f49f8cf","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":28},"updated":"2016-07-21 11:19:25.000000000","message":"``/etc/hosts``","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"74c58b232c6990881f238716976d8af41b5dd6af","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"fix hosts file"},{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"docker bind mount /etc/hosts into the container from a volumn."},{"line_number":23,"context_line":"this prevent atomic renames which will prevent ansible from fixing"},{"line_number":24,"context_line":"the /etc/host file automatically."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_6fe578a6","line":22,"range":{"start_line":22,"start_character":55,"end_line":22,"end_character":61},"updated":"2016-07-21 11:19:25.000000000","message":"volume?","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e03708605a5fff696d394bcec93f1b0c09736ead","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"fix hosts file"},{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"docker bind mount /etc/hosts into the container from a volumn."},{"line_number":23,"context_line":"this prevent atomic renames which will prevent ansible from fixing"},{"line_number":24,"context_line":"the /etc/host file automatically."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_78ca5a1c","line":22,"range":{"start_line":22,"start_character":55,"end_line":22,"end_character":61},"in_reply_to":"dada55a8_6fe578a6","updated":"2016-07-21 13:44:27.000000000","message":"Might also be helpful to explicitly include example commands.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"fix hosts file"},{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"docker bind mount /etc/hosts into the container from a volumn."},{"line_number":23,"context_line":"this prevent atomic renames which will prevent ansible from fixing"},{"line_number":24,"context_line":"the /etc/host file automatically."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_c6be2ead","line":22,"range":{"start_line":22,"start_character":55,"end_line":22,"end_character":61},"in_reply_to":"dada55a8_78ca5a1c","updated":"2016-07-26 20:13:24.000000000","message":"@mauricio yep ill fix that in next version thanks\n@ julia\nthe bind mounting is built into docker so you dont have to run any command to do it.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"74c58b232c6990881f238716976d8af41b5dd6af","unresolved":false,"context_lines":[{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"docker bind mount /etc/hosts into the container from a volumn."},{"line_number":23,"context_line":"this prevent atomic renames which will prevent ansible from fixing"},{"line_number":24,"context_line":"the /etc/host file automatically."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"to enable bifrost to be bootstrapped correctly"},{"line_number":27,"context_line":"add hostname to 127.0.0.1 line"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_2f58a087","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":13},"updated":"2016-07-21 11:19:25.000000000","message":"``/etc/host``","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e03708605a5fff696d394bcec93f1b0c09736ead","unresolved":false,"context_lines":[{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"docker bind mount /etc/hosts into the container from a volumn."},{"line_number":23,"context_line":"this prevent atomic renames which will prevent ansible from fixing"},{"line_number":24,"context_line":"the /etc/host file automatically."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"to enable bifrost to be bootstrapped correctly"},{"line_number":27,"context_line":"add hostname to 127.0.0.1 line"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_f8b3ea95","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":13},"in_reply_to":"dada55a8_2f58a087","updated":"2016-07-21 13:44:27.000000000","message":"So speaking of renames, inline open file edits should be permitted, unless something has changed in the last year or so.  I seem to remember running into this before and fixing the install playbook\u0027s behavior such that it didn\u0027t try to replace the hosts file.\n\nTL;DR this sounds like a bug in bifrost\u0027s behavior more than anything else.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"docker bind mount /etc/hosts into the container from a volumn."},{"line_number":23,"context_line":"this prevent atomic renames which will prevent ansible from fixing"},{"line_number":24,"context_line":"the /etc/host file automatically."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"to enable bifrost to be bootstrapped correctly"},{"line_number":27,"context_line":"add hostname to 127.0.0.1 line"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_0695e631","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":13},"in_reply_to":"dada55a8_f8b3ea95","updated":"2016-07-26 20:13:24.000000000","message":"actually this is here explicitly because of these lines in biforst\nhttps://github.com/openstack/bifrost/blob/12b926ab4e1add7f7e1f5ba5ceb7d3d11b6fc69d/playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml#L32-L40\n\ni tried a couple of different methods to update the /etc/hosts file but i could not find one that working in a docker container.\n\nso basiclal im discribing how to make the \n\"RabbitMQ - Testing if hostname is defined in /etc/hosts\" task pass so that the failing \"RabbitMQ - Fixing /etc/hosts\" task is not run when you bootstrap the container.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"dcf78bb11e7f5eefec724bace1c459e0c2a38e1e","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"modify kolla-build.conf as follows."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"set install_type to source"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"build container"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_49124f0a","line":50,"range":{"start_line":50,"start_character":20,"end_line":50,"end_character":26},"updated":"2016-07-20 21:05:51.000000000","message":"kolla-build .. -t source , is enough for this?  Doesn\u0027t need to be a config change.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"modify kolla-build.conf as follows."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"set install_type to source"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"build container"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_267aaaf1","line":50,"range":{"start_line":50,"start_character":20,"end_line":50,"end_character":26},"in_reply_to":"dada55a8_49124f0a","updated":"2016-07-26 20:13:24.000000000","message":"yes that is true though in general i think we have been moving away form the commandline flags in favor of the config.\n\nill list both options though thanks.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"dcf78bb11e7f5eefec724bace1c459e0c2a38e1e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"build container"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"tools/build.py bifrost-deploy"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"launch bifrost"},{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_a922eb4f","line":55,"range":{"start_line":55,"start_character":22,"end_line":55,"end_character":23},"updated":"2016-07-20 21:05:51.000000000","message":"This should also work:\n$ kolla-build -t source bitfrost-deploy","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":52,"context_line":"build container"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"tools/build.py bifrost-deploy"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"launch bifrost"},{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_465cfe7c","line":55,"range":{"start_line":55,"start_character":22,"end_line":55,"end_character":23},"in_reply_to":"dada55a8_a922eb4f","updated":"2016-07-26 20:13:24.000000000","message":"yes it would if you installed kolla system wide.\n\nill list both. for a development setup kolla-build will now be available.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"d36dd1f89820df7c17ff23c13eaa9e7d832e6e0a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# source env variables"},{"line_number":77,"context_line":"cd /bifrost"},{"line_number":78,"context_line":". env-vars"},{"line_number":79,"context_line":". /opt/stack/ansible/hacking/env-setup"},{"line_number":80,"context_line":"cd playbooks/"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_b28b7467","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":38},"updated":"2016-07-20 22:46:35.000000000","message":"If it would be useful for you to have, we can pick up https://review.openstack.org/#/c/329191/ so you can set the install location. You may also want to have a look at the virtualenv install we support (which is documented in the readme).","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":76,"context_line":"# source env variables"},{"line_number":77,"context_line":"cd /bifrost"},{"line_number":78,"context_line":". env-vars"},{"line_number":79,"context_line":". /opt/stack/ansible/hacking/env-setup"},{"line_number":80,"context_line":"cd playbooks/"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_26bd8a68","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":38},"in_reply_to":"dada55a8_b28b7467","updated":"2016-07-26 20:13:24.000000000","message":"actully i taught i was using the venv support let me double check. i may have reverted from using it.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"d36dd1f89820df7c17ff23c13eaa9e7d832e6e0a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"--------------------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    skip_package_install: true"},{"line_number":87,"context_line":"    mysql_service_name: mysql"},{"line_number":88,"context_line":"    ansible_python_interpreter: /var/lib/kolla/venv/bin/python"},{"line_number":89,"context_line":"    network_interface: \u003c add you network interface here \u003e"},{"line_number":90,"context_line":"    # uncomment below if needed"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_124fe06b","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":29},"updated":"2016-07-20 22:46:35.000000000","message":"I would let bifrost set this unless you know you\u0027re always using mysql vs mariadb. Also in the dockerfile you say you\u0027re always using mariadb, so this seems wrong anyway.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":84,"context_line":"--------------------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    skip_package_install: true"},{"line_number":87,"context_line":"    mysql_service_name: mysql"},{"line_number":88,"context_line":"    ansible_python_interpreter: /var/lib/kolla/venv/bin/python"},{"line_number":89,"context_line":"    network_interface: \u003c add you network interface here \u003e"},{"line_number":90,"context_line":"    # uncomment below if needed"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_c9291f9d","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":29},"in_reply_to":"dada55a8_124fe06b","updated":"2016-07-26 20:13:24.000000000","message":"i think the bootstrap was filing for me on centos without setting this but ill test it again.\n\nif my memory serves, the mariadb developers encouraged packager not to create a separate mariadb service file, this would allow the mariadb package to be dropped in in place of mysql without requiring scripts to be updated to account for a new service name.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e03708605a5fff696d394bcec93f1b0c09736ead","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Known issues"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"by default ssh is installed in the image but maybot be enable."},{"line_number":173,"context_line":"if you encounter this issue you will have to acess the server phyically in recovery mode to enable the ssh service."},{"line_number":174,"context_line":"if your hardware supports it, this can be done remotely with ipmitool and serial over lan."},{"line_number":175,"context_line":"ipmitool -I lanplus -H 192.168.1.30 -U admin -P root sol activate"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_fb44844a","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":2},"updated":"2016-07-21 13:44:27.000000000","message":"nit:   s/enable./enabled./","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"dcf78bb11e7f5eefec724bace1c459e0c2a38e1e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"Known issues"},{"line_number":170,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"by default ssh is installed in the image but maybot be enable."},{"line_number":173,"context_line":"if you encounter this issue you will have to acess the server phyically in recovery mode to enable the ssh service."},{"line_number":174,"context_line":"if your hardware supports it, this can be done remotely with ipmitool and serial over lan."},{"line_number":175,"context_line":"ipmitool -I lanplus -H 192.168.1.30 -U admin -P root sol activate"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_29d55b1b","line":172,"range":{"start_line":172,"start_character":45,"end_line":172,"end_character":51},"updated":"2016-07-20 21:05:51.000000000","message":"s/maybot/maynot","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e03708605a5fff696d394bcec93f1b0c09736ead","unresolved":false,"context_lines":[{"line_number":174,"context_line":"if your hardware supports it, this can be done remotely with ipmitool and serial over lan."},{"line_number":175,"context_line":"ipmitool -I lanplus -H 192.168.1.30 -U admin -P root sol activate"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_5bd6704f","line":177,"updated":"2016-07-21 13:44:27.000000000","message":"nit: I can\u0027t help but wonder if it would help to link over the bifrost\u0027s develope r docs as well so a user needing additional context can seek it out.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":174,"context_line":"if your hardware supports it, this can be done remotely with ipmitool and serial over lan."},{"line_number":175,"context_line":"ipmitool -I lanplus -H 192.168.1.30 -U admin -P root sol activate"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_b7e1a62c","line":177,"in_reply_to":"dada55a8_5bd6704f","updated":"2016-07-26 20:13:24.000000000","message":"yes that would definetly help\nill add a link to http://docs.openstack.org/developer/bifrost/\nor should i link to the github repo\nhttps://github.com/openstack/bifrost\n\ni tend to read the raw rst files rather then the rendered docs but the docs.openstack.org link might be friendlier.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"}],"docker/bifrost/bifrost-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f5c344e27dc43597a202a35269fb71d3762eb61e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"RUN ln -s bifrost-base-source/* bifrost \\"},{"line_number":7,"context_line":"    \u0026\u0026 useradd --user-group bifrost \\"},{"line_number":8,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /bifrost \\"},{"line_number":9,"context_line":"    \u0026\u0026 mkdir -p /etc/bifrost /home/bifrost \\"},{"line_number":10,"context_line":"    \u0026\u0026 chown -R bifrost: /etc/bifrost /home/bifrost"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"WORKDIR /bifrost"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_3b2d71fe","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":42},"updated":"2016-06-30 19:51:05.000000000","message":"Create and chown home for bifrost is not necessary when uses useradd --user-group","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"RUN ln -s bifrost-base-source/* bifrost \\"},{"line_number":7,"context_line":"    \u0026\u0026 useradd --user-group bifrost \\"},{"line_number":8,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /bifrost \\"},{"line_number":9,"context_line":"    \u0026\u0026 mkdir -p /etc/bifrost /home/bifrost \\"},{"line_number":10,"context_line":"    \u0026\u0026 chown -R bifrost: /etc/bifrost /home/bifrost"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"WORKDIR /bifrost"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_5b3f9386","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":42},"in_reply_to":"3aaa91ec_3b2d71fe","updated":"2016-07-01 00:41:29.000000000","message":"ok i will remove in next version.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f5c344e27dc43597a202a35269fb71d3762eb61e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml -e @/tmp/build_arg.yml\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_5b5b1d86","line":17,"range":{"start_line":17,"start_character":32,"end_line":17,"end_character":36},"updated":"2016-06-30 19:51:05.000000000","message":"Is nano package necessary?","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"06a84362ae5e1317d299e8370186298f248ef92e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml -e @/tmp/build_arg.yml\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_ac43df40","line":17,"updated":"2016-07-01 02:19:26.000000000","message":"epel-release is installed on in the base image.\n\nadd yum clean add the end to clean the image cache.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml -e @/tmp/build_arg.yml\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_dbe54338","line":17,"range":{"start_line":17,"start_character":32,"end_line":17,"end_character":36},"in_reply_to":"3aaa91ec_5b5b1d86","updated":"2016-07-01 00:41:29.000000000","message":"nope not at all i just cant stand vi and im using it for debuging and manual testing.\nill remove it when i remove the WIP tag from the commit.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3406210c0d20a786c93bfb03ceb6953dc3cd6cea","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml -e @/tmp/build_arg.yml\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_8cb887c9","line":17,"in_reply_to":"3aaa91ec_ac43df40","updated":"2016-07-01 13:13:02.000000000","message":"yep you are right.\nwhen i remove the install of nano this line will be empthy so i will just remove this branch of the if entirly.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f5c344e27dc43597a202a35269fb71d3762eb61e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_dbf54d51","line":19,"range":{"start_line":19,"start_character":65,"end_line":19,"end_character":66},"updated":"2016-06-30 19:51:05.000000000","message":"Better use double ampersand with line jumps","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"055197f3edd5872712feb46a589e5e5e717c55f5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1aa78d24_86f972cb","line":19,"updated":"2016-07-03 08:14:54.000000000","message":"check this for the  semicolon vs \u0026\u0026\n\n\n# Dockerfile\nFROM ubuntu:14.04\n\nRUN false; echo a\nRUN false \u0026\u0026 echo a\n\nBuilt this file: docker build . you will see the first RUN seccessfully and the second failed.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"06a84362ae5e1317d299e8370186298f248ef92e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_8c3ee3b5","line":19,"updated":"2016-07-01 02:19:26.000000000","message":"the mysql-server is never installed.\nadd --no-install-recommends when using apt-get install\n\nabout the semicolon, please check http://unix.stackexchange.com/questions/187145/whats-the-difference-between-semicolon-and-double-ampersand","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ee658cff3e1f54ca86b52c3094b3fd85f1cb71f3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1aa78d24_a63560db","line":19,"in_reply_to":"1aa78d24_86f972cb","updated":"2016-07-04 18:30:17.000000000","message":"yes i know i want the first behavior.\n\ni intentionally did not want the execution of auto remove and auto clean to be conditional.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3406210c0d20a786c93bfb03ceb6953dc3cd6cea","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_4c9a1f70","line":19,"in_reply_to":"3aaa91ec_8c3ee3b5","updated":"2016-07-01 13:13:02.000000000","message":"my sql is installed by the bifrost playbook but only on ubuntu\n\nmariadb is used by default on redhat based distros.\n\nas for the semicolon i know what the difference is between \u0026\u0026 and ; is in bash in terms of conditional execution what i don\u0027t understand is why it would better to use a \u0026\u0026 vs ; when you have a line continuation whcih is why Eduardo Gonxalez originally suggest the change.\n\nthe reason i am not useing \u0026\u0026 currently is that if bifrost every change the default on deabian based distros to use mariadb i dont want this code to fail hence why i am using ;\n\n\ni should however move the autoclean  and autoremove to the end so it removes the deb packages for mariadb also.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_fb62bfab","line":19,"range":{"start_line":19,"start_character":65,"end_line":19,"end_character":66},"in_reply_to":"3aaa91ec_dbf54d51","updated":"2016-07-01 00:41:29.000000000","message":"really why would \u0026\u0026 have any inpact on split lines?","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f5c344e27dc43597a202a35269fb71d3762eb61e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"RUN yum install -y epel-release nano"},{"line_number":18,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":19,"context_line":"RUN apt-get remove --purge mysql-server mysql-client mysql-common; apt-get autoremove; \\"},{"line_number":20,"context_line":"    apt-get autoclean; apt-get install -y mariadb-server openssh-client nano"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"COPY bifrost_sudoers /etc/sudoers.d/bifrost_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_fb4c89c9","line":20,"range":{"start_line":20,"start_character":72,"end_line":20,"end_character":76},"updated":"2016-06-30 19:51:05.000000000","message":"DITO","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"06a84362ae5e1317d299e8370186298f248ef92e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"RUN usermod -a -G kolla bifrost \\"},{"line_number":27,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":28,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/bifrost_sudoers \\"},{"line_number":29,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_bifrost_extend_start \\"},{"line_number":30,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_bifrost_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_ec496761","line":29,"updated":"2016-07-01 02:19:26.000000000","message":"the kolla_bifrost_extend_start is empty, no need add this.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3406210c0d20a786c93bfb03ceb6953dc3cd6cea","unresolved":false,"context_lines":[{"line_number":26,"context_line":"RUN usermod -a -G kolla bifrost \\"},{"line_number":27,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":28,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/bifrost_sudoers \\"},{"line_number":29,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_bifrost_extend_start \\"},{"line_number":30,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_bifrost_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_8cc9a728","line":29,"in_reply_to":"3aaa91ec_ec496761","updated":"2016-07-01 13:13:02.000000000","message":"originally i was going to use this to do some bootstrapping but since i am starting /sbin/init this is not need so yes ill remove. thanks","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"62065a2d25224b7b08da938a64ff7f4639e81acf","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"WORKDIR /bifrost"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# NOTE(sean-k-mooney): bifrost by default installs MySQL on debian based systems."},{"line_number":16,"context_line":"#                      here we explcitly remove it and replace it with mariadb"},{"line_number":17,"context_line":"#                      in the same RUN to prevent it form being commited to the layer."},{"line_number":18,"context_line":"RUN bash -c \u0027./scripts/env-setup.sh \u0026\u0026 source ./env-vars \u0026\u0026 source /opt/stack/ansible/hacking/env-setup \u0026\u0026 \\"},{"line_number":19,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml \\"},{"line_number":20,"context_line":"    -e @/tmp/build_arg.yml -e  @/tmp/build_arg_source.yml\u0027 \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3aaa91ec_5d23dcbe","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":86},"updated":"2016-07-01 18:13:37.000000000","message":"You could redefine required_packages and mysql_service_name in your build_arg.yml file instead, which might be a little less kludgy. On the bifrost side, the database packages could be split out into a separate list to make this cleaner, too.","commit_id":"079a83fc62c1ee0244aa191cfbde584e86bc1526"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"5782c0b782b7cef7a3a60f5d52f1a306b46a11d6","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"WORKDIR /bifrost"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# NOTE(sean-k-mooney): bifrost by default installs MySQL on debian based systems."},{"line_number":16,"context_line":"#                      here we explcitly remove it and replace it with mariadb"},{"line_number":17,"context_line":"#                      in the same RUN to prevent it form being commited to the layer."},{"line_number":18,"context_line":"RUN bash -c \u0027./scripts/env-setup.sh \u0026\u0026 source ./env-vars \u0026\u0026 source /opt/stack/ansible/hacking/env-setup \u0026\u0026 \\"},{"line_number":19,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml \\"},{"line_number":20,"context_line":"    -e @/tmp/build_arg.yml -e  @/tmp/build_arg_source.yml\u0027 \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1aa78d24_7f5c69ed","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":86},"in_reply_to":"1aa78d24_460f5c2e","updated":"2016-07-05 17:10:25.000000000","message":"Redhat and derivatives switched to using mariadb as the default database a while back, whereas mysql is still the default on the debian/ubuntu side. So we\u0027re just following what those distros are doing.\n\nWe can help you debug the issues with mysql startup in the container if you like. I feel like you should either fix the underlying issue, or at least address it in a comment, rather than introducing nonstandard behaviour silently.","commit_id":"079a83fc62c1ee0244aa191cfbde584e86bc1526"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ce9d2c56104580fd9a624bbd0e4ef900b47f0297","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"WORKDIR /bifrost"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# NOTE(sean-k-mooney): bifrost by default installs MySQL on debian based systems."},{"line_number":16,"context_line":"#                      here we explcitly remove it and replace it with mariadb"},{"line_number":17,"context_line":"#                      in the same RUN to prevent it form being commited to the layer."},{"line_number":18,"context_line":"RUN bash -c \u0027./scripts/env-setup.sh \u0026\u0026 source ./env-vars \u0026\u0026 source /opt/stack/ansible/hacking/env-setup \u0026\u0026 \\"},{"line_number":19,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml \\"},{"line_number":20,"context_line":"    -e @/tmp/build_arg.yml -e  @/tmp/build_arg_source.yml\u0027 \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1aa78d24_460f5c2e","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":86},"in_reply_to":"3aaa91ec_5d23dcbe","updated":"2016-07-04 18:37:55.000000000","message":"hi yes i was going to submit a patch to do something similar separately. i had been meaning to ask why mysql was used on ubuntu/debian instead of mariadb which is used on redhat et al.\n\ni did not want to make this depend on that patch to bifrost.\n\nthe reason i made this change by the way is i could not start the mysql server inside the container and i could not find any error in any log.\n\nusing maria db instead worked without any issues.\n\nthe if on line 21-26 would still be required if this change was made to bifrost unless we also modified bifrost to run autoremove/clean/yum clean all  or the downloaded binaries would be stored i the docker layer.","commit_id":"079a83fc62c1ee0244aa191cfbde584e86bc1526"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"d36dd1f89820df7c17ff23c13eaa9e7d832e6e0a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"WORKDIR /bifrost"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# NOTE(sean-k-mooney): bifrost by default installs MySQL on debian based systems."},{"line_number":16,"context_line":"#                      here we explcitly remove it and replace it with mariadb"},{"line_number":17,"context_line":"#                      in the same RUN to prevent it form being commited to the layer."},{"line_number":18,"context_line":"RUN bash -c \u0027./scripts/env-setup.sh \u0026\u0026 source ./env-vars \u0026\u0026 source /opt/stack/ansible/hacking/env-setup \u0026\u0026 \\"},{"line_number":19,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml \\"},{"line_number":20,"context_line":"    -e @/tmp/build_arg.yml -e  @/tmp/build_arg_source.yml\u0027 \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_7d40ad34","line":17,"range":{"start_line":15,"start_character":23,"end_line":17,"end_character":86},"updated":"2016-07-20 22:46:35.000000000","message":"Please mention why you\u0027re replacing with mariadb \u0026 file a bug with bifrost with enough information to help us reproduce it, as previously suggested. Then you can reference that bug number here.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"WORKDIR /bifrost"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# NOTE(sean-k-mooney): bifrost by default installs MySQL on debian based systems."},{"line_number":16,"context_line":"#                      here we explcitly remove it and replace it with mariadb"},{"line_number":17,"context_line":"#                      in the same RUN to prevent it form being commited to the layer."},{"line_number":18,"context_line":"RUN bash -c \u0027./scripts/env-setup.sh \u0026\u0026 source ./env-vars \u0026\u0026 source /opt/stack/ansible/hacking/env-setup \u0026\u0026 \\"},{"line_number":19,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml \\"},{"line_number":20,"context_line":"    -e @/tmp/build_arg.yml -e  @/tmp/build_arg_source.yml\u0027 \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_8ccf3555","line":17,"range":{"start_line":15,"start_character":23,"end_line":17,"end_character":86},"in_reply_to":"dada55a8_788b7a1f","updated":"2016-07-26 20:13:24.000000000","message":"actully the bug could have been related to upstart issue i was having at the time.\n\nbasically i was not able to start the mysql service inside the container and there was not log output that i could find to indicate any error.\n\nwhen i uninstalled mysql and istalled mariadb it just worked.\n\nnow that i have tweeked upstart to work correctly the original mysql package might work but i have not tested it since.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e03708605a5fff696d394bcec93f1b0c09736ead","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"WORKDIR /bifrost"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# NOTE(sean-k-mooney): bifrost by default installs MySQL on debian based systems."},{"line_number":16,"context_line":"#                      here we explcitly remove it and replace it with mariadb"},{"line_number":17,"context_line":"#                      in the same RUN to prevent it form being commited to the layer."},{"line_number":18,"context_line":"RUN bash -c \u0027./scripts/env-setup.sh \u0026\u0026 source ./env-vars \u0026\u0026 source /opt/stack/ansible/hacking/env-setup \u0026\u0026 \\"},{"line_number":19,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml \\"},{"line_number":20,"context_line":"    -e @/tmp/build_arg.yml -e  @/tmp/build_arg_source.yml\u0027 \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_788b7a1f","line":17,"range":{"start_line":15,"start_character":23,"end_line":17,"end_character":86},"in_reply_to":"dada55a8_7d40ad34","updated":"2016-07-21 13:44:27.000000000","message":"Agreed, it seems like it would be relatively easy for us to give a user a choice over which they wish to utilize.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#                      in the same RUN to prevent it form being commited to the layer."},{"line_number":18,"context_line":"RUN bash -c \u0027./scripts/env-setup.sh \u0026\u0026 source ./env-vars \u0026\u0026 source /opt/stack/ansible/hacking/env-setup \u0026\u0026 \\"},{"line_number":19,"context_line":"    ansible-playbook -vvvv -i /bifrost/playbooks/inventory/localhost /bifrost/playbooks/install.yaml \\"},{"line_number":20,"context_line":"    -e @/tmp/build_arg.yml -e  @/tmp/build_arg_source.yml\u0027 \u0026\u0026 \\"},{"line_number":21,"context_line":"{% if base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":22,"context_line":"    apt-get purge mysql-server mysql-client mysql-common; \\"},{"line_number":23,"context_line":"    apt-get -y install mariadb-server openssh-client; apt-get clean"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_6c57615a","line":20,"range":{"start_line":20,"start_character":27,"end_line":20,"end_character":57},"updated":"2016-07-26 20:13:24.000000000","message":"this file is never created.\ni need to check if this should have been deleted or did i forget to add a file to the commit...","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e03708605a5fff696d394bcec93f1b0c09736ead","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    -e @/tmp/build_arg.yml -e  @/tmp/build_arg_source.yml\u0027 \u0026\u0026 \\"},{"line_number":21,"context_line":"{% if base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":22,"context_line":"    apt-get purge mysql-server mysql-client mysql-common; \\"},{"line_number":23,"context_line":"    apt-get -y install mariadb-server openssh-client; apt-get clean"},{"line_number":24,"context_line":"{% else %}"},{"line_number":25,"context_line":"    yum clean all"},{"line_number":26,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_38dbc21c","line":23,"range":{"start_line":23,"start_character":38,"end_line":23,"end_character":52},"updated":"2016-07-21 13:44:27.000000000","message":"Out of curiosity, What is the reason for the openssh-client in the container?","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2bb6d367752e75713859e6fc405b050012d1388","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    -e @/tmp/build_arg.yml -e  @/tmp/build_arg_source.yml\u0027 \u0026\u0026 \\"},{"line_number":21,"context_line":"{% if base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":22,"context_line":"    apt-get purge mysql-server mysql-client mysql-common; \\"},{"line_number":23,"context_line":"    apt-get -y install mariadb-server openssh-client; apt-get clean"},{"line_number":24,"context_line":"{% else %}"},{"line_number":25,"context_line":"    yum clean all"},{"line_number":26,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_4cad3d9a","line":23,"range":{"start_line":23,"start_character":38,"end_line":23,"end_character":52},"in_reply_to":"dada55a8_38dbc21c","updated":"2016-07-26 20:13:24.000000000","message":"2 reasons \n\n1st it pulls in ssh-keygen on debian/ubuntu systems which is need to generate the ironic key\nhttps://github.com/openstack/bifrost/blob/12b926ab4e1add7f7e1f5ba5ceb7d3d11b6fc69d/playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml#L150-L154\n\nbifrost assumes ssh-keygen is available on the system but its not included in the ubuntu 14.04 conatienr.\n\nsecond the bifrost container is expectd to be used by executing into the container and executing the biforst to playbooks to enroll and deploy servers. when the deploy succeeds it useful to have the the openssh-client to test network connectivity to the deployed servers.\n\nopenssh-client and ssh-keygen are already present in the centos bas container so it is only need for ubuntu/debian.","commit_id":"b957482dac92edfb55e2f43eb2d2382a375d8de3"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"7bf8e05c5b4ec7a27f969d72f00d3a90983bb8e4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"# TODO(sean-k-mooney): add binary install logic."},{"line_number":6,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":7,"context_line":"ADD bifrost-base-archive /bifrost-base-source"},{"line_number":8,"context_line":"COPY build_arg.yml /tmp/build_arg.yml"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_9cd907f6","line":5,"updated":"2016-08-23 19:41:38.000000000","message":"raise error that binary is not supported here plz","commit_id":"c0bf1c164e788a293876df0a5b2a2e014168b56d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ae2dc6b4a6ecc844dade8ec57f11245c64ac959","unresolved":false,"context_lines":[{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"# TODO(sean-k-mooney): add binary install logic."},{"line_number":6,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":7,"context_line":"ADD bifrost-base-archive /bifrost-base-source"},{"line_number":8,"context_line":"COPY build_arg.yml /tmp/build_arg.yml"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_e7a4e84b","line":5,"in_reply_to":"1ac06dbe_9cd907f6","updated":"2016-08-23 19:53:45.000000000","message":"ok will do.\nill add it to the exceptions list for the binary builds too.","commit_id":"c0bf1c164e788a293876df0a5b2a2e014168b56d"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"2becbcbd3755c5b9a9427d4aad39f493e842e195","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fa7ab95a_bf2bc593","line":45,"updated":"2016-08-31 09:26:07.000000000","message":"lines 43/44 not needed","commit_id":"c60e91c19876643a23bff5ca22bc68247418e74b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1e3e8712540853a3d9e2e43b7c625c44920abfc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fa7ab95a_4a459515","line":45,"in_reply_to":"fa7ab95a_bf2bc593","updated":"2016-08-31 09:27:24.000000000","message":"oh yes you are right the base files should not have the main footer.\nill fix this thanks","commit_id":"c60e91c19876643a23bff5ca22bc68247418e74b"}],"docker/bifrost/bifrost-base/build_arg.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"create_image_via_dib: false"},{"line_number":5,"context_line":"bifrost_venv_dir: \"/var/lib/kolla/venv\""},{"line_number":6,"context_line":"enable_venv: true"},{"line_number":7,"context_line":"ansible_python_interpreter: /var/lib/kolla/venv/bin/python"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3aaa91ec_7bcb6f72","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":58},"updated":"2016-07-01 00:41:29.000000000","message":"TODO: remove this from here and conditional add it on the command line with -e if it is a source install.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"}],"docker/bifrost/bifrost-base/extend_start.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ! -d \"/var/log/kolla/bifrost\" ]]; then"},{"line_number":4,"context_line":"    mkdir -p /var/log/kolla/bifrost"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"if [[ $(stat -c %a /var/log/kolla/bifrost) !\u003d \"755\" ]]; then"},{"line_number":7,"context_line":"    chmod 755 /var/log/kolla/bifrost"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"source /usr/local/bin/kolla_bifrost_extend_start"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3aaa91ec_5ba9538f","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":2},"updated":"2016-07-01 00:41:29.000000000","message":"this is not needed due to how bifrost works.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"}],"docker/bifrost/bifrost-deploy/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f5c344e27dc43597a202a35269fb71d3762eb61e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ADD init-fake.conf /etc/init/fake-container-events.conf"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# undo some leet hax of the base image"},{"line_number":22,"context_line":"RUN rm /usr/sbin/policy-rc.d; \\"},{"line_number":23,"context_line":"\trm /sbin/initctl; dpkg-divert --rename --remove /sbin/initctl"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# generate a nice UTF-8 locale for our use"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_2d4a5855","line":22,"range":{"start_line":22,"start_character":28,"end_line":22,"end_character":29},"updated":"2016-06-30 19:51:05.000000000","message":"DITO","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ADD init-fake.conf /etc/init/fake-container-events.conf"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# undo some leet hax of the base image"},{"line_number":22,"context_line":"RUN rm /usr/sbin/policy-rc.d; \\"},{"line_number":23,"context_line":"\trm /sbin/initctl; dpkg-divert --rename --remove /sbin/initctl"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# generate a nice UTF-8 locale for our use"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_dbab8373","line":22,"range":{"start_line":22,"start_character":28,"end_line":22,"end_character":29},"in_reply_to":"3aaa91ec_2d4a5855","updated":"2016-07-01 00:41:29.000000000","message":"i do not want the execution of the removal to be conditional on the previous removal","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f5c344e27dc43597a202a35269fb71d3762eb61e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\trm /sbin/initctl; dpkg-divert --rename --remove /sbin/initctl"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# generate a nice UTF-8 locale for our use"},{"line_number":26,"context_line":"RUN locale-gen en_US.UTF-8 \u0026\u0026 update-locale LANG\u003den_US.UTF-8"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# remove some pointless services"},{"line_number":29,"context_line":"RUN /usr/sbin/update-rc.d -f ondemand remove; \\"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_2dbd3802","line":26,"range":{"start_line":26,"start_character":27,"end_line":26,"end_character":60},"updated":"2016-06-30 19:51:05.000000000","message":"Please, add it in a new jumpline","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\trm /sbin/initctl; dpkg-divert --rename --remove /sbin/initctl"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# generate a nice UTF-8 locale for our use"},{"line_number":26,"context_line":"RUN locale-gen en_US.UTF-8 \u0026\u0026 update-locale LANG\u003den_US.UTF-8"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# remove some pointless services"},{"line_number":29,"context_line":"RUN /usr/sbin/update-rc.d -f ondemand remove; \\"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_bb6f975e","line":26,"range":{"start_line":26,"start_character":27,"end_line":26,"end_character":60},"in_reply_to":"3aaa91ec_2dbd3802","updated":"2016-07-01 00:41:29.000000000","message":"why they should generally be avoided unless absolutly required.\n\nwasting vertical space with needless new lines is really hard to read as you have scroll.\n\nim honestly tempted to condense lines 31 to 42 when i remove the hard tabs.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4301f12fc385b01a92926037b25d58145003e57e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\techo \u0027# /lib/init/fstab: cleared out for bare-bones Docker\u0027 \u003e /lib/init/fstab"},{"line_number":47,"context_line":"{% endif %}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"RUN pip install -U ansible"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":52,"context_line":"RUN yum install -y e2fsprogs \u0026\u0026 yum clean all"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_3be9e77f","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":26},"updated":"2016-07-01 00:47:50.000000000","message":"this is not needed in a source install as it will be installed by bifrost in a virtual env that should used instead.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f5c344e27dc43597a202a35269fb71d3762eb61e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"RUN pip install -U ansible"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":52,"context_line":"RUN yum install -y e2fsprogs \u0026\u0026 yum clean all"},{"line_number":53,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":54,"context_line":"RUN apt-get install -y e2fsprogs \u0026\u0026 apt-get autoclean"},{"line_number":55,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_6d3900a4","line":52,"range":{"start_line":52,"start_character":29,"end_line":52,"end_character":45},"updated":"2016-06-30 19:51:05.000000000","message":"DITO","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f5c344e27dc43597a202a35269fb71d3762eb61e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":52,"context_line":"RUN yum install -y e2fsprogs \u0026\u0026 yum clean all"},{"line_number":53,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":54,"context_line":"RUN apt-get install -y e2fsprogs \u0026\u0026 apt-get autoclean"},{"line_number":55,"context_line":"{% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"CMD [ \"/sbin/init\" ]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3aaa91ec_cd48f42f","line":54,"range":{"start_line":54,"start_character":33,"end_line":54,"end_character":53},"updated":"2016-06-30 19:51:05.000000000","message":"DITO","commit_id":"99481189660110dc0b46080b8048132eb12b4155"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"7bf8e05c5b4ec7a27f969d72f00d3a90983bb8e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# TODO(sean-k-mooney): add ubuntu to list when Ubuntu 16.04 is supported."},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027debian\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN bash -c \u0027 $(cd /lib/systemd/system/sysinit.target.wants/; for i in *; do [ \\\"$i\\\" \u003d\u003d \\\"systemd-tmpfiles-setup.service\\\" ] || rm -f $i; done); \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_07e78440","line":7,"updated":"2016-08-23 19:41:38.000000000","message":"it already is:)","commit_id":"c0bf1c164e788a293876df0a5b2a2e014168b56d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f143d66d359af1f5d0bc8cca98abe991135609da","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# TODO(sean-k-mooney): add ubuntu to list when Ubuntu 16.04 is supported."},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027debian\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN bash -c \u0027 $(cd /lib/systemd/system/sysinit.target.wants/; for i in *; do [ \\\"$i\\\" \u003d\u003d \\\"systemd-tmpfiles-setup.service\\\" ] || rm -f $i; done); \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_a7003035","line":7,"in_reply_to":"1ac06dbe_07e78440","updated":"2016-08-23 19:49:07.000000000","message":"ya i\u0027d like to see this one fixed before merge","commit_id":"c0bf1c164e788a293876df0a5b2a2e014168b56d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ae2dc6b4a6ecc844dade8ec57f11245c64ac959","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# TODO(sean-k-mooney): add ubuntu to list when Ubuntu 16.04 is supported."},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027debian\u0027] %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN bash -c \u0027 $(cd /lib/systemd/system/sysinit.target.wants/; for i in *; do [ \\\"$i\\\" \u003d\u003d \\\"systemd-tmpfiles-setup.service\\\" ] || rm -f $i; done); \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_6270e6a4","line":7,"in_reply_to":"1ac06dbe_a7003035","updated":"2016-08-23 19:53:45.000000000","message":"yes ill fix this now","commit_id":"c0bf1c164e788a293876df0a5b2a2e014168b56d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c4b2c3909514945abd0fbe90c98e8061cbef238d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u0027e2fsprogs\u0027"},{"line_number":51,"context_line":"] %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"RUN {{ macros.install_packages(bifrost_deploy_packages | customizable(\"packages\")) }}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"CMD [ \"/sbin/init\" ]"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_990bd423","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":4},"updated":"2016-08-23 20:31:39.000000000","message":"the rebase added an extra run command here that i need to remove also","commit_id":"c0bf1c164e788a293876df0a5b2a2e014168b56d"}],"docker/bifrost/bifrost-deploy/bootstrap_args.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3aaa91ec_5bae7381","updated":"2016-07-01 00:41:29.000000000","message":"this is not used so i will delete it.\n\ni will template this file out in ansible in a seperate commit","commit_id":"99481189660110dc0b46080b8048132eb12b4155"}],"docker/bifrost/bifrost-deploy/dib_args.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3aaa91ec_7bcecf5a","updated":"2016-07-01 00:41:29.000000000","message":"this is not used so i will delete it\nit will also be templated out in ansible via a seperate commit.","commit_id":"99481189660110dc0b46080b8048132eb12b4155"}],"docker/bifrost/bifrost-deploy/init-fake.conf":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58a03d9b2b4356d7ad73ef619dbfec3a885f30a7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"start on startup"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"script"},{"line_number":9,"context_line":"\trm -rf /var/run/*.pid"},{"line_number":10,"context_line":"\trm -rf /var/run/network/*"},{"line_number":11,"context_line":"\t/sbin/initctl emit stopped JOB\u003dudevtrigger --no-wait"},{"line_number":12,"context_line":"\t/sbin/initctl emit started JOB\u003dudev --no-wait"},{"line_number":13,"context_line":"\t/sbin/initctl emit runlevel RUNLEVEL\u003d3 --no-wait"},{"line_number":14,"context_line":"end script"}],"source_content_type":"text/plain","patch_set":2,"id":"3aaa91ec_1b06ab85","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":49},"updated":"2016-07-01 00:41:29.000000000","message":"TODO: remove hard tabs","commit_id":"99481189660110dc0b46080b8048132eb12b4155"}],"docker/bifrost/bifrost-systemd/Dockerfile.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"871729787cdc31675b9e17617b418759b7333193","unresolved":false,"context_lines":[{"line_number":17,"context_line":"RUN apt-get install -y e2fsprogs \u0026\u0026 apt-get autoclean"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"VOLUME [ \"/sys/fs/cgroup\" ]"},{"line_number":21,"context_line":"VOLUME [ \"/dev\" ]"},{"line_number":22,"context_line":"CMD [ \"/sbin/init\" ]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bab6814e_c9e90eb9","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":20},"updated":"2016-05-23 00:13:56.000000000","message":"i need to change this to user the extend start scripts\n\nalso i dont thinkt he volume tag works with \"/dev\"\nthis will be done in ansible anyway.","commit_id":"b70dea63863558e5095e01f12ef102db949a06f2"}],"docker/bifrost/bifrost-systemd/bootstrap_args.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"871729787cdc31675b9e17617b418759b7333193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bab6814e_09d036f5","updated":"2016-05-23 00:13:56.000000000","message":"delete not used","commit_id":"b70dea63863558e5095e01f12ef102db949a06f2"}],"docker/bifrost/bifrost-systemd/dib_args.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"871729787cdc31675b9e17617b418759b7333193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bab6814e_890a6688","updated":"2016-05-23 00:13:56.000000000","message":"delete not used","commit_id":"b70dea63863558e5095e01f12ef102db949a06f2"}]}