)]}'
{"ansible/action_plugins/merge_configs.py":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"c3c7812e7a2d00a8c57bd91c2e534c4f1301076b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        remote_user \u003d task_vars.get(\u0027ansible_ssh_user\u0027) or self._play_context.remote_user"},{"line_number":46,"context_line":"        # NOTE(jeffrey4l): Ansible 2.1 add a remote_user param to the _make_tmp_path function."},{"line_number":47,"context_line":"        # inspect the number of the args here. In this way, ansible 2.0 and ansible 2.1 are"},{"line_number":48,"context_line":"        # bothe supported"},{"line_number":49,"context_line":"        make_tmp_path_args  \u003d inspect.getargspec(self._make_tmp_path)[0]"},{"line_number":50,"context_line":"        if not tmp and len(make_tmp_path_args) \u003d\u003d 1:"},{"line_number":51,"context_line":"            tmp \u003d self._make_tmp_path()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_babb380e","line":48,"range":{"start_line":48,"start_character":10,"end_line":48,"end_character":15},"updated":"2016-05-26 20:13:10.000000000","message":"nit: typo, should be both","commit_id":"a5b5e93a824d83e6b4911f6f59865dfed264a56b"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"2aa1ffda3834cf4d341c04ab4dcf99a92d0fb2e1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            task_vars \u003d dict()"},{"line_number":43,"context_line":"        result \u003d super(ActionModule, self).run(tmp, task_vars)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        remote_user \u003d (task_vars.get(\u0027ansible_ssh_user\u0027)"},{"line_number":46,"context_line":"                       or self._play_context.remote_user)"},{"line_number":47,"context_line":"        # NOTE(jeffrey4l): Ansible 2.1 add a remote_user param to the"},{"line_number":48,"context_line":"        # _make_tmp_path function.  inspect the number of the args here. In"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_c4721749","line":45,"updated":"2016-05-30 08:45:02.000000000","message":"There is whole bunch of logic that is only necessary in the case where tmp is None. I suggest putting everything in an \"if not tmp\" conditional, and moving line 45 closer to where it is used in the block for ansible 2.1.","commit_id":"b31b11cda2c2738f5c5798f95c82da184c4c084f"}]}