)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3b208bade5fa65400a46eb9410f76898186b6760","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Each images logs now will go to a logs directory that"},{"line_number":16,"context_line":"can be more easily read and looked over and leaves the"},{"line_number":17,"context_line":"main logger for informational/task kind of output only."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I939e073a2bc5ed8b5a1e969888fc743d80f468c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9abb7d3a_bb4e45bf","line":18,"updated":"2016-05-27 13:56:58.000000000","message":"Add a bug id.","commit_id":"e501c7e8cff1e810f29a8227c0277959c0adf0c6"}],"kolla/common/config.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"d8d8e97ea00e6d08b06dcc080c7dcaaf3500c86f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                help\u003d(\"Don\u0027t build images. Generate Dockerfile only\")),"},{"line_number":143,"context_line":"    cfg.IntOpt(\u0027timeout\u0027, default\u003d120,"},{"line_number":144,"context_line":"               help\u003d\u0027Time in seconds after which any operation times out\u0027),"},{"line_number":145,"context_line":"    cfg.StrOpt(\u0027logs-dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":146,"context_line":"]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_63342f4a","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":24},"updated":"2016-06-09 16:16:53.000000000","message":"s/logs-dir/logs_dir","commit_id":"8d8126d9b448e81556fad77767ae71639d539dcd"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"195e629ec2766b76496a5ddfe1411100300bf3c8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                help\u003d(\"Don\u0027t build images. Generate Dockerfile only\")),"},{"line_number":143,"context_line":"    cfg.IntOpt(\u0027timeout\u0027, default\u003d120,"},{"line_number":144,"context_line":"               help\u003d\u0027Time in seconds after which any operation times out\u0027),"},{"line_number":145,"context_line":"    cfg.StrOpt(\u0027logs-dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":146,"context_line":"]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_c3450a18","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":24},"in_reply_to":"7aa08908_63342f4a","updated":"2016-06-10 00:50:26.000000000","message":"Works for me, there is a mix of \u0027-\u0027 and \u0027_\u0027 in this config, so I\"m not really sure which one to favor, lol.","commit_id":"8d8126d9b448e81556fad77767ae71639d539dcd"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"4c23f53f7419df0e377335fad2406c42a6746d6a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                help\u003d(\"Don\u0027t build images. Generate Dockerfile only\")),"},{"line_number":143,"context_line":"    cfg.IntOpt(\u0027timeout\u0027, default\u003d120,"},{"line_number":144,"context_line":"               help\u003d\u0027Time in seconds after which any operation times out\u0027),"},{"line_number":145,"context_line":"    cfg.StrOpt(\u0027logs-dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":146,"context_line":"]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_49c5bb59","line":145,"range":{"start_line":145,"start_character":16,"end_line":145,"end_character":24},"in_reply_to":"7aa08908_c3450a18","updated":"2016-06-10 02:09:57.000000000","message":"Oh, understood. thanks.","commit_id":"8d8126d9b448e81556fad77767ae71639d539dcd"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"97608f933f77959ae3366f15ce50a43f0564338b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"               help\u003d\u0027Time in seconds after which any operation times out\u0027),"},{"line_number":145,"context_line":"    cfg.StrOpt(\u0027template-override\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027Path to template override file\u0027),"},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027logs_dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":148,"context_line":"]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":16,"id":"5a9d85d2_a42581c3","line":147,"updated":"2016-06-20 10:48:30.000000000","message":"Sorry, I know someone above said to use underscore here but this is inconsistent with the other config options! It needs to be --logs-dir","commit_id":"9ac5c4394231c30c52b8a8e2749f01417f5d211e"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"928f31c61c04d08e32ce5ca268f38bbe45e55d1c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"               help\u003d\u0027Time in seconds after which any operation times out\u0027),"},{"line_number":145,"context_line":"    cfg.StrOpt(\u0027template-override\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027Path to template override file\u0027),"},{"line_number":147,"context_line":"    cfg.StrOpt(\u0027logs_dir\u0027, help\u003d\u0027Path to logs directory\u0027),"},{"line_number":148,"context_line":"]"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"_BASE_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":16,"id":"5a9d85d2_346fd6c6","line":147,"in_reply_to":"5a9d85d2_a42581c3","updated":"2016-06-21 04:53:11.000000000","message":"missed it.","commit_id":"9ac5c4394231c30c52b8a8e2749f01417f5d211e"}],"kolla/image/build.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"d8d8e97ea00e6d08b06dcc080c7dcaaf3500c86f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.source \u003d source"},{"line_number":141,"context_line":"        self.parent_name \u003d parent_name"},{"line_number":142,"context_line":"        if logger is None:"},{"line_number":143,"context_line":"            logger \u003d make_a_logger()"},{"line_number":144,"context_line":"        self.logger \u003d logger"},{"line_number":145,"context_line":"        self.children \u003d []"},{"line_number":146,"context_line":"        self.plugins \u003d []"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_c34a43ac","line":143,"updated":"2016-06-09 16:16:53.000000000","message":"It\u0027s better to use self.name as image_name, isn\u0027t it?","commit_id":"8d8126d9b448e81556fad77767ae71639d539dcd"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"b71530f4912896172ef03c290441d152a85fe24d","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.source \u003d source"},{"line_number":141,"context_line":"        self.parent_name \u003d parent_name"},{"line_number":142,"context_line":"        if logger is None:"},{"line_number":143,"context_line":"            logger \u003d make_a_logger()"},{"line_number":144,"context_line":"        self.logger \u003d logger"},{"line_number":145,"context_line":"        self.children \u003d []"},{"line_number":146,"context_line":"        self.plugins \u003d []"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_635536c5","line":143,"in_reply_to":"7aa08908_c34a43ac","updated":"2016-06-10 00:50:40.000000000","message":"Ah ya, thx.","commit_id":"8d8126d9b448e81556fad77767ae71639d539dcd"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"52a3a3039bd71a5fb99c40cd7dd409a2f9a060fb","unresolved":false,"context_lines":[{"line_number":896,"context_line":""},{"line_number":897,"context_line":"    if conf.save_dependency:"},{"line_number":898,"context_line":"        kolla.save_dependency(conf.save_dependency)"},{"line_number":899,"context_line":"        LOG.info(\u0027Docker images dependency are saved in %s\u0027,"},{"line_number":900,"context_line":"                 conf.save_dependency)"},{"line_number":901,"context_line":"        return"},{"line_number":902,"context_line":"    if conf.list_images:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_ead8d281","line":899,"updated":"2016-06-16 05:56:31.000000000","message":"It can be like\n\nDocker image dependency graph is saved in %s","commit_id":"9ac5c4394231c30c52b8a8e2749f01417f5d211e"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"7435661b3c8dfa4fdd8a9955a4ea7da82345ba44","unresolved":false,"context_lines":[{"line_number":896,"context_line":""},{"line_number":897,"context_line":"    if conf.save_dependency:"},{"line_number":898,"context_line":"        kolla.save_dependency(conf.save_dependency)"},{"line_number":899,"context_line":"        LOG.info(\u0027Docker images dependency are saved in %s\u0027,"},{"line_number":900,"context_line":"                 conf.save_dependency)"},{"line_number":901,"context_line":"        return"},{"line_number":902,"context_line":"    if conf.list_images:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7aa08908_c0d15131","line":899,"in_reply_to":"7aa08908_ead8d281","updated":"2016-06-16 17:11:13.000000000","message":"Ya it could but \u0027is\u0027 doesn\u0027t sound right though IMHO.\n\nAnyways, the language here should be worked on sometime :-P","commit_id":"9ac5c4394231c30c52b8a8e2749f01417f5d211e"}]}