)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4acf8c22b05673a028b224a3f91ac06ada35e22d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"when the node is not ready to serve and restore it when ready."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4f49960d7ff2fa689d6ea730b2574f16f083edc1"},{"line_number":13,"context_line":"Related-Bug: 1578752"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abb7d3a_83e785ab","line":13,"updated":"2016-06-02 20:24:35.000000000","message":"I think this should be Closes-bug instead of Related-bug","commit_id":"c262a6b174530fc71d053c931fc56d65221898c9"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"77bf1d0d523b783df16f86149e387375647915e3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"when the node is not ready to serve and restore it when ready."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I4f49960d7ff2fa689d6ea730b2574f16f083edc1"},{"line_number":13,"context_line":"Related-Bug: 1578752"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abb7d3a_9136a6b2","line":13,"in_reply_to":"9abb7d3a_83e785ab","updated":"2016-06-02 22:38:27.000000000","message":"I agree, and to your other comment yes I also do think that this would close https://bugs.launchpad.net/kolla/+bug/1587752","commit_id":"c262a6b174530fc71d053c931fc56d65221898c9"}],"docker/mariadb/extend_start.sh":[{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"2a53f9937927e506608a70348f0fe4be12b97094","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    exit 0"},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Create a HTTP pseudo-daemon to listen on WSREP health"},{"line_number":42,"context_line":"while true; do"},{"line_number":43,"context_line":"    socat TCP-LISTEN:3307,crlf,reuseaddr,fork,max-children\u003d4 EXEC:/usr/local/bin/mysqlchk.sh"},{"line_number":44,"context_line":"done \u003e/dev/null 2\u003e\u00261 \u0026"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"if [[ \"${!BOOTSTRAP_ARGS[@]}\" ]]; then"},{"line_number":47,"context_line":"    ARGS\u003d\"${BOOTSTRAP_ARGS}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9abb7d3a_2aff8e02","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":22},"updated":"2016-05-27 22:25:36.000000000","message":"Very nice in general (happy no xinetd here!), however this layout may be a problem in Kolla because it runs a second daemon for HTTP inside an existing container and there has been a push to move to only thin, single-process containers. Adding a separate container to run alongside each mariadb container for the HTTP daemon and bind-mounting the MySQL socket into that new container might work.","commit_id":"2ba371d9f66a7a579280f52a603988d561eaa8cc"}],"docker/mariadb/mysqlchk.sh":[{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"2a53f9937927e506608a70348f0fe4be12b97094","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"MYSQL_SOCK\u003d\"/var/lib/mysql/mysql.sock\""},{"line_number":14,"context_line":"MYSQL_USERNAME\u003d\"haproxy\""},{"line_number":15,"context_line":"MYSQL_OPTS\u003d\"-N -q -A\""},{"line_number":16,"context_line":"TMP_FILE\u003d\"/dev/shm/mysqlchk.$$.out\""},{"line_number":17,"context_line":"ERR_FILE\u003d\"/dev/shm/mysqlchk.$$.err\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9abb7d3a_0aee0a22","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":24},"updated":"2016-05-27 22:25:36.000000000","message":"The existing haproxy MySQL user appears to only have \u0027USAGE\u0027 granted [1] and in the past I\u0027ve needed either the \u0027PROCESS\u0027 grant by itself or in addition to \u0027RELOAD\u0027 and \u0027REPLICATION CLIENT\u0027 to be able to read the wsrep_local_state variable. Depending on what else the existing haproxy user is used for it may be better to create another user for this (or for the other purposes). If the mysql-check is the only thing this user is currently used for, then IMO the permissions of the user could just be set to what is needed for the mysqlchk.sh script instead. Also need to make sure that the drop-root/privilege drop doesn\u0027t cause problems, but I don\u0027t think it will unless mysql.sock access is limited to only root.\n\n1 - https://github.com/openstack/kolla/blob/b1030263c58dedbcf9cc043014104783e96fa80f/ansible/roles/mariadb/tasks/register.yml#L12","commit_id":"2ba371d9f66a7a579280f52a603988d561eaa8cc"}]}