)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"7a51407c3170103c03a8b82660a4164f4f7154e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal (inc0) Jastrzebski \u003cinc007@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-01 20:50:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor of base Dockerfile to allow custom repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This breaks up base dockerfile into OS family dockerfile. Also allows to"},{"line_number":10,"context_line":"add add custom-dockerfile.yml which will be used instead of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9abb7d3a_caeed4b3","line":7,"updated":"2016-06-02 14:35:43.000000000","message":"I would say \u0027to lay foundations for full customisation\u0027 as it seem to allow for much more than just custom repos.","commit_id":"0aca62ddab62f955acf9c421559d387912ba64bc"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"7a51407c3170103c03a8b82660a4164f4f7154e5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Refactor of base Dockerfile to allow custom repo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This breaks up base dockerfile into OS family dockerfile. Also allows to"},{"line_number":10,"context_line":"add add custom-dockerfile.yml which will be used instead of"},{"line_number":11,"context_line":"debian-dockerfile. Alternatively we can break up any part of this code"},{"line_number":12,"context_line":"to block-based and custom-dockerfile will only override blocks it needs"},{"line_number":13,"context_line":"to."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9abb7d3a_ea92b8f5","line":11,"range":{"start_line":10,"start_character":49,"end_line":11,"end_character":17},"updated":"2016-06-02 14:35:43.000000000","message":"Is this accurate? It seems custom-dockerfile is essentially a series of blocks that can replace *any* blocks in the main templates. So its more powerful than just overriding debian-dockerfile","commit_id":"0aca62ddab62f955acf9c421559d387912ba64bc"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"b158cf9ba8191123ee403665621030607121c47d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"RUN cat /tmp/kolla_bashrc \u003e\u003e /root/.bashrc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Macro definitions"},{"line_number":18,"context_line":"{% macro install_yum(packages) -%}"},{"line_number":19,"context_line":"    RUN yum -y install \\"},{"line_number":20,"context_line":"        {% for package in packages -%}"},{"line_number":21,"context_line":"            {{ package }} \\"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9abb7d3a_0b292c8a","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":20},"updated":"2016-06-01 21:12:58.000000000","message":"how about naming this macro \u0027yum_install\u0027 instead of \u0027install_yum\u0027","commit_id":"0aca62ddab62f955acf9c421559d387912ba64bc"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"7a51407c3170103c03a8b82660a4164f4f7154e5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"RUN cat /tmp/kolla_bashrc \u003e\u003e /root/.bashrc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Macro definitions"},{"line_number":18,"context_line":"{% macro install_yum(packages) -%}"},{"line_number":19,"context_line":"    RUN yum -y install \\"},{"line_number":20,"context_line":"        {% for package in packages -%}"},{"line_number":21,"context_line":"            {{ package }} \\"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9abb7d3a_6a43686d","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":20},"in_reply_to":"9abb7d3a_0b292c8a","updated":"2016-06-02 14:35:43.000000000","message":"This kind of functionality may be better off in a separate patch, maybe you have some plans for it here though?","commit_id":"0aca62ddab62f955acf9c421559d387912ba64bc"}],"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"b158cf9ba8191123ee403665621030607121c47d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    {% if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":14,"context_line":"    # TODO(Allen) Remove python-dogpile-cache after the requirement of"},{"line_number":15,"context_line":"    # python-ironicclient is fixed."},{"line_number":16,"context_line":"    RUN yum -y install \\"},{"line_number":17,"context_line":"    {% include \"redhat-binary-packages\" %}"},{"line_number":18,"context_line":"    {% block openstack_base_redhat_binary_packages_additional %}{% endblock %}"},{"line_number":19,"context_line":"    \u0026\u0026 yum clean all"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9abb7d3a_101b1982","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":23},"updated":"2016-06-01 21:12:58.000000000","message":"can you consume install_yum macro here?","commit_id":"0aca62ddab62f955acf9c421559d387912ba64bc"}],"docker/openstack-base/debian-binary-packages":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"b158cf9ba8191123ee403665621030607121c47d","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"        python-barbicanclient \\"},{"line_number":3,"context_line":"        python-ceilometerclient \\"},{"line_number":4,"context_line":"        python-congressclient \\"},{"line_number":5,"context_line":"        python-designateclient \\"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9abb7d3a_50348148","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":8},"updated":"2016-06-01 21:12:58.000000000","message":"can you remove the new line and spaces? Or does the indent matter here?","commit_id":"0aca62ddab62f955acf9c421559d387912ba64bc"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"de15bd5795924181cac29b458dfa6d210e2df73c","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"        python-barbicanclient \\"},{"line_number":3,"context_line":"        python-ceilometerclient \\"},{"line_number":4,"context_line":"        python-congressclient \\"},{"line_number":5,"context_line":"        python-designateclient \\"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9abb7d3a_816b3db6","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"9abb7d3a_50348148","updated":"2016-06-01 22:22:55.000000000","message":"done","commit_id":"0aca62ddab62f955acf9c421559d387912ba64bc"}],"etc/kolla/custom-dockerfile-example.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"b158cf9ba8191123ee403665621030607121c47d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# lets include our own custom sources.list"},{"line_number":6,"context_line":"# TODO(inc0): currently custom sources list must be present in container"},{"line_number":7,"context_line":"# directory, docker doesn\u0027t seem to understand absolute paths"},{"line_number":8,"context_line":"{% block ubuntu_custom_sources_list  %}my_own.sources.list{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# let\u0027s add custom apt key at the end of repo setup"},{"line_number":11,"context_line":"{% block ubuntu_post_repo_setup  %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9abb7d3a_90d429ec","line":8,"range":{"start_line":8,"start_character":1,"end_line":8,"end_character":72},"updated":"2016-06-01 21:12:58.000000000","message":"can you add some new lines so it\u0027s more readable like you have it below","commit_id":"0aca62ddab62f955acf9c421559d387912ba64bc"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"de15bd5795924181cac29b458dfa6d210e2df73c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# lets include our own custom sources.list"},{"line_number":6,"context_line":"# TODO(inc0): currently custom sources list must be present in container"},{"line_number":7,"context_line":"# directory, docker doesn\u0027t seem to understand absolute paths"},{"line_number":8,"context_line":"{% block ubuntu_custom_sources_list  %}my_own.sources.list{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# let\u0027s add custom apt key at the end of repo setup"},{"line_number":11,"context_line":"{% block ubuntu_post_repo_setup  %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9abb7d3a_61ad79e8","line":8,"range":{"start_line":8,"start_character":1,"end_line":8,"end_character":72},"in_reply_to":"9abb7d3a_90d429ec","updated":"2016-06-01 22:22:55.000000000","message":"unfortunately jinja2 catches newlines too and this breaks. This is inline block","commit_id":"0aca62ddab62f955acf9c421559d387912ba64bc"}]}