)]}'
{"ansible/inventory/baremetal":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c53e674545fa8897611cd6e7ab9d653e64b1c8f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[baremetal]"},{"line_number":2,"context_line":"cloud[1:4]     ansible_ssh_user\u003dkolla ansible_ssh_private_key_file\u003d/home/sean/.ssh/id_rsa_bifrost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a9d85d2_3da33251","line":2,"updated":"2016-06-21 08:44:20.000000000","message":"how about use two groups.\none for kolla-master, one for kolla-deployee.\n\nthe kolla is only needed to install on one machine, i.e. the kolla-master. On\nthe other node, the docker and docker-py is enough.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"86197ee63ca9eb5d6779ad53709758461a54aeaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[baremetal]"},{"line_number":2,"context_line":"cloud[1:4]     ansible_ssh_user\u003dkolla ansible_ssh_private_key_file\u003d/home/sean/.ssh/id_rsa_bifrost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7aa08908_ba992622","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":96},"updated":"2016-06-05 05:45:44.000000000","message":"well this will work on my system but probably not many others.\n\na larger question i guest is should this be a seperate inventory.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"5f5288b2dcd9f63b0e4d65401366c9d1bc9b3309","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[baremetal]"},{"line_number":2,"context_line":"cloud[1:4]     ansible_ssh_user\u003dkolla ansible_ssh_private_key_file\u003d/home/sean/.ssh/id_rsa_bifrost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3aaa91ec_cd3557f8","line":2,"in_reply_to":"5a9d85d2_3da33251","updated":"2016-06-21 23:28:55.000000000","message":"Is the kolla-master the host running kolla-ansible? or just one of the deployees selected to have kolla available for use during the kolla-ansible run?","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[baremetal]"},{"line_number":2,"context_line":"cloud[1:4]     ansible_ssh_user\u003dkolla ansible_ssh_private_key_file\u003d/home/sean/.ssh/id_rsa_bifrost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7aa08908_ff2067b2","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":96},"in_reply_to":"7aa08908_ba992622","updated":"2016-06-10 23:22:45.000000000","message":"Actions of kolla-ansible via site.yml (like upgrade, deploy, etc) and also individual playbooks (like mariadb_recovery) can both already use groups in the existing global inventory. In addition, the hosts in the existing inventory are the same hosts that need the baremetal prep run on them. So these things make me think using the existing inventory is a better option. We just need to add a few groups to it.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9b013b8fdc118189c54eb1a54b957993d45b0e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[baremetal]"},{"line_number":2,"context_line":"cloud[1:4]     ansible_ssh_user\u003dkolla ansible_ssh_private_key_file\u003d/home/sean/.ssh/id_rsa_bifrost"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7aa08908_d8045e7f","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":96},"in_reply_to":"7aa08908_ff2067b2","updated":"2016-06-13 20:01:08.000000000","message":"yes actually i just added this as to keep things simple when debugging but you are right a separate inventory file is not needed. i will remove in v2","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"}],"ansible/roles/baremetal/defaults/main.yml":[{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"f5d2357e11096d8588ab001f31c21b65ce3e9f38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"baremetal_run: False"},{"line_number":3,"context_line":"baremetal_nic: em1"},{"line_number":4,"context_line":"update_hostname: True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"docker_apt_url: \"https://apt.dockerproject.org\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_548b1f68","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":18},"updated":"2016-08-04 20:16:33.000000000","message":"em1?  Where is this used?","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"f5d2357e11096d8588ab001f31c21b65ce3e9f38","unresolved":false,"context_lines":[{"line_number":9,"context_line":"docker_yum_url: \"https://yum.dockerproject.org\""},{"line_number":10,"context_line":"docker_gpg_fingerprint: \"58118E89F3A912897C070ADBF76221572C52609D\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"kolla_branch: master"},{"line_number":13,"context_line":"kolla_repo_url: https://github.com/openstack/kolla"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"docker_storage_driver: overlay"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_113ed927","line":12,"updated":"2016-08-04 20:16:33.000000000","message":"This needs to be tracked a release item, when this branch turns into stable/* .. Not sure how best to mark this as a release task..","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"1d8ec9c848cd12b2c1695dafb00c3d9365986641","unresolved":false,"context_lines":[{"line_number":9,"context_line":"docker_yum_url: \"https://yum.dockerproject.org\""},{"line_number":10,"context_line":"docker_gpg_fingerprint: \"58118E89F3A912897C070ADBF76221572C52609D\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"kolla_branch: master"},{"line_number":13,"context_line":"kolla_repo_url: https://github.com/openstack/kolla"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"docker_storage_driver: overlay"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_fb115e53","line":12,"in_reply_to":"bacf61ea_113ed927","updated":"2016-08-04 23:27:01.000000000","message":"As best I can tell everything in this review that used kolla_branch and kolla_repo_url has been moved elsewhere and these could be removed.\n\nAs for wherever they end up... If the git checkout on the target hosts is only needed for two or three files (I think one was requirements.txt) it may be cleaner to have kolla-ansible run a few extra tasks copy them over from the host it\u0027s running on. Though, that might require sorting out relative paths from that role\u0027s $PWD to avoid having to figure out which kolla tree is the right one (like if there is a git one and a pip-installed one).","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"f5d2357e11096d8588ab001f31c21b65ce3e9f38","unresolved":false,"context_lines":[{"line_number":10,"context_line":"docker_gpg_fingerprint: \"58118E89F3A912897C070ADBF76221572C52609D\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"kolla_branch: master"},{"line_number":13,"context_line":"kolla_repo_url: https://github.com/openstack/kolla"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"docker_storage_driver: overlay"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_71f0f591","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":14},"updated":"2016-08-04 20:16:33.000000000","message":"Should https://git.openstack.org/openstack/kolla be used instead?","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d605d972a96cf302b7817c25c95eed7fd65cf1f0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"kolla_branch: master"},{"line_number":13,"context_line":"kolla_repo_url: https://github.com/openstack/kolla"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"docker_storage_driver: overlay"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ubuntu_pkg_removals:"},{"line_number":18,"context_line":" - lxd"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_bed06a54","line":15,"updated":"2016-08-05 06:11:13.000000000","message":"needs btrfs if deploying on centos - overlayfs is not stable on centos","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"b28a8b0d47e2744425c76c974ef7e04a763d79f6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"kolla_branch: master"},{"line_number":13,"context_line":"kolla_repo_url: https://github.com/openstack/kolla"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"docker_storage_driver: overlay"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ubuntu_pkg_removals:"},{"line_number":18,"context_line":" - lxd"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_db0a6c1f","line":15,"in_reply_to":"bacf61ea_544ad455","updated":"2016-08-05 17:05:12.000000000","message":"Centos and friends tend to deploy the root filesystem on lvm.. \n\nStarting to get into local specifics... but doing something like this:\nlvcreate -l 100%FREE -n docker centos\nmkfs.btrfs /dev/centos/docker\nrm -rf /var/lib/docker/*\nmount /dev/centos/docker /var/lib/docker/\n\n(but adding to fstab), would work quite nicely on centos, if there is enough lvm free space.","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"49607f70e119231630fb65faa5b5f3ca0b0d03ff","unresolved":false,"context_lines":[{"line_number":12,"context_line":"kolla_branch: master"},{"line_number":13,"context_line":"kolla_repo_url: https://github.com/openstack/kolla"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"docker_storage_driver: overlay"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ubuntu_pkg_removals:"},{"line_number":18,"context_line":" - lxd"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_544ad455","line":15,"in_reply_to":"bacf61ea_bed06a54","updated":"2016-08-05 16:59:27.000000000","message":"does centos support aufs?\n\nbtrfs would require the file system to be btrfs.\nthe user can set this to btrfs but unless they root filesystem is btrfs it will fail.\n\ni can add code to convert the file system but even\nthough i know it should work its a little more dangerous than simply setting a config variable when executing the docker daemon.","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8a1d1376eac48a175af1cbbe044e83f00a51c426","unresolved":false,"context_lines":[{"line_number":12,"context_line":"kolla_branch: master"},{"line_number":13,"context_line":"kolla_repo_url: https://github.com/openstack/kolla"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"docker_storage_driver: overlay"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ubuntu_pkg_removals:"},{"line_number":18,"context_line":" - lxd"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_1b051d13","line":15,"in_reply_to":"bacf61ea_db0a6c1f","updated":"2016-08-05 20:26:07.000000000","message":"ill see if i can do this in a seperate commit.\nfor this commit ill assume that the user has selected a stroage driver that is compatible with there filesystem.","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"50eb89b42c7a3da2a2579b06ec78b79316435b37","unresolved":false,"context_lines":[{"line_number":12,"context_line":"create_kolla_user: True"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"docker_storage_driver: \"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"debian_pkg_install:"},{"line_number":17,"context_line":" - docker-engine\u003d1.11.*"},{"line_number":18,"context_line":" - git"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ac06dbe_71c75164","line":15,"updated":"2016-08-23 04:31:20.000000000","message":"I think in a future commit, this should be broken into the deployment host and the deployment targets.  Deployment targets only need docker-engine and docker-py (and its dependencies).  i am doubtful docker-py requires git, python-dev, libsl-dev, libffi-dev, python-setuptools.","commit_id":"3e8f9986d1229896af3e52e5a138bcbb7244a449"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6b10e4f48f3f375bbd4d7ea0d325788e4f4f5973","unresolved":false,"context_lines":[{"line_number":12,"context_line":"create_kolla_user: True"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"docker_storage_driver: \"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"debian_pkg_install:"},{"line_number":17,"context_line":" - docker-engine\u003d1.11.*"},{"line_number":18,"context_line":" - git"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ac06dbe_720d78e7","line":15,"in_reply_to":"1ac06dbe_71c75164","updated":"2016-08-23 12:43:34.000000000","message":"python-setuptools is used\nto install pip at a later point in an os independent way.\nbut yes i can investigate and split in a follow up commit.","commit_id":"3e8f9986d1229896af3e52e5a138bcbb7244a449"}],"ansible/roles/baremetal/tasks/append_to_etc_hosts.yml":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"319b36ce27bee13e13a33d6fc3c6fe4877102e40","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: get real node hostname"},{"line_number":3,"context_line":"  shell: echo $(hostname)"},{"line_number":4,"context_line":"  register: real_node_hostname"},{"line_number":5,"context_line":"  delegate_to: \"{{ baremetal_node }}\""},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_5f6ecf95","line":3,"updated":"2016-08-09 20:20:13.000000000","message":"can we use ansible_hostname here? As this will really be used later","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"90c7072d2efd7cada357ce86dce2f45ed1c39dc8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: get real node hostname"},{"line_number":3,"context_line":"  shell: echo $(hostname)"},{"line_number":4,"context_line":"  register: real_node_hostname"},{"line_number":5,"context_line":"  delegate_to: \"{{ baremetal_node }}\""},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_231c78c0","line":3,"in_reply_to":"9ad45d7e_0c61b3d3","updated":"2016-08-10 15:49:08.000000000","message":"so using ansible_hostname here will change the behavior.\n\ncurrently how this is working is that for each host in the inventory we add that hosts ip and hostname to all hosts.\n\nchanging to ansible_hostname would require the workflow to be \nreversed. so that instead of adding one host,ip to all hosts we would add all hosts,ips to one host.\n\ni can do that but its a little more complex in ansible.","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3b34734396d70874683280fea5273695b1cae36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: get real node hostname"},{"line_number":3,"context_line":"  shell: echo $(hostname)"},{"line_number":4,"context_line":"  register: real_node_hostname"},{"line_number":5,"context_line":"  delegate_to: \"{{ baremetal_node }}\""},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_0c61b3d3","line":3,"in_reply_to":"9ad45d7e_5f6ecf95","updated":"2016-08-10 11:59:28.000000000","message":"ill check that.\nansible_hostname might work though i taught tested that and it did not.\n\ninventory_hostname will not as it may be an ip as it is in my case.","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"8a78e543b1aafda69336a802efc7dc6cb6075d59","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: get real node hostname"},{"line_number":3,"context_line":"  shell: echo $(hostname)"},{"line_number":4,"context_line":"  register: real_node_hostname"},{"line_number":5,"context_line":"  delegate_to: \"{{ baremetal_node }}\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: get real node ip"},{"line_number":8,"context_line":"  shell: ip -4 addr show \"{{ hostvars[baremetal_node][\u0027baremetal_nic\u0027] }}\" | grep -oP \"(?\u003c\u003dinet )[\\d\\.]+(?\u003d/)\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_a0afd028","line":5,"updated":"2016-08-10 10:46:13.000000000","message":"currently getting \u0027baremetal_node\u0027 is undefined on this line when testing, unsure if something im doing wrong as it looks like it should work","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3b34734396d70874683280fea5273695b1cae36","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: get real node hostname"},{"line_number":3,"context_line":"  shell: echo $(hostname)"},{"line_number":4,"context_line":"  register: real_node_hostname"},{"line_number":5,"context_line":"  delegate_to: \"{{ baremetal_node }}\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: get real node ip"},{"line_number":8,"context_line":"  shell: ip -4 addr show \"{{ hostvars[baremetal_node][\u0027baremetal_nic\u0027] }}\" | grep -oP \"(?\u003c\u003dinet )[\\d\\.]+(?\u003d/)\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_f1019807","line":5,"in_reply_to":"9ad45d7e_a0afd028","updated":"2016-08-10 11:59:28.000000000","message":"are you using ansible \u003c 2.1 \n\nthe way i am defining the loop vairable does not work on older ansibel.\n\ni will refactor to the older way to define it.","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"319b36ce27bee13e13a33d6fc3c6fe4877102e40","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  delegate_to: \"{{ baremetal_node }}\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: get real node ip"},{"line_number":8,"context_line":"  shell: ip -4 addr show \"{{ hostvars[baremetal_node][\u0027baremetal_nic\u0027] }}\" | grep -oP \"(?\u003c\u003dinet )[\\d\\.]+(?\u003d/)\""},{"line_number":9,"context_line":"  register: real_node_ip"},{"line_number":10,"context_line":"  delegate_to: \"{{ baremetal_node }}\""},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_3f695b8c","line":8,"updated":"2016-08-09 20:20:13.000000000","message":"baremetal_nic will later be api_interface right? Hostname has to resolve to api_interface","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3b34734396d70874683280fea5273695b1cae36","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  delegate_to: \"{{ baremetal_node }}\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: get real node ip"},{"line_number":8,"context_line":"  shell: ip -4 addr show \"{{ hostvars[baremetal_node][\u0027baremetal_nic\u0027] }}\" | grep -oP \"(?\u003c\u003dinet )[\\d\\.]+(?\u003d/)\""},{"line_number":9,"context_line":"  register: real_node_ip"},{"line_number":10,"context_line":"  delegate_to: \"{{ baremetal_node }}\""},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_91393cf5","line":8,"in_reply_to":"9ad45d7e_3f695b8c","updated":"2016-08-10 11:59:28.000000000","message":"baremetal nic currently defaults to network_interface which is also the default value of api_interface.\n\ni can make it default to api_interfaces instead.","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"90c7072d2efd7cada357ce86dce2f45ed1c39dc8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    line\u003d\"{{ real_node_ip.stdout }} {{ real_node_hostname.stdout.split(\u0027.\u0027)[0] }} {{ real_node_hostname.stdout }} {{ \u0027#\u0027 }}a_kolla_ansible_host\""},{"line_number":16,"context_line":"    insertafter\u003d\".*kolla-ansible\\ hosts\""},{"line_number":17,"context_line":"    state\u003dpresent"},{"line_number":18,"context_line":"  with_items: groups[\u0027baremetal\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_83b8c4c9","line":18,"range":{"start_line":18,"start_character":1,"end_line":18,"end_character":33},"updated":"2016-08-10 15:49:08.000000000","message":"this should not be here.\nits not used","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"}],"ansible/roles/baremetal/tasks/install.yml":[{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - ntp"},{"line_number":43,"context_line":"    when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":44,"context_line":"-   name: Install Pypi"},{"line_number":45,"context_line":"    easy_install: name\u003dpip"},{"line_number":46,"context_line":"    become: True"},{"line_number":47,"context_line":"-   name: Install docker-py"},{"line_number":48,"context_line":"    pip: name\u003ddocker-py state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_c73cbdc1","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":26},"updated":"2016-06-10 23:22:45.000000000","message":"Using pip itself in Trusty before getting a newer version appears to break it (http://stackoverflow.com/questions/28917534/pip-broken-on-ubuntu-14-4-after-package-upgrade). This may work ok though, since you aren\u0027t actually using pip here until after easy_install updates it. I would leave this as-is for now since you use pip in the very next step and if it is a problem it will appear quickly in testing. As long as the docker-py install that follows is the first use of pip I think it will work.\n\nI really only mention this (when I\u0027m in favor of giving it a try) because it came up in IRC.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9b013b8fdc118189c54eb1a54b957993d45b0e8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - ntp"},{"line_number":43,"context_line":"    when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":44,"context_line":"-   name: Install Pypi"},{"line_number":45,"context_line":"    easy_install: name\u003dpip"},{"line_number":46,"context_line":"    become: True"},{"line_number":47,"context_line":"-   name: Install docker-py"},{"line_number":48,"context_line":"    pip: name\u003ddocker-py state\u003dlatest"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_73662bbc","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":26},"in_reply_to":"7aa08908_c73cbdc1","updated":"2016-06-13 20:01:08.000000000","message":"yes so i am explicitly not using pip until after i have installed a new version using easy_install.\n\ni was testing this on a minimal ubuntu trusty install that did not have pip installed form the package manager so in this case pip is not installed until after this runs.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":47,"context_line":"-   name: Install docker-py"},{"line_number":48,"context_line":"    pip: name\u003ddocker-py state\u003dlatest"},{"line_number":49,"context_line":"    become: True"},{"line_number":50,"context_line":"-   name: Install ansible"},{"line_number":51,"context_line":"    pip: name\u003dansible state\u003dlatest"},{"line_number":52,"context_line":"    become: True"},{"line_number":53,"context_line":"-   name: clone kolla"},{"line_number":54,"context_line":"    git: "},{"line_number":55,"context_line":"        repo\u003d{{kolla_repo_url}}"},{"line_number":56,"context_line":"        dest\u003d/opt/stack/kolla"},{"line_number":57,"context_line":"        refspec\u003d{{kolla_branch}}"},{"line_number":58,"context_line":"        force\u003dyes"},{"line_number":59,"context_line":"-   name: Install kolla requirements"},{"line_number":60,"context_line":"    pip: "},{"line_number":61,"context_line":"        requirements\u003d/opt/stack/kolla/requirements.txt "},{"line_number":62,"context_line":"        state\u003dlatest"},{"line_number":63,"context_line":"    become: True"},{"line_number":64,"context_line":"-   name: remove packages"},{"line_number":65,"context_line":"    package: name\u003d{{item}} state\u003dabsent"},{"line_number":66,"context_line":"    become: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_275661d2","line":63,"range":{"start_line":50,"start_character":0,"end_line":63,"end_character":16},"updated":"2016-06-10 23:22:45.000000000","message":"I don\u0027t think all of this is needed on the targeted nodes, most of it is only needed on the deployer node. If there are not already resources to set up kolla\u0027s deploy node, then IMHO that should be created separately.\n\nInstalling requirements may force us to keep some of it but you could also get this from the deploy node with a \"local_action:\" task that prints the requirements and registers the var, or perhaps even just use the copy module to put the local copy of requirements.txt onto the target nodes.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b68400a09727a80a7c6002e11778cacec5a4ecb6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"-   name: Install docker-py"},{"line_number":48,"context_line":"    pip: name\u003ddocker-py state\u003dlatest"},{"line_number":49,"context_line":"    become: True"},{"line_number":50,"context_line":"-   name: Install ansible"},{"line_number":51,"context_line":"    pip: name\u003dansible state\u003dlatest"},{"line_number":52,"context_line":"    become: True"},{"line_number":53,"context_line":"-   name: clone kolla"},{"line_number":54,"context_line":"    git: "},{"line_number":55,"context_line":"        repo\u003d{{kolla_repo_url}}"},{"line_number":56,"context_line":"        dest\u003d/opt/stack/kolla"},{"line_number":57,"context_line":"        refspec\u003d{{kolla_branch}}"},{"line_number":58,"context_line":"        force\u003dyes"},{"line_number":59,"context_line":"-   name: Install kolla requirements"},{"line_number":60,"context_line":"    pip: "},{"line_number":61,"context_line":"        requirements\u003d/opt/stack/kolla/requirements.txt "},{"line_number":62,"context_line":"        state\u003dlatest"},{"line_number":63,"context_line":"    become: True"},{"line_number":64,"context_line":"-   name: remove packages"},{"line_number":65,"context_line":"    package: name\u003d{{item}} state\u003dabsent"},{"line_number":66,"context_line":"    become: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_a3701a0c","line":63,"range":{"start_line":50,"start_character":0,"end_line":63,"end_character":16},"in_reply_to":"1aa78d24_5584dc5c","updated":"2016-07-21 16:14:18.000000000","message":"hi yes i will refactor this shortly.\ni have been a little split lately as i had to get the first revision of the feature i want to deliver into other projects out for review. now that this is done i should be able to spend more time on this going forward.\n\nthanks for the feedback i will try and incorperate many of the changes you suggesed when i refactor.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"6508a382c5dba8ff8658c6d4a1ee02790e1af020","unresolved":false,"context_lines":[{"line_number":47,"context_line":"-   name: Install docker-py"},{"line_number":48,"context_line":"    pip: name\u003ddocker-py state\u003dlatest"},{"line_number":49,"context_line":"    become: True"},{"line_number":50,"context_line":"-   name: Install ansible"},{"line_number":51,"context_line":"    pip: name\u003dansible state\u003dlatest"},{"line_number":52,"context_line":"    become: True"},{"line_number":53,"context_line":"-   name: clone kolla"},{"line_number":54,"context_line":"    git: "},{"line_number":55,"context_line":"        repo\u003d{{kolla_repo_url}}"},{"line_number":56,"context_line":"        dest\u003d/opt/stack/kolla"},{"line_number":57,"context_line":"        refspec\u003d{{kolla_branch}}"},{"line_number":58,"context_line":"        force\u003dyes"},{"line_number":59,"context_line":"-   name: Install kolla requirements"},{"line_number":60,"context_line":"    pip: "},{"line_number":61,"context_line":"        requirements\u003d/opt/stack/kolla/requirements.txt "},{"line_number":62,"context_line":"        state\u003dlatest"},{"line_number":63,"context_line":"    become: True"},{"line_number":64,"context_line":"-   name: remove packages"},{"line_number":65,"context_line":"    package: name\u003d{{item}} state\u003dabsent"},{"line_number":66,"context_line":"    become: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_5584dc5c","line":63,"range":{"start_line":50,"start_character":0,"end_line":63,"end_character":16},"in_reply_to":"3aaa91ec_6905850f","updated":"2016-07-13 17:59:54.000000000","message":"Having also looked at your deployment steps breakdown on the ML, if installing Ansible on the build host/deployer does get moved to a pre-step such as \"kolla-host build-host-deploy\", and if one of the few remaining differences between bootstrapping that host and the rest of the nodes is this pip install of kolla\u0027s requirements, then your inception/playbook reuse may be totally doable.\n\nAfter \"kolla-host build-host-deploy\" you could run \"kolla-ansible bootstrap-node -i \u0027localhost,\u0027\" and pass a tag/flag to the effect of \u0027with_deployer_deps\u0027. Then re-run the same play later without that tag/flag.\n\nOne thing I\u0027d be careful of though is instead using \u0027local_action:\u0027 to do some things on the local deployer host at the same time you\u0027re bootstrapping the nodes. It is better to make a separate ansible-playbook run targeting localhost because we won\u0027t always have the users, rights, or sudo config identical on the deployer and the nodes. This allows you to have different settings for each run. The mixed/local_action pattern is IMHO why a lot of new users have issues with kolla-ansible precheck.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1150c789997359df39c7f59ea28c5e39ca16209a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"-   name: Install docker-py"},{"line_number":48,"context_line":"    pip: name\u003ddocker-py state\u003dlatest"},{"line_number":49,"context_line":"    become: True"},{"line_number":50,"context_line":"-   name: Install ansible"},{"line_number":51,"context_line":"    pip: name\u003dansible state\u003dlatest"},{"line_number":52,"context_line":"    become: True"},{"line_number":53,"context_line":"-   name: clone kolla"},{"line_number":54,"context_line":"    git: "},{"line_number":55,"context_line":"        repo\u003d{{kolla_repo_url}}"},{"line_number":56,"context_line":"        dest\u003d/opt/stack/kolla"},{"line_number":57,"context_line":"        refspec\u003d{{kolla_branch}}"},{"line_number":58,"context_line":"        force\u003dyes"},{"line_number":59,"context_line":"-   name: Install kolla requirements"},{"line_number":60,"context_line":"    pip: "},{"line_number":61,"context_line":"        requirements\u003d/opt/stack/kolla/requirements.txt "},{"line_number":62,"context_line":"        state\u003dlatest"},{"line_number":63,"context_line":"    become: True"},{"line_number":64,"context_line":"-   name: remove packages"},{"line_number":65,"context_line":"    package: name\u003d{{item}} state\u003dabsent"},{"line_number":66,"context_line":"    become: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_6905850f","line":63,"range":{"start_line":50,"start_character":0,"end_line":63,"end_character":16},"in_reply_to":"3aaa91ec_f8cf2fb1","updated":"2016-06-24 17:36:46.000000000","message":"ya there is a bit of inception here but i original wanted this playbook to be able to setup the build host too.\n\nso you would do a fresh install of an os on one node.\nrun this playbook and it would allow you to build the image \nthen you would deploy bifrost and have it install the os on the rest of your nodes then run this playbook again to prep the deployment host and then run the kolla deploy to deploy openstack on the servers.\n\ni guess at a minium ansible would have to be installed for run this playbook in the first place :)","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"5f5288b2dcd9f63b0e4d65401366c9d1bc9b3309","unresolved":false,"context_lines":[{"line_number":47,"context_line":"-   name: Install docker-py"},{"line_number":48,"context_line":"    pip: name\u003ddocker-py state\u003dlatest"},{"line_number":49,"context_line":"    become: True"},{"line_number":50,"context_line":"-   name: Install ansible"},{"line_number":51,"context_line":"    pip: name\u003dansible state\u003dlatest"},{"line_number":52,"context_line":"    become: True"},{"line_number":53,"context_line":"-   name: clone kolla"},{"line_number":54,"context_line":"    git: "},{"line_number":55,"context_line":"        repo\u003d{{kolla_repo_url}}"},{"line_number":56,"context_line":"        dest\u003d/opt/stack/kolla"},{"line_number":57,"context_line":"        refspec\u003d{{kolla_branch}}"},{"line_number":58,"context_line":"        force\u003dyes"},{"line_number":59,"context_line":"-   name: Install kolla requirements"},{"line_number":60,"context_line":"    pip: "},{"line_number":61,"context_line":"        requirements\u003d/opt/stack/kolla/requirements.txt "},{"line_number":62,"context_line":"        state\u003dlatest"},{"line_number":63,"context_line":"    become: True"},{"line_number":64,"context_line":"-   name: remove packages"},{"line_number":65,"context_line":"    package: name\u003d{{item}} state\u003dabsent"},{"line_number":66,"context_line":"    become: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_f8cf2fb1","line":63,"range":{"start_line":50,"start_character":0,"end_line":63,"end_character":16},"in_reply_to":"7aa08908_1332475e","updated":"2016-06-21 23:28:55.000000000","message":"Sure, though I\u0027m still not sure what ansible is needed for since at this point we\u0027re already in the middle of an ansible-playbook run.\n\nIs it that the baremetal process is intended to also set up the host that will run kolla-ansible?","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9b013b8fdc118189c54eb1a54b957993d45b0e8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"-   name: Install docker-py"},{"line_number":48,"context_line":"    pip: name\u003ddocker-py state\u003dlatest"},{"line_number":49,"context_line":"    become: True"},{"line_number":50,"context_line":"-   name: Install ansible"},{"line_number":51,"context_line":"    pip: name\u003dansible state\u003dlatest"},{"line_number":52,"context_line":"    become: True"},{"line_number":53,"context_line":"-   name: clone kolla"},{"line_number":54,"context_line":"    git: "},{"line_number":55,"context_line":"        repo\u003d{{kolla_repo_url}}"},{"line_number":56,"context_line":"        dest\u003d/opt/stack/kolla"},{"line_number":57,"context_line":"        refspec\u003d{{kolla_branch}}"},{"line_number":58,"context_line":"        force\u003dyes"},{"line_number":59,"context_line":"-   name: Install kolla requirements"},{"line_number":60,"context_line":"    pip: "},{"line_number":61,"context_line":"        requirements\u003d/opt/stack/kolla/requirements.txt "},{"line_number":62,"context_line":"        state\u003dlatest"},{"line_number":63,"context_line":"    become: True"},{"line_number":64,"context_line":"-   name: remove packages"},{"line_number":65,"context_line":"    package: name\u003d{{item}} state\u003dabsent"},{"line_number":66,"context_line":"    become: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_1332475e","line":63,"range":{"start_line":50,"start_character":0,"end_line":63,"end_character":16},"in_reply_to":"7aa08908_275661d2","updated":"2016-06-13 20:01:08.000000000","message":"based on irc feedback im going to refactor this change into a separate playbook.\n\nas part of that i will into separate the logic into two roles.\none to install the common dependencies for all nodes and a separate one for the build dependencies.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"e71f97b59dee8c8d44b5ecc1c5c3fca0e0fd5ce9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"-   name: Install docker-py"},{"line_number":48,"context_line":"    pip: name\u003ddocker-py state\u003dlatest"},{"line_number":49,"context_line":"    become: True"},{"line_number":50,"context_line":"-   name: Install ansible"},{"line_number":51,"context_line":"    pip: name\u003dansible state\u003dlatest"},{"line_number":52,"context_line":"    become: True"},{"line_number":53,"context_line":"-   name: clone kolla"},{"line_number":54,"context_line":"    git: "},{"line_number":55,"context_line":"        repo\u003d{{kolla_repo_url}}"},{"line_number":56,"context_line":"        dest\u003d/opt/stack/kolla"},{"line_number":57,"context_line":"        refspec\u003d{{kolla_branch}}"},{"line_number":58,"context_line":"        force\u003dyes"},{"line_number":59,"context_line":"-   name: Install kolla requirements"},{"line_number":60,"context_line":"    pip: "},{"line_number":61,"context_line":"        requirements\u003d/opt/stack/kolla/requirements.txt "},{"line_number":62,"context_line":"        state\u003dlatest"},{"line_number":63,"context_line":"    become: True"},{"line_number":64,"context_line":"-   name: remove packages"},{"line_number":65,"context_line":"    package: name\u003d{{item}} state\u003dabsent"},{"line_number":66,"context_line":"    become: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_ec4ddfc4","line":63,"range":{"start_line":50,"start_character":0,"end_line":63,"end_character":16},"in_reply_to":"dada55a8_a3701a0c","updated":"2016-07-21 17:06:19.000000000","message":"totally. thanks for considering them.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c53e674545fa8897611cd6e7ab9d653e64b1c8f4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    become: True"},{"line_number":67,"context_line":"    with_items:"},{"line_number":68,"context_line":"    - lxd"},{"line_number":69,"context_line":"    - lxc"},{"line_number":70,"context_line":"    - libvirt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a9d85d2_fd988a1d","line":69,"updated":"2016-06-21 08:44:20.000000000","message":"why the lxc and lxd need to remove?","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1150c789997359df39c7f59ea28c5e39ca16209a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    become: True"},{"line_number":67,"context_line":"    with_items:"},{"line_number":68,"context_line":"    - lxd"},{"line_number":69,"context_line":"    - lxc"},{"line_number":70,"context_line":"    - libvirt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_49b9a92d","line":69,"in_reply_to":"3aaa91ec_27aa3ad5","updated":"2016-06-24 17:36:46.000000000","message":"this could be a separate task but even if you were on centos or another os if lxc/lxd is deployed would it not have to be removed for the same reason as on ubuntu 16.04","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"6508a382c5dba8ff8658c6d4a1ee02790e1af020","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    become: True"},{"line_number":67,"context_line":"    with_items:"},{"line_number":68,"context_line":"    - lxd"},{"line_number":69,"context_line":"    - lxc"},{"line_number":70,"context_line":"    - libvirt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_0a7453fb","line":69,"in_reply_to":"3aaa91ec_49b9a92d","updated":"2016-07-13 17:59:54.000000000","message":"As far as I know there are no lxd packages for CentOS or for Ubuntu 14.04 (unless the trusty-backports repo is enabled). At some point in the future, a package that needs to be removed may also have a different name for CentOS than for Ubuntu (like if we had to start removing any default apache2/httpd from the bare metal hosts).\n\nI would say just set this task as \u0027ignore_errors: True\u0027 and combine the lists from different distros, but I just tried to run apt-get purge on some packages that were not installed as well as some made up random names, and apt refused to act at all if there were unknown packages in the list.\n\nWhat about passing a \u0027pkg_removals\u0027 variable to this task that is set from a per-distro value (i.e.: vars like \u0027ubuntu14_pkg_removals\u0027 and \u0027cent7_pks_removals\u0027)?","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"5f5288b2dcd9f63b0e4d65401366c9d1bc9b3309","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    become: True"},{"line_number":67,"context_line":"    with_items:"},{"line_number":68,"context_line":"    - lxd"},{"line_number":69,"context_line":"    - lxc"},{"line_number":70,"context_line":"    - libvirt"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_27aa3ad5","line":69,"in_reply_to":"5a9d85d2_fd988a1d","updated":"2016-06-21 23:28:55.000000000","message":"I\u0027ve put a link to the reason below, but @sean-k-mooney perhaps it would make more sense to have a task separate from the libvirt uninstall that targets just 16.04. I\u0027m not sure.\n\n---\nhttp://docs.openstack.org/developer/kolla/quickstart.html\n---\nNote: On ubuntu 16.04, please uninstall lxd and lxc packages. (issue with cgroup mounts, mounts exponentially increasing when restarting container).","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"f5d2357e11096d8588ab001f31c21b65ce3e9f38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bacf61ea_f18065c1","updated":"2016-08-04 20:16:33.000000000","message":"Is it worth breaking this into two different files?  Debian / RedHat family?\n\nOr.... could we use the macros.j2 here?  (I agree it is slightly cross purpose here)","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"}],"ansible/roles/baremetal/tasks/main.yml":[{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  when: not baremetal_run"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Registering baremetal role has run"},{"line_number":6,"context_line":"  set_fact:"},{"line_number":7,"context_line":"    baremetal_run: True"},{"line_number":8,"context_line":"  when: not baremetal_run"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_aaca189f","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":23},"updated":"2016-06-10 23:22:45.000000000","message":"This may not always persist between runs of kolla-ansible, even when considering Ansible fact caching.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: \"{{ action }}.yml\""},{"line_number":3,"context_line":"  when: not baremetal_run"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Registering baremetal role has run"},{"line_number":6,"context_line":"  set_fact:"},{"line_number":7,"context_line":"    baremetal_run: True"},{"line_number":8,"context_line":"  when: not baremetal_run"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_5eba6124","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":25},"updated":"2016-06-10 23:22:45.000000000","message":"I think this goes away if baremetal is a separate action that site.yml does not include.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1150c789997359df39c7f59ea28c5e39ca16209a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: \"{{ action }}.yml\""},{"line_number":3,"context_line":"  when: not baremetal_run"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Registering baremetal role has run"},{"line_number":6,"context_line":"  set_fact:"},{"line_number":7,"context_line":"    baremetal_run: True"},{"line_number":8,"context_line":"  when: not baremetal_run"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_89d3915f","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":25},"in_reply_to":"3aaa91ec_984b8bb0","updated":"2016-06-24 17:36:46.000000000","message":"ah that makes sense yes ill remove this then.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9b013b8fdc118189c54eb1a54b957993d45b0e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: \"{{ action }}.yml\""},{"line_number":3,"context_line":"  when: not baremetal_run"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Registering baremetal role has run"},{"line_number":6,"context_line":"  set_fact:"},{"line_number":7,"context_line":"    baremetal_run: True"},{"line_number":8,"context_line":"  when: not baremetal_run"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_f384dbd3","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":25},"in_reply_to":"7aa08908_5eba6124","updated":"2016-06-13 20:01:08.000000000","message":"actully i dont know if this is actully needed.\n\ni started this role by basing it on the common role so this might not be needed at all.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"5f5288b2dcd9f63b0e4d65401366c9d1bc9b3309","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: \"{{ action }}.yml\""},{"line_number":3,"context_line":"  when: not baremetal_run"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Registering baremetal role has run"},{"line_number":6,"context_line":"  set_fact:"},{"line_number":7,"context_line":"    baremetal_run: True"},{"line_number":8,"context_line":"  when: not baremetal_run"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_984b8bb0","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":25},"in_reply_to":"7aa08908_f384dbd3","updated":"2016-06-21 23:28:55.000000000","message":"I think everything but the \u0027- include: \"{{ action }}.yml\"\u0027 is intended to check whether baremetal has run previously so that it does not have to be run every single time (or, as you\u0027d said, so that whatever this was based on does not have to be run every time :).\n\nWith baremetal being a separate command/action to kolla-ansible the rest shouldn\u0027t be needed.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"319b36ce27bee13e13a33d6fc3c6fe4877102e40","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: \"{{ action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_ff6ea394","line":2,"updated":"2016-08-09 20:20:13.000000000","message":"so I think we can just include only action there is:) bootstrap. But for future proofing this is ok.","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3b34734396d70874683280fea5273695b1cae36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: \"{{ action }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_ec153fe5","line":2,"in_reply_to":"9ad45d7e_ff6ea394","updated":"2016-08-10 11:59:28.000000000","message":"a follow up patch will add a bootstrap-build-host\n\ni decided to split that out as while it a small change i wanted to focuse on bootstrapping the deploy hosts first.","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"}],"ansible/roles/baremetal/tasks/post-install.yml":[{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"1d8ec9c848cd12b2c1695dafb00c3d9365986641","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  become: True"},{"line_number":9,"context_line":"  when: (ansible_distribution \u003d\u003d \"Ubuntu\" and ansible_distribution_major_version \u003e \"14\") or"},{"line_number":10,"context_line":"        (ansible_os_family \u003d\u003d \"RedHat\") or (ansible_distribution \u003d\u003d \"Debian\")"},{"line_number":11,"context_line":"- name: configure docker service"},{"line_number":12,"context_line":"  become: True"},{"line_number":13,"context_line":"  template:"},{"line_number":14,"context_line":"     src\u003ddocker_systemd_service.j2"},{"line_number":15,"context_line":"     dest\u003d/etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":16,"context_line":"  when: (ansible_distribution \u003d\u003d \"Ubuntu\" and ansible_distribution_major_version \u003e \"14\") or"},{"line_number":17,"context_line":"        (ansible_os_family \u003d\u003d \"RedHat\") or (ansible_distribution \u003d\u003d \"Debian\")"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: reload docker service file"},{"line_number":20,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_b6cc1bbc","line":17,"range":{"start_line":11,"start_character":0,"end_line":17,"end_character":77},"updated":"2016-08-04 23:27:01.000000000","message":"--insecure-registry is in here but this doesn\u0027t render on Trusty. IIRC on Trusty, this is still set in /etc/default/docker so may need a task here for that. \n\nThis page mentions it and just says it applies to \"Ubuntu LTS\" but I think it means Trusty: http://docs.openstack.org/developer/kolla/deploy-all-in-one-node.html","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"f5d2357e11096d8588ab001f31c21b65ce3e9f38","unresolved":false,"context_lines":[{"line_number":37,"context_line":"     name: docker"},{"line_number":38,"context_line":"  become: True"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: add kolla user to docker group"},{"line_number":41,"context_line":"  user:"},{"line_number":42,"context_line":"     name: kolla"},{"line_number":43,"context_line":"     append: yes"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_71fab544","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":12},"updated":"2016-08-04 20:16:33.000000000","message":"Why not just add the user to the group when it is created?  (might need the creation of kolla user to be here?)","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"ed359f77bc0552ba2ddda08af22982cbea722b0f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  become: True"},{"line_number":9,"context_line":"  when: (ansible_distribution \u003d\u003d \"Ubuntu\" and ansible_distribution_major_version \u003e \"14\") or"},{"line_number":10,"context_line":"        (ansible_os_family \u003d\u003d \"RedHat\") or (ansible_distribution \u003d\u003d \"Debian\")"},{"line_number":11,"context_line":"- name: configure docker service"},{"line_number":12,"context_line":"  become: True"},{"line_number":13,"context_line":"  template:"},{"line_number":14,"context_line":"     src\u003ddocker_systemd_service.j2"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_4bd2755d","line":11,"updated":"2016-08-10 10:55:58.000000000","message":"missing blank line","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3b34734396d70874683280fea5273695b1cae36","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  become: True"},{"line_number":9,"context_line":"  when: (ansible_distribution \u003d\u003d \"Ubuntu\" and ansible_distribution_major_version \u003e \"14\") or"},{"line_number":10,"context_line":"        (ansible_os_family \u003d\u003d \"RedHat\") or (ansible_distribution \u003d\u003d \"Debian\")"},{"line_number":11,"context_line":"- name: configure docker service"},{"line_number":12,"context_line":"  become: True"},{"line_number":13,"context_line":"  template:"},{"line_number":14,"context_line":"     src\u003ddocker_systemd_service.j2"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_6ce02ffb","line":11,"in_reply_to":"9ad45d7e_4bd2755d","updated":"2016-08-10 11:59:28.000000000","message":"ah thank you\nwill add","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"92b251dc92ef98a7ffa1c791080b98d08bd09251","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  become: True"},{"line_number":9,"context_line":"  when: (ansible_distribution \u003d\u003d \"Ubuntu\" and ansible_distribution_major_version \u003e \"14\") or"},{"line_number":10,"context_line":"        (ansible_os_family \u003d\u003d \"RedHat\") or (ansible_distribution \u003d\u003d \"Debian\")"},{"line_number":11,"context_line":"- name: configure docker service"},{"line_number":12,"context_line":"  become: True"},{"line_number":13,"context_line":"  template:"},{"line_number":14,"context_line":"     src\u003ddocker_systemd_service.j2"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_5e321f60","line":11,"in_reply_to":"9ad45d7e_6ce02ffb","updated":"2016-08-10 16:05:18.000000000","message":"Done","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"319b36ce27bee13e13a33d6fc3c6fe4877102e40","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  service:"},{"line_number":57,"context_line":"     name: docker"},{"line_number":58,"context_line":"     state: started"},{"line_number":59,"context_line":"  become: yes"},{"line_number":60,"context_line":"- name: restart docker"},{"line_number":61,"context_line":"  service:"},{"line_number":62,"context_line":"     name: docker"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_1f745766","line":59,"updated":"2016-08-09 20:20:13.000000000","message":"newline missing","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3b34734396d70874683280fea5273695b1cae36","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  service:"},{"line_number":57,"context_line":"     name: docker"},{"line_number":58,"context_line":"     state: started"},{"line_number":59,"context_line":"  become: yes"},{"line_number":60,"context_line":"- name: restart docker"},{"line_number":61,"context_line":"  service:"},{"line_number":62,"context_line":"     name: docker"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_accd0787","line":59,"in_reply_to":"9ad45d7e_1f745766","updated":"2016-08-10 11:59:28.000000000","message":"yep will add.","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"92b251dc92ef98a7ffa1c791080b98d08bd09251","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  service:"},{"line_number":57,"context_line":"     name: docker"},{"line_number":58,"context_line":"     state: started"},{"line_number":59,"context_line":"  become: yes"},{"line_number":60,"context_line":"- name: restart docker"},{"line_number":61,"context_line":"  service:"},{"line_number":62,"context_line":"     name: docker"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_be335b61","line":59,"in_reply_to":"9ad45d7e_accd0787","updated":"2016-08-10 16:05:18.000000000","message":"Done","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"50eb89b42c7a3da2a2579b06ec78b79316435b37","unresolved":false,"context_lines":[{"line_number":45,"context_line":"     name: docker"},{"line_number":46,"context_line":"  become: True"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: add kolla user to docker group"},{"line_number":49,"context_line":"  user:"},{"line_number":50,"context_line":"     name: kolla"},{"line_number":51,"context_line":"     append: yes"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ac06dbe_117c1d1e","line":48,"updated":"2016-08-23 04:31:20.000000000","message":"I think what we want here is a kolla group with a kolla user added to it by default.  Then operators can add their individual login to the kolla group and operate on the filesystem appropriately.","commit_id":"3e8f9986d1229896af3e52e5a138bcbb7244a449"}],"ansible/roles/baremetal/tasks/pre-install.yml":[{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set hostname"},{"line_number":3,"context_line":"  hostname: name\u003d{{ inventory_hostname }}"},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"- name: Update /etc/hosts"},{"line_number":6,"context_line":"  lineinfile:"},{"line_number":7,"context_line":"     dest\u003d/etc/hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_6407ca1c","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":14},"updated":"2016-06-10 23:22:45.000000000","message":"Anyone using IP addresses in their inventory may have trouble here, and some dynamic inventories may set \"inventory_hostname\" and \"ansible_ssh_hostname\" differently (for example I do this in Rackspace but not in EC2). I think the operator should set up their inventory (whether dynamic or static) to follow the lead of the host\u0027s hostname prior to running kolla so that this task is not needed.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b68400a09727a80a7c6002e11778cacec5a4ecb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set hostname"},{"line_number":3,"context_line":"  hostname: name\u003d{{ inventory_hostname }}"},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"- name: Update /etc/hosts"},{"line_number":6,"context_line":"  lineinfile:"},{"line_number":7,"context_line":"     dest\u003d/etc/hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_5de020cd","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":14},"in_reply_to":"1aa78d24_90a93293","updated":"2016-07-21 16:14:18.000000000","message":"this is probably not needed ill remove for now.\n\nthe reason i originally had this here was that with my bifrost deployed images it did not update the host name the first time i had got the deploy working but that was an error on my part.\n\nthe machine imaging tool or the operator should be able to update the hostname before the playbook is run.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"6508a382c5dba8ff8658c6d4a1ee02790e1af020","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set hostname"},{"line_number":3,"context_line":"  hostname: name\u003d{{ inventory_hostname }}"},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"- name: Update /etc/hosts"},{"line_number":6,"context_line":"  lineinfile:"},{"line_number":7,"context_line":"     dest\u003d/etc/hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_90a93293","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":14},"in_reply_to":"3aaa91ec_18179b52","updated":"2016-07-13 17:59:54.000000000","message":"I don\u0027t think this task is safe. Is there a scenario that is anticipated which will require it? I will try to describe why it worries me, and why I think operators should have hostnames set before running any Ansible portion of the baremetal process.\n\n(Note that some of the connection vars changed names in Ansible 2.0, mostly to drop the middle \u0027_ssh\u0027. So ansible_ssh_hostname is now ansible_hostname.)\n\nI\u0027d argue that it is a valid use-case to have inventory_hostname not be the node\u0027s hostname, and that changing a hostname mid-run that we\u0027ve just told Ansible to target could render some hosts unreachable.\n\nSee these two quotes on this page [1]:\n\n\u003e In the above example, trying to ansible against the host alias “jumper” (which may not even be a real hostname)\n\n\u003e ansible_host\n\u003e    The name of the host to connect to, if different from the alias you wish to give to it.\n\nSo inventory_hostname is just the alias we give the host in Ansible\u0027s inventory and ansible_hostname is how Ansible actually reaches the host. These can be set statically in an inventory file, and (either value) may or may not be specified by a dynamic inventory. ansible_hostname is assumed to be \u003d\u003d inventory_hostname if not otherwise specified before Ansible attempts to contact the host.\n\nSo if a node is added to inventory that is inventory_hostname\u003d\u0027192.168.29.6\u0027 and ansible_hostname\u003d\u0027node01.domainname.com\u0027, this task would attempt to set the linux hostname to an IP address, which isn\u0027t valid.\n\nLikewise, if a dynamic inventory sets inventory_hostname to an alias and ansible_hostname to the actual fqdn, anything else (server monitoring, etc.) that expects the host to have the actual fqdn will be unhappy (possibly including the host itself) after the hostname has changed.\n\nFinally, we can\u0027t be sure which hostname Ansible is setting with the hostname module on each distro, as recent platforms and tooling deal with several hostnames, such as with systemd\u0027s hostnamectl - \"This tool distinguishes three different hostnames\" [2].\n\nAll that being said, if this HAS to be done in some cases there is probably a way. Perhaps a single-task play that just sets the hostname and exits, and then the operator updates their inventory before going to the next step.\n\n\n[1] - http://docs.ansible.com/ansible/intro_inventory.html#hosts-and-groups\n[2] - https://www.freedesktop.org/software/systemd/man/hostnamectl.html","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"5f5288b2dcd9f63b0e4d65401366c9d1bc9b3309","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set hostname"},{"line_number":3,"context_line":"  hostname: name\u003d{{ inventory_hostname }}"},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"- name: Update /etc/hosts"},{"line_number":6,"context_line":"  lineinfile:"},{"line_number":7,"context_line":"     dest\u003d/etc/hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_18179b52","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":14},"in_reply_to":"7aa08908_136a47ed","updated":"2016-06-21 23:28:55.000000000","message":"I have run out of time at the moment and am not sure how gerrit works with Drafts. :D  I\u0027ll make another pass for this topic a little later.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9b013b8fdc118189c54eb1a54b957993d45b0e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set hostname"},{"line_number":3,"context_line":"  hostname: name\u003d{{ inventory_hostname }}"},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"- name: Update /etc/hosts"},{"line_number":6,"context_line":"  lineinfile:"},{"line_number":7,"context_line":"     dest\u003d/etc/hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_136a47ed","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":14},"in_reply_to":"7aa08908_6407ca1c","updated":"2016-06-13 20:01:08.000000000","message":"ok not sure i followed that entirely.\n\nwould it be better to make this conditional.\n\neither as a config option or by checking to see if the hostname matched?\n\ncan you point me to an example of what you suggest instead?","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"e71f97b59dee8c8d44b5ecc1c5c3fca0e0fd5ce9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set hostname"},{"line_number":3,"context_line":"  hostname: name\u003d{{ inventory_hostname }}"},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"- name: Update /etc/hosts"},{"line_number":6,"context_line":"  lineinfile:"},{"line_number":7,"context_line":"     dest\u003d/etc/hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_ec9e7f61","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":14},"in_reply_to":"dada55a8_5de020cd","updated":"2016-07-21 17:06:19.000000000","message":"Oh ok I get it now; sorry. That is an interesting and kind of hard problem so I\u0027m glad that at least for bifrost the deployed images set it.\n\nIs bifrost setting that via the configdrive then? Do the desired names go into \u0027BIFROST_INVENTORY_SOURCE\u0027 file ahead of time or are they separately defined?","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Set hostname"},{"line_number":3,"context_line":"  hostname: name\u003d{{ inventory_hostname }}"},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"- name: Update /etc/hosts"},{"line_number":6,"context_line":"  lineinfile:"},{"line_number":7,"context_line":"     dest\u003d/etc/hosts"},{"line_number":8,"context_line":"     regexp\u003d\"^127\\.0\\.1\\.1\""},{"line_number":9,"context_line":"     line\u003d\"127.0.0.1\t{{ inventory_hostname }} localhost\""},{"line_number":10,"context_line":"     state\u003dpresent"},{"line_number":11,"context_line":"  become: True"},{"line_number":12,"context_line":"- name: Generate /etc/hosts file"},{"line_number":13,"context_line":"  template:"},{"line_number":14,"context_line":"     src\u003dhosts.j2"},{"line_number":15,"context_line":"     dest\u003d/etc/hosts"},{"line_number":16,"context_line":"  become: True"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Ensure apt sources list directory exists"},{"line_number":19,"context_line":"  file: path\u003d/etc/apt/sources.list.d state\u003ddirectory recurse\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_c4479e75","line":16,"range":{"start_line":5,"start_character":0,"end_line":16,"end_character":14},"updated":"2016-06-10 23:22:45.000000000","message":"Doesn\u0027t the second task here remove the need for the first?","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9b013b8fdc118189c54eb1a54b957993d45b0e8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Set hostname"},{"line_number":3,"context_line":"  hostname: name\u003d{{ inventory_hostname }}"},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"- name: Update /etc/hosts"},{"line_number":6,"context_line":"  lineinfile:"},{"line_number":7,"context_line":"     dest\u003d/etc/hosts"},{"line_number":8,"context_line":"     regexp\u003d\"^127\\.0\\.1\\.1\""},{"line_number":9,"context_line":"     line\u003d\"127.0.0.1\t{{ inventory_hostname }} localhost\""},{"line_number":10,"context_line":"     state\u003dpresent"},{"line_number":11,"context_line":"  become: True"},{"line_number":12,"context_line":"- name: Generate /etc/hosts file"},{"line_number":13,"context_line":"  template:"},{"line_number":14,"context_line":"     src\u003dhosts.j2"},{"line_number":15,"context_line":"     dest\u003d/etc/hosts"},{"line_number":16,"context_line":"  become: True"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Ensure apt sources list directory exists"},{"line_number":19,"context_line":"  file: path\u003d/etc/apt/sources.list.d state\u003ddirectory recurse\u003dyes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_33d943f4","line":16,"range":{"start_line":5,"start_character":0,"end_line":16,"end_character":14},"in_reply_to":"7aa08908_c4479e75","updated":"2016-06-13 20:01:08.000000000","message":"yes i was trying a few different ways of doing this the first task is not needed.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"f5d2357e11096d8588ab001f31c21b65ce3e9f38","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  lineinfile:"},{"line_number":24,"context_line":"    dest: /etc/hosts"},{"line_number":25,"context_line":"    regexp: \"^{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""},{"line_number":26,"context_line":"    line: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\t{{ node_hostname.stdout }}\""},{"line_number":27,"context_line":"    state: present"},{"line_number":28,"context_line":"  become: True"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_d4226fa2","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":41},"updated":"2016-08-04 20:16:33.000000000","message":"Hmm, this probably needs to be configurable.  I\u0027d expect most deployments to have DNS resolution and not need this?","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"1d8ec9c848cd12b2c1695dafb00c3d9365986641","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  lineinfile:"},{"line_number":24,"context_line":"    dest: /etc/hosts"},{"line_number":25,"context_line":"    regexp: \"^{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""},{"line_number":26,"context_line":"    line: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\t{{ node_hostname.stdout }}\""},{"line_number":27,"context_line":"    state: present"},{"line_number":28,"context_line":"  become: True"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_3ba5b646","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":41},"in_reply_to":"bacf61ea_d4226fa2","updated":"2016-08-04 23:27:01.000000000","message":"I\u0027m torn here because each host is simply recording another name for itself and not for other hosts (unless this is supposed to have a \u0027with_items:\u0027), but I could still imagine some problematic corner cases - primarily if the actual DNS names are being used in Ansible\u0027s inventory and this value somehow disagrees with DNS (perhaps if a DNS change is still propagating).\n\nIs there a specific goal in mind for this or just wanting the host to also know itself by the inventory name?","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d6744d9db20df2edabda76fad2d8da036efb7e00","unresolved":false,"context_lines":[{"line_number":49,"context_line":"- name: add public key to kolla user authorized keys"},{"line_number":50,"context_line":"  authorized_key:"},{"line_number":51,"context_line":"    user: kolla"},{"line_number":52,"context_line":"    key: \"{{ kolla_ssh_key.public_key }}\""},{"line_number":53,"context_line":"  become: True"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: install apt packages"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_86bee662","line":52,"updated":"2016-08-05 14:28:11.000000000","message":"kolla_ssh_key is missing from the passwords.yml template","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"49607f70e119231630fb65faa5b5f3ca0b0d03ff","unresolved":false,"context_lines":[{"line_number":49,"context_line":"- name: add public key to kolla user authorized keys"},{"line_number":50,"context_line":"  authorized_key:"},{"line_number":51,"context_line":"    user: kolla"},{"line_number":52,"context_line":"    key: \"{{ kolla_ssh_key.public_key }}\""},{"line_number":53,"context_line":"  become: True"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: install apt packages"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_40432baf","line":52,"in_reply_to":"bacf61ea_86bee662","updated":"2016-08-05 16:59:27.000000000","message":"thanks will add","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d605d972a96cf302b7817c25c95eed7fd65cf1f0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  become: True"},{"line_number":108,"context_line":"  when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Ensure stack directory exists"},{"line_number":111,"context_line":"  file:"},{"line_number":112,"context_line":"    path: /opt/stack"},{"line_number":113,"context_line":"    state: directory"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_3e4c7a41","line":110,"updated":"2016-08-05 06:11:13.000000000","message":"I dont understand point of this task.  could you explain?","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"49607f70e119231630fb65faa5b5f3ca0b0d03ff","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  become: True"},{"line_number":108,"context_line":"  when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Ensure stack directory exists"},{"line_number":111,"context_line":"  file:"},{"line_number":112,"context_line":"    path: /opt/stack"},{"line_number":113,"context_line":"    state: directory"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_a062e73b","line":110,"in_reply_to":"bacf61ea_3e4c7a41","updated":"2016-08-05 16:59:27.000000000","message":"oh this should be deleted this was for setting up the build host.\nits not needed","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d605d972a96cf302b7817c25c95eed7fd65cf1f0","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"- name: Ensure stack directory exists"},{"line_number":111,"context_line":"  file:"},{"line_number":112,"context_line":"    path: /opt/stack"},{"line_number":113,"context_line":"    state: directory"},{"line_number":114,"context_line":"    recurse: yes"},{"line_number":115,"context_line":"    owner: kolla"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_be5eaae6","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":9},"updated":"2016-08-05 06:11:13.000000000","message":"ify ou ned persistent files, /var/lib/kolla is where they belong","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"ed359f77bc0552ba2ddda08af22982cbea722b0f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    line\u003d\"{{ \u0027#\u0027 }}kolla-ansible hosts\""},{"line_number":35,"context_line":"    insertafter\u003dEOF"},{"line_number":36,"context_line":"    state\u003dpresent"},{"line_number":37,"context_line":"  when: customize_etc_hosts | bool \u003d\u003d True"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- include: append_to_etc_hosts.yml"},{"line_number":40,"context_line":"  with_inventory_hostnames: baremetal"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_abc33188","line":37,"updated":"2016-08-10 10:55:58.000000000","message":"needs \u0027become: true\u0027","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"92b251dc92ef98a7ffa1c791080b98d08bd09251","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    line\u003d\"{{ \u0027#\u0027 }}kolla-ansible hosts\""},{"line_number":35,"context_line":"    insertafter\u003dEOF"},{"line_number":36,"context_line":"    state\u003dpresent"},{"line_number":37,"context_line":"  when: customize_etc_hosts | bool \u003d\u003d True"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- include: append_to_etc_hosts.yml"},{"line_number":40,"context_line":"  with_inventory_hostnames: baremetal"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_befcfb72","line":37,"in_reply_to":"9ad45d7e_6c9caf5d","updated":"2016-08-10 16:05:18.000000000","message":"Done","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3b34734396d70874683280fea5273695b1cae36","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    line\u003d\"{{ \u0027#\u0027 }}kolla-ansible hosts\""},{"line_number":35,"context_line":"    insertafter\u003dEOF"},{"line_number":36,"context_line":"    state\u003dpresent"},{"line_number":37,"context_line":"  when: customize_etc_hosts | bool \u003d\u003d True"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- include: append_to_etc_hosts.yml"},{"line_number":40,"context_line":"  with_inventory_hostnames: baremetal"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_6c9caf5d","line":37,"in_reply_to":"9ad45d7e_abc33188","updated":"2016-08-10 11:59:28.000000000","message":"yes sorry i was testing as root\nill correct this thanks.","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"ed359f77bc0552ba2ddda08af22982cbea722b0f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    loop_var: baremetal_node"},{"line_number":43,"context_line":"  when: customize_etc_hosts | bool \u003d\u003d True"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- group: name\u003dsudo state\u003dpresent"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- group: name\u003dkolla state\u003dpresent"},{"line_number":48,"context_line":"  when: create_kolla_user | bool \u003d\u003d True"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_ebb9a916","line":45,"updated":"2016-08-10 10:55:58.000000000","message":"needs \u0027become: true\u0027","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"92b251dc92ef98a7ffa1c791080b98d08bd09251","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    loop_var: baremetal_node"},{"line_number":43,"context_line":"  when: customize_etc_hosts | bool \u003d\u003d True"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- group: name\u003dsudo state\u003dpresent"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- group: name\u003dkolla state\u003dpresent"},{"line_number":48,"context_line":"  when: create_kolla_user | bool \u003d\u003d True"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_fefaf373","line":45,"in_reply_to":"9ad45d7e_ebb9a916","updated":"2016-08-10 16:05:18.000000000","message":"Done","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"ed359f77bc0552ba2ddda08af22982cbea722b0f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- group: name\u003dsudo state\u003dpresent"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- group: name\u003dkolla state\u003dpresent"},{"line_number":48,"context_line":"  when: create_kolla_user | bool \u003d\u003d True"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: create kolla user"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_8b3f4d86","line":47,"updated":"2016-08-10 10:55:58.000000000","message":"needs \u0027become: true\u0027","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"92b251dc92ef98a7ffa1c791080b98d08bd09251","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- group: name\u003dsudo state\u003dpresent"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- group: name\u003dkolla state\u003dpresent"},{"line_number":48,"context_line":"  when: create_kolla_user | bool \u003d\u003d True"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: create kolla user"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_def72f89","line":47,"in_reply_to":"9ad45d7e_8b3f4d86","updated":"2016-08-10 16:05:18.000000000","message":"Done","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"}],"ansible/roles/baremetal/templates/docker_defaults.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"50eb89b42c7a3da2a2579b06ec78b79316435b37","unresolved":false,"context_lines":[{"line_number":16,"context_line":"DOCKER_OPTS\u003d\"$DOCKER_OPTS --storage-driver\u003d{{ docker_storage_driver }}\""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"{% if docker_registry %}"},{"line_number":19,"context_line":"DOCKER_OPTS\u003d\"$DOCKER_OPTS --insecure-registry  {{ docker_registry }}\""},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# If you need Docker to use an HTTP proxy, it can also be specified here."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1ac06dbe_11a37d9e","line":19,"updated":"2016-08-23 04:31:20.000000000","message":"what if the registry isn\u0027t insecure but using tls as it should be?","commit_id":"3e8f9986d1229896af3e52e5a138bcbb7244a449"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6b10e4f48f3f375bbd4d7ea0d325788e4f4f5973","unresolved":false,"context_lines":[{"line_number":16,"context_line":"DOCKER_OPTS\u003d\"$DOCKER_OPTS --storage-driver\u003d{{ docker_storage_driver }}\""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"{% if docker_registry %}"},{"line_number":19,"context_line":"DOCKER_OPTS\u003d\"$DOCKER_OPTS --insecure-registry  {{ docker_registry }}\""},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# If you need Docker to use an HTTP proxy, it can also be specified here."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1ac06dbe_12bd24b7","line":19,"in_reply_to":"1ac06dbe_11a37d9e","updated":"2016-08-23 12:43:34.000000000","message":"i dont believe have a registry listed as an insecure-registry prevent http from being used but i can add a registry type variable to control this in a follow up commit.\n\ncurrently our quickstart guides assume you are using an insecure registry hence that is what i implemented.","commit_id":"3e8f9986d1229896af3e52e5a138bcbb7244a449"}],"ansible/roles/baremetal/templates/docker_systemd_service.j2":[{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"MountFlags\u003dshared"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_aa5858fb","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":9},"updated":"2016-06-10 23:22:45.000000000","message":"need insecure registry. and also the upstart version of that.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9b013b8fdc118189c54eb1a54b957993d45b0e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"MountFlags\u003dshared"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_9355971f","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":9},"in_reply_to":"7aa08908_aa5858fb","updated":"2016-06-13 20:01:08.000000000","message":"ah yes thanks ill add both","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"f5d2357e11096d8588ab001f31c21b65ce3e9f38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"MountFlags\u003dshared"},{"line_number":3,"context_line":"ExecStart\u003d"},{"line_number":4,"context_line":"ExecStart\u003d/usr/bin/docker daemon -H fd:// \\"},{"line_number":5,"context_line":"{% if docker_registry %}"},{"line_number":6,"context_line":"--insecure-registry  {{ docker_registry }} \\"},{"line_number":7,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_d47eef68","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":41},"updated":"2016-08-04 20:16:33.000000000","message":"Adding btrfs support later?","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"319b36ce27bee13e13a33d6fc3c6fe4877102e40","unresolved":false,"context_lines":[{"line_number":6,"context_line":"--insecure-registry  {{ docker_registry }} \\"},{"line_number":7,"context_line":"{% endif %}"},{"line_number":8,"context_line":"{% if docker_storage_driver %}"},{"line_number":9,"context_line":"--storage-driver\u003d{{ docker_storage_driver }}"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":" -H fd://"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ad45d7e_bf5c2bee","line":9,"updated":"2016-08-09 20:20:13.000000000","message":"I don\u0027t see default for this var. This will be tricky tho. I think safest bet would be to setup btrfs on loopback","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3b34734396d70874683280fea5273695b1cae36","unresolved":false,"context_lines":[{"line_number":6,"context_line":"--insecure-registry  {{ docker_registry }} \\"},{"line_number":7,"context_line":"{% endif %}"},{"line_number":8,"context_line":"{% if docker_storage_driver %}"},{"line_number":9,"context_line":"--storage-driver\u003d{{ docker_storage_driver }}"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":" -H fd://"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ad45d7e_4cbe0b66","line":9,"in_reply_to":"9ad45d7e_bf5c2bee","updated":"2016-08-10 11:59:28.000000000","message":"i did not default it intentionally.\ni did remove the default of the empty string\nby mistake form the defaults file which i will\nreadd\n\nunless the user sets docker_storage_driver\nit will use the default chosen by the package manger. \ni intend to add support for setting up btrfs as a follow up patch.\n\nthe current assumption is that if the user sets this value, the os image deployed on the server has the correct filesystem for the driver.\n\none caveat to running btrfs on loopback is that it will likely perform worse. devicemapper on a dedicated disk preforms much better then devicemapper on a loopback device.","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"}],"ansible/roles/baremetal/templates/hosts.j2":[{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"127.0.0.1   {{ inventory_hostname }} localhost localhost.localdomain localhost4 localhost4.localdomain4"},{"line_number":2,"context_line":"::1         {{ inventory_hostname }} localhost localhost.localdomain localhost6 localhost6.localdomain6"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% for host in groups[\u0027baremetal\u0027] %}"},{"line_number":5,"context_line":"{% set short_name \u003d host.split(\u0027.\u0027) %}"},{"line_number":6,"context_line":"{{ hostvars[host][\u0027ansible_\u0027+ baremetal_nic][\u0027ipv4\u0027][\u0027address\u0027] }}  {{ host }} {{ short_name[0] }}"},{"line_number":7,"context_line":"{% endfor %}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_048526ac","line":7,"range":{"start_line":1,"start_character":0,"end_line":7,"end_character":12},"updated":"2016-06-10 23:22:45.000000000","message":"Some environments will already have DNS and will not want this. Perhaps we could detect whether inventory hostnames are already pingable, present an option for whether the hosts file is already correct or not (customize_hostsfile: True/False), or etc.\n\nI have a pattern that can customize hosts on a per-host basis but I find it hard to follow. It has been stable in other places I\u0027ve used it, but I don\u0027t think it\u0027s a fit unless people want this process to add kolla hosts in /etc/hosts AND still keep prior customizations to the file (like if they used a config drive that sets \u0027manage_hosts: True\u0027 via cloud-init). I ported it from a working playbook, but this version is not tested: (https://gist.github.com/mark-casey/fffa714b13bfaac19a73eb94377bfcb5).","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9b013b8fdc118189c54eb1a54b957993d45b0e8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"127.0.0.1   {{ inventory_hostname }} localhost localhost.localdomain localhost4 localhost4.localdomain4"},{"line_number":2,"context_line":"::1         {{ inventory_hostname }} localhost localhost.localdomain localhost6 localhost6.localdomain6"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% for host in groups[\u0027baremetal\u0027] %}"},{"line_number":5,"context_line":"{% set short_name \u003d host.split(\u0027.\u0027) %}"},{"line_number":6,"context_line":"{{ hostvars[host][\u0027ansible_\u0027+ baremetal_nic][\u0027ipv4\u0027][\u0027address\u0027] }}  {{ host }} {{ short_name[0] }}"},{"line_number":7,"context_line":"{% endfor %}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_ce4db473","line":7,"range":{"start_line":1,"start_character":0,"end_line":7,"end_character":12},"in_reply_to":"7aa08908_048526ac","updated":"2016-06-13 20:01:08.000000000","message":"yes i you are right this should be configurable.\n\nill take a look at https://gist.github.com/mark-casey/fffa714b13bfaac19a73eb94377bfcb5 too.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"}],"ansible/site.yml":[{"author":{"_account_id":21530,"name":"Mark Casey","email":"mark.casey@moddulo.us","username":"mark-casey"},"change_message_id":"d37427fdc1a9c51bb2579b484eecc1072cc667ce","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        tags: manila,"},{"line_number":223,"context_line":"        when: enable_manila | bool }"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"- hosts:"},{"line_number":226,"context_line":"    - baremetal"},{"line_number":227,"context_line":"  roles:"},{"line_number":228,"context_line":"    - { role: baremetal,"},{"line_number":229,"context_line":"        tags: baremetal }"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_e7f8d97e","line":229,"range":{"start_line":225,"start_character":0,"end_line":229,"end_character":25},"updated":"2016-06-10 23:22:45.000000000","message":"I think this goes away if baremetal is a separate action that site.yml does not include.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c53e674545fa8897611cd6e7ab9d653e64b1c8f4","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    - baremetal"},{"line_number":227,"context_line":"  roles:"},{"line_number":228,"context_line":"    - { role: baremetal,"},{"line_number":229,"context_line":"        tags: baremetal }"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a9d85d2_5da0be43","line":229,"updated":"2016-06-21 08:44:20.000000000","message":"yes. use a separater playbooks file.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9b013b8fdc118189c54eb1a54b957993d45b0e8","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        tags: manila,"},{"line_number":223,"context_line":"        when: enable_manila | bool }"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"- hosts:"},{"line_number":226,"context_line":"    - baremetal"},{"line_number":227,"context_line":"  roles:"},{"line_number":228,"context_line":"    - { role: baremetal,"},{"line_number":229,"context_line":"        tags: baremetal }"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_ee6fd0c1","line":229,"range":{"start_line":225,"start_character":0,"end_line":229,"end_character":25},"in_reply_to":"7aa08908_e7f8d97e","updated":"2016-06-13 20:01:08.000000000","message":"as i am making this a separate playbook this will go away.","commit_id":"96ea633042d61643d5ae2f5dba013894cff459f2"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"f5d2357e11096d8588ab001f31c21b65ce3e9f38","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    - { role: watcher,"},{"line_number":257,"context_line":"        tags: watcher,"},{"line_number":258,"context_line":"        when: enable_watcher | bool }"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_545ddf13","line":259,"updated":"2016-08-04 20:16:33.000000000","message":"whitespace","commit_id":"7988ccf3c6c386507c5e280d661e687564bfd2f0"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d605d972a96cf302b7817c25c95eed7fd65cf1f0","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    - { role: watcher,"},{"line_number":257,"context_line":"        tags: watcher,"},{"line_number":258,"context_line":"        when: enable_watcher | bool }"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_fe0b02d3","line":259,"updated":"2016-08-05 06:11:13.000000000","message":"random line added can be removed","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"49607f70e119231630fb65faa5b5f3ca0b0d03ff","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    - { role: watcher,"},{"line_number":257,"context_line":"        tags: watcher,"},{"line_number":258,"context_line":"        when: enable_watcher | bool }"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bacf61ea_604d8fc3","line":259,"in_reply_to":"bacf61ea_fe0b02d3","updated":"2016-08-05 16:59:27.000000000","message":"yes will do","commit_id":"e323aa8563e2190c89d739ee09030002584d93b5"}],"kolla/cmd/genpwd.py":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"e9e51f42556bda84b8a87cacddda058de3d5b494","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    uuid_keys \u003d [\u0027ceph_cluster_fsid\u0027, \u0027rbd_secret_uuid\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # SSH key pair"},{"line_number":46,"context_line":"    ssh_keys \u003d [\u0027kolla_ssh_key,nova_ssh_key\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # If these keys are None, leave them as None"},{"line_number":49,"context_line":"    blank_keys \u003d [\u0027docker_registry_password\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_a944cf1a","line":46,"updated":"2016-08-10 14:16:06.000000000","message":"These should be two separate list items","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"92b251dc92ef98a7ffa1c791080b98d08bd09251","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    uuid_keys \u003d [\u0027ceph_cluster_fsid\u0027, \u0027rbd_secret_uuid\u0027]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # SSH key pair"},{"line_number":46,"context_line":"    ssh_keys \u003d [\u0027kolla_ssh_key,nova_ssh_key\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # If these keys are None, leave them as None"},{"line_number":49,"context_line":"    blank_keys \u003d [\u0027docker_registry_password\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_7e060387","line":46,"in_reply_to":"9ad45d7e_a944cf1a","updated":"2016-08-10 16:05:18.000000000","message":"Done","commit_id":"1bf6e8b7f99b0f8180786c91a8b9fe017853184e"}]}