)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d36e77661fee1e79ad210ba1b259f1899d6302f2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set fixes all Magnum issues in kolla master."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The [trust] section is generated into ansible/roles/magnum/templates/magnum.conf.j2"},{"line_number":12,"context_line":"using created trustee domain and user for Magnum by"},{"line_number":13,"context_line":"ansible/roles/magnum/templates/create_magnum_domain_user.sh script."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a8bc5a2_0287d1b5","line":11,"updated":"2016-09-23 02:02:34.000000000","message":"this description should be change. we add the [trust] section directly now.","commit_id":"923f691021b9303942d6d066f082b60419e2e1e3"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"c88c170e83c5fad1a4e1050ced955f487106b8c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set fixes all Magnum issues in kolla master."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The [trust] section is generated into ansible/roles/magnum/templates/magnum.conf.j2"},{"line_number":12,"context_line":"using created trustee domain and user for Magnum by"},{"line_number":13,"context_line":"ansible/roles/magnum/templates/create_magnum_domain_user.sh script."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a8bc5a2_61ebe013","line":11,"in_reply_to":"5a8bc5a2_0287d1b5","updated":"2016-09-26 05:58:21.000000000","message":"Done","commit_id":"923f691021b9303942d6d066f082b60419e2e1e3"}],"ansible/roles/magnum/tasks/config.yml":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"0720b6081c4cf098c87ba72ce71c3641b01508eb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                        \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3\" \\"},{"line_number":23,"context_line":"                        {{ role_path }}"},{"line_number":24,"context_line":"  register: status"},{"line_number":25,"context_line":"  changed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) !\u003d -1"},{"line_number":26,"context_line":"  failed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) \u003d\u003d -1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Copying over magnum.conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7aa08908_24453f6e","line":25,"updated":"2016-06-14 18:38:27.000000000","message":"please follow up with our standard and output json with \u0027failed\u0027 either true or false","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"1c0d12f6adbab9c070da9f96ea36e64493e6623a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                        \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3\" \\"},{"line_number":23,"context_line":"                        {{ role_path }}"},{"line_number":24,"context_line":"  register: status"},{"line_number":25,"context_line":"  changed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) !\u003d -1"},{"line_number":26,"context_line":"  failed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) \u003d\u003d -1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Copying over magnum.conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_09d14357","line":25,"in_reply_to":"7aa08908_24453f6e","updated":"2016-09-22 00:25:56.000000000","message":"Done","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":22835,"name":"Bartłomiej Daca","email":"bartek.daca@gmail.com","username":"bdaca"},"change_message_id":"87107316f7320162e68967222dc1d910304b8435","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    - \"magnum-api\""},{"line_number":17,"context_line":"    - \"magnum-conductor\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Creating trustee domain and user for magnum and updating magnum.conf.j2"},{"line_number":20,"context_line":"  local_action: command {{ role_path }}/templates/create_magnum_domain_user.sh \\"},{"line_number":21,"context_line":"                        {{ magnum_keystone_password }} {{ keystone_admin_password }} \\"},{"line_number":22,"context_line":"                        \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3\" \\"},{"line_number":23,"context_line":"                        {{ role_path }}"},{"line_number":24,"context_line":"  register: status"},{"line_number":25,"context_line":"  changed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) !\u003d -1"},{"line_number":26,"context_line":"  failed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) \u003d\u003d -1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Copying over magnum.conf"},{"line_number":29,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_5ed3b138","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":85},"updated":"2016-07-28 06:21:33.000000000","message":"This will fail on multinode installation","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"1c0d12f6adbab9c070da9f96ea36e64493e6623a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    - \"magnum-api\""},{"line_number":17,"context_line":"    - \"magnum-conductor\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Creating trustee domain and user for magnum and updating magnum.conf.j2"},{"line_number":20,"context_line":"  local_action: command {{ role_path }}/templates/create_magnum_domain_user.sh \\"},{"line_number":21,"context_line":"                        {{ magnum_keystone_password }} {{ keystone_admin_password }} \\"},{"line_number":22,"context_line":"                        \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3\" \\"},{"line_number":23,"context_line":"                        {{ role_path }}"},{"line_number":24,"context_line":"  register: status"},{"line_number":25,"context_line":"  changed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) !\u003d -1"},{"line_number":26,"context_line":"  failed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) \u003d\u003d -1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Copying over magnum.conf"},{"line_number":29,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_69cc87bb","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":85},"in_reply_to":"9a89bdaa_9ddb52ed","updated":"2016-09-22 00:25:56.000000000","message":"Done","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"1c0d12f6adbab9c070da9f96ea36e64493e6623a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    - \"magnum-api\""},{"line_number":17,"context_line":"    - \"magnum-conductor\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Creating trustee domain and user for magnum and updating magnum.conf.j2"},{"line_number":20,"context_line":"  local_action: command {{ role_path }}/templates/create_magnum_domain_user.sh \\"},{"line_number":21,"context_line":"                        {{ magnum_keystone_password }} {{ keystone_admin_password }} \\"},{"line_number":22,"context_line":"                        \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3\" \\"},{"line_number":23,"context_line":"                        {{ role_path }}"},{"line_number":24,"context_line":"  register: status"},{"line_number":25,"context_line":"  changed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) !\u003d -1"},{"line_number":26,"context_line":"  failed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) \u003d\u003d -1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Copying over magnum.conf"},{"line_number":29,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_49c7cb97","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":85},"in_reply_to":"bacf61ea_5ed3b138","updated":"2016-09-22 00:25:56.000000000","message":"Done","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":23440,"name":"jiriprox","email":"jirix.x.prokes@intel.com","username":"jiriprox"},"change_message_id":"952979b476163346ef4d20f43e6bbbdb2115119e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    - \"magnum-api\""},{"line_number":17,"context_line":"    - \"magnum-conductor\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Creating trustee domain and user for magnum and updating magnum.conf.j2"},{"line_number":20,"context_line":"  local_action: command {{ role_path }}/templates/create_magnum_domain_user.sh \\"},{"line_number":21,"context_line":"                        {{ magnum_keystone_password }} {{ keystone_admin_password }} \\"},{"line_number":22,"context_line":"                        \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3\" \\"},{"line_number":23,"context_line":"                        {{ role_path }}"},{"line_number":24,"context_line":"  register: status"},{"line_number":25,"context_line":"  changed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) !\u003d -1"},{"line_number":26,"context_line":"  failed_when: status.stdout.find(\u0027Trustee domain and user created for magnum\u0027) \u003d\u003d -1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Copying over magnum.conf"},{"line_number":29,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a89bdaa_9ddb52ed","line":26,"range":{"start_line":19,"start_character":0,"end_line":26,"end_character":85},"in_reply_to":"bacf61ea_5ed3b138","updated":"2016-09-05 09:52:31.000000000","message":"Yes this is failing on multimode(multi-controller) installation.\nrun_once option \"run_once: True\" have to be added behind \"register: status\"\n\nWith this correction is fix working on multimode as well.","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"}],"ansible/roles/magnum/tasks/start.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4cd374c7df57bfd624e35ca009b0c10759830ff0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    volumes:"},{"line_number":21,"context_line":"      - \"{{ node_config_directory }}/magnum-conductor/:{{ container_config_directory }}/:ro\""},{"line_number":22,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":23,"context_line":"      - \"magnum_conductor:/var/lib/magnum/\""},{"line_number":24,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":25,"context_line":"  when: inventory_hostname in groups[\u0027magnum-conductor\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_0ebdc5b6","line":23,"updated":"2016-09-26 16:22:58.000000000","message":"why use magnum_conductor? why not use magnum like other service?\nall nova service use nova volume name.","commit_id":"2b48953f5b5d5ddc53a847352fe27b7f70f887cd"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"9f9b122d5ac96f5b8630e7a053bb3eb17e30d4f5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    volumes:"},{"line_number":21,"context_line":"      - \"{{ node_config_directory }}/magnum-conductor/:{{ container_config_directory }}/:ro\""},{"line_number":22,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":23,"context_line":"      - \"magnum_conductor:/var/lib/magnum/\""},{"line_number":24,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":25,"context_line":"  when: inventory_hostname in groups[\u0027magnum-conductor\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_ba47584a","line":23,"in_reply_to":"5a8bc5a2_0ebdc5b6","updated":"2016-09-27 21:50:42.000000000","message":"changed to \"magnum\".\nDone","commit_id":"2b48953f5b5d5ddc53a847352fe27b7f70f887cd"}],"ansible/roles/magnum/templates/create_magnum_domain_user.sh":[{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"807d5d1aac3883cd6cef17974232d73521b6e4f2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"changed\u003d\"true\""},{"line_number":30,"context_line":"TRUSTEE_DOMAIN_ID\u003d$("},{"line_number":31,"context_line":"    openstack domain create magnum \\"},{"line_number":32,"context_line":"        --description \"Owns users and projects created by magnum\" \\"},{"line_number":33,"context_line":"        -f value -c id"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a8bc5a2_dd9eeb06","line":30,"updated":"2016-09-22 04:45:20.000000000","message":"Open point - Should the \u0027kolla_keystone_user\u0027 module from the toolbox be used instead? In other roles it\u0027s usually used for creating user/role, but there are 2 things different in case of trustees for magnum:\n\n1. a new domain needs to be created for magnum. kolla_keystone_user does not have such option/parameter yet, then this should probably be added then into kolla_keystone_user module \n\n2. user id and domain id needs to be fetched for magnum trustee configuration. Using kolla_keystone_user it is not possible to get such info back (?) and thus openstack queries should be executed anyway for getting the ids as part of this script.\n\nEspecially considering (2.) it\u0027s perhaps also ok to leave current domain/user/role insertion as part of this bash script (?)","commit_id":"c54185ffd6ae323497c67eee1e9691927e28e9cb"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2ae1f6b0afa1f969a93601652cc7961c333e98ec","unresolved":false,"context_lines":[{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Compose magnum_trustee.conf file with trustee config"},{"line_number":59,"context_line":"sudo cat \u003e$ROLE_PATH/templates/magnum_trustee.conf \u003c\u003c EOL"},{"line_number":60,"context_line":"[trust]"},{"line_number":61,"context_line":"trustee_domain_admin_password\u003d$TRUSTEE_DOMAIN_ADMIN_PASSWORD"},{"line_number":62,"context_line":"trustee_domain_admin_id\u003d$TRUSTEE_DOMAIN_ADMIN_ID"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a8bc5a2_b15f8874","line":59,"updated":"2016-09-22 07:00:36.000000000","message":"change the file content is template path is not good. one possible solution is: export these values into ansible fact.","commit_id":"c54185ffd6ae323497c67eee1e9691927e28e9cb"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"d71068a97dd93a5fac8e0cd96b7786482a8a7223","unresolved":false,"context_lines":[{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Compose magnum_trustee.conf file with trustee config"},{"line_number":59,"context_line":"sudo cat \u003e$ROLE_PATH/templates/magnum_trustee.conf \u003c\u003c EOL"},{"line_number":60,"context_line":"[trust]"},{"line_number":61,"context_line":"trustee_domain_admin_password\u003d$TRUSTEE_DOMAIN_ADMIN_PASSWORD"},{"line_number":62,"context_line":"trustee_domain_admin_id\u003d$TRUSTEE_DOMAIN_ADMIN_ID"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a8bc5a2_0ccf0857","line":59,"in_reply_to":"5a8bc5a2_b15f8874","updated":"2016-09-23 00:36:34.000000000","message":"Done\n\nNow the values are returned via json, added to ansible facts and put into magnum.conf","commit_id":"c54185ffd6ae323497c67eee1e9691927e28e9cb"},{"author":{"_account_id":22835,"name":"Bartłomiej Daca","email":"bartek.daca@gmail.com","username":"bdaca"},"change_message_id":"e7d476d7d2ddc1434c18f5655a92ea44c937ebb5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"changed\u003d\"true\""},{"line_number":26,"context_line":"TRUSTEE_DOMAIN_ID\u003d$("},{"line_number":27,"context_line":"    openstack domain create magnum \\"},{"line_number":28,"context_line":"        --description \"Owns users and projects created by magnum\" \\"},{"line_number":29,"context_line":"        -f value -c id"},{"line_number":30,"context_line":")"},{"line_number":31,"context_line":"if [[ $? !\u003d 0 ]]; then"},{"line_number":32,"context_line":"    fail_json \"${TRUSTEE_DOMAIN_ID}\""},{"line_number":33,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a8bc5a2_013f7c24","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":1},"updated":"2016-09-26 06:16:34.000000000","message":"This will fail when you execute \u0027deploy\u0027 task multiple times. You have to check if domain named \u0027magnum\u0027 exists at first.","commit_id":"2b48953f5b5d5ddc53a847352fe27b7f70f887cd"},{"author":{"_account_id":22835,"name":"Bartłomiej Daca","email":"bartek.daca@gmail.com","username":"bdaca"},"change_message_id":"cda360b5dc19d7a02a722a27cb264c8d49d0b9c9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"changed\u003d\"true\""},{"line_number":26,"context_line":"TRUSTEE_DOMAIN_ID\u003d$("},{"line_number":27,"context_line":"    openstack domain create magnum \\"},{"line_number":28,"context_line":"        --description \"Owns users and projects created by magnum\" \\"},{"line_number":29,"context_line":"        -f value -c id"},{"line_number":30,"context_line":")"},{"line_number":31,"context_line":"if [[ $? !\u003d 0 ]]; then"},{"line_number":32,"context_line":"    fail_json \"${TRUSTEE_DOMAIN_ID}\""},{"line_number":33,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a8bc5a2_a47a5675","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":1},"in_reply_to":"5a8bc5a2_013f7c24","updated":"2016-09-26 06:44:04.000000000","message":"There is an inconsistency now. In heat kolla creates domain in docker bootstrap. Here we have a bash script for this. So it looks like we have three ways now to do all the registration stuff: init in docker (heat), init by script (here), init by kolla_toolbox (everywhere else, but without domains stuff). Are we sure we want to follow this path?","commit_id":"2b48953f5b5d5ddc53a847352fe27b7f70f887cd"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"9f9b122d5ac96f5b8630e7a053bb3eb17e30d4f5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"changed\u003d\"true\""},{"line_number":26,"context_line":"TRUSTEE_DOMAIN_ID\u003d$("},{"line_number":27,"context_line":"    openstack domain create magnum \\"},{"line_number":28,"context_line":"        --description \"Owns users and projects created by magnum\" \\"},{"line_number":29,"context_line":"        -f value -c id"},{"line_number":30,"context_line":")"},{"line_number":31,"context_line":"if [[ $? !\u003d 0 ]]; then"},{"line_number":32,"context_line":"    fail_json \"${TRUSTEE_DOMAIN_ID}\""},{"line_number":33,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a8bc5a2_bab59832","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":1},"in_reply_to":"5a8bc5a2_013f7c24","updated":"2016-09-27 21:50:42.000000000","message":"changed to call of kolla-toolbox os modules.\nDone.","commit_id":"2b48953f5b5d5ddc53a847352fe27b7f70f887cd"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"9f9b122d5ac96f5b8630e7a053bb3eb17e30d4f5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"changed\u003d\"true\""},{"line_number":26,"context_line":"TRUSTEE_DOMAIN_ID\u003d$("},{"line_number":27,"context_line":"    openstack domain create magnum \\"},{"line_number":28,"context_line":"        --description \"Owns users and projects created by magnum\" \\"},{"line_number":29,"context_line":"        -f value -c id"},{"line_number":30,"context_line":")"},{"line_number":31,"context_line":"if [[ $? !\u003d 0 ]]; then"},{"line_number":32,"context_line":"    fail_json \"${TRUSTEE_DOMAIN_ID}\""},{"line_number":33,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a8bc5a2_3aa988e0","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":1},"in_reply_to":"5a8bc5a2_a47a5675","updated":"2016-09-27 21:50:42.000000000","message":"changed to call of kolla-toolbox os modules.\nDone.","commit_id":"2b48953f5b5d5ddc53a847352fe27b7f70f887cd"},{"author":{"_account_id":22835,"name":"Bartłomiej Daca","email":"bartek.daca@gmail.com","username":"bdaca"},"change_message_id":"cda360b5dc19d7a02a722a27cb264c8d49d0b9c9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    fail_json \"${TRUSTEE_DOMAIN_ADMIN_ID}\""},{"line_number":44,"context_line":"fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ROLE_ADD\u003d$(openstack --os-identity-api-version 3 role add \\"},{"line_number":47,"context_line":"            --user $TRUSTEE_DOMAIN_ADMIN_ID --domain $TRUSTEE_DOMAIN_ID \\"},{"line_number":48,"context_line":"            admin"},{"line_number":49,"context_line":")"},{"line_number":50,"context_line":"if [[ $? !\u003d 0 ]]; then"},{"line_number":51,"context_line":"    fail_json \"${ROLE_ADD}\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a8bc5a2_04ddca6e","line":48,"range":{"start_line":46,"start_character":11,"end_line":48,"end_character":17},"updated":"2016-09-26 06:44:04.000000000","message":"This will fail when executing \u0027deploy\u0027 task multiple times too.","commit_id":"2b48953f5b5d5ddc53a847352fe27b7f70f887cd"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"9f9b122d5ac96f5b8630e7a053bb3eb17e30d4f5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    fail_json \"${TRUSTEE_DOMAIN_ADMIN_ID}\""},{"line_number":44,"context_line":"fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ROLE_ADD\u003d$(openstack --os-identity-api-version 3 role add \\"},{"line_number":47,"context_line":"            --user $TRUSTEE_DOMAIN_ADMIN_ID --domain $TRUSTEE_DOMAIN_ID \\"},{"line_number":48,"context_line":"            admin"},{"line_number":49,"context_line":")"},{"line_number":50,"context_line":"if [[ $? !\u003d 0 ]]; then"},{"line_number":51,"context_line":"    fail_json \"${ROLE_ADD}\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a8bc5a2_1a7bec7c","line":48,"range":{"start_line":46,"start_character":11,"end_line":48,"end_character":17},"in_reply_to":"5a8bc5a2_04ddca6e","updated":"2016-09-27 21:50:42.000000000","message":"changed to call of kolla-toolbox os modules.\nDone.","commit_id":"2b48953f5b5d5ddc53a847352fe27b7f70f887cd"}],"ansible/roles/magnum/templates/magnum.conf.j2":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"0720b6081c4cf098c87ba72ce71c3641b01508eb","unresolved":false,"context_lines":[{"line_number":51,"context_line":"[trust]"},{"line_number":52,"context_line":"trustee_domain_admin_password \u003d VogjaaQ0jZLzbwLiCVZDKTJA73pE7wVNrymOkwWa"},{"line_number":53,"context_line":"trustee_domain_admin_id \u003d 93d58ca6271c4e7e9bc8cefe42e35723"},{"line_number":54,"context_line":"trustee_domain_id \u003d ef989aec33d64a97b092162a6334e766"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_concurrency]"},{"line_number":57,"context_line":"lock_path \u003d /var/lib/magnum/tmp"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_44420b69","line":54,"updated":"2016-06-14 18:38:27.000000000","message":"Alternatively, if you want to sed it up, put meaningful placeholder like \u003c\u003c trustee_domain_id \u003e\u003e. But as Jeffrey said you can do this with ansible templating. Just output json from task creating domain and then register output.","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"03e0c14fac54e6cb867c25103eec75baa1ff8a95","unresolved":false,"context_lines":[{"line_number":49,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[trust]"},{"line_number":52,"context_line":"trustee_domain_admin_password \u003d VogjaaQ0jZLzbwLiCVZDKTJA73pE7wVNrymOkwWa"},{"line_number":53,"context_line":"trustee_domain_admin_id \u003d 93d58ca6271c4e7e9bc8cefe42e35723"},{"line_number":54,"context_line":"trustee_domain_id \u003d ef989aec33d64a97b092162a6334e766"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_concurrency]"},{"line_number":57,"context_line":"lock_path \u003d /var/lib/magnum/tmp"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_bd743d9c","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":52},"updated":"2016-06-06 22:50:39.000000000","message":"These fields are not hardcoded here.  These values are from my test results.  The values for these fields will be dynamically updated using \"sed\" by  ansible/roles/magnum/templates/create_magnum_domain_user.sh  after creating the trustee domain and user for Magnum.\n\nLine # 20 in  ansible/roles/magnum/templates/magnum.conf.j2  calls  ansible/roles/magnum/templates/create_magnum_domain_user.sh  before copying magnum.conf.j2 to node_config_directory (/etc/kolla/magnum-*).","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7bef2d9f0b268fd9c8c8846277ddb608d7d3fbf8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"[trust]"},{"line_number":52,"context_line":"trustee_domain_admin_password \u003d VogjaaQ0jZLzbwLiCVZDKTJA73pE7wVNrymOkwWa"},{"line_number":53,"context_line":"trustee_domain_admin_id \u003d 93d58ca6271c4e7e9bc8cefe42e35723"},{"line_number":54,"context_line":"trustee_domain_id \u003d ef989aec33d64a97b092162a6334e766"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_concurrency]"},{"line_number":57,"context_line":"lock_path \u003d /var/lib/magnum/tmp"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_9b07c61b","line":54,"updated":"2016-06-07 02:34:54.000000000","message":"why not try to set these value by using ansible template/merge_config plugin?","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"1c0d12f6adbab9c070da9f96ea36e64493e6623a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"[trust]"},{"line_number":52,"context_line":"trustee_domain_admin_password \u003d VogjaaQ0jZLzbwLiCVZDKTJA73pE7wVNrymOkwWa"},{"line_number":53,"context_line":"trustee_domain_admin_id \u003d 93d58ca6271c4e7e9bc8cefe42e35723"},{"line_number":54,"context_line":"trustee_domain_id \u003d ef989aec33d64a97b092162a6334e766"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_concurrency]"},{"line_number":57,"context_line":"lock_path \u003d /var/lib/magnum/tmp"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_c9bbdb0d","line":54,"in_reply_to":"7aa08908_44420b69","updated":"2016-09-22 00:25:56.000000000","message":"Done","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"1c0d12f6adbab9c070da9f96ea36e64493e6623a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"[trust]"},{"line_number":52,"context_line":"trustee_domain_admin_password \u003d VogjaaQ0jZLzbwLiCVZDKTJA73pE7wVNrymOkwWa"},{"line_number":53,"context_line":"trustee_domain_admin_id \u003d 93d58ca6271c4e7e9bc8cefe42e35723"},{"line_number":54,"context_line":"trustee_domain_id \u003d ef989aec33d64a97b092162a6334e766"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_concurrency]"},{"line_number":57,"context_line":"lock_path \u003d /var/lib/magnum/tmp"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_e9b89713","line":54,"in_reply_to":"7aa08908_9b07c61b","updated":"2016-09-22 00:25:56.000000000","message":"Done","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"e33aa57133c529f050a77cb4e7f1988270e11763","unresolved":false,"context_lines":[{"line_number":49,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[trust]"},{"line_number":52,"context_line":"trustee_domain_admin_password \u003d VogjaaQ0jZLzbwLiCVZDKTJA73pE7wVNrymOkwWa"},{"line_number":53,"context_line":"trustee_domain_admin_id \u003d 93d58ca6271c4e7e9bc8cefe42e35723"},{"line_number":54,"context_line":"trustee_domain_id \u003d ef989aec33d64a97b092162a6334e766"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_concurrency]"},{"line_number":57,"context_line":"lock_path \u003d /var/lib/magnum/tmp"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_99701574","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":52},"in_reply_to":"7aa08908_bd743d9c","updated":"2016-06-13 22:02:13.000000000","message":"i\u0027m fine with this approach.","commit_id":"e630bb4d7833ed75777bd3c30707e6cb1be113bb"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d36e77661fee1e79ad210ba1b259f1899d6302f2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[cinder_client]"},{"line_number":25,"context_line":"region_name \u003d RegionOne"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[keystone_auth]"},{"line_number":28,"context_line":"auth_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5a8bc5a2_4291d9ef","line":25,"updated":"2016-09-23 02:02:34.000000000","message":"is `openstack_region_name` better?","commit_id":"923f691021b9303942d6d066f082b60419e2e1e3"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"c88c170e83c5fad1a4e1050ced955f487106b8c8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[cinder_client]"},{"line_number":25,"context_line":"region_name \u003d RegionOne"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[keystone_auth]"},{"line_number":28,"context_line":"auth_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5a8bc5a2_61d2005e","line":25,"in_reply_to":"5a8bc5a2_4291d9ef","updated":"2016-09-26 05:58:21.000000000","message":"Indeed.\nDone","commit_id":"923f691021b9303942d6d066f082b60419e2e1e3"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d36e77661fee1e79ad210ba1b259f1899d6302f2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"[keystone_authtoken]"},{"line_number":37,"context_line":"auth_version \u003d v3"},{"line_number":38,"context_line":"signing_dir \u003d /var/lib/magnum"},{"line_number":39,"context_line":"cafile \u003d /var/lib/magnum/ca-bundle.pem"},{"line_number":40,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":41,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":42,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5a8bc5a2_62bc156d","line":39,"updated":"2016-09-23 02:02:34.000000000","message":"shouldn\u0027t we create this file? where it come from?","commit_id":"923f691021b9303942d6d066f082b60419e2e1e3"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"c88c170e83c5fad1a4e1050ced955f487106b8c8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"[keystone_authtoken]"},{"line_number":37,"context_line":"auth_version \u003d v3"},{"line_number":38,"context_line":"signing_dir \u003d /var/lib/magnum"},{"line_number":39,"context_line":"cafile \u003d /var/lib/magnum/ca-bundle.pem"},{"line_number":40,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":41,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":42,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5a8bc5a2_014bfc2a","line":39,"in_reply_to":"5a8bc5a2_62bc156d","updated":"2016-09-26 05:58:21.000000000","message":"authtoken certificate section removed, should be set by user configuration if needed.","commit_id":"923f691021b9303942d6d066f082b60419e2e1e3"}],"docker/magnum/magnum-base/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d36e77661fee1e79ad210ba1b259f1899d6302f2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"RUN ln -s magnum-base-source/* magnum \\"},{"line_number":22,"context_line":"    \u0026\u0026 useradd --user-group magnum \\"},{"line_number":23,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /magnum \\"},{"line_number":24,"context_line":"    \u0026\u0026 mkdir -p /etc/magnum /home/magnum /var/lib/magnum/tmp /var/lib/magnum/certificates \\"},{"line_number":25,"context_line":"    \u0026\u0026 cp -r /magnum/etc/magnum/* /etc/magnum \\"},{"line_number":26,"context_line":"    \u0026\u0026 chown -R magnum: /etc/magnum /home/magnum /var/lib/magnum"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5a8bc5a2_2294cde0","line":24,"updated":"2016-09-23 02:02:34.000000000","message":"we will use docker volume for folder /var/lib/magnum, so no need to create the certificates folder.\n\nyou can create it in extern_start.sh script.","commit_id":"923f691021b9303942d6d066f082b60419e2e1e3"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"c88c170e83c5fad1a4e1050ced955f487106b8c8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"RUN ln -s magnum-base-source/* magnum \\"},{"line_number":22,"context_line":"    \u0026\u0026 useradd --user-group magnum \\"},{"line_number":23,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /magnum \\"},{"line_number":24,"context_line":"    \u0026\u0026 mkdir -p /etc/magnum /home/magnum /var/lib/magnum/tmp /var/lib/magnum/certificates \\"},{"line_number":25,"context_line":"    \u0026\u0026 cp -r /magnum/etc/magnum/* /etc/magnum \\"},{"line_number":26,"context_line":"    \u0026\u0026 chown -R magnum: /etc/magnum /home/magnum /var/lib/magnum"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5a8bc5a2_215478c8","line":24,"in_reply_to":"5a8bc5a2_2294cde0","updated":"2016-09-26 05:58:21.000000000","message":"Done\n/var/lib/magnum is now named volume for magnum_conductor.","commit_id":"923f691021b9303942d6d066f082b60419e2e1e3"}]}