)]}'
{"docker/heat/heat-api/Dockerfile.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"ec028c395fc7f8048e70934202742bf82bdc825f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"       {% set heat_api_packages \u003d [\u0027openstack-heat-api\u0027] %}"},{"line_number":7,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":8,"context_line":"        {% set heat_api_packages \u003d [\u0027heat-api\u0027] %}"},{"line_number":9,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7aa08908_71b10e8f","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":59},"updated":"2016-06-13 16:29:40.000000000","message":"How about doing this check in the macro?  That way you can remove these two if blocks.","commit_id":"597eaba188c31bb4daa6985aa8d609f6b2d0fa14"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"642ebe3c6fb640b36d7cbbdb85da3c1904fa502c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"       {% set heat_api_packages \u003d [\u0027openstack-heat-api\u0027] %}"},{"line_number":7,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":8,"context_line":"        {% set heat_api_packages \u003d [\u0027heat-api\u0027] %}"},{"line_number":9,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7aa08908_99c81557","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":59},"in_reply_to":"7aa08908_71b10e8f","updated":"2016-06-13 22:11:52.000000000","message":"The problem with checking in the macro is that the contents of heat_api_packages would have to end up there, which means we would have one big macro file with all of the defaults.  This would separate the information (which packages get installed) from the act of installing them (this dockerfile) and make development more difficult.","commit_id":"597eaba188c31bb4daa6985aa8d609f6b2d0fa14"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"ec028c395fc7f8048e70934202742bf82bdc825f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        {% set heat_api_packages \u003d [\u0027heat-api\u0027] %}"},{"line_number":9,"context_line":"    {% endif %}"},{"line_number":10,"context_line":"{% block heat_api_packages scoped %}{% endblock %}"},{"line_number":11,"context_line":"RUN {{ macros.install_packages(heat_api_packages) }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_heat_extend_start"},{"line_number":14,"context_line":"RUN chmod 755 /usr/local/bin/kolla_heat_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7aa08908_b1a7f64e","line":11,"range":{"start_line":11,"start_character":31,"end_line":11,"end_character":48},"updated":"2016-06-13 16:29:40.000000000","message":"If you do the check in the macro then just call with ()","commit_id":"597eaba188c31bb4daa6985aa8d609f6b2d0fa14"}]}