)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"19624d96039c5a57960dc1b377ca048458e9eab0","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"api_interface_address: \"0.0.0.0\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"memcache_servers: \"memcached\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"keystone_database_address: \"mariadb\""},{"line_number":23,"context_line":"keystone_admin_url: \"{{ admin_protocol }}://keystone-admin:{{ keystone_admin_port }}/v3\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_c4b02246","line":20,"updated":"2016-06-12 15:44:02.000000000","message":"how the memcached means here?","commit_id":"c6b9cf23aa26b167805eb9ca6f6b63ff57a472e4"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1341845afb5338dad92f248721a0dfbef3ec9d56","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Current working Kolla-Kubernetes globals.yml file, assuming that your"},{"line_number":20,"context_line":"memcached servers are available under the DNS alias \"memcached\":"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"api_interface_address: \"0.0.0.0\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"memcached_servers: \"memcached\""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_dffe0869","line":22,"updated":"2016-06-18 03:16:34.000000000","message":"is memcached running with --net\u003dhost?  If so, this is a nonstarter from a security perspective.  Ping me on irc if not and I\u0027ll change my vote.","commit_id":"04f84df13a1d44957079750c035e0ab268b94edb"}],"ansible/roles/keystone/templates/keystone.conf.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"19624d96039c5a57960dc1b377ca048458e9eab0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"enabled \u003d True"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if memcache_servers is defined %}"},{"line_number":18,"context_line":"memcache_servers \u003d {memcache_servers}"},{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":21,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_a4ad16eb","line":18,"updated":"2016-06-12 15:44:02.000000000","message":"does this really work?","commit_id":"c6b9cf23aa26b167805eb9ca6f6b63ff57a472e4"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"19624d96039c5a57960dc1b377ca048458e9eab0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% if memcache_servers is defined %}"},{"line_number":18,"context_line":"memcache_servers \u003d {memcache_servers}"},{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":21,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7aa08908_04b7ca3a","line":20,"updated":"2016-06-12 15:44:02.000000000","message":"here still need the hostvars variables from ansible.","commit_id":"c6b9cf23aa26b167805eb9ca6f6b63ff57a472e4"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"19624d96039c5a57960dc1b377ca048458e9eab0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7aa08908_e4b39e4b","line":22,"updated":"2016-06-12 15:44:02.000000000","message":"add tne newline at end of the file.","commit_id":"c6b9cf23aa26b167805eb9ca6f6b63ff57a472e4"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"8de6aa93fd66d8d41fc9fceff24b58ff2b602fae","unresolved":false,"context_lines":[{"line_number":14,"context_line":"backend \u003d oslo_cache.memcache_pool"},{"line_number":15,"context_line":"enabled \u003d True"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if memcache_servers is defined %}"},{"line_number":18,"context_line":"memcache_servers \u003d {{memcache_servers}}"},{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7aa08908_846ec1fd","line":17,"updated":"2016-06-14 14:53:05.000000000","message":"could u add some NOTE here? It will be confused for the newbie without\nbackground.","commit_id":"a4e363a565fd1eb96cb8976c2ac0efd07efa9c47"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"8de6aa93fd66d8d41fc9fceff24b58ff2b602fae","unresolved":false,"context_lines":[{"line_number":15,"context_line":"enabled \u003d True"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if memcache_servers is defined %}"},{"line_number":18,"context_line":"memcache_servers \u003d {{memcache_servers}}"},{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":21,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7aa08908_e47985c9","line":18,"updated":"2016-06-14 14:53:05.000000000","message":"use \n\n  {{ memcache_servers }}","commit_id":"a4e363a565fd1eb96cb8976c2ac0efd07efa9c47"},{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"ba3f88836d1ab5ceeb6d179aa5753162dd7cafbf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% if memcache_servers is defined %}"},{"line_number":18,"context_line":"memcache_servers \u003d {{memcache_servers}}"},{"line_number":19,"context_line":"{% else %}"},{"line_number":20,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":21,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7aa08908_3401f405","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":16},"updated":"2016-06-14 17:24:17.000000000","message":"isn\u0027t it \"memcached\", not \"memcache\".  Should we correct the variable name?\n\nAlso, i think you can do this all in one line, if it might look neater.","commit_id":"a4e363a565fd1eb96cb8976c2ac0efd07efa9c47"},{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"f70c5e3eb8fbb0d91d442bd52b078b33ce1fe880","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{# For Kolla-Ansible, generate the memcache servers based on the list of"},{"line_number":18,"context_line":"memcached servers in the inventory and memcache_servers should be un-set."},{"line_number":19,"context_line":"For Kolla-Kubernetes,  it is necessary to define the memcache_servers "},{"line_number":20,"context_line":"variable in globals.yml to set it to the Kubernetes service for memcached. #}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if memcache_servers is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7aa08908_3462943e","line":19,"range":{"start_line":19,"start_character":69,"end_line":19,"end_character":70},"updated":"2016-06-14 17:36:53.000000000","message":"Fix trailing whitespace.","commit_id":"e68e025013d814c91173611630f871e3dfc27efc"},{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"f70c5e3eb8fbb0d91d442bd52b078b33ce1fe880","unresolved":false,"context_lines":[{"line_number":20,"context_line":"variable in globals.yml to set it to the Kubernetes service for memcached. #}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if memcache_servers is defined %}"},{"line_number":23,"context_line":"memcache_servers \u003d {{ memcache_servers }}"},{"line_number":24,"context_line":"{% else %}"},{"line_number":25,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":26,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7aa08908_74337c62","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":16},"updated":"2016-06-14 17:36:53.000000000","message":"I still want you to fix the name.  Everywhere else in Kolla it is \"memcached\".  for example, \"./tools/build.sh memcached\"","commit_id":"e68e025013d814c91173611630f871e3dfc27efc"},{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"f70c5e3eb8fbb0d91d442bd52b078b33ce1fe880","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if memcache_servers is defined %}"},{"line_number":23,"context_line":"memcache_servers \u003d {{ memcache_servers }}"},{"line_number":24,"context_line":"{% else %}"},{"line_number":25,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":26,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7aa08908_d41990d2","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":2},"updated":"2016-06-14 17:36:53.000000000","message":"Also, take a look at the yaml file generated.  Ther will be awkward newlines in places.  Add a minus  sign {%- to suppress.","commit_id":"e68e025013d814c91173611630f871e3dfc27efc"}]}