)]}'
{"kolla/image/build.py":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"20d0172ff3921ec359d71cc263cb4e342d2822f7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            raise RuntimeError("},{"line_number":146,"context_line":"                \u0027Can not communicate with the docker service due to %s,\u0027"},{"line_number":147,"context_line":"                \u0027 please check the docker service is running\u0027"},{"line_number":148,"context_line":"                \u0027 without errors\u0027 % e)"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            return self._dc"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_fc6a7280","line":148,"updated":"2016-06-15 19:50:06.000000000","message":"can we just raise DockerException?;)","commit_id":"b716aceab024881605a7d7833bebb3787ecb1aa6"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"0c5a65d9c0b86e536a4ff705177e7552d2044180","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if self._dc is not None:"},{"line_number":140,"context_line":"            return self._dc"},{"line_number":141,"context_line":"        docker_kwargs \u003d self.docker_kwargs.copy()"},{"line_number":142,"context_line":"        self._dc \u003d docker.Client(version\u003d\u0027auto\u0027, **docker_kwargs)"},{"line_number":143,"context_line":"        return self._dc"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_6766db2a","line":142,"updated":"2016-06-16 05:38:23.000000000","message":"Please add the exception handling as well.","commit_id":"c8ef77eeac51ce1e58b3b2db4d53172af1663072"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"2596503872bfaaf3c8144ffae13886d190ce72c9","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                        if line:"},{"line_number":426,"context_line":"                            LOG.error(\u0027%s:%s\u0027, image.name, line)"},{"line_number":427,"context_line":"                    return"},{"line_number":428,"context_line":"        except Exception:"},{"line_number":429,"context_line":"            image.status \u003d STATUS_ERROR"},{"line_number":430,"context_line":"            LOG.exception(\u0027%s:Unknown error when building\u0027, image.name)"},{"line_number":431,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_529a42c6","line":428,"updated":"2016-06-17 04:01:24.000000000","message":"Generic exceptions are good. Can you please add the DockerException as well. It will help user debug better. Thanks!","commit_id":"7550aaf010a4969ee047009ab8e964901305885f"}]}
