)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"66a41f4ca7f9abc87467f3cb0b22ccce955e39ba","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow for externally managed configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Godaddy plans on using bindmounts for our existing configuration"},{"line_number":10,"context_line":"so make it possible to avoid all the configuration activity"},{"line_number":11,"context_line":"that happens during this."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3aaa91ec_c8b409d3","line":9,"updated":"2016-06-28 07:29:02.000000000","message":"why not use set_config.py ways? any benefit for bindmounts?","commit_id":"65f91be3ce231ce6ada9d110c54cec1456d8480a"}],"docker/base/set_configs.py":[{"author":{"_account_id":20128,"name":"Han Chao","email":"hanchao7@lenovo.com","username":"HanChao"},"change_message_id":"2322f9014b61d5a1aae4fdba5b4982477076442f","unresolved":false,"context_lines":[{"line_number":190,"context_line":"def execute_config_strategy():"},{"line_number":191,"context_line":"    config_strategy \u003d os.environ.get(\"KOLLA_CONFIG_STRATEGY\")"},{"line_number":192,"context_line":"    LOG.info(\"Kolla config strategy set to: %s\", config_strategy)"},{"line_number":193,"context_line":"    config \u003d load_config()"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    if config_strategy \u003d\u003d \"COPY_ALWAYS\":"},{"line_number":196,"context_line":"        copy_config(config)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_172ab77e","side":"PARENT","line":193,"updated":"2016-06-28 01:12:47.000000000","message":"As we would use the returned value more than once, why would you remove this?","commit_id":"2cb0f445bba72d5b085856deb57a5e48c5832ca9"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3be036a7f6307c3639dadc3f4b79b54e5402facd","unresolved":false,"context_lines":[{"line_number":190,"context_line":"def execute_config_strategy():"},{"line_number":191,"context_line":"    config_strategy \u003d os.environ.get(\"KOLLA_CONFIG_STRATEGY\")"},{"line_number":192,"context_line":"    LOG.info(\"Kolla config strategy set to: %s\", config_strategy)"},{"line_number":193,"context_line":"    config \u003d load_config()"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    if config_strategy \u003d\u003d \"COPY_ALWAYS\":"},{"line_number":196,"context_line":"        copy_config(config)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_f7c52e3d","side":"PARENT","line":193,"in_reply_to":"3aaa91ec_172ab77e","updated":"2016-06-28 23:48:30.000000000","message":"It\u0027s not actually used more than once.\n\nAnd its removed because loading isn\u0027t needed if the config is \u0027EXTERNALLY_MANAGED\u0027.","commit_id":"2cb0f445bba72d5b085856deb57a5e48c5832ca9"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"92a804c729581916b5ffae3ca650e4eb06d79e4b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            handle_permissions(config)"},{"line_number":246,"context_line":"            os.mknod(\u0027/configured\u0027)"},{"line_number":247,"context_line":"    elif config_strategy \u003d\u003d \"EXTERNALLY_MANAGED\":"},{"line_number":248,"context_line":"        os.mknod(\u0027/configured\u0027)"},{"line_number":249,"context_line":"    else:"},{"line_number":250,"context_line":"        LOG.error(\u0027KOLLA_CONFIG_STRATEGY is not set properly\u0027)"},{"line_number":251,"context_line":"        sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_c012d908","line":248,"updated":"2016-11-17 14:44:49.000000000","message":"this is only file relevant in COPY_ONCE. You want handle_permissions tho - this will fix your upgrade. I\u0027d suggest removing /configured and adding handle_permissions:) Also make sure that you will place at least config.json with perms in config volume","commit_id":"5ca5f7d1da537e1f78105b9896f24f9ad3ccd5a1"}]}