)]}'
{"ansible/library/kolla_docker.py":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"42c8c302cf03df8ad86dad92f2f61447f639fe3e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    required: True"},{"line_number":34,"context_line":"    type: str"},{"line_number":35,"context_line":"    choices:"},{"line_number":36,"context_line":"openstack_version: \"2.0.2\""},{"line_number":37,"context_line":"      - compare_image"},{"line_number":38,"context_line":"      - create_volume"},{"line_number":39,"context_line":"      - get_container_env"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_d1dc891a","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":26},"updated":"2016-06-28 19:18:13.000000000","message":"As this PS is to the master branch, so openstack_version should not be 3.0.0?","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"99644fdd094b58955fc2d9d9d8cdfaa3bcec2e9b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    required: True"},{"line_number":34,"context_line":"    type: str"},{"line_number":35,"context_line":"    choices:"},{"line_number":36,"context_line":"openstack_version: \"2.0.2\""},{"line_number":37,"context_line":"      - compare_image"},{"line_number":38,"context_line":"      - create_volume"},{"line_number":39,"context_line":"      - get_container_env"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_644028a6","line":36,"updated":"2016-07-26 15:26:40.000000000","message":"a typo? this shoud not exist here.","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"224aaa45daecfe65733309084eba7de44eaa3af7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    required: True"},{"line_number":34,"context_line":"    type: str"},{"line_number":35,"context_line":"    choices:"},{"line_number":36,"context_line":"openstack_version: \"2.0.2\""},{"line_number":37,"context_line":"      - compare_image"},{"line_number":38,"context_line":"      - create_volume"},{"line_number":39,"context_line":"      - get_container_env"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_7ecb8053","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":26},"in_reply_to":"3aaa91ec_43b34f9a","updated":"2016-06-30 13:02:34.000000000","message":"it is bad to fix the version number. how about the end-user want to customized version number?","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"dc05c48ce5e5ea4b3f8594441ac014cc325e3880","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    required: True"},{"line_number":34,"context_line":"    type: str"},{"line_number":35,"context_line":"    choices:"},{"line_number":36,"context_line":"openstack_version: \"2.0.2\""},{"line_number":37,"context_line":"      - compare_image"},{"line_number":38,"context_line":"      - create_volume"},{"line_number":39,"context_line":"      - get_container_env"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_1e9b5c67","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":26},"in_reply_to":"3aaa91ec_43b34f9a","updated":"2016-06-30 12:47:15.000000000","message":"nm looks like I added this forsome reason.  I\u0027ll remove it.","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8abdb674ab50f00a2463a550e37210e6b251130b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    required: True"},{"line_number":34,"context_line":"    type: str"},{"line_number":35,"context_line":"    choices:"},{"line_number":36,"context_line":"openstack_version: \"2.0.2\""},{"line_number":37,"context_line":"      - compare_image"},{"line_number":38,"context_line":"      - create_volume"},{"line_number":39,"context_line":"      - get_container_env"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5b920cf7","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":26},"in_reply_to":"3aaa91ec_7ecb8053","updated":"2016-06-30 15:08:30.000000000","message":"folks,\n\nI think what happened here is I pasted from my copy buffer at an inopportune time and missed this.  I will fix it.","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"316ded7a746ac3fb52e492b40eb17f2b08a5f3b8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    required: True"},{"line_number":34,"context_line":"    type: str"},{"line_number":35,"context_line":"    choices:"},{"line_number":36,"context_line":"openstack_version: \"2.0.2\""},{"line_number":37,"context_line":"      - compare_image"},{"line_number":38,"context_line":"      - create_volume"},{"line_number":39,"context_line":"      - get_container_env"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_43b34f9a","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":26},"in_reply_to":"3aaa91ec_d1dc891a","updated":"2016-06-30 12:37:11.000000000","message":"groan more places with version numbers.  I think that version # problem needs to be addressed as a separate patch.","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"58d5199cd56c40151b8bfe40fa0faae766ddef28","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        if container and self.check_container_differs():"},{"line_number":557,"context_line":"            try:"},{"line_number":558,"context_line":"                self.remove_container()"},{"line_number":559,"context_line":"            except Exception:"},{"line_number":560,"context_line":"                pass"},{"line_number":561,"context_line":"            container \u003d self.check_container()"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4b7a81f2","line":559,"updated":"2016-06-29 13:32:00.000000000","message":"Also can we please fix actual issue?","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"bcd3a541ad629005a7649f5c3e901beb00778cc0","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        if container and self.check_container_differs():"},{"line_number":557,"context_line":"            try:"},{"line_number":558,"context_line":"                self.remove_container()"},{"line_number":559,"context_line":"            except Exception:"},{"line_number":560,"context_line":"                pass"},{"line_number":561,"context_line":"            container \u003d self.check_container()"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_16444772","line":559,"updated":"2016-06-28 19:06:27.000000000","message":"No errors should pass silently, at least add warning log here. But I\u0027d rather have it fail and retry in your case then miss an error log...","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"224aaa45daecfe65733309084eba7de44eaa3af7","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        if container and self.check_container_differs():"},{"line_number":557,"context_line":"            try:"},{"line_number":558,"context_line":"                self.remove_container()"},{"line_number":559,"context_line":"            except Exception:"},{"line_number":560,"context_line":"                pass"},{"line_number":561,"context_line":"            container \u003d self.check_container()"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_94ac4ca0","line":559,"in_reply_to":"3aaa91ec_4b7a81f2","updated":"2016-06-30 13:02:34.000000000","message":"simple ignore is bad. please try to add a new parameter to the kolla_docker module, like: force or ignore_errors.\n\nIn the ansible, we can specify this param to ignore error when remove the nova_libvirt container.","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8abdb674ab50f00a2463a550e37210e6b251130b","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        if container and self.check_container_differs():"},{"line_number":557,"context_line":"            try:"},{"line_number":558,"context_line":"                self.remove_container()"},{"line_number":559,"context_line":"            except Exception:"},{"line_number":560,"context_line":"                pass"},{"line_number":561,"context_line":"            container \u003d self.check_container()"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_bb6e90fd","line":559,"in_reply_to":"3aaa91ec_4b7a81f2","updated":"2016-06-30 15:08:30.000000000","message":"the actual issue is on kernel.org.  I am no longer a kernel wizard.  A workaround is the only viable solution in the short-medium term.","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8abdb674ab50f00a2463a550e37210e6b251130b","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        if container and self.check_container_differs():"},{"line_number":557,"context_line":"            try:"},{"line_number":558,"context_line":"                self.remove_container()"},{"line_number":559,"context_line":"            except Exception:"},{"line_number":560,"context_line":"                pass"},{"line_number":561,"context_line":"            container \u003d self.check_container()"},{"line_number":562,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_db427c67","line":559,"in_reply_to":"3aaa91ec_94ac4ca0","updated":"2016-06-30 15:08:30.000000000","message":"Jeffrey,\n\nSounds good.  I\u0027ll make this change today.","commit_id":"cd08831da2befe6721b3a6109c0fb820c0692e55"}]}