)]}'
{"docker/base/set_configs.py":[{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"c514fbb74cd856baca31b8aafa6ba28205ab9a89","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    if config_strategy \u003d\u003d \"COPY_ALWAYS\":"},{"line_number":196,"context_line":"        copy_config(config)"},{"line_number":197,"context_line":"        return 0"},{"line_number":198,"context_line":"    elif config_strategy \u003d\u003d \"COPY_ONCE\":"},{"line_number":199,"context_line":"        if os.path.exists(\u0027/configured\u0027):"},{"line_number":200,"context_line":"            LOG.info(\"The config strategy prevents copying new configs\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_1d1da6bd","line":197,"updated":"2016-06-28 10:44:54.000000000","message":"sys.exit raise an exit exception that can be useful than only returning the 0, 1 only.","commit_id":"3f2cad188a5d5df383388afa7e4c00763389835d"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"62bec05bc9d62c47375da01281f5fc013b47cb54","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    if config_strategy \u003d\u003d \"COPY_ALWAYS\":"},{"line_number":196,"context_line":"        copy_config(config)"},{"line_number":197,"context_line":"        return 0"},{"line_number":198,"context_line":"    elif config_strategy \u003d\u003d \"COPY_ONCE\":"},{"line_number":199,"context_line":"        if os.path.exists(\u0027/configured\u0027):"},{"line_number":200,"context_line":"            LOG.info(\"The config strategy prevents copying new configs\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_76f156cd","line":197,"in_reply_to":"3aaa91ec_1d1da6bd","updated":"2016-06-28 15:41:17.000000000","message":"ok, perhaps we should raise an exception here instead, cause randomly having sys.exit scattered over the program is pretty bad practice and makes it hard to find the exit points of this program (which is also bad)","commit_id":"3f2cad188a5d5df383388afa7e4c00763389835d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"51f59b22d2b326765994f39580c145930c062b8e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"class ExitingException(Exception):"},{"line_number":31,"context_line":"    def __init__(self, message, exit_code):"},{"line_number":32,"context_line":"        super(ExitingException, self).__init__(message)"},{"line_number":33,"context_line":"        self.exit_code \u003d exit_code"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def validate_config(config):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_6c7a9778","line":33,"updated":"2016-07-01 02:22:36.000000000","message":"you are using the exit_code \u003d\u003d 1 all the time and exit with 1 when has\nerror. what\u0027s the purpose of this value?","commit_id":"f24e69ffeeac763281634518310ce48dd2195665"}]}