)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"ba8f34d8611d5061c2123ebc808d4c18e9c10549","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integrate neutron-vpnaas-agent into the neutron Ansible role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint neutron-vpnaas-agent"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1fae21f48d5beef47934aef7c23910536955f2b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aa78d24_c01a4217","line":9,"updated":"2016-07-03 01:01:11.000000000","message":"Since there are two patch set, the commit message should be \"partially implement ...\".","commit_id":"e564fb44647c8da0c87daa5c2a3e02617d75a9b4"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8a3b78dd4a0c7bfb156fc24361573cab9fbef307","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Integrate neutron-vpnaas-agent into the neutron Ansible role"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint neutron-vpnaas-agent"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I1fae21f48d5beef47934aef7c23910536955f2b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aa78d24_31b6f68a","line":9,"in_reply_to":"1aa78d24_c01a4217","updated":"2016-07-03 12:32:58.000000000","message":"Will be fixed with the next patch set. Same for the other review.","commit_id":"e564fb44647c8da0c87daa5c2a3e02617d75a9b4"}],"ansible/roles/neutron/tasks/config.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ccc9f4f356071f3c8238b4afaa6e4f14fe53f815","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      - \"{{ node_custom_config }}/neutron/{{ inventory_hostname }}/neutron_lbaas.conf\""},{"line_number":76,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/neutron_lbaas.conf\""},{"line_number":77,"context_line":"  with_items:"},{"line_number":78,"context_line":"    - \"neutron-server\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Copying over neutron_vpnaas.conf"},{"line_number":81,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa7ab95a_873bbaea","line":78,"updated":"2016-09-01 13:07:18.000000000","message":"what\u0027s the benefit to use seperate lbaas and vpnaas config file?\n\nthis file should not be used and render when the lbaas and vpnaas is disabled.","commit_id":"af685e9a577a7155f482a896184270d7fa7e0661"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"c5ea45537272cc61cc4f7e89091e24e8a8fc6542","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      - \"{{ node_custom_config }}/neutron/{{ inventory_hostname }}/neutron_lbaas.conf\""},{"line_number":76,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/neutron_lbaas.conf\""},{"line_number":77,"context_line":"  with_items:"},{"line_number":78,"context_line":"    - \"neutron-server\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Copying over neutron_vpnaas.conf"},{"line_number":81,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a89bdaa_cf1fe907","line":78,"in_reply_to":"fa7ab95a_873bbaea","updated":"2016-09-09 11:38:07.000000000","message":"Tow services, two configuration files... I will add when conditions to avoid the task when the service is not enabled.","commit_id":"af685e9a577a7155f482a896184270d7fa7e0661"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"dadf68083f181ce9390c1e7c7f0380759b3d0114","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    vars:"},{"line_number":72,"context_line":"      service_name: \"{{ item }}\""},{"line_number":73,"context_line":"    sources:"},{"line_number":74,"context_line":"      - \"{{ role_path }}/templates/neutron_lbaas.conf.j2\""},{"line_number":75,"context_line":"      - \"{{ node_custom_config }}/neutron/{{ inventory_hostname }}/neutron_lbaas.conf\""},{"line_number":76,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/neutron_lbaas.conf\""},{"line_number":77,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_3f4cca41","line":74,"updated":"2016-09-15 02:58:34.000000000","message":"add \n  - \"{{ node_custom_config }}/neutron/neutron_lbaas.conf","commit_id":"1de53bf200c0af76e8702f2b0f26b8d50f1ac75d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"dadf68083f181ce9390c1e7c7f0380759b3d0114","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    vars:"},{"line_number":83,"context_line":"      service_name: \"{{ item }}\""},{"line_number":84,"context_line":"    sources:"},{"line_number":85,"context_line":"      - \"{{ role_path }}/templates/neutron_vpnaas.conf.j2\""},{"line_number":86,"context_line":"      - \"{{ node_custom_config }}/neutron/{{ inventory_hostname }}/neutron_vpnaas.conf\""},{"line_number":87,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/neutron_vpnaas.conf\""},{"line_number":88,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_5f47d61c","line":85,"updated":"2016-09-15 02:58:34.000000000","message":"add\n\n  - \"{{ node_custom_config }}/neutron/neutron_vpnaas.conf\"","commit_id":"1de53bf200c0af76e8702f2b0f26b8d50f1ac75d"}],"ansible/roles/neutron/tasks/do_reconfigure.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"dadf68083f181ce9390c1e7c7f0380759b3d0114","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":15,"context_line":"    - { name: neutron_l3_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"},{"line_number":16,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":17,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":18,"context_line":"    - { name: neutron_metadata_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Ensuring the neutron_openvswitch_agent container is up"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_7f5652d3","side":"PARENT","line":17,"updated":"2016-09-15 02:58:34.000000000","message":"why this line is removed?","commit_id":"37ec5ecb52733e743797a87a3fd08be9781630a2"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"dadf68083f181ce9390c1e7c7f0380759b3d0114","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":74,"context_line":"    - { name: neutron_l3_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"},{"line_number":75,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":76,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":77,"context_line":"    - { name: neutron_metadata_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Check the configs in the neutron_openvswitch_agent container"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_9f515edb","side":"PARENT","line":76,"updated":"2016-09-15 02:58:34.000000000","message":"ditto, this line shouldn\u0027t be removed.  if removed, \nwhen the dvr is disabled, the neutron_metadata_agent is never startted.","commit_id":"37ec5ecb52733e743797a87a3fd08be9781630a2"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"dadf68083f181ce9390c1e7c7f0380759b3d0114","unresolved":false,"context_lines":[{"line_number":188,"context_line":"       { name: neutron_l3_agent, group: neutron-l3-agent },"},{"line_number":189,"context_line":"       { name: neutron_l3_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" },"},{"line_number":190,"context_line":"       { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" },"},{"line_number":191,"context_line":"       { name: neutron_metadata_agent, group: neutron-metadata-agent },"},{"line_number":192,"context_line":"       { name: neutron_metadata_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }]"},{"line_number":193,"context_line":"    - \"{{ neutron_container_envs.results }}\""},{"line_number":194,"context_line":"    - \"{{ neutron_check_results.results }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_bf5e1ae7","side":"PARENT","line":191,"updated":"2016-09-15 02:58:34.000000000","message":"ditto.","commit_id":"37ec5ecb52733e743797a87a3fd08be9781630a2"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"dadf68083f181ce9390c1e7c7f0380759b3d0114","unresolved":false,"context_lines":[{"line_number":256,"context_line":"       { name: neutron_l3_agent, group: neutron-l3-agent },"},{"line_number":257,"context_line":"       { name: neutron_l3_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" },"},{"line_number":258,"context_line":"       { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" },"},{"line_number":259,"context_line":"       { name: neutron_metadata_agent, group: neutron-metadata-agent },"},{"line_number":260,"context_line":"       { name: neutron_metadata_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }]"},{"line_number":261,"context_line":"    - \"{{ neutron_container_envs.results }}\""},{"line_number":262,"context_line":"    - \"{{ neutron_check_results.results }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a8ec9b2_df6126aa","side":"PARENT","line":259,"updated":"2016-09-15 02:58:34.000000000","message":"ditto.","commit_id":"37ec5ecb52733e743797a87a3fd08be9781630a2"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"7f47076cb60c5f96e84d015f3b1597b318926498","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":15,"context_line":"    - { name: neutron_l3_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"},{"line_number":16,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":17,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }    "},{"line_number":18,"context_line":"    - { name: neutron_metadata_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"},{"line_number":19,"context_line":"    - { name: neutron_vpnaas_agent, group: neutron-vpnaas-agent, enabled: \"{{ enable_neutron_vpnaas | bool }}\" }"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_5d3977f1","line":17,"updated":"2016-09-15 17:46:15.000000000","message":"remove whitespaces plz","commit_id":"be0fcb5b99107e846f53cba2fa649f7d7d622077"}],"ansible/roles/neutron/tasks/start.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"f6b343ecc3a2d1c6f9f12ebe30aa4484c765cf28","unresolved":false,"context_lines":[{"line_number":185,"context_line":"      - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":186,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":187,"context_line":"  when:"},{"line_number":188,"context_line":"    - inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"- name: Starting neutron-lbaas-agent container"},{"line_number":191,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_8ec07be2","line":188,"updated":"2016-07-01 23:19:02.000000000","message":"Do not start the neutron-l3-agent when running the neutron-von-agent.","commit_id":"564b619c2f4e7c96f7c4d52749a719b461d8d860"}],"ansible/roles/neutron/templates/neutron-vpnaas-agent.json.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"dadf68083f181ce9390c1e7c7f0380759b3d0114","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        },"},{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"source\": \"{{ container_config_directory }}/fwaas_driver.ini\","},{"line_number":18,"context_line":"            \"dest\": \"/etc/neutron/fwaas_driver.ini\","},{"line_number":19,"context_line":"            \"owner\": \"neutron\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7a8ec9b2_1f454e16","line":17,"updated":"2016-09-15 02:58:34.000000000","message":"firewall is not needed in vpnaas.","commit_id":"1de53bf200c0af76e8702f2b0f26b8d50f1ac75d"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ccc9f4f356071f3c8238b4afaa6e4f14fe53f815","unresolved":false,"context_lines":[{"line_number":47,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":48,"context_line":"[service_providers]"},{"line_number":49,"context_line":"service_provider \u003d LOADBALANCERV2:Haproxy:neutron_lbaas.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default"},{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[nova]"},{"line_number":53,"context_line":"auth_url \u003d {{ keystone_admin_url }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"fa7ab95a_a73efed7","side":"PARENT","line":50,"updated":"2016-09-01 13:07:18.000000000","message":"why remove this?","commit_id":"707e6ddc1b43562bb982b1f3cd52337af84d7034"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"c5ea45537272cc61cc4f7e89091e24e8a8fc6542","unresolved":false,"context_lines":[{"line_number":47,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":48,"context_line":"[service_providers]"},{"line_number":49,"context_line":"service_provider \u003d LOADBALANCERV2:Haproxy:neutron_lbaas.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default"},{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[nova]"},{"line_number":53,"context_line":"auth_url \u003d {{ keystone_admin_url }}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9a89bdaa_4fd2f935","side":"PARENT","line":50,"in_reply_to":"fa7ab95a_a73efed7","updated":"2016-09-09 11:38:07.000000000","message":"This was a problem with our merge_config task. This cannot handle two parameters of the same name and will remove one parameter. But this is possible with openstack configuration files. Because of that it is necessary to enable the service provider in a separate file.","commit_id":"707e6ddc1b43562bb982b1f3cd52337af84d7034"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"dadf68083f181ce9390c1e7c7f0380759b3d0114","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"allow_overlapping_ips \u003d true"},{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},lbaas{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %},{% if neutron_plugin_agent \u003d\u003d \"sfc\" %}flow_classifier,sfc{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7a8ec9b2_ff58a2fc","side":"PARENT","line":38,"updated":"2016-09-15 02:58:34.000000000","message":"bad merge conflict handle the flow_classifier,sfc is removed.","commit_id":"37ec5ecb52733e743797a87a3fd08be9781630a2"}],"ansible/roles/neutron/templates/neutron_vpnaas.conf.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8a6ae8c2430026d87eaf95c08b654be39df640bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if enable_neutron_vpnaas | bool %}"},{"line_number":2,"context_line":"[service_providers]"},{"line_number":3,"context_line":"service_provider \u003d VPN:openswan:neutron_vpnaas.services.vpn.service_drivers.ipsec.IPsecVPNDriver:default"},{"line_number":4,"context_line":"{% endif %} "}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3aaa91ec_c1b7e638","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":12},"updated":"2016-07-01 19:02:18.000000000","message":"Will be removed with the next patch set.","commit_id":"564b619c2f4e7c96f7c4d52749a719b461d8d860"}]}