)]}'
{"docker/watcher/watcher-base/Dockerfile.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"d6b02508ac54789ba19fe9c048cf157b8c6879c2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"RUN ln -s watcher-base-source/* watcher \\"},{"line_number":13,"context_line":"    \u0026\u0026 useradd --user-group watcher \\"},{"line_number":14,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /watcher \\"},{"line_number":15,"context_line":"    \u0026\u0026 mkdir -p /etc/watcher /home/watcher \\"},{"line_number":16,"context_line":"    \u0026\u0026 cp -r /watcher/etc/watcher/* /etc/watcher/ \\"},{"line_number":17,"context_line":"    \u0026\u0026 chown -R watcher: /etc/watcher /home/watcher"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1aa78d24_03b527ed","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":42},"updated":"2016-07-05 12:11:55.000000000","message":"I think it makes sense to use the -m parameter of useradd command instead of manually creating the home dir.","commit_id":"dcd375c91ffae8f56c75af6ec47aafb6173dc907"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"ab60114124bfa9f210c8c1036e275b4502fc1095","unresolved":false,"context_lines":[{"line_number":12,"context_line":"RUN ln -s watcher-base-source/* watcher \\"},{"line_number":13,"context_line":"    \u0026\u0026 useradd --user-group watcher \\"},{"line_number":14,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /watcher \\"},{"line_number":15,"context_line":"    \u0026\u0026 mkdir -p /etc/watcher /home/watcher \\"},{"line_number":16,"context_line":"    \u0026\u0026 cp -r /watcher/etc/watcher/* /etc/watcher/ \\"},{"line_number":17,"context_line":"    \u0026\u0026 chown -R watcher: /etc/watcher /home/watcher"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1aa78d24_63f86b4a","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":42},"in_reply_to":"1aa78d24_03b527ed","updated":"2016-07-05 12:18:15.000000000","message":"I\u0027d agree with you, but i\u0027m trying to follow consistency:\n\ndocker/murano/murano-base/Dockerfile.j2:24:    \u0026\u0026 mkdir -p /etc/murano /home/murano \\\ndocker/designate/designate-base/Dockerfile.j2:34:    \u0026\u0026 mkdir -p /etc/designate /var/log/designate /home/designate \\\ndocker/zaqar/Dockerfile.j2:25:    \u0026\u0026 mkdir -p /etc/zaqar /var/log/zaqar /home/zaqar \\\ndocker/cinder/cinder-base/Dockerfile.j2:49:    \u0026\u0026 mkdir -p /etc/cinder /var/lib/cinder /home/cinder \\\ndocker/manila/manila-base/Dockerfile.j2:39:    \u0026\u0026 mkdir -p /etc/manila /var/lib/manila /var/cache/manila /home/manila \\\ndocker/swift/swift-base/Dockerfile.j2:37:    \u0026\u0026 mkdir -p /etc/swift /var/cache/swift /var/log/swift /home/swift \\\ndocker/gnocchi/gnocchi-base/Dockerfile.j2:31:    \u0026\u0026 mkdir -p /etc/gnocchi /var/log/gnocchi /home/gnocchi \\\ndocker/mistral/mistral-base/Dockerfile.j2:26:    \u0026\u0026 mkdir -p /etc/mistral /home/mistral \\\ndocker/mongodb/Dockerfile.j2:19:RUN mkdir -p /var/lib/mongodb /home/mongodb \\\ndocker/watcher/watcher-base/Dockerfile.j2:15:    \u0026\u0026 mkdir -p /etc/watcher /home/watcher \\\ndocker/ceilometer/ceilometer-base/Dockerfile.j2:27:    \u0026\u0026 mkdir -p /etc/ceilometer /var/log/ceilometer /home/ceilometer \\\ndocker/horizon/Dockerfile.j2:79:    \u0026\u0026 mkdir -p /etc/openstack-dashboard /home/horizon \\\ndocker/keystone/Dockerfile.j2:55:    \u0026\u0026 mkdir -p /etc/keystone /var/www/cgi-bin/keystone /var/log/apache2 /home/keystone \\\ndocker/magnum/magnum-base/Dockerfile.j2:25:    \u0026\u0026 mkdir -p /etc/magnum /home/magnum \\\ndocker/aodh/aodh-base/Dockerfile.j2:25:    \u0026\u0026 mkdir -p /etc/aodh /var/log/aodh /home/aodh \\\ndocker/heat/heat-base/Dockerfile.j2:24:    \u0026\u0026 mkdir -p /etc/heat /home/heat \\\ndocker/neutron/neutron-base/Dockerfile.j2:57:    \u0026\u0026 mkdir -p /etc/neutron /usr/share/neutron /var/lib/neutron /home/neutron \\\ndocker/trove/trove-base/Dockerfile.j2:25:    \u0026\u0026 mkdir -p /etc/trove /var/log/trove /home/trove \\\ndocker/ironic/ironic-base/Dockerfile.j2:24:    \u0026\u0026 mkdir -p /etc/ironic /var/log/ironic /home/ironic \\\ndocker/sahara/sahara-base/Dockerfile.j2:25:    \u0026\u0026 mkdir -p /etc/sahara /var/log/sahara /home/sahara \\\ndocker/glance/glance-base/Dockerfile.j2:47:    \u0026\u0026 mkdir -p /etc/glance /var/lib/glance /home/glance \\\ndocker/ceph/ceph-base/Dockerfile.j2:30:    \u0026\u0026 mkdir -p /home/ceph \\","commit_id":"dcd375c91ffae8f56c75af6ec47aafb6173dc907"}],"kolla/common/config.py":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"ddb7ba502374cf54f5c1631b2425b593c3ce6a46","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":267,"context_line":"        \u0027location\u0027: (\u0027http://tarballs.openstack.org/trove/\u0027"},{"line_number":268,"context_line":"                     \u0027trove-master.tar.gz\u0027)},"},{"line_number":269,"context_line":"    \u0027watcher\u0027: {"},{"line_number":270,"context_line":"        \u0027watcher-base\u0027: {"},{"line_number":271,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":272,"context_line":"        \u0027location\u0027: (\u0027http://tarballs.openstack.org/watcher/\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_2ab0fd42","line":269,"range":{"start_line":269,"start_character":5,"end_line":269,"end_character":16},"updated":"2016-07-05 09:22:53.000000000","message":"this is not required.","commit_id":"5d7fd42c3193c251521025f14f7a971ec0593457"}],"tests/test_build.py":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"e3b1b922b8899c83561c49ee0b2f78c9e888f3fa","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class BuildTestCentosBinary(BuildTest, base.BaseTestCase):"},{"line_number":70,"context_line":"    excluded_images \u003d [\"kuryr\", \"watcher-base\", \"watcher-api\","},{"line_number":71,"context_line":"                       \"watcher-engine\"]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_8d1e6661","line":70,"updated":"2016-07-05 11:20:36.000000000","message":"only watcher-base should be sufficient.\n\nadd it to next line below kuryr.\n\nThis will be required for oraclelinux binary","commit_id":"54dd06f533128157e1db8d451fee0c4771775b6d"}]}
