)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"ea2c42b8205dbf9e4e80d77ddc0541dfcfe417f9","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8763528bb6ff12943b810212c71396d2d7cf6836"},{"line_number":21,"context_line":"Partial-bug: #1598929"},{"line_number":22,"context_line":"Partially-implements: bp watcher"},{"line_number":23,"context_line":"Signed-off-by: Dave Walker (Daviey) \u003cemail@daviey.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_e8eb9d76","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":24},"updated":"2016-07-19 11:42:54.000000000","message":"blueprint","commit_id":"22ff22ed0319bce32558652833680f5815f3e30d"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"ca4d7496ec10674c5ae57da74e7bfc3af9e107ea","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8763528bb6ff12943b810212c71396d2d7cf6836"},{"line_number":21,"context_line":"Partial-bug: #1598929"},{"line_number":22,"context_line":"Partially-implements: bp watcher"},{"line_number":23,"context_line":"Signed-off-by: Dave Walker (Daviey) \u003cemail@daviey.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_9207a71b","line":22,"range":{"start_line":22,"start_character":22,"end_line":22,"end_character":24},"in_reply_to":"dada55a8_e8eb9d76","updated":"2016-07-19 14:12:43.000000000","message":"I can change it.. but bp is supported syntax... and the previous commit of this blueprint has already landed with this syntax.","commit_id":"22ff22ed0319bce32558652833680f5815f3e30d"}],"ansible/roles/common/templates/cron-logrotate-watcher.conf.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"ea2c42b8205dbf9e4e80d77ddc0541dfcfe417f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"/var/log/kolla/watcher/*.log\""},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dada55a8_28d775c0","line":1,"updated":"2016-07-19 11:42:54.000000000","message":"Should this be under [DEFAULT]?","commit_id":"22ff22ed0319bce32558652833680f5815f3e30d"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"ca4d7496ec10674c5ae57da74e7bfc3af9e107ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"/var/log/kolla/watcher/*.log\""},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"dada55a8_728f93cc","line":1,"in_reply_to":"dada55a8_28d775c0","updated":"2016-07-19 14:12:43.000000000","message":"Uhm?  Don\u0027t think so..\nTo compare:\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/common/templates/cron-logrotate-glance.conf.j2","commit_id":"22ff22ed0319bce32558652833680f5815f3e30d"}],"ansible/roles/haproxy/templates/haproxy.cfg.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"9a511549b58428afad36828daec758a5b2503b53","unresolved":false,"context_lines":[{"line_number":332,"context_line":"{% endif %}"},{"line_number":333,"context_line":"{% endif %}"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"{% if enable_watcher | bool %}"},{"line_number":336,"context_line":"listen watcher_api"},{"line_number":337,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ watcher_api_port }}"},{"line_number":338,"context_line":"{% for host in groups[\u0027watcher-api\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_6d2a1180","line":335,"range":{"start_line":335,"start_character":6,"end_line":335,"end_character":20},"updated":"2016-07-19 14:30:12.000000000","message":"I think this be within enable_ceilometer since this requires ceilometer to be enabled","commit_id":"aa6f51f6bfdcd1c644c87393ac16fdc18ac06944"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"ffa86585581a53963f946656c5189d718b1981b2","unresolved":false,"context_lines":[{"line_number":332,"context_line":"{% endif %}"},{"line_number":333,"context_line":"{% endif %}"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"{% if enable_watcher | bool %}"},{"line_number":336,"context_line":"listen watcher_api"},{"line_number":337,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ watcher_api_port }}"},{"line_number":338,"context_line":"{% for host in groups[\u0027watcher-api\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_ed78c12d","line":335,"range":{"start_line":335,"start_character":6,"end_line":335,"end_character":20},"in_reply_to":"dada55a8_6d2a1180","updated":"2016-07-19 14:37:29.000000000","message":"missing a verb there..  I think this should be within enable_ceilometer","commit_id":"aa6f51f6bfdcd1c644c87393ac16fdc18ac06944"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"cc84046899240303e698a1f8b8f27dcb8936fdb8","unresolved":false,"context_lines":[{"line_number":332,"context_line":"{% endif %}"},{"line_number":333,"context_line":"{% endif %}"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"{% if enable_watcher | bool %}"},{"line_number":336,"context_line":"listen watcher_api"},{"line_number":337,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ watcher_api_port }}"},{"line_number":338,"context_line":"{% for host in groups[\u0027watcher-api\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_f40b017b","line":335,"range":{"start_line":335,"start_character":6,"end_line":335,"end_character":20},"in_reply_to":"dada55a8_de28c035","updated":"2016-07-21 11:20:56.000000000","message":"Instead of within ceilometer, how about adding to the conditional if enable_ceilometer | bool and enable_watcher | bool similar to line 351.\n\nI agree that dumping this in ceilometer would be messy.","commit_id":"aa6f51f6bfdcd1c644c87393ac16fdc18ac06944"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"225e992154c144a5fc2c99e4c536cc85a6d35aaa","unresolved":false,"context_lines":[{"line_number":332,"context_line":"{% endif %}"},{"line_number":333,"context_line":"{% endif %}"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"{% if enable_watcher | bool %}"},{"line_number":336,"context_line":"listen watcher_api"},{"line_number":337,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ watcher_api_port }}"},{"line_number":338,"context_line":"{% for host in groups[\u0027watcher-api\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_de28c035","line":335,"range":{"start_line":335,"start_character":6,"end_line":335,"end_character":20},"in_reply_to":"dada55a8_ed78c12d","updated":"2016-07-20 17:15:58.000000000","message":"I\u0027m not sure i agree.  Enabling watcher does require ceilometer, but enabling ceilometer doesn\u0027t enable (and a user may not want) watcher.  I think switching this to ceilometer would be less clean and confusing to anyone looking at it.\n\nThis is similar to the ceilometer/mongodb scenario (but inverted).  Ceilometer requires mongodb, but I wouldn\u0027t put \"if enabled_mongodb\" for the ceilometer api endpoint?","commit_id":"aa6f51f6bfdcd1c644c87393ac16fdc18ac06944"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"9a511549b58428afad36828daec758a5b2503b53","unresolved":false,"context_lines":[{"line_number":55,"context_line":"instance_usage_audit \u003d True"},{"line_number":56,"context_line":"instance_usage_audit_period \u003d hour"},{"line_number":57,"context_line":"notify_on_state_change \u003d vm_and_task_state"},{"line_number":58,"context_line":"{% if enable_watcher | bool %}"},{"line_number":59,"context_line":"compute_monitors\u003dnova.compute.monitors.cpu.virt_driver"},{"line_number":60,"context_line":"{% endif %}"},{"line_number":61,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dada55a8_2d081a2d","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":20},"updated":"2016-07-19 14:30:12.000000000","message":"if watcher requires ceilometer to be enabled then should this logic be everywhere there is enable_watcher?","commit_id":"aa6f51f6bfdcd1c644c87393ac16fdc18ac06944"}],"ansible/roles/watcher/tasks/do_reconfigure.yml":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"ea2c42b8205dbf9e4e80d77ddc0541dfcfe417f9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - config_strategy \u003d\u003d \"COPY_ONCE\" or item[1][\u0027KOLLA_CONFIG_STRATEGY\u0027] \u003d\u003d \u0027COPY_ONCE\u0027"},{"line_number":45,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":46,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":47,"context_line":"  with_together:"},{"line_number":48,"context_line":"    - [{ name: watcher_api, group: watcher-api },"},{"line_number":49,"context_line":"       { name: watcher_engine, group: watcher-engine },"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_0ec6f948","line":46,"range":{"start_line":46,"start_character":5,"end_line":46,"end_character":52},"updated":"2016-07-19 11:42:54.000000000","message":"This needs to be first in the when statement to be sure this is the correct host otherwise the other when statements will fail.\n\nhttps://bugs.launchpad.net/kolla/+bug/1603943","commit_id":"22ff22ed0319bce32558652833680f5815f3e30d"}]}