)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":16704,"name":"James McCarthy","email":"james.m.mccarthy@oracle.com","username":"jmccarthy"},"change_message_id":"e819ce989e726173d95414663afdfb847eaa60fb","unresolved":false,"context_lines":[{"line_number":260,"context_line":"# Valid options are [ ext4, btrfs, xfs ]"},{"line_number":261,"context_line":"ceph_osd_filesystem: \"xfs\""},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# Set to \u0027yes-i-really-really-mean-it\u0027 to force wipe disks with existing partitions for OSDs. Only"},{"line_number":264,"context_line":"# set if you understand the consequences!"},{"line_number":265,"context_line":"ceph_osd_wipe_disk: \"\""},{"line_number":266,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_b71bb17f","line":263,"range":{"start_line":263,"start_character":10,"end_line":263,"end_character":37},"updated":"2016-07-05 11:05:11.000000000","message":"Would \"True\" suffice ? This string while attempting to enforce in the users mind they should be sure about what they are doing, seems odd, at least drop a really ;)","commit_id":"3b9afed462784ee5f89784aa696ad7c331849b0d"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a88dbd973e534011ab7ca7f4fc2dd6db56f40d6d","unresolved":false,"context_lines":[{"line_number":260,"context_line":"# Valid options are [ ext4, btrfs, xfs ]"},{"line_number":261,"context_line":"ceph_osd_filesystem: \"xfs\""},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# Set to \u0027yes-i-really-really-mean-it\u0027 to force wipe disks with existing partitions for OSDs. Only"},{"line_number":264,"context_line":"# set if you understand the consequences!"},{"line_number":265,"context_line":"ceph_osd_wipe_disk: \"\""},{"line_number":266,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_92dcc313","line":263,"range":{"start_line":263,"start_character":10,"end_line":263,"end_character":37},"in_reply_to":"1aa78d24_b71bb17f","updated":"2016-07-05 11:09:25.000000000","message":"I copied it from another operation in Ceph (http://docs.ceph.com/docs/hammer/rados/operations/pools/#delete-a-pool)\n\nWhen data is at stake I guess you can never be too careful, it is does look odd though :)","commit_id":"3b9afed462784ee5f89784aa696ad7c331849b0d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"accea34b5ca2c123f80e75bb94946c96face5ec4","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Set to \u0027yes-i-really-really-mean-it\u0027 to force wipe disks with existing partitions for OSDs. Only"},{"line_number":268,"context_line":"# set if you understand the consequences!"},{"line_number":269,"context_line":"ceph_osd_wipe_disk: \"\""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"# These are /etc/fstab options. Comma separated, no spaces (see fstab(8))"},{"line_number":272,"context_line":"ceph_osd_mount_options: \"defaults,noatime\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_58052478","line":269,"updated":"2016-07-26 07:42:36.000000000","message":"I think pause for a certain time is OK. pause infinity is unacceptable. like: if the user do not nothing in 5 minutes, then the playbook failed.","commit_id":"edfdf94d1546ba1e3c694ba6109bbeec915c27a7"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"fc53a1471dcbfdd2fb2bb962c37f00e150d5c86d","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Set to \u0027yes-i-really-really-mean-it\u0027 to force wipe disks with existing partitions for OSDs. Only"},{"line_number":268,"context_line":"# set if you understand the consequences!"},{"line_number":269,"context_line":"ceph_osd_wipe_disk: \"\""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"# These are /etc/fstab options. Comma separated, no spaces (see fstab(8))"},{"line_number":272,"context_line":"ceph_osd_mount_options: \"defaults,noatime\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_c04f0432","line":269,"updated":"2016-07-21 15:51:32.000000000","message":"Please use pause ansible module instead. Pause with prompt will allow users to decide during playbook runtime. http://docs.ansible.com/ansible/pause_module.html","commit_id":"edfdf94d1546ba1e3c694ba6109bbeec915c27a7"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a9b8736f02f2fd84dc88fcde582ead3d3100382c","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Set to \u0027yes-i-really-really-mean-it\u0027 to force wipe disks with existing partitions for OSDs. Only"},{"line_number":268,"context_line":"# set if you understand the consequences!"},{"line_number":269,"context_line":"ceph_osd_wipe_disk: \"\""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"# These are /etc/fstab options. Comma separated, no spaces (see fstab(8))"},{"line_number":272,"context_line":"ceph_osd_mount_options: \"defaults,noatime\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_cd4c42a0","line":269,"updated":"2016-07-22 03:43:28.000000000","message":"pause is not a good idea. In the automation process, there is no user to watcher the output in most case.","commit_id":"edfdf94d1546ba1e3c694ba6109bbeec915c27a7"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"67589d954f6df08e4e15eb2c8f3ee87e2b4e4783","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Set to \u0027yes-i-really-really-mean-it\u0027 to force wipe disks with existing partitions for OSDs. Only"},{"line_number":268,"context_line":"# set if you understand the consequences!"},{"line_number":269,"context_line":"ceph_osd_wipe_disk: \"\""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"# These are /etc/fstab options. Comma separated, no spaces (see fstab(8))"},{"line_number":272,"context_line":"ceph_osd_mount_options: \"defaults,noatime\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_13639d42","line":269,"in_reply_to":"dada55a8_c04f0432","updated":"2016-07-26 00:27:35.000000000","message":"A mixture of both seems appropriate.. lack of yes-i-really-mean-it causes a pause, whereas default behaviour is to pause - requiring human interaction.","commit_id":"edfdf94d1546ba1e3c694ba6109bbeec915c27a7"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"897a07b7abcbb25d748f87eb1b5f93298e48b348","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# Set to \u0027yes-i-really-really-mean-it\u0027 to force wipe disks with existing partitions for OSDs. Only"},{"line_number":268,"context_line":"# set if you understand the consequences!"},{"line_number":269,"context_line":"ceph_osd_wipe_disk: \"\""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"# These are /etc/fstab options. Comma separated, no spaces (see fstab(8))"},{"line_number":272,"context_line":"ceph_osd_mount_options: \"defaults,noatime\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_5dc0c6e0","line":269,"in_reply_to":"dada55a8_c04f0432","updated":"2016-08-03 10:02:27.000000000","message":"I can\u0027t see the value in pause here. Also agree with other comments that it\u0027s not appropriate in an automated environment. Can you expand?","commit_id":"edfdf94d1546ba1e3c694ba6109bbeec915c27a7"}],"docker/ceph/ceph-osd/extend_start.sh":[{"author":{"_account_id":16704,"name":"James McCarthy","email":"james.m.mccarthy@oracle.com","username":"jmccarthy"},"change_message_id":"e819ce989e726173d95414663afdfb847eaa60fb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        if [[ \"${OSD_DEV_NUM_PARTITIONS}\" \u003e \"1\" \\"},{"line_number":22,"context_line":"                \u0026\u0026 \"${OSD_FORCE_PARTITION}\" !\u003d \"yes-i-really-really-mean-it\" ]]; then"},{"line_number":23,"context_line":"            cat \u003c\u003c EOF"},{"line_number":24,"context_line":"STOP: ${OSD_DEV} is marked to be wiped and partitioned to for Ceph data and a co-located journal,"},{"line_number":25,"context_line":"but appears to have other existing partitions (\u003e1)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"If you are sure you want this disk to be *wiped* for use with Ceph, set"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1aa78d24_37ca216f","line":24,"range":{"start_line":24,"start_character":55,"end_line":24,"end_character":61},"updated":"2016-07-05 11:05:11.000000000","message":"typo","commit_id":"3b9afed462784ee5f89784aa696ad7c331849b0d"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a88dbd973e534011ab7ca7f4fc2dd6db56f40d6d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        if [[ \"${OSD_DEV_NUM_PARTITIONS}\" \u003e \"1\" \\"},{"line_number":22,"context_line":"                \u0026\u0026 \"${OSD_FORCE_PARTITION}\" !\u003d \"yes-i-really-really-mean-it\" ]]; then"},{"line_number":23,"context_line":"            cat \u003c\u003c EOF"},{"line_number":24,"context_line":"STOP: ${OSD_DEV} is marked to be wiped and partitioned to for Ceph data and a co-located journal,"},{"line_number":25,"context_line":"but appears to have other existing partitions (\u003e1)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"If you are sure you want this disk to be *wiped* for use with Ceph, set"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1aa78d24_72d797ed","line":24,"range":{"start_line":24,"start_character":55,"end_line":24,"end_character":61},"in_reply_to":"1aa78d24_37ca216f","updated":"2016-07-05 11:09:25.000000000","message":"Done","commit_id":"3b9afed462784ee5f89784aa696ad7c331849b0d"}],"releasenotes/notes/add-ceph-disk-init-protection-5b38ce8f1502ff69.yaml":[{"author":{"_account_id":16704,"name":"James McCarthy","email":"james.m.mccarthy@oracle.com","username":"jmccarthy"},"change_message_id":"e819ce989e726173d95414663afdfb847eaa60fb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    not wipe disks that contain more than one partition."},{"line_number":15,"context_line":"    An operator may override this behaviour by setting"},{"line_number":16,"context_line":"    the Ansible variable \u0027ceph_osd_wipe_disk\u0027 to"},{"line_number":17,"context_line":"    \u0027yes-i-really-really-mean-it\u0027. The variable itself"},{"line_number":18,"context_line":"    is passed to the bootstrap container as an environment"},{"line_number":19,"context_line":"    variable, retaining compatibility for non Ansible"},{"line_number":20,"context_line":"    based deployments."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_725157d8","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":32},"updated":"2016-07-05 11:05:11.000000000","message":"Would True suffice ? This string while attempting to enforce in the users mind they should be sure about what they are doing, seems odd, at least drop a really ;)","commit_id":"3b9afed462784ee5f89784aa696ad7c331849b0d"}]}