)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"bd97a488bd54e9cc25dd61885b1cf0239134341f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Set_configs.py had to be extended to support globbing (wildcards) in"},{"line_number":15,"context_line":"order to copy ceph keyring file which is named depending on the cephx"},{"line_number":16,"context_line":"user name."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iacadbd8ec9956e9f075206ea03b28f044cb6ffb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_c049cb61","line":17,"updated":"2016-07-13 11:06:58.000000000","message":"Please add a bug id for this change (http://docs.openstack.org/developer/kolla/CONTRIBUTING.html)","commit_id":"c3b63402135359b958e10909ded9c2d767da7724"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1de7224fd3f8083d6a5b13e0f87f8a0a682003dd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"order to copy ceph keyring file which is named depending on the cephx"},{"line_number":16,"context_line":"user name."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"bp: external-ceph"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Iacadbd8ec9956e9f075206ea03b28f044cb6ffb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_495b3f54","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":17},"updated":"2016-07-13 13:32:27.000000000","message":"Implements: bp: external-ceph","commit_id":"c0407d757e0a4d74043eccf6ea0fa2644f44ba06"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f9ccf8fe03f79d454bd7a4ab11943030efd20546","unresolved":false,"context_lines":[{"line_number":15,"context_line":"order to copy ceph keyring file which is named depending on the cephx"},{"line_number":16,"context_line":"user name."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: bp: external-ceph"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Iacadbd8ec9956e9f075206ea03b28f044cb6ffb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aa78d24_b58be967","line":18,"updated":"2016-07-14 07:09:36.000000000","message":"this is not implementing the external ceph. it is use different\nstorage for differenct stroage, actually. Do we have such a bp?","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"092b7e5c292055f2f5b1bd630cf1052793e14e0c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"order to copy ceph keyring file which is named depending on the cephx"},{"line_number":16,"context_line":"user name."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: bp: external-ceph"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Iacadbd8ec9956e9f075206ea03b28f044cb6ffb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aa78d24_b86d999b","line":18,"in_reply_to":"1aa78d24_b58be967","updated":"2016-07-14 09:31:10.000000000","message":"Partly, I agree. Still ceph files must be copied over which is implemented here. I know I could have done this in two steps: external ceph + different storage for different service in a second blueprint, but I thought the topics are very related. If you still think creating a second blueprint is necessary for +1 let me know and I\u0027ll create one.","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"bd97a488bd54e9cc25dd61885b1cf0239134341f","unresolved":false,"context_lines":[{"line_number":220,"context_line":"num_nova_fake_per_node: 5"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# Control usage of ceph per service"},{"line_number":223,"context_line":"glance_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":224,"context_line":"nova_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":225,"context_line":"cinder_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":226,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_0084735b","line":223,"updated":"2016-07-13 11:06:58.000000000","message":"\"enable_glance_ceph\" may be more consistent with the other vars in this file","commit_id":"c3b63402135359b958e10909ded9c2d767da7724"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"10d8fbbe04ca63cf9fe131cb929a2f013406660f","unresolved":false,"context_lines":[{"line_number":220,"context_line":"num_nova_fake_per_node: 5"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# Control usage of ceph per service"},{"line_number":223,"context_line":"glance_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":224,"context_line":"nova_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":225,"context_line":"cinder_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":226,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_36b29506","line":223,"in_reply_to":"1aa78d24_0084735b","updated":"2016-07-13 12:02:12.000000000","message":"I though of this, too. Then I found \"ceph_enable_cache\" which is ceph specific and therefore starts with \"ceph_\". Following the other pattern that would have to be named \"enable_ceph_cache\", no? Not sure, I can live with both ways ;)","commit_id":"c3b63402135359b958e10909ded9c2d767da7724"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"bd97a488bd54e9cc25dd61885b1cf0239134341f","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# Control usage of ceph per service"},{"line_number":223,"context_line":"glance_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":224,"context_line":"nova_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":225,"context_line":"cinder_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_a05bdf20","line":224,"updated":"2016-07-13 11:06:58.000000000","message":"Best only add the var for Glance in this patch","commit_id":"c3b63402135359b958e10909ded9c2d767da7724"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"35584474a8ff183607fdbc915e9feb3770f2bc69","unresolved":false,"context_lines":[{"line_number":220,"context_line":"num_nova_fake_per_node: 5"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# Control usage of ceph per service"},{"line_number":223,"context_line":"glance_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"####################"},{"line_number":226,"context_line":"# RabbitMQ options"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_b79cadc0","line":223,"updated":"2016-07-13 17:08:57.000000000","message":"not saying no, but curious why we would need to enable per service.  Wouldn\u0027t the ability to enable once be preferred?","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"c51ff856d8acfb846a6988281da20ae36a5d0700","unresolved":false,"context_lines":[{"line_number":220,"context_line":"num_nova_fake_per_node: 5"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# Control usage of ceph per service"},{"line_number":223,"context_line":"glance_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"####################"},{"line_number":226,"context_line":"# RabbitMQ options"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_57a629ab","line":223,"in_reply_to":"1aa78d24_b79cadc0","updated":"2016-07-13 17:16:10.000000000","message":"Hi Steven, I believe we need this as as common deployment architecture includes local storage for Nova instead of Ceph (latency, boot storms, decentralization, many more reasons) while Cinder volumes and Glance images go on Ceph. Also Glance may use some S3 compatible method. You see the combinations that make sense are numerous :)","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"}],"ansible/roles/glance/tasks/deploy.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"bd97a488bd54e9cc25dd61885b1cf0239134341f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- debug: msg\u003d\"enable_ceph {{ enable_ceph | bool}}\""},{"line_number":4,"context_line":"- debug: msg\u003d\"glance_enable_ceph {{ glance_enable_ceph | bool}}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: ceph.yml"},{"line_number":7,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_0c366f02","line":4,"updated":"2016-07-13 11:06:58.000000000","message":"Please remove these debug statements for merge","commit_id":"c3b63402135359b958e10909ded9c2d767da7724"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1de7224fd3f8083d6a5b13e0f87f8a0a682003dd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  when:"},{"line_number":4,"context_line":"    - (enable_ceph | bool) and (glance_enable_ceph | bool)"},{"line_number":5,"context_line":"    - inventory_hostname in groups[\u0027ceph-mon\u0027] or"},{"line_number":6,"context_line":"        inventory_hostname in groups[\u0027glance-api\u0027] or"},{"line_number":7,"context_line":"        inventory_hostname in groups[\u0027glance-registry\u0027]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- include: external_ceph.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_e964ab22","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":8},"updated":"2016-07-13 13:32:27.000000000","message":"fix indenting","commit_id":"c0407d757e0a4d74043eccf6ea0fa2644f44ba06"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1de7224fd3f8083d6a5b13e0f87f8a0a682003dd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    - (enable_ceph | bool) and (glance_enable_ceph | bool)"},{"line_number":5,"context_line":"    - inventory_hostname in groups[\u0027ceph-mon\u0027] or"},{"line_number":6,"context_line":"        inventory_hostname in groups[\u0027glance-api\u0027] or"},{"line_number":7,"context_line":"        inventory_hostname in groups[\u0027glance-registry\u0027]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- include: external_ceph.yml"},{"line_number":10,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_4974dfcd","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":8},"updated":"2016-07-13 13:32:27.000000000","message":"fix indenting","commit_id":"c0407d757e0a4d74043eccf6ea0fa2644f44ba06"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1de7224fd3f8083d6a5b13e0f87f8a0a682003dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  when:"},{"line_number":11,"context_line":"    - (enable_ceph | bool \u003d\u003d False) and (glance_enable_ceph | bool)"},{"line_number":12,"context_line":"    - inventory_hostname in groups[\u0027glance-api\u0027] or"},{"line_number":13,"context_line":"        inventory_hostname in groups[\u0027glance-registry\u0027]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- include: register.yml"},{"line_number":16,"context_line":"  when: inventory_hostname in groups[\u0027glance-api\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_29b4f37f","line":13,"range":{"start_line":13,"start_character":6,"end_line":13,"end_character":8},"updated":"2016-07-13 13:32:27.000000000","message":"fix indenting","commit_id":"c0407d757e0a4d74043eccf6ea0fa2644f44ba06"}],"ansible/roles/glance/templates/glance-api.json.j2":[{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"f5e013c720e46393349db9e48ee1a7f7e72f31f8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph.*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/ceph/\","},{"line_number":13,"context_line":"            \"owner\": \"glance\","},{"line_number":14,"context_line":"            \"perm\": \"0700\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"        {% endif %}"},{"line_number":17,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1aa78d24_9def1de8","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":25},"updated":"2016-07-13 14:23:38.000000000","message":"Why do we need to change permission here?","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"3f0eb547051157a0d6da7951c905275657008064","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph.*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/ceph/\","},{"line_number":13,"context_line":"            \"owner\": \"glance\","},{"line_number":14,"context_line":"            \"perm\": \"0700\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"        {% endif %}"},{"line_number":17,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1aa78d24_0baabdd2","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":25},"in_reply_to":"1aa78d24_57162949","updated":"2016-07-13 17:20:17.000000000","message":"Yep, thanks for explaining more clearly. There is one thing though, that popped up: Setting 700 works for the director but the files get the x too. It doesn\u0027t really hurt, though. You think it has to be fixed before merge?","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"35584474a8ff183607fdbc915e9feb3770f2bc69","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph.*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/ceph/\","},{"line_number":13,"context_line":"            \"owner\": \"glance\","},{"line_number":14,"context_line":"            \"perm\": \"0700\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"        {% endif %}"},{"line_number":17,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1aa78d24_57162949","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":25},"in_reply_to":"1aa78d24_83b22047","updated":"2016-07-13 17:08:57.000000000","message":"Mathais,\n\nI think Alicja didnt\u0027 understand the /etc/ceph was a directory and needs 700 to execute into the directory via ls/cd/etc.","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"653796b008c0b0103e9b027dccaeb07b0551533f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph.*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/ceph/\","},{"line_number":13,"context_line":"            \"owner\": \"glance\","},{"line_number":14,"context_line":"            \"perm\": \"0700\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"        {% endif %}"},{"line_number":17,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1aa78d24_83b22047","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":25},"in_reply_to":"1aa78d24_9def1de8","updated":"2016-07-13 14:48:47.000000000","message":"The reason is that set_config.py would set 600 for the directory /etc/ceph/ and that would disallow listing the directory contents. When doing so, glance fails to read ceph.conf and throws an error message. Do you have any better idea to solve this than to set 0700?","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"}],"etc/kolla/globals.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"32833ed6b26c1767a665476b1dafb0ac9730f9b4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"#enable_swift: \"no\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"# Control usage of ceph per service"},{"line_number":129,"context_line":"glance_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":130,"context_line":"nova_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":131,"context_line":"cinder_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"###################"},{"line_number":134,"context_line":"# Ceph options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_43e5e5d9","line":131,"range":{"start_line":129,"start_character":0,"end_line":131,"end_character":39},"updated":"2016-07-13 11:43:21.000000000","message":"please, comment it","commit_id":"c3b63402135359b958e10909ded9c2d767da7724"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1de7224fd3f8083d6a5b13e0f87f8a0a682003dd","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"# Control usage of ceph per service. This allows to configure external ceph"},{"line_number":129,"context_line":"# when ceph is not deployed by Kolla."},{"line_number":130,"context_line":"glance_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"###################"},{"line_number":133,"context_line":"# Ceph options"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_a91e23b8","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":39},"updated":"2016-07-13 13:32:27.000000000","message":"comment this line","commit_id":"c0407d757e0a4d74043eccf6ea0fa2644f44ba06"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"35584474a8ff183607fdbc915e9feb3770f2bc69","unresolved":false,"context_lines":[{"line_number":126,"context_line":"#enable_swift: \"no\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"# Control usage of ceph per service. This allows to configure external ceph"},{"line_number":129,"context_line":"# when ceph is not deployed by Kolla."},{"line_number":130,"context_line":"#glance_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"###################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_1748212c","line":129,"updated":"2016-07-13 17:08:57.000000000","message":"would you mind explaning this assertion more in the review.  I don\u0027t understand why we can\u0027t just have enable_ceph for all of OpenStack independent and orthogonally to whether which services are enabled.  IMO we want all or nothing for CEPH.\n\nAlso we are not super keen on adding config options (which is why I raise this question).","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"c51ff856d8acfb846a6988281da20ae36a5d0700","unresolved":false,"context_lines":[{"line_number":126,"context_line":"#enable_swift: \"no\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"# Control usage of ceph per service. This allows to configure external ceph"},{"line_number":129,"context_line":"# when ceph is not deployed by Kolla."},{"line_number":130,"context_line":"#glance_enable_ceph: \"{{ enable_ceph }}\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"###################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_f7411564","line":129,"in_reply_to":"1aa78d24_1748212c","updated":"2016-07-13 17:16:10.000000000","message":"pretty much the same answer I gave to you question about group_vars/all.yaml applies here too :) The all or nothing on Ceph approach doesn\u0027t cut it for many deployments. Personally, I\u0027ve seen two major installation with local storage vor Nova. \n\nI totally understand that more options are bad, which is why I decided not to proceed with the previous patch that addressed this blueprint. I believe this path represents the minimum necessary for the reason above.","commit_id":"860bdae8f81625b0fa95291475ebc1347416d24a"}]}