)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"56c9cbe992a588517f178a189ff91661adffcdf8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  This change enable support of openvswitch with"},{"line_number":12,"context_line":"  the dpdk acclerated netdev datapath."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint ovs-dpdk"},{"line_number":15,"context_line":"Change-Id: I7c3a5dddeca1886fe1c7681ce8d5bebde08f3102"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a71b18c_75210dfc","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":10},"updated":"2016-12-09 01:32:18.000000000","message":"change to partial","commit_id":"d91ef218bc5084e5dacf23604892c2bd9faa2aa7"}],"ansible/roles/neutron/tasks/start.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82ad4e0d51b2b1c25b54e3a1c21e51dca360eaa4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"       or inventory_hostname in groups[\u0027neutron-vpnaas-agent\u0027])"},{"line_number":75,"context_line":"    - neutron_plugin_agent \u003d\u003d \"openvswitch\""},{"line_number":76,"context_line":"    - ovs_datapath \u003d\u003d \"system\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"#      - \"/dev/hugepages:/dev/hugepages:shared\""},{"line_number":79,"context_line":"#      - \"/dev/userio:/dev/userio:rw\""},{"line_number":80,"context_line":"#      - \"/dev/vfio:/dev/vfio/:rw\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- name: Starting openvswitch-vswitchd-dpdk container"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_dfa07da8","line":80,"range":{"start_line":77,"start_character":0,"end_line":80,"end_character":34},"updated":"2016-10-26 23:18:46.000000000","message":"delete","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82ad4e0d51b2b1c25b54e3a1c21e51dca360eaa4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"      - \"{{ node_config_directory }}/openvswitch-vswitchd/:{{ container_config_directory }}/:ro\""},{"line_number":92,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":93,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":94,"context_line":"      - \"/var/run:/var/run\""},{"line_number":95,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":96,"context_line":"      - \"/dev:/dev:rw\""},{"line_number":97,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_ff8c6137","line":94,"range":{"start_line":94,"start_character":6,"end_line":94,"end_character":27},"updated":"2016-10-26 23:18:46.000000000","message":"i should be able to use /run instead as is done for kernel ovs","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82ad4e0d51b2b1c25b54e3a1c21e51dca360eaa4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":94,"context_line":"      - \"/var/run:/var/run\""},{"line_number":95,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":96,"context_line":"      - \"/dev:/dev:rw\""},{"line_number":97,"context_line":"  when:"},{"line_number":98,"context_line":"    - (inventory_hostname in groups[\u0027compute\u0027]"},{"line_number":99,"context_line":"       or (enable_manila | bool and inventory_hostname in groups[\u0027manila-share\u0027])"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_9f9fe55e","line":96,"range":{"start_line":96,"start_character":6,"end_line":96,"end_character":22},"updated":"2016-10-26 23:18:46.000000000","message":"i may be able to restrict this later once i determin why dpdk phyical nic are not working.\n\n/dev/hugepages is require\n/dev/vfio/ is require if vfio-pci is used.\n/dev/userio is required if uio_pci_generic is used","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"}],"ansible/roles/neutron/templates/openvswitch-vswitchd-dpdk.json.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82ad4e0d51b2b1c25b54e3a1c21e51dca360eaa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba5da102_bfc5895c","updated":"2016-10-26 23:18:46.000000000","message":"this file is not needed and can be removed.","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"}],"ansible/roles/nova/tasks/start_compute.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82ad4e0d51b2b1c25b54e3a1c21e51dca360eaa4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":13,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":14,"context_line":"      - \"/run/:/run/:shared\""},{"line_number":15,"context_line":"      - \"/var/run/openvswitch:/var/run/openvswitch\""},{"line_number":16,"context_line":"      - \"/dev:/dev\""},{"line_number":17,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":18,"context_line":"      - \"kolla_logs:/var/log/kolla/\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba5da102_5fce2d84","line":15,"range":{"start_line":15,"start_character":6,"end_line":15,"end_character":51},"updated":"2016-10-26 23:18:46.000000000","message":"i should be able to use /run/openvswitch here which i will get acess too from line 14 so i should be able to remove this change. but i need to test it first","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"}],"ansible/roles/nova/templates/qemu.conf.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82ad4e0d51b2b1c25b54e3a1c21e51dca360eaa4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"stdio_handler \u003d \"file\""},{"line_number":2,"context_line":"user \u003d \"root\""},{"line_number":3,"context_line":"group \u003d \"root\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"cgroup_device_acl \u003d ["},{"line_number":6,"context_line":"    \"/dev/null\", \"/dev/full\", \"/dev/zero\","}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba5da102_bfee69ea","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":14},"updated":"2016-10-26 23:18:46.000000000","message":"this is temporary and will be removed i a later revision.","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82ad4e0d51b2b1c25b54e3a1c21e51dca360eaa4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"user \u003d \"root\""},{"line_number":3,"context_line":"group \u003d \"root\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"cgroup_device_acl \u003d ["},{"line_number":6,"context_line":"    \"/dev/null\", \"/dev/full\", \"/dev/zero\","},{"line_number":7,"context_line":"    \"/dev/random\", \"/dev/urandom\","},{"line_number":8,"context_line":"    \"/dev/ptmx\", \"/dev/kvm\", \"/dev/kqemu\","},{"line_number":9,"context_line":"    \"/dev/rtc\", \"/dev/hpet\",\"/dev/net/tun\","},{"line_number":10,"context_line":"    \"/dev/vfio/vfio\","},{"line_number":11,"context_line":"]"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba5da102_dfb95dee","line":11,"range":{"start_line":5,"start_character":0,"end_line":11,"end_character":1},"updated":"2016-10-26 23:18:46.000000000","message":"this may not be needed with newer libvirt.","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"}],"contrib/template-override/ovs-dpdk-source.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{%- endmacro %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# compile ovs"},{"line_number":10,"context_line":"{% block  ovsdpdk_install %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"    {% set ovs_dpdk_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_aa6b9c83","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":10},"updated":"2017-01-07 22:55:39.000000000","message":"nit, two spaces","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77c5adb27592687d41bfd5258aa27d18dcb13382","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{%- endmacro %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# compile ovs"},{"line_number":10,"context_line":"{% block  ovsdpdk_install %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"    {% set ovs_dpdk_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_0d13c60e","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":10},"in_reply_to":"ba5201f7_aa6b9c83","updated":"2017-01-09 15:46:29.000000000","message":"thanks i will fix.","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# compile ovs"},{"line_number":10,"context_line":"{% block  ovsdpdk_install %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":14,"context_line":"        \u0027kernel-devel-$(uname -r)\u0027,"},{"line_number":15,"context_line":"        \u0027redhat-lsb-core\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_ca6620ba","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":40},"updated":"2017-01-07 22:55:39.000000000","message":"fedora support has been deprecated","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77c5adb27592687d41bfd5258aa27d18dcb13382","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# compile ovs"},{"line_number":10,"context_line":"{% block  ovsdpdk_install %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":13,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":14,"context_line":"        \u0027kernel-devel-$(uname -r)\u0027,"},{"line_number":15,"context_line":"        \u0027redhat-lsb-core\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_ad2aba2d","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":40},"in_reply_to":"ba5201f7_ca6620ba","updated":"2017-01-09 15:46:29.000000000","message":"yes i will remove i started this in newton when it was still a thing.","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \u0027python-six\u0027"},{"line_number":27,"context_line":"     ] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":32,"context_line":"        \u0027linux-headers-$(uname -r)\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_ea0764c7","line":29,"updated":"2017-01-07 22:55:39.000000000","message":"debian still supported bit not tested","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77c5adb27592687d41bfd5258aa27d18dcb13382","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \u0027python-six\u0027"},{"line_number":27,"context_line":"     ] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":32,"context_line":"        \u0027linux-headers-$(uname -r)\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_2d1faa0a","line":29,"in_reply_to":"ba5201f7_ea0764c7","updated":"2017-01-09 15:46:29.000000000","message":"ok i can add debian.","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"./configure --with-dpdk\u003d\"/dpdk/build\" --prefix\u003d/usr --with-dbdir\u003d/etc/openvswitch --with-rundir\u003d/run/openvswitch \u0026\u0026 \\"},{"line_number":73,"context_line":"make -j $(nproc) CFLAGS\u003d\u0027-O3 -fPIC\u0027 \u0026\u0026 make install"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_4a115003","line":75,"updated":"2017-01-07 22:55:39.000000000","message":"Extra empty lines, please remove it.","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1c59da1a54cd31bac57219142248d9554cfba130","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% macro sed(file\u003d\u0027\u0027, expressions\u003d[]) -%}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"RUN /bin/true ; {% for expression in expressions %} sed -i \"{{ file }}\" -e \"{{ expression }}\" \u0026\u0026 {% endfor %} /bin/true"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_796850bb","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":41},"updated":"2017-01-10 17:12:53.000000000","message":"Can we include sed macro into main macros.j2?","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af7be303ad13ac1be1cb9dad8f969c23ee272347","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends parent_template %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% macro sed(file\u003d\u0027\u0027, expressions\u003d[]) -%}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"RUN /bin/true ; {% for expression in expressions %} sed -i \"{{ file }}\" -e \"{{ expression }}\" \u0026\u0026 {% endfor %} /bin/true"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_4059cc5a","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":41},"in_reply_to":"ba5201f7_796850bb","updated":"2017-01-10 18:25:59.000000000","message":"am yes sure it will likely be useful again at some point.","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1c59da1a54cd31bac57219142248d9554cfba130","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% macro sed(file\u003d\u0027\u0027, expressions\u003d[]) -%}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"RUN /bin/true ; {% for expression in expressions %} sed -i \"{{ file }}\" -e \"{{ expression }}\" \u0026\u0026 {% endfor %} /bin/true"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{%- endmacro %}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_7920504a","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":13},"updated":"2017-01-10 17:12:53.000000000","message":"Why do we need to force an OK? Same comment for /bin/true at end of line.","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af7be303ad13ac1be1cb9dad8f969c23ee272347","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{% macro sed(file\u003d\u0027\u0027, expressions\u003d[]) -%}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"RUN /bin/true ; {% for expression in expressions %} sed -i \"{{ file }}\" -e \"{{ expression }}\" \u0026\u0026 {% endfor %} /bin/true"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{%- endmacro %}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_433c76bf","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":13},"in_reply_to":"ba5201f7_7920504a","updated":"2017-01-10 18:25:59.000000000","message":"its to handle the case where the list of expressions is empty\n\ni may be able to handle this with an if statement and a test of the number of entries instead.\n\nthat would prevent a layer being generated if it was not needed.","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1c59da1a54cd31bac57219142248d9554cfba130","unresolved":false,"context_lines":[{"line_number":70,"context_line":"WORKDIR /ovs"},{"line_number":71,"context_line":"RUN ./boot.sh \u0026\u0026 \\"},{"line_number":72,"context_line":"./configure --with-dpdk\u003d\"/dpdk/build\" --prefix\u003d/usr --with-dbdir\u003d/etc/openvswitch --with-rundir\u003d/run/openvswitch \u0026\u0026 \\"},{"line_number":73,"context_line":"make -j $(nproc) CFLAGS\u003d\u0027-O3 -fPIC\u0027 \u0026\u0026 make install"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_19f1046b","line":73,"range":{"start_line":73,"start_character":36,"end_line":73,"end_character":51},"updated":"2017-01-10 17:12:53.000000000","message":"Could you jump this to the next line?","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af7be303ad13ac1be1cb9dad8f969c23ee272347","unresolved":false,"context_lines":[{"line_number":70,"context_line":"WORKDIR /ovs"},{"line_number":71,"context_line":"RUN ./boot.sh \u0026\u0026 \\"},{"line_number":72,"context_line":"./configure --with-dpdk\u003d\"/dpdk/build\" --prefix\u003d/usr --with-dbdir\u003d/etc/openvswitch --with-rundir\u003d/run/openvswitch \u0026\u0026 \\"},{"line_number":73,"context_line":"make -j $(nproc) CFLAGS\u003d\u0027-O3 -fPIC\u0027 \u0026\u0026 make install"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_c39dc6bc","line":73,"range":{"start_line":73,"start_character":36,"end_line":73,"end_character":51},"in_reply_to":"ba5201f7_19f1046b","updated":"2017-01-10 18:25:59.000000000","message":"yes ill do this in the next version.","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"e9460367e84791fe02de6c3e77991513cecf8386","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":7,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":8,"context_line":"        \u0027kernel-devel-$(uname -r)\u0027,"},{"line_number":9,"context_line":"        \u0027redhat-lsb-core\u0027,"},{"line_number":10,"context_line":"        \u0027pciutils\u0027,"},{"line_number":11,"context_line":"        \u0027autoconf\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3a461143_08c6f847","line":8,"updated":"2017-01-27 13:19:34.000000000","message":"Kernel headers should not be installed. It\u0027s not needed (dpdk kernel modules are not built anyway) and additionally it fails when the host os has a different os/kernel version than the base os image. $(uname -r) is evaulated on the build host, not inside the docker image build.","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"4e169c781a9558aed8d8881a5797b6e2e83cf29f","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":7,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":8,"context_line":"        \u0027kernel-devel-$(uname -r)\u0027,"},{"line_number":9,"context_line":"        \u0027redhat-lsb-core\u0027,"},{"line_number":10,"context_line":"        \u0027pciutils\u0027,"},{"line_number":11,"context_line":"        \u0027autoconf\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3a461143_d90da03f","line":8,"in_reply_to":"3a461143_08c6f847","updated":"2017-01-27 13:53:32.000000000","message":"... my bad, uname -r is evaulated during the image build but anyway this can be different during build time vs. deployment time. And the kernel-devel is not needed for the build anyway.","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a1ec96735ecd5f2a90660dcf7c010f4d4e811267","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":7,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":8,"context_line":"        \u0027kernel-devel-$(uname -r)\u0027,"},{"line_number":9,"context_line":"        \u0027redhat-lsb-core\u0027,"},{"line_number":10,"context_line":"        \u0027pciutils\u0027,"},{"line_number":11,"context_line":"        \u0027autoconf\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1a430d35_e31d9610","line":8,"in_reply_to":"3a461143_d90da03f","updated":"2017-02-03 18:52:06.000000000","message":"this is jsut pulling in the kernel headers.\nthey dont need to match exactly but there is no metapackage that i can use such as kernel-devel-generic.\n\ndpdk needs these to be installed but only for some macros/defines as far as i am aware so as we are not compiling any of the dpdk kernel modules such as kni or igb_uio these will not be used for linking to the kernel and therefor do not need to match the headres on the target plathform.","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"e9460367e84791fe02de6c3e77991513cecf8386","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"{{ macros.install_packages(ovs_dpdk_packages | customizable(\"packages\")) }}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ADD plugins-archive /"},{"line_number":47,"context_line":"RUN ln -s /plugins/ovsdpdk-plugin-ovs-archive-*/ /ovs \u0026\u0026 ln -s /plugins/ovsdpdk-plugin-dpdk-archive-*/ /dpdk"},{"line_number":48,"context_line":"WORKDIR /dpdk"},{"line_number":49,"context_line":"{% set RTE_TARGET\u003d\u0027x86_64-native-linuxapp-gcc\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3a461143_e3270d10","line":46,"updated":"2017-01-27 13:19:34.000000000","message":"when using ovs as a souce package (not as a plugin):\nADD ovsdpdk-archive /ovs","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"e9460367e84791fe02de6c3e77991513cecf8386","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{{ macros.install_packages(ovs_dpdk_packages | customizable(\"packages\")) }}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ADD plugins-archive /"},{"line_number":47,"context_line":"RUN ln -s /plugins/ovsdpdk-plugin-ovs-archive-*/ /ovs \u0026\u0026 ln -s /plugins/ovsdpdk-plugin-dpdk-archive-*/ /dpdk"},{"line_number":48,"context_line":"WORKDIR /dpdk"},{"line_number":49,"context_line":"{% set RTE_TARGET\u003d\u0027x86_64-native-linuxapp-gcc\u0027 %}"},{"line_number":50,"context_line":"RUN make config T\u003d\"{{ RTE_TARGET }}\""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3a461143_48c80023","line":47,"updated":"2017-01-27 13:19:34.000000000","message":"note: this fails when installing plugins as type \u0027local\u0027 (plugin directories can/will have different names then)","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a1ec96735ecd5f2a90660dcf7c010f4d4e811267","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{{ macros.install_packages(ovs_dpdk_packages | customizable(\"packages\")) }}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ADD plugins-archive /"},{"line_number":47,"context_line":"RUN ln -s /plugins/ovsdpdk-plugin-ovs-archive-*/ /ovs \u0026\u0026 ln -s /plugins/ovsdpdk-plugin-dpdk-archive-*/ /dpdk"},{"line_number":48,"context_line":"WORKDIR /dpdk"},{"line_number":49,"context_line":"{% set RTE_TARGET\u003d\u0027x86_64-native-linuxapp-gcc\u0027 %}"},{"line_number":50,"context_line":"RUN make config T\u003d\"{{ RTE_TARGET }}\""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1a430d35_63bfe6d0","line":47,"in_reply_to":"3a461143_48c80023","updated":"2017-02-03 18:52:06.000000000","message":"it may work with tar balls only but for this example code i specifcaly chose to suppot git only.","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"}],"contrib/template-override/ovs-dpdk.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c836768d6654946ca0571a18da4a649ef6eaba6e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":16,"context_line":"        \u0027openvswitch-switch-dpdk\u0027"},{"line_number":17,"context_line":"    ] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"dfeb2761_b7d905f4","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":33},"updated":"2017-04-05 03:11:20.000000000","message":"add crudini","commit_id":"cf83176e45c0f9f0e3c171edbe24f72b58e5c7df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c836768d6654946ca0571a18da4a649ef6eaba6e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{% else %}"},{"line_number":31,"context_line":"# install ovs from source"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":34,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":35,"context_line":"        \u0027kernel-devel-$(uname -r)\u0027,"},{"line_number":36,"context_line":"        \u0027redhat-lsb-core\u0027,"},{"line_number":37,"context_line":"        \u0027pciutils\u0027,"},{"line_number":38,"context_line":"        \u0027autoconf\u0027,"},{"line_number":39,"context_line":"        \u0027libtool\u0027,"},{"line_number":40,"context_line":"        \u0027fuse-devel\u0027,"},{"line_number":41,"context_line":"        \u0027gcc\u0027,"},{"line_number":42,"context_line":"        \u0027make\u0027,"},{"line_number":43,"context_line":"        \u0027autoconf\u0027,"},{"line_number":44,"context_line":"        \u0027automake\u0027,"},{"line_number":45,"context_line":"        \u0027libpcap-devel\u0027,"},{"line_number":46,"context_line":"        \u0027python-devel\u0027,"},{"line_number":47,"context_line":"        \u0027python-six\u0027"},{"line_number":48,"context_line":"     ] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":53,"context_line":"        \u0027linux-headers-$(uname -r)\u0027,"},{"line_number":54,"context_line":"        \u0027fdutils\u0027,"},{"line_number":55,"context_line":"        \u0027libxtst6\u0027,"},{"line_number":56,"context_line":"        \u0027libnuma-dev\u0027,"},{"line_number":57,"context_line":"        \u0027autoconf\u0027,"},{"line_number":58,"context_line":"        \u0027automake\u0027,"},{"line_number":59,"context_line":"        \u0027libtool\u0027,"},{"line_number":60,"context_line":"        \u0027libfuse-dev\u0027,"},{"line_number":61,"context_line":"        \u0027gcc\u0027,"},{"line_number":62,"context_line":"        \u0027make\u0027,"},{"line_number":63,"context_line":"        \u0027build-essential\u0027,"},{"line_number":64,"context_line":"        \u0027libpcap-dev\u0027,"},{"line_number":65,"context_line":"        \u0027python-dev\u0027,"},{"line_number":66,"context_line":"        \u0027python-six\u0027"},{"line_number":67,"context_line":"    ] %}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"{% endif %}"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"dfeb2761_37ce152e","line":67,"range":{"start_line":33,"start_character":0,"end_line":67,"end_character":8},"updated":"2017-04-05 03:11:20.000000000","message":"need to add crudini","commit_id":"cf83176e45c0f9f0e3c171edbe24f72b58e5c7df"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"03a4bd4af5719084c75f6448a1d6fbadbb360209","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(ovs_dpdk_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"RUN update-alternatives --set ovs-vswitchd /usr/lib/openvswitch-switch-dpdk/ovs-vswitchd-dpdk"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5f201791_bb885471","line":23,"range":{"start_line":23,"start_character":22,"end_line":23,"end_character":40},"updated":"2017-06-21 09:07:46.000000000","message":"alphabetize","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"03a4bd4af5719084c75f6448a1d6fbadbb360209","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \u0027crudini\u0027"},{"line_number":49,"context_line":"     ] %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    {% set ovs_dpdk_packages \u003d ["},{"line_number":54,"context_line":"        \u0027linux-headers-$(uname -r)\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5f201791_1b91889a","line":51,"range":{"start_line":51,"start_character":24,"end_line":51,"end_character":42},"updated":"2017-06-21 09:07:46.000000000","message":"ditto","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"03a4bd4af5719084c75f6448a1d6fbadbb360209","unresolved":false,"context_lines":[{"line_number":73,"context_line":"{{ macros.install_packages(ovs_dpdk_packages | customizable(\"packages\")) }}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"ADD plugins-archive /"},{"line_number":76,"context_line":"RUN ln -s /plugins/openvswitch-base-plugin-ovs-archive-*/ /ovs \u0026\u0026 ln -s /plugins/openvswitch-base-plugin-dpdk-archive-*/ /dpdk"},{"line_number":77,"context_line":"WORKDIR /dpdk"},{"line_number":78,"context_line":"{% set RTE_TARGET\u003d\u0027x86_64-native-linuxapp-gcc\u0027 %}"},{"line_number":79,"context_line":"RUN make config T\u003d\"{{ RTE_TARGET }}\""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5f201791_9b40f809","line":76,"range":{"start_line":76,"start_character":63,"end_line":76,"end_character":126},"updated":"2017-06-21 09:07:46.000000000","message":"syntax style, please split this command into other line","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"03a4bd4af5719084c75f6448a1d6fbadbb360209","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                           \"s/CONFIG_RTE_BUILD_SHARED_LIB\u003d.*$/CONFIG_RTE_BUILD_SHARED_LIB\u003dn/\"])"},{"line_number":90,"context_line":"}}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"RUN make -j $(nproc) EXTRA_CFLAGS\u003d\u0027-fPIC\u0027 \u0026\u0026 \\"},{"line_number":93,"context_line":"    make install"},{"line_number":94,"context_line":"WORKDIR /ovs"},{"line_number":95,"context_line":"RUN ./boot.sh \u0026\u0026 \\"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5f201791_9b591800","line":92,"range":{"start_line":92,"start_character":42,"end_line":92,"end_character":46},"updated":"2017-06-21 09:07:46.000000000","message":"just for common syntax with other dockerfiles, split line \\ and add \u0026\u0026 in the next line\n\nRUN command1 \\\n    \u0026\u0026 command2\n\nSame comment for other RUNs with multiple commands","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"03a4bd4af5719084c75f6448a1d6fbadbb360209","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"{% block openvswitch_vswitchd_footer %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"RUN echo \"chmod 777 /var/run/openvswitch\" \u003e /usr/local/bin/kolla_openvswitch_extend_start"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"5f201791_1b02a8b5","line":106,"range":{"start_line":106,"start_character":42,"end_line":106,"end_character":43},"updated":"2017-06-21 09:07:46.000000000","message":"this will replace all content in https://github.com/openstack/kolla/blob/master/docker/openvswitch/openvswitch-vswitchd/extend_start.sh.\n\nIs the expected behavior or append that line in the file?","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":26203,"name":"Maciej Skrocki","email":"maciej.skrocki@intel.com","username":"mskrocki"},"change_message_id":"62f30b9f422ad95a4c7abe81d6c6e627d5b8f4b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"3f1d235d_74f592ec","updated":"2017-07-05 18:31:03.000000000","message":"Do we still need this override when using separate ovsdpdk images? Can we just put this there?","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4f729baa63509e831ed8e53890e2f1db81c52778","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"3f1d235d_fa1e28b9","in_reply_to":"3f1d235d_74f592ec","updated":"2017-07-05 21:40:25.000000000","message":"well the main images are not allowed to build non openstack python project from souce by default.\n\nthat is why compilation of ovs and dpdk from source is a template override and not part of the docker file.","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"169c741b00592e2c4108bef647fdf38e9e2adb9b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \u0027libpcap-devel\u0027,"},{"line_number":20,"context_line":"        \u0027python-devel\u0027,"},{"line_number":21,"context_line":"        \u0027python-six\u0027,"},{"line_number":22,"context_line":"        \u0027crudini\u0027"},{"line_number":23,"context_line":"     ] %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% elif base_distro in [ \u0027debian\u0027, \u0027ubuntu\u0027 ] %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3f1d235d_acf89e7a","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":17},"updated":"2017-07-05 08:35:46.000000000","message":"is crudini used anywhere?","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"40ab6e3ef4fde2e1c0ac02fda5f39ededfd910fb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \u0027libpcap-devel\u0027,"},{"line_number":20,"context_line":"        \u0027python-devel\u0027,"},{"line_number":21,"context_line":"        \u0027python-six\u0027,"},{"line_number":22,"context_line":"        \u0027crudini\u0027"},{"line_number":23,"context_line":"     ] %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% elif base_distro in [ \u0027debian\u0027, \u0027ubuntu\u0027 ] %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3f1d235d_9c8bc91d","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":17},"in_reply_to":"3f1d235d_acf89e7a","updated":"2017-07-05 11:13:58.000000000","message":"its used on the hosts in ovs-dpdkctl.sh but not in any of the containers.\n\nwhen ovs-dpdkctl.sh init is called it will be need in the ovsdpdk-db container to read the conf file and do the port and bridge configuration.","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"169c741b00592e2c4108bef647fdf38e9e2adb9b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \u0026\u0026 make install"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"{% endblock %}"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3f1d235d_2c0c8eeb","line":76,"updated":"2017-07-05 08:35:46.000000000","message":"just nit, if need other change please remove this empty line","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"}],"doc/template-override/ovs-dpdk-source.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Building ovs with dpdk containers from source"},{"line_number":8,"context_line":"---------------------------------------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- append the following to /etc/kolla/kolla-build.conf to select the version"},{"line_number":11,"context_line":"  of ovs and dpdk to use for your source build."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"kolla-build.conf"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_6afc54b8","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":3},"updated":"2017-01-07 22:55:39.000000000","message":"Upper case","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- To build the container execute the follow command: \u0027tools/build.py --template-override contrib/template-override/ovs-dpdk-source.j2 dpdk\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"prep servers for ovs-dpdk container"},{"line_number":29,"context_line":"-----------------------------------"},{"line_number":30,"context_line":"(this section will be automated at a later date)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_cafd40b2","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":4},"updated":"2017-01-07 22:55:39.000000000","message":"Use full name","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"-----------------------------------"},{"line_number":30,"context_line":"(this section will be automated at a later date)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"before deploying the ovs-dpdk container the follow steps must be performed on the host."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- Hugepages should be allocated for use by dpdk and guest instances."},{"line_number":35,"context_line":"  This can be done at runtime via sysfs or at kernel boot time via the kernel command line."}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_ea2e8441","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":1},"updated":"2017-01-07 22:55:39.000000000","message":"Uppercase","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  to /etc/default/grub and regenerating the grub config via  \u0027sudo grub-mkconfig  -o /boot/grub/grub.cfg\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- Load kernel dpdk compatible kernel modules this can be done via adding the module to /etc/modules"},{"line_number":42,"context_line":"   e.g."},{"line_number":43,"context_line":"   ubuntu@kolla-ovsdpdk:~/kolla$ cat /etc/modules"},{"line_number":44,"context_line":"   # /etc/modules: kernel modules to load at boot time."},{"line_number":45,"context_line":"   #"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_6a237456","line":42,"range":{"start_line":42,"start_character":3,"end_line":42,"end_character":7},"updated":"2017-01-07 22:55:39.000000000","message":"Do not use eg.\nhttp://docs.openstack.org/contributor-guide/writing-style/word-choice.html","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  To use this tool you must first generate the config file."},{"line_number":56,"context_line":"  This can be done by executing ovs-dpdkctl.sh gen_config and setting the"},{"line_number":57,"context_line":"  bridge_mappings and port_mappings vairable on the commanline."},{"line_number":58,"context_line":"  e.g. sudo bridge_mappings\u003dphysnet1:br-ex port_mappings\u003dens5:br-ex tools/ovs-dpdkctl.sh gen_config \u0026\u0026 tools/ovs-dpdkctl.sh show_config"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  In this example it is assuming your neutron_external_interface is \"ens5\"."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_8a1ed809","line":58,"range":{"start_line":58,"start_character":1,"end_line":58,"end_character":6},"updated":"2017-01-07 22:55:39.000000000","message":"ditto","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  To bind the NICs to the drivers specified in the config execute the following command:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"      sudo tools/ovs-dpdkctl.sh bind_nics"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  To re-bind NICs to their original driver execute:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_ead5a41b","line":90,"range":{"start_line":90,"start_character":6,"end_line":90,"end_character":10},"updated":"2017-01-07 22:55:39.000000000","message":"Do not use sudo in docs","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1c59da1a54cd31bac57219142248d9554cfba130","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OVS-DPDK Source build"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CentOS, Fedora and Oracle Linux currently do not provide packages for ovs with dpdk. The Ubuntu packages do not support UIO based drivers."},{"line_number":5,"context_line":"To user the uio_pci_generic driver on Ubuntu a source build is required."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_d9013c08","line":3,"updated":"2017-01-10 17:12:53.000000000","message":"Why a doc is in jinja2 format instead of rst?\n\nCould you split lines at maximum of 79 characters?\nref: http://docs.openstack.org/contributor-guide/rst-conv/general-guidelines.html#lines-length","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af7be303ad13ac1be1cb9dad8f969c23ee272347","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OVS-DPDK Source build"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CentOS, Fedora and Oracle Linux currently do not provide packages for ovs with dpdk. The Ubuntu packages do not support UIO based drivers."},{"line_number":5,"context_line":"To user the uio_pci_generic driver on Ubuntu a source build is required."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_43aab6d3","line":3,"in_reply_to":"ba5201f7_d9013c08","updated":"2017-01-10 18:25:59.000000000","message":"that was a typo\nill wrap the lines as required.","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1c59da1a54cd31bac57219142248d9554cfba130","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OVS-DPDK Source build"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CentOS, Fedora and Oracle Linux currently do not provide packages for ovs with dpdk. The Ubuntu packages do not support UIO based drivers."},{"line_number":5,"context_line":"To user the uio_pci_generic driver on Ubuntu a source build is required."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Building ovs with dpdk containers from source"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_3920889b","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":14},"updated":"2017-01-10 17:12:53.000000000","message":"Fedora is deprecated, not need to be mentioned.","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af7be303ad13ac1be1cb9dad8f969c23ee272347","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OVS-DPDK Source build"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CentOS, Fedora and Oracle Linux currently do not provide packages for ovs with dpdk. The Ubuntu packages do not support UIO based drivers."},{"line_number":5,"context_line":"To user the uio_pci_generic driver on Ubuntu a source build is required."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Building ovs with dpdk containers from source"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_838bbe67","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":14},"in_reply_to":"ba5201f7_3920889b","updated":"2017-01-10 18:25:59.000000000","message":"yes i started this before fedora was deprecated.","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"}],"doc/template-override/ovs-dpdk-source.rst":[{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"e9460367e84791fe02de6c3e77991513cecf8386","unresolved":false,"context_lines":[{"line_number":15,"context_line":"kolla-build.conf"},{"line_number":16,"context_line":"________________"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[ovsdpdk-plugin-ovs]"},{"line_number":19,"context_line":"type \u003d git"},{"line_number":20,"context_line":"location \u003d https://github.com/openvswitch/ovs.git"},{"line_number":21,"context_line":"reference \u003d v2.6.0"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a461143_c302116f","line":18,"updated":"2017-01-27 13:19:34.000000000","message":"better approach would be to use ovs as a source package and only dpdk as a plugin:\n\n[ovsdpdk]\ntype\u003dgit\nlocation\u003dhttps://github.com/openvswitch/ovs.git\nreference\u003dv2.6.0","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a1ec96735ecd5f2a90660dcf7c010f4d4e811267","unresolved":false,"context_lines":[{"line_number":15,"context_line":"kolla-build.conf"},{"line_number":16,"context_line":"________________"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[ovsdpdk-plugin-ovs]"},{"line_number":19,"context_line":"type \u003d git"},{"line_number":20,"context_line":"location \u003d https://github.com/openvswitch/ovs.git"},{"line_number":21,"context_line":"reference \u003d v2.6.0"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a430d35_23ab1e76","line":18,"in_reply_to":"3a461143_c302116f","updated":"2017-02-03 18:52:06.000000000","message":"that is ment to be done for separate container not for adding multiple source repos to a single base container.\n\ni dont see how i could also add dpdk this way.","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"e9460367e84791fe02de6c3e77991513cecf8386","unresolved":false,"context_lines":[{"line_number":118,"context_line":"---------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"To deploy ovs-dpdk instead of ovs simpley add"},{"line_number":121,"context_line":"\u0027ovs_datapath: \"netdev\"\u0027 to /etc/kollaglobal.yml"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a461143_23acb533","line":121,"updated":"2017-01-27 13:19:34.000000000","message":"I already commented this earlier, but no reply so far: ovs_datapath-\u003enetdev setting should not automatically imply dpdk usage from my point of view (netdev can be used of other purposes than dpdk as well)","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a1ec96735ecd5f2a90660dcf7c010f4d4e811267","unresolved":false,"context_lines":[{"line_number":118,"context_line":"---------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"To deploy ovs-dpdk instead of ovs simpley add"},{"line_number":121,"context_line":"\u0027ovs_datapath: \"netdev\"\u0027 to /etc/kollaglobal.yml"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1a430d35_2375def8","line":121,"in_reply_to":"3a461143_23acb533","updated":"2017-02-03 18:52:06.000000000","message":"actually it cant.\nos-vif has an outstanding bug that means you cannot use the bsd netdev implementation or any other non dpdk implementation with the netdev datapath.\n\nhttps://bugs.launchpad.net/os-vif/+bug/1632372\n\nthat said its on my todo list to fix that bug in pike so i will use a different parameter here to enable dpdk explicitly. thanks for your feedback.","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"}],"doc/template-override/ovs-dpdk.rst":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"03a4bd4af5719084c75f6448a1d6fbadbb360209","unresolved":false,"context_lines":[{"line_number":26,"context_line":"reference \u003d v16.07"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- To build the container execute the follow command:"},{"line_number":29,"context_line":"    tools/build.py --template-override \\"},{"line_number":30,"context_line":"    contrib/template-override/ovs-dpdk.j2 dpdk"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Prepare servers for ovs-dpdk container"},{"line_number":33,"context_line":"-----------------------------------"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5f201791_dbd2f034","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":46},"updated":"2017-06-21 09:07:46.000000000","message":"use rst syntax for commands","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"eaee36201ef319fd4d9e4bf806a427d757c963a5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    tools/build.py --template-override \\"},{"line_number":30,"context_line":"    contrib/template-override/ovs-dpdk.j2 dpdk"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Prepare servers for ovs-dpdk container"},{"line_number":33,"context_line":"-----------------------------------"},{"line_number":34,"context_line":"(this section will be automated at a later date)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Before deploying the ovs-dpdk container,"}],"source_content_type":"text/x-rst","patch_set":17,"id":"ff0f0b1f_95b6053e","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":35},"updated":"2017-05-23 01:42:33.000000000","message":"nit\ncomplete the dashes under the topic.","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"eaee36201ef319fd4d9e4bf806a427d757c963a5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"(this section will be automated at a later date)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Before deploying the ovs-dpdk container,"},{"line_number":37,"context_line":"the follow steps must be performed on the host."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- Hugepages should be allocated for use by dpdk and guest instances."},{"line_number":40,"context_line":"  This can be done at runtime via sysfs or at kernel boot time"}],"source_content_type":"text/x-rst","patch_set":17,"id":"ff0f0b1f_758c917e","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":11},"updated":"2017-05-23 01:42:33.000000000","message":"s/follow/following","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"03a4bd4af5719084c75f6448a1d6fbadbb360209","unresolved":false,"context_lines":[{"line_number":49,"context_line":"- Load kernel dpdk compatible kernel modules,"},{"line_number":50,"context_line":"  this can be done via adding the module to /etc/modules"},{"line_number":51,"context_line":"  for example:"},{"line_number":52,"context_line":"    ubuntu@kolla-ovsdpdk:~/kolla$ cat /etc/modules"},{"line_number":53,"context_line":"    # /etc/modules: kernel modules to load at boot time."},{"line_number":54,"context_line":"    #"},{"line_number":55,"context_line":"    # This file contains the names of kernel modules that should be loaded"},{"line_number":56,"context_line":"    # at boot time, one per line. Lines beginning with \"#\" are ignored."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    uio_pci_generic"},{"line_number":59,"context_line":"    vfio_pci"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- Before deploying ovs-dpdk containers you need to bind the"},{"line_number":62,"context_line":"  physical nic to the kernel driver."}],"source_content_type":"text/x-rst","patch_set":17,"id":"5f201791_7be19cfe","line":59,"range":{"start_line":52,"start_character":0,"end_line":59,"end_character":12},"updated":"2017-06-21 09:07:46.000000000","message":"same for command rst syntax","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"03a4bd4af5719084c75f6448a1d6fbadbb360209","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  To use this tool you must first generate the config file."},{"line_number":66,"context_line":"  This can be done by executing ovs-dpdkctl.sh gen_config and setting the"},{"line_number":67,"context_line":"  bridge_mappings and port_mappings variable on the command line."},{"line_number":68,"context_line":"  For example:"},{"line_number":69,"context_line":"    bridge_mappings\u003dphysnet1:br-ex port_mappings\u003dens5:br-ex \\"},{"line_number":70,"context_line":"    tools/ovs-dpdkctl.sh gen_config  \u0026\u0026 \\"},{"line_number":71,"context_line":"    tools/ovs-dpdkctl.sh show_config"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  In this example it is assuming your neutron_external_interface is \"ens5\"."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"5f201791_fbec8cf4","line":71,"range":{"start_line":68,"start_character":0,"end_line":71,"end_character":36},"updated":"2017-06-21 09:07:46.000000000","message":"ditto","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"03a4bd4af5719084c75f6448a1d6fbadbb360209","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  This will result in the creation of a config similar to this."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  [ovs]"},{"line_number":78,"context_line":"  bridge_mappings \u003d physnet1:br-ex"},{"line_number":79,"context_line":"  port_mappings \u003d ens5:br-ex"},{"line_number":80,"context_line":"  cidr_mappings \u003d"},{"line_number":81,"context_line":"  pmd_coremask \u003d 0x2"},{"line_number":82,"context_line":"  ovs_mem_channels \u003d 4"},{"line_number":83,"context_line":"  ovs_socket_mem \u003d 512"},{"line_number":84,"context_line":"  dpdk_interface_driver \u003d uio_pci_generic"},{"line_number":85,"context_line":"  hugepage_mountpoint \u003d /dev/hugepages"},{"line_number":86,"context_line":"  pci_whitelist \u003d \u0027-w 0000:00:05.0\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  [ens3]"},{"line_number":89,"context_line":"  address \u003d 0000:00:03.0"},{"line_number":90,"context_line":"  driver \u003de1000"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  [ens4]"},{"line_number":93,"context_line":"  address \u003d 0000:00:04.0"},{"line_number":94,"context_line":"  driver \u003de1000"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  [ens5]"},{"line_number":98,"context_line":"  address \u003d 0000:00:05.0"},{"line_number":99,"context_line":"  driver \u003d uio_pci_generic"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  To bind the NICs to the drivers specified in the config"},{"line_number":102,"context_line":"  execute the following command:"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5f201791_7bbabcde","line":99,"range":{"start_line":77,"start_character":0,"end_line":99,"end_character":26},"updated":"2017-06-21 09:07:46.000000000","message":"same and in the 3 next commands too","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"eaee36201ef319fd4d9e4bf806a427d757c963a5","unresolved":false,"context_lines":[{"line_number":117,"context_line":"Deploy ovs-dpdk"},{"line_number":118,"context_line":"---------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"To deploy ovs-dpdk instead of ovs simpley add"},{"line_number":121,"context_line":"\u0027ovs_datapath: \"netdev\"\u0027 to /etc/kollaglobal.yml"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"ff0f0b1f_d5cd9d66","line":120,"range":{"start_line":120,"start_character":34,"end_line":120,"end_character":41},"updated":"2017-05-23 01:42:33.000000000","message":"s/simpley/simply","commit_id":"7f175e3bced41cadd551eb30ece380b6f4ed8f15"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"169c741b00592e2c4108bef647fdf38e9e2adb9b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CentOS and Oracle Linux currently do not provide packages"},{"line_number":5,"context_line":"for ovs with dpdk."},{"line_number":6,"context_line":"The Ubuntu packages do not support UIO based drivers."},{"line_number":7,"context_line":"To use the uio_pci_generic driver on Ubuntu a source build is required."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"3f1d235d_cc407aa8","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":17},"updated":"2017-07-05 08:35:46.000000000","message":"dpdk is present in extras repo:\n\n[root@kolla tmp]# yum provides dpdk\nLoaded plugins: fastestmirror, langpacks\nLoading mirror speeds from cached hostfile\n * base: centos.mirrors.ovh.net\n * epel: fr.mirror.babylon.network\n * extras: fr.mirror.babylon.network\n * updates: mirror.neify.es\ndpdk-2.2.0-3.el7.x86_64 : Set of libraries and drivers for fast packet processing\nRepo        : extras","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"40ab6e3ef4fde2e1c0ac02fda5f39ededfd910fb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CentOS and Oracle Linux currently do not provide packages"},{"line_number":5,"context_line":"for ovs with dpdk."},{"line_number":6,"context_line":"The Ubuntu packages do not support UIO based drivers."},{"line_number":7,"context_line":"To use the uio_pci_generic driver on Ubuntu a source build is required."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"3f1d235d_dc5141db","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":17},"in_reply_to":"3f1d235d_cc407aa8","updated":"2017-07-05 11:13:58.000000000","message":"yes but has ovs been compiled to dynamically link to it.\n\nas far as i no on centos it has not been.\njust have dpdk installed is not enough unfortunately.","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":26203,"name":"Maciej Skrocki","email":"maciej.skrocki@intel.com","username":"mskrocki"},"change_message_id":"62f30b9f422ad95a4c7abe81d6c6e627d5b8f4b0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"kolla-build.conf"},{"line_number":16,"context_line":"________________"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[openvswitch-base-plugin-ovs]"},{"line_number":19,"context_line":"type \u003d git"},{"line_number":20,"context_line":"location \u003d https://github.com/openvswitch/ovs.git"},{"line_number":21,"context_line":"reference \u003d v2.7.0"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3f1d235d_543df6c1","line":18,"range":{"start_line":18,"start_character":1,"end_line":18,"end_character":28},"updated":"2017-07-05 18:31:03.000000000","message":"is this still correct with the new ovsdpdk image names?","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4f729baa63509e831ed8e53890e2f1db81c52778","unresolved":false,"context_lines":[{"line_number":15,"context_line":"kolla-build.conf"},{"line_number":16,"context_line":"________________"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[openvswitch-base-plugin-ovs]"},{"line_number":19,"context_line":"type \u003d git"},{"line_number":20,"context_line":"location \u003d https://github.com/openvswitch/ovs.git"},{"line_number":21,"context_line":"reference \u003d v2.7.0"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3f1d235d_fa4ce8c8","line":18,"range":{"start_line":18,"start_character":1,"end_line":18,"end_character":28},"in_reply_to":"3f1d235d_543df6c1","updated":"2017-07-05 21:40:25.000000000","message":"you are correct this shoudl be ovsdpdk-base-plugin-ovs\ni was going to submit another patch automatically generate this section as part of generating the kolla-build.conf later this week so ill fix it in that patch.","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"}],"docker/macros.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"169c741b00592e2c4108bef647fdf38e9e2adb9b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"{%- endmacro %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% macro install_pip(packages, constraints \u003d true) %}"},{"line_number":27,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3f1d235d_8cc72265","line":24,"updated":"2017-07-05 08:35:46.000000000","message":"too many lines, with 2 is enough, change if need any other update in the PS","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ef6926e5551ead9555e2914d0fb099c3684d6ea4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"{%- endmacro %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% macro install_pip(packages, constraints \u003d true) %}"},{"line_number":27,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3f1d235d_176b12b7","line":24,"in_reply_to":"3f1d235d_1cfb3979","updated":"2017-07-05 11:25:36.000000000","message":"cool yes ill reduce to 1 i tend to add extra space when im working on stuff to seperate what im changing i just didnt remove it here.","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"40ab6e3ef4fde2e1c0ac02fda5f39ededfd910fb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"{%- endmacro %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% macro install_pip(packages, constraints \u003d true) %}"},{"line_number":27,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3f1d235d_dcedc1f0","line":24,"in_reply_to":"3f1d235d_8cc72265","updated":"2017-07-05 11:13:58.000000000","message":"the spacing between the macros?\nsorry dont fully understand the comment but are you saying\nthat i should only have 2 new lines?\nafter the macro","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"edf79fcebad054bf87f15695dd3f1aacc8f7d299","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"{%- endmacro %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% macro install_pip(packages, constraints \u003d true) %}"},{"line_number":27,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3f1d235d_1cfb3979","line":24,"in_reply_to":"3f1d235d_dcedc1f0","updated":"2017-07-05 11:16:24.000000000","message":"yes or even one, other macros only have one, sorry for bad explanation","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5d877eb97079e858740c2b0c5f43b9f3ed08cb20","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    true"},{"line_number":24,"context_line":"{%- endif -%}"},{"line_number":25,"context_line":"{% endmacro %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% macro configure_user(name, groups\u003dNone, shell\u003dNone, homedir\u003dNone) %}"},{"line_number":29,"context_line":"{% set user\u003dusers[name] %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"3f1d235d_97de020f","side":"PARENT","line":26,"updated":"2017-07-05 11:37:55.000000000","message":"i know this is technically unrelated but now all of the macros have only 1 line between them.","commit_id":"c2c457c28201f551d9bc401f562c17ba2ac6eb36"}],"docker/openvswitch/openvswitch-db-server/ovs_ensure_configured.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82ad4e0d51b2b1c25b54e3a1c21e51dca360eaa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba5da102_7fe4d10c","updated":"2016-10-26 23:18:46.000000000","message":"im going to split out these changes into a different file to make handeling multpile bridges simpler","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"}],"docker/openvswitch/openvswitch-vswitchd-dpdk/Dockerfile.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82ad4e0d51b2b1c25b54e3a1c21e51dca360eaa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba5da102_9f76053d","updated":"2016-10-26 23:18:46.000000000","message":"need to add template override sections","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a181f7b9514bed09410f925c9f6d06e58a14bfc5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum -y install \\"},{"line_number":7,"context_line":"        openvswitch-dpdk \\"},{"line_number":8,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba5da102_dfb5ddd0","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":24},"updated":"2016-10-26 23:21:03.000000000","message":"need to double check package name.","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c2d890760368e72411e7cc2e9fa31e47bb5c41a7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum -y install \\"},{"line_number":7,"context_line":"        openvswitch-dpdk \\"},{"line_number":8,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba5da102_6a024e71","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":24},"in_reply_to":"ba5da102_c55c807f","updated":"2016-11-04 18:11:00.000000000","message":"i originally taught since they were part of osp they would be part of rdo. i realsed after the fact that this is not hte case. this will provide support for ubuntu only in tree \nand i will support and maintain a template override file in networking-ovs-dpdk.","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"65751a59626eecfe392c3abdd7cf209a0268add8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum -y install \\"},{"line_number":7,"context_line":"        openvswitch-dpdk \\"},{"line_number":8,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba5da102_c55c807f","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":24},"in_reply_to":"ba5da102_dfb5ddd0","updated":"2016-11-02 22:54:57.000000000","message":"what is intended repository of dpdk-enabled ovs package for centos? It does not seem to be in centos nor delorean.","commit_id":"a51c0a76f32c13762ef3a680b9a8a5ba5f3a18cd"}],"docker/ovsdpdk/ovsdpdk-db/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"50052e262e88268687945b22129975cb50612921","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% block ovsdpdk_db_footer %}{% endblock %}"},{"line_number":14,"context_line":"{% block footer %}{% endblock %}"},{"line_number":15,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3a71b18c_aa0c1495","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"updated":"2016-12-09 11:03:23.000000000","message":"We have deprecated this footers and we are not longer including in new images.","commit_id":"d91ef218bc5084e5dacf23604892c2bd9faa2aa7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"933f89e370b1149895a8cf1ecc9f1f5f25042f9d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% block ovsdpdk_db_footer %}{% endblock %}"},{"line_number":14,"context_line":"{% block footer %}{% endblock %}"},{"line_number":15,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1a6eadb0_a492d955","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"in_reply_to":"3a71b18c_aa0c1495","updated":"2016-12-13 02:59:15.000000000","message":"ok cool do i just ommit it now.\n\nthis was for the old include header and foother when building right? its not used via template override.","commit_id":"d91ef218bc5084e5dacf23604892c2bd9faa2aa7"}],"docker/ovsdpdk/ovsdpdk-db/ovs_ensure_configured.sh":[{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"26b8b604bb5e460acf9c8c318c8d05a2162c98f1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    changed\u003dchanged"},{"line_number":16,"context_line":"    cmd\u003d\"ovs-vsctl --no-wait add-port $bridge $port\""},{"line_number":17,"context_line":"    #NOTE(sean-k-mooney): the dpdk port name must be dpdk0"},{"line_number":18,"context_line":"    [[ \"$ovs_datapath\" \u003d\u003d \"netdev\" ]] \u0026\u0026 cmd\u003d\"ovs-vsctl --no-wait add-port $bridge dpdk0 -- set interface dpdk0 type\u003ddpdk\""},{"line_number":19,"context_line":"    $cmd"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_76eacead","line":18,"updated":"2016-11-09 17:16:44.000000000","message":"By that condition (and others checking ovs_datapath across this patchset), kolla would introduce implication:\novs_datapath is netdev -\u003e use dpdk.\nThis steals other usecases of netdev for ovs, which can be _different_ than dpdk. More universal is to introduce a new variable like \u0027ovs_use_dpdk\u0027 or something like that, based on what dpdk-specific actions (and also \"ovs_datapath\u003dnetdev\" in ml2_conf.ini.j2) would be set.","commit_id":"f9c45bc13938a111fe905b423f1da83f6df8d7f1"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"26b8b604bb5e460acf9c8c318c8d05a2162c98f1","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"if [[ \"$ovs_datapath\" \u003d\u003d \"netdev\" ]]; then"},{"line_number":23,"context_line":"   ovs-vsctl --no-wait set Open_vSwitch . other_config:pmd-cpu-mask\u003d0x6 other_config:dpdk-init\u003dTrue other_config:dpdk-lcore-mask\u003d0x2 \\"},{"line_number":24,"context_line":"   other_config:dpdk-mem-channels\u003d4 other_config:dpdk-socket-mem\u003d512 other_config:dpdk-hugepage-dir\u003d/dev/hugepages"},{"line_number":25,"context_line":"fi"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"echo $changed"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_964122ac","line":24,"updated":"2016-11-09 17:16:44.000000000","message":"Is there a way how to customize these dpdk parameters for deployment? They are dependent on target host machines and particular use case.","commit_id":"f9c45bc13938a111fe905b423f1da83f6df8d7f1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e053f677423f17c32d64afc29d6e543ad2ecd7d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ba5201f7_07be73fe","updated":"2017-01-06 19:00:35.000000000","message":"this need to be refactored to support multiple bridge mapping but i think its better to handel this in ansible outside the container rather then bake it in so i will remove this in next versions.","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"}],"docker/ovsdpdk/ovsdpdk-db/start_ovsdb_server.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e053f677423f17c32d64afc29d6e543ad2ecd7d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ba5201f7_473a3b9a","updated":"2017-01-06 19:00:35.000000000","message":"i will refactor this out it would be better to bind mount a file externally for each installer as done in kolla-salt.","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"}],"docker/ovsdpdk/ovsdpdk-vswitchd/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"50052e262e88268687945b22129975cb50612921","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}ovsdpdk:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":"{% block ovsdpdk_vswitchd_header %}{% endblock %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_ovsdpdk_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3a71b18c_2a4f24be","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":47},"updated":"2016-12-09 11:03:23.000000000","message":"Not needed if not installing anything","commit_id":"d91ef218bc5084e5dacf23604892c2bd9faa2aa7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"933f89e370b1149895a8cf1ecc9f1f5f25042f9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}ovsdpdk:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":"{% block ovsdpdk_vswitchd_header %}{% endblock %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_ovsdpdk_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1a6eadb0_a479f931","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":47},"in_reply_to":"3a71b18c_2a4f24be","updated":"2016-12-13 02:59:15.000000000","message":"thanks ill remove","commit_id":"d91ef218bc5084e5dacf23604892c2bd9faa2aa7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block ovsdpdk_vswitchd_footer %}{% endblock %}"},{"line_number":10,"context_line":"{% block footer %}{% endblock %}"},{"line_number":11,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_2adc0c45","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":20},"updated":"2017-01-07 22:55:39.000000000","message":"Deprecated footers","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77c5adb27592687d41bfd5258aa27d18dcb13382","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block ovsdpdk_vswitchd_footer %}{% endblock %}"},{"line_number":10,"context_line":"{% block footer %}{% endblock %}"},{"line_number":11,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_65dc6275","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":20},"in_reply_to":"ba5201f7_2adc0c45","updated":"2017-01-09 15:46:29.000000000","message":"yes i taught i delete this but i guess not.\nill remove in next version thanks.","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"}],"docker/ovsdpdk/ovsdpdk/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"f0ef7316131900aa6d8a903db818881a8207c9e3","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% block ovsdpdk_footer %}{% endblock %}"},{"line_number":34,"context_line":"{% block footer %}{% endblock %}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba5201f7_4adf9039","line":35,"updated":"2017-01-07 22:55:39.000000000","message":"Please, remove empty line","commit_id":"2ae33e3cce2b355198a072da129d4440d62f0e1f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1c59da1a54cd31bac57219142248d9554cfba130","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% block ovsdpdk_install %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":12,"context_line":"\u0026\u0026 /bin/false"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_7420554a","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":40},"updated":"2017-01-10 17:12:53.000000000","message":"fedora ;)","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af7be303ad13ac1be1cb9dad8f969c23ee272347","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% block ovsdpdk_install %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":12,"context_line":"\u0026\u0026 /bin/false"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba5201f7_23ddb270","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":40},"in_reply_to":"ba5201f7_7420554a","updated":"2017-01-10 18:25:59.000000000","message":"yep ill drop it thanks","commit_id":"613b7a1bcbaa1b0a95d839ed9c8477a7523fa998"},{"author":{"_account_id":21061,"name":"Martin Matyas","email":"m.matyas2@partner.samsung.com","username":"martin.matyas"},"change_message_id":"e9460367e84791fe02de6c3e77991513cecf8386","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3a461143_8309e9df","updated":"2017-01-27 13:19:34.000000000","message":"\"ovsdpdk-base\" image name should be rather used to keep kolla convention for parent service images","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a1ec96735ecd5f2a90660dcf7c010f4d4e811267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1a430d35_23a87e1f","in_reply_to":"3a461143_8309e9df","updated":"2017-02-03 18:52:06.000000000","message":"you mean this file should be ovsdpdk-base.\n\ni had some issues with that if i recall corectly as i think you cannot use plugins with base images.\ni can take a look again. but this file should inherit for base.","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a1ec96735ecd5f2a90660dcf7c010f4d4e811267","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":12,"context_line":"\u0026\u0026 /bin/false"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1a430d35_9e81854d","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":13},"updated":"2017-02-03 18:52:06.000000000","message":"i may be able to enable this via \nhttps://copr.fedorainfracloud.org/coprs/pmatilai/dpdk-snapshot/packages/\nbased on \nhttps://github.com/openstack/networking-ovn/blob/a60b70369eb4bd7984a760a46d146e280cab2fe4/doc/source/install.rst#packaging\nin a follow up commit but initially i will leave it as out of scope.","commit_id":"eb56ddb1a0052f39855d144c9a38ab1b2f70c9ef"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"169c741b00592e2c4108bef647fdf38e9e2adb9b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#TODO(sean-k-mooney) create repo via open suse build system to package"},{"line_number":12,"context_line":"# for centos/oraclelinux/rhel distros."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN echo binay install on {{base_distro}} is not currently supported ; /bin/false"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3f1d235d_6745ff42","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":14},"updated":"2017-07-05 08:35:46.000000000","message":"typo, also please use common kolla message:\nhttps://github.com/openstack/kolla/blob/master/docker/freezer/freezer-api/Dockerfile.j2#L10","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"40ab6e3ef4fde2e1c0ac02fda5f39ededfd910fb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#TODO(sean-k-mooney) create repo via open suse build system to package"},{"line_number":12,"context_line":"# for centos/oraclelinux/rhel distros."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN echo binay install on {{base_distro}} is not currently supported ; /bin/false"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"3f1d235d_1cd1f923","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":14},"in_reply_to":"3f1d235d_6745ff42","updated":"2017-07-05 11:13:58.000000000","message":"ok sure ill update that.","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"}],"tests/test_build.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"169c741b00592e2c4108bef647fdf38e9e2adb9b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"vitrage-base\","},{"line_number":88,"context_line":"        \"vmtp\","},{"line_number":89,"context_line":"        \"zun-base\","},{"line_number":90,"context_line":"        \"ovsdpdk\","},{"line_number":91,"context_line":"    ]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_e7a7cf0a","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":18},"updated":"2017-07-05 08:35:46.000000000","message":"please, alphabetize","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"40ab6e3ef4fde2e1c0ac02fda5f39ededfd910fb","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"vitrage-base\","},{"line_number":88,"context_line":"        \"vmtp\","},{"line_number":89,"context_line":"        \"zun-base\","},{"line_number":90,"context_line":"        \"ovsdpdk\","},{"line_number":91,"context_line":"    ]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_1c96994d","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":18},"in_reply_to":"3f1d235d_e7a7cf0a","updated":"2017-07-05 11:13:58.000000000","message":"sure. last time i updated this list these were not in alphitcal order so i just appended to it but no problem.","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"169c741b00592e2c4108bef647fdf38e9e2adb9b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \"bifrost-base\","},{"line_number":102,"context_line":"        \"kafka\","},{"line_number":103,"context_line":"        \"mistral-base\","},{"line_number":104,"context_line":"        \"ovsdpdk\","},{"line_number":105,"context_line":"        \"opendaylight\""},{"line_number":106,"context_line":"    ]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_c7b05346","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":18},"updated":"2017-07-05 08:35:46.000000000","message":"ditto","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"169c741b00592e2c4108bef647fdf38e9e2adb9b","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        \"vitrage-base\","},{"line_number":216,"context_line":"        \"vmtp\","},{"line_number":217,"context_line":"        \"zun-base\","},{"line_number":218,"context_line":"        \"ovsdpdk\","},{"line_number":219,"context_line":"    ]"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_a7ad57ea","line":218,"range":{"start_line":218,"start_character":8,"end_line":218,"end_character":18},"updated":"2017-07-05 08:35:46.000000000","message":"ditto","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"169c741b00592e2c4108bef647fdf38e9e2adb9b","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    excluded_images \u003d ["},{"line_number":229,"context_line":"        \"bifrost-base\","},{"line_number":230,"context_line":"        \"kafka\","},{"line_number":231,"context_line":"        \"ovsdpdk\","},{"line_number":232,"context_line":"        \"opendaylight\""},{"line_number":233,"context_line":"    ]"},{"line_number":234,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3f1d235d_47868368","line":231,"range":{"start_line":231,"start_character":8,"end_line":231,"end_character":18},"updated":"2017-07-05 08:35:46.000000000","message":"ditto","commit_id":"2dc756f4d89fa47c77eb073a8749764f3ad5462a"}]}