)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"3a9f1ba778b094a88c262557e8d1cb315a269d40","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    \u0026\u0026 groupadd kolla \\"},{"line_number":267,"context_line":"    \u0026\u0026 rm -f /tmp/kolla_bashrc"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"fa7ab95a_6a8cbd35","line":269,"updated":"2016-08-29 04:53:52.000000000","message":"Add named footer block for base image","commit_id":"0b0cfdf7d3f05d398456b1cf25e20c8c2e991079"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"09bff10a87b66a0c199b046d80f86cf7d2cdc81c","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    \u0026\u0026 groupadd kolla \\"},{"line_number":267,"context_line":"    \u0026\u0026 rm -f /tmp/kolla_bashrc"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"fa7ab95a_61e85bb5","line":269,"in_reply_to":"fa7ab95a_6a8cbd35","updated":"2016-08-29 08:35:52.000000000","message":"I would prefer to not touch the base Dockerfile with this change. It is not related to it.","commit_id":"0b0cfdf7d3f05d398456b1cf25e20c8c2e991079"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"74812be0099c06dadea11d963573ad105b3fd953","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        \u0027python\u0027,"},{"line_number":173,"context_line":"        \u0027lvm2\u0027,"},{"line_number":174,"context_line":"        \u0027scsi-target-utils\u0027,"},{"line_number":175,"context_line":"        \u0027iproute\u0027,"},{"line_number":176,"context_line":"        \u0027iscsi-initiator-utils\u0027"},{"line_number":177,"context_line":"] %}"},{"line_number":178,"context_line":"# Install base packages"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"9a89bdaa_de09d085","side":"PARENT","line":175,"updated":"2016-09-07 14:52:37.000000000","message":"why remove the iproute?","commit_id":"5fca91c6fd45ff5807e1894598e6b97a00eef4bb"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"74812be0099c06dadea11d963573ad105b3fd953","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    \u0027which\u0027,"},{"line_number":190,"context_line":"    \u0027lvm2\u0027,"},{"line_number":191,"context_line":"    \u0027scsi-target-utils\u0027,"},{"line_number":192,"context_line":"    \u0027iproute\u0027,"},{"line_number":193,"context_line":"    \u0027iscsi-initiator-utils\u0027"},{"line_number":194,"context_line":"] %}"},{"line_number":195,"context_line":"# Update packages"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"9a89bdaa_fe0e948a","side":"PARENT","line":192,"updated":"2016-09-07 14:52:37.000000000","message":"ditto","commit_id":"5fca91c6fd45ff5807e1894598e6b97a00eef4bb"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c79412028020847fd6818a011cbe1b81390dc4b3","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    \u0027which\u0027,"},{"line_number":190,"context_line":"    \u0027lvm2\u0027,"},{"line_number":191,"context_line":"    \u0027scsi-target-utils\u0027,"},{"line_number":192,"context_line":"    \u0027iproute\u0027,"},{"line_number":193,"context_line":"    \u0027iscsi-initiator-utils\u0027"},{"line_number":194,"context_line":"] %}"},{"line_number":195,"context_line":"# Update packages"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"9a89bdaa_79f7fe58","side":"PARENT","line":192,"in_reply_to":"9a89bdaa_fe0e948a","updated":"2016-09-07 15:11:56.000000000","message":"Done","commit_id":"5fca91c6fd45ff5807e1894598e6b97a00eef4bb"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"74812be0099c06dadea11d963573ad105b3fd953","unresolved":false,"context_lines":[{"line_number":221,"context_line":"{% set base_apt_packages \u003d ["},{"line_number":222,"context_line":"   \u0027curl\u0027,"},{"line_number":223,"context_line":"   \u0027gawk\u0027,"},{"line_number":224,"context_line":"   \u0027iproute2\u0027,"},{"line_number":225,"context_line":"   \u0027kmod\u0027,"},{"line_number":226,"context_line":"   \u0027lvm2\u0027,"},{"line_number":227,"context_line":"   \u0027open-iscsi\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"9a89bdaa_1e2898e1","side":"PARENT","line":224,"updated":"2016-09-07 14:52:37.000000000","message":"ditto","commit_id":"5fca91c6fd45ff5807e1894598e6b97a00eef4bb"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c79412028020847fd6818a011cbe1b81390dc4b3","unresolved":false,"context_lines":[{"line_number":221,"context_line":"{% set base_apt_packages \u003d ["},{"line_number":222,"context_line":"   \u0027curl\u0027,"},{"line_number":223,"context_line":"   \u0027gawk\u0027,"},{"line_number":224,"context_line":"   \u0027iproute2\u0027,"},{"line_number":225,"context_line":"   \u0027kmod\u0027,"},{"line_number":226,"context_line":"   \u0027lvm2\u0027,"},{"line_number":227,"context_line":"   \u0027open-iscsi\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"9a89bdaa_19043248","side":"PARENT","line":224,"in_reply_to":"9a89bdaa_1e2898e1","updated":"2016-09-07 15:11:56.000000000","message":"Done","commit_id":"5fca91c6fd45ff5807e1894598e6b97a00eef4bb"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"74812be0099c06dadea11d963573ad105b3fd953","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-Percona \u0027,"},{"line_number":54,"context_line":"    \u0027https://packages.elastic.co/GPG-KEY-elasticsearch\u0027,"},{"line_number":55,"context_line":"    \u0027https://repos.influxdata.com/influxdb.key\u0027,"},{"line_number":56,"context_line":"    \u0027https://packagecloud.io/gpg.key https://grafanarel.s3.amazonaws.com/RPM-GPG-KEY-grafana\u0027"},{"line_number":57,"context_line":"] %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN true {% for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}\u0026\u0026 rpm --import {{ key }} {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"9a89bdaa_be188cd4","line":56,"updated":"2016-09-07 14:52:37.000000000","message":"i think this is wrong? why add two keys here?","commit_id":"18277873961f6242c565f80b6db11517debc70d2"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c79412028020847fd6818a011cbe1b81390dc4b3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-Percona \u0027,"},{"line_number":54,"context_line":"    \u0027https://packages.elastic.co/GPG-KEY-elasticsearch\u0027,"},{"line_number":55,"context_line":"    \u0027https://repos.influxdata.com/influxdb.key\u0027,"},{"line_number":56,"context_line":"    \u0027https://packagecloud.io/gpg.key https://grafanarel.s3.amazonaws.com/RPM-GPG-KEY-grafana\u0027"},{"line_number":57,"context_line":"] %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN true {% for key in base_yum_repo_keys | customizable(\u0027yum_repo_keys\u0027) %}\u0026\u0026 rpm --import {{ key }} {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"9a89bdaa_7d6a89b4","line":56,"in_reply_to":"9a89bdaa_be188cd4","updated":"2016-09-07 15:11:56.000000000","message":"the grafana website repo are two key, all I\u0027m here to fill two key, you can refer to the link\nhttp://docs.grafana.org/installation/rpm/","commit_id":"18277873961f6242c565f80b6db11517debc70d2"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a5af15e226e63e8f427c074a734fc1641436bd6a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    \u0027which\u0027,"},{"line_number":193,"context_line":"    \u0027lvm2\u0027,"},{"line_number":194,"context_line":"    \u0027iproute\u0027,"},{"line_number":195,"context_line":"    \u0027scsi-target-utils\u0027,"},{"line_number":196,"context_line":"    \u0027iscsi-initiator-utils\u0027"},{"line_number":197,"context_line":"] %}"},{"line_number":198,"context_line":"# Update packages"}],"source_content_type":"text/x-jinja2","patch_set":39,"id":"9a89bdaa_2585ad58","line":195,"range":{"start_line":195,"start_character":4,"end_line":195,"end_character":24},"updated":"2016-09-10 14:36:03.000000000","message":"Why changed the order? Is an unnecessary change","commit_id":"30dd49a49bdd259c67e590a17d0da2d0f43bd270"}],"docker/base/grafana.repo":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"74812be0099c06dadea11d963573ad105b3fd953","unresolved":false,"context_lines":[{"line_number":4,"context_line":"repo_gpgcheck\u003d1"},{"line_number":5,"context_line":"enabled\u003d1"},{"line_number":6,"context_line":"gpgcheck\u003d1"},{"line_number":7,"context_line":"gpgkey\u003dhttps://packagecloud.io/gpg.key https://grafanarel.s3.amazonaws.com/RPM-GPG-KEY-grafana"}],"source_content_type":"application/octet-stream","patch_set":33,"id":"9a89bdaa_3e255c08","line":7,"updated":"2016-09-07 14:52:37.000000000","message":"two key files. does this work?","commit_id":"18277873961f6242c565f80b6db11517debc70d2"}],"docker/base/sources.list.debian":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"fb52f3bcfa0fc206a45e39445b3a74ed10983707","unresolved":false,"context_lines":[{"line_number":29,"context_line":"deb https://repos.influxdata.com/debian jessie stable"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# Grafana repo"},{"line_number":32,"context_line":"deb https://packagecloud.io/grafana/stable/debian/ wheezy main"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"bacf61ea_9edd2945","line":32,"updated":"2016-07-28 06:19:14.000000000","message":"need use jessie version here\n\nsee http://askubuntu.com/questions/445487/which-ubuntu-version-is-equivalent-to-debian-squeeze","commit_id":"cd4ce6a9d5ae1525c20ea1d46e761c9196bf3d88"}],"docker/base/sources.list.ubuntu":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"00c7b8d26929aef94471cded1682d4ceef5d0dc8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"deb https://repos.influxdata.com/ubuntu trusty stable"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Grafana repo"},{"line_number":35,"context_line":"deb https://packagecloud.io/grafana/stable/debian/ wheezy main"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"dada55a8_f2a05544","line":35,"updated":"2016-07-26 17:23:13.000000000","message":"groan more mirrors","commit_id":"692e650b4b208e9983071617c579e5eb07bdb18d"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"f0d0cc59f9eb97c451757a7b432250cb4639b830","unresolved":false,"context_lines":[{"line_number":32,"context_line":"deb https://repos.influxdata.com/ubuntu trusty stable"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Grafana repo"},{"line_number":35,"context_line":"deb https://packagecloud.io/grafana/stable/debian/ wheezy main"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"dada55a8_3571200d","line":35,"in_reply_to":"dada55a8_f2a05544","updated":"2016-07-27 05:48:23.000000000","message":"I used DEB download before but someone complained about that, too. What\u0027s the official policy? The software has to come from somewhere ;)","commit_id":"692e650b4b208e9983071617c579e5eb07bdb18d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"fb52f3bcfa0fc206a45e39445b3a74ed10983707","unresolved":false,"context_lines":[{"line_number":32,"context_line":"deb https://repos.influxdata.com/ubuntu trusty stable"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Grafana repo"},{"line_number":35,"context_line":"deb https://packagecloud.io/grafana/stable/debian/ wheezy main"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"bacf61ea_7ee2f504","line":35,"updated":"2016-07-28 06:19:14.000000000","message":"ditto","commit_id":"cd4ce6a9d5ae1525c20ea1d46e761c9196bf3d88"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"05b49bbf7e85d05d09dea244230801a8fbb35c55","unresolved":false,"context_lines":[{"line_number":32,"context_line":"deb https://repos.influxdata.com/ubuntu trusty stable"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Grafana repo"},{"line_number":35,"context_line":"deb https://packagecloud.io/grafana/stable/debian/ jessie main"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"1ac06dbe_6d48922e","line":35,"range":{"start_line":35,"start_character":43,"end_line":35,"end_character":57},"updated":"2016-08-19 16:55:13.000000000","message":"Is this correct? I would expect ubuntu trusty here.","commit_id":"81c8eb1907586b3b1fad5954e663a762191030ba"}],"docker/grafana/Dockerfile.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"f8c74a6541491972585f13565a52ed302b0115d7","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN curl -L https://github.com/tianon/gosu/releases/download/1.7/gosu-amd64 \u003e /usr/sbin/gosu \\"},{"line_number":15,"context_line":"    \u0026\u0026 chmod +x /usr/sbin/gosu"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":18,"context_line":"COPY run.sh /run.sh"},{"line_number":19,"context_line":"COPY grafana_sudoers /etc/sudoers.d/kolla_grafana_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bacf61ea_f1575ac8","line":16,"updated":"2016-07-27 14:42:08.000000000","message":"Need to create the grafana user and /home/grafana","commit_id":"9c01022421ba46159ea512388304add3c25915da"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"66fc350192380a1515a15419e78ffb0e00993fa6","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN curl -L https://github.com/tianon/gosu/releases/download/1.7/gosu-amd64 \u003e /usr/sbin/gosu \\"},{"line_number":15,"context_line":"    \u0026\u0026 chmod +x /usr/sbin/gosu"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":18,"context_line":"COPY run.sh /run.sh"},{"line_number":19,"context_line":"COPY grafana_sudoers /etc/sudoers.d/kolla_grafana_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bacf61ea_fda0c1a7","line":16,"in_reply_to":"bacf61ea_f1575ac8","updated":"2016-07-27 19:58:58.000000000","message":"Why is that necessary? The debian package takes care of that.","commit_id":"9c01022421ba46159ea512388304add3c25915da"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"70559d82d55c6e74709f41bb054e364f0488b32a","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN chmod 750 /etc/sudoers.d \\"},{"line_number":11,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_grafana_sudoers \\"},{"line_number":12,"context_line":"    \u0026\u0026 usermod -a -G kolla grafana"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% block grafana_footer %}{% endblock %}"},{"line_number":15,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bacf61ea_7acd4130","line":12,"updated":"2016-08-01 13:14:09.000000000","message":"you added chown -R to the sudoers file, but aren\u0027t using it. This step could be run as the user as part of the bootstrap step or as root in the dockerfile here.","commit_id":"1ccc1c565e9ab2e6d9e21fe2c80158f4b8482b81"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"159c7b0adfc6c9c080efacb2ec11850fb95426b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN chmod 750 /etc/sudoers.d \\"},{"line_number":11,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_grafana_sudoers \\"},{"line_number":12,"context_line":"    \u0026\u0026 usermod -a -G kolla grafana"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% block grafana_footer %}{% endblock %}"},{"line_number":15,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bacf61ea_5b236ea7","line":12,"in_reply_to":"bacf61ea_3d06b220","updated":"2016-08-04 10:49:52.000000000","message":"When the sudoers file is not necessary to run grafana I think it should be removed.","commit_id":"1ccc1c565e9ab2e6d9e21fe2c80158f4b8482b81"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"b23c1a389a628287b403d08a21cd8ff9f8ab6879","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN chmod 750 /etc/sudoers.d \\"},{"line_number":11,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_grafana_sudoers \\"},{"line_number":12,"context_line":"    \u0026\u0026 usermod -a -G kolla grafana"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% block grafana_footer %}{% endblock %}"},{"line_number":15,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bacf61ea_3d06b220","line":12,"in_reply_to":"bacf61ea_7acd4130","updated":"2016-08-03 10:03:10.000000000","message":"I thought this was necessary to support source installation. Should I remove it entirely? I think sudoers is not necessary at all as Grafana ins installed via DEB package and that does all the necessary chown and chmod.","commit_id":"1ccc1c565e9ab2e6d9e21fe2c80158f4b8482b81"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"805ce99e05a0e517183df278a3fe3c60014e479c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":6,"context_line":"RUN {{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN usermod -a -G kolla grafana"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"9ad45d7e_88c26ee7","line":5,"updated":"2016-08-11 12:35:54.000000000","message":"This cannot be installed without having added the grafana repo to the base docker container. Docs are at http://docs.grafana.org/installation/rpm/\n\nIf you are intending to only add grafana as binary for debian/ubuntu it will need to be wrapped in the correct if statement.","commit_id":"02764687378d56644612bb454cbb45981e41c565"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"05b49bbf7e85d05d09dea244230801a8fbb35c55","unresolved":false,"context_lines":[{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":7,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":8,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_2d5dfae9","line":5,"updated":"2016-08-19 16:55:13.000000000","message":"nit: one empty line is enough","commit_id":"81c8eb1907586b3b1fad5954e663a762191030ba"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"b55935d2c069106ae61d17ed08c8f7c7fa584117","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":7,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN {{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_725526c5","line":8,"updated":"2016-08-19 11:30:16.000000000","message":"This means that a centos build will appear to succeed, but really have an empty packageset?\n\nProbably needs to declare that centos isn\u0027t yet supported and fail the build","commit_id":"81c8eb1907586b3b1fad5954e663a762191030ba"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9d9ea8656926eb2f9b232f582f77c2b749b75d3f","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":7,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN {{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_1d3e83b8","line":8,"in_reply_to":"1ac06dbe_725526c5","updated":"2016-08-19 11:43:17.000000000","message":"Have a look at https://github.com/openstack/kolla/blob/master/docker/watcher/watcher-base/Dockerfile.j2#L6-L7 how to add a note that a distro is not yet supported and exclude the image in tests/test_build.py.","commit_id":"81c8eb1907586b3b1fad5954e663a762191030ba"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"f774f329277e26eb2d304b2280d98fac5e4c9222","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":7,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN {{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_c214def6","line":8,"in_reply_to":"1ac06dbe_725526c5","updated":"2016-08-20 03:22:13.000000000","message":"The previous patchset also had comments regarding setting this up correctly.","commit_id":"81c8eb1907586b3b1fad5954e663a762191030ba"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"05b49bbf7e85d05d09dea244230801a8fbb35c55","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN {{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN usermod -a -G kolla grafana"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_8d722e7b","line":10,"updated":"2016-08-19 16:55:13.000000000","message":"nit: one empty line is enough","commit_id":"81c8eb1907586b3b1fad5954e663a762191030ba"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"3b0c8024aa41e8609842d441a2b3c5bec2ebc3b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN {{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN usermod -a -G kolla grafana"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_02039143","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":3},"updated":"2016-08-20 12:25:56.000000000","message":"The RUN has to be removed, it is now included in the macro itself.","commit_id":"81c8eb1907586b3b1fad5954e663a762191030ba"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"73e6c041adc00c74a6c09e623b93dc25b6503590","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":7,"context_line":"{% else  %}"},{"line_number":8,"context_line":"    RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":9,"context_line":"        \u0026\u0026 /bin/false"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"1ac06dbe_32d19cfc","line":9,"updated":"2016-08-25 13:16:31.000000000","message":"You have to add exceptions for Centos, ... to \ttests/test_build.py. If you not do this the gates will fail because of /bin/false.","commit_id":"0b0cfdf7d3f05d398456b1cf25e20c8c2e991079"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"6edba4056fc3985ea764dd57ef00d6be111b1fd3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":7,"context_line":"{% else  %}"},{"line_number":8,"context_line":"    RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":9,"context_line":"        \u0026\u0026 /bin/false"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"fa7ab95a_38ed168c","line":9,"in_reply_to":"1ac06dbe_32d19cfc","updated":"2016-08-26 01:58:17.000000000","message":"Approval","commit_id":"0b0cfdf7d3f05d398456b1cf25e20c8c2e991079"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"0e373046ff619d22299d38f78173bb706a05f2ed","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":7,"context_line":"{% else  %}"},{"line_number":8,"context_line":"    RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":9,"context_line":"        \u0026\u0026 /bin/false"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"fa7ab95a_3fcfb5b1","line":9,"in_reply_to":"1ac06dbe_32d19cfc","updated":"2016-08-26 06:51:32.000000000","message":"Hi, do you have any examples for this?","commit_id":"0b0cfdf7d3f05d398456b1cf25e20c8c2e991079"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"2036906c8c58cb8e03187220f97a7a30bb9a4fff","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":7,"context_line":"{% else  %}"},{"line_number":8,"context_line":"    RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":9,"context_line":"        \u0026\u0026 /bin/false"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"fa7ab95a_9a960c93","line":9,"in_reply_to":"fa7ab95a_3fcfb5b1","updated":"2016-08-26 08:21:57.000000000","message":"https://review.openstack.org/#/c/349295/13/tests/test_build.py","commit_id":"0b0cfdf7d3f05d398456b1cf25e20c8c2e991079"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"6f3339a3be8262dd8e1ccfdc750b1c57265a5b52","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    {% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":7,"context_line":"{% else  %}"},{"line_number":8,"context_line":"    RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":9,"context_line":"        \u0026\u0026 /bin/false"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"fa7ab95a_91785f91","line":9,"in_reply_to":"fa7ab95a_9a960c93","updated":"2016-08-28 19:18:46.000000000","message":"Dont get it. Thought you wanted a change in this file, no?","commit_id":"0b0cfdf7d3f05d398456b1cf25e20c8c2e991079"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"3a9f1ba778b094a88c262557e8d1cb315a269d40","unresolved":false,"context_lines":[{"line_number":14,"context_line":"RUN usermod -a -G kolla grafana"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% block grafana_footer %}{% endblock %}"},{"line_number":17,"context_line":"{% block footer %}{% endblock %}"},{"line_number":18,"context_line":"{{ include_footer }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"USER grafana"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"fa7ab95a_ea91ad53","line":17,"updated":"2016-08-29 04:53:52.000000000","message":"remove this footer block","commit_id":"0b0cfdf7d3f05d398456b1cf25e20c8c2e991079"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"1f7b1376c23b2a6a3475db8d972876505efa9000","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% set grafana_packages \u003d [\u0027grafana\u0027] %}"},{"line_number":6,"context_line":"RUN {{ macros.install_packages(grafana_packages | customizable(\"packages\")) }}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN usermod -a -G kolla grafana"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"fa7ab95a_eb5d3d7a","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":4},"updated":"2016-09-01 10:50:26.000000000","message":"RUN is not required here, is is part of the macro.","commit_id":"0143904d5f8acb39d5935efc350004fdfb852eff"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"47108774cdeda0217923bc98e17f753585053499","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"WORKDIR /usr/share/grafana"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"COPY grafana_sudoers /etc/sudoers.d/kolla_grafana_sudoers"},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"USER grafana"}],"source_content_type":"text/x-jinja2","patch_set":39,"id":"9a89bdaa_a321bdfe","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":54},"updated":"2016-09-10 02:53:26.000000000","message":"Should be above block...?","commit_id":"30dd49a49bdd259c67e590a17d0da2d0f43bd270"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a5af15e226e63e8f427c074a734fc1641436bd6a","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"WORKDIR /usr/share/grafana"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"COPY grafana_sudoers /etc/sudoers.d/kolla_grafana_sudoers"},{"line_number":17,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"USER grafana"}],"source_content_type":"text/x-jinja2","patch_set":39,"id":"9a89bdaa_85af59e2","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":54},"in_reply_to":"9a89bdaa_a321bdfe","updated":"2016-09-10 14:36:03.000000000","message":"Yes, good catch","commit_id":"30dd49a49bdd259c67e590a17d0da2d0f43bd270"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"14a06e8d0436286f00b12f7254457e30f2542910","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN usermod -a -G kolla grafana"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"WORKDIR /usr/share/grafana"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"COPY grafana_sudoers /etc/sudoers.d/kolla_grafana_sudoers"},{"line_number":13,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"9a89bdaa_928eb8ce","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":26},"updated":"2016-09-11 03:34:34.000000000","message":"is the above line necessary?","commit_id":"8c0226e30597cd13aa7fda59f849f982aa47da89"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"484231d8d77a64c6a44710dc21242a33843da3c8","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN usermod -a -G kolla grafana"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"WORKDIR /usr/share/grafana"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"COPY grafana_sudoers /etc/sudoers.d/kolla_grafana_sudoers"},{"line_number":13,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"9a89bdaa_9e495f91","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":26},"in_reply_to":"9a89bdaa_928eb8ce","updated":"2016-09-11 12:18:33.000000000","message":"yes, it is necessary","commit_id":"8c0226e30597cd13aa7fda59f849f982aa47da89"}],"docker/grafana/extend_start.sh":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"f8c74a6541491972585f13565a52ed302b0115d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bacf61ea_11482e2d","line":9,"updated":"2016-07-27 14:42:08.000000000","message":"KOLLA_BOOTSTRAP is never used.  If you don\u0027t need to bootstrap then you can remove this file","commit_id":"9c01022421ba46159ea512388304add3c25915da"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"66fc350192380a1515a15419e78ffb0e00993fa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bacf61ea_7da3319f","line":9,"in_reply_to":"bacf61ea_11482e2d","updated":"2016-07-27 19:58:58.000000000","message":"done","commit_id":"9c01022421ba46159ea512388304add3c25915da"}],"docker/grafana/grafana_sudoers":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"e5209a84fa5204b56254fdc2ed157893f5dcf005","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown -R telegraf\\:, /usr/sbin/grafana-server "}],"source_content_type":"application/octet-stream","patch_set":11,"id":"dada55a8_d8d0ab21","line":1,"range":{"start_line":1,"start_character":82,"end_line":1,"end_character":83},"updated":"2016-07-27 11:52:29.000000000","message":"remove whitespace","commit_id":"62f1a26332e2ea6d1d0b5d0e177729cc63dac83b"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5376634e0ed22508866a99854ea0a6e2b033ab88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown -R telegraf\\:, /usr/sbin/grafana-server"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"bacf61ea_19b817e5","line":1,"updated":"2016-07-28 15:09:38.000000000","message":"this is wrong. add /bin/chown too.","commit_id":"896186b7cb7f8260f815eac5c75911580f463a5a"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c86f6bce62904e0ccf8e7f685314c589f1e7d0fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWOD: /usr/bin/chown -R grafana\\: /var/lib/grafana, /bin/chown -R grafana\\: /var/lib/grafana"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"bacf61ea_ed470f49","line":1,"range":{"start_line":1,"start_character":18,"end_line":1,"end_character":27},"updated":"2016-07-29 12:03:38.000000000","message":"NOPASSWD","commit_id":"8961ccadb63793bb8fc02a987144b28322a82624"}],"docker/grafana/run.sh":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"76c39ba54a5284c3416e17c0b6d818e3f55753bf","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/etc/init.d/grafana-server start"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"while true; do "},{"line_number":6,"context_line":"    sleep 1000;"},{"line_number":7,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dada55a8_7d3ada35","line":5,"updated":"2016-07-25 02:35:57.000000000","message":"Trailing whitspace","commit_id":"c7f6c7ef776114a6923000288f634d94b3e62932"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"00c7b8d26929aef94471cded1682d4ceef5d0dc8","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"/etc/init.d/grafana-server start"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"while true; do"},{"line_number":6,"context_line":"    sleep 1000;"},{"line_number":7,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dada55a8_1257e95a","line":5,"updated":"2016-07-26 17:23:13.000000000","message":"remove all this and use sleep infinity","commit_id":"692e650b4b208e9983071617c579e5eb07bdb18d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"aa5a6ab646fa1b38de14a58fb23f37aa8c4341eb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"/etc/init.d/grafana-server start"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"while true; do"},{"line_number":6,"context_line":"    sleep 1000;"},{"line_number":7,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dada55a8_c4e578dc","line":6,"updated":"2016-07-27 03:23:52.000000000","message":"please use the /usr/sbin/grafana-server direct rather then the service manage scripts.\n\nsee this https://github.com/grafana/grafana/blob/master/packaging/rpm/systemd/grafana-server.service#L14","commit_id":"692e650b4b208e9983071617c579e5eb07bdb18d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f5fde5e22938255b5aacce7d7b05a4b3b0be7eb1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"/etc/init.d/grafana-server start"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"while true; do"},{"line_number":6,"context_line":"    sleep 1000;"},{"line_number":7,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dada55a8_6afaafbe","line":6,"updated":"2016-07-26 15:52:53.000000000","message":"what\u0027s the purepose to sleep 1000?","commit_id":"692e650b4b208e9983071617c579e5eb07bdb18d"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"4be0115b157980e827f76e02bdf13c92d615d2d2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"/etc/init.d/grafana-server start"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"while true; do"},{"line_number":6,"context_line":"    sleep 1000;"},{"line_number":7,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":10,"id":"dada55a8_c1dd8115","line":6,"in_reply_to":"dada55a8_6afaafbe","updated":"2016-07-26 16:25:03.000000000","message":"I found the grafana-server binary forks into background and has no option to stay or foreground. I tried running it directly, but that didnt work. This is the only way around it I could find.","commit_id":"692e650b4b208e9983071617c579e5eb07bdb18d"}],"tests/test_build.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"74812be0099c06dadea11d963573ad105b3fd953","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                       \"congress-base\","},{"line_number":74,"context_line":"                       \"bifrost-base\","},{"line_number":75,"context_line":"                       \"cloudkitty-base\","},{"line_number":76,"context_line":"                       \"grafana\"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def setUp(self):"},{"line_number":79,"context_line":"        super(BuildTestCentosBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":33,"id":"9a89bdaa_5e1ea0bb","line":76,"updated":"2016-09-07 14:52:37.000000000","message":"why add grafana here?","commit_id":"18277873961f6242c565f80b6db11517debc70d2"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"74812be0099c06dadea11d963573ad105b3fd953","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                       \"congress-base\","},{"line_number":126,"context_line":"                       \"bifrost-base\","},{"line_number":127,"context_line":"                       \"cloudkitty-base\","},{"line_number":128,"context_line":"                       \"grafana\"]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def setUp(self):"},{"line_number":131,"context_line":"        super(BuildTestOracleLinuxBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":33,"id":"9a89bdaa_7e1b64ca","line":128,"updated":"2016-09-07 14:52:37.000000000","message":"ditto","commit_id":"18277873961f6242c565f80b6db11517debc70d2"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d01303543e9123909c204b8c76264d8609d2b723","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                       \"congress-base\","},{"line_number":74,"context_line":"                       \"bifrost-base\","},{"line_number":75,"context_line":"                       \"cloudkitty-base\","},{"line_number":76,"context_line":"                       \"grafana\"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def setUp(self):"},{"line_number":79,"context_line":"        super(BuildTestCentosBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":34,"id":"9a89bdaa_31a3ca01","line":76,"updated":"2016-09-07 16:06:05.000000000","message":"Is there a reason grafana can\u0027t be built for Centos/OL binary?","commit_id":"1ed865e00c11e9607288defc82847acd0d45b259"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"0cf572d1da25e3f11fe6be75c30a33aee828420d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                       \"congress-base\","},{"line_number":74,"context_line":"                       \"bifrost-base\","},{"line_number":75,"context_line":"                       \"cloudkitty-base\","},{"line_number":76,"context_line":"                       \"grafana\"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def setUp(self):"},{"line_number":79,"context_line":"        super(BuildTestCentosBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":34,"id":"9a89bdaa_ec27c9b3","line":76,"in_reply_to":"9a89bdaa_31a3ca01","updated":"2016-09-07 16:26:19.000000000","message":"sorry， i fixed it， i should remove it","commit_id":"1ed865e00c11e9607288defc82847acd0d45b259"}]}