)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ccccf32c9df3210d526d4c333204794962cc1198","unresolved":false,"context_lines":[{"line_number":231,"context_line":"enable_neutron_lbaas: \"no\""},{"line_number":232,"context_line":"enable_neutron_qos: \"no\""},{"line_number":233,"context_line":"enable_swift: \"no\""},{"line_number":234,"context_line":"enable_performance_monitoring: \"no\""},{"line_number":235,"context_line":"enable_tempest: \"no\""},{"line_number":236,"context_line":"enable_watcher: \"no\""},{"line_number":237,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_693c81c8","line":234,"updated":"2016-07-31 09:04:20.000000000","message":"please respect the alphabetiacl order for the enable_*","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},"change_message_id":"b70d632499e2726f7c8739936361567baee22eda","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"watcher_api_port: \"9322\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"influxdb_port: \"8086\""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"public_protocol: \"{{ \u0027https\u0027 if kolla_enable_tls_external | bool else \u0027http\u0027 }}\""},{"line_number":179,"context_line":"internal_protocol: \"http\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"bacf61ea_5485fb04","line":176,"range":{"start_line":176,"start_character":16,"end_line":176,"end_character":20},"updated":"2016-08-04 11:58:57.000000000","message":"I remeber you add influxdb roles,howerver ,not used influxdb_port variable in conf file.This is why?","commit_id":"10db997dc2e99fe9976fa306dbb69d682e84b9c7"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"866042c84a1661d661057d43dfb8eb6a0c619d8c","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"watcher_api_port: \"9322\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"influxdb_port: \"8086\""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"public_protocol: \"{{ \u0027https\u0027 if kolla_enable_tls_external | bool else \u0027http\u0027 }}\""},{"line_number":179,"context_line":"internal_protocol: \"http\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"bacf61ea_afd184fd","line":176,"range":{"start_line":176,"start_character":16,"end_line":176,"end_character":20},"in_reply_to":"bacf61ea_5485fb04","updated":"2016-08-04 12:19:43.000000000","message":"Variable is used in ansible/roles/telegraf/templates/telegraf.conf.j2","commit_id":"10db997dc2e99fe9976fa306dbb69d682e84b9c7"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f55233d78bcdda475bd48368162e9f8871005c71","unresolved":false,"context_lines":[{"line_number":234,"context_line":"enable_neutron_lbaas: \"no\""},{"line_number":235,"context_line":"enable_neutron_qos: \"no\""},{"line_number":236,"context_line":"enable_swift: \"no\""},{"line_number":237,"context_line":"enable_performance_monitoring: \"no\""},{"line_number":238,"context_line":"enable_tempest: \"no\""},{"line_number":239,"context_line":"enable_watcher: \"no\""},{"line_number":240,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa7ab95a_2a7c27b4","line":237,"range":{"start_line":237,"start_character":0,"end_line":237,"end_character":35},"updated":"2016-08-30 06:59:45.000000000","message":"it should change to enable_telegraf: \"no\"","commit_id":"e409dd9f3ee04e295c228fa57fc23ea261895c30"}],"ansible/roles/telegraf/defaults/main.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ccccf32c9df3210d526d4c333204794962cc1198","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"telegraf\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"####################"},{"line_number":5,"context_line":"# Docker"},{"line_number":6,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_4939bdd6","line":3,"updated":"2016-07-31 09:04:20.000000000","message":"two empty lines","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ccccf32c9df3210d526d4c333204794962cc1198","unresolved":false,"context_lines":[{"line_number":4,"context_line":"####################"},{"line_number":5,"context_line":"# Docker"},{"line_number":6,"context_line":"####################"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"telegraf_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-telegraf\""},{"line_number":9,"context_line":"telegraf_tag: \"{{ openstack_release }}\""},{"line_number":10,"context_line":"telegraf_image_full: \"{{ telegraf_image }}:{{ telegraf_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_a932f9ef","line":7,"updated":"2016-07-31 09:04:20.000000000","message":"no need empty line","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ccccf32c9df3210d526d4c333204794962cc1198","unresolved":false,"context_lines":[{"line_number":13,"context_line":"####################"},{"line_number":14,"context_line":"# Protocols"},{"line_number":15,"context_line":"####################"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"elasticsearch_proto: \"http\""},{"line_number":18,"context_line":"haproxy_proto: \"http\""},{"line_number":19,"context_line":"influxdb_proto: \"http\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_892f3587","line":16,"updated":"2016-07-31 09:04:20.000000000","message":"ditto","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c42a7f529b29ca26088bfbac1c91e5cb5958d1f3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Protocols"},{"line_number":15,"context_line":"####################"},{"line_number":16,"context_line":"elasticsearch_proto: \"http\""},{"line_number":17,"context_line":"haproxy_proto: \"http\""},{"line_number":18,"context_line":"influxdb_proto: \"http\""},{"line_number":19,"context_line":"rabbitmq_proto: \"http\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bacf61ea_83e0712a","line":17,"updated":"2016-08-02 00:59:23.000000000","message":"please re-use the `internal_protocol`, `public_protocol` and `admin_protocol` variables.","commit_id":"265dbcf8c0b742738ff4b1257ec6a860b435c322"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8ee8ba16cef266eb17be6f4ae5c6913eb99b04d4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"elasticsearch_proto: \"{{ internal_procotol }}\""},{"line_number":17,"context_line":"haproxy_proto: \"{{ internal_protocol }}\""},{"line_number":18,"context_line":"influxdb_proto: \"{{ internal_protocol }}\""},{"line_number":19,"context_line":"rabbitmq_proto: \"{{ internal_protocol }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bacf61ea_c55e5f44","line":19,"updated":"2016-08-04 10:39:13.000000000","message":"This is confusing, because you want to access the web interface of rabbitmq and not rabbitmq itself. I think rabbitmq_management_proto would be a better name.","commit_id":"da17b49148ac7feadef19d07b90be8daab596537"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"5380fc516394e79a17b321b84927ed0559c089f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"####################"},{"line_number":5,"context_line":"# Docker"},{"line_number":6,"context_line":"####################"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"telegraf_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-telegraf\""},{"line_number":9,"context_line":"telegraf_tag: \"{{ openstack_release }}\""},{"line_number":10,"context_line":"telegraf_image_full: \"{{ telegraf_image }}:{{ telegraf_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"bacf61ea_a17514cc","line":7,"updated":"2016-08-04 13:50:18.000000000","message":"remove empty line","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"5380fc516394e79a17b321b84927ed0559c089f7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"####################"},{"line_number":14,"context_line":"# Protocols"},{"line_number":15,"context_line":"####################"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"elasticsearch_proto: \"http\""},{"line_number":18,"context_line":"haproxy_proto: \"http\""},{"line_number":19,"context_line":"influxdb_proto: \"http\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"bacf61ea_8141f065","line":16,"updated":"2016-08-04 13:50:18.000000000","message":"remove empty line","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"5380fc516394e79a17b321b84927ed0559c089f7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Protocols"},{"line_number":15,"context_line":"####################"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"elasticsearch_proto: \"http\""},{"line_number":18,"context_line":"haproxy_proto: \"http\""},{"line_number":19,"context_line":"influxdb_proto: \"http\""},{"line_number":20,"context_line":"rabbitmq_proto: \"http\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"bacf61ea_8138d0ef","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":22},"updated":"2016-08-04 13:50:18.000000000","message":"why don\u0027t you use \"{{ internal_procotol }}\" here?","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"105b88299af1f523d939c60160fdbec3e3ad14a1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Protocols"},{"line_number":15,"context_line":"####################"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"elasticsearch_proto: \"http\""},{"line_number":18,"context_line":"haproxy_proto: \"http\""},{"line_number":19,"context_line":"influxdb_proto: \"http\""},{"line_number":20,"context_line":"rabbitmq_proto: \"http\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"bacf61ea_472c2802","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":22},"in_reply_to":"bacf61ea_8138d0ef","updated":"2016-08-04 14:46:16.000000000","message":"wasn\u0027t aware of it","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f55233d78bcdda475bd48368162e9f8871005c71","unresolved":false,"context_lines":[{"line_number":14,"context_line":"####################"},{"line_number":15,"context_line":"elasticsearch_proto: \"{{ elasticsearch_proto }}\""},{"line_number":16,"context_line":"haproxy_proto: \"{{ haproxy_proto }}\""},{"line_number":17,"context_line":"influxdb_proto: \"{{ internal_procotol }}\""},{"line_number":18,"context_line":"rabbitmq_proto: \"{{ rabbitmq_proto }}\""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa7ab95a_8a6c5309","line":17,"range":{"start_line":17,"start_character":20,"end_line":17,"end_character":37},"updated":"2016-08-30 06:59:45.000000000","message":"it should is {{ internal_protocol }}","commit_id":"e409dd9f3ee04e295c228fa57fc23ea261895c30"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f55233d78bcdda475bd48368162e9f8871005c71","unresolved":false,"context_lines":[{"line_number":12,"context_line":"####################"},{"line_number":13,"context_line":"# Protocols"},{"line_number":14,"context_line":"####################"},{"line_number":15,"context_line":"elasticsearch_proto: \"{{ elasticsearch_proto }}\""},{"line_number":16,"context_line":"haproxy_proto: \"{{ haproxy_proto }}\""},{"line_number":17,"context_line":"influxdb_proto: \"{{ internal_procotol }}\""},{"line_number":18,"context_line":"rabbitmq_proto: \"{{ rabbitmq_proto }}\""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa7ab95a_8ae7f3aa","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":38},"updated":"2016-08-30 06:59:45.000000000","message":"you should delete it or you are in /group_vars/all.yaml setting","commit_id":"e409dd9f3ee04e295c228fa57fc23ea261895c30"}],"ansible/roles/telegraf/meta/main.yml":[{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f55233d78bcdda475bd48368162e9f8871005c71","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027telegraf.yml\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa7ab95a_0afcc33c","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":48},"updated":"2016-08-30 06:59:45.000000000","message":"if you don\u0027t use it, you can delete it","commit_id":"e409dd9f3ee04e295c228fa57fc23ea261895c30"}],"ansible/roles/telegraf/tasks/config.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ccccf32c9df3210d526d4c333204794962cc1198","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    src: \"{{ item }}\""},{"line_number":24,"context_line":"    dest: \"{{ node_config_directory }}/telegraf/config\""},{"line_number":25,"context_line":"  with_fileglob:"},{"line_number":26,"context_line":"    - \"{{ role_path }}/templates/config/*.conf\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_e94eb16d","line":26,"updated":"2016-07-31 09:04:20.000000000","message":"where is these files?","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"d619b92daa78543ad71ba6458550b6424cebb6d3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    src: \"{{ item }}\""},{"line_number":24,"context_line":"    dest: \"{{ node_config_directory }}/telegraf/config\""},{"line_number":25,"context_line":"  with_fileglob:"},{"line_number":26,"context_line":"    - \"{{ role_path }}/templates/config/*.conf\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_69b12147","line":26,"in_reply_to":"bacf61ea_e94eb16d","updated":"2016-07-31 09:25:47.000000000","message":"There are none. But there will be the requirement to copy custom config files over. Better address this now than in a bug report after merge :)","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"e0b98ca62d6e78dd043138fb000ca91a22f099dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Copying over default config.json files"},{"line_number":12,"context_line":"  template:"},{"line_number":13,"context_line":"    src: \"telegraf.json.j2\""},{"line_number":14,"context_line":"    dest: \"{{ node_config_directory }}/telegraf/config.json\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Copying over telegraf config file"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bacf61ea_62ea8cdc","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":18},"updated":"2016-08-02 08:51:22.000000000","message":"Could you also add with_items for this section? We usually do this in this way, even for one item.","commit_id":"265dbcf8c0b742738ff4b1257ec6a860b435c322"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"e0b98ca62d6e78dd043138fb000ca91a22f099dd","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Copying over telegraf config file"},{"line_number":17,"context_line":"  template:"},{"line_number":18,"context_line":"    src: \"telegraf.conf.j2\""},{"line_number":19,"context_line":"    dest: \"{{ node_config_directory }}/telegraf/telegraf.conf\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Copying over telegraf plugin files"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bacf61ea_a2f004ca","line":18,"range":{"start_line":18,"start_character":10,"end_line":18,"end_character":18},"updated":"2016-08-02 08:51:22.000000000","message":"the same here","commit_id":"265dbcf8c0b742738ff4b1257ec6a860b435c322"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"37b8298e7c9b4d8817911640f9af422ba2c93de6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensuring config directories exist"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item  }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bacf61ea_e2f8f1c6","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":50},"updated":"2016-08-03 12:06:13.000000000","message":"{{ item }}","commit_id":"a62b262388664d461c9e004c360ca68338b98bd4"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"2f187c0e4748021bdad0539e07612ae512680101","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensuring config directories exist"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item  }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bacf61ea_e268c323","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":50},"in_reply_to":"bacf61ea_e2f8f1c6","updated":"2016-08-04 06:45:08.000000000","message":"What\u0027s wrong here? I dont see it.","commit_id":"a62b262388664d461c9e004c360ca68338b98bd4"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"37b8298e7c9b4d8817911640f9af422ba2c93de6","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Copying over default config.json files"},{"line_number":12,"context_line":"  template:"},{"line_number":13,"context_line":"    src: \"{{ item  }}\""},{"line_number":14,"context_line":"    dest: \"{{ node_config_directory }}/telegraf/config.json\""},{"line_number":15,"context_line":"   with_items:"},{"line_number":16,"context_line":"     - telegraf.json.j2"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bacf61ea_c2f5edcb","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":21},"updated":"2016-08-03 12:06:13.000000000","message":"{{ item }}","commit_id":"a62b262388664d461c9e004c360ca68338b98bd4"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"37b8298e7c9b4d8817911640f9af422ba2c93de6","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Copying over telegraf config file"},{"line_number":19,"context_line":"  template:"},{"line_number":20,"context_line":"    src: \"{{ item  }}\""},{"line_number":21,"context_line":"    dest: \"{{ node_config_directory }}/telegraf/telegraf.conf\""},{"line_number":22,"context_line":"   with_items:"},{"line_number":23,"context_line":"     - telegraf.conf.j2"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"bacf61ea_4209fddc","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":21},"updated":"2016-08-03 12:06:13.000000000","message":"{{ item }}","commit_id":"a62b262388664d461c9e004c360ca68338b98bd4"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"5380fc516394e79a17b321b84927ed0559c089f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensuring config directories exist"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item  }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"bacf61ea_4c00cf01","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":48},"updated":"2016-08-04 13:50:18.000000000","message":"2 spaces here, should be 1","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"105b88299af1f523d939c60160fdbec3e3ad14a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensuring config directories exist"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item  }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"bacf61ea_ad24e50c","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":48},"in_reply_to":"bacf61ea_4c00cf01","updated":"2016-08-04 14:46:16.000000000","message":"done","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"}],"ansible/roles/telegraf/tasks/reconfigure.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"92b4b8fcf60be87c793231cdec717eac750d2382","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: do_reconfigure.yml"},{"line_number":3,"context_line":"  serial: \"30%\""}],"source_content_type":"text/x-yaml","patch_set":50,"id":"7a8ec9b2_a1261b66","line":3,"updated":"2016-09-14 15:34:26.000000000","message":"remove serial here","commit_id":"2a899e7d7450319795adf2d844322d160c8f019e"}],"ansible/roles/telegraf/tasks/start.yml":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"6677fafb766d38da6b91c75e11d3cc4c23d68740","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    volumes:"},{"line_number":12,"context_line":"      - \"{{ node_config_directory }}/telegraf/:{{ container_config_directory }}/:ro\""},{"line_number":13,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":14,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":15,"context_line":"      - \"/sys:/rootfs/sys:ro\""},{"line_number":16,"context_line":"      - \"/proc:/rootfs/proc:ro\""},{"line_number":17,"context_line":"      - \"/var/run/docker.sock:/var/run/docker.sock:ro\""}],"source_content_type":"text/x-yaml","patch_set":47,"id":"9a89bdaa_6eaae372","line":14,"updated":"2016-09-13 04:24:00.000000000","message":"It seems there is no log file for telegraf because its Dockerfile does not create any directory for log [1]. In addition there is no log file configuration in this PS. So the above line is unnecessary.\n\n[1] https://github.com/openstack/kolla/tree/master/docker/telegraf","commit_id":"90555577bb8b644195a75aac506ef5fc33e586f0"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"2bd8a954a2091f296880007478d5086d3615ed5a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    volumes:"},{"line_number":12,"context_line":"      - \"{{ node_config_directory }}/telegraf/:{{ container_config_directory }}/:ro\""},{"line_number":13,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":14,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":15,"context_line":"      - \"/sys:/rootfs/sys:ro\""},{"line_number":16,"context_line":"      - \"/proc:/rootfs/proc:ro\""},{"line_number":17,"context_line":"      - \"/var/run/docker.sock:/var/run/docker.sock:ro\""}],"source_content_type":"text/x-yaml","patch_set":47,"id":"9a89bdaa_31691cbf","line":14,"in_reply_to":"9a89bdaa_6eaae372","updated":"2016-09-13 05:47:24.000000000","message":"yes,i will add log file to telgraf contaier","commit_id":"90555577bb8b644195a75aac506ef5fc33e586f0"}],"ansible/roles/telegraf/tasks/upgrade.yml":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"124bc005d2bc6d505645b0e4b3f8fddafc0030f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- include: bootstrap_service.yml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: start.yml"},{"line_number":7,"context_line":"  serial: \"30%\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bacf61ea_ee981b6d","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":28},"updated":"2016-07-27 14:33:17.000000000","message":"there is no bootstrap_service.yml.  It doesn\u0027t look like you need to bootstrap since the extend_start isn\u0027t doing anything.","commit_id":"f56feb2e9712419c0ed0b6882069981bcd91f9ec"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"b4a517a537983fe66366c5abae7e2925ae1af945","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- include: bootstrap_service.yml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: start.yml"},{"line_number":7,"context_line":"  serial: \"30%\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bacf61ea_c05514c7","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":28},"in_reply_to":"bacf61ea_ee981b6d","updated":"2016-07-27 19:58:30.000000000","message":"removed the line","commit_id":"f56feb2e9712419c0ed0b6882069981bcd91f9ec"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"abc1224ed161741057b84e97ba8cd187b29e3d7f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- include: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- include: start.yml"},{"line_number":5,"context_line":"  serial: \"30%\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"7a8ec9b2_70d30339","line":5,"updated":"2016-09-14 15:11:10.000000000","message":"serial is not valid here, please check the latest site.yml","commit_id":"24aeb7cfbae2c84945882f8c18155c99c11cd962"}],"ansible/roles/telegraf/templates/telegraf.conf.j2":[{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"969dbeadc47c2278987ebee7db330ca1260490a5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  hostname \u003d \"\""},{"line_number":13,"context_line":"  omit_hostname \u003d false"},{"line_number":14,"context_line":"[[outputs.influxdb]]"},{"line_number":15,"context_line":"  urls \u003d [{% for host in groups[\u0027influxdb\u0027] %}\"http://{{ hostvars[host][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027]}}:8086\",{% endfor %}] # required"},{"line_number":16,"context_line":"  database \u003d \"telegraf\" # required"},{"line_number":17,"context_line":"  precision \u003d \"s\""},{"line_number":18,"context_line":"  retention_policy \u003d \"default\""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"dada55a8_ce5dd816","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":51},"updated":"2016-07-26 00:40:05.000000000","message":"same as below","commit_id":"b86ac60a59b9b76f0d2ea135d395a55bb03a0a2b"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"969dbeadc47c2278987ebee7db330ca1260490a5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  interfaces \u003d []"},{"line_number":35,"context_line":"{% if inventory_hostname in groups[\u0027haproxy\u0027] %}"},{"line_number":36,"context_line":"[[inputs.haproxy]]"},{"line_number":37,"context_line":"  servers \u003d [\"http://{{ haproxy_user }}:{{ haproxy_password }}@{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:1984\"]"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"{% if inventory_hostname in groups[\u0027memcached\u0027] %}"},{"line_number":40,"context_line":"[[inputs.memcached]]"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"dada55a8_ee625cd7","line":37,"range":{"start_line":37,"start_character":14,"end_line":37,"end_character":18},"updated":"2016-07-26 00:40:05.000000000","message":"same as below","commit_id":"b86ac60a59b9b76f0d2ea135d395a55bb03a0a2b"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"969dbeadc47c2278987ebee7db330ca1260490a5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% endif %}"},{"line_number":43,"context_line":"{% if inventory_hostname in groups[\u0027memcached\u0027] %}"},{"line_number":44,"context_line":"[[inputs.elasticsearch]]"},{"line_number":45,"context_line":"  servers \u003d [\"http://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:9200\"]"},{"line_number":46,"context_line":"  local \u003d true"},{"line_number":47,"context_line":"  cluster_health \u003d true"},{"line_number":48,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"dada55a8_8e63e0dc","line":45,"range":{"start_line":45,"start_character":14,"end_line":45,"end_character":18},"updated":"2016-07-26 00:40:05.000000000","message":"Should this be hard-coded http?","commit_id":"b86ac60a59b9b76f0d2ea135d395a55bb03a0a2b"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8ee8ba16cef266eb17be6f4ae5c6913eb99b04d4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  hostname \u003d \"\""},{"line_number":13,"context_line":"  omit_hostname \u003d false"},{"line_number":14,"context_line":"[[outputs.influxdb]]"},{"line_number":15,"context_line":"  urls \u003d [{% for host in groups[\u0027influxdb\u0027] %}\"{{ influxdb_proto }}://{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027]}}:8086\"{% if not loop.last %},{% endif %}{% endfor %}]"},{"line_number":16,"context_line":"  database \u003d \"telegraf\" # required"},{"line_number":17,"context_line":"  precision \u003d \"s\""},{"line_number":18,"context_line":"  retention_policy \u003d \"default\""}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"bacf61ea_880f5ee0","line":15,"range":{"start_line":15,"start_character":155,"end_line":15,"end_character":159},"updated":"2016-08-04 10:39:13.000000000","message":"this port should be added to ansible/group_vars/all.yml","commit_id":"da17b49148ac7feadef19d07b90be8daab596537"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8ee8ba16cef266eb17be6f4ae5c6913eb99b04d4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  interfaces \u003d []"},{"line_number":35,"context_line":"{% if inventory_hostname in groups[\u0027haproxy\u0027] %}"},{"line_number":36,"context_line":"[[inputs.haproxy]]"},{"line_number":37,"context_line":"  servers \u003d [\"{{ haproxy_proto }}://{{ haproxy_user }}:{{ haproxy_password }}@{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:1984\"]"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"{% if inventory_hostname in groups[\u0027memcached\u0027] %}"},{"line_number":40,"context_line":"[[inputs.memcached]]"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"bacf61ea_c872f67b","line":37,"range":{"start_line":37,"start_character":160,"end_line":37,"end_character":164},"updated":"2016-08-04 10:39:13.000000000","message":"use {{ haproxy_stats_port }} here","commit_id":"da17b49148ac7feadef19d07b90be8daab596537"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8ee8ba16cef266eb17be6f4ae5c6913eb99b04d4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"[[inputs.memcached]]"},{"line_number":41,"context_line":"  servers \u003d [\"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:11211\"]"},{"line_number":42,"context_line":"{% endif %}"},{"line_number":43,"context_line":"{% if inventory_hostname in groups[\u0027memcached\u0027] %}"},{"line_number":44,"context_line":"[[inputs.elasticsearch]]"},{"line_number":45,"context_line":"  servers \u003d [\"{{ elasticsearch_proto }}://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:9200\"]"},{"line_number":46,"context_line":"  local \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"bacf61ea_a8aa22d0","line":43,"range":{"start_line":43,"start_character":36,"end_line":43,"end_character":45},"updated":"2016-08-04 10:39:13.000000000","message":"This should be elasticsearch and not memcached.","commit_id":"da17b49148ac7feadef19d07b90be8daab596537"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8ee8ba16cef266eb17be6f4ae5c6913eb99b04d4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% endif %}"},{"line_number":43,"context_line":"{% if inventory_hostname in groups[\u0027memcached\u0027] %}"},{"line_number":44,"context_line":"[[inputs.elasticsearch]]"},{"line_number":45,"context_line":"  servers \u003d [\"{{ elasticsearch_proto }}://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:9200\"]"},{"line_number":46,"context_line":"  local \u003d true"},{"line_number":47,"context_line":"  cluster_health \u003d true"},{"line_number":48,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"bacf61ea_88411e0e","line":45,"range":{"start_line":45,"start_character":124,"end_line":45,"end_character":128},"updated":"2016-08-04 10:39:13.000000000","message":"use {{ elasticsearch_port }} here","commit_id":"da17b49148ac7feadef19d07b90be8daab596537"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8ee8ba16cef266eb17be6f4ae5c6913eb99b04d4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"{% endif %}"},{"line_number":49,"context_line":"{% if inventory_hostname in groups[\u0027rabbitmq\u0027] %}"},{"line_number":50,"context_line":"[[inputs.rabbitmq]]"},{"line_number":51,"context_line":"  url \u003d \"{{ rabbitmq_proto }}://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:15672\""},{"line_number":52,"context_line":"  username \u003d \"openstack\""},{"line_number":53,"context_line":"  password \u003d \"{{ rabbitmq_password }}\""},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"bacf61ea_0856ced1","line":51,"range":{"start_line":51,"start_character":114,"end_line":51,"end_character":119},"updated":"2016-08-04 10:39:13.000000000","message":"use {{ rabbitmq_management_port }} here","commit_id":"da17b49148ac7feadef19d07b90be8daab596537"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8ee8ba16cef266eb17be6f4ae5c6913eb99b04d4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"{% if inventory_hostname in groups[\u0027rabbitmq\u0027] %}"},{"line_number":50,"context_line":"[[inputs.rabbitmq]]"},{"line_number":51,"context_line":"  url \u003d \"{{ rabbitmq_proto }}://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:15672\""},{"line_number":52,"context_line":"  username \u003d \"openstack\""},{"line_number":53,"context_line":"  password \u003d \"{{ rabbitmq_password }}\""},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"bacf61ea_a8d86280","line":52,"range":{"start_line":52,"start_character":14,"end_line":52,"end_character":23},"updated":"2016-08-04 10:39:13.000000000","message":"use {{ rabbitmq_user }} here","commit_id":"da17b49148ac7feadef19d07b90be8daab596537"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f55233d78bcdda475bd48368162e9f8871005c71","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  interfaces \u003d []"},{"line_number":35,"context_line":"{% if inventory_hostname in groups[\u0027haproxy\u0027] %}"},{"line_number":36,"context_line":"[[inputs.haproxy]]"},{"line_number":37,"context_line":"  servers \u003d [\"{{ haproxy_proto }}://{{ haproxy_user }}:{{ haproxy_password }}@{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:1984\"]"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"{% if inventory_hostname in groups[\u0027memcached\u0027] %}"},{"line_number":40,"context_line":"[[inputs.memcached]]"}],"source_content_type":"text/x-jinja2","patch_set":37,"id":"fa7ab95a_8d7b8d7a","line":37,"range":{"start_line":37,"start_character":17,"end_line":37,"end_character":30},"updated":"2016-08-30 06:59:45.000000000","message":"{{ internal_protocol }} or you set this variable","commit_id":"e409dd9f3ee04e295c228fa57fc23ea261895c30"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f55233d78bcdda475bd48368162e9f8871005c71","unresolved":false,"context_lines":[{"line_number":48,"context_line":"{% endif %}"},{"line_number":49,"context_line":"{% if inventory_hostname in groups[\u0027rabbitmq\u0027] %}"},{"line_number":50,"context_line":"[[inputs.rabbitmq]]"},{"line_number":51,"context_line":"  url \u003d \"{{ rabbitmq_proto }}://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:15672\""},{"line_number":52,"context_line":"  username \u003d \"openstack\""},{"line_number":53,"context_line":"  password \u003d \"{{ rabbitmq_password }}\""},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":37,"id":"fa7ab95a_4dec252a","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":27},"updated":"2016-08-30 06:59:45.000000000","message":"{{ internal_protocol }} or you set this variable","commit_id":"e409dd9f3ee04e295c228fa57fc23ea261895c30"}],"ansible/roles/telegraf/templates/telegraf.json.j2":[{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"6d8a21b39dee134cb531e8560de7c6d5396aea6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/telegraf.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/telegraf/telegraf.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0644\""},{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bacf61ea_56a81177","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":26},"updated":"2016-08-01 14:49:54.000000000","message":"Why owner is root? Shouldn\u0027t it be telegraf?","commit_id":"dfa2bc6ea5dbd62e7235c6761651d15993f95103"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"6d8a21b39dee134cb531e8560de7c6d5396aea6d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/config/*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/telegraf/telegraf.d/\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0644\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bacf61ea_7620b5f7","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":26},"updated":"2016-08-01 14:49:54.000000000","message":"ditto","commit_id":"dfa2bc6ea5dbd62e7235c6761651d15993f95103"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"5380fc516394e79a17b321b84927ed0559c089f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/telegraf.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/telegraf/telegraf.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0644\""},{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"bacf61ea_ac386bd4","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":26},"updated":"2016-08-04 13:50:18.000000000","message":"should be telegraf","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"105b88299af1f523d939c60160fdbec3e3ad14a1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/telegraf.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/telegraf/telegraf.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0644\""},{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"bacf61ea_8d32c15c","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":26},"in_reply_to":"bacf61ea_ac386bd4","updated":"2016-08-04 14:46:16.000000000","message":"This is what the debian package from influxdata repo sets as owner. I see no reason to change it.","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"5380fc516394e79a17b321b84927ed0559c089f7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/config/*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/telegraf/telegraf.d/\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0644\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"bacf61ea_ec2ee38a","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":26},"updated":"2016-08-04 13:50:18.000000000","message":"ditto","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"105b88299af1f523d939c60160fdbec3e3ad14a1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/config/*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/telegraf/telegraf.d/\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0644\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"bacf61ea_ad3d052d","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":26},"in_reply_to":"bacf61ea_ec2ee38a","updated":"2016-08-04 14:46:16.000000000","message":"This is what the debian package from influxdata repo sets as owner. I see no reason to change it.","commit_id":"f9cbfb7a742fb5ddc50ccff087aa057a767e498f"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"abc1224ed161741057b84e97ba8cd187b29e3d7f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/telegraf.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/telegraf/telegraf.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":49,"id":"7a8ec9b2_abf35c09","line":7,"updated":"2016-09-14 15:11:10.000000000","message":"the telegraf containers run as user telegraf and so can\u0027t read this config","commit_id":"24aeb7cfbae2c84945882f8c18155c99c11cd962"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"abc1224ed161741057b84e97ba8cd187b29e3d7f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/config/*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/telegraf/telegraf.d/\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":49,"id":"7a8ec9b2_cbf8a8e8","line":13,"updated":"2016-09-14 15:11:10.000000000","message":"same","commit_id":"24aeb7cfbae2c84945882f8c18155c99c11cd962"}],"ansible/site.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ccccf32c9df3210d526d4c333204794962cc1198","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  roles:"},{"line_number":4,"context_line":"    - { role: telegraf,"},{"line_number":5,"context_line":"        tags: [\u0027perfmon\u0027, \u0027telegraf\u0027],"},{"line_number":6,"context_line":"        when: enable_performance_monitoring | bool }"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- hosts:"},{"line_number":9,"context_line":"    - ceph-mon"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_092345a8","line":6,"updated":"2016-07-31 09:04:20.000000000","message":"please move this to the end of the file( at least not the start.) the monitor tools should be installed and configure at last. Otherwise, some invalid value should be saved. \n\nFor example: if the telegraf load the data from nova, but the nova is not installed here.","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"d619b92daa78543ad71ba6458550b6424cebb6d3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  roles:"},{"line_number":4,"context_line":"    - { role: telegraf,"},{"line_number":5,"context_line":"        tags: [\u0027perfmon\u0027, \u0027telegraf\u0027],"},{"line_number":6,"context_line":"        when: enable_performance_monitoring | bool }"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- hosts:"},{"line_number":9,"context_line":"    - ceph-mon"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_699801c1","line":6,"in_reply_to":"bacf61ea_092345a8","updated":"2016-07-31 09:25:47.000000000","message":"I think there are two ways to argue about this: What you said is correct. But installing the tools last, we will miss data points. I will move it last to get your upvote though.","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f55233d78bcdda475bd48368162e9f8871005c71","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        tags: watcher,"},{"line_number":262,"context_line":"        when: enable_watcher | bool }"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"- hosts: all"},{"line_number":265,"context_line":"  roles:"},{"line_number":266,"context_line":"    - { role: telegraf,"},{"line_number":267,"context_line":"        tags: [\u0027perfmon\u0027, \u0027telegraf\u0027],"},{"line_number":268,"context_line":"        when: enable_performance_monitoring | bool }"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa7ab95a_0a9f635f","line":268,"range":{"start_line":264,"start_character":0,"end_line":268,"end_character":52},"updated":"2016-08-30 06:59:45.000000000","message":"this should is \n- hosts: \n    - telegraf\n    - influxdb\n  roles:\n    - { role: telegraf,\n        tags: telgraf,\n        when: enable_telegraf | bool }","commit_id":"e409dd9f3ee04e295c228fa57fc23ea261895c30"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"1d548f5278e42bbad78d5aeffbebd36ac6b0252b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        when: enable_aodh | bool }"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"- hosts:"},{"line_number":259,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":260,"context_line":"    - congress-api"},{"line_number":261,"context_line":"    - congress-policy-engine"},{"line_number":262,"context_line":"    - congress-datasource"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"9a89bdaa_6c93865b","line":259,"updated":"2016-09-08 13:25:58.000000000","message":"This needs to be fixed","commit_id":"811ef0758c788f2fca01f2449af80478659c984a"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"5d591893318ef41a0a180762fbb9f59094b9c76b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- hosts: influxdb"},{"line_number":3,"context_line":"  roles:"},{"line_number":4,"context_line":"    - { role: influxdb,"},{"line_number":5,"context_line":"        tags: [\u0027perfmon\u0027, \u0027influxdb\u0027] }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- hosts:"},{"line_number":8,"context_line":"    - ceph-mon"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"9a89bdaa_12eb8879","line":5,"updated":"2016-09-11 03:29:56.000000000","message":"It would be better to add a condition (e.g., when enable_...) for influxdb, like other services.","commit_id":"1626650a465d36217e966c16f81df097f9c214b0"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"12d4926168ac4f0f10aeb5a484fd074e68b9df18","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- hosts: influxdb"},{"line_number":3,"context_line":"  roles:"},{"line_number":4,"context_line":"    - { role: influxdb,"},{"line_number":5,"context_line":"        tags: [\u0027perfmon\u0027, \u0027influxdb\u0027] }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- hosts:"},{"line_number":8,"context_line":"    - ceph-mon"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"9a89bdaa_3e59335c","line":5,"in_reply_to":"9a89bdaa_12eb8879","updated":"2016-09-11 12:19:58.000000000","message":"it is shoud delete i will fixed it","commit_id":"1626650a465d36217e966c16f81df097f9c214b0"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"92b4b8fcf60be87c793231cdec717eac750d2382","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        when: enable_influxdb | bool }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- hosts:"},{"line_number":30,"context_line":"    - telegraf"},{"line_number":31,"context_line":"  roles:"},{"line_number":32,"context_line":"    - { role: telegraf,"},{"line_number":33,"context_line":"        tags: telegraf,"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"7a8ec9b2_21bf6bfc","line":30,"updated":"2016-09-14 15:34:26.000000000","message":"You need a line like this here: \n\n  serial: \u0027{{ \"30%\" if action \u003d\u003d \"upgrade\" else \"0\" }}\u0027\n\nHit the rebase button from Gerrit and you should see entries for the other services here.","commit_id":"2a899e7d7450319795adf2d844322d160c8f019e"}],"etc/kolla/globals.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"21fc9acd0ba29827354904208be3507cf6d39723","unresolved":false,"context_lines":[{"line_number":144,"context_line":"#######################"},{"line_number":145,"context_line":"# Glance options"},{"line_number":146,"context_line":"#######################"},{"line_number":147,"context_line":"# Configure image backend. "},{"line_number":148,"context_line":"glance_backend_file: \"yes\""},{"line_number":149,"context_line":"#glance_backend_ceph: \"no\""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bacf61ea_5264f620","line":147,"range":{"start_line":147,"start_character":26,"end_line":147,"end_character":27},"updated":"2016-07-29 11:58:19.000000000","message":"remove whitespace","commit_id":"1c68aedb87511c5e2184cf4061318a7e7ab44e42"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ccccf32c9df3210d526d4c333204794962cc1198","unresolved":false,"context_lines":[{"line_number":144,"context_line":"#######################"},{"line_number":145,"context_line":"# Glance options"},{"line_number":146,"context_line":"#######################"},{"line_number":147,"context_line":"# Configure image backend."},{"line_number":148,"context_line":"glance_backend_file: \"yes\""},{"line_number":149,"context_line":"#glance_backend_ceph: \"no\""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_291e095f","line":147,"updated":"2016-07-31 09:04:20.000000000","message":"do not touch this in this PS.","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":17938,"name":"Mathias Ewald","email":"mewald@evoila.de","username":"mewald"},"change_message_id":"d619b92daa78543ad71ba6458550b6424cebb6d3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"#######################"},{"line_number":145,"context_line":"# Glance options"},{"line_number":146,"context_line":"#######################"},{"line_number":147,"context_line":"# Configure image backend."},{"line_number":148,"context_line":"glance_backend_file: \"yes\""},{"line_number":149,"context_line":"#glance_backend_ceph: \"no\""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bacf61ea_69df6169","line":147,"in_reply_to":"bacf61ea_291e095f","updated":"2016-07-31 09:25:47.000000000","message":"I think all that happened here was the removal of a white space. After someone complained about trailing white spaces I did :%s/\\s*$//g in vim. Should I add the whitespace back?","commit_id":"ebc78762fa35f84790a1a597b3651d3634022a00"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c42a7f529b29ca26088bfbac1c91e5cb5958d1f3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"#######################"},{"line_number":145,"context_line":"# Glance options"},{"line_number":146,"context_line":"#######################"},{"line_number":147,"context_line":"# Configure image backend."},{"line_number":148,"context_line":"glance_backend_file: \"yes\""},{"line_number":149,"context_line":"#glance_backend_ceph: \"no\""},{"line_number":150,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bacf61ea_23f545ec","line":147,"updated":"2016-08-02 00:59:23.000000000","message":"I prefer you do not touch this is this PS. you can push a new PS for the tail white space remove.","commit_id":"265dbcf8c0b742738ff4b1257ec6a860b435c322"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f55233d78bcdda475bd48368162e9f8871005c71","unresolved":false,"context_lines":[{"line_number":123,"context_line":"#enable_multipathd: \"no\""},{"line_number":124,"context_line":"#enable_neutron_lbaas: \"no\""},{"line_number":125,"context_line":"#enable_neutron_qos: \"no\""},{"line_number":126,"context_line":"#enable_performance_monitoring: \"no\""},{"line_number":127,"context_line":"#enable_swift: \"no\""},{"line_number":128,"context_line":"#enable_tempest: \"no\""},{"line_number":129,"context_line":"#enable_watcher: \"no\""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa7ab95a_eaf6bf8d","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":36},"updated":"2016-08-30 06:59:45.000000000","message":"it should change \n#enable_telegraf: \"no\"","commit_id":"e409dd9f3ee04e295c228fa57fc23ea261895c30"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"1de68bb236a8ff85bda183f2707d7ee33456f8eb","unresolved":false,"context_lines":[{"line_number":171,"context_line":"# Glance options"},{"line_number":172,"context_line":"#######################"},{"line_number":173,"context_line":"# Configure image backend."},{"line_number":174,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":175,"context_line":"#glance_backend_file: \"yes\""},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":177,"context_line":"glance_backend_file: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"9a89bdaa_84a7b6a5","line":174,"updated":"2016-09-08 16:21:47.000000000","message":"Needs to be resolved","commit_id":"1626650a465d36217e966c16f81df097f9c214b0"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"7b4261a5233c48d796556505859f0fad615bb3f0","unresolved":false,"context_lines":[{"line_number":171,"context_line":"# Glance options"},{"line_number":172,"context_line":"#######################"},{"line_number":173,"context_line":"# Configure image backend."},{"line_number":174,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":175,"context_line":"#glance_backend_file: \"yes\""},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":177,"context_line":"glance_backend_file: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":44,"id":"9a89bdaa_f1eca694","line":174,"in_reply_to":"9a89bdaa_84a7b6a5","updated":"2016-09-09 05:13:07.000000000","message":"good advice,i fixed it now","commit_id":"1626650a465d36217e966c16f81df097f9c214b0"}]}