)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"931a98c557809d68a2651f50d44468d88a56d8b0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  Kolla-Kubernetes patch to be merged to be safe)"},{"line_number":11,"context_line":"* Allows the user to point at a cluster for the following services that"},{"line_number":12,"context_line":"  isn\u0027t defined by the Ansible hostvars:"},{"line_number":13,"context_line":"\t* RabbitMQ"},{"line_number":14,"context_line":"\t* MemcacheD"},{"line_number":15,"context_line":"\t* Neutron"},{"line_number":16,"context_line":"\t* Keystone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_98fff300","line":13,"updated":"2016-08-09 02:37:43.000000000","message":"is this tab? some special characters at the beginning of these lines. please remove it.","commit_id":"f4ea57a0c28eedf5633000040da30c9d26e74f15"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4bde271b61a9853bd4c20d62052ec7ba922d196f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\t* RabbitMQ"},{"line_number":13,"context_line":"\t* MemcacheD"},{"line_number":14,"context_line":"\t* Neutron"},{"line_number":15,"context_line":"\t* Keystone"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iadbdd3aa43f9ba91ec820220fb8828e69161c579"},{"line_number":18,"context_line":"Co-authored-by: Ryan Hallisey \u003crhallise@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_e1d5c1b9","line":15,"updated":"2016-08-14 16:06:23.000000000","message":"wired char here at the begining of the line still. could u remove them?","commit_id":"4693bc8c776f7497f5ebaf13e77b20da4a7aebd7"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"529c599c2041459cc7b7638172b24fd1dcf7d086","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\t* MemcacheD"},{"line_number":14,"context_line":"\t* Neutron"},{"line_number":15,"context_line":"\t* Keystone"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iadbdd3aa43f9ba91ec820220fb8828e69161c579"},{"line_number":18,"context_line":"Co-authored-by: Ryan Hallisey \u003crhallise@redhat.com\u003e"},{"line_number":19,"context_line":"Partially-implements: blueprint api-interface-bind-address-override"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a8bc5a2_a407041b","line":16,"updated":"2016-09-23 06:17:10.000000000","message":"please remove \u003e\u003e character","commit_id":"4693bc8c776f7497f5ebaf13e77b20da4a7aebd7"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"931a98c557809d68a2651f50d44468d88a56d8b0","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"{% if nova_console \u003d\u003d \u0027novnc\u0027 %}"},{"line_number":69,"context_line":"[vnc]"},{"line_number":70,"context_line":"novncproxy_host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":71,"context_line":"novncproxy_port \u003d {{ nova_novncproxy_port }}"},{"line_number":72,"context_line":"vncserver_listen \u003d {{ api_interface_address }}"},{"line_number":73,"context_line":"vncserver_proxyclient_address \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_7804bf14","line":70,"updated":"2016-08-09 02:37:43.000000000","message":"shouldn\u0027t this be fixed?","commit_id":"f4ea57a0c28eedf5633000040da30c9d26e74f15"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"931a98c557809d68a2651f50d44468d88a56d8b0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"novncproxy_host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":71,"context_line":"novncproxy_port \u003d {{ nova_novncproxy_port }}"},{"line_number":72,"context_line":"vncserver_listen \u003d {{ api_interface_address }}"},{"line_number":73,"context_line":"vncserver_proxyclient_address \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":74,"context_line":"{% if inventory_hostname in groups[\u0027compute\u0027] %}"},{"line_number":75,"context_line":"novncproxy_base_url \u003d {{ public_protocol }}://{{ kolla_external_fqdn }}:{{ nova_novncproxy_port }}/vnc_auto.html"},{"line_number":76,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_d8096b2e","line":73,"updated":"2016-08-09 02:37:43.000000000","message":"and this.","commit_id":"f4ea57a0c28eedf5633000040da30c9d26e74f15"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"931a98c557809d68a2651f50d44468d88a56d8b0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"[spice]"},{"line_number":82,"context_line":"enabled \u003d true"},{"line_number":83,"context_line":"server_listen \u003d {{ api_interface_address }}"},{"line_number":84,"context_line":"server_proxyclient_address \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":85,"context_line":"{% if inventory_hostname in groups[\u0027compute\u0027] %}"},{"line_number":86,"context_line":"html5proxy_base_url \u003d {{ public_protocol }}://{{ kolla_external_fqdn }}:{{ nova_spicehtml5proxy_port }}/spice_auto.html"},{"line_number":87,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_b80e3732","line":84,"updated":"2016-08-09 02:37:43.000000000","message":"ditto","commit_id":"f4ea57a0c28eedf5633000040da30c9d26e74f15"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"931a98c557809d68a2651f50d44468d88a56d8b0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"{% if inventory_hostname in groups[\u0027compute\u0027] %}"},{"line_number":86,"context_line":"html5proxy_base_url \u003d {{ public_protocol }}://{{ kolla_external_fqdn }}:{{ nova_spicehtml5proxy_port }}/spice_auto.html"},{"line_number":87,"context_line":"{% endif %}"},{"line_number":88,"context_line":"html5proxy_host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":89,"context_line":"html5proxy_port \u003d {{ nova_spicehtml5proxy_port }}"},{"line_number":90,"context_line":"{% endif %}"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_1814a342","line":88,"updated":"2016-08-09 02:37:43.000000000","message":"ditto","commit_id":"f4ea57a0c28eedf5633000040da30c9d26e74f15"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"931a98c557809d68a2651f50d44468d88a56d8b0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"For Kolla-Kubernetes,  it is necessary to define the memcached_servers"},{"line_number":184,"context_line":"variable in globals.yml to set it to the Kubernetes service for memcached. #}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"{% if memcached_servers is defined %}"},{"line_number":187,"context_line":"memcache_servers \u003d {{ memcached_servers }}"},{"line_number":188,"context_line":"{% else %}"},{"line_number":189,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_f810af50","line":186,"updated":"2016-08-09 02:37:43.000000000","message":"shouldn\u0027t we reuse the orchestration_engine variable here? rather than use the xxx is defined logical.","commit_id":"f4ea57a0c28eedf5633000040da30c9d26e74f15"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"931a98c557809d68a2651f50d44468d88a56d8b0","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"[libvirt]"},{"line_number":194,"context_line":"connection_uri \u003d \"qemu+tcp://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}/system\""},{"line_number":195,"context_line":"{% if enable_ceph | bool and nova_backend \u003d\u003d \"rbd\" %}"},{"line_number":196,"context_line":"images_type \u003d rbd"},{"line_number":197,"context_line":"images_rbd_pool \u003d {{ ceph_nova_pool_name }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_581e1b64","line":194,"updated":"2016-08-09 02:37:43.000000000","message":"ditto","commit_id":"f4ea57a0c28eedf5633000040da30c9d26e74f15"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4bde271b61a9853bd4c20d62052ec7ba922d196f","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"{% if nova_console \u003d\u003d \u0027novnc\u0027 %}"},{"line_number":69,"context_line":"[vnc]"},{"line_number":70,"context_line":"novncproxy_host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":71,"context_line":"novncproxy_port \u003d {{ nova_novncproxy_port }}"},{"line_number":72,"context_line":"vncserver_listen \u003d {{ api_interface_address }}"},{"line_number":73,"context_line":"vncserver_proxyclient_address \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3ac371cc_41dbf5ed","line":70,"updated":"2016-08-14 16:06:23.000000000","message":"there are lots of the api_interface left, shoudn\u0027t it be fixed?","commit_id":"4693bc8c776f7497f5ebaf13e77b20da4a7aebd7"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4bde271b61a9853bd4c20d62052ec7ba922d196f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"[spice]"},{"line_number":82,"context_line":"enabled \u003d true"},{"line_number":83,"context_line":"server_listen \u003d {{ api_interface_address }}"},{"line_number":84,"context_line":"server_proxyclient_address \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":85,"context_line":"{% if inventory_hostname in groups[\u0027compute\u0027] %}"},{"line_number":86,"context_line":"html5proxy_base_url \u003d {{ public_protocol }}://{{ kolla_external_fqdn }}:{{ nova_spicehtml5proxy_port }}/spice_auto.html"},{"line_number":87,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3ac371cc_21d879ef","line":84,"updated":"2016-08-14 16:06:23.000000000","message":"ditto","commit_id":"4693bc8c776f7497f5ebaf13e77b20da4a7aebd7"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"255150d0d586dc8b68e9494807282285ead12cbd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"[spice]"},{"line_number":82,"context_line":"enabled \u003d true"},{"line_number":83,"context_line":"server_listen \u003d {{ api_interface_address }}"},{"line_number":84,"context_line":"server_proxyclient_address \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":85,"context_line":"{% if inventory_hostname in groups[\u0027compute\u0027] %}"},{"line_number":86,"context_line":"html5proxy_base_url \u003d {{ public_protocol }}://{{ kolla_external_fqdn }}:{{ nova_spicehtml5proxy_port }}/spice_auto.html"},{"line_number":87,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a89bdaa_9d4ce043","line":84,"in_reply_to":"3ac371cc_21d879ef","updated":"2016-09-06 19:58:01.000000000","message":"these will be replaced when there are services created for them.  Currently they can be left this way.","commit_id":"4693bc8c776f7497f5ebaf13e77b20da4a7aebd7"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4bde271b61a9853bd4c20d62052ec7ba922d196f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"{% if inventory_hostname in groups[\u0027compute\u0027] %}"},{"line_number":86,"context_line":"html5proxy_base_url \u003d {{ public_protocol }}://{{ kolla_external_fqdn }}:{{ nova_spicehtml5proxy_port }}/spice_auto.html"},{"line_number":87,"context_line":"{% endif %}"},{"line_number":88,"context_line":"html5proxy_host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":89,"context_line":"html5proxy_port \u003d {{ nova_spicehtml5proxy_port }}"},{"line_number":90,"context_line":"{% endif %}"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3ac371cc_81e5eda9","line":88,"updated":"2016-08-14 16:06:23.000000000","message":"ditto","commit_id":"4693bc8c776f7497f5ebaf13e77b20da4a7aebd7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"440b1b6c2fd50ca7d33928c6ec35ffa4e4cec07f","unresolved":false,"context_lines":[{"line_number":156,"context_line":"backend \u003d oslo_cache.memcache_pool"},{"line_number":157,"context_line":"enabled \u003d True"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"{% if orchestration_engine \u003d\u003d \u0027KUBERNETES\u0027 %}"},{"line_number":160,"context_line":"memcache_servers \u003d {{ memcached_servers }}"},{"line_number":161,"context_line":"{% else %}"},{"line_number":162,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":163,"context_line":"{%- endif %}"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"[keystone_authtoken]"},{"line_number":166,"context_line":"auth_uri \u003d {{ keystone_public_url }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_7ad36e60","line":163,"range":{"start_line":159,"start_character":0,"end_line":163,"end_character":12},"updated":"2016-08-11 16:15:42.000000000","message":"should this not be part of the previous memcached change or was that for keystone only?\n\nare there other services that will need this change?","commit_id":"4693bc8c776f7497f5ebaf13e77b20da4a7aebd7"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"255150d0d586dc8b68e9494807282285ead12cbd","unresolved":false,"context_lines":[{"line_number":156,"context_line":"backend \u003d oslo_cache.memcache_pool"},{"line_number":157,"context_line":"enabled \u003d True"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"{% if orchestration_engine \u003d\u003d \u0027KUBERNETES\u0027 %}"},{"line_number":160,"context_line":"memcache_servers \u003d {{ memcached_servers }}"},{"line_number":161,"context_line":"{% else %}"},{"line_number":162,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":163,"context_line":"{%- endif %}"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"[keystone_authtoken]"},{"line_number":166,"context_line":"auth_uri \u003d {{ keystone_public_url }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a89bdaa_fdffaca7","line":163,"range":{"start_line":159,"start_character":0,"end_line":163,"end_character":12},"in_reply_to":"9ad45d7e_7ad36e60","updated":"2016-09-06 19:58:01.000000000","message":"they other services that need it have this change","commit_id":"4693bc8c776f7497f5ebaf13e77b20da4a7aebd7"}]}