)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"8f7fd279ae14623c0ebe52bb9786ff1e6cd2671f","unresolved":false,"context_lines":[{"line_number":233,"context_line":"enable_swift: \"no\""},{"line_number":234,"context_line":"enable_tempest: \"no\""},{"line_number":235,"context_line":"enable_watcher: \"no\""},{"line_number":236,"context_line":"enable_neutron_networking_sfc_agent: \"no\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"ironic_keystone_user: \"ironic\""},{"line_number":239,"context_line":"neutron_keystone_user: \"neutron\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a89bdaa_0f574cca","line":236,"updated":"2016-09-08 13:40:11.000000000","message":"can you alphabetize this please?","commit_id":"51886396a1e5c63ef555111474bd1fcf6e970522"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"72c312d4dc065138e7966771cdbe4cc01c91889e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"bifrost_network_interface: \"{{ network_interface }}\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Valid options are [ openvswitch, linuxbridge, networking-sfc ]"},{"line_number":114,"context_line":"neutron_plugin_agent: \"openvswitch\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# The default ports used by each service."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7a8ec9b2_8fac17ef","line":113,"updated":"2016-09-14 00:54:47.000000000","message":"how about just calling it sfc.  Clearly it is networking related.","commit_id":"8df4da2e32f7142eb62eebc3947e45ebcfbdef16"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":143,"context_line":"[neutron-metadata-agent:children]"},{"line_number":144,"context_line":"neutron"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"[neutron-networking-sfc-agent:children]"},{"line_number":147,"context_line":"neutron"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Cinder"},{"line_number":150,"context_line":"[cinder-api:children]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dada55a8_fdcc9d36","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":7},"updated":"2016-07-26 21:49:16.000000000","message":"i don\u0027t think this should be needed as the networking-sfc-agent is a replacement for the normal neutron ovs agent so when you change the image name it will be deployed wherever the neutron ovs agent would have been deployed.\n\ncreating a separate group would allow the deployer to create an invalid configuration where you have a mix of some host using the sfc agent and some using the standard agent.\n\nif a vm is added to a chain but scheduled to a node with the standard agent the service chain config will never be applied on that node and the chain will be broken.\n\nthis would be a silent failure as the standard agent will never pull the rpc message from the message bus.\n\nthis could technically be worked around by creating a host aggregate for sfc capable hosts and a host aggregate for normal host but that relies entirely on the operator doing the right thing and is not discoverable by the tenant from the api. so i would stronly discourage allow the operator this flexablity in this case.","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"}],"ansible/inventory/multinode":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":155,"context_line":"[neutron-metadata-agent:children]"},{"line_number":156,"context_line":"neutron"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"[neutron-networking-sfc-agent:children]"},{"line_number":159,"context_line":"neutron"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# Cinder"},{"line_number":162,"context_line":"[cinder-api:children]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dada55a8_dde2799f","line":159,"range":{"start_line":158,"start_character":0,"end_line":159,"end_character":7},"updated":"2016-07-26 21:49:16.000000000","message":"see comment in all-in-one inventroy","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":39,"context_line":"neutron_openvswitch_agent_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-neutron-openvswitch-agent\""},{"line_number":40,"context_line":"neutron_openvswitch_agent_tag: \"{{ openstack_release }}\""},{"line_number":41,"context_line":"neutron_openvswitch_agent_image_full: \"{{ neutron_openvswitch_agent_image }}:{{ neutron_openvswitch_agent_tag }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"neutron_server_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-neutron-server\""},{"line_number":44,"context_line":"neutron_server_tag: \"{{ openstack_release }}\""},{"line_number":45,"context_line":"neutron_server_image_full: \"{{ neutron_server_image }}:{{ neutron_server_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_98976f8f","line":42,"updated":"2016-07-26 21:49:16.000000000","message":"when not enable_neutron_networking_sfc\nneutron_openvswitch_agent_image_full: \"{{ neutron_networking_sfc_agent_image_full }}\"\nwhen enable_neutron_networking_sfc\n\nnot sure if that systax is vaild\nbut basically you chould cange the image name if \nenable_neutron_networking_sfc is true.","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"8f7fd279ae14623c0ebe52bb9786ff1e6cd2671f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"neutron_openvswitch_agent_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-neutron-openvswitch-agent\""},{"line_number":36,"context_line":"neutron_openvswitch_agent_tag: \"{{ openstack_release }}\""},{"line_number":37,"context_line":"neutron_openvswitch_agent_image_full: \"{{ neutron_openvswitch_agent_image }}:{{ neutron_openvswitch_agent_tag }}\""},{"line_number":38,"context_line":"when:"},{"line_number":39,"context_line":"  - not enable_neutron_networking_sfc_agent | bool"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"neutron_networking_sfc_agent_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-neutron-networking-sfc-agent\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a89bdaa_ef3ce894","line":38,"updated":"2016-09-08 13:40:11.000000000","message":"when statements in main.yml are unnecessary","commit_id":"51886396a1e5c63ef555111474bd1fcf6e970522"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5aba8dd1e94cd52cbd76faaf9b2762ba787121ea","unresolved":false,"context_lines":[{"line_number":36,"context_line":"neutron_openvswitch_agent_tag: \"{{ openstack_release }}\""},{"line_number":37,"context_line":"neutron_openvswitch_agent_image_full: \"{{ neutron_openvswitch_agent_image }}:{{ neutron_openvswitch_agent_tag }}\""},{"line_number":38,"context_line":"when:"},{"line_number":39,"context_line":"  - not enable_neutron_networking_sfc_agent | bool"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"neutron_networking_sfc_agent_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-neutron-networking-sfc-agent\""},{"line_number":42,"context_line":"neutron_networking_sfc_agent_tag: \"{{ openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a89bdaa_ebcd0531","line":39,"updated":"2016-09-13 04:01:55.000000000","message":"this is bad. when clause won\u0027t work in defaults/main.yml file. And this breaked the gate.","commit_id":"398d12e6eb2fcca08f65ed5f4c616a384ecf58e5"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"72c312d4dc065138e7966771cdbe4cc01c91889e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"neutron_networking_sfc_agent_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-neutron-networking-sfc-agent\""},{"line_number":40,"context_line":"neutron_networking_sfc_agent_tag: \"{{ openstack_release }}\""},{"line_number":41,"context_line":"neutron_openvswitch_agent_image_full: \"{{ neutron_networking_sfc_agent_image }}:{{ neutron_networking_sfc_agent_tag }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"neutron_server_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-neutron-server\""},{"line_number":44,"context_line":"neutron_server_tag: \"{{ openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7a8ec9b2_ef811b4f","line":41,"updated":"2016-09-14 00:54:47.000000000","message":"this should be neutron_networking_sfc_agent_image_full","commit_id":"8df4da2e32f7142eb62eebc3947e45ebcfbdef16"}],"ansible/roles/neutron/tasks/bootstrap_service.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  run_once: True"},{"line_number":43,"context_line":"  delegate_to: \"{{ groups[\u0027neutron-lbaas-agent\u0027][0] }}\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Running Neutron networking sfc bootstrap container"},{"line_number":46,"context_line":"  kolla_docker:"},{"line_number":47,"context_line":"    action: \"start_container\""},{"line_number":48,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":49,"context_line":"    detach: False"},{"line_number":50,"context_line":"    environment:"},{"line_number":51,"context_line":"      KOLLA_BOOTSTRAP:"},{"line_number":52,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":53,"context_line":"    image: \"{{ neutron_networking_sfc_agent_image_full }}\""},{"line_number":54,"context_line":"    labels:"},{"line_number":55,"context_line":"      BOOTSTRAP:"},{"line_number":56,"context_line":"    name: \"bootstrap_neutron_networking-sfc_agent\""},{"line_number":57,"context_line":"    restart_policy: \"never\""},{"line_number":58,"context_line":"    volumes:"},{"line_number":59,"context_line":"      - \"{{ node_config_directory }}/neutron-networking-sfc-agent/:{{ container_config_directory }}/:ro\""},{"line_number":60,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":61,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":62,"context_line":"  when:"},{"line_number":63,"context_line":"    - enable_neutron_networking_sfc | bool"},{"line_number":64,"context_line":"    - inventory_hostname in groups[\u0027neutron-networking-sfc-agent\u0027]"},{"line_number":65,"context_line":"  run_once: True"},{"line_number":66,"context_line":"  delegate_to: \"{{ groups[\u0027neutron-networking-sfc-agent\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_1d325110","line":66,"range":{"start_line":45,"start_character":0,"end_line":66,"end_character":64},"updated":"2016-07-26 21:49:16.000000000","message":"this is not needed if you change then name of the \nneutron_server_image_full to be  neutron_networking_sfc_agent_image_full\nif enable_neutron_networking_sfc is yes.","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"}],"ansible/roles/neutron/tasks/config.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    - \"openvswitch-db-server\""},{"line_number":25,"context_line":"    - \"openvswitch-vswitchd\""},{"line_number":26,"context_line":"    - \"neutron-lbaas-agent\""},{"line_number":27,"context_line":"    - \"neutron-networking-sfc-agent\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Copying over config.json files for services"},{"line_number":30,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_4a3385f6","line":27,"range":{"start_line":27,"start_character":3,"end_line":27,"end_character":36},"updated":"2016-07-29 21:38:11.000000000","message":"the networking-sfc agent uses the same configs as the standard neutron openvswitch agent so im not sure this is needed  same with the rest of the changes in this file.","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"}],"ansible/roles/neutron/tasks/deploy.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":14,"context_line":"        or inventory_hostname in groups[\u0027neutron-server\u0027]"},{"line_number":15,"context_line":"        or inventory_hostname in groups[\u0027neutron-lbaas-agent\u0027]"},{"line_number":16,"context_line":"        or inventory_hostname in groups[\u0027neutron-networking-sfc-agent\u0027]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- include: config-neutron-fake.yml"},{"line_number":19,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_586a17ee","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":71},"updated":"2016-07-26 21:49:16.000000000","message":"new group is not need","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":32,"context_line":"        or inventory_hostname in groups[\u0027neutron-server\u0027]"},{"line_number":33,"context_line":"        or inventory_hostname in groups[\u0027neutron-lbaas-agent\u0027]"},{"line_number":34,"context_line":"        or inventory_hostname in groups[\u0027neutron-networking-sfc-agent\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_d87e07ae","line":34,"range":{"start_line":34,"start_character":7,"end_line":34,"end_character":71},"updated":"2016-07-26 21:49:16.000000000","message":"same as above","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"}],"ansible/roles/neutron/tasks/do_reconfigure.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":15,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":16,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":17,"context_line":"    - { name: neutron_networking-sfc_agent, group: neutron-networking-sfc-agent, enabled: \"{{ enable_neutron_networking_sfc | bool }}\" }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Ensuring the neutron_openvswitch_agent container is up"},{"line_number":20,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_f8366b01","line":17,"range":{"start_line":17,"start_character":44,"end_line":17,"end_character":79},"updated":"2016-07-26 21:49:16.000000000","message":"new group is not need","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":31,"context_line":"          or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":32,"context_line":"          or inventory_hostname in groups[\u0027neutron-lbaas-agent\u0027]"},{"line_number":33,"context_line":"          or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":34,"context_line":"          or inventory_hostname in groups[\u0027neutron-networking-sfc-agent\u0027]"},{"line_number":35,"context_line":"          and not enable_nova_fake | bool"},{"line_number":36,"context_line":"        ) or"},{"line_number":37,"context_line":"        ( inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_383da3dd","line":34,"range":{"start_line":34,"start_character":10,"end_line":34,"end_character":73},"updated":"2016-07-26 21:49:16.000000000","message":"new group is not need","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":39,"context_line":"          or inventory_hostname in groups[\u0027neutron-lbaas-agent\u0027]"},{"line_number":40,"context_line":"          or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":41,"context_line":"          or inventory_hostname in groups[\u0027neutron-networking-sfc-agent\u0027]"},{"line_number":42,"context_line":"          and enable_nova_fake | bool"},{"line_number":43,"context_line":"        )"},{"line_number":44,"context_line":"      )"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_78239bbd","line":41,"range":{"start_line":41,"start_character":9,"end_line":41,"end_character":73},"updated":"2016-07-26 21:49:16.000000000","message":"same as above","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":75,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":76,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":77,"context_line":"    - { name: neutron_networking-sfc_agent, group: neutron-networking-sfc-agent, enabled: \"{{ enable_neutron_networking_sfc | bool }}\" }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"- name: Check the configs in the neutron_openvswitch_agent container"},{"line_number":80,"context_line":"  command: docker exec neutron_openvswitch_agent /usr/local/bin/kolla_set_configs --check"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_980daf40","line":77,"range":{"start_line":77,"start_character":44,"end_line":77,"end_character":79},"updated":"2016-07-26 21:49:16.000000000","message":"new group is not need\nsame for other instances below","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":15,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":16,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":17,"context_line":"    - { name: neutron_networking-sfc_agent, enabled: \"{{ enable_neutron_networking_sfc | bool }}\" }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Ensuring the neutron_openvswitch_agent container is up"},{"line_number":20,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_8470d3dd","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":99},"updated":"2016-07-29 21:38:11.000000000","message":"this is not needed.\nthe agent will be started by lines 19-42 below on all the hosts it should run on","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":73,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":74,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":75,"context_line":"    - { name: neutron_networking-sfc_agent, enabled: \"{{ enable_neutron_networking_sfc | bool }}\" }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Check the configs in the neutron_openvswitch_agent container"},{"line_number":78,"context_line":"  command: docker exec neutron_openvswitch_agent /usr/local/bin/kolla_set_configs --check"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_a4423766","line":75,"range":{"start_line":75,"start_character":3,"end_line":75,"end_character":99},"updated":"2016-07-29 21:38:11.000000000","message":"not needed","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"2949c9ebef8d30f6f445a769902979882069cfcf","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":73,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":74,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":75,"context_line":"    - { name: neutron_networking-sfc_agent, enabled: \"{{ enable_neutron_networking_sfc | bool }}\" }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Check the configs in the neutron_openvswitch_agent container"},{"line_number":78,"context_line":"  command: docker exec neutron_openvswitch_agent /usr/local/bin/kolla_set_configs --check"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_c07d5b6e","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":42},"updated":"2016-08-05 16:54:03.000000000","message":"not needed","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":130,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":131,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":132,"context_line":"    - { name: neutron_networking-sfc_agent, enable: \"{{ enable_neutron_networking_sfc | bool }}\" }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- name: Container config strategy for the neutron_openvswitch_agent container"},{"line_number":135,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_0454e31e","line":132,"range":{"start_line":132,"start_character":2,"end_line":132,"end_character":98},"updated":"2016-07-29 21:38:11.000000000","message":"not needed","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"2949c9ebef8d30f6f445a769902979882069cfcf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":130,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":131,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":132,"context_line":"    - { name: neutron_networking-sfc_agent, enable: \"{{ enable_neutron_networking_sfc | bool }}\" }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- name: Container config strategy for the neutron_openvswitch_agent container"},{"line_number":135,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_2099d7c4","line":132,"range":{"start_line":132,"start_character":2,"end_line":132,"end_character":98},"in_reply_to":"bacf61ea_0454e31e","updated":"2016-08-05 16:54:03.000000000","message":"Done","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[{"line_number":184,"context_line":"       { name: neutron_dhcp_agent, group: neutron-dhcp-agent },"},{"line_number":185,"context_line":"       { name: neutron_l3_agent, group: neutron-l3-agent },"},{"line_number":186,"context_line":"       { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" },"},{"line_number":187,"context_line":"       { name: neutron_networking-sfc_agent, enabled: \"{{ enable_neutron_networking_sfc | bool }}\" },"},{"line_number":188,"context_line":"       { name: neutron_metadata_agent, group: neutron-metadata-agent }]"},{"line_number":189,"context_line":"    - neutron_container_envs.results"},{"line_number":190,"context_line":"    - neutron_check_results.results"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_e4270fc8","line":187,"range":{"start_line":187,"start_character":7,"end_line":187,"end_character":101},"updated":"2016-07-29 21:38:11.000000000","message":"not needed\n\nthe plugin runs as part of the server so it will be removed when the neutron_server container is and the agent runs in place of the normal openvswitch agent so it will be removed by lines 192-216 below.","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[{"line_number":251,"context_line":"       { name: neutron_dhcp_agent, group: neutron-dhcp-agent },"},{"line_number":252,"context_line":"       { name: neutron_l3_agent, group: neutron-l3-agent },"},{"line_number":253,"context_line":"       { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" },"},{"line_number":254,"context_line":"       { name: neutron_networking-sfc_agent, enabled: \"{{ enable_neutron_networking_sfc | bool }}\" },"},{"line_number":255,"context_line":"       { name: neutron_metadata_agent, group: neutron-metadata-agent }]"},{"line_number":256,"context_line":"    - neutron_container_envs.results"},{"line_number":257,"context_line":"    - neutron_check_results.results"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_8a01fd07","line":254,"range":{"start_line":254,"start_character":6,"end_line":254,"end_character":101},"updated":"2016-07-29 21:38:11.000000000","message":"not needed","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"2949c9ebef8d30f6f445a769902979882069cfcf","unresolved":false,"context_lines":[{"line_number":251,"context_line":"       { name: neutron_dhcp_agent, group: neutron-dhcp-agent },"},{"line_number":252,"context_line":"       { name: neutron_l3_agent, group: neutron-l3-agent },"},{"line_number":253,"context_line":"       { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" },"},{"line_number":254,"context_line":"       { name: neutron_networking-sfc_agent, enabled: \"{{ enable_neutron_networking_sfc | bool }}\" },"},{"line_number":255,"context_line":"       { name: neutron_metadata_agent, group: neutron-metadata-agent }]"},{"line_number":256,"context_line":"    - neutron_container_envs.results"},{"line_number":257,"context_line":"    - neutron_check_results.results"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bacf61ea_20c71797","line":254,"range":{"start_line":254,"start_character":6,"end_line":254,"end_character":101},"in_reply_to":"bacf61ea_8a01fd07","updated":"2016-08-05 16:54:03.000000000","message":"Done","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"}],"ansible/roles/neutron/tasks/reconfigure.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        or inventory_hostname in groups[\u0027neutron-l3-agent\u0027]"},{"line_number":9,"context_line":"        or inventory_hostname in groups[\u0027neutron-lbaas-agent\u0027]"},{"line_number":10,"context_line":"        or inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":11,"context_line":"        or inventory_hostname in groups[\u0027neutron-networking-networking-sfc-agent\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_b8c23351","line":11,"range":{"start_line":11,"start_character":7,"end_line":11,"end_character":82},"updated":"2016-07-26 21:49:16.000000000","message":"again a new group is not a good idea here.","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"}],"ansible/roles/neutron/tasks/start.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":219,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":220,"context_line":"  when:"},{"line_number":221,"context_line":"    - enable_neutron_networking_sfc | bool"},{"line_number":222,"context_line":"    - inventory_hostname in groups[\u0027neutron-networking-sfc-agent\u0027]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"- name: Starting neutron-metadata-agent container"},{"line_number":225,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_0c006000","line":222,"range":{"start_line":222,"start_character":2,"end_line":222,"end_character":66},"updated":"2016-07-26 21:49:16.000000000","message":"new group is not need","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    - enable_neutron_lbaas | bool"},{"line_number":205,"context_line":"    - inventory_hostname in groups[\u0027neutron-lbaas-agent\u0027]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"- name: Starting neutron-networking-sfc-agent container"},{"line_number":208,"context_line":"  kolla_docker:"},{"line_number":209,"context_line":"    action: \"start_container\""},{"line_number":210,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":211,"context_line":"    image: \"{{ neutron_networking_sfc_agent_image_full }}\""},{"line_number":212,"context_line":"    name: \"neutron_networking_sfc_agent\""},{"line_number":213,"context_line":"    privileged: True"},{"line_number":214,"context_line":"    volumes:"},{"line_number":215,"context_line":"      - \"{{ node_config_directory }}/neutron-networking-sfc-agent/:{{ container_config_directory }}/:ro\""},{"line_number":216,"context_line":"      - \"/run:/run\""},{"line_number":217,"context_line":"      - \"/run/netns/:/run/netns/:shared\""},{"line_number":218,"context_line":"      - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":219,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":220,"context_line":"  when:"},{"line_number":221,"context_line":"    - enable_neutron_networking_sfc | bool"},{"line_number":222,"context_line":"    - inventory_hostname in groups[\u0027neutron-networking-sfc-agent\u0027]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"- name: Starting neutron-metadata-agent container"},{"line_number":225,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_ec522c12","line":222,"range":{"start_line":207,"start_character":0,"end_line":222,"end_character":66},"updated":"2016-07-26 21:49:16.000000000","message":"this is not need as the the sfc agent will be lauched inplace of the standard agent above.\n\nalso as written this would result in to copies fo the ovs neutron agent running on the plathform. the standard version and the sfc version.","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"72c312d4dc065138e7966771cdbe4cc01c91889e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"          and enable_nova_fake | bool"},{"line_number":138,"context_line":"        )"},{"line_number":139,"context_line":"      )"},{"line_number":140,"context_line":"    - neutron_plugin_agent \u003d\u003d \"networking-sfc\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- name: Starting neutron-openvswitch-agent container for fake nova compute"},{"line_number":143,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7a8ec9b2_6f96eb95","line":140,"updated":"2016-09-14 00:54:47.000000000","message":"i\u0027d prefer networking-sfc change to sfc","commit_id":"8df4da2e32f7142eb62eebc3947e45ebcfbdef16"}],"ansible/roles/neutron/tasks/upgrade.yml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dada55a8_4c5418fd","updated":"2016-07-26 21:49:16.000000000","message":"new group is not need","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"}],"ansible/roles/neutron/templates/neutron-networking-sfc-agent.json.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bacf61ea_eaaeb9e4","updated":"2016-07-29 21:38:11.000000000","message":"I do not think this is ever used it\u0027s also an exact copy of the neutron-openvswitch-agent templates as the sfc agent is just a fork that inherits from the neutron ovs agent.","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"2949c9ebef8d30f6f445a769902979882069cfcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bacf61ea_2098b777","in_reply_to":"bacf61ea_eaaeb9e4","updated":"2016-08-05 16:54:03.000000000","message":"if this is a plug-in, i think this file does not need to exist","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d147faa1507ced0afba0deabb3be92d6beff8f32","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"allow_overlapping_ips \u003d true"},{"line_number":34,"context_line":"core_plugin \u003d ml2"},{"line_number":35,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}{% if enable_neutron_networking_sfc | bool %},networking_sfc.services.flowclassifier.plugin.FlowClassifierPlugin,networking_sfc.services.sfc.plugin.SfcPlugin{% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":38,"context_line":"[service_providers]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dada55a8_6c663cee","line":35,"updated":"2016-07-26 21:49:16.000000000","message":"nit: it might better to generate this with a macros but its fine as it is for now.","commit_id":"97596682235ed8a1ad52f6f47f1d65567b80e75a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"allow_overlapping_ips \u003d true"},{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"servive_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}{% if enable_neutron_networking_sfc | bool %},networking_sfc.services.flowclassifier.plugin.FlowClassifierPlugin,networking_sfc.services.sfc.plugin.SfcPlugin{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":41,"context_line":"[service_providers]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_048fc3cc","line":38,"range":{"start_line":38,"start_character":230,"end_line":38,"end_character":341},"updated":"2016-07-29 21:38:11.000000000","message":"flow_classifier,sfc\n\nyou should use the alias, not the fully qualified class name.","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"allow_overlapping_ips \u003d true"},{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"servive_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}{% if enable_neutron_networking_sfc | bool %},networking_sfc.services.flowclassifier.plugin.FlowClassifierPlugin,networking_sfc.services.sfc.plugin.SfcPlugin{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":41,"context_line":"[service_providers]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_04734316","line":38,"range":{"start_line":38,"start_character":61,"end_line":38,"end_character":124},"updated":"2016-07-29 21:38:11.000000000","message":"lbaas","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5d995ce331c59967a95c14cd1eb0f84a12c3120","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"allow_overlapping_ips \u003d true"},{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"servive_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}{% if enable_neutron_networking_sfc | bool %},networking_sfc.services.flowclassifier.plugin.FlowClassifierPlugin,networking_sfc.services.sfc.plugin.SfcPlugin{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":41,"context_line":"[service_providers]"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_44809bc0","line":38,"range":{"start_line":38,"start_character":5,"end_line":38,"end_character":6},"updated":"2016-07-29 21:38:11.000000000","message":"service","commit_id":"183eb2fcbae8ba59887a80c54600dd55cb20f8f6"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f040a9ed23a0d6d397a0c5e84468e7a413b41c9e","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"allow_overlapping_ips \u003d true"},{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},lbaas{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}{% if enable_neutron_networking_sfc_agent | bool %},flow_classifier,sfc{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"9a89bdaa_a6e23d9e","line":38,"updated":"2016-09-13 12:02:39.000000000","message":"there is not enable_neutron_networking_sfc_agent variable now.","commit_id":"6d14bf93701a97cba50a0ef802024a7ca74cdfe5"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f040a9ed23a0d6d397a0c5e84468e7a413b41c9e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"driver \u003d noop"},{"line_number":102,"context_line":"{% endif %}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"{% if enable_neutron_networking_sfc_agent | bool %}"},{"line_number":105,"context_line":"[sfc]"},{"line_number":106,"context_line":"drivers \u003d ovs"},{"line_number":107,"context_line":"[flowclassifier]"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"9a89bdaa_46d331d5","line":104,"updated":"2016-09-13 12:02:39.000000000","message":"there is not enable_neutron_networking_sfc_agent variable now.","commit_id":"6d14bf93701a97cba50a0ef802024a7ca74cdfe5"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ec02fe4f71583d33c3f414468323b8c949cf32e4","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"allow_overlapping_ips \u003d true"},{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},lbaas{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %},flow_classifier,sfc"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"7a8ec9b2_783033e9","line":38,"updated":"2016-09-14 21:45:57.000000000","message":"still need if condition, see below.","commit_id":"8df4da2e32f7142eb62eebc3947e45ebcfbdef16"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"72c312d4dc065138e7966771cdbe4cc01c91889e","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"allow_overlapping_ips \u003d true"},{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},lbaas{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %},flow_classifier,sfc"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"7a8ec9b2_afe7133f","line":38,"updated":"2016-09-14 00:54:47.000000000","message":"this change is unrelated to this patch set and should be a different patch.  If it is related, then it should be conditional on sfc a an agent type.","commit_id":"8df4da2e32f7142eb62eebc3947e45ebcfbdef16"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ec02fe4f71583d33c3f414468323b8c949cf32e4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"driver \u003d noop"},{"line_number":102,"context_line":"{% endif %}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[sfc]"},{"line_number":105,"context_line":"drivers \u003d ovs"},{"line_number":106,"context_line":"[flowclassifier]"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"7a8ec9b2_984dff74","line":104,"updated":"2016-09-14 21:45:57.000000000","message":"still need if condition \n\n{% if neutron_plugin_agent \u003d\u003d \u0027networking-sfc\u0027 %}\n[sfc]\nxxx\n{% endif %}","commit_id":"8df4da2e32f7142eb62eebc3947e45ebcfbdef16"}],"releasenotes/notes/add-networking-sfc-62ae433ed7aa4e33.yaml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"72c312d4dc065138e7966771cdbe4cc01c91889e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add networking-sfc support."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7a8ec9b2_0fd56742","line":3,"updated":"2016-09-14 00:54:47.000000000","message":"A little more detail about what sfc is would be helpful.","commit_id":"8df4da2e32f7142eb62eebc3947e45ebcfbdef16"}]}