)]}'
{"docker/heka/Dockerfile.j2":[{"author":{"_account_id":15388,"name":"Abe Music","email":"abe.music@gmail.com","username":"abemusic"},"change_message_id":"cbd37bed64597b50be57dad15d2c4f09e5cebf59","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb\u0027]"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN {{ macros.install_packages(heat_engine_packages | customizable(\"packages\")) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"COPY plugins/modules /usr/share/heka/lua_modules/"},{"line_number":15,"context_line":"COPY plugins/decoders /usr/share/heka/lua_decoders/"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dada55a8_30a6b253","line":12,"range":{"start_line":12,"start_character":31,"end_line":12,"end_character":51},"updated":"2016-07-25 14:37:39.000000000","message":"heka_packages","commit_id":"a6480c4c34c34a251d670a4de020b738bdfa8109"},{"author":{"_account_id":15388,"name":"Abe Music","email":"abe.music@gmail.com","username":"abemusic"},"change_message_id":"2d46384d920432647bbe39b72ca89de3eaedd652","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb\u0027]"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN {{ macros.install_packages(heka_engine_packages | customizable(\"packages\")) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"COPY plugins/modules /usr/share/heka/lua_modules/"},{"line_number":15,"context_line":"COPY plugins/decoders /usr/share/heka/lua_decoders/"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"dada55a8_d335a046","line":12,"range":{"start_line":12,"start_character":31,"end_line":12,"end_character":51},"updated":"2016-07-25 14:50:21.000000000","message":"Need to use the variable declared above \"heka_packages\" (drop the engine part of this)","commit_id":"e957e5e36853aee67784cb3e00e71cb1f04d4f52"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"8232b09c36838f513891a1d1ddc856239485050a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb\u0027]"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN {{ macros.install_packages(heka_engine_packages | customizable(\"packages\")) }}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"COPY plugins/modules /usr/share/heka/lua_modules/"},{"line_number":15,"context_line":"COPY plugins/decoders /usr/share/heka/lua_decoders/"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"dada55a8_3f193f89","line":12,"range":{"start_line":12,"start_character":31,"end_line":12,"end_character":51},"in_reply_to":"dada55a8_d335a046","updated":"2016-07-26 03:27:03.000000000","message":"+1","commit_id":"e957e5e36853aee67784cb3e00e71cb1f04d4f52"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a19acd813d4f92f7ea06398f62b4363836814ca8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm\u0027] %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN {{ macros.install_packages(heka_packages | customizable(\"packages\")) }} \u0026\u0026 useradd --user-group heka \u0026\u0026 mkdir /etc/heka"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_7f977390","line":8,"updated":"2016-07-28 15:33:56.000000000","message":"add a \\ to start a new line for useradd and mkdir","commit_id":"4a3ca5a0169c2dffe4bcea8ba6100ff2858cba5f"},{"author":{"_account_id":17934,"name":"Josh Lothian","email":"josh.lothian@gmail.com","username":"jlothian"},"change_message_id":"3b80bfbf0fd208a662ea7a373080dbc1bdec1f7d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm\u0027] %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN {{ macros.install_packages(heka_packages | customizable(\"packages\")) }} \u0026\u0026 useradd --user-group heka \u0026\u0026 mkdir /etc/heka"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_3fe85bb4","line":8,"in_reply_to":"bacf61ea_7f977390","updated":"2016-07-28 15:41:37.000000000","message":"Done","commit_id":"4a3ca5a0169c2dffe4bcea8ba6100ff2858cba5f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a19acd813d4f92f7ea06398f62b4363836814ca8","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"},{"line_number":12,"context_line":"    \u0026\u0026 dpkg -i heka_0.10.0_amd64.deb \\"},{"line_number":13,"context_line":"    \u0026\u0026 rm -f heka_0.10.0_amd64.deb"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_5f926fa0","line":12,"updated":"2016-07-28 15:33:56.000000000","message":"shouldn\u0027t this can be customized?","commit_id":"4a3ca5a0169c2dffe4bcea8ba6100ff2858cba5f"},{"author":{"_account_id":17934,"name":"Josh Lothian","email":"josh.lothian@gmail.com","username":"jlothian"},"change_message_id":"3b80bfbf0fd208a662ea7a373080dbc1bdec1f7d","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"},{"line_number":12,"context_line":"    \u0026\u0026 dpkg -i heka_0.10.0_amd64.deb \\"},{"line_number":13,"context_line":"    \u0026\u0026 rm -f heka_0.10.0_amd64.deb"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_bf78cbf3","line":12,"in_reply_to":"bacf61ea_5f926fa0","updated":"2016-07-28 15:41:37.000000000","message":"Jeffrey:  as the install_packages macro currently stands, it cannot install packages based on a URL (rather than just a package name) because it\u0027s using apt-get.  Abe has looked at updating the macro to support this, but it ends up looking pretty ugly.","commit_id":"4a3ca5a0169c2dffe4bcea8ba6100ff2858cba5f"},{"author":{"_account_id":15388,"name":"Abe Music","email":"abe.music@gmail.com","username":"abemusic"},"change_message_id":"751142bbadbbdf3653969959e4ba2d694ec30055","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"},{"line_number":12,"context_line":"    \u0026\u0026 dpkg -i heka_0.10.0_amd64.deb \\"},{"line_number":13,"context_line":"    \u0026\u0026 rm -f heka_0.10.0_amd64.deb"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_4a7d8f6d","line":12,"in_reply_to":"bacf61ea_bf78cbf3","updated":"2016-07-28 15:47:40.000000000","message":"I can provide the updates to the macro that supports installing from URL or regular packages...I\u0027m just not sure this review is the right place for it. Would love thoughts on this.","commit_id":"4a3ca5a0169c2dffe4bcea8ba6100ff2858cba5f"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d667f0e8a866d1692f50c1451e91e96e7c0e1fe3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9ad45d7e_15457c16","line":3,"updated":"2016-08-09 10:16:33.000000000","message":"Please add blank line above this","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":17934,"name":"Josh Lothian","email":"josh.lothian@gmail.com","username":"jlothian"},"change_message_id":"9f74e144ab171606b53c6511644172a651aba3e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3ac371cc_88f769f4","line":3,"in_reply_to":"9ad45d7e_15457c16","updated":"2016-08-16 17:26:16.000000000","message":"Done","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"6e612c5a1a4e62b3a96126cd320f0c97d5bbbd5a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm\u0027] %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN {{ macros.install_packages(heka_packages | customizable(\"packages\")) }} \\"},{"line_number":9,"context_line":"    \u0026\u0026 useradd --user-group heka \\"},{"line_number":10,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_35733e4f","line":8,"updated":"2016-07-29 04:11:08.000000000","message":"oh.sorry, i missed following lines. this is correct.","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"bc994716df8abef27cc075a4aca45d0fb42339c8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm\u0027] %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN {{ macros.install_packages(heka_packages | customizable(\"packages\")) }} \\"},{"line_number":9,"context_line":"    \u0026\u0026 useradd --user-group heka \\"},{"line_number":10,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_9f4a27ab","line":8,"updated":"2016-07-28 15:41:51.000000000","message":"this is wrong.","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":17934,"name":"Josh Lothian","email":"josh.lothian@gmail.com","username":"jlothian"},"change_message_id":"9f74e144ab171606b53c6511644172a651aba3e0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm\u0027] %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN {{ macros.install_packages(heka_packages | customizable(\"packages\")) }} \\"},{"line_number":9,"context_line":"    \u0026\u0026 useradd --user-group heka \\"},{"line_number":10,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3ac371cc_e8dedd6b","line":8,"in_reply_to":"9ad45d7e_95e32c33","updated":"2016-08-16 17:26:16.000000000","message":"Done","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d667f0e8a866d1692f50c1451e91e96e7c0e1fe3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm\u0027] %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN {{ macros.install_packages(heka_packages | customizable(\"packages\")) }} \\"},{"line_number":9,"context_line":"    \u0026\u0026 useradd --user-group heka \\"},{"line_number":10,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9ad45d7e_95e32c33","line":8,"in_reply_to":"bacf61ea_35733e4f","updated":"2016-08-09 10:16:33.000000000","message":"I prefer not to combine the macro RUN with other lines. If we want to add blocks to customise the lines below it will have to be broken out again.","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":15388,"name":"Abe Music","email":"abe.music@gmail.com","username":"abemusic"},"change_message_id":"c4f22edabf47c879c0b92d2387a6e19fd3b530d0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"    {% set heka_packages \u003d [\u0027https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm\u0027] %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"RUN {{ macros.install_packages(heka_packages | customizable(\"packages\")) }} \\"},{"line_number":9,"context_line":"    \u0026\u0026 useradd --user-group heka \\"},{"line_number":10,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_4a10ef01","line":8,"in_reply_to":"bacf61ea_9f4a27ab","updated":"2016-07-28 15:50:38.000000000","message":"Can you please clarify what\u0027s wrong with this?","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"bc994716df8abef27cc075a4aca45d0fb42339c8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"},{"line_number":14,"context_line":"    \u0026\u0026 dpkg -i heka_0.10.0_amd64.deb \\"},{"line_number":15,"context_line":"    \u0026\u0026 rm -f heka_0.10.0_amd64.deb"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_ffc7e30f","line":13,"updated":"2016-07-28 15:41:51.000000000","message":"could this be costomized?","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"ac9b24681ba166a49d170c046304e602cb160047","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"},{"line_number":14,"context_line":"    \u0026\u0026 dpkg -i heka_0.10.0_amd64.deb \\"},{"line_number":15,"context_line":"    \u0026\u0026 rm -f heka_0.10.0_amd64.deb"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_ebbe02fe","line":13,"updated":"2016-08-03 15:28:25.000000000","message":"so macro is not required for cuistomizations. This can be done by creating a list of prior to this line, adding | customizable filter to it and then make a forloop out of this whole block.","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":15388,"name":"Abe Music","email":"abe.music@gmail.com","username":"abemusic"},"change_message_id":"c4f22edabf47c879c0b92d2387a6e19fd3b530d0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"},{"line_number":14,"context_line":"    \u0026\u0026 dpkg -i heka_0.10.0_amd64.deb \\"},{"line_number":15,"context_line":"    \u0026\u0026 rm -f heka_0.10.0_amd64.deb"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_0abb97e6","line":13,"in_reply_to":"bacf61ea_ffc7e30f","updated":"2016-07-28 15:50:38.000000000","message":"Are you asking about potentially using the macro to install the package? If so, it would need to support installing deb files directly from a URL, which it does not at the moment because apt-get can\u0027t do that.","commit_id":"7d56da40d64aea81eaccf637e3593e0299261d25"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f97f0138bb90e25c313e349f068941edee6a9e25","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":19,"context_line":"RUN useradd --user-group heka \\"},{"line_number":20,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"COPY plugins/modules /usr/share/heka/lua_modules/"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3ac371cc_2c02a90b","line":20,"updated":"2016-08-17 09:05:57.000000000","message":"why not put this into above if condition?","commit_id":"dc8cdbf2489e2f28f35aee3b60dc8023aaa30a62"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"7173401870f8072f4489b244aa6ca3fc2af2463c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":19,"context_line":"RUN useradd --user-group heka \\"},{"line_number":20,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"COPY plugins/modules /usr/share/heka/lua_modules/"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3ac371cc_3b9e5963","line":20,"in_reply_to":"3ac371cc_2c02a90b","updated":"2016-08-17 10:19:16.000000000","message":"+1","commit_id":"dc8cdbf2489e2f28f35aee3b60dc8023aaa30a62"},{"author":{"_account_id":17934,"name":"Josh Lothian","email":"josh.lothian@gmail.com","username":"jlothian"},"change_message_id":"15b39d14164ac4bc295451097078d1e442a8deff","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":19,"context_line":"RUN useradd --user-group heka \\"},{"line_number":20,"context_line":"    \u0026\u0026 mkdir /etc/heka"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"COPY plugins/modules /usr/share/heka/lua_modules/"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3ac371cc_3853f56c","line":20,"in_reply_to":"3ac371cc_2c02a90b","updated":"2016-08-17 13:05:22.000000000","message":"Good point.  I thought the ordering of RPM installation vs. user/dir creation might for some reason.  Does not appear to be the case.","commit_id":"dc8cdbf2489e2f28f35aee3b60dc8023aaa30a62"}]}