)]}'
{"ansible/roles/nova/tasks/check.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"99cda1333a64543d5bacde7cba3f433a92832ede","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: Nova sanity checks"},{"line_number":4,"context_line":"  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost"},{"line_number":5,"context_line":"    -m kolla_sanity"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_f437a5fb","line":2,"updated":"2016-07-26 16:44:29.000000000","message":"this blank line isn\u0027t needed.","commit_id":"39d97d91d512ca492d89fbf5e0ba9bd7f2863a83"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a515c4e7007df730e07997a1c495f529cc05d9b0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  retries: 1"},{"line_number":17,"context_line":"  delay: 5"},{"line_number":18,"context_line":"  run_once: True"},{"line_number":19,"context_line":"  when: kolla_enable_sanity_nova | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_39937751","line":19,"updated":"2016-08-03 02:25:30.000000000","message":"add newline char at the end of file.","commit_id":"cf6384250b753b9f58d8d7290e71673f15cb83fc"}],"ansible/roles/nova/tasks/main.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c6d4179e7014bfa4b26f49e5a55d226369af564a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bacf61ea_9fc4e75f","line":5,"updated":"2016-07-28 15:37:46.000000000","message":"need a newline at end of the file","commit_id":"39d97d91d512ca492d89fbf5e0ba9bd7f2863a83"}],"docker/kolla-toolbox/kolla_sanity.py":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"af07af45a26d1624e886dcb4f9ab5d96cff85c20","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def nova(cloud):"},{"line_number":53,"context_line":"        cloud.create_flavor(\"test\", 1, 1, 1, 1)"},{"line_number":54,"context_line":"        cloud.nova_client.flavors.delete(1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def main():"},{"line_number":57,"context_line":"    module \u003d AnsibleModule("},{"line_number":58,"context_line":"        argument_spec\u003dopenstack_full_argument_spec("}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3aa37451","line":55,"updated":"2016-08-02 19:22:49.000000000","message":"expected 2 blank lines","commit_id":"cf6384250b753b9f58d8d7290e71673f15cb83fc"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"72f9a6181e972476508a46648705c9f0b82c6b59","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def nova(cloud):"},{"line_number":53,"context_line":"        cloud.create_flavor(\"test\", 1, 1, 1, 1)"},{"line_number":54,"context_line":"        cloud.nova_client.flavors.delete(1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_47973c90","line":54,"updated":"2016-08-09 14:42:50.000000000","message":"I think it is better to use some random ID here. Maybe a Kolla user injected the generation of flavours somewhere and then this test will fail because it creates a flavour with the ID 1.","commit_id":"395b6e3f7985229567e2a17ed933e21d57775298"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f9344200e62f2ee153491aa84b4fcc068482db0f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def nova(cloud):"},{"line_number":53,"context_line":"        cloud.create_flavor(\"test\", 1, 1, 1, 1)"},{"line_number":54,"context_line":"        cloud.nova_client.flavors.delete(1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_cc5fad3f","line":54,"updated":"2016-08-10 06:07:51.000000000","message":"agreed.","commit_id":"395b6e3f7985229567e2a17ed933e21d57775298"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"514b6700ea4cd584748ec4d509afc40e4989b15e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def nova(cloud):"},{"line_number":53,"context_line":"        cloud.create_flavor(\"test\", 1, 1, 1, 9023455)"},{"line_number":54,"context_line":"        cloud.nova_client.flavors.delete(9023455)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_a1cbc91d","line":54,"updated":"2016-08-14 16:04:44.000000000","message":"agreed.","commit_id":"2520336dee48984c696a59403bcfbb83faa243dc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d79203652def7a1b42a6f3d7224340134dffc3c","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def nova(cloud):"},{"line_number":53,"context_line":"        cloud.create_flavor(\"test\", 1, 1, 1, 9023455)"},{"line_number":54,"context_line":"        cloud.nova_client.flavors.delete(9023455)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_a66b161d","line":54,"range":{"start_line":53,"start_character":8,"end_line":54,"end_character":49},"updated":"2016-08-11 16:08:40.000000000","message":"rather then using a hardcoded id of 9023455 it would probably be better to create the flavor and allow the db to assign it then use the value returned by the create call to delete it.","commit_id":"2520336dee48984c696a59403bcfbb83faa243dc"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"39ea962e59f8dfcee762b455819c785e6b15a09b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def nova(cloud):"},{"line_number":53,"context_line":"        cloud.create_flavor(\"test\", 1, 1, 1, 9023455)"},{"line_number":54,"context_line":"        cloud.nova_client.flavors.delete(9023455)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_b5993f22","line":54,"in_reply_to":"3ac371cc_a1cbc91d","updated":"2016-08-15 02:36:01.000000000","message":"Is there any method like cloud.get_flavor_id(\"test\")?","commit_id":"2520336dee48984c696a59403bcfbb83faa243dc"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"5d5cd131e4331580ef4cd7f6e06ddf517b20a0e5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def nova(cloud):"},{"line_number":53,"context_line":"        cloud.create_flavor(\"test\", 1, 1, 1, 9023455)"},{"line_number":54,"context_line":"        cloud.nova_client.flavors.delete(9023455)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_1811325e","line":54,"in_reply_to":"3ac371cc_b5993f22","updated":"2016-08-31 06:47:06.000000000","message":"Why not directly called, cloud.delete_flavor(name_or_id) method for deleting flavor","commit_id":"2520336dee48984c696a59403bcfbb83faa243dc"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"09aa5c009249eefa3a459deaa93e3e6fbcf08855","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def nova(cloud):"},{"line_number":53,"context_line":"        cloud.create_flavor(\"test\", 1, 1, 1, 9023455)"},{"line_number":54,"context_line":"        cloud.nova_client.flavors.delete(9023455)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_38375d00","line":54,"range":{"start_line":53,"start_character":8,"end_line":54,"end_character":49},"in_reply_to":"9ad45d7e_a66b161d","updated":"2016-09-12 15:11:33.000000000","message":"agree","commit_id":"2520336dee48984c696a59403bcfbb83faa243dc"},{"author":{"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},"change_message_id":"8c90d4c1f471d718b4effff3e83d0f5bf155fca2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def nova(cloud):"},{"line_number":53,"context_line":"        cloud.create_flavor(\"test\", 1, 1, 1, 9023455)"},{"line_number":54,"context_line":"        cloud.nova_client.flavors.delete(9023455)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_be249dc6","line":54,"in_reply_to":"fa7ab95a_1811325e","updated":"2016-08-31 11:43:51.000000000","message":"it is ok,if it is in test code.","commit_id":"2520336dee48984c696a59403bcfbb83faa243dc"}]}