)]}'
{"ansible/roles/nova/tasks/register.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4703a9b2d4828a5fd796fcc8ea189afc5ea83c93","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  delay: 5"},{"line_number":19,"context_line":"  run_once: True"},{"line_number":20,"context_line":"  with_items:"},{"line_number":21,"context_line":"    - {\u0027name\u0027: \u0027nova_legacy\u0027, \u0027service_type\u0027: \u0027compute_legacy\u0027, \u0027interface\u0027: \u0027admin\u0027, \u0027url\u0027: \u0027{{ nova_legacy_admin_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service (Legacy 2.0)\u0027}"},{"line_number":22,"context_line":"    - {\u0027name\u0027: \u0027nova_legacy\u0027, \u0027service_type\u0027: \u0027compute_legacy\u0027, \u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ nova_legacy_internal_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service (Legacy 2.0)\u0027}"},{"line_number":23,"context_line":"    - {\u0027name\u0027: \u0027nova_legacy\u0027, \u0027service_type\u0027: \u0027compute_legacy\u0027, \u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ nova_legacy_public_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service (Legacy 2.0)\u0027}"},{"line_number":24,"context_line":"    - {\u0027name\u0027: \u0027nova\u0027, \u0027service_type\u0027: \u0027compute\u0027, \u0027interface\u0027: \u0027admin\u0027, \u0027url\u0027: \u0027{{ nova_admin_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service\u0027}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_d8836454","line":21,"updated":"2016-08-08 07:08:45.000000000","message":"Other endpoint description is bad[0]. It using Openstack rather then OpenStack. Moreover, I perfer to change the description to the same with devstack and puppet-nova[1]\nwe not fix it because the kolla_keystone_service do not support that. But now, it support it and we have a change to fix it.\n\n[0] https://github.com/openstack/kolla/blob/master/ansible/roles/cinder/tasks/register.yml#L7\n[1] https://github.com/openstack/puppet-nova/blob/master/manifests/keystone/auth.pp#L92","commit_id":"1ce1cd10fe867d002b0e87013e236842c4af68a6"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ae9ac785ba93fe5ebf26acbdf03901c2effb3134","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  delay: 5"},{"line_number":19,"context_line":"  run_once: True"},{"line_number":20,"context_line":"  with_items:"},{"line_number":21,"context_line":"    - {\u0027name\u0027: \u0027nova_legacy\u0027, \u0027service_type\u0027: \u0027compute_legacy\u0027, \u0027interface\u0027: \u0027admin\u0027, \u0027url\u0027: \u0027{{ nova_legacy_admin_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service (Legacy 2.0)\u0027}"},{"line_number":22,"context_line":"    - {\u0027name\u0027: \u0027nova_legacy\u0027, \u0027service_type\u0027: \u0027compute_legacy\u0027, \u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ nova_legacy_internal_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service (Legacy 2.0)\u0027}"},{"line_number":23,"context_line":"    - {\u0027name\u0027: \u0027nova_legacy\u0027, \u0027service_type\u0027: \u0027compute_legacy\u0027, \u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ nova_legacy_public_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service (Legacy 2.0)\u0027}"},{"line_number":24,"context_line":"    - {\u0027name\u0027: \u0027nova\u0027, \u0027service_type\u0027: \u0027compute\u0027, \u0027interface\u0027: \u0027admin\u0027, \u0027url\u0027: \u0027{{ nova_admin_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service\u0027}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_488050f7","line":21,"range":{"start_line":21,"start_character":163,"end_line":21,"end_character":170},"updated":"2016-08-07 19:25:49.000000000","message":"We do not use \"Service\" in other endpoint descriptions.","commit_id":"1ce1cd10fe867d002b0e87013e236842c4af68a6"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"652a083e5a22c6eb44734342bf35c5192cd5b9c8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  delay: 5"},{"line_number":19,"context_line":"  run_once: True"},{"line_number":20,"context_line":"  with_items:"},{"line_number":21,"context_line":"    - {\u0027name\u0027: \u0027nova_legacy\u0027, \u0027service_type\u0027: \u0027compute_legacy\u0027, \u0027interface\u0027: \u0027admin\u0027, \u0027url\u0027: \u0027{{ nova_legacy_admin_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service (Legacy 2.0)\u0027}"},{"line_number":22,"context_line":"    - {\u0027name\u0027: \u0027nova_legacy\u0027, \u0027service_type\u0027: \u0027compute_legacy\u0027, \u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ nova_legacy_internal_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service (Legacy 2.0)\u0027}"},{"line_number":23,"context_line":"    - {\u0027name\u0027: \u0027nova_legacy\u0027, \u0027service_type\u0027: \u0027compute_legacy\u0027, \u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ nova_legacy_public_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service (Legacy 2.0)\u0027}"},{"line_number":24,"context_line":"    - {\u0027name\u0027: \u0027nova\u0027, \u0027service_type\u0027: \u0027compute\u0027, \u0027interface\u0027: \u0027admin\u0027, \u0027url\u0027: \u0027{{ nova_admin_endpoint }}\u0027, \u0027description\u0027: \u0027OpenStack Compute Service\u0027}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_283d70c4","line":21,"in_reply_to":"bacf61ea_d8836454","updated":"2016-08-10 16:45:56.000000000","message":"I do not have a strong behaviour here, I just think that descriptions should be unified. I proposed https://review.openstack.org/#/c/352110/ to do this in one step. I will update this review to use the descriptions like in puppet-nova.","commit_id":"1ce1cd10fe867d002b0e87013e236842c4af68a6"}]}