)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15492,"name":"Robin Naundorf","email":"r.naundorf@fh-muenster.de","username":"senk"},"change_message_id":"5a1eaa1e2a713e28ecd31c8a9ef9e9ed9d20b19f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-08-05 13:30:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Customizations for Cinder"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8d0131aff9cc406bd80ce384003308aee672412a"},{"line_number":10,"context_line":"Partially-implements: blueprint third-party-plugin-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bacf61ea_16ccc033","line":8,"updated":"2016-08-06 18:49:40.000000000","message":"please add some more information to commit message","commit_id":"d40da27f92f310ea6a6bccd57a2b3a962907e6d7"},{"author":{"_account_id":15492,"name":"Robin Naundorf","email":"r.naundorf@fh-muenster.de","username":"senk"},"change_message_id":"70e1fd2fa8a6a0c8105eeebdb616caa42f232985","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-08-08 09:30:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Customizations for Cinder"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8d0131aff9cc406bd80ce384003308aee672412a"},{"line_number":10,"context_line":"Partially-implements: blueprint third-party-plugin-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_701a4619","line":8,"updated":"2016-08-08 09:42:46.000000000","message":"please add some more information to commit message","commit_id":"45e1bb6f30871c5e22beaabcb5d471258ee32c1e"}],"docker/cinder/cinder-api/Dockerfile.j2":[{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"0eff0286daef54cdf7bbf5b483b2c674a9e78e13","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"        {% set cinder_api_packages \u003d ["},{"line_number":10,"context_line":"                \u0027python-keystone\u0027"},{"line_number":11,"context_line":"        ] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_386c7acf","line":10,"range":{"start_line":10,"start_character":17,"end_line":10,"end_character":32},"updated":"2016-08-11 09:43:11.000000000","message":"this should is openstack-cinder-api？","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"5c0d3c7cb1b42c66c43a945c90993f3fce8eedd3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"        {% set cinder_api_packages \u003d ["},{"line_number":10,"context_line":"                \u0027python-keystone\u0027"},{"line_number":11,"context_line":"        ] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_e8f68f8d","line":10,"range":{"start_line":10,"start_character":17,"end_line":10,"end_character":32},"in_reply_to":"9ad45d7e_386c7acf","updated":"2016-08-11 13:01:56.000000000","message":"Cinder api binary is installed by openstack-cinder in rhel distros which is in the cinder-base already. This is correct.","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"}],"docker/cinder/cinder-backup/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4315ff0ac6d1ffa9afd09b3c7c0d0c9b601b801b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(cinder_backup_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bacf61ea_6ca62110","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":84},"updated":"2016-08-05 21:17:10.000000000","message":"This RUN has to be before base_distro ubuntu {% endif %}. If not, centos build is looking for a yum install without any package which make the build fail","commit_id":"d40da27f92f310ea6a6bccd57a2b3a962907e6d7"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"0d5a0022743300cb9b06eb40dd03b022f79ad65c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(cinder_backup_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_8de1a5d3","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":84},"in_reply_to":"bacf61ea_6ca62110","updated":"2016-08-08 09:30:36.000000000","message":"Thanks Eduardo well spotted","commit_id":"d40da27f92f310ea6a6bccd57a2b3a962907e6d7"}],"docker/cinder/cinder-base/Dockerfile.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"6f05ee64957ffe30e231d53c20a1123b16a4d909","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"RUN {{ macros.install_packages(cinder_base_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":29,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_0238893c","line":26,"updated":"2016-08-03 20:40:40.000000000","message":"Is it possible to move line 26 and 47 out of the if block to line 59? This way this line is required only once.","commit_id":"a4266f7963dac91cb526fe08993fefd2b369e9de"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"caa837a979560813a25eb5a8c2533fde26922392","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"RUN {{ macros.install_packages(cinder_base_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":29,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_bbb0aa8c","line":26,"in_reply_to":"bacf61ea_0238893c","updated":"2016-08-04 11:03:50.000000000","message":"My concern with that is that the pip install of cinder may require the packages to be installed first. I haven\u0027t tested cinder specifically but this is often the case, leading me to think it\u0027s best to keep the RUN lines where they are to be future proof.","commit_id":"a4266f7963dac91cb526fe08993fefd2b369e9de"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"8b1a68326f996f5e3c12621746a66e7c1adc9263","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"RUN {{ macros.install_packages(cinder_base_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":29,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_3ee9481b","line":26,"in_reply_to":"bacf61ea_bbb0aa8c","updated":"2016-08-04 11:07:44.000000000","message":"Makes sense.","commit_id":"a4266f7963dac91cb526fe08993fefd2b369e9de"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"1d6f6ffa26fc9c2e8f6efcc48ddb064072cb915d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":29,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        {% set cinder_base_packages \u003d ["},{"line_number":32,"context_line":"                \u0027lvm2\u0027,"},{"line_number":33,"context_line":"                \u0027qemu-img\u0027,"},{"line_number":34,"context_line":"                \u0027ceph-common\u0027"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ad45d7e_299344a5","line":31,"updated":"2016-08-08 12:17:28.000000000","message":"After reading the documentation patch for the docker file customisations I am not sure if this is correct. What will happen when we append entries to this dictionary using the block in the footer when we define the dictionary twice. Does this work like expected?","commit_id":"3a9c9c9304dfe13d8f5836ee4a8b30239d6dc63d"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a48f6db640ceb593fbf617eb8ab3ca9289f5705a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":29,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        {% set cinder_base_packages \u003d ["},{"line_number":32,"context_line":"                \u0027lvm2\u0027,"},{"line_number":33,"context_line":"                \u0027qemu-img\u0027,"},{"line_number":34,"context_line":"                \u0027ceph-common\u0027"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ad45d7e_1b95d4e3","line":31,"in_reply_to":"9ad45d7e_299344a5","updated":"2016-08-08 16:52:13.000000000","message":"\u003e What will happen when we append entries to this dictionary using the block in the footer\n\nYou should not do that. If the documentation indicates so, please let me know where and add a -1! You should only modify this dict using the dedicated \"packages\" filter. The footer is for other free form changes.","commit_id":"3a9c9c9304dfe13d8f5836ee4a8b30239d6dc63d"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"14c84f534f8a4162e66ccba9616575123aa47be8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"RUN usermod -a -G kolla cinder \\"},{"line_number":64,"context_line":"    \u0026\u0026 mkdir -p /etc/ceph \\"},{"line_number":65,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":66,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_cinder_sudoers \\"},{"line_number":67,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_cinder_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_1adff30d","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":27},"updated":"2016-08-11 07:45:10.000000000","message":"This is not a step in the rhel source step. Are you sure it should be moved to a global action?","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"5dbcd0f29f9ce5f4b55076009e83a6573dff2b25","unresolved":false,"context_lines":[{"line_number":61,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"RUN usermod -a -G kolla cinder \\"},{"line_number":64,"context_line":"    \u0026\u0026 mkdir -p /etc/ceph \\"},{"line_number":65,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":66,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_cinder_sudoers \\"},{"line_number":67,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_cinder_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_e71887d5","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":27},"in_reply_to":"9ad45d7e_1adff30d","updated":"2016-08-11 08:56:05.000000000","message":"It\u0027s done in all cases except rhel source. I feel it\u0027s easier to have here.","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"5c0d3c7cb1b42c66c43a945c90993f3fce8eedd3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"RUN usermod -a -G kolla cinder \\"},{"line_number":64,"context_line":"    \u0026\u0026 mkdir -p /etc/ceph \\"},{"line_number":65,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":66,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_cinder_sudoers \\"},{"line_number":67,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_cinder_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_c8af4b7b","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":27},"in_reply_to":"9ad45d7e_e71887d5","updated":"2016-08-11 13:01:56.000000000","message":"That\u0027s fair enough.","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"}],"docker/cinder/cinder-scheduler/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"18787886b8381edaf5f61eb3f937dfd9d69cb1e7","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(cinder_backup_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_50e8997c","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":53},"updated":"2016-08-03 15:21:52.000000000","message":"Change to cinder_scheduler_packages","commit_id":"c477208f256fd0900a4ed56e83feb4da301bd9a8"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"26f430fd884b4f17ea3373e77b4e23badcf04f3d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(cinder_backup_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_3047e578","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":53},"in_reply_to":"bacf61ea_50e8997c","updated":"2016-08-03 15:23:15.000000000","message":"nice catch.","commit_id":"c477208f256fd0900a4ed56e83feb4da301bd9a8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4315ff0ac6d1ffa9afd09b3c7c0d0c9b601b801b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(cinder_scheduler_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bacf61ea_4ceb5d13","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":87},"updated":"2016-08-05 21:17:10.000000000","message":"Ditto","commit_id":"d40da27f92f310ea6a6bccd57a2b3a962907e6d7"}],"docker/cinder/cinder-volume/Dockerfile.j2":[{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"5c0d3c7cb1b42c66c43a945c90993f3fce8eedd3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"            \u0027scsi-target-utils\u0027"},{"line_number":10,"context_line":"    ] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% block cinder_volume_redhat_setup %}"},{"line_number":13,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/tgtd.conf"},{"line_number":14,"context_line":"{% endblock %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_f36680eb","line":12,"updated":"2016-08-11 13:01:56.000000000","message":"I\u0027ve only seen this style used in horizon. Is this a part of the blueprint for third party plugin support?","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"8b138cf41706b68a05d6d06063eed0880f0d7aa8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"            \u0027scsi-target-utils\u0027"},{"line_number":10,"context_line":"    ] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% block cinder_volume_redhat_setup %}"},{"line_number":13,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/tgtd.conf"},{"line_number":14,"context_line":"{% endblock %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_97bc47bc","line":12,"in_reply_to":"9ad45d7e_f36680eb","updated":"2016-08-11 13:43:47.000000000","message":"Pretty much. The blueprint is called third party plugins but its part of the overall effort to customise the Dockerfiles, I don\u0027t feel there\u0027s any reason to create another blueprint at this stage.\n\nAs part of my own build I don\u0027t want to run these seds, so I felt it was reasonable to put the _setup_ blocks here.","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"0eff0286daef54cdf7bbf5b483b2c674a9e78e13","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% block cinder_volume_ubuntu_setup %}"},{"line_number":23,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/targets.conf"},{"line_number":24,"context_line":"{% endblock %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_98712647","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":72},"updated":"2016-08-11 09:43:11.000000000","message":"This command is not appropriate, you do not run the RUN {{macros.install_package}}, how can you find the configuration file.","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"8b138cf41706b68a05d6d06063eed0880f0d7aa8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% block cinder_volume_ubuntu_setup %}"},{"line_number":23,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/targets.conf"},{"line_number":24,"context_line":"{% endblock %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_b7150b9d","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":72},"in_reply_to":"9ad45d7e_98712647","updated":"2016-08-11 13:43:47.000000000","message":"Done","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"5c0d3c7cb1b42c66c43a945c90993f3fce8eedd3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% block cinder_volume_ubuntu_setup %}"},{"line_number":23,"context_line":"RUN sed -i \u00271 i include /var/lib/cinder/volumes/*\u0027 /etc/tgt/targets.conf"},{"line_number":24,"context_line":"{% endblock %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9ad45d7e_736450b8","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":72},"in_reply_to":"9ad45d7e_98712647","updated":"2016-08-11 13:01:56.000000000","message":"Yes the install macro will have to run prior to the sed commands in each base distro group.","commit_id":"68854fc365b7d7a18eb405d14a681222c3877f64"}]}