)]}'
{"docker/manila/manila-api/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"09fed380da8f834ef3caea2f07788e8c9f9f3f16","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"        {% set manila_api_packages \u003d ["},{"line_number":10,"context_line":"                \u0027manila-api\u0027"},{"line_number":11,"context_line":"        ] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_b12c1b4b","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":34},"updated":"2016-08-05 06:46:26.000000000","message":"Use single line syntax for 1 package\neg: {% set manila_api_packages \u003d [\u0027manila-api\u0027] %}","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c47761d9536456eefcb61aa3fe8896c5a7f2ee9a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"        {% set manila_api_packages \u003d ["},{"line_number":10,"context_line":"                \u0027manila-api\u0027"},{"line_number":11,"context_line":"        ] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_759a7215","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":34},"in_reply_to":"bacf61ea_b12c1b4b","updated":"2016-08-05 15:47:55.000000000","message":"I see no gain making this change","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"}],"docker/manila/manila-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"09fed380da8f834ef3caea2f07788e8c9f9f3f16","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":26,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        {% set manila_base_packages \u003d ["},{"line_number":29,"context_line":"                \u0027openvswitch\u0027"},{"line_number":30,"context_line":"        ] %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_d1270f61","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":35},"updated":"2016-08-05 06:46:26.000000000","message":"Ditto","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c47761d9536456eefcb61aa3fe8896c5a7f2ee9a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":26,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        {% set manila_base_packages \u003d ["},{"line_number":29,"context_line":"                \u0027openvswitch\u0027"},{"line_number":30,"context_line":"        ] %}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_f58662b7","line":28,"range":{"start_line":28,"start_character":15,"end_line":28,"end_character":35},"in_reply_to":"bacf61ea_d1270f61","updated":"2016-08-05 15:47:55.000000000","message":"ditto","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"09fed380da8f834ef3caea2f07788e8c9f9f3f16","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        {% set manila_base_packages \u003d ["},{"line_number":35,"context_line":"                \u0027openvswitch-switch\u0027"},{"line_number":36,"context_line":"        ] %}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_111ec70b","line":34,"range":{"start_line":34,"start_character":15,"end_line":34,"end_character":35},"updated":"2016-08-05 06:46:26.000000000","message":"Ditto","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c47761d9536456eefcb61aa3fe8896c5a7f2ee9a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        {% set manila_base_packages \u003d ["},{"line_number":35,"context_line":"                \u0027openvswitch-switch\u0027"},{"line_number":36,"context_line":"        ] %}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_d5b4fe82","line":34,"range":{"start_line":34,"start_character":15,"end_line":34,"end_character":35},"in_reply_to":"bacf61ea_111ec70b","updated":"2016-08-05 15:47:55.000000000","message":"ditto","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"592a1e872c847e9cbb8f91b0f7757a42858bea19","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_manila_sudoers"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN touch /usr/local/bin/kolla_manila_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_9077b1d3","line":56,"updated":"2016-08-03 15:23:36.000000000","message":"RUN command at line 23 \u0026 40, can we commonly place it here after line 55. Is this cause any problem?","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"871cb0cb0441fa9eed2ae24aca4090127e80f94b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_manila_sudoers"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN touch /usr/local/bin/kolla_manila_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_22d14dce","line":56,"in_reply_to":"bacf61ea_9077b1d3","updated":"2016-08-03 20:42:31.000000000","message":"Confirmed.","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"}],"docker/manila/manila-scheduler/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"09fed380da8f834ef3caea2f07788e8c9f9f3f16","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"        {% set manila_scheduler_packages \u003d ["},{"line_number":10,"context_line":"                \u0027manila-scheduler\u0027"},{"line_number":11,"context_line":"        ] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_5114bfe7","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":40},"updated":"2016-08-05 06:46:26.000000000","message":"Ditto","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c47761d9536456eefcb61aa3fe8896c5a7f2ee9a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"        {% set manila_scheduler_packages \u003d ["},{"line_number":10,"context_line":"                \u0027manila-scheduler\u0027"},{"line_number":11,"context_line":"        ] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_35a47a49","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":40},"in_reply_to":"bacf61ea_5114bfe7","updated":"2016-08-05 15:47:55.000000000","message":"ditto","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"871cb0cb0441fa9eed2ae24aca4090127e80f94b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif%}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(manila_scheduler_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":"{% endif%}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block manila_scheduler_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_c2f03169","line":15,"updated":"2016-08-03 20:42:31.000000000","message":"Just a nit, the other files do have a newline after the RUN command.","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c47761d9536456eefcb61aa3fe8896c5a7f2ee9a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif%}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(manila_scheduler_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":"{% endif%}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block manila_scheduler_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_a7284187","line":15,"in_reply_to":"bacf61ea_c2f03169","updated":"2016-08-05 15:47:55.000000000","message":"Done","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"493f4e057e9217cf164bd6d166c1bacd45e0f476","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    {% endif%}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(manila_scheduler_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif%}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bacf61ea_ac3e59b5","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":87},"updated":"2016-08-05 21:10:39.000000000","message":"This RUN has to be before base_distro ubuntu {% endif %}.\nIf not, centos build is looking for a yum install without any package which make it fail","commit_id":"e9b57d156125839f6df80796fe627abdc83b54aa"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"54f62d307974414ec80d5846928f87eec33d3178","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    {% endif%}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(manila_scheduler_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif%}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bacf61ea_d05b5020","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":87},"in_reply_to":"bacf61ea_ac3e59b5","updated":"2016-08-06 14:12:24.000000000","message":"I think this is a bug in the macro itself. The macro should not fail when running without packages?","commit_id":"e9b57d156125839f6df80796fe627abdc83b54aa"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"a81497c06ab4a737355281bb40ae34016e339153","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    {% endif%}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(manila_scheduler_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif%}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_6edab4e9","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":87},"in_reply_to":"bacf61ea_d05b5020","updated":"2016-08-11 08:04:59.000000000","message":"That\u0027s true that the macro should fail more gracefully but the position of the statement is out of place. It should be moved as well.","commit_id":"e9b57d156125839f6df80796fe627abdc83b54aa"}],"docker/manila/manila-share/Dockerfile.j2":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"803b023bcb9dcf08af0803fe2f07dfdddfb4dcc5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    {% set manila_share_packages \u003d ["},{"line_number":10,"context_line":"            \u0027openstack-manila-share\u0027"},{"line_number":11,"context_line":"    ] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bacf61ea_854bf82a","line":9,"updated":"2016-08-03 14:15:11.000000000","message":"Minor, this block should have one more indent","commit_id":"e958266aac3035a6a0649f32cdbfb04562c7d5d6"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"085dcd97911e5110b04bd01e95c26b778dd6f0b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    {% set manila_share_packages \u003d ["},{"line_number":10,"context_line":"            \u0027openstack-manila-share\u0027"},{"line_number":11,"context_line":"    ] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bacf61ea_4582a001","line":9,"in_reply_to":"bacf61ea_854bf82a","updated":"2016-08-03 14:17:44.000000000","message":"Ok. :)","commit_id":"e958266aac3035a6a0649f32cdbfb04562c7d5d6"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"09fed380da8f834ef3caea2f07788e8c9f9f3f16","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"        {% set manila_share_packages \u003d ["},{"line_number":10,"context_line":"                \u0027openstack-manila-share\u0027"},{"line_number":11,"context_line":"        ] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_b1d37b37","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":36},"updated":"2016-08-05 06:46:26.000000000","message":"Ditto","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c47761d9536456eefcb61aa3fe8896c5a7f2ee9a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"        {% set manila_share_packages \u003d ["},{"line_number":10,"context_line":"                \u0027openstack-manila-share\u0027"},{"line_number":11,"context_line":"        ] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_954c469f","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":36},"in_reply_to":"bacf61ea_b1d37b37","updated":"2016-08-05 15:47:55.000000000","message":"ditto","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"871cb0cb0441fa9eed2ae24aca4090127e80f94b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(manila_share_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block manila_share_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_62022540","line":15,"updated":"2016-08-03 20:42:31.000000000","message":"Same here","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c47761d9536456eefcb61aa3fe8896c5a7f2ee9a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(manila_share_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":"{% endif %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block manila_share_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bacf61ea_872b7d81","line":15,"in_reply_to":"bacf61ea_62022540","updated":"2016-08-05 15:47:55.000000000","message":"Done","commit_id":"e870cbfd888a19d6f2b515ce91d035b3a6540962"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"493f4e057e9217cf164bd6d166c1bacd45e0f476","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(manila_share_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"bacf61ea_8c6c35d1","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":83},"updated":"2016-08-05 21:10:39.000000000","message":"The same but for centos packages","commit_id":"e9b57d156125839f6df80796fe627abdc83b54aa"}]}