)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"8b8b5e888946d2fa1ef31f0e896f7b4b7ac1c2ab","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"   Reference link: http://docs.openstack.org/developer/aodh/install/mod_wsgi.html"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"enviroment: base:centos  type:source"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1609000"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bacf61ea_4521994c","line":22,"updated":"2016-08-05 08:28:59.000000000","message":"remove this or add this into the proper item above. normally, we need test and fix in all case.","commit_id":"3583de5fb801eb95b38beee566bac4db7452d83c"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a86704e5270b03e3a5f82f79b9514e8932167102","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"repair aodh image dockerfile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Add the missing packages in the gnocchi image"},{"line_number":10,"context_line":"   packages: pymongo"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2. Add aodh sudoer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"fa7ab95a_326a7c81","line":9,"updated":"2016-08-26 10:57:01.000000000","message":"I dont see this change?","commit_id":"ef413177775b99482c7e2ed7fe21713264620253"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"5ca748ddf71370225c4b0546536c753765052b34","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"repair aodh image dockerfile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Add the missing packages in the gnocchi image"},{"line_number":10,"context_line":"   packages: pymongo"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2. Add aodh sudoer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"fa7ab95a_8d6ec9c7","line":9,"in_reply_to":"fa7ab95a_326a7c81","updated":"2016-08-26 11:06:34.000000000","message":"here changes are all in order to be able to run as httpd","commit_id":"ef413177775b99482c7e2ed7fe21713264620253"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"e76a4a413659d09cbe35e01d59738ddafed4409b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"repair aodh image dockerfile"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Add the missing packages in the gnocchi image"},{"line_number":10,"context_line":"   packages: pymongo"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2. Add aodh sudoer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"fa7ab95a_cd5e1145","line":9,"in_reply_to":"fa7ab95a_8d6ec9c7","updated":"2016-08-26 11:16:37.000000000","message":"There are no changes to the gnocchi image in this patchset","commit_id":"ef413177775b99482c7e2ed7fe21713264620253"}],"docker/aodh/aodh-api/Dockerfile.j2":[{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"d00267b02ce6dc17e1e178e10128f04728762324","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":6,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":7,"context_line":"       {% set aodh_api_packages \u003d ["},{"line_number":8,"context_line":"            \u0027openstack-aodh-api\u0027"},{"line_number":9,"context_line":"        ] %}"},{"line_number":10,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9ad45d7e_b9a18748","line":7,"updated":"2016-08-11 12:18:28.000000000","message":"This is across 3 lines whereas the ubuntu version of aodh_api_packages is across 1. They should follow the same pattern.","commit_id":"8a828bbd40ba864137f32288b4be52446098e443"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"7b39812b9b1ed64d79769b0a5337a28aa7220a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3ac371cc_afe89d11","line":24,"updated":"2016-08-15 22:48:48.000000000","message":"Why has USER aodh been removed from here? If its to do with permissions does the sudoers file need to be updated?","commit_id":"9d8330ca45d751b81c391a0913126984d6f90a61"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"ef1451ed811a2bdcbe535a21c7259e93a6c4d39d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3ac371cc_7d429b69","line":24,"in_reply_to":"3ac371cc_a1a6ec50","updated":"2016-08-17 00:57:39.000000000","message":"I think Binbing is right; refer to horizon [1].\n\n[1] https://github.com/openstack/kolla/blob/master/docker/horizon/Dockerfile.j2","commit_id":"9d8330ca45d751b81c391a0913126984d6f90a61"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"0a46de05f100b1619e2dc434a3cfb023f355fb19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3ac371cc_a1a6ec50","line":24,"in_reply_to":"3ac371cc_afe89d11","updated":"2016-08-16 03:05:30.000000000","message":"there changes are all in order to be able to run as httpd","commit_id":"9d8330ca45d751b81c391a0913126984d6f90a61"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"d7eb02a0aa45c274a3750a03fd8fa0903ed6a78c","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":6,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":7,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":8,"context_line":"       {% set aodh_api_packages \u003d [\u0027openstack-aodh-api\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":"        {% set aodh_api_packages \u003d [\u0027aodh-api\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"3ac371cc_b11ca5c2","line":7,"updated":"2016-08-19 04:36:54.000000000","message":"Please clean up the code. Thanks.","commit_id":"fddd470d0b0d6f8e0b7b2a39aebc0f5a35c29c2e"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"d7eb02a0aa45c274a3750a03fd8fa0903ed6a78c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        {% set aodh_api_packages \u003d ["},{"line_number":17,"context_line":"            \u0027aodh-api\u0027"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e 9d8330c... repair aodh image dockerfile"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":"RUN {{ macros.install_packages(aodh_api_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"3ac371cc_117819f8","line":19,"updated":"2016-08-19 04:36:54.000000000","message":"ditto","commit_id":"fddd470d0b0d6f8e0b7b2a39aebc0f5a35c29c2e"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"d970b84e5ee975af23506b7b222b9e9266a47907","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":"{{ include_footer }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"USER aodh"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"3ac371cc_8857bbc9","side":"PARENT","line":21,"updated":"2016-08-19 06:49:10.000000000","message":"why remove user?","commit_id":"e029dc5af1eb6ae31a6a755fe65891ff4a75cd12"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"dfa158a093739902817ac51b03b5c0ce567bebbc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":"{{ include_footer }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"USER aodh"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"3ac371cc_48d2e335","side":"PARENT","line":21,"in_reply_to":"3ac371cc_8857bbc9","updated":"2016-08-19 06:51:11.000000000","message":"there changes are all in order to be able to run as httpd","commit_id":"e029dc5af1eb6ae31a6a755fe65891ff4a75cd12"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a86704e5270b03e3a5f82f79b9514e8932167102","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":"{{ include_footer }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"USER aodh"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"fa7ab95a_b25daceb","side":"PARENT","line":21,"updated":"2016-08-26 10:57:01.000000000","message":"Why remove this?","commit_id":"1e222274e155d6db11c80aee4c48d9e5f3713e22"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a799761d7e069393f0aa9ed68fe56009fbcceb6c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":"{{ include_footer }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"USER aodh"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"fa7ab95a_294cbc6f","side":"PARENT","line":21,"updated":"2016-08-26 15:35:16.000000000","message":"why remove this","commit_id":"1e222274e155d6db11c80aee4c48d9e5f3713e22"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"f4fb98825b57f69ba556cbff2324904539ab8028","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":"{{ include_footer }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"USER aodh"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"fa7ab95a_c266ac28","side":"PARENT","line":21,"in_reply_to":"fa7ab95a_294cbc6f","updated":"2016-08-27 04:20:45.000000000","message":"If I understand correctly, root is required for httpd (refer to horizon [1]).\n[1] https://github.com/openstack/kolla/blob/master/docker/horizon/Dockerfile.j2","commit_id":"1e222274e155d6db11c80aee4c48d9e5f3713e22"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"b2b6dde4a33faf039aa48dee791c6ff54aa79938","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":"{{ include_footer }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"USER aodh"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"fa7ab95a_b9cf017e","side":"PARENT","line":21,"in_reply_to":"fa7ab95a_564ecd6f","updated":"2016-08-29 07:32:25.000000000","message":"Great analysis，thanks","commit_id":"1e222274e155d6db11c80aee4c48d9e5f3713e22"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"7c7ea0fe488bf3942f346fc128d964ae0e1637a4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":"{{ include_footer }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"USER aodh"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"fa7ab95a_564ecd6f","side":"PARENT","line":21,"in_reply_to":"fa7ab95a_9f1cf378","updated":"2016-08-28 16:44:14.000000000","message":"the security model on httpd (horizon is an example or keystone) is that Apache starts as root and then drops privileges.  I spent inorderinate amounts of time trying to get it to not behave like that, but apache needs root to start and is designed to drop root (as in if it can\u0027t, it doesn\u0027t work at all).","commit_id":"1e222274e155d6db11c80aee4c48d9e5f3713e22"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"d7c9ac876054c50d95356d3c81953356066a3491","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":"{{ include_footer }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"USER aodh"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"fa7ab95a_9f1cf378","side":"PARENT","line":21,"in_reply_to":"fa7ab95a_c266ac28","updated":"2016-08-28 02:52:56.000000000","message":"yes, httpd is required root","commit_id":"1e222274e155d6db11c80aee4c48d9e5f3713e22"}],"docker/aodh/aodh-api/extend_start.sh":[{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"d00267b02ce6dc17e1e178e10128f04728762324","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    aodh-dbsync"},{"line_number":7,"context_line":"    exit 0"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9ad45d7e_391bd7cb","line":7,"updated":"2016-08-11 12:18:28.000000000","message":"You may need to set the permissions of /var/lib/aodh.\n\nEg.\nsudo chown -R aodh: /var/lib/aodh/","commit_id":"8a828bbd40ba864137f32288b4be52446098e443"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"27e0c1e2efa6b2b37562451d089a71d73e19cf4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3ac371cc_731a4a19","line":9,"updated":"2016-08-14 05:36:23.000000000","message":"The code that you removed from the aodh-base/extended_start.sh should be here. I can see that you deleted it from aodh-base but did not move it to here.\n\nif [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then\n    # Loading Apache2 ENV variables\n    source /etc/apache2/envvars\n    rm -rf /var/run/apache2/*\n    APACHE_DIR\u003d\"apache2\"\nelse\n    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*\n    APACHE_DIR\u003d\"httpd\"\nfi","commit_id":"308abfc83b4cfea659717d8b30dfca00ad4f66b3"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a86704e5270b03e3a5f82f79b9514e8932167102","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# results in the container not being able to restart. (bug #1489676, 1557036)"},{"line_number":5,"context_line":"if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":6,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":7,"context_line":"    source /etc/apache2/envvars"},{"line_number":8,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":9,"context_line":"else"},{"line_number":10,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"}],"source_content_type":"text/x-sh","patch_set":26,"id":"fa7ab95a_f2e4940e","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"updated":"2016-08-26 10:57:01.000000000","message":"please change to \u0027.\u0027","commit_id":"ef413177775b99482c7e2ed7fe21713264620253"}],"docker/aodh/aodh-base/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5efe0ce4ecbde422884db7540acf437da5f5bd27","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        python-ldappool \\"},{"line_number":13,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"RUN mkdir -p /var/www/cgi-bin/aodh \\"},{"line_number":18,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bacf61ea_4ba05542","line":15,"updated":"2016-08-06 16:21:25.000000000","message":"two `elif base_distro in [\u0027ubuntu\u0027]? need remove one.","commit_id":"738d61c67090c08390e7b0b0e39fe61bdaee8aea"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"384600aabb453b2e9636aa393623808252c348e7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":21,"context_line":"    {% set aodh_base_packages \u003d [\u0027aodh-common\u0027"},{"line_number":22,"context_line":"                                    \u0027python-aodhclinet\u0027,"},{"line_number":23,"context_line":"                                    \u0027httpd\u0027,"},{"line_number":24,"context_line":"                                    \u0027mod_wsgi\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bacf61ea_d6e06828","line":21,"updated":"2016-08-06 17:29:43.000000000","message":"missing comma","commit_id":"dfc6acbdf77e003668a7915b3472c5abe9bc5e71"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"384600aabb453b2e9636aa393623808252c348e7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"   {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":49,"context_line":"     {% set aodh_base_packages \u003d [\u0027aodh-common\u0027"},{"line_number":50,"context_line":"                                    \u0027python-aodhclinet\u0027,"},{"line_number":51,"context_line":"                                    \u0027httpd\u0027,"},{"line_number":52,"context_line":"                                    \u0027mod_wsgi\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bacf61ea_16d5e041","line":49,"updated":"2016-08-06 17:29:43.000000000","message":"Ditto","commit_id":"dfc6acbdf77e003668a7915b3472c5abe9bc5e71"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"384600aabb453b2e9636aa393623808252c348e7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"     ] %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RUN mkdir -p /var/www/cgi-bin/aodh \\"},{"line_number":58,"context_line":"    \u0026\u0026 echo \u003e /etc/apache2/ports.conf  "},{"line_number":59,"context_line":"  "},{"line_number":60,"context_line":"    {% endif %}"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bacf61ea_36d2a45c","line":58,"range":{"start_line":58,"start_character":37,"end_line":58,"end_character":39},"updated":"2016-08-06 17:29:43.000000000","message":"Please, remove whitespace","commit_id":"dfc6acbdf77e003668a7915b3472c5abe9bc5e71"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"384600aabb453b2e9636aa393623808252c348e7","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RUN mkdir -p /var/www/cgi-bin/aodh \\"},{"line_number":58,"context_line":"    \u0026\u0026 echo \u003e /etc/apache2/ports.conf  "},{"line_number":59,"context_line":"  "},{"line_number":60,"context_line":"    {% endif %}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"RUN {{ macros.install_packages(aodh_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bacf61ea_76c89ca8","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"updated":"2016-08-06 17:29:43.000000000","message":"Ditto","commit_id":"dfc6acbdf77e003668a7915b3472c5abe9bc5e71"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"384600aabb453b2e9636aa393623808252c348e7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    {% endif %}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"RUN {{ macros.install_packages(aodh_base_packages | customizable(\"packages\")) }}"},{"line_number":63,"context_line":"{% endif %}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"ADD aodh-base-archive /aodh-base-source"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bacf61ea_163cc091","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":11},"updated":"2016-08-06 17:29:43.000000000","message":"Remove this endif, source finish at line 74","commit_id":"dfc6acbdf77e003668a7915b3472c5abe9bc5e71"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"384600aabb453b2e9636aa393623808252c348e7","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"{% block aodh_base_footer %}{% endblock %}"},{"line_number":88,"context_line":"{% block footer %}{% endblock %}"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bacf61ea_763ffc86","line":89,"updated":"2016-08-06 17:29:43.000000000","message":"Add {{ include_footer }}","commit_id":"dfc6acbdf77e003668a7915b3472c5abe9bc5e71"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"d00267b02ce6dc17e1e178e10128f04728762324","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027libapache2-mod-wsgi\u0027,"},{"line_number":49,"context_line":"            \u0027python-ldappool\u0027"},{"line_number":50,"context_line":"        ] %}"},{"line_number":51,"context_line":"RUN {{ macros.install_packages(aodh_packages | customizable(\"packages\")) }}"},{"line_number":52,"context_line":"RUN echo \u003e /etc/apache2/ports.conf"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9ad45d7e_34675eb8","line":51,"range":{"start_line":51,"start_character":31,"end_line":51,"end_character":44},"updated":"2016-08-11 12:18:28.000000000","message":"This should be called aodh_base_packages","commit_id":"8a828bbd40ba864137f32288b4be52446098e443"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"d00267b02ce6dc17e1e178e10128f04728762324","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt pymongo /aodh \\"},{"line_number":61,"context_line":"    \u0026\u0026 mkdir -p /etc/aodh /var/log/kolla/aodh /home/aodh /var/www/cgi-bin/aodh \\"},{"line_number":62,"context_line":"    \u0026\u0026 cp -r /aodh/etc/aodh/* /etc/aodh/  \\"},{"line_number":63,"context_line":"    \u0026\u0026 chown -R aodh: /etc/aodh /var/log/kolla/aodh /var/www/cgi-bin/aodh"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% endif %}"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9ad45d7e_34b91e16","line":63,"updated":"2016-08-11 12:18:28.000000000","message":"Shown /home/aodh not be in here as well?","commit_id":"8a828bbd40ba864137f32288b4be52446098e443"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"d00267b02ce6dc17e1e178e10128f04728762324","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":68,"context_line":"COPY aodh_sudoers /etc/sudoers.d/kolla_aodh_sudoers"},{"line_number":69,"context_line":"COPY app /var/www/cgi-bin/aodh/app"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"{% block aodh_base_footer %}{% endblock %}"},{"line_number":72,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9ad45d7e_747a7689","line":69,"updated":"2016-08-11 12:18:28.000000000","message":"This is not required.","commit_id":"8a828bbd40ba864137f32288b4be52446098e443"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"d00267b02ce6dc17e1e178e10128f04728762324","unresolved":false,"context_lines":[{"line_number":68,"context_line":"COPY aodh_sudoers /etc/sudoers.d/kolla_aodh_sudoers"},{"line_number":69,"context_line":"COPY app /var/www/cgi-bin/aodh/app"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"{% block aodh_base_footer %}{% endblock %}"},{"line_number":72,"context_line":"{% block footer %}{% endblock %}"},{"line_number":73,"context_line":"{{ include_footer }}"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"9ad45d7e_34463e4f","line":71,"updated":"2016-08-11 12:18:28.000000000","message":"The footers should be at the bottom of this file.","commit_id":"8a828bbd40ba864137f32288b4be52446098e443"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"5e16a92af4678e4a04e0f8341bb29f8a7f17c80f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"COPY aodh_sudoers /etc/sudoers.d/kolla_aodh_sudoers"},{"line_number":68,"context_line":"COPY app /var/www/cgi-bin/aodh/app"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"{% block aodh_base_footer %}{% endblock %}"},{"line_number":71,"context_line":"{% block footer %}{% endblock %}"},{"line_number":72,"context_line":"{{ include_footer }}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"RUN usermod -a -G kolla aodh \\"},{"line_number":75,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9ad45d7e_d6285788","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":20},"updated":"2016-08-12 04:34:44.000000000","message":"These should be at the bottom of the file","commit_id":"034ca297a8dd997c6ac6df0f8820137e97bdacbc"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c96eec0674189d60a646d56ed56a27c012a33b10","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    \u0026\u0026 chmod 640 /etc/sudoers.d/kolla_aodh_sudoers \\"},{"line_number":73,"context_line":"    \u0026\u0026 chmod 755 /var/www/cgi-bin/aodh \\"},{"line_number":74,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_aodh_extend_start \\"},{"line_number":75,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_aodh_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9ad45d7e_c5e19f9c","line":75,"updated":"2016-08-12 15:27:00.000000000","message":"{% block aodh_base_footer %}{% endblock %}\n{% block footer %}{% endblock %}","commit_id":"f93b2629cd96f6e2c9cd0efe5745e31bcf8394f6"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"a1c31768d53a6000395a0490dd75f1863c5ef64f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \u0026\u0026 useradd --user-group aodh \\"},{"line_number":59,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt pymongo /aodh \\"},{"line_number":60,"context_line":"    \u0026\u0026 mkdir -p /etc/aodh /var/log/kolla/aodh /var/www/cgi-bin/aodh \\"},{"line_number":61,"context_line":"    \u0026\u0026 cp -r /aodh/etc/aodh/* /etc/aodh/  \\"},{"line_number":62,"context_line":"    \u0026\u0026 chown -R aodh: /etc/aodh /var/log/kolla/aodh /var/www/cgi-bin/aodh"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"7ac969e8_c60417c8","line":61,"updated":"2016-08-13 03:47:10.000000000","message":"extra space","commit_id":"18e1fee92616df3c0aec759083a2bb6cab50c931"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"1610be0b90b352875040487b841335f29ce65d01","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":67,"context_line":"COPY aodh_sudoers /etc/sudoers.d/kolla_aodh_sudoers"},{"line_number":68,"context_line":"COPY app /var/www/cgi-bin/aodh/app"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"RUN usermod -a -G kolla aodh \\"},{"line_number":71,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"7ac969e8_09adad31","line":68,"updated":"2016-08-12 21:40:48.000000000","message":"This line should be removed. Aodh has its own wsgi file that you can use.","commit_id":"18e1fee92616df3c0aec759083a2bb6cab50c931"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"eb6fcef913c802b7244b2285b74996a61086c46a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3ac371cc_9371b17a","updated":"2016-08-19 03:06:32.000000000","message":"Committed with merge conflicts in file...","commit_id":"fddd470d0b0d6f8e0b7b2a39aebc0f5a35c29c2e"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c3a95d5039e7dbb9ac5a74c36725ab5618c7059b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3ac371cc_22486587","in_reply_to":"3ac371cc_9371b17a","updated":"2016-08-19 06:39:15.000000000","message":"sure，i fixed it now","commit_id":"fddd470d0b0d6f8e0b7b2a39aebc0f5a35c29c2e"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"d7eb02a0aa45c274a3750a03fd8fa0903ed6a78c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":"    {% if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":20,"context_line":"       {% set aodh_base_packages \u003d ["},{"line_number":21,"context_line":"            \u0027openstack-aodh-common\u0027,  "},{"line_number":22,"context_line":"            \u0027python-aodhclient\u0027,"},{"line_number":23,"context_line":"            \u0027httpd\u0027,"},{"line_number":24,"context_line":"            \u0027mod_wsgi\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"3ac371cc_518291c9","line":21,"updated":"2016-08-19 04:36:54.000000000","message":"trailing spaces.","commit_id":"fddd470d0b0d6f8e0b7b2a39aebc0f5a35c29c2e"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c3a95d5039e7dbb9ac5a74c36725ab5618c7059b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":"    {% if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":20,"context_line":"       {% set aodh_base_packages \u003d ["},{"line_number":21,"context_line":"            \u0027openstack-aodh-common\u0027,  "},{"line_number":22,"context_line":"            \u0027python-aodhclient\u0027,"},{"line_number":23,"context_line":"            \u0027httpd\u0027,"},{"line_number":24,"context_line":"            \u0027mod_wsgi\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"3ac371cc_a2545521","line":21,"in_reply_to":"3ac371cc_518291c9","updated":"2016-08-19 06:39:15.000000000","message":"thanks，i fix it now","commit_id":"fddd470d0b0d6f8e0b7b2a39aebc0f5a35c29c2e"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"d7eb02a0aa45c274a3750a03fd8fa0903ed6a78c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \u0026\u0026 echo \u003e /etc/apache2/ports.conf"},{"line_number":45,"context_line":"    {% endif %}"},{"line_number":46,"context_line":"   "},{"line_number":47,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e 9d8330c... repair aodh image dockerfile"},{"line_number":48,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":49,"context_line":"    {% if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"3ac371cc_71698d25","line":47,"updated":"2016-08-19 04:36:54.000000000","message":"clean up the code","commit_id":"fddd470d0b0d6f8e0b7b2a39aebc0f5a35c29c2e"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c3a95d5039e7dbb9ac5a74c36725ab5618c7059b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \u0026\u0026 echo \u003e /etc/apache2/ports.conf"},{"line_number":45,"context_line":"    {% endif %}"},{"line_number":46,"context_line":"   "},{"line_number":47,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e 9d8330c... repair aodh image dockerfile"},{"line_number":48,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":49,"context_line":"    {% if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"3ac371cc_423ac1e8","line":47,"in_reply_to":"3ac371cc_71698d25","updated":"2016-08-19 06:39:15.000000000","message":"Done","commit_id":"fddd470d0b0d6f8e0b7b2a39aebc0f5a35c29c2e"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"097d803e0c5602dffb1931c9125858d81eb44ad3","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"       "},{"line_number":9,"context_line":"       {% set aodh_base_packages \u003d ["},{"line_number":10,"context_line":"            \u0027openstack-aodh-common\u0027,"},{"line_number":11,"context_line":"            \u0027python-aodhclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"1ac06dbe_62c52a3b","line":8,"updated":"2016-08-20 03:41:42.000000000","message":"remove spaces","commit_id":"9ef97a344cd493422ca27f0bd1f57abc9806600a"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"b392e57ee6ae76bbe3fa29284347c072052fe319","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"1ac06dbe_ffd07f55","updated":"2016-08-21 06:01:10.000000000","message":"This file is all over the place. There is duplicate logic and nested redundant logic.","commit_id":"1852eaac346b7e31b3376962823853888041e692"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"b392e57ee6ae76bbe3fa29284347c072052fe319","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u0027python-ldappool\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":18,"context_line":"    {% set aodh_base_packages \u003d [\u0027openstack-aodh-common\u0027] %}"},{"line_number":19,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"    {% set aodh_base_packages \u003d [\u0027aodh-common\u0027] %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"{{ macros.install_packages(aodh_base_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":"RUN mkdir -p /var/www/cgi-bin/aodh \\"},{"line_number":24,"context_line":"    \u0026\u0026 cp -a /usr/lib/python2.7/site-packages/aodh/api/app.wsgi /var/www/cgi-bin/aodh/ \\"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_7f4c8f42","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":11},"updated":"2016-08-21 06:01:10.000000000","message":"This should be deleted.","commit_id":"1852eaac346b7e31b3376962823853888041e692"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"65b5e5ea0e964dcceb94a7ad2d4fa84db5f9f850","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u0027python-ldappool\u0027"},{"line_number":15,"context_line":"        ] %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":18,"context_line":"    {% set aodh_base_packages \u003d [\u0027openstack-aodh-common\u0027] %}"},{"line_number":19,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"    {% set aodh_base_packages \u003d [\u0027aodh-common\u0027] %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"{{ macros.install_packages(aodh_base_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":"RUN mkdir -p /var/www/cgi-bin/aodh \\"},{"line_number":24,"context_line":"    \u0026\u0026 cp -a /usr/lib/python2.7/site-packages/aodh/api/app.wsgi /var/www/cgi-bin/aodh/ \\"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_c0a044a2","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":11},"in_reply_to":"1ac06dbe_7f4c8f42","updated":"2016-08-21 11:07:24.000000000","message":"Done","commit_id":"1852eaac346b7e31b3376962823853888041e692"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"b392e57ee6ae76bbe3fa29284347c072052fe319","unresolved":false,"context_lines":[{"line_number":23,"context_line":"RUN mkdir -p /var/www/cgi-bin/aodh \\"},{"line_number":24,"context_line":"    \u0026\u0026 cp -a /usr/lib/python2.7/site-packages/aodh/api/app.wsgi /var/www/cgi-bin/aodh/ \\"},{"line_number":25,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":26,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"       {% set aodh_base_packages \u003d ["},{"line_number":29,"context_line":"            \u0027aodh-common\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_5f47131d","line":26,"updated":"2016-08-21 06:01:10.000000000","message":"Add whitespace above.","commit_id":"1852eaac346b7e31b3376962823853888041e692"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"b392e57ee6ae76bbe3fa29284347c072052fe319","unresolved":false,"context_lines":[{"line_number":49,"context_line":"{{ macros.install_packages(aodh_base_packages | customizable(\"packages\")) }}"},{"line_number":50,"context_line":"RUN mkdir -p /var/www/cgi-bin/aodh \\"},{"line_number":51,"context_line":"    \u0026\u0026 sed -i -r \u0027s,^(Listen 80),#\\1,\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":52,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"       {% set aodh_base_packages \u003d ["},{"line_number":55,"context_line":"            \u0027apache2\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_9f518bdb","line":52,"updated":"2016-08-21 06:01:10.000000000","message":"Add whitespace above.","commit_id":"1852eaac346b7e31b3376962823853888041e692"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"b392e57ee6ae76bbe3fa29284347c072052fe319","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_aodh_extend_start"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"{% block aodh_base_footer %}{% endblock %}"},{"line_number":88,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"1ac06dbe_9f8ceb80","line":88,"updated":"2016-08-21 06:01:10.000000000","message":"This should be removed. It is not required for base images.","commit_id":"1852eaac346b7e31b3376962823853888041e692"}],"docker/aodh/aodh-base/aodh_sudoers":[{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"d00267b02ce6dc17e1e178e10128f04728762324","unresolved":false,"context_lines":[{"line_number":1,"context_line":"aodh ALL\u003d(ALL) NOPASSWD: ALL"},{"line_number":2,"context_line":"%kolla ALL\u003d(ALL) NOPASSWD: ALL"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9ad45d7e_399ab76e","line":1,"updated":"2016-08-11 12:18:28.000000000","message":"There should be restrictions on what can be done under NOPASSWD reflected on what operations aodh needs to perform as a privileged user.\n\nAs an example:\n\n%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown -R aodh\\: /var/lib/aodh/, /bin/chown -R aodh\\: /var/lib/aodh/\n\nThat should handle the requirements of aodh.","commit_id":"8a828bbd40ba864137f32288b4be52446098e443"}],"docker/aodh/aodh-base/app":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5efe0ce4ecbde422884db7540acf437da5f5bd27","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Initialize the oslo configuration library and logging"},{"line_number":26,"context_line":"conf \u003d service.prepare_service([])"},{"line_number":27,"context_line":"application \u003d app.load_app(conf)"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"bacf61ea_6b9d5909","line":27,"updated":"2016-08-06 16:21:25.000000000","message":"aodh has appliation file. no need add it in kolla.\n\nhttps://github.com/openstack/aodh/blob/master/aodh/api/app.wsgi","commit_id":"738d61c67090c08390e7b0b0e39fe61bdaee8aea"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"d00267b02ce6dc17e1e178e10128f04728762324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9ad45d7e_d9255b5c","updated":"2016-08-11 12:18:28.000000000","message":"This is not required. The application has its own wsgi file eg. https://github.com/openstack/aodh/blob/master/aodh/api/app.wsgi.\n\nThe httpd config to connect to this is given at https://github.com/openstack/aodh/blob/master/etc/apache2/aodh.","commit_id":"8a828bbd40ba864137f32288b4be52446098e443"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"1610be0b90b352875040487b841335f29ce65d01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7ac969e8_c95ef575","updated":"2016-08-12 21:40:48.000000000","message":"This is not required. Aodh has its own wsgi handler in the app and the httpd config will be copied into the container on deploy.","commit_id":"18e1fee92616df3c0aec759083a2bb6cab50c931"}],"docker/aodh/aodh-base/extend_start.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5efe0ce4ecbde422884db7540acf437da5f5bd27","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":7,"context_line":"    source /etc/apache2/envvars"},{"line_number":8,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":9,"context_line":"    APACHE_DIR\u003d\"apache2\""},{"line_number":10,"context_line":"else"},{"line_number":11,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"},{"line_number":12,"context_line":"    APACHE_DIR\u003d\"httpd\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"bacf61ea_ab8bd1c1","line":9,"updated":"2016-08-06 16:21:25.000000000","message":"why handle the apache in aodh-base? only the aodh-api need this.","commit_id":"738d61c67090c08390e7b0b0e39fe61bdaee8aea"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"be4c64dd1c92e7069fba7fb356686dc999b41389","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    APACHE_DIR\u003d\"httpd\""},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Create log dir for Aodh logs"},{"line_number":16,"context_line":"AODH_LOG_DIR\u003d\"/var/log/kolla/aodh\""},{"line_number":17,"context_line":"if [[ ! -d \"${AODH_LOG_DIR}\" ]]; then"},{"line_number":18,"context_line":"    mkdir -p ${AODH_LOG_DIR}"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9ad45d7e_9933b0f5","line":15,"updated":"2016-08-12 05:04:41.000000000","message":"The above comment can be removed.","commit_id":"034ca297a8dd997c6ac6df0f8820137e97bdacbc"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"1610be0b90b352875040487b841335f29ce65d01","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":4,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":5,"context_line":"    source /etc/apache2/envvars"},{"line_number":6,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":7,"context_line":"    APACHE_DIR\u003d\"apache2\""},{"line_number":8,"context_line":"else"},{"line_number":9,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"},{"line_number":10,"context_line":"    APACHE_DIR\u003d\"httpd\""},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Create log dir for Aodh logs"},{"line_number":14,"context_line":"AODH_LOG_DIR\u003d\"/var/log/kolla/aodh\""}],"source_content_type":"text/x-sh","patch_set":15,"id":"7ac969e8_e9d011cc","line":11,"range":{"start_line":3,"start_character":0,"end_line":11,"end_character":2},"updated":"2016-08-12 21:40:48.000000000","message":"This should all be in aodh-api/extended_start.sh. There is no use in running this on all aodh containers. Only the API has apache.","commit_id":"18e1fee92616df3c0aec759083a2bb6cab50c931"},{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"f907c4f43a3713bbf7e3a7b83c5c57472b164a29","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    chmod 755 ${AODH_LOG_DIR}"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source /usr/local/bin/kolla_aodh_extend_start"}],"source_content_type":"text/x-sh","patch_set":25,"id":"1ac06dbe_fdf4995b","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"updated":"2016-08-23 13:00:18.000000000","message":"Use \".\" instead of source. http://docs.openstack.org/contributor-guide/writing-style/code-conventions.html","commit_id":"b095454997854f5ca6af5db59fd7fd2acf0791d6"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"57aa151ae486807613e60460695569747f0daff7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    chmod 755 ${AODH_LOG_DIR}"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source /usr/local/bin/kolla_aodh_extend_start"}],"source_content_type":"text/x-sh","patch_set":25,"id":"fa7ab95a_27d95c22","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"1ac06dbe_16401d07","updated":"2016-08-26 10:43:17.000000000","message":"Done","commit_id":"b095454997854f5ca6af5db59fd7fd2acf0791d6"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"57aa151ae486807613e60460695569747f0daff7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    chmod 755 ${AODH_LOG_DIR}"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source /usr/local/bin/kolla_aodh_extend_start"}],"source_content_type":"text/x-sh","patch_set":25,"id":"fa7ab95a_c7d190fd","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"1ac06dbe_97a4264b","updated":"2016-08-26 10:43:17.000000000","message":"Done","commit_id":"b095454997854f5ca6af5db59fd7fd2acf0791d6"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"83f30dcd88da999f1c5df1f93953bcc57a772018","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    chmod 755 ${AODH_LOG_DIR}"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source /usr/local/bin/kolla_aodh_extend_start"}],"source_content_type":"text/x-sh","patch_set":25,"id":"1ac06dbe_16401d07","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"1ac06dbe_97a4264b","updated":"2016-08-24 15:02:21.000000000","message":"Hi bingbing thanks for your sharing ,It LGTM\nbut I agree with Wei Cao , since it have a role about the “.”  I think we should standy by it \nif you have some advice ,maybe you should commit a patch to update it  http://docs.openstack.org/contributor-guide/writing-style/code-conventions.html","commit_id":"b095454997854f5ca6af5db59fd7fd2acf0791d6"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"d25563001385d0cb4cdec87f3bcbed501bb34a02","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    chmod 755 ${AODH_LOG_DIR}"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source /usr/local/bin/kolla_aodh_extend_start"}],"source_content_type":"text/x-sh","patch_set":25,"id":"1ac06dbe_97a4264b","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"1ac06dbe_fdf4995b","updated":"2016-08-24 08:11:55.000000000","message":"I think it should be considered","commit_id":"b095454997854f5ca6af5db59fd7fd2acf0791d6"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a86704e5270b03e3a5f82f79b9514e8932167102","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Create log dir for Aodh logs"},{"line_number":4,"context_line":"AODH_LOG_DIR\u003d\"/var/log/kolla/aodh\""},{"line_number":5,"context_line":"if [[ ! -d \"${AODH_LOG_DIR}\" ]]; then"},{"line_number":6,"context_line":"    mkdir -p ${AODH_LOG_DIR}"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"if [[ $(stat -c %U:%G ${AODH_LOG_DIR}) !\u003d \"aodh:kolla\" ]]; then"},{"line_number":9,"context_line":"    chown aodh:kolla ${AODH_LOG_DIR}"}],"source_content_type":"text/x-sh","patch_set":26,"id":"fa7ab95a_52b620dd","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":28},"updated":"2016-08-26 10:57:01.000000000","message":"Can this be done at build time? (in the Dockerfile)","commit_id":"ef413177775b99482c7e2ed7fe21713264620253"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"da8e15d3be71f830dea30ce0e57a2c8d213f8562","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Create log dir for Aodh logs"},{"line_number":4,"context_line":"AODH_LOG_DIR\u003d\"/var/log/kolla/aodh\""},{"line_number":5,"context_line":"if [[ ! -d \"${AODH_LOG_DIR}\" ]]; then"},{"line_number":6,"context_line":"    mkdir -p ${AODH_LOG_DIR}"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"if [[ $(stat -c %U:%G ${AODH_LOG_DIR}) !\u003d \"aodh:kolla\" ]]; then"},{"line_number":9,"context_line":"    chown aodh:kolla ${AODH_LOG_DIR}"}],"source_content_type":"text/x-sh","patch_set":26,"id":"fa7ab95a_ede4b50e","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":28},"in_reply_to":"fa7ab95a_529540e2","updated":"2016-08-26 11:11:17.000000000","message":"Ah sorry keep forgetting that!","commit_id":"ef413177775b99482c7e2ed7fe21713264620253"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"5ca748ddf71370225c4b0546536c753765052b34","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Create log dir for Aodh logs"},{"line_number":4,"context_line":"AODH_LOG_DIR\u003d\"/var/log/kolla/aodh\""},{"line_number":5,"context_line":"if [[ ! -d \"${AODH_LOG_DIR}\" ]]; then"},{"line_number":6,"context_line":"    mkdir -p ${AODH_LOG_DIR}"},{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":"if [[ $(stat -c %U:%G ${AODH_LOG_DIR}) !\u003d \"aodh:kolla\" ]]; then"},{"line_number":9,"context_line":"    chown aodh:kolla ${AODH_LOG_DIR}"}],"source_content_type":"text/x-sh","patch_set":26,"id":"fa7ab95a_529540e2","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":28},"in_reply_to":"fa7ab95a_52b620dd","updated":"2016-08-26 11:06:34.000000000","message":"If you create a directory in dockerfile, Mount volume will be overwritten","commit_id":"ef413177775b99482c7e2ed7fe21713264620253"}]}