)]}'
{"docker/neutron/neutron-base/Dockerfile.j2":[{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"807f3bed513654dca948ea6a18011921ec9d315b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            \u0027openvswitch-switch\u0027,"},{"line_number":24,"context_line":"            \u0027python-openvswitch\u0027"},{"line_number":25,"context_line":"        ] %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"RUN mkdir -p /usr/share/neutron \\"},{"line_number":28,"context_line":"    \u0026\u0026 ln -s /etc/neutron/api-paste.ini /usr/share/neutron/api-paste.ini"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_d1bc2108","line":26,"updated":"2016-08-11 08:24:07.000000000","message":"Because you are symlinking below to neutron files, you need to install the packages first. \n\nThe following needs to be at line 16 (for binary rhel install), and line 26 (for binary ubuntu install), and line 60 (for source install).\n\nRUN {{ macros.install_packages(neutron_base_packages | customizable(\"packages\")) }}\n\nYou can also remove it from the bottom of the file.","commit_id":"e02e6447d6a5ae12f373d202e05cbe49f0b2766d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a4e0d94c3bc2bd9770b753a6a7a741f5d261d3c0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_neutron_extend_start"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"{% block neutron_base_footer %}{% endblock %}"},{"line_number":93,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1ac06dbe_45fd9339","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":32},"updated":"2016-08-20 13:48:30.000000000","message":"Please, remove block footer line in base images","commit_id":"9ef42b32bec69b4c9c1bb5336c4e261901b454b7"}],"docker/neutron/neutron-dhcp-agent/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2f0a0d1890b477d9fb5fdf3c5c4d19dec5807307","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":7,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"        {% set neutron__packages \u003d ["},{"line_number":10,"context_line":"            \u0027neutron-dhcp-agent\u0027"},{"line_number":11,"context_line":"        ] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bacf61ea_e278d5fa","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":32},"updated":"2016-08-03 20:46:48.000000000","message":"Set neutron_dhcp_agent_packages","commit_id":"73f11e2ae3f757f43e211983540139208f035b39"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"807f3bed513654dca948ea6a18011921ec9d315b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN {{ macros.install_packages(neutron_dhcp_agent_packages | customizable(\"packages\")) }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_f1d96558","line":15,"updated":"2016-08-11 08:24:07.000000000","message":"As binary install is the only one defining packages, I would imagine you should put this within the logical scope of where the packages are defined at line 12.","commit_id":"e02e6447d6a5ae12f373d202e05cbe49f0b2766d"}],"docker/neutron/neutron-l3-agent/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2f0a0d1890b477d9fb5fdf3c5c4d19dec5807307","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}neutron-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bacf61ea_0286c9da","line":3,"updated":"2016-08-03 20:46:48.000000000","message":"Add {% import \"macros.j2\" as macros with context %}","commit_id":"73f11e2ae3f757f43e211983540139208f035b39"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2f0a0d1890b477d9fb5fdf3c5c4d19dec5807307","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"        {% set neutron__packages \u003d ["},{"line_number":8,"context_line":"            \u0027neutron-l3-agent\u0027"},{"line_number":9,"context_line":"        ] %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bacf61ea_e2c61515","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":32},"updated":"2016-08-03 20:46:48.000000000","message":"Set neutron_l3_agent_packages","commit_id":"73f11e2ae3f757f43e211983540139208f035b39"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2f0a0d1890b477d9fb5fdf3c5c4d19dec5807307","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    {% set neutron__packages \u003d ["},{"line_number":16,"context_line":"        \u0027keepalived\u0027"},{"line_number":17,"context_line":"    ] %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bacf61ea_02d409bb","line":15,"range":{"start_line":15,"start_character":11,"end_line":15,"end_character":28},"updated":"2016-08-03 20:46:48.000000000","message":"Ditto","commit_id":"73f11e2ae3f757f43e211983540139208f035b39"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2f0a0d1890b477d9fb5fdf3c5c4d19dec5807307","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"RUN {{ macros.install_packages(neutron_l3_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% block neutron_l3_agent_footer %}{% endblock %}"},{"line_number":24,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bacf61ea_62db45ee","line":21,"range":{"start_line":21,"start_character":31,"end_line":21,"end_character":50},"updated":"2016-08-03 20:46:48.000000000","message":"Ditto","commit_id":"73f11e2ae3f757f43e211983540139208f035b39"}],"docker/neutron/neutron-lbaas-agent/Dockerfile.j2":[{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"807f3bed513654dca948ea6a18011921ec9d315b","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% set neutron_lbaas_agent_packages \u003d ["},{"line_number":7,"context_line":"    \u0027haproxy\u0027"},{"line_number":8,"context_line":"] %}"},{"line_number":9,"context_line":"RUN {{ macros.install_packages(neutron_lbaas_agent_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_31eaddac","line":6,"updated":"2016-08-11 08:24:07.000000000","message":"There are other base_distro options than the ones specified in the original (such as Debian). Should you not still keep the logic for whether the distro is rhel based or debian based?","commit_id":"e02e6447d6a5ae12f373d202e05cbe49f0b2766d"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e081e6739b80bcf06726644b5022aac64aae75a2","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% set neutron_lbaas_agent_packages \u003d ["},{"line_number":7,"context_line":"    \u0027haproxy\u0027"},{"line_number":8,"context_line":"] %}"},{"line_number":9,"context_line":"RUN {{ macros.install_packages(neutron_lbaas_agent_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_57d8dc1d","line":6,"in_reply_to":"9ad45d7e_31eaddac","updated":"2016-08-19 11:18:30.000000000","message":"I thought this is a bug and that nobody tested on Debian. Why should it be necessary to install Haproxy on Ubuntu but not on Debian?","commit_id":"e02e6447d6a5ae12f373d202e05cbe49f0b2766d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1105374e334707b1a1da8d36b051dc5fd838da9a","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"        {% set neutron_lbaas_agent_packages \u003d ["},{"line_number":15,"context_line":"            \u0027openstack-neutron-lbaas\u0027,"},{"line_number":16,"context_line":"            \u0027net-tools\u0027"},{"line_number":17,"context_line":"        ] %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa7ab95a_2d433a14","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":22},"updated":"2016-08-30 16:05:11.000000000","message":"net-tools is already installed by the previous macro.install and can be removed from binary installs","commit_id":"6a6a87b5a0b1dfdd8ee4bd94c6795ae0a411782d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"1105374e334707b1a1da8d36b051dc5fd838da9a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            \u0027neutron-lbaas-common\u0027,"},{"line_number":23,"context_line":"            \u0027neutron-lbaasv2-agent\u0027,"},{"line_number":24,"context_line":"            \u0027python-neutron-lbaas\u0027,"},{"line_number":25,"context_line":"            \u0027net-tools\u0027"},{"line_number":26,"context_line":"        ] %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa7ab95a_ad4f4a32","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":22},"updated":"2016-08-30 16:05:11.000000000","message":"ditto","commit_id":"6a6a87b5a0b1dfdd8ee4bd94c6795ae0a411782d"}],"docker/neutron/neutron-linuxbridge-agent/Dockerfile.j2":[{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"807f3bed513654dca948ea6a18011921ec9d315b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    {% set neutron_linuxbridge_agent_packages \u003d ["},{"line_number":26,"context_line":"        \u0027bridge-utils\u0027,"},{"line_number":27,"context_line":"        \u0027ebtables\u0027"},{"line_number":28,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_d14701ba","line":25,"updated":"2016-08-11 08:24:07.000000000","message":"Ditto","commit_id":"e02e6447d6a5ae12f373d202e05cbe49f0b2766d"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e081e6739b80bcf06726644b5022aac64aae75a2","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    {% set neutron_linuxbridge_agent_packages \u003d ["},{"line_number":26,"context_line":"        \u0027bridge-utils\u0027,"},{"line_number":27,"context_line":"        \u0027ebtables\u0027"},{"line_number":28,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_972ff4f5","line":25,"in_reply_to":"9ad45d7e_d14701ba","updated":"2016-08-19 11:18:30.000000000","message":"See my note for neutron-lbaas-agent. Same here.","commit_id":"e02e6447d6a5ae12f373d202e05cbe49f0b2766d"}],"docker/neutron/neutron-metadata-agent/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2f0a0d1890b477d9fb5fdf3c5c4d19dec5807307","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":22,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/neutron_sudoers \\"},{"line_number":23,"context_line":"    \u0026\u0026 usermod -a -G kolla neutron"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ include_footer }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"USER neutron"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bacf61ea_827c79b6","line":24,"updated":"2016-08-03 20:46:48.000000000","message":"Add {% block neutron_metadata_agent_footer %}{% endblock %}\n{% block footer %}{% endblock %}","commit_id":"73f11e2ae3f757f43e211983540139208f035b39"}],"docker/neutron/neutron-openvswitch-agent/Dockerfile.j2":[{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"807f3bed513654dca948ea6a18011921ec9d315b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"RUN {{ macros.install_packages(neutron_openvswitch_agent_packages | customizable(\"packages\")) }}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% block neutron_openvswitch_footer %}{% endblock %}"},{"line_number":27,"context_line":"{% block footer %}{% endblock %}"},{"line_number":28,"context_line":"{{ include_footer }}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_d191c1f2","line":26,"updated":"2016-08-11 08:24:07.000000000","message":"This should be neutron_openvswitch_agent_footer","commit_id":"e02e6447d6a5ae12f373d202e05cbe49f0b2766d"}]}