)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7fea5c7f1173a98406cb1d791ad463f460997dff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhubingbing \u003c1392607554@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-06 18:59:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add sahara ansible roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I75b58248bfc4e86cace75faa82526d55a9ebbdbf"},{"line_number":10,"context_line":"Partially-Implements: blueprint ansible-sahara"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bacf61ea_46e5e7d9","line":7,"updated":"2016-08-07 04:42:26.000000000","message":"roles -\u003e role","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"},{"author":{"_account_id":15492,"name":"Robin Naundorf","email":"r.naundorf@fh-muenster.de","username":"senk"},"change_message_id":"69da4313708e892dadc07fc137ab6a36895fdeea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add sahara ansible roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I75b58248bfc4e86cace75faa82526d55a9ebbdbf"},{"line_number":10,"context_line":"Partially-Implements: blueprint ansible-sahara"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bacf61ea_164fa092","line":10,"updated":"2016-08-06 19:17:09.000000000","message":"blueprint ansible-sahara does not exist","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"76c3c2da277ea62255bf333b8daac5646351ee9b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add sahara ansible roles"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I75b58248bfc4e86cace75faa82526d55a9ebbdbf"},{"line_number":10,"context_line":"Partially-Implements: blueprint ansible-sahara"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bacf61ea_91ac3aee","line":10,"in_reply_to":"bacf61ea_164fa092","updated":"2016-08-06 19:45:04.000000000","message":"sorry，name is ：sahara-role\nI\u0027ll change it right now.","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[{"line_number":216,"context_line":"enable_neutron_lbaas: \"no\""},{"line_number":217,"context_line":"enable_neutron_qos: \"no\""},{"line_number":218,"context_line":"enable_swift: \"no\""},{"line_number":219,"context_line":"enable_sahara: \"no\""},{"line_number":220,"context_line":"enable_tempest: \"no\""},{"line_number":221,"context_line":"enable_watcher: \"no\""},{"line_number":222,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_ea84dcd3","line":219,"updated":"2016-08-05 08:17:15.000000000","message":"switch 218 and 219, follow the alphabet order rule.","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"cc7a5f2351428ef622aa107efc174249ed4804bd","unresolved":false,"context_lines":[{"line_number":233,"context_line":"enable_neutron_lbaas: \"no\""},{"line_number":234,"context_line":"enable_neutron_qos: \"no\""},{"line_number":235,"context_line":"enable_swift: \"no\""},{"line_number":236,"context_line":"enable_sahara: \"no\""},{"line_number":237,"context_line":"enable_tempest: \"no\""},{"line_number":238,"context_line":"enable_watcher: \"no\""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_21fe7838","line":236,"updated":"2016-08-09 14:27:54.000000000","message":"nit: should be before swift","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"8eec8f84f00f6790aefe4715230ead098a13eaac","unresolved":false,"context_lines":[{"line_number":232,"context_line":"enable_murano: \"no\""},{"line_number":233,"context_line":"enable_neutron_lbaas: \"no\""},{"line_number":234,"context_line":"enable_neutron_qos: \"no\""},{"line_number":235,"context_line":"enable_sahara: \"no\""},{"line_number":236,"context_line":"enable_sahara: \"no\""},{"line_number":237,"context_line":"enable_swift: \"no\""},{"line_number":238,"context_line":"enable_tempest: \"no\""},{"line_number":239,"context_line":"enable_watcher: \"no\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_03a7d84f","line":236,"range":{"start_line":235,"start_character":0,"end_line":236,"end_character":19},"updated":"2016-08-10 04:04:16.000000000","message":"duplicated","commit_id":"49b8721dc30696b187065ecf4a1fb766317d5f99"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"38e802de5e23f7a13dab1a955022ffaf6469df51","unresolved":false,"context_lines":[{"line_number":232,"context_line":"enable_murano: \"no\""},{"line_number":233,"context_line":"enable_neutron_lbaas: \"no\""},{"line_number":234,"context_line":"enable_neutron_qos: \"no\""},{"line_number":235,"context_line":"enable_sahara: \"no\""},{"line_number":236,"context_line":"enable_sahara: \"no\""},{"line_number":237,"context_line":"enable_swift: \"no\""},{"line_number":238,"context_line":"enable_tempest: \"no\""},{"line_number":239,"context_line":"enable_watcher: \"no\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_e6cf327d","line":236,"range":{"start_line":235,"start_character":0,"end_line":236,"end_character":19},"in_reply_to":"9ad45d7e_03a7d84f","updated":"2016-08-10 04:22:01.000000000","message":"sure，i fixed itnow","commit_id":"49b8721dc30696b187065ecf4a1fb766317d5f99"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"fb5dbfc393b13a039a9b29243bbbae81f85a4996","unresolved":false,"context_lines":[{"line_number":90,"context_line":"[sahara:children]"},{"line_number":91,"context_line":"control"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Tempest"},{"line_number":94,"context_line":"[tempest:children]"},{"line_number":95,"context_line":"control"},{"line_number":96,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9ad45d7e_3b91a1f1","line":93,"updated":"2016-08-09 03:49:29.000000000","message":"Is this line relevant to the patch?","commit_id":"cde0dad3831148a56fccbf29336857a0e9189e78"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"732c7574cb18ab0e25e213734b3a2e23a0f6694f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"[sahara:children]"},{"line_number":91,"context_line":"control"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Tempest"},{"line_number":94,"context_line":"[tempest:children]"},{"line_number":95,"context_line":"control"},{"line_number":96,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9ad45d7e_c99fdf01","line":93,"in_reply_to":"9ad45d7e_3b91a1f1","updated":"2016-08-09 07:57:24.000000000","message":"i fix now","commit_id":"cde0dad3831148a56fccbf29336857a0e9189e78"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"312c100321633488f452516a01e2950e28ac4515","unresolved":false,"context_lines":[{"line_number":90,"context_line":"[sahara:children]"},{"line_number":91,"context_line":"control"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Tempest"},{"line_number":94,"context_line":"[tempest:children]"},{"line_number":95,"context_line":"control"},{"line_number":96,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3ac371cc_685adb2b","line":93,"updated":"2016-08-17 01:03:40.000000000","message":"Remove this line","commit_id":"077d006dc23aeeef43a2dd73e6cc8dfa2e4140d4"}],"ansible/roles/haproxy/templates/haproxy.cfg.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e8be0fa46b3ee5ab7e6f844d838d740328b67db9","unresolved":false,"context_lines":[{"line_number":350,"context_line":"{% endif %}"},{"line_number":351,"context_line":"{% endif %}"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"{% if enable_sahara | bool }"},{"line_number":354,"context_line":"listen sahara_api"},{"line_number":355,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ sahara_api_port }}"},{"line_number":356,"context_line":"{% for host in groups[\u0027watcher-api\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"9a89bdaa_963167a5","line":353,"range":{"start_line":353,"start_character":27,"end_line":353,"end_character":28},"updated":"2016-09-05 13:49:15.000000000","message":"Close it %}","commit_id":"9aaa1ed6333135ab3a119eaa3b0fe717d7581dd6"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e8be0fa46b3ee5ab7e6f844d838d740328b67db9","unresolved":false,"context_lines":[{"line_number":353,"context_line":"{% if enable_sahara | bool }"},{"line_number":354,"context_line":"listen sahara_api"},{"line_number":355,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ sahara_api_port }}"},{"line_number":356,"context_line":"{% for host in groups[\u0027watcher-api\u0027] %}"},{"line_number":357,"context_line":"  server {{ hostvars[host][\u0027ansible_hostname\u0027] }} {{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ sahara_api_port }} check inter 2000 rise 2 fall 5"},{"line_number":358,"context_line":"{% endfor %}"},{"line_number":359,"context_line":"{% if haproxy_enable_external_vip | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"9a89bdaa_eec4a641","line":356,"range":{"start_line":356,"start_character":23,"end_line":356,"end_character":30},"updated":"2016-09-05 13:49:15.000000000","message":"watcher/sahara","commit_id":"9aaa1ed6333135ab3a119eaa3b0fe717d7581dd6"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e8be0fa46b3ee5ab7e6f844d838d740328b67db9","unresolved":false,"context_lines":[{"line_number":357,"context_line":"  server {{ hostvars[host][\u0027ansible_hostname\u0027] }} {{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ sahara_api_port }} check inter 2000 rise 2 fall 5"},{"line_number":358,"context_line":"{% endfor %}"},{"line_number":359,"context_line":"{% if haproxy_enable_external_vip | bool %}"},{"line_number":360,"context_line":" "},{"line_number":361,"context_line":"listen sahara_api_external"},{"line_number":362,"context_line":"  bind {{ kolla_external_vip_address }}:{{ sahara_api_port }} {{ tls_bind_info }}"},{"line_number":363,"context_line":"{% for host in groups[\u0027sahara-api\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"9a89bdaa_8eb5dace","line":360,"range":{"start_line":360,"start_character":0,"end_line":360,"end_character":1},"updated":"2016-09-05 13:49:15.000000000","message":"nit: remove whitespace","commit_id":"9aaa1ed6333135ab3a119eaa3b0fe717d7581dd6"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"93821bee5c40e24a937cecb141cfd5e7548eeeb9","unresolved":false,"context_lines":[{"line_number":357,"context_line":"  server {{ hostvars[host][\u0027ansible_hostname\u0027] }} {{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ sahara_api_port }} check inter 2000 rise 2 fall 5"},{"line_number":358,"context_line":"{% endfor %}"},{"line_number":359,"context_line":"{% if haproxy_enable_external_vip | bool %}"},{"line_number":360,"context_line":" "},{"line_number":361,"context_line":"listen sahara_api_external"},{"line_number":362,"context_line":"  bind {{ kolla_external_vip_address }}:{{ sahara_api_port }} {{ tls_bind_info }}"},{"line_number":363,"context_line":"{% for host in groups[\u0027sahara-api\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"9a89bdaa_8bf4d587","line":360,"range":{"start_line":360,"start_character":0,"end_line":360,"end_character":1},"updated":"2016-09-05 19:24:13.000000000","message":"nit: please, remove white space","commit_id":"9fe27d6e3aff787d24e46baaa4e240433b7dfb2c"}],"ansible/roles/sahara/defaults/main.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"####################"},{"line_number":28,"context_line":"# OpenStack"},{"line_number":29,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_ca7918fe","line":26,"updated":"2016-08-05 08:17:15.000000000","message":"too many empty lines. keep two lines is enough.","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"}],"ansible/roles/sahara/meta/main.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027ceilometer.yml\u0027  }"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_4a27e811","line":3,"updated":"2016-08-05 08:17:15.000000000","message":"typo: ceilometer -\u003e sahara","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"fb5dbfc393b13a039a9b29243bbbae81f85a4996","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027sahara.yml\u0027  }"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_5b829595","line":3,"updated":"2016-08-09 03:49:29.000000000","message":"remove extra space","commit_id":"cde0dad3831148a56fccbf29336857a0e9189e78"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"732c7574cb18ab0e25e213734b3a2e23a0f6694f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027sahara.yml\u0027  }"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_c944ff75","line":3,"in_reply_to":"9ad45d7e_5b829595","updated":"2016-08-09 07:57:24.000000000","message":"i fit now","commit_id":"cde0dad3831148a56fccbf29336857a0e9189e78"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d7325de8c26febbfd612db2693e72cbdb8663b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:  "},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027sahara.yml\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_74184385","line":2,"range":{"start_line":2,"start_character":13,"end_line":2,"end_character":15},"updated":"2016-08-09 08:29:46.000000000","message":"Please, remove whitespace","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"dd1433c269215db330bfa90eb053b61572d4226f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:  "},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027sahara.yml\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_d88b191d","line":2,"range":{"start_line":2,"start_character":13,"end_line":2,"end_character":15},"in_reply_to":"9ad45d7e_74184385","updated":"2016-08-09 11:01:28.000000000","message":"i fixed now","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"cc7a5f2351428ef622aa107efc174249ed4804bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027sahara.yml\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_2185d8ac","line":3,"range":{"start_line":3,"start_character":20,"end_line":3,"end_character":45},"updated":"2016-08-09 14:27:54.000000000","message":"I think this is not necessary.","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"bc3104d436539abf8453e786636a9c73a856eb79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027sahara.yml\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_209f8e51","line":3,"updated":"2016-08-22 04:05:48.000000000","message":"Remove \"project_yaml:\u0027sahara.yml\u0027 \"","commit_id":"389d8f68ac93b16283ce52ad35f7a778355a63e4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e6c1d16db85295e36eae3b8b29e46c6cc9641258","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027sahara.yml\u0027 }"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"fa7ab95a_e0cff07c","line":3,"range":{"start_line":3,"start_character":18,"end_line":3,"end_character":46},"updated":"2016-09-01 22:22:38.000000000","message":"project_yaml is not needed","commit_id":"810970980c241188dc6cc70bce20cc818bb3dbb5"}],"ansible/roles/sahara/tasks/bootstrap.yml":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"bc3104d436539abf8453e786636a9c73a856eb79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Creating sahara database"},{"line_number":3,"context_line":"  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost"},{"line_number":4,"context_line":"    -m mysql_db"},{"line_number":5,"context_line":"    -a \"login_host\u003d\u0027{{ database_address }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_a0b9becd","line":2,"updated":"2016-08-22 04:05:48.000000000","message":"Capitalize Sahara","commit_id":"389d8f68ac93b16283ce52ad35f7a778355a63e4"}],"ansible/roles/sahara/tasks/bootstrap_service.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    restart_policy: \"never\""},{"line_number":16,"context_line":"    volumes:"},{"line_number":17,"context_line":"      - \"{{ node_config_directory }}/sahara-api/:{{ container_config_directory }}/:ro\""},{"line_number":18,"context_line":"      - \"sahara:/var/lib/sahara/\""},{"line_number":19,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":20,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":21,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_6a1aacc7","line":18,"updated":"2016-08-05 08:17:15.000000000","message":"move this to the last one. follow the alphabet order rule.","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7fea5c7f1173a98406cb1d791ad463f460997dff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Running sahara bootstrap container"},{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"start_container\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_c6d9d723","line":2,"updated":"2016-08-07 04:42:26.000000000","message":"Capitalization: sahara -\u003e Sahara","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"}],"ansible/roles/sahara/tasks/config.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    - \"sahara-api\""},{"line_number":32,"context_line":"    - \"sahara-engine\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Copying over policy.json  "},{"line_number":35,"context_line":"  template:"},{"line_number":36,"context_line":"    src: \"policy.json.j2\""},{"line_number":37,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/policy.json\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_2a6b941f","line":34,"updated":"2016-08-05 08:17:15.000000000","message":"no need copy this file now.","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - \"sahara-api\""},{"line_number":40,"context_line":"    - \"sahara-engine\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Copying over api-paste.ini"},{"line_number":43,"context_line":"  template:"},{"line_number":44,"context_line":"    src: \"api-paste.ini.j2\""},{"line_number":45,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/api-paste.ini\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_8a7440fe","line":42,"updated":"2016-08-05 08:17:15.000000000","message":"no need copy this file now.","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"fb5dbfc393b13a039a9b29243bbbae81f85a4996","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - \"sahara-api\""},{"line_number":9,"context_line":"    - \"sahara-engine\""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_1e148b42","line":7,"updated":"2016-08-09 03:49:29.000000000","message":"can you use the service group variable [1] to remove some duplicate line?\n\n[1] https://github.com/openstack/kolla/blob/master/ansible/roles/glance/defaults/main.yml#L3","commit_id":"cde0dad3831148a56fccbf29336857a0e9189e78"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d7325de8c26febbfd612db2693e72cbdb8663b8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      - \"/etc/kolla/config/global.conf\""},{"line_number":26,"context_line":"      - \"/etc/kolla/config/database.conf\""},{"line_number":27,"context_line":"      - \"/etc/kolla/config/messaging.conf\""},{"line_number":28,"context_line":"      - \"/etc/kolla/config/glance.conf\""},{"line_number":29,"context_line":"      - \"/etc/kolla/config/glance/{{ item }}.conf\""},{"line_number":30,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/sahara.conf\""},{"line_number":31,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_77820554","line":28,"range":{"start_line":28,"start_character":27,"end_line":28,"end_character":33},"updated":"2016-08-09 08:29:46.000000000","message":"s/glance/sahara/g","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d7325de8c26febbfd612db2693e72cbdb8663b8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - \"/etc/kolla/config/database.conf\""},{"line_number":27,"context_line":"      - \"/etc/kolla/config/messaging.conf\""},{"line_number":28,"context_line":"      - \"/etc/kolla/config/glance.conf\""},{"line_number":29,"context_line":"      - \"/etc/kolla/config/glance/{{ item }}.conf\""},{"line_number":30,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/sahara.conf\""},{"line_number":31,"context_line":"  with_items:"},{"line_number":32,"context_line":"    - \"sahara-api\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_f796f592","line":29,"range":{"start_line":29,"start_character":27,"end_line":29,"end_character":33},"updated":"2016-08-09 08:29:46.000000000","message":"Ditto","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"91e40d53248ab1bdf8235fe2a3eee82637431207","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":26,"context_line":"      - \"{{ node_custom_config }}/database.conf\""},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/messaging.conf\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/glance.conf\""},{"line_number":29,"context_line":"      - \"{{ node_custom_config }}/glance/{{ item }}.conf\""},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ item }}.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ inventory_hostname }}/sahara.conf\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_63224203","line":28,"range":{"start_line":28,"start_character":34,"end_line":28,"end_character":40},"updated":"2016-08-09 11:09:06.000000000","message":"Missed change glance with sahara","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"47f13ad134b6eccd95d3031a18adfe626edaa951","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":26,"context_line":"      - \"{{ node_custom_config }}/database.conf\""},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/messaging.conf\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/glance.conf\""},{"line_number":29,"context_line":"      - \"{{ node_custom_config }}/glance/{{ item }}.conf\""},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ item }}.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ inventory_hostname }}/sahara.conf\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_c9c98d7a","line":28,"range":{"start_line":28,"start_character":34,"end_line":28,"end_character":40},"in_reply_to":"9ad45d7e_63224203","updated":"2016-08-09 11:46:07.000000000","message":"Done","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"91e40d53248ab1bdf8235fe2a3eee82637431207","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - \"{{ node_custom_config }}/database.conf\""},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/messaging.conf\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/glance.conf\""},{"line_number":29,"context_line":"      - \"{{ node_custom_config }}/glance/{{ item }}.conf\""},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ item }}.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ inventory_hostname }}/sahara.conf\""},{"line_number":32,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/sahara.conf\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_c3216efd","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":40},"updated":"2016-08-09 11:09:06.000000000","message":"Ditto","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"47f13ad134b6eccd95d3031a18adfe626edaa951","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - \"{{ node_custom_config }}/database.conf\""},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/messaging.conf\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/glance.conf\""},{"line_number":29,"context_line":"      - \"{{ node_custom_config }}/glance/{{ item }}.conf\""},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ item }}.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ inventory_hostname }}/sahara.conf\""},{"line_number":32,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/sahara.conf\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_09a285ae","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":40},"in_reply_to":"9ad45d7e_c3216efd","updated":"2016-08-09 11:46:07.000000000","message":"Done","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c784776e05e2cbf85ba67c1798653f981e49acb3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":26,"context_line":"      - \"{{ node_custom_config }}/database.conf\""},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/messaging.conf\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/glance.conf\""},{"line_number":29,"context_line":"      - \"{{ node_custom_config }}/glance/{{ item }}.conf\""},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ item }}.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ inventory_hostname }}/sahara.conf\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9ad45d7e_662a1d2e","line":28,"range":{"start_line":28,"start_character":34,"end_line":28,"end_character":40},"updated":"2016-08-10 07:23:15.000000000","message":"Please, change glance with sahara","commit_id":"22a0c847bc56bf26616d4cad562ce302c1187c9d"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"29a99f64ad94b7fc62e02c5bf422eb08900bdb38","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":26,"context_line":"      - \"{{ node_custom_config }}/database.conf\""},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/messaging.conf\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/glance.conf\""},{"line_number":29,"context_line":"      - \"{{ node_custom_config }}/glance/{{ item }}.conf\""},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ item }}.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ inventory_hostname }}/sahara.conf\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9ad45d7e_a621b5b6","line":28,"range":{"start_line":28,"start_character":34,"end_line":28,"end_character":40},"in_reply_to":"9ad45d7e_662a1d2e","updated":"2016-08-10 07:28:54.000000000","message":"sure，good i fixed now","commit_id":"22a0c847bc56bf26616d4cad562ce302c1187c9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c784776e05e2cbf85ba67c1798653f981e49acb3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - \"{{ node_custom_config }}/database.conf\""},{"line_number":27,"context_line":"      - \"{{ node_custom_config }}/messaging.conf\""},{"line_number":28,"context_line":"      - \"{{ node_custom_config }}/glance.conf\""},{"line_number":29,"context_line":"      - \"{{ node_custom_config }}/glance/{{ item }}.conf\""},{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ item }}.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/sahara/{{ inventory_hostname }}/sahara.conf\""},{"line_number":32,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/sahara.conf\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9ad45d7e_a61c1514","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":40},"updated":"2016-08-10 07:23:15.000000000","message":"Ditto","commit_id":"22a0c847bc56bf26616d4cad562ce302c1187c9d"}],"ansible/roles/sahara/tasks/deploy.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bacf61ea_aa7e64e1","updated":"2016-08-05 08:17:15.000000000","message":"lots of ceilometer in this file.","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d7325de8c26febbfd612db2693e72cbdb8663b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- include: config.yml"},{"line_number":6,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_573c2193","line":3,"range":{"start_line":3,"start_character":38,"end_line":3,"end_character":44},"updated":"2016-08-09 08:29:46.000000000","message":"This used to be sahara-api only","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"dd1433c269215db330bfa90eb053b61572d4226f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- include: config.yml"},{"line_number":6,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_a3a9da7d","line":3,"range":{"start_line":3,"start_character":38,"end_line":3,"end_character":44},"in_reply_to":"9ad45d7e_573c2193","updated":"2016-08-09 11:01:28.000000000","message":"Done","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d7325de8c26febbfd612db2693e72cbdb8663b8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- include: config.yml"},{"line_number":6,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include: bootstrap.yml"},{"line_number":9,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_d76f7190","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":46},"updated":"2016-08-09 08:29:46.000000000","message":"Usually here is used something like this:\n when: inventory_hostname in groups[\u0027sahara-api\u0027] or\n       inventory_hostname in groups[\u0027sahara-engine\u0027]","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"dd1433c269215db330bfa90eb053b61572d4226f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- include: config.yml"},{"line_number":6,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include: bootstrap.yml"},{"line_number":9,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_83cbf652","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":46},"in_reply_to":"9ad45d7e_d76f7190","updated":"2016-08-09 11:01:28.000000000","message":"i fix now","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d7325de8c26febbfd612db2693e72cbdb8663b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include: bootstrap.yml"},{"line_number":9,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- include: start.yml"},{"line_number":12,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_170109af","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":44},"updated":"2016-08-09 08:29:46.000000000","message":"Here sahara-api only","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d7325de8c26febbfd612db2693e72cbdb8663b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- include: start.yml"},{"line_number":12,"context_line":"  when: inventory_hostname in groups[\u0027sahara\u0027]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_b7b47df2","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":46},"updated":"2016-08-09 08:29:46.000000000","message":"The same as config.yml\n when: inventory_hostname in groups[\u0027sahara-api\u0027] or\n       inventory_hostname in groups[\u0027sahara-engine\u0027]","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"91e40d53248ab1bdf8235fe2a3eee82637431207","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"},{"line_number":4,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027] "},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: config.yml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_a34a7aaa","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":53},"updated":"2016-08-09 11:09:06.000000000","message":"Register only with sahara-api","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"47f13ad134b6eccd95d3031a18adfe626edaa951","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"},{"line_number":4,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027] "},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: config.yml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_8996754a","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":53},"in_reply_to":"9ad45d7e_a34a7aaa","updated":"2016-08-09 11:46:07.000000000","message":"Done","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"cc7a5f2351428ef622aa107efc174249ed4804bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"},{"line_number":4,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027] "},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: config.yml"},{"line_number":7,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_4178ccc4","line":4,"range":{"start_line":4,"start_character":53,"end_line":4,"end_character":54},"updated":"2016-08-09 14:27:54.000000000","message":"trailing whitespace","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"91e40d53248ab1bdf8235fe2a3eee82637431207","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- include: bootstrap.yml"},{"line_number":11,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"},{"line_number":12,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- include: start.yml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_03c8a621","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"updated":"2016-08-09 11:09:06.000000000","message":"Ditto","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"47f13ad134b6eccd95d3031a18adfe626edaa951","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- include: bootstrap.yml"},{"line_number":11,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"},{"line_number":12,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- include: start.yml"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_69918152","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"9ad45d7e_03c8a621","updated":"2016-08-09 11:46:07.000000000","message":"Done","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c784776e05e2cbf85ba67c1798653f981e49acb3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"},{"line_number":4,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027]"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: config.yml"},{"line_number":7,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9ad45d7e_e6728d48","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":53},"updated":"2016-08-10 07:23:15.000000000","message":"register.yml is only made at sahara-api, remove sahara-engine","commit_id":"22a0c847bc56bf26616d4cad562ce302c1187c9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c784776e05e2cbf85ba67c1798653f981e49acb3","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- include: bootstrap.yml"},{"line_number":11,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"},{"line_number":12,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- include: start.yml"},{"line_number":15,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9ad45d7e_a69ff54e","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":53},"updated":"2016-08-10 07:23:15.000000000","message":"Ditto","commit_id":"22a0c847bc56bf26616d4cad562ce302c1187c9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e6c1d16db85295e36eae3b8b29e46c6cc9641258","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"},{"line_number":4,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027]"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: config.yml"},{"line_number":7,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"fa7ab95a_c0b2ece4","line":4,"range":{"start_line":3,"start_character":51,"end_line":4,"end_character":53},"updated":"2016-09-01 22:22:38.000000000","message":"Register is only made at sahara-api container","commit_id":"810970980c241188dc6cc70bce20cc818bb3dbb5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e6c1d16db85295e36eae3b8b29e46c6cc9641258","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- include: bootstrap.yml"},{"line_number":11,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"},{"line_number":12,"context_line":"        inventory_hostname in groups[\u0027sahara-engine\u0027]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- include: start.yml"},{"line_number":15,"context_line":"  when: inventory_hostname in groups[\u0027sahara-api\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"fa7ab95a_20c2b834","line":12,"range":{"start_line":11,"start_character":51,"end_line":12,"end_character":53},"updated":"2016-09-01 22:22:38.000000000","message":"Ditto","commit_id":"810970980c241188dc6cc70bce20cc818bb3dbb5"}],"ansible/roles/sahara/tasks/do_reconfigure.yml":[{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"70d963514f840e74f03a1f8cd7002468f13ef756","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  with_together:"},{"line_number":50,"context_line":"    - [{ name: sahara_api, group: sahara-api },"},{"line_number":51,"context_line":"       { name: sahara_engine, group: sahara-engine },]"},{"line_number":52,"context_line":"    - container_envs.results"},{"line_number":53,"context_line":"    - check_results.results"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- include: start.yml"},{"line_number":56,"context_line":"  when: remove_containers.changed"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_e37d641d","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":27},"updated":"2016-08-10 03:47:31.000000000","message":"You should use full variable syntax here.\n\nEx: \"{{ container_envs.result }}\"","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"70d963514f840e74f03a1f8cd7002468f13ef756","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  with_together:"},{"line_number":68,"context_line":"    - [{ name: sahara_api, group: sahara-api },"},{"line_number":69,"context_line":"       { name: sahara_engine, group: sahara-engine },]"},{"line_number":70,"context_line":"    - container_envs.results"},{"line_number":71,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_e3a444a7","line":71,"range":{"start_line":70,"start_character":1,"end_line":71,"end_character":27},"updated":"2016-08-10 03:47:31.000000000","message":"You should use full variable syntax here.\n\nEx: \"{{ container_envs.result }}\"","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"8eec8f84f00f6790aefe4715230ead098a13eaac","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  with_together:"},{"line_number":50,"context_line":"    - [{ name: sahara_api, group: sahara-api },"},{"line_number":51,"context_line":"       { name: sahara_engine, group: sahara-engine },]"},{"line_number":52,"context_line":"    - container_envs.results"},{"line_number":53,"context_line":"    - check_results.results"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- include: start.yml"},{"line_number":56,"context_line":"  when: remove_containers.changed"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_a33c0ce3","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":27},"updated":"2016-08-10 04:04:16.000000000","message":"It\u0027s better to use full variables syntax here, ex in my comments in your previous patch set","commit_id":"49b8721dc30696b187065ecf4a1fb766317d5f99"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"2af60f7262b60130a97827940bd2c1f47f688e1f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  with_together:"},{"line_number":50,"context_line":"    - [{ name: sahara_api, group: sahara-api },"},{"line_number":51,"context_line":"       { name: sahara_engine, group: sahara-engine },]"},{"line_number":52,"context_line":"    - container_envs.results"},{"line_number":53,"context_line":"    - check_results.results"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- include: start.yml"},{"line_number":56,"context_line":"  when: remove_containers.changed"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_e640d2a7","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":27},"in_reply_to":"9ad45d7e_66bb42e6","updated":"2016-08-10 04:31:17.000000000","message":"bp ansible2 [1] is on progress, so many modules are still written like your.\n\n[1] https://blueprints.launchpad.net/kolla/+spec/ansible2","commit_id":"49b8721dc30696b187065ecf4a1fb766317d5f99"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"38e802de5e23f7a13dab1a955022ffaf6469df51","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  with_together:"},{"line_number":50,"context_line":"    - [{ name: sahara_api, group: sahara-api },"},{"line_number":51,"context_line":"       { name: sahara_engine, group: sahara-engine },]"},{"line_number":52,"context_line":"    - container_envs.results"},{"line_number":53,"context_line":"    - check_results.results"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- include: start.yml"},{"line_number":56,"context_line":"  when: remove_containers.changed"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_66bb42e6","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":27},"in_reply_to":"9ad45d7e_a33c0ce3","updated":"2016-08-10 04:22:01.000000000","message":"I don\u0027t think it\u0027s necessary to do so, and the other modules are written like me","commit_id":"49b8721dc30696b187065ecf4a1fb766317d5f99"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"8eec8f84f00f6790aefe4715230ead098a13eaac","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  with_together:"},{"line_number":68,"context_line":"    - [{ name: sahara_api, group: sahara-api },"},{"line_number":69,"context_line":"       { name: sahara_engine, group: sahara-engine },]"},{"line_number":70,"context_line":"    - container_envs.results"},{"line_number":71,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_431c3077","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":27},"updated":"2016-08-10 04:04:16.000000000","message":"Should use full variable syntax here, too","commit_id":"49b8721dc30696b187065ecf4a1fb766317d5f99"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"312c100321633488f452516a01e2950e28ac4515","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  with_items:"},{"line_number":10,"context_line":"    - { name: sahara_api, group: sahara-api }"},{"line_number":11,"context_line":"    - { name: sahara_engine, group: sahara-engine }"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- include: config.yml"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_c83cafca","line":12,"updated":"2016-08-17 01:03:40.000000000","message":"Please use one line space","commit_id":"077d006dc23aeeef43a2dd73e6cc8dfa2e4140d4"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"312c100321633488f452516a01e2950e28ac4515","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  with_items:"},{"line_number":36,"context_line":"    - { name: sahara_api, group: sahara-api }"},{"line_number":37,"context_line":"    - { name: sahara_engine, group: sahara-engine }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Remove the containers"},{"line_number":41,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_a83973d9","line":38,"updated":"2016-08-17 01:03:40.000000000","message":"Ditto","commit_id":"077d006dc23aeeef43a2dd73e6cc8dfa2e4140d4"}],"ansible/roles/sahara/tasks/pull.yml":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7fea5c7f1173a98406cb1d791ad463f460997dff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: Pulling sahara-engine image"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"pull_image\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_a6d4a3e8","line":2,"updated":"2016-08-07 04:42:26.000000000","message":"remove blank line","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"}],"ansible/roles/sahara/tasks/register.yml":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7fea5c7f1173a98406cb1d791ad463f460997dff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Creating the sahara service and endpoint"},{"line_number":3,"context_line":"  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost"},{"line_number":4,"context_line":"    -m kolla_keystone_service"},{"line_number":5,"context_line":"    -a \"service_name\u003dsahara"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_e6085b93","line":2,"updated":"2016-08-07 04:42:26.000000000","message":"Sahara","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7fea5c7f1173a98406cb1d791ad463f460997dff","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - {\u0027interface\u0027: \u0027internal\u0027, \u0027url\u0027: \u0027{{ sahara_internal_endpoint }}\u0027}"},{"line_number":23,"context_line":"    - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ sahara_public_endpoint }}\u0027}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Creating the sahara project, user, and role"},{"line_number":26,"context_line":"  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost"},{"line_number":27,"context_line":"    -m kolla_keystone_user"},{"line_number":28,"context_line":"    -a \"project\u003dservice"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_06064f85","line":25,"updated":"2016-08-07 04:42:26.000000000","message":"ditto","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"cc7a5f2351428ef622aa107efc174249ed4804bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    -m kolla_keystone_service"},{"line_number":5,"context_line":"    -a \"service_name\u003dsahara"},{"line_number":6,"context_line":"        service_type\u003ddata_processing"},{"line_number":7,"context_line":"        description\u003d\u0027Sahara Data Processing\u0027"},{"line_number":8,"context_line":"        endpoint_region\u003d{{ openstack_region_name }}"},{"line_number":9,"context_line":"        url\u003d\u0027{{ item.url }}\u0027"},{"line_number":10,"context_line":"        interface\u003d\u0027{{ item.interface }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9ad45d7e_8159245d","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":43},"updated":"2016-08-09 14:27:54.000000000","message":"OpenStack Data Processing","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"}],"ansible/roles/sahara/tasks/start.yml":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7fea5c7f1173a98406cb1d791ad463f460997dff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: Starting sahara-api container"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"start_container\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bacf61ea_46fcc771","line":2,"updated":"2016-08-07 04:42:26.000000000","message":"blank line","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"}],"ansible/roles/sahara/templates/api-paste.ini.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bacf61ea_4a6ec82f","updated":"2016-08-05 08:17:15.000000000","message":"we are not touch this file in Kolla. no need add it as template.","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"}],"ansible/roles/sahara/templates/policy.json.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bacf61ea_ea0dfc8f","updated":"2016-08-05 08:17:15.000000000","message":"ditto","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"}],"ansible/roles/sahara/templates/sahara-api.json.j2":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7fea5c7f1173a98406cb1d791ad463f460997dff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_26ff1367","line":12,"updated":"2016-08-07 04:42:26.000000000","message":"remove the last line","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"312c100321633488f452516a01e2950e28ac4515","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"sahara-api --config-file /etc/sahara/sahara.conf\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/sahara.conf\","}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"3ac371cc_88075717","line":2,"updated":"2016-08-17 01:03:40.000000000","message":"Is the \"--config-file\" necessary? Should it be the default location?","commit_id":"077d006dc23aeeef43a2dd73e6cc8dfa2e4140d4"}],"ansible/roles/sahara/templates/sahara-engine.json.j2":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7fea5c7f1173a98406cb1d791ad463f460997dff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_86fa3f73","line":12,"updated":"2016-08-07 04:42:26.000000000","message":"ditto","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"312c100321633488f452516a01e2950e28ac4515","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"sahara-engine --config-file /etc/sahara/sahara.conf\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/sahara.conf\","}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"3ac371cc_c815cf40","line":2,"updated":"2016-08-17 01:03:40.000000000","message":"Same as the previous file.","commit_id":"077d006dc23aeeef43a2dd73e6cc8dfa2e4140d4"}],"ansible/roles/sahara/templates/sahara.conf.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"os_region_name\u003dRegionOne"},{"line_number":9,"context_line":"port \u003d {{ sahara_api_port }}"},{"line_number":10,"context_line":"host \u003d 0.0.0.0"},{"line_number":11,"context_line":"api_paste_config \u003d /etc/sahara/api-paste.ini"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"use_neutron \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bacf61ea_2a24340b","line":10,"updated":"2016-08-05 08:17:15.000000000","message":"bind to ip.","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"api_paste_config \u003d /etc/sahara/api-paste.ini"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"use_neutron \u003d True"},{"line_number":14,"context_line":"api_workers \u003d 2"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"use_floating_ips \u003d False"},{"line_number":17,"context_line":"use_namespaces \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bacf61ea_8a1d60c0","line":14,"updated":"2016-08-05 08:17:15.000000000","message":"use the global veriables for this.","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7fea5c7f1173a98406cb1d791ad463f460997dff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"debug \u003d {{ sahara_logging_debug }}"},{"line_number":4,"context_line":"verbose \u003d True"},{"line_number":5,"context_line":"log_dir \u003d /var/log/kolla/sahara"},{"line_number":6,"context_line":"rpc_backend \u003d rabbit"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_062daffd","line":4,"updated":"2016-08-07 04:42:26.000000000","message":"I do not remember any service in kolla sets verbose as True","commit_id":"1e36733e6992f1a514bc0bf5ba065404f421c9e8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d7325de8c26febbfd612db2693e72cbdb8663b8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"log_dir \u003d /var/log/kolla/sahara"},{"line_number":5,"context_line":"rpc_backend \u003d rabbit"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"os_region_name\u003dRegionOne"},{"line_number":8,"context_line":"port \u003d {{ sahara_api_port }}"},{"line_number":9,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ad45d7e_5236ef03","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":15},"updated":"2016-08-09 08:29:46.000000000","message":"Add whitespace before and after equal sign","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3d7325de8c26febbfd612db2693e72cbdb8663b8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"[keystone_authtoken]"},{"line_number":29,"context_line":"memcached_servers \u003d {{ kolla_internal_fqdn }}:{{ memcached_port }}"},{"line_number":30,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"},{"line_number":31,"context_line":"project_domain_name \u003d default"},{"line_number":32,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ad45d7e_92bb4772","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":66},"updated":"2016-08-09 08:29:46.000000000","message":"Should be configured with a list of memcached nodes.\nCheck glance-api.conf as an example, where it is also configured to support kubernetes https://github.com/openstack/kolla/blob/master/ansible/roles/glance/templates/glance-api.conf.j2\n\nMove it after all keystone auth configuration","commit_id":"203adb960a93ae9af2ea01c66b9902d84f0e3d5d"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"cc7a5f2351428ef622aa107efc174249ed4804bd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"port \u003d {{ sahara_api_port }}"},{"line_number":6,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":7,"context_line":"use_neutron \u003d True"},{"line_number":8,"context_line":"api_workers \u003d 2"},{"line_number":9,"context_line":"use_floating_ips \u003d False"},{"line_number":10,"context_line":"use_namespaces \u003d True"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9ad45d7e_a11b887f","line":8,"range":{"start_line":8,"start_character":14,"end_line":8,"end_character":15},"updated":"2016-08-09 14:27:54.000000000","message":"{{ openstack_service_workers }}","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"91e40d53248ab1bdf8235fe2a3eee82637431207","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[keystone_authtoken]"},{"line_number":25,"context_line":"memcached_servers \u003d {{ kolla_internal_fqdn }}:{{ memcached_port }}"},{"line_number":26,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"},{"line_number":27,"context_line":"project_domain_name \u003d default"},{"line_number":28,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9ad45d7e_a3a6fa50","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":17},"updated":"2016-08-09 11:09:06.000000000","message":"Change, to a list of memcached servers as suggested at last comment","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"cc7a5f2351428ef622aa107efc174249ed4804bd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"user_domain_name \u003d default"},{"line_number":30,"context_line":"username \u003d {{ sahara_keystone_user }}"},{"line_number":31,"context_line":"password \u003d {{ sahara_keystone_password }}"},{"line_number":32,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3"},{"line_number":33,"context_line":"auth_type \u003d password"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9ad45d7e_64199e79","line":32,"range":{"start_line":32,"start_character":85,"end_line":32,"end_character":88},"updated":"2016-08-09 14:27:54.000000000","message":"Is it required to explicitly set this?","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"cc7a5f2351428ef622aa107efc174249ed4804bd","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[profiler]"},{"line_number":48,"context_line":"enabled \u003d False"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9ad45d7e_443bbad1","line":48,"updated":"2016-08-09 14:27:54.000000000","message":"Is it enabled by default?","commit_id":"aed3f34ca2df19772ee7f68747c725211497caa7"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e6c1d16db85295e36eae3b8b29e46c6cc9641258","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[database]"},{"line_number":14,"context_line":"connection \u003d mysql+pymysql://{{ sahara_database_user }}:{{ sahara_database_password }}@{{ sahara_database_address }}/{{ sahara_database_name }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[oslo_messaging_rabbit]"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"fa7ab95a_03121e57","line":14,"range":{"start_line":14,"start_character":59,"end_line":14,"end_character":83},"updated":"2016-09-01 22:22:38.000000000","message":"Password not defined at passwords.yml","commit_id":"810970980c241188dc6cc70bce20cc818bb3dbb5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e6c1d16db85295e36eae3b8b29e46c6cc9641258","unresolved":false,"context_lines":[{"line_number":20,"context_line":"rabbit_ha_queues \u003d true"},{"line_number":21,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{# For Kolla-Ansible, generate the memcache servers based on the list of"},{"line_number":24,"context_line":"memcached servers in the inventory and memcached_servers should be un-set."},{"line_number":25,"context_line":"For Kolla-Kubernetes,  it is necessary to define the memcached_servers"},{"line_number":26,"context_line":"variable in globals.yml to set it to the Kubernetes service for memcached. #}"},{"line_number":27,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":28,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":29,"context_line":"{% if orchestration_engine \u003d\u003d \u0027KUBERNETES\u0027 %}"},{"line_number":30,"context_line":"memcache_servers \u003d {{ memcached_servers }}"},{"line_number":31,"context_line":"{% else %}"},{"line_number":32,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":33,"context_line":"{%- endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[keystone_authtoken]"},{"line_number":36,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"fa7ab95a_407c1cb5","line":33,"range":{"start_line":23,"start_character":0,"end_line":33,"end_character":12},"updated":"2016-09-01 22:22:38.000000000","message":"Q: memcached configuration is in oslo_messaging_rabbit section?\n\nUsually goes at keystone_authtoken section, can you ensure this is correct","commit_id":"810970980c241188dc6cc70bce20cc818bb3dbb5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e6c1d16db85295e36eae3b8b29e46c6cc9641258","unresolved":false,"context_lines":[{"line_number":38,"context_line":"project_name \u003d service"},{"line_number":39,"context_line":"user_domain_name \u003d default"},{"line_number":40,"context_line":"username \u003d {{ sahara_keystone_user }}"},{"line_number":41,"context_line":"password \u003d {{ sahara_keystone_password }}"},{"line_number":42,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3"},{"line_number":43,"context_line":"auth_type \u003d password"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"fa7ab95a_c30bd622","line":41,"range":{"start_line":41,"start_character":14,"end_line":41,"end_character":38},"updated":"2016-09-01 22:22:38.000000000","message":"Password not defined at passwords.yml","commit_id":"810970980c241188dc6cc70bce20cc818bb3dbb5"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"66008c433236e261e2572ab8e546cb9aa4a12ffa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"connection \u003d mysql+pymysql://{{ sahara_database_user }}:{{ sahara_database_password }}@{{ sahara_database_address }}/{{ sahara_database_name }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[oslo_messaging_rabbit]"},{"line_number":18,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":19,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":20,"context_line":"rabbit_ha_queues \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"fa7ab95a_5ba88677","line":17,"updated":"2016-09-02 06:22:37.000000000","message":"Please use transport_url for rabbitmq configuration\n\n\u003e\u003e https://review.openstack.org/#/c/356449/3","commit_id":"45ac1f61f0d583bcb5e2fbce256f55231c9bd7e7"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"fc4f8ca8a2f67fe272b7f6b12e543a4747e48f28","unresolved":false,"context_lines":[{"line_number":14,"context_line":"connection \u003d mysql+pymysql://{{ sahara_database_user }}:{{ sahara_database_password }}@{{ sahara_database_address }}/{{ sahara_database_name }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[oslo_messaging_rabbit]"},{"line_number":18,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":19,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":20,"context_line":"rabbit_ha_queues \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"fa7ab95a_366037cf","line":17,"in_reply_to":"fa7ab95a_5ba88677","updated":"2016-09-02 06:44:47.000000000","message":"you sure?","commit_id":"45ac1f61f0d583bcb5e2fbce256f55231c9bd7e7"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"ff6eb88efe1994dad11abae71e12a14f69a9077c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{% if orchestration_engine \u003d\u003d \u0027KUBERNETES\u0027 %}"},{"line_number":29,"context_line":"memcache_servers \u003d {{ memcached_servers }}"},{"line_number":30,"context_line":"{% else %}"},{"line_number":31,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop."},{"line_number":32,"context_line":"last %},{% endif %}{% endfor %}"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[service_credentials]"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_1fd58442","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":31},"updated":"2016-09-05 04:23:39.000000000","message":"not sure if the broken line would work. Please verify this. Thanks.","commit_id":"f3e2bdf7b221131610347330a222ba4353eeefcf"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"8fb25ba066ec3e8db461d1fb837f9bcc26675c1f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{% if orchestration_engine \u003d\u003d \u0027KUBERNETES\u0027 %}"},{"line_number":29,"context_line":"memcache_servers \u003d {{ memcached_servers }}"},{"line_number":30,"context_line":"{% else %}"},{"line_number":31,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop."},{"line_number":32,"context_line":"last %},{% endif %}{% endfor %}"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[service_credentials]"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_64944437","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":31},"in_reply_to":"9a89bdaa_1fd58442","updated":"2016-09-05 07:23:21.000000000","message":"nice catch. this should not work.","commit_id":"f3e2bdf7b221131610347330a222ba4353eeefcf"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"8f398f80a49c37793d2cba3397a20fab71a34ff4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{% if orchestration_engine \u003d\u003d \u0027KUBERNETES\u0027 %}"},{"line_number":29,"context_line":"memcache_servers \u003d {{ memcached_servers }}"},{"line_number":30,"context_line":"{% else %}"},{"line_number":31,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop."},{"line_number":32,"context_line":"last %},{% endif %}{% endfor %}"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[service_credentials]"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_44dd8013","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":31},"in_reply_to":"9a89bdaa_64944437","updated":"2016-09-05 07:25:31.000000000","message":"Done","commit_id":"f3e2bdf7b221131610347330a222ba4353eeefcf"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"ff6eb88efe1994dad11abae71e12a14f69a9077c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[service_credentials]"},{"line_number":36,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":37,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":38,"context_line":"password \u003d {{ sahara_keystone_password }}"},{"line_number":39,"context_line":"username \u003d {{ sahara_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_bfbe58fd","line":36,"updated":"2016-09-05 04:23:39.000000000","message":"remove extra space after \"internal_protocol\"","commit_id":"f3e2bdf7b221131610347330a222ba4353eeefcf"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"8f398f80a49c37793d2cba3397a20fab71a34ff4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[service_credentials]"},{"line_number":36,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":37,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":38,"context_line":"password \u003d {{ sahara_keystone_password }}"},{"line_number":39,"context_line":"username \u003d {{ sahara_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_84e788e3","line":36,"in_reply_to":"9a89bdaa_bfbe58fd","updated":"2016-09-05 07:25:31.000000000","message":"Done","commit_id":"f3e2bdf7b221131610347330a222ba4353eeefcf"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"5efbae2c856d6d51452632341aaac4ecb4f2dde6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"debug \u003d {{ sahara_logging_debug }}"},{"line_number":3,"context_line":"log_dir \u003d /var/log/kolla/sahara"},{"line_number":4,"context_line":"rpc_backend \u003d rabbit"},{"line_number":5,"context_line":"port \u003d {{ sahara_api_port }}"},{"line_number":6,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":7,"context_line":"transport_url \u003d rabbit://{% for host in groups[\u0027rabbitmq\u0027] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"9a89bdaa_1a1d3bbd","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":20},"updated":"2016-09-06 17:48:03.000000000","message":"When using transport_url rpc_backend is not necessary","commit_id":"401abd1068288a0dc3c21ca6b9f43918e0e88d8f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"5efbae2c856d6d51452632341aaac4ecb4f2dde6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"user_domain_name \u003d default"},{"line_number":21,"context_line":"username \u003d {{ sahara_keystone_user }}"},{"line_number":22,"context_line":"password \u003d {{ sahara_keystone_password }}"},{"line_number":23,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3"},{"line_number":24,"context_line":"auth_type \u003d password"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"memcache_security_strategy \u003d ENCRYPT"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"9a89bdaa_5acb431e","line":23,"range":{"start_line":23,"start_character":85,"end_line":23,"end_character":88},"updated":"2016-09-06 17:48:03.000000000","message":"Is explicitly necessary set v3? kolla uses v3 by default","commit_id":"401abd1068288a0dc3c21ca6b9f43918e0e88d8f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"5efbae2c856d6d51452632341aaac4ecb4f2dde6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[service_credentials]"},{"line_number":35,"context_line":"auth_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":36,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":37,"context_line":"password \u003d {{ sahara_keystone_password }}"},{"line_number":38,"context_line":"username \u003d {{ sahara_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"9a89bdaa_7ad2c7d3","line":35,"range":{"start_line":35,"start_character":89,"end_line":35,"end_character":92},"updated":"2016-09-06 17:48:03.000000000","message":"ditto","commit_id":"401abd1068288a0dc3c21ca6b9f43918e0e88d8f"}],"ansible/site.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3d55bfd85b362941e8556f7e82cb76263b32175a","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        when: enable_ceilometer | bool }"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"- hosts:"},{"line_number":243,"context_line":"    - sahara"},{"line_number":244,"context_line":"  roles:"},{"line_number":245,"context_line":"    - { role: sahara,"},{"line_number":246,"context_line":"        tags: sahara,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_0a8050be","line":243,"updated":"2016-08-05 08:17:15.000000000","message":"should use\n\n- sahara-api\n- sahara-engine","commit_id":"ed4dfc1fd480ccbe16df8e0f1b22685a94b407b4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e6c1d16db85295e36eae3b8b29e46c6cc9641258","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"- hosts:"},{"line_number":216,"context_line":"    - sahara-api"},{"line_number":217,"context_line":"    - sahara-engine"},{"line_number":218,"context_line":"  roles:"},{"line_number":219,"context_line":"    - { role: sahara,"},{"line_number":220,"context_line":"        tags: sahara,"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"fa7ab95a_005db446","line":217,"updated":"2016-09-01 22:22:38.000000000","message":"Please, add rabbitmq and memcached nodes","commit_id":"810970980c241188dc6cc70bce20cc818bb3dbb5"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"df43f7814656ed4e0e35ecb01de880f9352c4a8e","unresolved":false,"context_lines":[{"line_number":201,"context_line":"- hosts:"},{"line_number":202,"context_line":"    - sahara-api"},{"line_number":203,"context_line":"    - sahara-engine"},{"line_number":204,"context_line":"    - rabbitmq"},{"line_number":205,"context_line":"    - memcached"},{"line_number":206,"context_line":"  roles:"},{"line_number":207,"context_line":"    - { role: sahara,"},{"line_number":208,"context_line":"        tags: sahara,"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"fa7ab95a_602f5588","line":205,"range":{"start_line":204,"start_character":4,"end_line":205,"end_character":15},"updated":"2016-09-02 05:11:47.000000000","message":"It seems that neither rabbitmq nor memchaed has been impacted by the sahara service. If I understand correctly, please remove these two hosts for the sahara task. Thanks.","commit_id":"45ac1f61f0d583bcb5e2fbce256f55231c9bd7e7"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e4e9a5085df52d8027394434d145dc44f9b569f3","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    - sahara-api"},{"line_number":203,"context_line":"    - sahara-engine"},{"line_number":204,"context_line":"    - rabbitmq"},{"line_number":205,"context_line":"    - memcached"},{"line_number":206,"context_line":"  roles:"},{"line_number":207,"context_line":"    - { role: sahara,"},{"line_number":208,"context_line":"        tags: sahara,"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a89bdaa_eee4b83c","line":205,"updated":"2016-09-05 01:34:46.000000000","message":"This is no need. \n\nIn the sahara role, u do not touch the rabbitmq and memcached. Event though api need haproxy, this is done in haproxy role rather than sahara.\nAll the task is ran in sahara-* host.\nso please remove them.","commit_id":"17661bb97ceb8a256410088b5e9f4fe05dd7f069"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"acc71490b675019694e4153ce98db3a94b4eb760","unresolved":false,"context_lines":[{"line_number":201,"context_line":"- hosts:"},{"line_number":202,"context_line":"    - sahara-api"},{"line_number":203,"context_line":"    - sahara-engine"},{"line_number":204,"context_line":"    - rabbitmq"},{"line_number":205,"context_line":"    - memcached"},{"line_number":206,"context_line":"  roles:"},{"line_number":207,"context_line":"    - { role: sahara,"},{"line_number":208,"context_line":"        tags: sahara,"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a89bdaa_fe25585c","line":205,"range":{"start_line":204,"start_character":6,"end_line":205,"end_character":15},"updated":"2016-09-03 04:55:03.000000000","message":"why are rabbitmq and memchaed hosts necessary here?","commit_id":"17661bb97ceb8a256410088b5e9f4fe05dd7f069"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"289e40aafcce2a8da33d44adbff80dcdb660d92f","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    - sahara-api"},{"line_number":203,"context_line":"    - sahara-engine"},{"line_number":204,"context_line":"    - rabbitmq"},{"line_number":205,"context_line":"    - memcached"},{"line_number":206,"context_line":"  roles:"},{"line_number":207,"context_line":"    - { role: sahara,"},{"line_number":208,"context_line":"        tags: sahara,"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a89bdaa_04e9bd1a","line":205,"in_reply_to":"9a89bdaa_eee4b83c","updated":"2016-09-05 03:31:28.000000000","message":"Done","commit_id":"17661bb97ceb8a256410088b5e9f4fe05dd7f069"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"7fe3ec39f1806164fed02511a45691f45eea09e9","unresolved":false,"context_lines":[{"line_number":201,"context_line":"- hosts:"},{"line_number":202,"context_line":"    - sahara-api"},{"line_number":203,"context_line":"    - sahara-engine"},{"line_number":204,"context_line":"    - rabbitmq"},{"line_number":205,"context_line":"    - memcached"},{"line_number":206,"context_line":"  roles:"},{"line_number":207,"context_line":"    - { role: sahara,"},{"line_number":208,"context_line":"        tags: sahara,"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9a89bdaa_2d3a3437","line":205,"range":{"start_line":204,"start_character":6,"end_line":205,"end_character":15},"in_reply_to":"9a89bdaa_fe25585c","updated":"2016-09-03 14:18:14.000000000","message":"becaause，i use rabbitmq and memcacheed","commit_id":"17661bb97ceb8a256410088b5e9f4fe05dd7f069"}]}