)]}'
{"docker/barbican/barbican-api/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RUN chmod 755 /usr/local/bin/kolla_barbican_extend_start"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_api_footer %}{% endblock %} "},{"line_number":22,"context_line":"{% block footer %}{% endblock %} "},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_163160a2","line":21,"range":{"start_line":21,"start_character":45,"end_line":21,"end_character":46},"updated":"2016-08-06 17:45:05.000000000","message":"Please, remove whitespace","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"RUN chmod 755 /usr/local/bin/kolla_barbican_extend_start"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_api_footer %}{% endblock %} "},{"line_number":22,"context_line":"{% block footer %}{% endblock %} "},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_76241c5f","line":22,"range":{"start_line":22,"start_character":32,"end_line":22,"end_character":33},"updated":"2016-08-06 17:45:05.000000000","message":"Ditto","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_api_footer %}{% endblock %} "},{"line_number":22,"context_line":"{% block footer %}{% endblock %} "},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ include_footer }}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_56275862","line":23,"updated":"2016-08-06 17:45:05.000000000","message":"Please, remove lines 23 and 24","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"7f92b9c0a193e834763fddce86af06819e645763","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_91ea000e","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":48},"updated":"2016-08-09 19:27:54.000000000","message":"this should be barbican-base","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"79618382350352c754639c6dc1c4beff98da195f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_1fa577a1","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":48},"in_reply_to":"9ad45d7e_91ea000e","updated":"2016-08-09 20:25:31.000000000","message":"thanks, I forgot to sync, you are really careful.","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7e4d4664af23b0f81a89bbb9cb64d958b9ae2479","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {% set barbican_api_packages \u003d [\u0027barbican-api\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_api_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1ac06dbe_438ca67f","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":3},"updated":"2016-08-24 11:55:14.000000000","message":"Remove RUNs for macros. Now, this is handled by the macro itself to support empty package lists","commit_id":"710be3dcd0061abaf64b55c186bc5387c2a70229"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c90925bc3a6874222c19b1212ddc850f27eacd62","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {% set barbican_api_packages \u003d [\u0027barbican-api\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_api_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1ac06dbe_cf29d0f4","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":3},"in_reply_to":"1ac06dbe_438ca67f","updated":"2016-08-24 13:58:48.000000000","message":"sure，i fixed it now","commit_id":"710be3dcd0061abaf64b55c186bc5387c2a70229"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"6ac6b170380d5c41e951673af4d5d9251d842492","unresolved":false,"context_lines":[{"line_number":19,"context_line":"RUN chmod 755 /usr/local/bin/kolla_barbican_extend_start"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_api_footer %}{% endblock %}"},{"line_number":22,"context_line":"{% block footer %}{% endblock %}"},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa7ab95a_6aa59db3","line":22,"updated":"2016-08-29 04:52:39.000000000","message":"remove this footer block","commit_id":"6effe64999b9155bfa514c1acc8020327d0231db"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7f78ce8334afe79125d8d1d501be703240c120a0","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_api_footer %}{% endblock %}"},{"line_number":22,"context_line":"{% block footer %}{% endblock %}"},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9a89bdaa_051704a4","line":23,"updated":"2016-09-04 04:25:13.000000000","message":"Do you want to remove the above line to be consistent as other barbican-* Dockerfiles?","commit_id":"6e255dceb55d1e5f78c60b080f98013ab9b8e3d8"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"0bef9740fb9b19be8825fd6b0496f7d2cf8d686a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_api_footer %}{% endblock %}"},{"line_number":22,"context_line":"{% block footer %}{% endblock %}"},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9a89bdaa_a04e46bf","line":23,"in_reply_to":"9a89bdaa_051704a4","updated":"2016-09-04 07:47:09.000000000","message":"Done","commit_id":"6e255dceb55d1e5f78c60b080f98013ab9b8e3d8"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"2be386976a245fb58637f4442e694197a26fc902","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_api_footer %}{% endblock %}"},{"line_number":22,"context_line":"{% block footer %}{% endblock %}"},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9a89bdaa_58c1d8e3","line":23,"in_reply_to":"9a89bdaa_3a097e96","updated":"2016-09-05 10:09:43.000000000","message":"sorry, i forget it","commit_id":"6e255dceb55d1e5f78c60b080f98013ab9b8e3d8"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"2be386976a245fb58637f4442e694197a26fc902","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_api_footer %}{% endblock %}"},{"line_number":22,"context_line":"{% block footer %}{% endblock %}"},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9a89bdaa_80d862f1","line":23,"in_reply_to":"9a89bdaa_a04e46bf","updated":"2016-09-05 10:09:43.000000000","message":"Done","commit_id":"6e255dceb55d1e5f78c60b080f98013ab9b8e3d8"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"d228935db10a82b55559dc3b68a3a80a7c6cd3f7","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_api_footer %}{% endblock %}"},{"line_number":22,"context_line":"{% block footer %}{% endblock %}"},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9a89bdaa_3a097e96","line":23,"in_reply_to":"9a89bdaa_a04e46bf","updated":"2016-09-04 14:08:57.000000000","message":"Hi, Bingbing, I have not seen your updated the PS with the above line removed.","commit_id":"6e255dceb55d1e5f78c60b080f98013ab9b8e3d8"}],"docker/barbican/barbican-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set barbican_base_packages \u003d [\u0027openstack-barbican-common\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %} "},{"line_number":10,"context_line":"        {% set barbican_base_packages \u003d [\u0027barbican-common\u0027] %} "},{"line_number":11,"context_line":"    {% endif %} "},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_b6221450","line":9,"range":{"start_line":9,"start_character":40,"end_line":9,"end_character":41},"updated":"2016-08-06 17:45:05.000000000","message":"Please remove whitespace","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set barbican_base_packages \u003d [\u0027openstack-barbican-common\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %} "},{"line_number":10,"context_line":"        {% set barbican_base_packages \u003d [\u0027barbican-common\u0027] %} "},{"line_number":11,"context_line":"    {% endif %} "},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_961d5011","line":10,"range":{"start_line":10,"start_character":62,"end_line":10,"end_character":63},"updated":"2016-08-06 17:45:05.000000000","message":"Ditto","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        {% set barbican_base_packages \u003d [\u0027openstack-barbican-common\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %} "},{"line_number":10,"context_line":"        {% set barbican_base_packages \u003d [\u0027barbican-common\u0027] %} "},{"line_number":11,"context_line":"    {% endif %} "},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_base_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_d61348ff","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":16},"updated":"2016-08-06 17:45:05.000000000","message":"Ditto","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"a8e0e3c4d261fb020e140fa922854bfaee824a7f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0026\u0026 chmod 740 /etc/sudoers.d/kolla_barbican_sudoers \\"},{"line_number":33,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_barbican_extend_start \\"},{"line_number":34,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_barbican_extend_start"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bacf61ea_8841a8ab","line":35,"updated":"2016-08-07 19:38:29.000000000","message":"This line can be removed.","commit_id":"0b134926ff9dbaf426e3a2f22aedfe33fa654c49"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4c18a2682ad83a9dd035b80f4f024162e7414906","unresolved":false,"context_lines":[{"line_number":27,"context_line":"COPY barbican_sudoers /etc/sudoers.d/kolla_barbican_sudoers"},{"line_number":28,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"RUN usermod -a -G kolla barbican \\"},{"line_number":31,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":32,"context_line":"    \u0026\u0026 chmod 740 /etc/sudoers.d/kolla_barbican_sudoers \\"},{"line_number":33,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_barbican_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_f13d3cbc","line":30,"updated":"2016-08-09 19:24:06.000000000","message":"useradd missing","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"7f92b9c0a193e834763fddce86af06819e645763","unresolved":false,"context_lines":[{"line_number":27,"context_line":"COPY barbican_sudoers /etc/sudoers.d/kolla_barbican_sudoers"},{"line_number":28,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"RUN usermod -a -G kolla barbican \\"},{"line_number":31,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":32,"context_line":"    \u0026\u0026 chmod 740 /etc/sudoers.d/kolla_barbican_sudoers \\"},{"line_number":33,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_barbican_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_f16edc94","line":30,"in_reply_to":"9ad45d7e_f13d3cbc","updated":"2016-08-09 19:27:54.000000000","message":"This comment is wrong. The FROM in the other DOckerfiles are wrong, because of that the barbican user is not available there.","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"79618382350352c754639c6dc1c4beff98da195f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"COPY barbican_sudoers /etc/sudoers.d/kolla_barbican_sudoers"},{"line_number":28,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"RUN usermod -a -G kolla barbican \\"},{"line_number":31,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":32,"context_line":"    \u0026\u0026 chmod 740 /etc/sudoers.d/kolla_barbican_sudoers \\"},{"line_number":33,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_barbican_extend_start \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_91a200ad","line":30,"in_reply_to":"9ad45d7e_f13d3cbc","updated":"2016-08-09 20:25:31.000000000","message":"it need\u0027t useradd ,Because the above has been added to the user.","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"d6873cc626e000142421ac037ab388acfa8533fc","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"RUN usermod -a -G kolla barbican \\"},{"line_number":31,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":32,"context_line":"    \u0026\u0026 chmod 740 /etc/sudoers.d/kolla_barbican_sudoers \\"},{"line_number":33,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_barbican_extend_start \\"},{"line_number":34,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_barbican_extend_start"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_ee78bb2d","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":16},"updated":"2016-08-09 19:10:15.000000000","message":"This should be 640","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"79618382350352c754639c6dc1c4beff98da195f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"RUN usermod -a -G kolla barbican \\"},{"line_number":31,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":32,"context_line":"    \u0026\u0026 chmod 740 /etc/sudoers.d/kolla_barbican_sudoers \\"},{"line_number":33,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_barbican_extend_start \\"},{"line_number":34,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_barbican_extend_start"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_11d0d01e","line":32,"range":{"start_line":32,"start_character":13,"end_line":32,"end_character":16},"in_reply_to":"9ad45d7e_ee78bb2d","updated":"2016-08-09 20:25:31.000000000","message":"Done","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"d6873cc626e000142421ac037ab388acfa8533fc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0026\u0026 chmod 740 /etc/sudoers.d/kolla_barbican_sudoers \\"},{"line_number":33,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_barbican_extend_start \\"},{"line_number":34,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_barbican_extend_start"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_6e8ccb35","line":35,"updated":"2016-08-09 19:10:15.000000000","message":"nit: trailing newline","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"79618382350352c754639c6dc1c4beff98da195f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0026\u0026 chmod 740 /etc/sudoers.d/kolla_barbican_sudoers \\"},{"line_number":33,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_barbican_extend_start \\"},{"line_number":34,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_barbican_extend_start"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_51a1a8a2","line":35,"in_reply_to":"9ad45d7e_6e8ccb35","updated":"2016-08-09 20:25:31.000000000","message":"sure,i fixet now","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"d4fc65688fab46a71bc8fca286d137864cec9c36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1ac06dbe_0d18fe83","line":42,"updated":"2016-08-19 17:11:55.000000000","message":"At the moment we add missing footer in the base images, add footer here.","commit_id":"b9a2ad2d29636190039b91b742a12fa7ed7271d4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"39e543e2d3fd2d9c7675772b46fbd61fa82d9ea6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1ac06dbe_a29efd53","line":42,"in_reply_to":"1ac06dbe_0d18fe83","updated":"2016-08-20 11:46:17.000000000","message":"In base images only {% block barbican_base_footer %}{% endblock %}.","commit_id":"b9a2ad2d29636190039b91b742a12fa7ed7271d4"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"ad6cd750f51f3417ee180dc31f463eb6644290f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1ac06dbe_ba8f8773","line":42,"in_reply_to":"1ac06dbe_a29efd53","updated":"2016-08-24 08:14:39.000000000","message":"Sure, i fixed it now","commit_id":"b9a2ad2d29636190039b91b742a12fa7ed7271d4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e2e8aad7c71c7a942cd8ea5710f84e92b32c8e20","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set barbican_base_packages \u003d [\u0027openstack-barbican-common\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":"        {% set barbican_base_packages \u003d [\u0027barbican-common\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{{ macros.install_packages(barbican_base_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":16,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"        {% set barbican_uwsgi_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":18,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"        {% set barbican_uwsgi_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{ macros.install_packages(barbican_uwsgi_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1ac06dbe_fecef3b5","line":20,"range":{"start_line":6,"start_character":0,"end_line":20,"end_character":15},"updated":"2016-08-24 16:05:14.000000000","message":"You can use one single macros.install as follows:\n\nif binary\n  if centos\n      set barbican_base_packages\n  if ubuntu\n      set barbican_base_packages\nelif source\n  set barbican_base_packages\nendif\n\nmacros.install\n\nUse the same name for barbican_base_packages and unify source in a single set because is the same package name.","commit_id":"1203155b8f0d2b633db3a1e27da1bae7bd57d505"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"affe4f86b0b202e130194ea4fa7d5e6d17e02ddf","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set barbican_base_packages \u003d [\u0027openstack-barbican-common\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":"        {% set barbican_base_packages \u003d [\u0027barbican-common\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{{ macros.install_packages(barbican_base_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":16,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"        {% set barbican_uwsgi_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":18,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"        {% set barbican_uwsgi_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{ macros.install_packages(barbican_uwsgi_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1ac06dbe_1f200d49","line":20,"range":{"start_line":6,"start_character":0,"end_line":20,"end_character":15},"in_reply_to":"1ac06dbe_fecef3b5","updated":"2016-08-25 01:38:34.000000000","message":"good advice","commit_id":"1203155b8f0d2b633db3a1e27da1bae7bd57d505"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"b4cca4869d69e92ad1692b3f4fb35c60d35bf5ff","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set barbican_base_packages \u003d [\u0027openstack-barbican-common\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":"        {% set barbican_base_packages \u003d [\u0027barbican-common\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{{ macros.install_packages(barbican_base_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":16,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"        {% set barbican_uwsgi_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":18,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"        {% set barbican_uwsgi_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{ macros.install_packages(barbican_uwsgi_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"fa7ab95a_2a23a306","line":20,"range":{"start_line":6,"start_character":0,"end_line":20,"end_character":15},"in_reply_to":"1ac06dbe_fecef3b5","updated":"2016-08-28 05:10:30.000000000","message":"good advice ,bug i do not think so, source(pip install uwsgi) installation depends on the uwsgi-plugin-python, he must be installed before it","commit_id":"1203155b8f0d2b633db3a1e27da1bae7bd57d505"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f43a4376df4c673468547e3423172601056e575f","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set barbican_base_packages \u003d [\u0027openstack-barbican-common\u0027] %}"},{"line_number":9,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":"        {% set barbican_base_packages \u003d [\u0027barbican-common\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{{ macros.install_packages(barbican_base_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":16,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":17,"context_line":"        {% set barbican_uwsgi_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":18,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"        {% set barbican_uwsgi_packages \u003d [\u0027uwsgi-plugin-python\u0027] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{ macros.install_packages(barbican_uwsgi_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"fa7ab95a_13837799","line":20,"range":{"start_line":6,"start_character":0,"end_line":20,"end_character":15},"in_reply_to":"fa7ab95a_2a23a306","updated":"2016-08-28 16:26:14.000000000","message":"zhubingbing I am fairly certain Eduardo\u0027s solution would work - can you try it?  It would be preferrable.","commit_id":"1203155b8f0d2b633db3a1e27da1bae7bd57d505"}],"docker/barbican/barbican-base/barbican_sudoers":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"ff402b6b88ad3058da0de969487aba55a1fcf80b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown -R barbican\\: /var/lib/glance/, /bin/chown -R barbican\\: /var/lib/barbican/"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"9ad45d7e_f88d597c","line":1,"range":{"start_line":1,"start_character":57,"end_line":1,"end_character":73},"updated":"2016-08-08 21:21:56.000000000","message":"Are necessary permissions on /var/lib/glance for barbican user?","commit_id":"bf97d35417cf8b4397f919fd2c2fd491c4893df2"}],"docker/barbican/barbican-base/extend_start.sh":[{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"9808285482d0f80ed7b0825842b18a2336123148","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    chmod 755 ${LOG_DIR}"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source /usr/local/bin/kolla_barbican_extend_start"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1ac06dbe_5df16d00","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"updated":"2016-08-23 12:54:28.000000000","message":"Use \".\" instead of source. http://docs.openstack.org/contributor-guide/writing-style/code-conventions.html","commit_id":"b9a2ad2d29636190039b91b742a12fa7ed7271d4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d62de92a43a8e3efe92bab908bd3027c428f4906","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    chmod 755 ${LOG_DIR}"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"source /usr/local/bin/kolla_barbican_extend_start"}],"source_content_type":"text/x-sh","patch_set":17,"id":"fa7ab95a_32aec798","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"updated":"2016-09-01 06:50:09.000000000","message":"Please, change source with dot.\nhttp://docs.openstack.org/contributor-guide/writing-style/code-conventions.html","commit_id":"6291f18f46ad750bb5700870e58846ae252066f1"}],"docker/barbican/barbican-keystone-listener/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"       {% set barbican_keystone_listener_packages \u003d [\u0027barbican-keystone-listener\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican-keystone-listener_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_b6e974e8","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":66},"updated":"2016-08-06 17:45:05.000000000","message":"use barbican_keystone_listener_packages","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RUN chmod 755 /usr/local/bin/kolla_barbican_extend_start"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_keystone_listener_footer %}{% endblock %} "},{"line_number":22,"context_line":"{% block footer %}{% endblock %} "},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_16d84052","line":21,"range":{"start_line":21,"start_character":59,"end_line":21,"end_character":60},"updated":"2016-08-06 17:45:05.000000000","message":"Remove whitespace","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"RUN chmod 755 /usr/local/bin/kolla_barbican_extend_start"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_keystone_listener_footer %}{% endblock %} "},{"line_number":22,"context_line":"{% block footer %}{% endblock %} "},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_76db7c4f","line":22,"range":{"start_line":22,"start_character":32,"end_line":22,"end_character":33},"updated":"2016-08-06 17:45:05.000000000","message":"Ditto","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_keystone_listener_footer %}{% endblock %} "},{"line_number":22,"context_line":"{% block footer %}{% endblock %} "},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ include_footer }}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_f6ef6ce6","line":23,"updated":"2016-08-06 17:45:05.000000000","message":"Please, remove lines 23 and 24","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"7f92b9c0a193e834763fddce86af06819e645763","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_51e9a813","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":48},"updated":"2016-08-09 19:27:54.000000000","message":"this should be barbican-base","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7e4d4664af23b0f81a89bbb9cb64d958b9ae2479","unresolved":false,"context_lines":[{"line_number":10,"context_line":"       {% set barbican_keystone_listener_packages \u003d [\u0027barbican-keystone-listener\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_keystone_listener_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1ac06dbe_83d33e5f","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":3},"updated":"2016-08-24 11:55:14.000000000","message":"Ditto","commit_id":"710be3dcd0061abaf64b55c186bc5387c2a70229"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c90925bc3a6874222c19b1212ddc850f27eacd62","unresolved":false,"context_lines":[{"line_number":10,"context_line":"       {% set barbican_keystone_listener_packages \u003d [\u0027barbican-keystone-listener\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_keystone_listener_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1ac06dbe_6f1c1cc2","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":3},"in_reply_to":"1ac06dbe_83d33e5f","updated":"2016-08-24 13:58:48.000000000","message":"Done","commit_id":"710be3dcd0061abaf64b55c186bc5387c2a70229"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7e4d4664af23b0f81a89bbb9cb64d958b9ae2479","unresolved":false,"context_lines":[{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_keystone_listener_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block barbican_keystone_listener_footer %}{% endblock %}"},{"line_number":19,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1ac06dbe_a35c7af1","line":16,"updated":"2016-08-24 11:55:14.000000000","message":"Remove unnecessary line","commit_id":"710be3dcd0061abaf64b55c186bc5387c2a70229"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c90925bc3a6874222c19b1212ddc850f27eacd62","unresolved":false,"context_lines":[{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_keystone_listener_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block barbican_keystone_listener_footer %}{% endblock %}"},{"line_number":19,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1ac06dbe_cf771007","line":16,"in_reply_to":"1ac06dbe_a35c7af1","updated":"2016-08-24 13:58:48.000000000","message":"Done","commit_id":"710be3dcd0061abaf64b55c186bc5387c2a70229"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"6ac6b170380d5c41e951673af4d5d9251d842492","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% block barbican_keystone_listener_footer %}{% endblock %}"},{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa7ab95a_0aca516d","line":18,"updated":"2016-08-29 04:52:39.000000000","message":"remove this footer block","commit_id":"6effe64999b9155bfa514c1acc8020327d0231db"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"82473a7af11f1a74e33d112229f6e6138e2180ad","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% block barbican_keystone_listener_footer %}{% endblock %}"},{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa7ab95a_18e75941","line":18,"updated":"2016-08-31 12:56:55.000000000","message":"why we have {% block footer %}{% endblock %} in other role? like nova-api? all this a bug?","commit_id":"6effe64999b9155bfa514c1acc8020327d0231db"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"bb9d7efe4c703942c42996e5dd61cfd6275dfead","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% block barbican_keystone_listener_footer %}{% endblock %}"},{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa7ab95a_617dbb6d","line":18,"in_reply_to":"fa7ab95a_0aca516d","updated":"2016-08-29 08:25:27.000000000","message":"Is {{ include_footer }} missing here?","commit_id":"6effe64999b9155bfa514c1acc8020327d0231db"}],"docker/barbican/barbican-worker/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"       {% set barbican_worker_packages \u003d [\u0027barbican-worker\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_api_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_36bc64db","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":52},"updated":"2016-08-06 17:45:05.000000000","message":"Change to barbican_worker_packages","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RUN chmod 755 /usr/local/bin/kolla_barbican_extend_start"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_worker_footer %}{% endblock %} "},{"line_number":22,"context_line":"{% block footer %}{% endblock %} "},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_16bfa0d0","line":21,"range":{"start_line":21,"start_character":48,"end_line":21,"end_character":49},"updated":"2016-08-06 17:45:05.000000000","message":"Please remove whitespace","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"RUN chmod 755 /usr/local/bin/kolla_barbican_extend_start"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_worker_footer %}{% endblock %} "},{"line_number":22,"context_line":"{% block footer %}{% endblock %} "},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_76b25c07","line":22,"range":{"start_line":22,"start_character":32,"end_line":22,"end_character":33},"updated":"2016-08-06 17:45:05.000000000","message":"Ditto","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a667a1c6463ea490ecb7436c8c393e3c782d351e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{% block barbican_worker_footer %}{% endblock %} "},{"line_number":22,"context_line":"{% block footer %}{% endblock %} "},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ include_footer }}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bacf61ea_56b598ea","line":23,"updated":"2016-08-06 17:45:05.000000000","message":"Remove lines 23 and 24","commit_id":"8512a22011b46d898e4f5a4489168f1fba02df9d"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"7f92b9c0a193e834763fddce86af06819e645763","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9ad45d7e_d1cbd8a3","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":48},"updated":"2016-08-09 19:27:54.000000000","message":"this should be barbican-base","commit_id":"f9f2dbbd13d3ba734af369618781ef288d5bb944"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"7e4d4664af23b0f81a89bbb9cb64d958b9ae2479","unresolved":false,"context_lines":[{"line_number":10,"context_line":"       {% set barbican_worker_packages \u003d [\u0027barbican-worker\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_worker_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1ac06dbe_a303dabd","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":3},"updated":"2016-08-24 11:55:14.000000000","message":"Remove RUN","commit_id":"710be3dcd0061abaf64b55c186bc5387c2a70229"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c90925bc3a6874222c19b1212ddc850f27eacd62","unresolved":false,"context_lines":[{"line_number":10,"context_line":"       {% set barbican_worker_packages \u003d [\u0027barbican-worker\u0027] %}"},{"line_number":11,"context_line":"    {% endif %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN {{ macros.install_packages(barbican_worker_packages | customizable(\"packages\")) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1ac06dbe_8f76b804","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":3},"in_reply_to":"1ac06dbe_a303dabd","updated":"2016-08-24 13:58:48.000000000","message":"Done","commit_id":"710be3dcd0061abaf64b55c186bc5387c2a70229"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"6ac6b170380d5c41e951673af4d5d9251d842492","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% block barbican_worker_footer %}{% endblock %}"},{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa7ab95a_8aaca1a1","line":18,"updated":"2016-08-29 04:52:39.000000000","message":"remove this footer block","commit_id":"6effe64999b9155bfa514c1acc8020327d0231db"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"bb9d7efe4c703942c42996e5dd61cfd6275dfead","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% block barbican_worker_footer %}{% endblock %}"},{"line_number":18,"context_line":"{% block footer %}{% endblock %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"USER barbican"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa7ab95a_a197c38e","line":18,"in_reply_to":"fa7ab95a_8aaca1a1","updated":"2016-08-29 08:25:27.000000000","message":"Is {{ include_footer }} missing here?","commit_id":"6effe64999b9155bfa514c1acc8020327d0231db"}],"kolla/common/config.py":[{"author":{"_account_id":20663,"name":"caowei","email":"caowei010@gmail.com","username":"caowei"},"change_message_id":"9808285482d0f80ed7b0825842b18a2336123148","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":171,"context_line":"        \u0027location\u0027: (\u0027http://tarballs.openstack.org/aodh/\u0027"},{"line_number":172,"context_line":"                     \u0027aodh-master.tar.gz\u0027)},"},{"line_number":173,"context_line":"    \u0027barbican-base\u0027: {"},{"line_number":174,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":175,"context_line":"        \u0027location\u0027: (\u0027http://tarballs.openstack.org/barbican/\u0027"},{"line_number":176,"context_line":"                     \u0027barbican-master.tar.gz\u0027)},"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_1dbc15db","line":173,"range":{"start_line":173,"start_character":4,"end_line":173,"end_character":18},"updated":"2016-08-23 12:54:28.000000000","message":"Please add barbican to one of the build group, e.g., aux","commit_id":"b9a2ad2d29636190039b91b742a12fa7ed7271d4"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d62de92a43a8e3efe92bab908bd3027c428f4906","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":178,"context_line":"        \u0027location\u0027: (\u0027http://tarballs.openstack.org/bifrost/\u0027"},{"line_number":179,"context_line":"                     \u0027bifrost-master.tar.gz\u0027)},"},{"line_number":180,"context_line":"    \u0027barbican-base\u0027: {"},{"line_number":181,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":182,"context_line":"        \u0027location\u0027: (\u0027http://tarballs.openstack.org/barbican/\u0027"},{"line_number":183,"context_line":"                     \u0027barbican-master.tar.gz\u0027)},"},{"line_number":184,"context_line":"    \u0027ceilometer-base\u0027: {"},{"line_number":185,"context_line":"        \u0027type\u0027: \u0027url\u0027,"},{"line_number":186,"context_line":"        \u0027location\u0027: (\u0027http://tarballs.openstack.org/ceilometer/\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_729e8f55","line":183,"range":{"start_line":180,"start_character":0,"end_line":183,"end_character":48},"updated":"2016-09-01 06:50:09.000000000","message":"Please, alphabetize this","commit_id":"6291f18f46ad750bb5700870e58846ae252066f1"}]}