)]}'
{"docker/ceph/ceph-base/Dockerfile.j2":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"af7503f60d12b104af6c8f3750c44684c3b5e67a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ad45d7e_d6f7aaf3","line":30,"updated":"2016-08-08 10:16:09.000000000","message":"Please add footer sections for ceph-base","commit_id":"a08b18871f7af8d3351780b793bdada73d1c8a06"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"2777cf8f019a73a710e01e8a0389eda773197e89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ad45d7e_fc0bad7b","line":30,"in_reply_to":"9ad45d7e_611a7a70","updated":"2016-08-08 11:10:37.000000000","message":"Say for example I need to make a modification easily across all the ceph Dockerfiles. With ceph_base_footer I can easily add it there. Without I have to make the same change in all ceph footers, e.g. ceph_mon_footer, ceph_osd_footer etc.","commit_id":"a08b18871f7af8d3351780b793bdada73d1c8a06"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"eefbbb249e07019f4bfa4b45e8b2edbc7928fbaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ad45d7e_611a7a70","line":30,"in_reply_to":"9ad45d7e_d6f7aaf3","updated":"2016-08-08 10:36:18.000000000","message":"Is this needed?  What customisations can you see needed in base, that aren\u0027t covered by the other templates?","commit_id":"a08b18871f7af8d3351780b793bdada73d1c8a06"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"324fc4ce4ed5ca966c2ad856a92147133278d2f8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \u0027btrfs-tools\u0027"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"RUN {{ macros.install_packages(ceph_base_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":25,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_2ceda925","line":22,"updated":"2016-08-10 05:39:13.000000000","message":"OK.","commit_id":"304c69a91f026036b6530a58de6383dc5fa8b38e"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"92965a6dd4f73d57990181cd7716778bf5508e74","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \u0027btrfs-tools\u0027"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"RUN {{ macros.install_packages(ceph_base_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":25,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_5ebf23fb","line":22,"updated":"2016-08-09 03:56:25.000000000","message":"merge this with following RUN lines.","commit_id":"304c69a91f026036b6530a58de6383dc5fa8b38e"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"cdf8f367059be87e2a7ee67213dc4d25063ce626","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \u0027btrfs-tools\u0027"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"RUN {{ macros.install_packages(ceph_base_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":25,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_898fa722","line":22,"in_reply_to":"9ad45d7e_5ebf23fb","updated":"2016-08-09 04:50:02.000000000","message":"You mean remove the empty line or \nRUN {{macro}} \\\n    \u0026\u0026 other RUN stuff??","commit_id":"304c69a91f026036b6530a58de6383dc5fa8b38e"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"bf1ffe834f9a0bedd694083b0ad9a16fc7576b20","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        \u0027btrfs-tools\u0027"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"RUN {{ macros.install_packages(ceph_base_packages | customizable(\"packages\")) }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":25,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_2fb79187","line":22,"in_reply_to":"9ad45d7e_898fa722","updated":"2016-08-09 09:48:58.000000000","message":"I\u0027ve been avoiding this so far as other RUN statements may want to be customised with blocks independently of the install_packages","commit_id":"304c69a91f026036b6530a58de6383dc5fa8b38e"}]}