)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"b7aba397611d0f634b71c94819d0ea48c3fe49f4","unresolved":false,"context_lines":[{"line_number":177,"context_line":"internal_protocol: \"http\""},{"line_number":178,"context_line":"admin_protocol: \"http\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"network_ha: \"no\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"####################"},{"line_number":183,"context_line":"# OpenStack options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_ba7db0e9","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":10},"updated":"2016-08-08 13:14:28.000000000","message":"I would prefer an other variable name because it only enables some HA features for Neutron. Also I think this is the wrong category. The correct category is OpenStack options (starting on line 183).","commit_id":"4f359e17983ccd51651394fad05f3f98c4ac1dc3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c5c6b424dfc4ae57520f76dbb7fcc477e5c15dc2","unresolved":false,"context_lines":[{"line_number":177,"context_line":"internal_protocol: \"http\""},{"line_number":178,"context_line":"admin_protocol: \"http\""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"network_ha: \"no\""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"####################"},{"line_number":183,"context_line":"# OpenStack options"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_fc2a83e6","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":10},"in_reply_to":"9ad45d7e_ba7db0e9","updated":"2016-08-08 15:07:46.000000000","message":"OK, changed to neutron_agent_ha","commit_id":"4f359e17983ccd51651394fad05f3f98c4ac1dc3"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"46bf9b6505825834f6738a44f34001200a364403","unresolved":false,"context_lines":[{"line_number":242,"context_line":"enable_nova_fake: \"no\""},{"line_number":243,"context_line":"num_nova_fake_per_node: 5"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"neutron_agent_ha: \"no\""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"####################"},{"line_number":248,"context_line":"# Logging options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_372b8484","line":245,"updated":"2016-08-08 20:04:57.000000000","message":"Why not enable_neutron_agent_ha?","commit_id":"c3e0c665db00b8214323f6da30332e3e10328314"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"bcc511f5f94a2a136e8543d5f3d89990caa75c2f","unresolved":false,"context_lines":[{"line_number":242,"context_line":"enable_nova_fake: \"no\""},{"line_number":243,"context_line":"num_nova_fake_per_node: 5"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"neutron_agent_ha: \"no\""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"####################"},{"line_number":248,"context_line":"# Logging options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_fb6c2e9e","line":245,"in_reply_to":"9ad45d7e_372b8484","updated":"2016-08-09 00:18:32.000000000","message":"Done","commit_id":"c3e0c665db00b8214323f6da30332e3e10328314"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"e1de90126571432986fa557873ddac1d4db5557d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"# Nova fake driver and the number of fake driver per compute node"},{"line_number":243,"context_line":"enable_nova_fake: \"no\""},{"line_number":244,"context_line":"num_nova_fake_per_node: 5"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"####################"},{"line_number":247,"context_line":"# Logging options"},{"line_number":248,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_4430f601","line":245,"updated":"2016-08-09 05:49:02.000000000","message":"Please add back the blank line","commit_id":"3474fff72b502f95586b618130682a3f1e7b5008"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e60de5562364009d1bf4aa0111e6225de62e43f3","unresolved":false,"context_lines":[{"line_number":306,"context_line":"#######################"},{"line_number":307,"context_line":"# Neutron options"},{"line_number":308,"context_line":"#######################"},{"line_number":309,"context_line":"dhcp_agents_per_network: 2"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"###################"},{"line_number":312,"context_line":"# Ceph options"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_3ffe976b","line":309,"updated":"2016-08-25 08:34:22.000000000","message":"please move this to the neutron/defaults/main.yml file. \n\nThis is not a global variable shared between roles.","commit_id":"697cb312ce57889124ccd80e88c62ba8dc3eaef2"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"eab309d024414d627cb0bc46954e3a75a78fce83","unresolved":false,"context_lines":[{"line_number":52,"context_line":"####################"},{"line_number":53,"context_line":"# OpenStack"},{"line_number":54,"context_line":"####################"},{"line_number":55,"context_line":"dhcp_agents_per_network: 2"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"neutron_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""},{"line_number":58,"context_line":"neutron_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fa7ab95a_14047d15","line":55,"updated":"2016-08-26 13:15:57.000000000","message":"I think this would be more appropriate in all.yml","commit_id":"e70144eea607c9a02bd3fb173044bb87fa6cf271"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ab0093334624b703df055a42b06e7d50a05f571d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"####################"},{"line_number":53,"context_line":"# OpenStack"},{"line_number":54,"context_line":"####################"},{"line_number":55,"context_line":"dhcp_agents_per_network: 2"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"neutron_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""},{"line_number":58,"context_line":"neutron_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa7ab95a_bcdbe120","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":26},"updated":"2016-08-31 02:38:22.000000000","message":"should we not also support setting the min/max l3 router instances\nmax_l3_agents_per_router \u003d \u003c 2 to number of network nodes \u003e\nmin_l3_agents_per_router \u003d 2\nsee http://docs.openstack.org/mitaka/config-reference/networking/networking_options_reference.html#l3-agent","commit_id":"45e111144e444077c001ad980eb8789a581c9938"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"57a630f587bf90cd23982c62715dfe3e88264cde","unresolved":false,"context_lines":[{"line_number":52,"context_line":"####################"},{"line_number":53,"context_line":"# OpenStack"},{"line_number":54,"context_line":"####################"},{"line_number":55,"context_line":"dhcp_agents_per_network: 2"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"neutron_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""},{"line_number":58,"context_line":"neutron_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa7ab95a_5812da59","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":26},"in_reply_to":"fa7ab95a_bcdbe120","updated":"2016-08-31 06:13:57.000000000","message":"Done","commit_id":"45e111144e444077c001ad980eb8789a581c9938"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"e2add53994d71a36dbfda869e7e48358794fcd7b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"####################"},{"line_number":55,"context_line":"dhcp_agents_per_network: 2"},{"line_number":56,"context_line":"min_l3_agents_per_router: 2"},{"line_number":57,"context_line":"max_l3_agents_per_router: {{ groups[\u0027neutron-l3-agent\u0027] | length }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"neutron_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""},{"line_number":60,"context_line":"neutron_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa7ab95a_33e614e9","line":57,"updated":"2016-08-31 08:13:52.000000000","message":"I would leave default for max_l3_agents_per_router instead of inventing some logic here. 3 is a perfect default disregarding number of hosts","commit_id":"c92b0d588336887eb0d44c4b394c0f9f4b508432"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"20aee2ab872c9165e048ee204d936a5ada878225","unresolved":false,"context_lines":[{"line_number":54,"context_line":"####################"},{"line_number":55,"context_line":"dhcp_agents_per_network: 2"},{"line_number":56,"context_line":"min_l3_agents_per_router: 2"},{"line_number":57,"context_line":"max_l3_agents_per_router: {{ groups[\u0027neutron-l3-agent\u0027] | length }}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"neutron_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""},{"line_number":60,"context_line":"neutron_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"fa7ab95a_b6acd28d","line":57,"in_reply_to":"fa7ab95a_33e614e9","updated":"2016-08-31 08:31:37.000000000","message":"Done","commit_id":"c92b0d588336887eb0d44c4b394c0f9f4b508432"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"b7aba397611d0f634b71c94819d0ea48c3fe49f4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if network_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ groups[\"neutron-dhcp-agent\"] | length }}"},{"line_number":42,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":43,"context_line":"l3_ha \u003d true"},{"line_number":44,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_1a6ddc04","line":41,"updated":"2016-08-08 13:14:28.000000000","message":"This makes no sense. Maybe there is an environment with 50 DHCP agents. Why should neutron schedule 50 DHCP agents per network?","commit_id":"4f359e17983ccd51651394fad05f3f98c4ac1dc3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c5c6b424dfc4ae57520f76dbb7fcc477e5c15dc2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if network_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ groups[\"neutron-dhcp-agent\"] | length }}"},{"line_number":42,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":43,"context_line":"l3_ha \u003d true"},{"line_number":44,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_bf763d3c","line":41,"in_reply_to":"9ad45d7e_1a6ddc04","updated":"2016-08-08 15:07:46.000000000","message":"Yeah, make sense, use 2 instead here.","commit_id":"4f359e17983ccd51651394fad05f3f98c4ac1dc3"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"b7aba397611d0f634b71c94819d0ea48c3fe49f4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if network_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ groups[\"neutron-dhcp-agent\"] | length }}"},{"line_number":42,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":43,"context_line":"l3_ha \u003d true"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_1a3b1ced","line":42,"updated":"2016-08-08 13:14:28.000000000","message":"allow_automatic_dhcp_failover is True by default, but I would prefer to explicitly set it to true here.","commit_id":"4f359e17983ccd51651394fad05f3f98c4ac1dc3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c5c6b424dfc4ae57520f76dbb7fcc477e5c15dc2","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if network_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ groups[\"neutron-dhcp-agent\"] | length }}"},{"line_number":42,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":43,"context_line":"l3_ha \u003d true"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_ff8ef525","line":42,"in_reply_to":"9ad45d7e_1a3b1ced","updated":"2016-08-08 15:07:46.000000000","message":"Done","commit_id":"4f359e17983ccd51651394fad05f3f98c4ac1dc3"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"46bf9b6505825834f6738a44f34001200a364403","unresolved":false,"context_lines":[{"line_number":40,"context_line":"{% if neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":42,"context_line":"allow_automatic_dhcp_failover \u003d true"},{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 2"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"},{"line_number":46,"context_line":"allow_automatic_l3agent_failover \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_b73774e2","line":43,"updated":"2016-08-08 20:04:57.000000000","message":"I would use 3 here.","commit_id":"c3e0c665db00b8214323f6da30332e3e10328314"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"bcc511f5f94a2a136e8543d5f3d89990caa75c2f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"{% if neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":42,"context_line":"allow_automatic_dhcp_failover \u003d true"},{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 2"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"},{"line_number":46,"context_line":"allow_automatic_l3agent_failover \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_7b0f9ee1","line":43,"in_reply_to":"9ad45d7e_b73774e2","updated":"2016-08-09 00:18:32.000000000","message":"Done","commit_id":"c3e0c665db00b8214323f6da30332e3e10328314"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"46bf9b6505825834f6738a44f34001200a364403","unresolved":false,"context_lines":[{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 2"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"},{"line_number":46,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":47,"context_line":"l3_ha \u003d true"},{"line_number":48,"context_line":"{% endif %}"},{"line_number":49,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_f731eced","line":46,"updated":"2016-08-08 20:04:57.000000000","message":"I think it is safe to set this to true even when only having 1 l3 agent. Same for dhcp.","commit_id":"c3e0c665db00b8214323f6da30332e3e10328314"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"bcc511f5f94a2a136e8543d5f3d89990caa75c2f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 2"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"},{"line_number":46,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":47,"context_line":"l3_ha \u003d true"},{"line_number":48,"context_line":"{% endif %}"},{"line_number":49,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_1b3142a3","line":46,"in_reply_to":"9ad45d7e_f731eced","updated":"2016-08-09 00:18:32.000000000","message":"Done","commit_id":"c3e0c665db00b8214323f6da30332e3e10328314"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"e1de90126571432986fa557873ddac1d4db5557d","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"allow_automatic_dhcp_failover \u003d true"},{"line_number":42,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 3"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"allow_automatic_l3agent_failover \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_6f04f314","line":42,"updated":"2016-08-09 05:49:02.000000000","message":"what if enable_neutron_agent_ha is set to true, while group[neutron-dhcp-agent] has \u003c 2 nodes?","commit_id":"3474fff72b502f95586b618130682a3f1e7b5008"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"42bcdf1fd9e9295d18a6450fc904d4555a7e406b","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"allow_automatic_dhcp_failover \u003d true"},{"line_number":42,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 3"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"allow_automatic_l3agent_failover \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_de5b0e53","line":42,"in_reply_to":"9ad45d7e_6f04f314","updated":"2016-08-09 07:12:19.000000000","message":"The default value is 1","commit_id":"3474fff72b502f95586b618130682a3f1e7b5008"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d3aaeffd7623b67ff462833657d3733c59ec3e8f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"allow_automatic_dhcp_failover \u003d true"},{"line_number":42,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 3"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":46,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1ac06dbe_930a8824","line":43,"updated":"2016-08-24 01:33:23.000000000","message":"what happen if i only have two neutron-dhcp-agent and setting the dhcp_agents_per_network to 3.","commit_id":"5cc039fb737989347be6ca87c2074616b3d2eb6b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c03e5f17ca1c591c716646c38779a112dd8e4431","unresolved":false,"context_lines":[{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"allow_automatic_dhcp_failover \u003d true"},{"line_number":42,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 3"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":46,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1ac06dbe_57874eb4","line":43,"in_reply_to":"1ac06dbe_930a8824","updated":"2016-08-24 08:12:58.000000000","message":"Yeah, need to check this.","commit_id":"5cc039fb737989347be6ca87c2074616b3d2eb6b"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d3aaeffd7623b67ff462833657d3733c59ec3e8f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 3"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":46,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"},{"line_number":47,"context_line":"l3_ha \u003d true"},{"line_number":48,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1ac06dbe_333474fa","line":45,"updated":"2016-08-24 01:33:23.000000000","message":"why this option is not in the following if condition? what will happen if a have only one neutron-l3-agent and enable the allow_automatic_l3_agent_failover?","commit_id":"5cc039fb737989347be6ca87c2074616b3d2eb6b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c03e5f17ca1c591c716646c38779a112dd8e4431","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":43,"context_line":"dhcp_agents_per_network \u003d 3"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":46,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"},{"line_number":47,"context_line":"l3_ha \u003d true"},{"line_number":48,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1ac06dbe_7a3d0fc3","line":45,"in_reply_to":"1ac06dbe_333474fa","updated":"2016-08-24 08:12:58.000000000","message":"moved into if condition","commit_id":"5cc039fb737989347be6ca87c2074616b3d2eb6b"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"ac7a495737cf25748d5637bd99d083c53b4f8738","unresolved":false,"context_lines":[{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":42,"context_line":"allow_automatic_dhcp_failover \u003d true"},{"line_number":43,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003d\u003d 2 %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1ac06dbe_060f5c2f","line":40,"updated":"2016-08-24 12:17:59.000000000","message":"https://review.openstack.org/#/c/359819/1/ansible/roles/neutron/templates/neutron.conf.j2\n\nthat\u0027s a minimum required for the config","commit_id":"2eb516dcd765d13f2fc4c6b8def166c72277371b"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"3f3c435007eef26f9181041fe3c68ca2447e1a48","unresolved":false,"context_lines":[{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":42,"context_line":"allow_automatic_dhcp_failover \u003d true"},{"line_number":43,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003d\u003d 2 %}"},{"line_number":44,"context_line":"dhcp_agents_per_network \u003d 2"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1ac06dbe_fa9a9a60","line":41,"updated":"2016-08-24 09:46:07.000000000","message":"I would prefer to make a precheck. When somebody enables Neutron Agent HA he has to deploy at least two dhcp/l3 agents. If you enable this feature and do deploy one one dhcp/l3 agent it makes no sense.","commit_id":"2eb516dcd765d13f2fc4c6b8def166c72277371b"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"3f3c435007eef26f9181041fe3c68ca2447e1a48","unresolved":false,"context_lines":[{"line_number":47,"context_line":"{% endif %}"},{"line_number":48,"context_line":"{% endif %}"},{"line_number":49,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"},{"line_number":50,"context_line":"allow_automatic_l3agent_failover \u003d true"},{"line_number":51,"context_line":"l3_ha \u003d true"},{"line_number":52,"context_line":"{% endif %}"},{"line_number":53,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1ac06dbe_fae8dab4","line":50,"updated":"2016-08-24 09:46:07.000000000","message":"ditto","commit_id":"2eb516dcd765d13f2fc4c6b8def166c72277371b"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"9f590c27f99f02a957b00dbda10dbb453154ea7f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":42,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1ac06dbe_b81c936b","line":41,"updated":"2016-08-24 15:35:56.000000000","message":"I think this check for \u003e\u003d 2 can be removed now?","commit_id":"8bfc0c140131e060adbb69132805ed94ca79fd5f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"70a814137481b28e05663664bae95aabdf0449a3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":42,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1ac06dbe_baaf4c2a","line":41,"in_reply_to":"1ac06dbe_b81c936b","updated":"2016-08-25 00:20:46.000000000","message":"Done","commit_id":"8bfc0c140131e060adbb69132805ed94ca79fd5f"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"9f590c27f99f02a957b00dbda10dbb453154ea7f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":42,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"},{"line_number":45,"context_line":"l3_ha \u003d true"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1ac06dbe_f8244bb3","line":44,"updated":"2016-08-24 15:35:56.000000000","message":"ditto","commit_id":"8bfc0c140131e060adbb69132805ed94ca79fd5f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"70a814137481b28e05663664bae95aabdf0449a3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"{% if groups[\"neutron-dhcp-agent\"] | length \u003e\u003d 2 %}"},{"line_number":42,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":"{% if groups[\"neutron-l3-agent\"] | length \u003e\u003d2 %}"},{"line_number":45,"context_line":"l3_ha \u003d true"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"1ac06dbe_9aac1037","line":44,"in_reply_to":"1ac06dbe_f8244bb3","updated":"2016-08-25 00:20:46.000000000","message":"Done","commit_id":"8bfc0c140131e060adbb69132805ed94ca79fd5f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ab0093334624b703df055a42b06e7d50a05f571d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"},{"line_number":42,"context_line":"l3_ha \u003d true"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":46,"context_line":"[service_providers]"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"fa7ab95a_dc07c57f","line":43,"range":{"start_line":40,"start_character":0,"end_line":43,"end_character":11},"updated":"2016-08-31 02:38:22.000000000","message":"these should be set in the dhcp_agent.ini config and l3_agent.ini respectivly instead of the main neutron config.","commit_id":"45e111144e444077c001ad980eb8789a581c9938"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"57a630f587bf90cd23982c62715dfe3e88264cde","unresolved":false,"context_lines":[{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_agent_ha | bool %}"},{"line_number":41,"context_line":"dhcp_agents_per_network \u003d {{ dhcp_agents_per_network }}"},{"line_number":42,"context_line":"l3_ha \u003d true"},{"line_number":43,"context_line":"{% endif %}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":46,"context_line":"[service_providers]"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"fa7ab95a_3dd508b9","line":43,"range":{"start_line":40,"start_character":0,"end_line":43,"end_character":11},"in_reply_to":"fa7ab95a_dc07c57f","updated":"2016-08-31 06:13:57.000000000","message":"These are used by the scheduler, should be set in neutron.conf","commit_id":"45e111144e444077c001ad980eb8789a581c9938"}],"ansible/roles/prechecks/tasks/service_checks.yml":[{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"f0f94edfa86ffea6544b9c2cb3234b21c37157d8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  changed_when: false"},{"line_number":44,"context_line":"  failed_when: result.stdout | regex_replace(\u0027(.*ssh_key.*)\u0027, \u0027\u0027) | search(\":\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Checking if number of network agents are less than two when enabling agent ha"},{"line_number":47,"context_line":"  command: echo {{ groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2 or"},{"line_number":48,"context_line":"                   groups[\u0027neutron-l3-agent\u0027] | length \u003c 2 }}"},{"line_number":49,"context_line":"  register: result"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ac06dbe_785dfb47","line":46,"updated":"2016-08-24 15:45:42.000000000","message":"this should be local_action - no need to run this task on all hosts","commit_id":"8bfc0c140131e060adbb69132805ed94ca79fd5f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"70a814137481b28e05663664bae95aabdf0449a3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  changed_when: false"},{"line_number":44,"context_line":"  failed_when: result.stdout | regex_replace(\u0027(.*ssh_key.*)\u0027, \u0027\u0027) | search(\":\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Checking if number of network agents are less than two when enabling agent ha"},{"line_number":47,"context_line":"  command: echo {{ groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2 or"},{"line_number":48,"context_line":"                   groups[\u0027neutron-l3-agent\u0027] | length \u003c 2 }}"},{"line_number":49,"context_line":"  register: result"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ac06dbe_1a35c0f6","line":46,"in_reply_to":"1ac06dbe_785dfb47","updated":"2016-08-25 00:20:46.000000000","message":"Done","commit_id":"8bfc0c140131e060adbb69132805ed94ca79fd5f"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"f0f94edfa86ffea6544b9c2cb3234b21c37157d8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  register: result"},{"line_number":50,"context_line":"  changed_when: false"},{"line_number":51,"context_line":"  failed_when: result.stdout | bool"},{"line_number":52,"context_line":"  when: enable_neutron_agent_ha is defined and enable_neutron_agent_ha | bool"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ac06dbe_fb2445b3","line":52,"updated":"2016-08-24 15:45:42.000000000","message":"enable_neutron_agent_ha | bool is enough since it is defined anyway","commit_id":"8bfc0c140131e060adbb69132805ed94ca79fd5f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"70a814137481b28e05663664bae95aabdf0449a3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  register: result"},{"line_number":50,"context_line":"  changed_when: false"},{"line_number":51,"context_line":"  failed_when: result.stdout | bool"},{"line_number":52,"context_line":"  when: enable_neutron_agent_ha is defined and enable_neutron_agent_ha | bool"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ac06dbe_55242bae","line":52,"in_reply_to":"1ac06dbe_fb2445b3","updated":"2016-08-25 00:20:46.000000000","message":"Done","commit_id":"8bfc0c140131e060adbb69132805ed94ca79fd5f"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"82b26369ba50c3685af42ac03561872f2c6a70ea","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  failed_when: result.stdout | regex_replace(\u0027(.*ssh_key.*)\u0027, \u0027\u0027) | search(\":\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Checking if number of network agents are less than two when enabling agent ha"},{"line_number":47,"context_line":"  local_action: command echo {{ groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2 or"},{"line_number":48,"context_line":"                                groups[\u0027neutron-l3-agent\u0027] | length \u003c 2 }}"},{"line_number":49,"context_line":"  register: result"},{"line_number":50,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1ac06dbe_9e20644b","line":47,"updated":"2016-08-25 11:00:39.000000000","message":"Why is it not possible to directly use failed_when to analyse the values? Is it necessary to run echo for it?","commit_id":"08f4cc5c5c851f86e760046d61b5ec3063fec513"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"238246547f369510517b38ee4754b63b6f6d7d2a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  failed_when: result.stdout | regex_replace(\u0027(.*ssh_key.*)\u0027, \u0027\u0027) | search(\":\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Checking if number of network agents are less than two when enabling agent ha"},{"line_number":47,"context_line":"  local_action: command echo {{ groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2 or"},{"line_number":48,"context_line":"                                groups[\u0027neutron-l3-agent\u0027] | length \u003c 2 }}"},{"line_number":49,"context_line":"  register: result"},{"line_number":50,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1ac06dbe_7d93edfa","line":47,"in_reply_to":"1ac06dbe_9e20644b","updated":"2016-08-25 11:34:33.000000000","message":"An action is always needed for failed_when. I changed this to:\n\n- name: Checking if number of network agents are less than two when enabling agent ha\n  fail: msg\u003d\"Network agents are less than two\"\n  when: enable_neutron_agent_ha | bool and\n        (groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2 or groups[\u0027neutron-l3-agent\u0027] | length \u003c 2)","commit_id":"08f4cc5c5c851f86e760046d61b5ec3063fec513"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e2f112620fd674c47c4a8654c96784335f63af81","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Checking if number of network agents are less than two when enabling agent ha"},{"line_number":47,"context_line":"  fail: msg\u003d\"Network agents are less than two\""},{"line_number":48,"context_line":"  when: enable_neutron_agent_ha | bool and"},{"line_number":49,"context_line":"        (groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2 or groups[\u0027neutron-l3-agent\u0027] | length \u003c 2)"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa7ab95a_f3166fa6","line":48,"updated":"2016-08-26 02:33:48.000000000","message":"need add run_once + delegate_to\nor use local_action","commit_id":"754f037082f67ce72245f998b79bebb5377a77f4"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"538341a65c9ffe9e1028d17f3b1ef76354273747","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Checking if number of network agents are less than two when enabling agent ha"},{"line_number":47,"context_line":"  fail: msg\u003d\"Network agents are less than two\""},{"line_number":48,"context_line":"  when: enable_neutron_agent_ha | bool and"},{"line_number":49,"context_line":"        (groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2 or groups[\u0027neutron-l3-agent\u0027] | length \u003c 2)"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa7ab95a_4eddb06f","line":48,"in_reply_to":"fa7ab95a_f3166fa6","updated":"2016-08-26 02:58:47.000000000","message":"I\u0027m not sure which host should be used for delegate_to, could you enlighten me?","commit_id":"754f037082f67ce72245f998b79bebb5377a77f4"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"dad892b8967a1bd2de3cc85a38eed3c775e40c4e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  fail: msg\u003d\"Network agents are less than two\""},{"line_number":48,"context_line":"  run_once: True"},{"line_number":49,"context_line":"  when: enable_neutron_agent_ha | bool and"},{"line_number":50,"context_line":"        (groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2 or groups[\u0027neutron-l3-agent\u0027] | length \u003c 2)"},{"line_number":51,"context_line":"  delegate_to: \"{{ groups[\u0027neutron-server\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fa7ab95a_61cc3436","line":50,"updated":"2016-08-26 10:11:04.000000000","message":"actually I would check groups[\u0027neutron\u0027] \u003c 2 and delegate to groups[\u0027neutron\u0027][0]. Having separate subgroups for dhcp,l3,meta makes little sense anyway, especially for dvr case (this case is similar to openvswitch running on both network and compute hosts)","commit_id":"e70144eea607c9a02bd3fb173044bb87fa6cf271"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"eab309d024414d627cb0bc46954e3a75a78fce83","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  fail: msg\u003d\"Network agents are less than two\""},{"line_number":48,"context_line":"  run_once: True"},{"line_number":49,"context_line":"  when: enable_neutron_agent_ha | bool and"},{"line_number":50,"context_line":"        (groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2 or groups[\u0027neutron-l3-agent\u0027] | length \u003c 2)"},{"line_number":51,"context_line":"  delegate_to: \"{{ groups[\u0027neutron-server\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fa7ab95a_541d2572","line":50,"in_reply_to":"fa7ab95a_61cc3436","updated":"2016-08-26 13:15:57.000000000","message":"Can we just use local_action as Vlad suggested in a previous patchset?","commit_id":"e70144eea607c9a02bd3fb173044bb87fa6cf271"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"749f1a6db3ed0bd926821b31ff44315ad88b8fee","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  register: result"},{"line_number":56,"context_line":"  changed_when: false"},{"line_number":57,"context_line":"  failed_when: result.stdout | bool"},{"line_number":58,"context_line":"  when: enable_neutron_agent_ha | bool"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa7ab95a_3701f56a","line":58,"updated":"2016-08-30 04:47:40.000000000","message":"If I understand correctly, this should be run_once.","commit_id":"d1842ca34b72f0e5545509f79176dc7f7fcda751"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"281f37c94f078f1f9c4bdcb92106bcc21809a01f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  register: result"},{"line_number":56,"context_line":"  changed_when: false"},{"line_number":57,"context_line":"  failed_when: result.stdout | bool"},{"line_number":58,"context_line":"  when: enable_neutron_agent_ha | bool"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa7ab95a_ed933959","line":58,"in_reply_to":"fa7ab95a_3701f56a","updated":"2016-08-30 07:02:04.000000000","message":"I\u0027m not sure if it\u0027s needed, other checks are not using this.","commit_id":"d1842ca34b72f0e5545509f79176dc7f7fcda751"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"27e196fec6e8440830281ea1189b0d985686fbd2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  register: result"},{"line_number":56,"context_line":"  changed_when: false"},{"line_number":57,"context_line":"  failed_when: result.stdout | bool"},{"line_number":58,"context_line":"  when: enable_neutron_agent_ha | bool"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa7ab95a_91d9e359","line":58,"in_reply_to":"fa7ab95a_ed933959","updated":"2016-08-30 09:15:33.000000000","message":"local_action is \"run_once\"","commit_id":"d1842ca34b72f0e5545509f79176dc7f7fcda751"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"27e196fec6e8440830281ea1189b0d985686fbd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fa7ab95a_7450cd0b","line":59,"updated":"2016-08-30 09:15:33.000000000","message":"hopefully last rework :)\n\nwhat about an easy approach - local_action with fail module?\n\n- name: Checking number of network agents\n  local_action: fail msg\u003d\"Number of network agents are less than two when enabling agent ha\"\n  changed_when: false\n  when: groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2\n        or groups[\u0027neutron-l3-agent\u0027] | length \u003c 2","commit_id":"d1842ca34b72f0e5545509f79176dc7f7fcda751"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"fe319817e044d78945b2a3ce9de9628f745f1d14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fa7ab95a_f4705d0d","line":59,"in_reply_to":"fa7ab95a_7450cd0b","updated":"2016-08-30 09:24:42.000000000","message":"- name: Checking number of network agents\n  local_action: fail msg\u003d\"Number of network agents are less than two when enabling agent ha\"\n  changed_when: false\n  when:\n    - enable_neutron_agent_ha | bool\n    - groups[\u0027neutron-dhcp-agent\u0027] | length \u003c 2\n      or groups[\u0027neutron-l3-agent\u0027] | length \u003c 2","commit_id":"d1842ca34b72f0e5545509f79176dc7f7fcda751"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"9716c03bf65bcf9f01f1efd8fd65e00f42d7dbc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fa7ab95a_a8db9f20","line":59,"in_reply_to":"fa7ab95a_f4705d0d","updated":"2016-08-31 00:11:11.000000000","message":"Done, i hope so;) thanks for reviewing!","commit_id":"d1842ca34b72f0e5545509f79176dc7f7fcda751"}]}