)]}'
{"ansible/inventory/all-in-one":[{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"c7f5da019dfd81079f2de31b7836591b83d39959","unresolved":false,"context_lines":[{"line_number":200,"context_line":"storage"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"# Barbican"},{"line_number":203,"context_line":"[barbican-api:children]]"},{"line_number":204,"context_line":"barbican"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"[barbican-keystone-listener:children]"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"fa7ab95a_bb799284","line":203,"updated":"2016-09-02 06:05:38.000000000","message":"remove extra closing braces ]","commit_id":"3a06d0faebe16b377756d061debe0cc532a69fe3"}],"ansible/roles/barbican/meta/main.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"13037b5e54dd726f33ac6df42fd47a01a3eec631","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027barbican.yml\u0027  }"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_eef43b88","line":3,"range":{"start_line":3,"start_character":20,"end_line":3,"end_character":48},"updated":"2016-08-09 19:20:44.000000000","message":"this is not necessary","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"37cf8f69b6b1c2c8ca14c4d74d9556f80837c6c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027barbican.yml\u0027  }"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_403331f6","line":3,"range":{"start_line":3,"start_character":18,"end_line":3,"end_character":49},"updated":"2016-08-29 16:45:16.000000000","message":"project_yaml is not needed","commit_id":"ecb0b8a43ca6adb51c89e2dc1e6c5a8c8c4c3052"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"7b382fb49a0b49e5e08251c80a4292bbdfc62445","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common, project_yaml: \u0027barbican.yml\u0027  }"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_f08790b2","line":3,"range":{"start_line":3,"start_character":18,"end_line":3,"end_character":49},"in_reply_to":"fa7ab95a_403331f6","updated":"2016-08-30 07:31:19.000000000","message":"Done","commit_id":"ecb0b8a43ca6adb51c89e2dc1e6c5a8c8c4c3052"}],"ansible/roles/barbican/tasks/config.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      - \"/etc/kolla/config/global.conf\""},{"line_number":28,"context_line":"      - \"/etc/kolla/config/database.conf\""},{"line_number":29,"context_line":"      - \"/etc/kolla/config/messaging.conf\""},{"line_number":30,"context_line":"      - \"/etc/kolla/config/glance.conf\""},{"line_number":31,"context_line":"      - \"/etc/kolla/config/glance/{{ item }}.conf\""},{"line_number":32,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/barbican.conf\""},{"line_number":33,"context_line":"  with_items:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_9a2cd503","line":30,"range":{"start_line":30,"start_character":27,"end_line":30,"end_character":33},"updated":"2016-08-09 21:16:43.000000000","message":"Change to barbican","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      - \"/etc/kolla/config/database.conf\""},{"line_number":29,"context_line":"      - \"/etc/kolla/config/messaging.conf\""},{"line_number":30,"context_line":"      - \"/etc/kolla/config/glance.conf\""},{"line_number":31,"context_line":"      - \"/etc/kolla/config/glance/{{ item }}.conf\""},{"line_number":32,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/barbican.conf\""},{"line_number":33,"context_line":"  with_items:"},{"line_number":34,"context_line":"    - \"barbican-api\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_ba39d943","line":31,"range":{"start_line":31,"start_character":27,"end_line":31,"end_character":33},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"2d17b0268ad791313f43d56abe07dd4c347895ab","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/barbican.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/barbican/{{ item }}.conf\""},{"line_number":32,"context_line":"      - \"{{ node_custom_config }}/barbican/{{ inventory_hostname }}/barbican.conf\""},{"line_number":33,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/barbican.conf\""},{"line_number":34,"context_line":"  with_items:"},{"line_number":35,"context_line":"    - \"barbican-api\""},{"line_number":36,"context_line":"    - \"barbican-keystone-listener\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_280031aa","line":33,"range":{"start_line":33,"start_character":39,"end_line":33,"end_character":49},"updated":"2016-08-25 02:59:58.000000000","message":"Should the same barbican.conf be in 3 different folders: barbican-api, barbican-keystone-listener, and barbican-worker?  Thought there is only /etc/barbican/barbican/conf.","commit_id":"97e144843061f8fbef5bdfa551854677eedbc54a"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f73c1dc670e842b0e3da4e53c41362fa7de27eec","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/barbican.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/barbican/{{ item }}.conf\""},{"line_number":32,"context_line":"      - \"{{ node_custom_config }}/barbican/{{ inventory_hostname }}/barbican.conf\""},{"line_number":33,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/barbican.conf\""},{"line_number":34,"context_line":"  with_items:"},{"line_number":35,"context_line":"    - \"barbican-api\""},{"line_number":36,"context_line":"    - \"barbican-keystone-listener\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_3106d520","line":33,"range":{"start_line":33,"start_character":39,"end_line":33,"end_character":49},"in_reply_to":"1ac06dbe_280031aa","updated":"2016-08-25 06:29:09.000000000","message":"OK，good advice\nI think you can refer to the next https://github.com/openstack/kolla/blob/master/ansible/roles/ceilometer/tasks/config.yml \n There is no repetition.","commit_id":"97e144843061f8fbef5bdfa551854677eedbc54a"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"e814a6eaee62dd28154290641966e5dcaa120209","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      - \"{{ node_custom_config }}/barbican.conf\""},{"line_number":31,"context_line":"      - \"{{ node_custom_config }}/barbican/{{ item }}.conf\""},{"line_number":32,"context_line":"      - \"{{ node_custom_config }}/barbican/{{ inventory_hostname }}/barbican.conf\""},{"line_number":33,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/barbican.conf\""},{"line_number":34,"context_line":"  with_items:"},{"line_number":35,"context_line":"    - \"barbican-api\""},{"line_number":36,"context_line":"    - \"barbican-keystone-listener\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_ca5b1786","line":33,"range":{"start_line":33,"start_character":39,"end_line":33,"end_character":49},"in_reply_to":"1ac06dbe_3106d520","updated":"2016-08-28 05:18:44.000000000","message":"Done","commit_id":"97e144843061f8fbef5bdfa551854677eedbc54a"}],"ansible/roles/barbican/tasks/deploy.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- include: config.yml"},{"line_number":6,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_5a79bdf5","line":3,"range":{"start_line":3,"start_character":38,"end_line":3,"end_character":46},"updated":"2016-08-09 21:16:43.000000000","message":"This used to be barbican-api only","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- include: config.yml"},{"line_number":6,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include: bootstrap.yml"},{"line_number":9,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_fafeb136","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":48},"updated":"2016-08-09 21:16:43.000000000","message":"Usually here is used something like this:\n when: inventory_hostname in groups[\u0027barbican-api\u0027] or\n       inventory_hostname in groups[\u0027barbican-worker\u0027] or \n       inventory_hostname in groups[\u0027barbican-keystone-listener\u0027]","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include: bootstrap.yml"},{"line_number":9,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- include: start.yml"},{"line_number":12,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_baa3994e","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":46},"updated":"2016-08-09 21:16:43.000000000","message":"Here barbican-api only","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- include: start.yml"},{"line_number":12,"context_line":"  when: inventory_hostname in groups[\u0027barbican\u0027]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_baba796c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":48},"updated":"2016-08-09 21:16:43.000000000","message":"The same as config.yml\nUsually here is used something like this:\n when: inventory_hostname in groups[\u0027barbican-api\u0027] or\n       inventory_hostname in groups[\u0027barbican-worker\u0027] or \n       inventory_hostname in groups[\u0027barbican-keystone-listener\u0027]","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6e65d74e698f112ad5b72fceae0115ecf24ad263","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027barbican-api\u0027] or"},{"line_number":4,"context_line":"        inventory_hostname in groups[\u0027barbican-worker\u0027] or "},{"line_number":5,"context_line":"        inventory_hostname in groups[\u0027barbican-keystone-listener\u0027]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- include: config.yml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_3e22f400","line":4,"range":{"start_line":4,"start_character":57,"end_line":4,"end_character":59},"updated":"2016-08-10 01:45:09.000000000","message":"Remove whitespace","commit_id":"d4343abc72d8e6fce1331e661a2b086ff02d2e31"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6e65d74e698f112ad5b72fceae0115ecf24ad263","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- include: config.yml"},{"line_number":8,"context_line":"  when: inventory_hostname in groups[\u0027barbican-api\u0027] or"},{"line_number":9,"context_line":"        inventory_hostname in groups[\u0027barbican-worker\u0027] or "},{"line_number":10,"context_line":"        inventory_hostname in groups[\u0027barbican-keystone-listener\u0027]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include: bootstrap.yml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_7e7aacf2","line":9,"range":{"start_line":9,"start_character":58,"end_line":9,"end_character":59},"updated":"2016-08-10 01:45:09.000000000","message":"Ditto","commit_id":"d4343abc72d8e6fce1331e661a2b086ff02d2e31"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6e65d74e698f112ad5b72fceae0115ecf24ad263","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include: bootstrap.yml"},{"line_number":13,"context_line":"  when: inventory_hostname in groups[\u0027barbican-api\u0027] or"},{"line_number":14,"context_line":"        inventory_hostname in groups[\u0027barbican-worker\u0027] or "},{"line_number":15,"context_line":"        inventory_hostname in groups[\u0027barbican-keystone-listener\u0027]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- include: start.yml"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_be8424d4","line":14,"range":{"start_line":14,"start_character":58,"end_line":14,"end_character":59},"updated":"2016-08-10 01:45:09.000000000","message":"Ditto","commit_id":"d4343abc72d8e6fce1331e661a2b086ff02d2e31"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6e65d74e698f112ad5b72fceae0115ecf24ad263","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- include: start.yml"},{"line_number":18,"context_line":"  when: inventory_hostname in groups[\u0027barbican-api\u0027] or"},{"line_number":19,"context_line":"        inventory_hostname in groups[\u0027barbican-worker\u0027] or "},{"line_number":20,"context_line":"        inventory_hostname in groups[\u0027barbican-keystone-listener\u0027]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_9e87a0d6","line":19,"range":{"start_line":19,"start_character":58,"end_line":19,"end_character":59},"updated":"2016-08-10 01:45:09.000000000","message":"Ditto","commit_id":"d4343abc72d8e6fce1331e661a2b086ff02d2e31"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3a993ad4b5016149573ba745974495c122980525","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: register.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027barbican-api\u0027] or"},{"line_number":4,"context_line":"        inventory_hostname in groups[\u0027barbican-worker\u0027] or"},{"line_number":5,"context_line":"        inventory_hostname in groups[\u0027barbican-keystone-listener\u0027]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- include: config.yml"},{"line_number":8,"context_line":"  when: inventory_hostname in groups[\u0027barbican-api\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_a6ac1536","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":66},"updated":"2016-08-10 07:29:21.000000000","message":"Register only need to be executed at barbican-api containers, remove barbican-worker and barbican-keystone-listener","commit_id":"a02885351ec024a132e80f8c48d6f38fcdff1bb9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3a993ad4b5016149573ba745974495c122980525","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include: bootstrap.yml"},{"line_number":13,"context_line":"  when: inventory_hostname in groups[\u0027barbican-api\u0027] or"},{"line_number":14,"context_line":"        inventory_hostname in groups[\u0027barbican-worker\u0027] or"},{"line_number":15,"context_line":"        inventory_hostname in groups[\u0027barbican-keystone-listener\u0027]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- include: start.yml"},{"line_number":18,"context_line":"  when: inventory_hostname in groups[\u0027barbican-api\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_46643921","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":66},"updated":"2016-08-10 07:29:21.000000000","message":"Ditto","commit_id":"a02885351ec024a132e80f8c48d6f38fcdff1bb9"}],"ansible/roles/barbican/tasks/do_reconfigure.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  when: inventory_hostname in groups[item.group]"},{"line_number":9,"context_line":"  with_items:"},{"line_number":10,"context_line":"    - { name: barbican_api, group: barbican-api }"},{"line_number":11,"context_line":"    - { name: barbican-keystone-listener, group: barbican-keystone-listener }"},{"line_number":12,"context_line":"    - { name: barbican-worker, group: barbican-worker }"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- include: config.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_45bba20e","line":11,"range":{"start_line":11,"start_character":14,"end_line":11,"end_character":40},"updated":"2016-08-09 21:16:43.000000000","message":"Container is started with name barbican_keystone_listener instead of barbican-keystone-listener here: https://review.openstack.org/#/c/352515/4/ansible/roles/barbican/tasks/start.yml","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  with_items:"},{"line_number":10,"context_line":"    - { name: barbican_api, group: barbican-api }"},{"line_number":11,"context_line":"    - { name: barbican-keystone-listener, group: barbican-keystone-listener }"},{"line_number":12,"context_line":"    - { name: barbican-worker, group: barbican-worker }"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- include: config.yml"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_05488a2c","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":29},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  when: inventory_hostname in groups[item.group]"},{"line_number":22,"context_line":"  with_items:"},{"line_number":23,"context_line":"    - { name: barbican_api, group: barbican-api }"},{"line_number":24,"context_line":"    - { name: barbican-keystone-listener, group: barbican-keystone-listener }"},{"line_number":25,"context_line":"    - { name: barbican-worker, group: barbican-worker }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(jeffrey4l): when config_strategy \u003d\u003d \u0027COPY_ALWAYS\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_c55cb2ef","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":40},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  with_items:"},{"line_number":23,"context_line":"    - { name: barbican_api, group: barbican-api }"},{"line_number":24,"context_line":"    - { name: barbican-keystone-listener, group: barbican-keystone-listener }"},{"line_number":25,"context_line":"    - { name: barbican-worker, group: barbican-worker }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(jeffrey4l): when config_strategy \u003d\u003d \u0027COPY_ALWAYS\u0027"},{"line_number":28,"context_line":"# and container env[\u0027KOLLA_CONFIG_STRATEGY\u0027] \u003d\u003d \u0027COPY_ONCE\u0027,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_e510d603","line":25,"range":{"start_line":25,"start_character":14,"end_line":25,"end_character":29},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  when: inventory_hostname in groups[item.group]"},{"line_number":36,"context_line":"  with_items:"},{"line_number":37,"context_line":"    - { name: barbican_api, group: barbican-api }"},{"line_number":38,"context_line":"    - { name: barbican-keystone-listener, group: barbican-keystone-listener }"},{"line_number":39,"context_line":"    - { name: barbican-worker, group: barbican-worker }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Remove the containers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_c513120c","line":38,"range":{"start_line":38,"start_character":14,"end_line":38,"end_character":40},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  with_items:"},{"line_number":37,"context_line":"    - { name: barbican_api, group: barbican-api }"},{"line_number":38,"context_line":"    - { name: barbican-keystone-listener, group: barbican-keystone-listener }"},{"line_number":39,"context_line":"    - { name: barbican-worker, group: barbican-worker }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Remove the containers"},{"line_number":42,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_4500c2aa","line":39,"range":{"start_line":39,"start_character":14,"end_line":39,"end_character":29},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":50,"context_line":"  with_together:"},{"line_number":51,"context_line":"    - [{ name: barbican_api, group: barbican-api },"},{"line_number":52,"context_line":"       { name: barbican-keystone-listener, group: barbican-keystone-listener },"},{"line_number":53,"context_line":"       { name: barbican-worker, group: barbican-worker }]"},{"line_number":54,"context_line":"    - container_envs.results"},{"line_number":55,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_a52d3e48","line":52,"range":{"start_line":52,"start_character":15,"end_line":52,"end_character":41},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  with_together:"},{"line_number":51,"context_line":"    - [{ name: barbican_api, group: barbican-api },"},{"line_number":52,"context_line":"       { name: barbican-keystone-listener, group: barbican-keystone-listener },"},{"line_number":53,"context_line":"       { name: barbican-worker, group: barbican-worker }]"},{"line_number":54,"context_line":"    - container_envs.results"},{"line_number":55,"context_line":"    - check_results.results"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_8530fa9f","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":30},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":69,"context_line":"  with_together:"},{"line_number":70,"context_line":"    - [{ name: barbican_api, group: barbican-api },"},{"line_number":71,"context_line":"       { name: barbican-keystone-listener, group: barbican-keystone-listener },"},{"line_number":72,"context_line":"       { name: barbican-worker, group: barbican-worker }]"},{"line_number":73,"context_line":"    - container_envs.results"},{"line_number":74,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_2522ee52","line":71,"range":{"start_line":71,"start_character":15,"end_line":71,"end_character":41},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"15ad592c4c9d221cf51142269aee1d871c325b89","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  with_together:"},{"line_number":70,"context_line":"    - [{ name: barbican_api, group: barbican-api },"},{"line_number":71,"context_line":"       { name: barbican-keystone-listener, group: barbican-keystone-listener },"},{"line_number":72,"context_line":"       { name: barbican-worker, group: barbican-worker }]"},{"line_number":73,"context_line":"    - container_envs.results"},{"line_number":74,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_451722ed","line":72,"range":{"start_line":72,"start_character":15,"end_line":72,"end_character":30},"updated":"2016-08-09 21:16:43.000000000","message":"Ditto","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"cc5b75ca524e0e8a65cc49d8983087bc7baca447","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    - [{ name: barbican_api, group: barbican-api },"},{"line_number":52,"context_line":"       { name: barbican_keystone_listener, group: barbican-keystone-listener },"},{"line_number":53,"context_line":"       { name: barbican_worker, group: barbican-worker }]"},{"line_number":54,"context_line":"    - container_envs.results"},{"line_number":55,"context_line":"    - check_results.results"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- include: start.yml"},{"line_number":58,"context_line":"  when: remove_containers.changed"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_2022d200","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":27},"updated":"2016-08-10 03:19:51.000000000","message":"You should use full variable syntax.\nEx:\n\n{{ container_envs.results }}","commit_id":"fc0d8643da73a34440f06b812603e136ad4bf04a"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"cc5b75ca524e0e8a65cc49d8983087bc7baca447","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    - [{ name: barbican_api, group: barbican-api },"},{"line_number":71,"context_line":"       { name: barbican_keystone_listener, group: barbican-keystone-listener },"},{"line_number":72,"context_line":"       { name: barbican_worker, group: barbican-worker }]"},{"line_number":73,"context_line":"    - container_envs.results"},{"line_number":74,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_e06efa2d","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":27},"updated":"2016-08-10 03:19:51.000000000","message":"You should use full variable syntax.\nEx:\n\n{{ container_envs.results }}","commit_id":"fc0d8643da73a34440f06b812603e136ad4bf04a"}],"ansible/roles/barbican/tasks/register.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"13037b5e54dd726f33ac6df42fd47a01a3eec631","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    -m kolla_keystone_service"},{"line_number":5,"context_line":"    -a \"service_name\u003dbarbican"},{"line_number":6,"context_line":"        service_type\u003dkey-manager"},{"line_number":7,"context_line":"        description\u003d\u0027Barbican Key Management Service\u0027"},{"line_number":8,"context_line":"        endpoint_region\u003d{{ openstack_region_name }}"},{"line_number":9,"context_line":"        url\u003d\u0027{{ item.url }}\u0027"},{"line_number":10,"context_line":"        interface\u003d\u0027{{ item.interface }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_0e41cfa9","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":52},"updated":"2016-08-09 19:20:44.000000000","message":"OpenStack Key Management","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"}],"ansible/roles/barbican/templates/barbican-api.json.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"c0499b827ddfafe7a01d7cf0574bdc1bde7e0df9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/barbican.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/barbican/barbican.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9ad45d7e_ffd98384","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":26},"updated":"2016-08-09 20:17:28.000000000","message":"maybe it is better to keep 0600 and change this to barbican. that\u0027s the way the other roles do it.","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ba9ee85e89651d19a6e79452b9fd48c76d2dd057","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/barbican.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/barbican/barbican.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9ad45d7e_ff92239e","line":8,"range":{"start_line":8,"start_character":21,"end_line":8,"end_character":25},"updated":"2016-08-09 20:16:29.000000000","message":"this should be 0640, process will run as user barbican","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"}],"ansible/roles/barbican/templates/barbican-keystone-listener.json.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ba9ee85e89651d19a6e79452b9fd48c76d2dd057","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/barbican.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/barbican/barbican.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9ad45d7e_bf726bab","line":8,"range":{"start_line":8,"start_character":21,"end_line":8,"end_character":25},"updated":"2016-08-09 20:16:29.000000000","message":"this should be 0640, process will run as user barbican","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"}],"ansible/roles/barbican/templates/barbican-worker.json.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"ba9ee85e89651d19a6e79452b9fd48c76d2dd057","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/barbican.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/barbican/barbican.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9ad45d7e_1fb1f747","line":8,"range":{"start_line":8,"start_character":21,"end_line":8,"end_character":25},"updated":"2016-08-09 20:16:29.000000000","message":"this should be 0640, process will run as user barbican","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"}],"ansible/roles/barbican/templates/barbican.conf.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9333ac418136aa088c22238eef3cb813f076c9dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"max_allowed_secret_in_bytes \u003d 10000"},{"line_number":11,"context_line":"max_allowed_request_size_in_bytes \u003d 1000000"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"sql_connection \u003d mysql://{{ barbican_database_user }}:{{ barbican_database_password }}@{{ barbican_database_address }}/{{ barbican_database_name }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[keystone_notifications]"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9ad45d7e_e5f456f3","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":22},"updated":"2016-08-09 21:10:37.000000000","message":"This should be mysql+pymysql","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"13037b5e54dd726f33ac6df42fd47a01a3eec631","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[keystone_notifications]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Keystone notification functionality uses transport related configuration"},{"line_number":18,"context_line":"# from barbican common configuration as defined under"},{"line_number":19,"context_line":"# \u0027Queue Options - oslo.messaging\u0027 comments."},{"line_number":20,"context_line":"# The HA related configuration is also shared with notification server."}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9ad45d7e_cea05746","line":17,"updated":"2016-08-09 19:20:44.000000000","message":"We do not have comments in the other configuration files. I think they should be removed.","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"13037b5e54dd726f33ac6df42fd47a01a3eec631","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[keystone_authtoken]"},{"line_number":50,"context_line":"memcached_servers \u003d {{ kolla_internal_fqdn }}:{{ memcached_port }}"},{"line_number":51,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":52,"context_line":"project_domain_id \u003d default"},{"line_number":53,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9ad45d7e_ceb7b784","line":50,"updated":"2016-08-09 19:20:44.000000000","message":"This is not correct, please check the other configuration templates.","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3a993ad4b5016149573ba745974495c122980525","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[keystone_notifications]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Keystone notification functionality uses transport related configuration"},{"line_number":18,"context_line":"# from barbican common configuration as defined under"},{"line_number":19,"context_line":"# \u0027Queue Options - oslo.messaging\u0027 comments."},{"line_number":20,"context_line":"# The HA related configuration is also shared with notification server."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# True enables keystone notification listener functionality."},{"line_number":23,"context_line":"enable \u003d True"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The default exchange under which topics are scoped."}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ad45d7e_46327911","line":22,"range":{"start_line":17,"start_character":0,"end_line":22,"end_character":60},"updated":"2016-08-10 07:29:21.000000000","message":"Please, remove comments at templates","commit_id":"a02885351ec024a132e80f8c48d6f38fcdff1bb9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3a993ad4b5016149573ba745974495c122980525","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[keystone_authtoken]"},{"line_number":50,"context_line":"memcached_servers \u003d {{ kolla_internal_fqdn }}:{{ memcached_port }}"},{"line_number":51,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":52,"context_line":"project_domain_id \u003d default"},{"line_number":53,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ad45d7e_8613d165","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":66},"updated":"2016-08-10 07:29:21.000000000","message":"Use correct syntax for memcached, it need to be a list of nodes. \nSee as an example: \nhttps://github.com/openstack/kolla/blob/master/ansible/roles/ironic/templates/ironic.conf.j2","commit_id":"a02885351ec024a132e80f8c48d6f38fcdff1bb9"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"2d17b0268ad791313f43d56abe07dd4c347895ab","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[keystone_notifications]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Keystone notification functionality uses transport related configuration"},{"line_number":18,"context_line":"# from barbican common configuration as defined under"},{"line_number":19,"context_line":"# \u0027Queue Options - oslo.messaging\u0027 comments."},{"line_number":20,"context_line":"# The HA related configuration is also shared with notification server."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# True enables keystone notification listener functionality."},{"line_number":23,"context_line":"enable \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_08b0d58a","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":71},"updated":"2016-08-25 02:59:58.000000000","message":"Per Eduardo\u0027s comment in previous patch set, comments in templates should be removed.","commit_id":"97e144843061f8fbef5bdfa551854677eedbc54a"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f73c1dc670e842b0e3da4e53c41362fa7de27eec","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[keystone_notifications]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Keystone notification functionality uses transport related configuration"},{"line_number":18,"context_line":"# from barbican common configuration as defined under"},{"line_number":19,"context_line":"# \u0027Queue Options - oslo.messaging\u0027 comments."},{"line_number":20,"context_line":"# The HA related configuration is also shared with notification server."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# True enables keystone notification listener functionality."},{"line_number":23,"context_line":"enable \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_ac56ec03","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":71},"in_reply_to":"1ac06dbe_08b0d58a","updated":"2016-08-25 06:29:09.000000000","message":"Done","commit_id":"97e144843061f8fbef5bdfa551854677eedbc54a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"54b9b66a3032fba1b07e05e4cc3597fabba0a00a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"sql_connection \u003d mysql://{{ barbican_database_user }}:{{ barbican_database_password }}@{{ barbican_database_address }}/{{ barbican_database_name }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[keystone_notifications]"},{"line_number":16,"context_line":"# True enables keystone notification listener functionality."},{"line_number":17,"context_line":"enable \u003d True"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"control_exchange \u003d \u0027openstack\u0027"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"fa7ab95a_3baa9785","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":60},"updated":"2016-08-30 15:53:20.000000000","message":"Remove comments.","commit_id":"fd07716b32e88566702977e00428c9ae6a150a0f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"b3b053fe415b1720d667b289af965004c8580f4a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"sql_connection \u003d mysql://{{ barbican_database_user }}:{{ barbican_database_password }}@{{ barbican_database_address }}/{{ barbican_database_name }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[keystone_notifications]"},{"line_number":16,"context_line":"# True enables keystone notification listener functionality."},{"line_number":17,"context_line":"enable \u003d True"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"control_exchange \u003d \u0027openstack\u0027"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"fa7ab95a_d69ec4b7","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":60},"in_reply_to":"fa7ab95a_3baa9785","updated":"2016-08-31 01:12:17.000000000","message":"Done","commit_id":"fd07716b32e88566702977e00428c9ae6a150a0f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"54b9b66a3032fba1b07e05e4cc3597fabba0a00a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"topic \u003d \u0027notifications\u0027"},{"line_number":21,"context_line":"allow_requeue \u003d False"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Version of tasks invoked via notifications"},{"line_number":24,"context_line":"version \u003d \u00271.0\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"thread_pool_size \u003d 10"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"fa7ab95a_bb9ea760","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":44},"updated":"2016-08-30 15:53:20.000000000","message":"Ditto","commit_id":"fd07716b32e88566702977e00428c9ae6a150a0f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"b3b053fe415b1720d667b289af965004c8580f4a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"topic \u003d \u0027notifications\u0027"},{"line_number":21,"context_line":"allow_requeue \u003d False"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Version of tasks invoked via notifications"},{"line_number":24,"context_line":"version \u003d \u00271.0\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"thread_pool_size \u003d 10"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"fa7ab95a_f6a3c8fe","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":44},"in_reply_to":"fa7ab95a_bb9ea760","updated":"2016-08-31 01:12:17.000000000","message":"Done","commit_id":"fd07716b32e88566702977e00428c9ae6a150a0f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"54b9b66a3032fba1b07e05e4cc3597fabba0a00a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[keystone_authtoken]"},{"line_number":30,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":31,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":32,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027]"},{"line_number":33,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":34,"context_line":"project_domain_id \u003d default"},{"line_number":35,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"fa7ab95a_3b25375b","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":138},"updated":"2016-08-30 15:53:20.000000000","message":"Please, move line 30, 31 and 32 after line 40 to maintain consistency between all templates","commit_id":"fd07716b32e88566702977e00428c9ae6a150a0f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"b3b053fe415b1720d667b289af965004c8580f4a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[keystone_authtoken]"},{"line_number":30,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":31,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":32,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027]"},{"line_number":33,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":34,"context_line":"project_domain_id \u003d default"},{"line_number":35,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"fa7ab95a_16a90ce0","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":138},"in_reply_to":"fa7ab95a_3b25375b","updated":"2016-08-31 01:12:17.000000000","message":"Done","commit_id":"fd07716b32e88566702977e00428c9ae6a150a0f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"efd7cacf3e30a60e589793f863873aa98a7dd360","unresolved":false,"context_lines":[{"line_number":51,"context_line":"password \u003d {{ barbican_keystone_password }}"},{"line_number":52,"context_line":"username \u003d {{ barbican_keystone_user }}"},{"line_number":53,"context_line":"project_name \u003d service"},{"line_number":54,"context_line":"project_domain_id \u003d default"},{"line_number":55,"context_line":"user_domain_id \u003d default"},{"line_number":56,"context_line":"auth_type \u003d password"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"fa7ab95a_643b629d","line":54,"updated":"2016-08-31 12:03:43.000000000","message":"I noticed these are throughout our playbooks.  Followup work would be to parametrize them.","commit_id":"be3cbb776e94ceb1f134d25ac8ce122ad1f7ce4d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"0fad99197bf87c78e3be33cdf84b765e22e87c71","unresolved":false,"context_lines":[{"line_number":39,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027i"},{"line_number":40,"context_line":"pv4\u0027][\u0027address\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[oslo_messaging_rabbit]"},{"line_number":43,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":44,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":45,"context_line":"rabbit_ha_queues \u003d true"},{"line_number":46,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[service_credentials]"},{"line_number":49,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"9a89bdaa_92f814c5","line":46,"range":{"start_line":42,"start_character":0,"end_line":46,"end_character":202},"updated":"2016-09-07 17:02:53.000000000","message":"Please, use new transport_url option instead of oslo_messaging_rabbit.\nExample: https://github.com/openstack/kolla/blob/master/ansible/roles/heat/templates/heat.conf.j2","commit_id":"11a1bd510d370cf251b9dc6306902f10707d1d00"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c3ddff7dd642fbe2da9c2ed8c7434db23d9df81c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027i"},{"line_number":40,"context_line":"pv4\u0027][\u0027address\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[oslo_messaging_rabbit]"},{"line_number":43,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":44,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":45,"context_line":"rabbit_ha_queues \u003d true"},{"line_number":46,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[service_credentials]"},{"line_number":49,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"9a89bdaa_c6b4a136","line":46,"range":{"start_line":42,"start_character":0,"end_line":46,"end_character":202},"in_reply_to":"9a89bdaa_92f814c5","updated":"2016-09-07 17:19:59.000000000","message":"ok. no probleme, i fixed it","commit_id":"11a1bd510d370cf251b9dc6306902f10707d1d00"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"559cfa7d075f506c9603e656239884dfadec30d2","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[keystone_authtoken]"},{"line_number":30,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":31,"context_line":"project_domain_id \u003d default"},{"line_number":32,"context_line":"project_name \u003d service"},{"line_number":33,"context_line":"user_domain_id \u003d default"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_2ab42733","line":30,"range":{"start_line":30,"start_character":89,"end_line":30,"end_character":92},"updated":"2016-09-07 20:58:22.000000000","message":"Kolla uses v3 by default, is mandatory to specify v3 in the url?","commit_id":"36b535c5659dc170032bf5939bce3065c936a3ab"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"feb629f86e3bf2f00b9ac23e4617a816fe6308a5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[keystone_authtoken]"},{"line_number":30,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":31,"context_line":"project_domain_id \u003d default"},{"line_number":32,"context_line":"project_name \u003d service"},{"line_number":33,"context_line":"user_domain_id \u003d default"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_9088fd72","line":30,"range":{"start_line":30,"start_character":89,"end_line":30,"end_character":92},"in_reply_to":"9a89bdaa_2ab42733","updated":"2016-09-08 03:51:54.000000000","message":"Done","commit_id":"36b535c5659dc170032bf5939bce3065c936a3ab"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"559cfa7d075f506c9603e656239884dfadec30d2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":40,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":41,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027i"},{"line_number":42,"context_line":"pv4\u0027][\u0027address\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[service_credentials]"},{"line_number":45,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_4a508b0b","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":16},"updated":"2016-09-07 20:58:22.000000000","message":"unexpected line change","commit_id":"36b535c5659dc170032bf5939bce3065c936a3ab"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"feb629f86e3bf2f00b9ac23e4617a816fe6308a5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":40,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":41,"context_line":"memcache_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027i"},{"line_number":42,"context_line":"pv4\u0027][\u0027address\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[service_credentials]"},{"line_number":45,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_50b4b533","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":16},"in_reply_to":"9a89bdaa_4a508b0b","updated":"2016-09-08 03:51:54.000000000","message":"Done","commit_id":"36b535c5659dc170032bf5939bce3065c936a3ab"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"559cfa7d075f506c9603e656239884dfadec30d2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"pv4\u0027][\u0027address\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[service_credentials]"},{"line_number":45,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":46,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":47,"context_line":"password \u003d {{ barbican_keystone_password }}"},{"line_number":48,"context_line":"username \u003d {{ barbican_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_2ab98715","line":45,"range":{"start_line":45,"start_character":90,"end_line":45,"end_character":93},"updated":"2016-09-07 20:58:22.000000000","message":"The same as auth_uri in keystone-authtoken section. \nSome services need v3 in the url because have issues in auth, can you ensure if without version still working?","commit_id":"36b535c5659dc170032bf5939bce3065c936a3ab"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"feb629f86e3bf2f00b9ac23e4617a816fe6308a5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"pv4\u0027][\u0027address\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[service_credentials]"},{"line_number":45,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":46,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":47,"context_line":"password \u003d {{ barbican_keystone_password }}"},{"line_number":48,"context_line":"username \u003d {{ barbican_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a89bdaa_30b9f12e","line":45,"range":{"start_line":45,"start_character":90,"end_line":45,"end_character":93},"in_reply_to":"9a89bdaa_2ab98715","updated":"2016-09-08 03:51:54.000000000","message":"Done","commit_id":"36b535c5659dc170032bf5939bce3065c936a3ab"}],"ansible/roles/prechecks/tasks/port_checks.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"22ce0984e11c8d4337c69b5394fbef805cc8dbe6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Checking free port for barbican API"},{"line_number":3,"context_line":"  wait_for:"},{"line_number":4,"context_line":"    host: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""},{"line_number":5,"context_line":"    port: \"{{ barbican_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9a89bdaa_3eef451f","line":2,"range":{"start_line":2,"start_character":31,"end_line":2,"end_character":39},"updated":"2016-09-12 15:41:54.000000000","message":"Nit: capitalize Barbican","commit_id":"2e36422b631c8c3df0040b0c73bfae17e4e965a1"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"22ce0984e11c8d4337c69b5394fbef805cc8dbe6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    state: stopped"},{"line_number":8,"context_line":"  when: inventory_hostname in groups[\u0027barbican-api\u0027]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Checking free port for barbican API HAProxy"},{"line_number":11,"context_line":"  wait_for:"},{"line_number":12,"context_line":"    host: \"{{ kolla_internal_vip_address }}\""},{"line_number":13,"context_line":"    port: \"{{ barbican_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9a89bdaa_5ef089fd","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":39},"updated":"2016-09-12 15:41:54.000000000","message":"Ditto","commit_id":"2e36422b631c8c3df0040b0c73bfae17e4e965a1"}],"ansible/site.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"13037b5e54dd726f33ac6df42fd47a01a3eec631","unresolved":false,"context_lines":[{"line_number":246,"context_line":"  roles:"},{"line_number":247,"context_line":"    - { role: barbican,"},{"line_number":248,"context_line":"        tags: barbican,"},{"line_number":249,"context_line":"        when: enable_barbican | bool } "},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"- hosts:"},{"line_number":252,"context_line":"    - tempest"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_ce6e9700","line":249,"range":{"start_line":249,"start_character":38,"end_line":249,"end_character":39},"updated":"2016-08-09 19:20:44.000000000","message":"trailing whitespace","commit_id":"00d532ae3aa1adb1573dde192869508e9b8790d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"3a993ad4b5016149573ba745974495c122980525","unresolved":false,"context_lines":[{"line_number":246,"context_line":"  roles:"},{"line_number":247,"context_line":"    - { role: barbican,"},{"line_number":248,"context_line":"        tags: barbican,"},{"line_number":249,"context_line":"        when: enable_barbican | bool } "},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"- hosts:"},{"line_number":252,"context_line":"    - tempest"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_2903d60e","line":249,"range":{"start_line":249,"start_character":38,"end_line":249,"end_character":39},"updated":"2016-08-10 07:29:21.000000000","message":"Please, remove whitespace","commit_id":"a02885351ec024a132e80f8c48d6f38fcdff1bb9"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"2d17b0268ad791313f43d56abe07dd4c347895ab","unresolved":false,"context_lines":[{"line_number":246,"context_line":"  roles:"},{"line_number":247,"context_line":"    - { role: barbican,"},{"line_number":248,"context_line":"        tags: barbican,"},{"line_number":249,"context_line":"        when: enable_barbican | bool } "},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"- hosts:"},{"line_number":252,"context_line":"    - tempest"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_8d2a17e6","line":249,"range":{"start_line":249,"start_character":38,"end_line":249,"end_character":39},"updated":"2016-08-25 02:59:58.000000000","message":"nit: extra space","commit_id":"97e144843061f8fbef5bdfa551854677eedbc54a"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"e814a6eaee62dd28154290641966e5dcaa120209","unresolved":false,"context_lines":[{"line_number":246,"context_line":"  roles:"},{"line_number":247,"context_line":"    - { role: barbican,"},{"line_number":248,"context_line":"        tags: barbican,"},{"line_number":249,"context_line":"        when: enable_barbican | bool } "},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"- hosts:"},{"line_number":252,"context_line":"    - tempest"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_0a56df5b","line":249,"range":{"start_line":249,"start_character":38,"end_line":249,"end_character":39},"in_reply_to":"1ac06dbe_0c48e05a","updated":"2016-08-28 05:18:44.000000000","message":"Done","commit_id":"97e144843061f8fbef5bdfa551854677eedbc54a"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"f73c1dc670e842b0e3da4e53c41362fa7de27eec","unresolved":false,"context_lines":[{"line_number":246,"context_line":"  roles:"},{"line_number":247,"context_line":"    - { role: barbican,"},{"line_number":248,"context_line":"        tags: barbican,"},{"line_number":249,"context_line":"        when: enable_barbican | bool } "},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"- hosts:"},{"line_number":252,"context_line":"    - tempest"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_0c48e05a","line":249,"range":{"start_line":249,"start_character":38,"end_line":249,"end_character":39},"in_reply_to":"1ac06dbe_8d2a17e6","updated":"2016-08-25 06:29:09.000000000","message":"Done","commit_id":"97e144843061f8fbef5bdfa551854677eedbc54a"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"e814a6eaee62dd28154290641966e5dcaa120209","unresolved":false,"context_lines":[{"line_number":246,"context_line":"  roles:"},{"line_number":247,"context_line":"    - { role: barbican,"},{"line_number":248,"context_line":"        tags: barbican,"},{"line_number":249,"context_line":"        when: enable_barbican | bool } "},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"- hosts:"},{"line_number":252,"context_line":"    - tempest"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_2a51e362","line":249,"range":{"start_line":249,"start_character":38,"end_line":249,"end_character":39},"in_reply_to":"1ac06dbe_8d2a17e6","updated":"2016-08-28 05:18:44.000000000","message":"good, i fixed it now","commit_id":"97e144843061f8fbef5bdfa551854677eedbc54a"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"37cf8f69b6b1c2c8ca14c4d74d9556f80837c6c4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"- hosts:"},{"line_number":243,"context_line":"    - barbican-api"},{"line_number":244,"context_line":"    - barbican-keystone-listener"},{"line_number":245,"context_line":"    - barbican-worker"},{"line_number":246,"context_line":"  roles:"},{"line_number":247,"context_line":"    - { role: barbican,"},{"line_number":248,"context_line":"        tags: barbican,"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_5b1c06c1","line":245,"updated":"2016-08-29 16:45:16.000000000","message":"Add rabbitmq and memcached nodes","commit_id":"ecb0b8a43ca6adb51c89e2dc1e6c5a8c8c4c3052"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"37cf8f69b6b1c2c8ca14c4d74d9556f80837c6c4","unresolved":false,"context_lines":[{"line_number":246,"context_line":"  roles:"},{"line_number":247,"context_line":"    - { role: barbican,"},{"line_number":248,"context_line":"        tags: barbican,"},{"line_number":249,"context_line":"        when: enable_barbican | bool } "},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"- hosts:"},{"line_number":252,"context_line":"    - tempest"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_3b4822cc","line":249,"range":{"start_line":249,"start_character":38,"end_line":249,"end_character":39},"updated":"2016-08-29 16:45:16.000000000","message":"nit: remove whitespace","commit_id":"ecb0b8a43ca6adb51c89e2dc1e6c5a8c8c4c3052"}],"releasenotes/notes/add-barbican-8f0636668001de73.yaml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"37cf8f69b6b1c2c8ca14c4d74d9556f80837c6c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Implement Barbican ansible role"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_5b732615","line":4,"updated":"2016-08-29 16:45:16.000000000","message":"Nit: Remove empty line","commit_id":"ecb0b8a43ca6adb51c89e2dc1e6c5a8c8c4c3052"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"7b382fb49a0b49e5e08251c80a4292bbdfc62445","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Implement Barbican ansible role"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_909e4405","line":4,"in_reply_to":"fa7ab95a_5b732615","updated":"2016-08-30 07:31:19.000000000","message":"Done","commit_id":"ecb0b8a43ca6adb51c89e2dc1e6c5a8c8c4c3052"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"efd7cacf3e30a60e589793f863873aa98a7dd360","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Implement Barbican ansible role"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fa7ab95a_24523ade","line":3,"updated":"2016-08-31 12:03:43.000000000","message":"more complete release note would be helpful.","commit_id":"be3cbb776e94ceb1f134d25ac8ce122ad1f7ce4d"}]}