)]}'
{"docker/glance/glance-base/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"fc71539fb6f7d1ab6845c4032d46fd408a1b06f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        python-rbd \\"},{"line_number":10,"context_line":"        python-rados \\"},{"line_number":11,"context_line":"    \u0026\u0026 yum clean all \\"},{"line_number":12,"context_line":"    \u0026\u0026 mkdir -p /etc/ceph/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_76f30c9f","side":"PARENT","line":12,"updated":"2016-08-09 15:59:00.000000000","message":"this is missing for from binary installed - recommend adding between lines 16 and 17 on right side of review","commit_id":"8f90e62b48e701164c8193929c6a8eb15aec2f19"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"690eca1e9cf24e2783d2bbeaa27f3b0479ab44eb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        python-rbd \\"},{"line_number":10,"context_line":"        python-rados \\"},{"line_number":11,"context_line":"    \u0026\u0026 yum clean all \\"},{"line_number":12,"context_line":"    \u0026\u0026 mkdir -p /etc/ceph/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_2b90e642","side":"PARENT","line":12,"in_reply_to":"9ad45d7e_26578acf","updated":"2016-08-10 09:31:07.000000000","message":"@Hui Kang no- mkdir is executed in all possible branches,\nsee lines 12, 21, 31, 39","commit_id":"8f90e62b48e701164c8193929c6a8eb15aec2f19"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"037692bebee95a6331b93dae8b225277a5164a57","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        python-rbd \\"},{"line_number":10,"context_line":"        python-rados \\"},{"line_number":11,"context_line":"    \u0026\u0026 yum clean all \\"},{"line_number":12,"context_line":"    \u0026\u0026 mkdir -p /etc/ceph/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_ca2e8cf9","side":"PARENT","line":12,"in_reply_to":"9ad45d7e_76f30c9f","updated":"2016-08-09 16:12:17.000000000","message":"I moved this step to line 28. Is it wrong?","commit_id":"8f90e62b48e701164c8193929c6a8eb15aec2f19"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"ed71b009db991859fe4bf70f16f6fd36e8b3c56e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        python-rbd \\"},{"line_number":10,"context_line":"        python-rados \\"},{"line_number":11,"context_line":"    \u0026\u0026 yum clean all \\"},{"line_number":12,"context_line":"    \u0026\u0026 mkdir -p /etc/ceph/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_26578acf","side":"PARENT","line":12,"in_reply_to":"9ad45d7e_ca2e8cf9","updated":"2016-08-10 04:19:20.000000000","message":"The mkdir command was executed with binary centos build. After moving to line 28, this commend is executed for all build type.","commit_id":"8f90e62b48e701164c8193929c6a8eb15aec2f19"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"fc71539fb6f7d1ab6845c4032d46fd408a1b06f6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    ] %}"},{"line_number":23,"context_line":"{% endif %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"ADD glance-base-archive /glance-base-source"},{"line_number":28,"context_line":"RUN mkdir -p /etc/ceph/ \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_b69584e5","line":25,"updated":"2016-08-09 15:59:00.000000000","message":"This needs to be duplicated to between line 17 and 18 so the from binary packaging results in installed glance and ceph packages.","commit_id":"0345dc9b6dd649ef8c039295230800e05f936d77"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"037692bebee95a6331b93dae8b225277a5164a57","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    ] %}"},{"line_number":23,"context_line":"{% endif %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"ADD glance-base-archive /glance-base-source"},{"line_number":28,"context_line":"RUN mkdir -p /etc/ceph/ \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_8ad774ec","line":25,"in_reply_to":"9ad45d7e_b69584e5","updated":"2016-08-09 16:12:17.000000000","message":"I don\u0027t see why. I collect a list of packages in if clause\nand then execute run macro just once. This run should be unconditional","commit_id":"0345dc9b6dd649ef8c039295230800e05f936d77"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"fc71539fb6f7d1ab6845c4032d46fd408a1b06f6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":41,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_glance_sudoers \\"},{"line_number":42,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_glance_extend_start \\"},{"line_number":43,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_glance_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_96bfa05f","line":43,"updated":"2016-08-09 15:59:00.000000000","message":"missing the footers","commit_id":"0345dc9b6dd649ef8c039295230800e05f936d77"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"037692bebee95a6331b93dae8b225277a5164a57","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0026\u0026 chmod 750 /etc/sudoers.d \\"},{"line_number":41,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/kolla_glance_sudoers \\"},{"line_number":42,"context_line":"    \u0026\u0026 touch /usr/local/bin/kolla_glance_extend_start \\"},{"line_number":43,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_glance_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_6a6960be","line":43,"in_reply_to":"9ad45d7e_96bfa05f","updated":"2016-08-09 16:12:17.000000000","message":"Done","commit_id":"0345dc9b6dd649ef8c039295230800e05f936d77"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c6882d29b5560734da9655b377ce2ba477e7328e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"        {%set glance_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_2bbd8668","line":3,"updated":"2016-08-10 09:35:36.000000000","message":"Missing {% import \"macros.j2\" as macros with context %}","commit_id":"e34b41fa95b8c93ef26915d3e0c34f1a1b995bf6"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"e22995f82f87d6413398f591c741d3505b5d4fce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"        {%set glance_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9ad45d7e_372e8843","line":3,"in_reply_to":"9ad45d7e_2bbd8668","updated":"2016-08-10 09:41:52.000000000","message":"Done","commit_id":"e34b41fa95b8c93ef26915d3e0c34f1a1b995bf6"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"44e5f91c7c888b896e0159a01c68ea02e8ba5368","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% endif %}"},{"line_number":20,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":21,"context_line":"    {%set glance_base_packages \u003d ["},{"line_number":22,"context_line":"        \u0027python-rbd\u0027,"},{"line_number":23,"context_line":"        \u0027python-rados\u0027"},{"line_number":24,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_7a24655f","line":21,"updated":"2016-08-10 09:59:41.000000000","message":"please add space after the % if you need another PS","commit_id":"cceb8baad064c2e2c02e6d332d1a3313e62b8748"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"66b3072998c79d9362d4c8a6e1e5c2fe4fcf5163","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% endif %}"},{"line_number":20,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":21,"context_line":"    {%set glance_base_packages \u003d ["},{"line_number":22,"context_line":"        \u0027python-rbd\u0027,"},{"line_number":23,"context_line":"        \u0027python-rados\u0027"},{"line_number":24,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9ad45d7e_9d24b3c5","line":21,"in_reply_to":"9ad45d7e_7a24655f","updated":"2016-08-10 10:29:51.000000000","message":"Excuse my ignorance - but what is PS?","commit_id":"cceb8baad064c2e2c02e6d332d1a3313e62b8748"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a3ef29a9afb7d87bfa38ae6df9ad3ceb314d979d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \u0027python-rbd\u0027,"},{"line_number":17,"context_line":"            \u0027python-rados\u0027"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% endif %}"},{"line_number":20,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":21,"context_line":"    {% set glance_base_packages \u003d ["},{"line_number":22,"context_line":"        \u0027python-rbd\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_7fd0a1f6","line":19,"updated":"2016-08-11 07:23:07.000000000","message":"Add RUN {{ macros...} after line 19 for binary installations.\nAlso add a RUN to create /etc/ceph folder","commit_id":"f1bcacf2bc1e793cd874bad67643036bdf1d073f"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"85a326817db540536747c44a05daa04dfcdebf51","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \u0027python-rbd\u0027,"},{"line_number":17,"context_line":"            \u0027python-rados\u0027"},{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% endif %}"},{"line_number":20,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":21,"context_line":"    {% set glance_base_packages \u003d ["},{"line_number":22,"context_line":"        \u0027python-rbd\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_7341f5a8","line":19,"in_reply_to":"9ad45d7e_7fd0a1f6","updated":"2016-08-11 10:01:39.000000000","message":"Done","commit_id":"f1bcacf2bc1e793cd874bad67643036bdf1d073f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a3ef29a9afb7d87bfa38ae6df9ad3ceb314d979d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        \u0027python-rbd\u0027,"},{"line_number":23,"context_line":"        \u0027python-rados\u0027"},{"line_number":24,"context_line":"    ] %}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_3f38e93c","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":11},"updated":"2016-08-11 07:23:07.000000000","message":"Move this endif to line 37, this is breaking gates when trying to install source at binary installations.","commit_id":"f1bcacf2bc1e793cd874bad67643036bdf1d073f"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"85a326817db540536747c44a05daa04dfcdebf51","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        \u0027python-rbd\u0027,"},{"line_number":23,"context_line":"        \u0027python-rados\u0027"},{"line_number":24,"context_line":"    ] %}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_d331c15b","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":11},"in_reply_to":"9ad45d7e_3f38e93c","updated":"2016-08-11 10:01:39.000000000","message":"Done","commit_id":"f1bcacf2bc1e793cd874bad67643036bdf1d073f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a3ef29a9afb7d87bfa38ae6df9ad3ceb314d979d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"ADD glance-base-archive /glance-base-source"},{"line_number":30,"context_line":"RUN mkdir -p /etc/ceph/ \\"},{"line_number":31,"context_line":"    \u0026\u0026 ln -s glance-base-source/* glance \\"},{"line_number":32,"context_line":"    \u0026\u0026 useradd --user-group glance \\"},{"line_number":33,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /glance \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_bfb4d934","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":23},"updated":"2016-08-11 07:23:07.000000000","message":"+1 to Kirill Shileev, IMHO customizations shouldn\u0027t handle any functionality change.\nWhen installing ceph package, they will create /etc/ceph folder, but I don\u0027t know if python-rbd or python-rados packages will create that folder.","commit_id":"f1bcacf2bc1e793cd874bad67643036bdf1d073f"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"0fdd598058e89b1006c834b9f6efbbc23b344c29","unresolved":false,"context_lines":[{"line_number":27,"context_line":"RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"ADD glance-base-archive /glance-base-source"},{"line_number":30,"context_line":"RUN mkdir -p /etc/ceph/ \\"},{"line_number":31,"context_line":"    \u0026\u0026 ln -s glance-base-source/* glance \\"},{"line_number":32,"context_line":"    \u0026\u0026 useradd --user-group glance \\"},{"line_number":33,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /glance \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_c8293439","line":30,"updated":"2016-08-10 16:52:17.000000000","message":"Why is this step necessary now?","commit_id":"f1bcacf2bc1e793cd874bad67643036bdf1d073f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"41a82df23fd485da536900a269ec1aeac84bb676","unresolved":false,"context_lines":[{"line_number":27,"context_line":"RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"ADD glance-base-archive /glance-base-source"},{"line_number":30,"context_line":"RUN mkdir -p /etc/ceph/ \\"},{"line_number":31,"context_line":"    \u0026\u0026 ln -s glance-base-source/* glance \\"},{"line_number":32,"context_line":"    \u0026\u0026 useradd --user-group glance \\"},{"line_number":33,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /glance \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_3f4116aa","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":24},"updated":"2016-08-10 23:02:03.000000000","message":"this should delete","commit_id":"f1bcacf2bc1e793cd874bad67643036bdf1d073f"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"85a326817db540536747c44a05daa04dfcdebf51","unresolved":false,"context_lines":[{"line_number":27,"context_line":"RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"ADD glance-base-archive /glance-base-source"},{"line_number":30,"context_line":"RUN mkdir -p /etc/ceph/ \\"},{"line_number":31,"context_line":"    \u0026\u0026 ln -s glance-base-source/* glance \\"},{"line_number":32,"context_line":"    \u0026\u0026 useradd --user-group glance \\"},{"line_number":33,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /glance \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_5325d106","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":24},"in_reply_to":"9ad45d7e_3f4116aa","updated":"2016-08-11 10:01:39.000000000","message":"Done","commit_id":"f1bcacf2bc1e793cd874bad67643036bdf1d073f"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"b2def99a474c06462732916b13ecbfa0e41002dd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"ADD glance-base-archive /glance-base-source"},{"line_number":30,"context_line":"RUN mkdir -p /etc/ceph/ \\"},{"line_number":31,"context_line":"    \u0026\u0026 ln -s glance-base-source/* glance \\"},{"line_number":32,"context_line":"    \u0026\u0026 useradd --user-group glance \\"},{"line_number":33,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /glance \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_c8381440","line":30,"in_reply_to":"9ad45d7e_c8293439","updated":"2016-08-10 16:57:00.000000000","message":"This patch is to do customization, it does not address any functionality of the service itself. If making sure that /etc/ceph directory is not longer needed for glance - I believe, it needs to be erased in a different patch","commit_id":"f1bcacf2bc1e793cd874bad67643036bdf1d073f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67e911d3bb47869581bc72f9c3a637eee0af875e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":24,"context_line":"    {% set glance_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9ad45d7e_454986cf","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":4},"updated":"2016-08-11 10:56:49.000000000","message":"Don\u0027t add these spaces","commit_id":"1acff2763cef76d3ee63a8a7a9e994df25daccf8"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"7d3902ce6af7ac55c0a4e951454eafde2e0b6505","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        ] %}"},{"line_number":19,"context_line":"    {% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":24,"context_line":"    {% set glance_base_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9ad45d7e_08e1632d","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":4},"in_reply_to":"9ad45d7e_454986cf","updated":"2016-08-11 11:05:25.000000000","message":"Done","commit_id":"1acff2763cef76d3ee63a8a7a9e994df25daccf8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67e911d3bb47869581bc72f9c3a637eee0af875e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \u0027python-rados\u0027"},{"line_number":27,"context_line":"    ] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    ADD glance-base-archive /glance-base-source"},{"line_number":32,"context_line":"    RUN ln -s glance-base-source/* glance \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9ad45d7e_a50e8289","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":4},"updated":"2016-08-11 10:56:49.000000000","message":"Ditto","commit_id":"1acff2763cef76d3ee63a8a7a9e994df25daccf8"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"7d3902ce6af7ac55c0a4e951454eafde2e0b6505","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \u0027python-rados\u0027"},{"line_number":27,"context_line":"    ] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    ADD glance-base-archive /glance-base-source"},{"line_number":32,"context_line":"    RUN ln -s glance-base-source/* glance \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9ad45d7e_e8db2f7a","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":4},"in_reply_to":"9ad45d7e_a50e8289","updated":"2016-08-11 11:05:25.000000000","message":"Done","commit_id":"1acff2763cef76d3ee63a8a7a9e994df25daccf8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67e911d3bb47869581bc72f9c3a637eee0af875e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    ADD glance-base-archive /glance-base-source"},{"line_number":32,"context_line":"    RUN ln -s glance-base-source/* glance \\"},{"line_number":33,"context_line":"        \u0026\u0026 useradd --user-group glance \\"},{"line_number":34,"context_line":"        \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /glance \\"},{"line_number":35,"context_line":"        \u0026\u0026 mkdir -p /etc/glance /var/lib/glance /home/glance \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9ad45d7e_452066f7","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":4},"updated":"2016-08-11 10:56:49.000000000","message":"Ditto, also for the remain RUN lines","commit_id":"1acff2763cef76d3ee63a8a7a9e994df25daccf8"},{"author":{"_account_id":12632,"name":"Kirill Shileev","email":"kshileev@cisco.com","username":"kshileev"},"change_message_id":"7d3902ce6af7ac55c0a4e951454eafde2e0b6505","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    RUN {{ macros.install_packages(glance_base_packages | customizable(\"packages\")) }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    ADD glance-base-archive /glance-base-source"},{"line_number":32,"context_line":"    RUN ln -s glance-base-source/* glance \\"},{"line_number":33,"context_line":"        \u0026\u0026 useradd --user-group glance \\"},{"line_number":34,"context_line":"        \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /glance \\"},{"line_number":35,"context_line":"        \u0026\u0026 mkdir -p /etc/glance /var/lib/glance /home/glance \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9ad45d7e_28e2672f","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":4},"in_reply_to":"9ad45d7e_452066f7","updated":"2016-08-11 11:05:25.000000000","message":"Done","commit_id":"1acff2763cef76d3ee63a8a7a9e994df25daccf8"}]}