)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"655a250c946e2e67b23db55c89169e24d4727126","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"watcher_api_port: \"9322\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"designate_api_port: \"9001\""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"public_protocol: \"{{ \u0027https\u0027 if kolla_enable_tls_external | bool else \u0027http\u0027 }}\""},{"line_number":179,"context_line":"internal_protocol: \"http\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_96407b37","line":176,"range":{"start_line":176,"start_character":0,"end_line":176,"end_character":26},"updated":"2016-08-12 16:03:15.000000000","message":"Please arrange in alphabetical order","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"4ed0f19a52b2edee10e2200a3d7977c3a9349017","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"watcher_api_port: \"9322\""},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"designate_api_port: \"9001\""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"public_protocol: \"{{ \u0027https\u0027 if kolla_enable_tls_external | bool else \u0027http\u0027 }}\""},{"line_number":179,"context_line":"internal_protocol: \"http\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7ac969e8_0c3e5bb8","line":176,"range":{"start_line":176,"start_character":0,"end_line":176,"end_character":26},"in_reply_to":"9ad45d7e_96407b37","updated":"2016-08-12 21:48:34.000000000","message":"The port list was in no way alphabetical order previously. Should he really have to do this?","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c80d5b3f2d571a8c3472b7c4e398ce91ac02b4d6","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"# DNS Server deployment via kolla not yet supported."},{"line_number":288,"context_line":"# designate-backend-bind9 group intentionally empty."},{"line_number":289,"context_line":"[designate-backend-bind9:children]               "}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9ad45d7e_8942c20e","line":289,"range":{"start_line":289,"start_character":34,"end_line":289,"end_character":49},"updated":"2016-08-10 07:38:43.000000000","message":"delete it","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"}],"ansible/roles/designate/defaults/main.yml":[{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"855f8e6436cbfa238910e1c67e17ee378fc62bae","unresolved":false,"context_lines":[{"line_number":11,"context_line":"designate_pool_manager_database_name: \"designate_pool_manager\""},{"line_number":12,"context_line":"designate_pool_manager_database_user: \"designate_pool_manager\""},{"line_number":13,"context_line":"designate_pool_manager_database_address: \"{{ kolla_internal_fqdn }}:{{ database_port }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"####################"},{"line_number":16,"context_line":"# Docker"},{"line_number":17,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_9c53f5e1","line":14,"updated":"2016-08-10 21:21:27.000000000","message":"I think its common practice to have two blank lines here.","commit_id":"db224a4d7f1fdd055039e1f9dc132586c823e6d8"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"855f8e6436cbfa238910e1c67e17ee378fc62bae","unresolved":false,"context_lines":[{"line_number":39,"context_line":"designate_sink_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-designate-sink\""},{"line_number":40,"context_line":"designate_sink_tag: \"{{ openstack_release }}\""},{"line_number":41,"context_line":"designate_sink_image_full: \"{{ designate_sink_image }}:{{ designate_sink_tag }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"####################"},{"line_number":44,"context_line":"# OpenStack"},{"line_number":45,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ad45d7e_7c50c1d4","line":42,"updated":"2016-08-10 21:21:27.000000000","message":"And here","commit_id":"db224a4d7f1fdd055039e1f9dc132586c823e6d8"}],"ansible/roles/designate/tasks/bootstrap.yml":[{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c80d5b3f2d571a8c3472b7c4e398ce91ac02b4d6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"                    (database.stdout.split(\u0027localhost | SUCCESS \u003d\u003e \u0027)[1]|from_json).changed }}\""},{"line_number":13,"context_line":"  failed_when: database.stdout.split()[2] !\u003d \u0027SUCCESS\u0027"},{"line_number":14,"context_line":"  run_once: True"},{"line_number":15,"context_line":"  delegate_to: \"{{ groups[\u0027designate-central\u0027][0] }}\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Reading json from variable"},{"line_number":18,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_09a1b2a3","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":44},"updated":"2016-08-10 07:38:43.000000000","message":"Here should be replaced by api","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"},{"author":{"_account_id":17372,"name":"Ross Krumbeck","email":"ross.krumbeck@gmail.com","username":"bsk1n"},"change_message_id":"27af47997843e1c80258257d562d5d96262972ad","unresolved":false,"context_lines":[{"line_number":12,"context_line":"                    (database.stdout.split(\u0027localhost | SUCCESS \u003d\u003e \u0027)[1]|from_json).changed }}\""},{"line_number":13,"context_line":"  failed_when: database.stdout.split()[2] !\u003d \u0027SUCCESS\u0027"},{"line_number":14,"context_line":"  run_once: True"},{"line_number":15,"context_line":"  delegate_to: \"{{ groups[\u0027designate-central\u0027][0] }}\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Reading json from variable"},{"line_number":18,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_bd0ed738","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":44},"in_reply_to":"9ad45d7e_09a1b2a3","updated":"2016-08-10 10:43:31.000000000","message":"designate-manage is packaged with designate-central:\n\n1:openstack-designate-central-2.0.0-1.el7.noarch : OpenStack Designate Central service\nRepo        : centos-openstack-mitaka\nMatched from:\nFilename    : /usr/bin/designate-manage","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"}],"ansible/roles/designate/tasks/bootstrap_service.yml":[{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"c80d5b3f2d571a8c3472b7c4e398ce91ac02b4d6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    environment:"},{"line_number":8,"context_line":"      KOLLA_BOOTSTRAP:"},{"line_number":9,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":10,"context_line":"    image: \"{{ designate_central_image_full }}\""},{"line_number":11,"context_line":"    labels:"},{"line_number":12,"context_line":"      BOOTSTRAP:"},{"line_number":13,"context_line":"    name: \"bootstrap_designate\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_a9ca266c","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":43},"updated":"2016-08-10 07:38:43.000000000","message":"it shoud designat_api_image_full","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"},{"author":{"_account_id":17372,"name":"Ross Krumbeck","email":"ross.krumbeck@gmail.com","username":"bsk1n"},"change_message_id":"27af47997843e1c80258257d562d5d96262972ad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    environment:"},{"line_number":8,"context_line":"      KOLLA_BOOTSTRAP:"},{"line_number":9,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":10,"context_line":"    image: \"{{ designate_central_image_full }}\""},{"line_number":11,"context_line":"    labels:"},{"line_number":12,"context_line":"      BOOTSTRAP:"},{"line_number":13,"context_line":"    name: \"bootstrap_designate\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_bd27f7c8","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":43},"in_reply_to":"9ad45d7e_a9ca266c","updated":"2016-08-10 10:43:31.000000000","message":"designate-manage is packaged with designate-central:\n\n1:openstack-designate-central-2.0.0-1.el7.noarch : OpenStack Designate Central service\nRepo        : centos-openstack-mitaka\nMatched from:\nFilename    : /usr/bin/designate-manage","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"}],"ansible/roles/designate/tasks/deploy.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"209f5b4e14aec542e4745e46aa166f44b7e5c5fd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        inventory_hostname in groups[\u0027designate-backend-bind9\u0027]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- include: bootstrap.yml"},{"line_number":14,"context_line":"  when: inventory_hostname in groups[\u0027designate-api\u0027]"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: start.yml"},{"line_number":17,"context_line":"  when: inventory_hostname in groups[\u0027designate-api\u0027] or"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_fcab3a1b","line":14,"range":{"start_line":14,"start_character":38,"end_line":14,"end_character":51},"updated":"2016-08-10 08:23:12.000000000","message":"If bootstraping is done at designate-central, set it here too.","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"}],"ansible/roles/designate/tasks/do_reconfigure.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"209f5b4e14aec542e4745e46aa166f44b7e5c5fd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  failed_when: false"},{"line_number":25,"context_line":"  register: check_results"},{"line_number":26,"context_line":"  when: inventory_hostname in groups[item.group]"},{"line_number":27,"context_line":"  with_items:  "},{"line_number":28,"context_line":"    - { name: designate_central, group: designate-central }"},{"line_number":29,"context_line":"    - { name: designate_api, group: designate-api }"},{"line_number":30,"context_line":"    - { name: designate_mdns, group: designate-mdns }"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_9c731ee7","line":27,"range":{"start_line":27,"start_character":13,"end_line":27,"end_character":15},"updated":"2016-08-10 08:23:12.000000000","message":"Please, remove whitespace","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"855f8e6436cbfa238910e1c67e17ee378fc62bae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ad45d7e_67df8e69","updated":"2016-08-10 21:21:27.000000000","message":"If bind9 is not yet assigned to a host in the inventory file, should it be in the do_reconfigure?\n\nI would imagine this would fail as the container was never deployed.\n\nThis wouldn\u0027t be an issue with the start and upgrade as it won\u0027t match the when condition so it wont be deployed.","commit_id":"db224a4d7f1fdd055039e1f9dc132586c823e6d8"},{"author":{"_account_id":17372,"name":"Ross Krumbeck","email":"ross.krumbeck@gmail.com","username":"bsk1n"},"change_message_id":"96c54ab79f35da6a257487dca62e5bec973922b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ad45d7e_5004b948","in_reply_to":"9ad45d7e_67df8e69","updated":"2016-08-11 00:47:17.000000000","message":"It will not fail as long as the designate-backend-bind9 group is left blank in the inventory file.\n\nThe main reason I\u0027ve left it here is that I have already written most of the ansible code to support the lifecycle of designate-backend-bind9 other than the container\u0027s deployment and configuration.","commit_id":"db224a4d7f1fdd055039e1f9dc132586c823e6d8"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6928a10b08039bb0dee64aa84820b175c39e5217","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - { name: designate_mdns, group: designate-mdns }"},{"line_number":15,"context_line":"    - { name: designate_pool_manager, group: designate-pool-manager }"},{"line_number":16,"context_line":"    - { name: designate_sink, group: designate-sink }"},{"line_number":17,"context_line":"    - { name: designate_backend_bind9, group: designate-backend-bind9 }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- include: config.yml"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_fa32dfa5","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":71},"updated":"2016-08-11 07:43:52.000000000","message":"If bind9 is not going to be used for now, makes more sense not deploying the container","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"655a250c946e2e67b23db55c89169e24d4727126","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - { name: designate_mdns, group: designate-mdns }"},{"line_number":15,"context_line":"    - { name: designate_pool_manager, group: designate-pool-manager }"},{"line_number":16,"context_line":"    - { name: designate_sink, group: designate-sink }"},{"line_number":17,"context_line":"    - { name: designate_backend_bind9, group: designate-backend-bind9 }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- include: config.yml"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_f62f373c","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":71},"in_reply_to":"9ad45d7e_fa32dfa5","updated":"2016-08-12 16:03:15.000000000","message":"Agree","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6928a10b08039bb0dee64aa84820b175c39e5217","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - { name: designate_mdns, group: designate-mdns }"},{"line_number":31,"context_line":"    - { name: designate_pool_manager, group: designate-pool-manager }"},{"line_number":32,"context_line":"    - { name: designate_sink, group: designate-sink }"},{"line_number":33,"context_line":"    - { name: designate_backend_bind9, group: designate-backend-bind9 }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# NOTE(jeffrey4l): when config_strategy \u003d\u003d \u0027COPY_ALWAYS\u0027"},{"line_number":36,"context_line":"# and container env[\u0027KOLLA_CONFIG_STRATEGY\u0027] \u003d\u003d \u0027COPY_ONCE\u0027,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_1ad5331b","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":71},"updated":"2016-08-11 07:43:52.000000000","message":"Ditto","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"655a250c946e2e67b23db55c89169e24d4727126","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - { name: designate_mdns, group: designate-mdns }"},{"line_number":31,"context_line":"    - { name: designate_pool_manager, group: designate-pool-manager }"},{"line_number":32,"context_line":"    - { name: designate_sink, group: designate-sink }"},{"line_number":33,"context_line":"    - { name: designate_backend_bind9, group: designate-backend-bind9 }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# NOTE(jeffrey4l): when config_strategy \u003d\u003d \u0027COPY_ALWAYS\u0027"},{"line_number":36,"context_line":"# and container env[\u0027KOLLA_CONFIG_STRATEGY\u0027] \u003d\u003d \u0027COPY_ONCE\u0027,"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_961fdb08","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":71},"in_reply_to":"9ad45d7e_1ad5331b","updated":"2016-08-12 16:03:15.000000000","message":"Agree","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6928a10b08039bb0dee64aa84820b175c39e5217","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    - { name: designate_mdns, group: designate-mdns }"},{"line_number":48,"context_line":"    - { name: designate_pool_manager, group: designate-pool-manager }"},{"line_number":49,"context_line":"    - { name: designate_sink, group: designate-sink }"},{"line_number":50,"context_line":"    - { name: designate_backend_bind9, group: designate-backend-bind9 }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Remove the containers"},{"line_number":53,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_3ae0f7f9","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":71},"updated":"2016-08-11 07:43:52.000000000","message":"Ditto","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6928a10b08039bb0dee64aa84820b175c39e5217","unresolved":false,"context_lines":[{"line_number":64,"context_line":"       { name: designate_mdns, group: designate-mdns },"},{"line_number":65,"context_line":"       { name: designate_pool_manager, group: designate-pool-manager },"},{"line_number":66,"context_line":"       { name: designate_sink, group: designate-sink },"},{"line_number":67,"context_line":"       { name: designate_backend_bind9, group: designate-backend-bind9 }]"},{"line_number":68,"context_line":"    - container_envs.results"},{"line_number":69,"context_line":"    - check_results.results"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_baece7f3","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":73},"updated":"2016-08-11 07:43:52.000000000","message":"Ditto","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6928a10b08039bb0dee64aa84820b175c39e5217","unresolved":false,"context_lines":[{"line_number":86,"context_line":"       { name: designate_mdns, group: designate-mdns },"},{"line_number":87,"context_line":"       { name: designate_pool_manager, group: designate-pool-manager },"},{"line_number":88,"context_line":"       { name: designate_sink, group: designate-sink },"},{"line_number":89,"context_line":"       { name: designate_backend_bind9, group: designate-backend-bind9 }]"},{"line_number":90,"context_line":"    - container_envs.results"},{"line_number":91,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_5aa96b8f","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":73},"updated":"2016-08-11 07:43:52.000000000","message":"Ditto","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"61eb12f23278ac6f295ed56cec344d9361a7176e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"       { name: designate_mdns, group: designate-mdns },"},{"line_number":62,"context_line":"       { name: designate_pool_manager, group: designate-pool-manager },"},{"line_number":63,"context_line":"       { name: designate_sink, group: designate-sink }]"},{"line_number":64,"context_line":"    - container_envs.results"},{"line_number":65,"context_line":"    - check_results.results"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- include: start.yml"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_a4fc6e3f","line":64,"range":{"start_line":64,"start_character":6,"end_line":64,"end_character":28},"updated":"2016-08-19 15:25:40.000000000","message":"Use ansible2 syntax \"{{ container_envs.results }}\"","commit_id":"8fe75fc9adc63a9d39b85f884781311e29e93509"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"61eb12f23278ac6f295ed56cec344d9361a7176e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"       { name: designate_pool_manager, group: designate-pool-manager },"},{"line_number":63,"context_line":"       { name: designate_sink, group: designate-sink }]"},{"line_number":64,"context_line":"    - container_envs.results"},{"line_number":65,"context_line":"    - check_results.results"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- include: start.yml"},{"line_number":68,"context_line":"  when: remove_containers.changed"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_44865aba","line":65,"range":{"start_line":65,"start_character":6,"end_line":65,"end_character":27},"updated":"2016-08-19 15:25:40.000000000","message":"Ditto","commit_id":"8fe75fc9adc63a9d39b85f884781311e29e93509"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"61eb12f23278ac6f295ed56cec344d9361a7176e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"       { name: designate_mdns, group: designate-mdns },"},{"line_number":83,"context_line":"       { name: designate_pool_manager, group: designate-pool-manager },"},{"line_number":84,"context_line":"       { name: designate_sink, group: designate-sink }]"},{"line_number":85,"context_line":"    - container_envs.results"},{"line_number":86,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_04bbc273","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":27},"updated":"2016-08-19 15:25:40.000000000","message":"Ditto","commit_id":"8fe75fc9adc63a9d39b85f884781311e29e93509"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"0cb649ea01beecf94dc33f81303c79b8a8c620f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensuring the containers up"},{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    name: \"{{ item.name }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a629dbe_4a95963e","line":1,"updated":"2016-11-07 13:46:34.000000000","message":"move it to reconfigure file.","commit_id":"e502a61c3d745c7ea297f68af0c7afc9d9c2bf6e"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"dedd2a76ead0021d43c9413c995ef9452d33cf8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensuring the containers up"},{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    name: \"{{ item.name }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a629dbe_bdef55af","line":1,"in_reply_to":"9a629dbe_4a95963e","updated":"2016-11-07 15:37:28.000000000","message":"done","commit_id":"e502a61c3d745c7ea297f68af0c7afc9d9c2bf6e"}],"ansible/roles/designate/tasks/start.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6928a10b08039bb0dee64aa84820b175c39e5217","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":24,"context_line":"  when: inventory_hostname in groups[\u0027designate-api\u0027]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Starting designate-backend-bind9 container"},{"line_number":27,"context_line":"  kolla_docker:"},{"line_number":28,"context_line":"    action: \"start_container\""},{"line_number":29,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9ad45d7e_baa86778","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":50},"updated":"2016-08-11 07:43:52.000000000","message":"Ditto","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"}],"ansible/roles/designate/tasks/upgrade.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"bc42ced659171d98bb8850e5874ce2dbf4cb6d0b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  when: inventory_hostname in groups[\u0027designate-central\u0027]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include: start.yml"},{"line_number":13,"context_line":"  serial: \"%30\""},{"line_number":14,"context_line":"  when: inventory_hostname in groups[\u0027designate-central\u0027]"},{"line_number":15,"context_line":"        or inventory_hostname in groups[\u0027designate-api\u0027]"},{"line_number":16,"context_line":"        or inventory_hostname in groups[\u0027designate-mdns\u0027]"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9a629dbe_7546b124","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":15},"updated":"2016-11-07 16:56:31.000000000","message":"it isn\u0027t needed anymore.","commit_id":"c1032efec15ca30717f90a49098bf6b36f960417"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"9cafd3808db69ee6d10827cf4647d98e828a04f3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  when: inventory_hostname in groups[\u0027designate-central\u0027]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include: start.yml"},{"line_number":13,"context_line":"  serial: \"%30\""},{"line_number":14,"context_line":"  when: inventory_hostname in groups[\u0027designate-central\u0027]"},{"line_number":15,"context_line":"        or inventory_hostname in groups[\u0027designate-api\u0027]"},{"line_number":16,"context_line":"        or inventory_hostname in groups[\u0027designate-mdns\u0027]"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9a629dbe_bcad8433","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":15},"in_reply_to":"9a629dbe_7546b124","updated":"2016-11-08 01:26:54.000000000","message":"Done","commit_id":"c1032efec15ca30717f90a49098bf6b36f960417"}],"ansible/roles/designate/templates/designate.conf.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"209f5b4e14aec542e4745e46aa166f44b7e5c5fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"# Where an option is commented out, but filled in this shows the default"},{"line_number":3,"context_line":"# value of that option"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"########################"},{"line_number":6,"context_line":"## General Configuration"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_ff1e8c61","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":22},"updated":"2016-08-10 08:23:12.000000000","message":"Please, remove comments","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"855f8e6436cbfa238910e1c67e17ee378fc62bae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ad45d7e_82c39056","updated":"2016-08-10 21:21:27.000000000","message":"From what I can see in other project config files, any commented out/default config options are omitted from the config. You may have to remove any parts which are not ini file headers \"[some_header]\" or variables being set.","commit_id":"db224a4d7f1fdd055039e1f9dc132586c823e6d8"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"855f8e6436cbfa238910e1c67e17ee378fc62bae","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#log_config \u003d None"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Log directory"},{"line_number":16,"context_line":"log-dir \u003d /var/log/kolla/designate"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Driver used for issuing notifications"},{"line_number":19,"context_line":"notification_driver \u003d messaging"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_42f878c3","line":16,"updated":"2016-08-10 21:21:27.000000000","message":"Is this correct? From \nhttps://github.com/openstack/designate/blob/master/etc/designate/designate.conf.sample \nand \nhttp://docs.openstack.org/developer/designate/getting-started.html#configuring-designate,\nit refers to it as \"logdir\".","commit_id":"db224a4d7f1fdd055039e1f9dc132586c823e6d8"},{"author":{"_account_id":17372,"name":"Ross Krumbeck","email":"ross.krumbeck@gmail.com","username":"bsk1n"},"change_message_id":"96c54ab79f35da6a257487dca62e5bec973922b8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#log_config \u003d None"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Log directory"},{"line_number":16,"context_line":"log-dir \u003d /var/log/kolla/designate"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Driver used for issuing notifications"},{"line_number":19,"context_line":"notification_driver \u003d messaging"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9ad45d7e_307665d7","line":16,"in_reply_to":"9ad45d7e_42f878c3","updated":"2016-08-11 00:47:17.000000000","message":"Originally I used the sample, but when running designate there were warnings that logdir is deprecated and log-dir should be used.","commit_id":"db224a4d7f1fdd055039e1f9dc132586c823e6d8"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"655a250c946e2e67b23db55c89169e24d4727126","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"[backend:agent:bind9]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"[backend:agent:denominator]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"[oslo_concurrency]"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9ad45d7e_96123b57","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":27},"updated":"2016-08-12 16:03:15.000000000","message":"There is no content that can be considered to delete","commit_id":"61a27a2083fc8f5688143cc9413788d5d4548811"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3b612d02cc65a5935a203534be30ec608897b838","unresolved":false,"context_lines":[{"line_number":25,"context_line":"enable_api_v2 \u003d True"},{"line_number":26,"context_line":"enabled_extensions_v2 \u003d \u0027quotas, reports\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"api_paste_config \u003d /usr/share/designate/api-paste.ini"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[keystone_authtoken]"},{"line_number":31,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_79408b07","line":28,"updated":"2016-08-24 02:11:43.000000000","message":"when install from source, this file do not exist.","commit_id":"8fe75fc9adc63a9d39b85f884781311e29e93509"},{"author":{"_account_id":17372,"name":"Ross Krumbeck","email":"ross.krumbeck@gmail.com","username":"bsk1n"},"change_message_id":"cbe5826baed40da14ca56fef0af5d4e847816d24","unresolved":false,"context_lines":[{"line_number":25,"context_line":"enable_api_v2 \u003d True"},{"line_number":26,"context_line":"enabled_extensions_v2 \u003d \u0027quotas, reports\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"api_paste_config \u003d /usr/share/designate/api-paste.ini"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[keystone_authtoken]"},{"line_number":31,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa7ab95a_a7f441f2","line":28,"in_reply_to":"1ac06dbe_79408b07","updated":"2016-08-29 01:02:47.000000000","message":"I\u0027m not sure what to do about this. Designate API container will not start without it.","commit_id":"8fe75fc9adc63a9d39b85f884781311e29e93509"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"61eb12f23278ac6f295ed56cec344d9361a7176e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"enabled_notification_handlers \u003d nova_fixed, neutron_floatingip"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[service:mdns]"},{"line_number":53,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + kolla_external_vip_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"[service:agent]"},{"line_number":56,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"1ac06dbe_ea2bcd31","line":53,"range":{"start_line":53,"start_character":52,"end_line":53,"end_character":80},"updated":"2016-08-19 15:25:40.000000000","message":"Q: any expecial reason for using external_vip_interface instead of api_interface?","commit_id":"8fe75fc9adc63a9d39b85f884781311e29e93509"},{"author":{"_account_id":17372,"name":"Ross Krumbeck","email":"ross.krumbeck@gmail.com","username":"bsk1n"},"change_message_id":"cbe5826baed40da14ca56fef0af5d4e847816d24","unresolved":false,"context_lines":[{"line_number":50,"context_line":"enabled_notification_handlers \u003d nova_fixed, neutron_floatingip"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[service:mdns]"},{"line_number":53,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + kolla_external_vip_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"[service:agent]"},{"line_number":56,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"fa7ab95a_e797298e","line":53,"range":{"start_line":53,"start_character":52,"end_line":53,"end_character":80},"in_reply_to":"1ac06dbe_ea2bcd31","updated":"2016-08-29 01:02:47.000000000","message":"I thought that the Customer Facing DNS servers needed to initiate DNS requests to the mDNS service and since its mostly UDP which is not supported by haproxy.\n\nBut after reviewing the docs looks like the requests are outbound from mDNS so I will revert:\n\nhttp://docs.openstack.org/developer/designate/architecture.html","commit_id":"8fe75fc9adc63a9d39b85f884781311e29e93509"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"a76323ac3161128df082039ddc7c2c6d78722347","unresolved":false,"context_lines":[{"line_number":28,"context_line":"api_paste_config \u003d /usr/share/designate/api-paste.ini"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[keystone_authtoken]"},{"line_number":31,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"},{"line_number":32,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":33,"context_line":"auth_type \u003d password"},{"line_number":34,"context_line":"project_domain_id \u003d default"},{"line_number":35,"context_line":"user_domain_id \u003d default"},{"line_number":36,"context_line":"project_name \u003d service"},{"line_number":37,"context_line":"username \u003d {{ designate_keystone_user }}"},{"line_number":38,"context_line":"password \u003d {{ designate_keystone_password }}"},{"line_number":39,"context_line":"http_connect_timeout \u003d 60"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"memcache_security_strategy \u003d ENCRYPT"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9a89bdaa_b84236ac","line":38,"range":{"start_line":31,"start_character":0,"end_line":38,"end_character":44},"updated":"2016-09-08 09:58:30.000000000","message":"Use correct keystone parameter name\nhttp://docs.openstack.org/developer/designate/install/ubuntu.html","commit_id":"e8ee3e2f317f33da45a63383f7cfbd5f80f2b43a"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"633abf6fe7c4ca08fd9621863aa0c0f3355c8a1b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":12,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":13,"context_line":"rabbit_ha_queues \u003d true"},{"line_number":14,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[service:central]"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"9a629dbe_da719d0d","line":14,"updated":"2016-11-11 16:01:08.000000000","message":"use  transport_url instead","commit_id":"f361bba376998fdbc2ad7fefa58ce536eb435d21"}],"ansible/roles/haproxy/templates/haproxy.cfg.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"209f5b4e14aec542e4745e46aa166f44b7e5c5fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ad45d7e_5f5b582e","line":456,"updated":"2016-08-10 08:23:12.000000000","message":"Please add {% if haproxy_enable_external_vip | bool %}, see ceilometer as an example","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"633abf6fe7c4ca08fd9621863aa0c0f3355c8a1b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"[oslo_messaging_notifications]"},{"line_number":94,"context_line":"{% if enable_ceilometer | bool or enable_designate | bool %}"},{"line_number":95,"context_line":"driver \u003d messagingv2"},{"line_number":96,"context_line":"topics \u003d notifications{% if enable_designate | bool %},notifications_designate{% endif %}"},{"line_number":97,"context_line":"{% else %}"},{"line_number":98,"context_line":"driver \u003d noop"},{"line_number":99,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"9a629dbe_ba76a903","line":96,"updated":"2016-11-11 16:01:08.000000000","message":"need disable notifictions topic when enable_ceilometer\u003d\u003dno and enable_designate\u003dyes","commit_id":"f361bba376998fdbc2ad7fefa58ce536eb435d21"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"633abf6fe7c4ca08fd9621863aa0c0f3355c8a1b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"# Though my_ip is not used directly, lots of other variables use $my_ip"},{"line_number":53,"context_line":"my_ip \u003d {{ api_interface_address }}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% if enable_ceilometer | bool or enable_designate | bool %}"},{"line_number":56,"context_line":"instance_usage_audit \u003d True"},{"line_number":57,"context_line":"instance_usage_audit_period \u003d hour"},{"line_number":58,"context_line":"notify_on_state_change \u003d vm_and_task_state"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"9a629dbe_7a70910b","line":55,"updated":"2016-11-11 16:01:08.000000000","message":"hmm, designate need the instance usage audit info?","commit_id":"f361bba376998fdbc2ad7fefa58ce536eb435d21"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"633abf6fe7c4ca08fd9621863aa0c0f3355c8a1b","unresolved":false,"context_lines":[{"line_number":189,"context_line":"[oslo_messaging_notifications]"},{"line_number":190,"context_line":"{% if enable_ceilometer | bool or enable_designate | bool %}"},{"line_number":191,"context_line":"driver \u003d messagingv2"},{"line_number":192,"context_line":"topics \u003d notifications{% if enable_designate | bool %},notifications_designate{% endif %}"},{"line_number":193,"context_line":"{% else %}"},{"line_number":194,"context_line":"driver \u003d noop"},{"line_number":195,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"9a629dbe_9a6ba51d","line":192,"updated":"2016-11-11 16:01:08.000000000","message":"ditto.","commit_id":"f361bba376998fdbc2ad7fefa58ce536eb435d21"}],"ansible/roles/prechecks/tasks/port_checks.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"209f5b4e14aec542e4745e46aa166f44b7e5c5fd","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    - \"{{ kolla_internal_vip_address }}\""},{"line_number":456,"context_line":"    - \"{{ kolla_external_vip_address }}\""},{"line_number":457,"context_line":"  failed_when: ping_output.rc !\u003d 1"},{"line_number":458,"context_line":"  when: enable_haproxy | bool"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"- name: Checking if kolla_internal_vip_address is in the same network as network_interface on all nodes"},{"line_number":461,"context_line":"  command: ip -4 -o addr show dev {{ network_interface }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_7ff45cf1","line":458,"range":{"start_line":458,"start_character":0,"end_line":458,"end_character":29},"updated":"2016-08-10 08:23:12.000000000","message":"Any reason for adding this here? If you found an issue create a new bug with a separate commit.","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"209f5b4e14aec542e4745e46aa166f44b7e5c5fd","unresolved":false,"context_lines":[{"line_number":463,"context_line":"  changed_when: false"},{"line_number":464,"context_line":"  failed_when: \"\u0027169.254.\u0027 not in kolla_internal_vip_address and \\"},{"line_number":465,"context_line":"                kolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3]) is none\""},{"line_number":466,"context_line":"  when: enable_haproxy | bool"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_3fd14458","line":466,"range":{"start_line":466,"start_character":0,"end_line":466,"end_character":29},"updated":"2016-08-10 08:23:12.000000000","message":"Ditto","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"}],"ansible/site.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"209f5b4e14aec542e4745e46aa166f44b7e5c5fd","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    - memcached"},{"line_number":270,"context_line":"  roles:"},{"line_number":271,"context_line":"    - { role: designate,"},{"line_number":272,"context_line":"               tags: designate,"},{"line_number":273,"context_line":"               when: enable_designate | bool }"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_9f47901c","line":272,"range":{"start_line":272,"start_character":9,"end_line":272,"end_character":15},"updated":"2016-08-10 08:23:12.000000000","message":"Put it at the same place as role:","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"209f5b4e14aec542e4745e46aa166f44b7e5c5fd","unresolved":false,"context_lines":[{"line_number":270,"context_line":"  roles:"},{"line_number":271,"context_line":"    - { role: designate,"},{"line_number":272,"context_line":"               tags: designate,"},{"line_number":273,"context_line":"               when: enable_designate | bool }"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_3f5f84e6","line":273,"range":{"start_line":273,"start_character":10,"end_line":273,"end_character":14},"updated":"2016-08-10 08:23:12.000000000","message":"ditto","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"61eb12f23278ac6f295ed56cec344d9361a7176e","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"- hosts:"},{"line_number":261,"context_line":"    - designate-api"},{"line_number":262,"context_line":"    - designate-backend-bind9"},{"line_number":263,"context_line":"    - designate-central"},{"line_number":264,"context_line":"    - designate-mdns"},{"line_number":265,"context_line":"    - designate-pool-manager"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_0a5f4973","line":262,"range":{"start_line":262,"start_character":0,"end_line":262,"end_character":29},"updated":"2016-08-19 15:25:40.000000000","message":"There is not entry about backend-bind9 in the code, remove it","commit_id":"8fe75fc9adc63a9d39b85f884781311e29e93509"},{"author":{"_account_id":17372,"name":"Ross Krumbeck","email":"ross.krumbeck@gmail.com","username":"bsk1n"},"change_message_id":"cbe5826baed40da14ca56fef0af5d4e847816d24","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"- hosts:"},{"line_number":261,"context_line":"    - designate-api"},{"line_number":262,"context_line":"    - designate-backend-bind9"},{"line_number":263,"context_line":"    - designate-central"},{"line_number":264,"context_line":"    - designate-mdns"},{"line_number":265,"context_line":"    - designate-pool-manager"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_07da4d78","line":262,"range":{"start_line":262,"start_character":0,"end_line":262,"end_character":29},"in_reply_to":"1ac06dbe_0a5f4973","updated":"2016-08-29 01:02:47.000000000","message":"Done","commit_id":"8fe75fc9adc63a9d39b85f884781311e29e93509"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"0cb649ea01beecf94dc33f81303c79b8a8c620f0","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    - designate-mdns"},{"line_number":318,"context_line":"    - designate-pool-manager"},{"line_number":319,"context_line":"    - designate-sink"},{"line_number":320,"context_line":" serial: \u0027{{ \"30%\" if action \u003d\u003d \"upgrade\" else \"0\" }}\u0027 "},{"line_number":321,"context_line":"  roles:"},{"line_number":322,"context_line":"    - { role: designate,"},{"line_number":323,"context_line":"        tags: designate,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a629dbe_4a7cb620","line":320,"range":{"start_line":320,"start_character":54,"end_line":320,"end_character":55},"updated":"2016-11-07 13:46:34.000000000","message":"remove whitespace","commit_id":"e502a61c3d745c7ea297f68af0c7afc9d9c2bf6e"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"dedd2a76ead0021d43c9413c995ef9452d33cf8a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    - designate-mdns"},{"line_number":318,"context_line":"    - designate-pool-manager"},{"line_number":319,"context_line":"    - designate-sink"},{"line_number":320,"context_line":" serial: \u0027{{ \"30%\" if action \u003d\u003d \"upgrade\" else \"0\" }}\u0027 "},{"line_number":321,"context_line":"  roles:"},{"line_number":322,"context_line":"    - { role: designate,"},{"line_number":323,"context_line":"        tags: designate,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a629dbe_bdd8351f","line":320,"range":{"start_line":320,"start_character":54,"end_line":320,"end_character":55},"in_reply_to":"9a629dbe_4a7cb620","updated":"2016-11-07 15:37:28.000000000","message":"done","commit_id":"e502a61c3d745c7ea297f68af0c7afc9d9c2bf6e"}],"docker/designate/designate-pool-manager/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"209f5b4e14aec542e4745e46aa166f44b7e5c5fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}designate-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# The bind9 package here is only to provide the rndc binary."},{"line_number":8,"context_line":"RUN yum -y install \\"},{"line_number":9,"context_line":"        bind \\"},{"line_number":10,"context_line":"        openstack-designate-pool-manager \\"},{"line_number":11,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN apt-get -y install --no-install-recommends \\"},{"line_number":16,"context_line":"        bind9 \\"},{"line_number":17,"context_line":"        designate-pool-manager \\"},{"line_number":18,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"USER designate"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_7fde1c40","line":25,"range":{"start_line":1,"start_character":0,"end_line":25,"end_character":14},"updated":"2016-08-10 08:23:12.000000000","message":"What\u0027s the reason for rename the file?\nThere is a commit which apply customizations for designate, this change can be applied there: https://review.openstack.org/#/c/350172/","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"},{"author":{"_account_id":17372,"name":"Ross Krumbeck","email":"ross.krumbeck@gmail.com","username":"bsk1n"},"change_message_id":"27af47997843e1c80258257d562d5d96262972ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}designate-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# The bind9 package here is only to provide the rndc binary."},{"line_number":8,"context_line":"RUN yum -y install \\"},{"line_number":9,"context_line":"        bind \\"},{"line_number":10,"context_line":"        openstack-designate-pool-manager \\"},{"line_number":11,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN apt-get -y install --no-install-recommends \\"},{"line_number":16,"context_line":"        bind9 \\"},{"line_number":17,"context_line":"        designate-pool-manager \\"},{"line_number":18,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"USER designate"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_80ae0c7f","line":25,"range":{"start_line":1,"start_character":0,"end_line":25,"end_character":14},"in_reply_to":"9ad45d7e_7fde1c40","updated":"2016-08-10 10:43:31.000000000","message":"So that the name is accurate. The service is called designate-pool-manager not designate-poolmanager. Also to be consistent with other ansible roles such as heat-api-cfn.","commit_id":"50c8c8f5de7052371492240052dc77219baeb64b"}],"etc/kolla/globals.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"54270a8a34bbd72292cfc17a6bcffe549643f9e5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"#enable_etcd: \"no\""},{"line_number":132,"context_line":"#enable_gnocchi: \"no\""},{"line_number":133,"context_line":"#enable_grafana: \"no\""},{"line_number":134,"context_line":"#enable_designate: \"no\""},{"line_number":135,"context_line":"#enable_heat: \"yes\""},{"line_number":136,"context_line":"#enable_horizon: \"yes\""},{"line_number":137,"context_line":"#enable_influxdb: \"no\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9a629dbe_7e6c0e08","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":23},"updated":"2016-11-11 12:28:57.000000000","message":"dupe?","commit_id":"b794739169dcbe766f082431afe076a96126d2f4"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"64383a7c7ed48b803b7717e32d57a66c8f169d8e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"#enable_etcd: \"no\""},{"line_number":132,"context_line":"#enable_gnocchi: \"no\""},{"line_number":133,"context_line":"#enable_grafana: \"no\""},{"line_number":134,"context_line":"#enable_designate: \"no\""},{"line_number":135,"context_line":"#enable_heat: \"yes\""},{"line_number":136,"context_line":"#enable_horizon: \"yes\""},{"line_number":137,"context_line":"#enable_influxdb: \"no\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9a629dbe_d487bbb2","line":134,"range":{"start_line":134,"start_character":0,"end_line":134,"end_character":23},"in_reply_to":"9a629dbe_7e6c0e08","updated":"2016-11-11 13:26:30.000000000","message":"done","commit_id":"b794739169dcbe766f082431afe076a96126d2f4"}]}
