)]}'
{"docker/vmtp/Dockerfile.j2":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3477116f939e3bdab03e16601f0bb639267c5a3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9ad45d7e_505abef2","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":47},"updated":"2016-08-11 21:05:29.000000000","message":"im not sure this is needed as you are not using any macros from it.","commit_id":"24767796fe2becd0c3920d221ce683acc89dd717"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3f7736049615f322acb138c70584292c58e918b9","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":7,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3ac371cc_9af1d2d0","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":17},"updated":"2016-08-14 23:46:11.000000000","message":"if you make the build explcitly fail you may need to skip this container in the binary gate job tests.\n\nthis can be done by adding the container to the excluded_images  for each of the binary jobs in this file\nhttps://github.com/openstack/kolla/blob/master/tests/test_build.py#L70-L72","commit_id":"3b61bf43147ffc53e34e24470a0021ddaab5789b"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ccd84da60b20cdafca0af4c25eb0e6d7d840b915","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":7,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3ac371cc_7548675c","line":7,"range":{"start_line":6,"start_character":0,"end_line":7,"end_character":17},"in_reply_to":"3ac371cc_9af1d2d0","updated":"2016-08-15 01:46:29.000000000","message":"Done","commit_id":"3b61bf43147ffc53e34e24470a0021ddaab5789b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"1bbf91365ed46b7d7cf634f5e41c96f874ebd719","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ac371cc_75aa2772","line":18,"updated":"2016-08-15 02:15:13.000000000","message":"Shall we drop root for the vmtp container?","commit_id":"cc56bed3cfb7a04473f96f2f8c0068da0e822b4f"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"735a94a910ce8e3e3c2b03215f407d1dcbe4a27a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ac371cc_f692654a","line":18,"in_reply_to":"3ac371cc_75aa2772","updated":"2016-08-16 04:21:27.000000000","message":"Thanks for the feedback.  Will add VMTP user in next patch-set that will also address the merge conflict.","commit_id":"cc56bed3cfb7a04473f96f2f8c0068da0e822b4f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"297092c6c067382d96cbac235d4b4aebf9af909d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN pip install -U vmtp"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3ac371cc_7b8c8e7f","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":18},"updated":"2016-08-16 11:14:34.000000000","message":"Upgrade is necessary?","commit_id":"8a2e9489522f5ca0e704c0957229362da3786d6b"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"297092c6c067382d96cbac235d4b4aebf9af909d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN useradd --user-group vmtp"},{"line_number":16,"context_line":"RUN usermod -a -G kolla vmtp"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block vmtp_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3ac371cc_5bfa72be","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":29},"updated":"2016-08-16 11:14:34.000000000","message":"User add should be in source install code block, if not, when a binary is available the uuid and guid will be different from binary defaults","commit_id":"8a2e9489522f5ca0e704c0957229362da3786d6b"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"297092c6c067382d96cbac235d4b4aebf9af909d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ include_footer }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"USER vmtp"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3ac371cc_9bbfcafa","line":23,"updated":"2016-08-16 11:14:34.000000000","message":"Remove empty line","commit_id":"8a2e9489522f5ca0e704c0957229362da3786d6b"}],"tests/test_build.py":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"297092c6c067382d96cbac235d4b4aebf9af909d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                       \"neutron-networking-sfc-agent\","},{"line_number":72,"context_line":"                       \"senlin-base\","},{"line_number":73,"context_line":"                       \"vmtp\","},{"line_number":74,"context_line":"                       \"watcher-base\"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def setUp(self):"},{"line_number":77,"context_line":"        super(BuildTestCentosBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_dbd30237","line":74,"range":{"start_line":74,"start_character":37,"end_line":74,"end_character":38},"updated":"2016-08-16 11:14:34.000000000","message":"Keep the syntax as it was, move ] to a new line","commit_id":"8a2e9489522f5ca0e704c0957229362da3786d6b"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"297092c6c067382d96cbac235d4b4aebf9af909d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"class BuildTestUbuntuBinary(BuildTest, base.BaseTestCase):"},{"line_number":93,"context_line":"    excluded_images \u003d [\"neutron-networking-sfc-agent\","},{"line_number":94,"context_line":"                       \"vmtp\","},{"line_number":95,"context_line":"                       \"zaqar\"]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def setUp(self):"},{"line_number":98,"context_line":"        super(BuildTestUbuntuBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_fbe07efc","line":95,"range":{"start_line":95,"start_character":30,"end_line":95,"end_character":31},"updated":"2016-08-16 11:14:34.000000000","message":"Ditto","commit_id":"8a2e9489522f5ca0e704c0957229362da3786d6b"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"297092c6c067382d96cbac235d4b4aebf9af909d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                       \"neutron-networking-sfc-agent\","},{"line_number":115,"context_line":"                       \"senlin-base\","},{"line_number":116,"context_line":"                       \"vmtp\","},{"line_number":117,"context_line":"                       \"watcher-base\"]"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def setUp(self):"},{"line_number":120,"context_line":"        super(BuildTestOracleLinuxBinary, self).setUp()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_9bf22ad1","line":117,"range":{"start_line":117,"start_character":37,"end_line":117,"end_character":38},"updated":"2016-08-16 11:14:34.000000000","message":"Ditto","commit_id":"8a2e9489522f5ca0e704c0957229362da3786d6b"}]}