)]}'
{"docker/ironic/ironic-api/Dockerfile.j2":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"04a32f694fbc197f7b552f9a367d50f1f18c07ab","unresolved":false,"context_lines":[{"line_number":18,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block ironic_api_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":"{{ include_footer }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"USER ironic"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_403998d6","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":32},"updated":"2016-08-23 08:38:45.000000000","message":"please remove this","commit_id":"07946a2607620d58a0e18f57cd7b9c261d89b87c"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4d87243cb0ae917fe0e2aca0ebf8f197eb6ba3a3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{% block ironic_api_footer %}{% endblock %}"},{"line_number":21,"context_line":"{% block footer %}{% endblock %}"},{"line_number":22,"context_line":"{{ include_footer }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"USER ironic"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_ec899b27","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":32},"in_reply_to":"1ac06dbe_403998d6","updated":"2016-08-23 09:51:38.000000000","message":"It\u0027s in every other customisation patch. I agree it\u0027s probably not needed, but I\u0027m ok with letting this through and removing all at once.","commit_id":"07946a2607620d58a0e18f57cd7b9c261d89b87c"}],"docker/ironic/ironic-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"9072d99aa6823687c7ed4e467e0af5388452afe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ad45d7e_36a2869b","line":33,"updated":"2016-08-12 09:59:30.000000000","message":"Please, include footers","commit_id":"4ded7ee2956dfd2ba24d0364d97b3e5adb85dc80"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"451372d4192d73e43b3288ffb7f3d6b5a7c5f923","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ac371cc_8efcfc3f","line":33,"updated":"2016-08-14 14:21:54.000000000","message":"include footers is not needed.\n\nBut please add \u0027\\n\u0027 at the last line.","commit_id":"4ded7ee2956dfd2ba24d0364d97b3e5adb85dc80"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"72cb5ab60a965ff3c7bd05573faa04430cae7815","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ac371cc_fa456617","line":33,"in_reply_to":"3ac371cc_8efcfc3f","updated":"2016-08-20 02:49:56.000000000","message":"Can you please explain what you mean? There is an extra line after the footer block.","commit_id":"4ded7ee2956dfd2ba24d0364d97b3e5adb85dc80"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"ac0bc8d9b1723bb64f4839da119d1bfb93771206","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ad45d7e_73540b21","line":33,"in_reply_to":"9ad45d7e_36a2869b","updated":"2016-08-12 11:15:49.000000000","message":"I don\u0027t believe {{ include_footer }} is meant to be at the footer of base Dockerfiles as you would have the same code repeated twice.\n\nAs an example, building ironic-api would have the footer code twice as it would have been placed in ironic-base and ironic-api.","commit_id":"4ded7ee2956dfd2ba24d0364d97b3e5adb85dc80"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"6425f9b268887119a47706b0b925f38800126e7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ad45d7e_e592e3f5","line":33,"in_reply_to":"9ad45d7e_73540b21","updated":"2016-08-12 15:27:48.000000000","message":"I agree Shaun :)","commit_id":"4ded7ee2956dfd2ba24d0364d97b3e5adb85dc80"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"4985410c45ad198c308a1401ea59805baa08f620","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \u0026\u0026 chown -R ironic: /etc/ironic"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block ironic_base_footer %}{% endblock %}"},{"line_number":32,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_ee7461d0","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":32},"updated":"2016-08-20 11:05:11.000000000","message":"Please, remove block footer at base image, is not necessary.","commit_id":"35764d08c95b5b165d57846ea046622f41bc32d1"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"4a6bff1a7dc369767293814ce0e65d8dfd4a5afc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \u0026\u0026 chown -R ironic: /etc/ironic"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block ironic_base_footer %}{% endblock %}"},{"line_number":32,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_b87c6a73","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":32},"in_reply_to":"1ac06dbe_ee7461d0","updated":"2016-08-20 14:04:22.000000000","message":"Done","commit_id":"35764d08c95b5b165d57846ea046622f41bc32d1"}],"docker/ironic/ironic-conductor/Dockerfile.j2":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"04a32f694fbc197f7b552f9a367d50f1f18c07ab","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{{ macros.install_packages(ironic_conductor_packages | customizable(\"packages\")) }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% block ironic_conductor_footer %}{% endblock %}"},{"line_number":36,"context_line":"{% block footer %}{% endblock %}"},{"line_number":37,"context_line":"{{ include_footer }}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"USER ironic"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_a0496c62","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":32},"updated":"2016-08-23 08:38:45.000000000","message":"ditto","commit_id":"07946a2607620d58a0e18f57cd7b9c261d89b87c"}],"docker/ironic/ironic-inspector/Dockerfile.j2":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"9d75222e32bee463e2b6712c252fccc4a38b64cc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027openstack-ironic-inspector\u0027] %}"},{"line_number":9,"context_line":"    {% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_c2497e8d","line":9,"updated":"2016-08-20 04:13:16.000000000","message":"if ubuntu is not supported, please add code to print out some message","commit_id":"35764d08c95b5b165d57846ea046622f41bc32d1"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"b55dabe01ec544a0894219451f22c0ca51de1e04","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":7,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":8,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027openstack-ironic-inspector\u0027] %}"},{"line_number":9,"context_line":"    {% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_6dd87b54","line":9,"in_reply_to":"1ac06dbe_c2497e8d","updated":"2016-08-20 04:40:18.000000000","message":"This is purely to make ironic compatible with the third party plugin support blueprint.\n\nI would imaging the issue that you\u0027ve mentioned would be persistent across many packages so maybe its better to fix across the board rather than ad-hoc?","commit_id":"35764d08c95b5b165d57846ea046622f41bc32d1"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"04a32f694fbc197f7b552f9a367d50f1f18c07ab","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% block ironic_inspector_footer %}{% endblock %}"},{"line_number":16,"context_line":"{% block footer %}{% endblock %}"},{"line_number":17,"context_line":"{{ include_footer }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"USER ironic"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_206c5ccf","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":32},"updated":"2016-08-23 08:38:45.000000000","message":"ditto","commit_id":"07946a2607620d58a0e18f57cd7b9c261d89b87c"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"b15c8d9ad2b966e129a1a9dd1c5d9f59a7419421","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027openstack-ironic-inspector\u0027] %}"},{"line_number":9,"context_line":"    {% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1ac06dbe_c3e04999","line":11,"updated":"2016-08-25 10:54:48.000000000","message":"Not sure if this has to be moved inside the centos, ... block.","commit_id":"b597c90827ff0be7d21d394829e3067b4bcca28d"},{"author":{"_account_id":16482,"name":"Shaun Smekel","email":"shaun.smekel@theorem.net.au","username":"smekel"},"change_message_id":"40b85ddcfbcac4acc3cd8a814b65a97b50761529","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027openstack-ironic-inspector\u0027] %}"},{"line_number":9,"context_line":"    {% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa7ab95a_d2375bae","line":11,"in_reply_to":"1ac06dbe_c3e04999","updated":"2016-08-27 07:31:44.000000000","message":"Install_packages now handles an empty package list (an ideal that you floated from memory) so it will omit running the yum install/apt-get install command.","commit_id":"b597c90827ff0be7d21d394829e3067b4bcca28d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1bc31dec85f296da01a1188470a36af931741348","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        {% set ironic_inspector_packages \u003d [\u0027openstack-ironic-inspector\u0027] %}"},{"line_number":9,"context_line":"    {% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{{ macros.install_packages(ironic_inspector_packages | customizable(\"packages\")) }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa7ab95a_53133fb8","line":11,"in_reply_to":"fa7ab95a_d2375bae","updated":"2016-08-28 16:04:57.000000000","message":"This should probably be a conditional or ubuntu.  Please file a techdebt bug.","commit_id":"b597c90827ff0be7d21d394829e3067b4bcca28d"}],"docker/ironic/ironic-pxe/Dockerfile.j2":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"04a32f694fbc197f7b552f9a367d50f1f18c07ab","unresolved":false,"context_lines":[{"line_number":23,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% block ironic_pxe_footer %}{% endblock %}"},{"line_number":26,"context_line":"{% block footer %}{% endblock %}"},{"line_number":27,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1ac06dbe_4067d8e8","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":32},"updated":"2016-08-23 08:38:45.000000000","message":"ditto","commit_id":"07946a2607620d58a0e18f57cd7b9c261d89b87c"}]}