)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Add upgrade Ansible task"},{"line_number":19,"context_line":"Add reconfigure Ansible task"},{"line_number":20,"context_line":"Add templatized json and .conf files for barbican"},{"line_number":21,"context_line":"Integrate barbican with haproxy"},{"line_number":22,"context_line":"Reference installation configuration link:http://docs.openstack.org/mitaka/install-guide-rdo/trove-install.html"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I0bc6edbf2e495ce377f994f793bde979d5c55dbf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a629dbe_dff806c6","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":31},"updated":"2016-11-09 20:17:57.000000000","message":"Please, remove it","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":288,"context_line":"enable_telegraf: \"no\""},{"line_number":289,"context_line":"enable_tempest: \"no\""},{"line_number":290,"context_line":"enable_vmtp: \"no\""},{"line_number":291,"context_line":"enable_trove: \"no\""},{"line_number":292,"context_line":"enable_watcher: \"no\""},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"ironic_keystone_user: \"ironic\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_e471c377","line":291,"range":{"start_line":291,"start_character":0,"end_line":291,"end_character":18},"updated":"2016-11-09 20:17:57.000000000","message":"Please, alphabetize.","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":321,"context_line":"####################"},{"line_number":322,"context_line":"## Trove options"},{"line_number":323,"context_line":"####################"},{"line_number":324,"context_line":"trove_api_workers: 2"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"####################"},{"line_number":327,"context_line":"# HAProxy options"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a629dbe_de4e113a","line":324,"range":{"start_line":324,"start_character":19,"end_line":324,"end_character":20},"updated":"2016-11-10 21:28:08.000000000","message":"Please, call to var openstack_service_workers. Also IMHO this vars is not needed here. Calling to openstack_service_workers directly in the template is enough","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4e390b55fbd5ec892e0dc5a1828ab92bb9fa1734","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#These initial groups are the only groups required to be modified. The"},{"line_number":2,"context_line":"# additional groups are for more control of the environment."},{"line_number":3,"context_line":"[control]"},{"line_number":4,"context_line":"localhost       ansible_connection\u003dlocal"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ba5da102_ef9e5e62","line":1,"updated":"2016-11-06 05:47:45.000000000","message":"please do not touch this in your patch.","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6102ca9d69704193c778edb06be6187f9cf5d81f","unresolved":false,"context_lines":[{"line_number":195,"context_line":"[swift-object-server:children]"},{"line_number":196,"context_line":"storage"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"# Trvoe"},{"line_number":199,"context_line":"[trove-api:children]"},{"line_number":200,"context_line":"trove"},{"line_number":201,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ac06dbe_b9554c51","line":198,"range":{"start_line":198,"start_character":2,"end_line":198,"end_character":7},"updated":"2016-08-22 17:33:02.000000000","message":"/trvoe/trove","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"}],"ansible/inventory/multinode":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6102ca9d69704193c778edb06be6187f9cf5d81f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"[gnocchi-metricd:children]"},{"line_number":282,"context_line":"gnocchi"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"# Trvoe"},{"line_number":285,"context_line":"[trove-api:children]"},{"line_number":286,"context_line":"trove"},{"line_number":287,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ac06dbe_59ba586f","line":284,"range":{"start_line":284,"start_character":2,"end_line":284,"end_character":7},"updated":"2016-08-22 17:33:02.000000000","message":"ditto","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":138,"context_line":"[gnocchi:children]"},{"line_number":139,"context_line":"control"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"[gnocchi:children]"},{"line_number":142,"context_line":"control"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"[trove:children]"},{"line_number":145,"context_line":"control"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9a629dbe_442eef43","line":142,"range":{"start_line":141,"start_character":0,"end_line":142,"end_character":7},"updated":"2016-11-09 20:17:57.000000000","message":"Duplicated entry","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"}],"ansible/roles/haproxy/templates/haproxy.cfg.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":568,"context_line":"{% endif %}"},{"line_number":569,"context_line":"{% endif %}"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"{% if enable_trove | bool %}"},{"line_number":573,"context_line":"listen trove_api"},{"line_number":574,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ trove_api_port }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_c422ff51","line":571,"updated":"2016-11-09 20:17:57.000000000","message":"Extra line not needed, is enough with one empty line","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"bf1002563ab197f07465b5a090451b08e1b7bdc1","unresolved":false,"context_lines":[{"line_number":620,"context_line":"{% endif %}"},{"line_number":621,"context_line":"{% endif %}"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"# (NOTE): This defaults section deletes forwardfor as recomended by:"},{"line_number":624,"context_line":"#         https://marc.info/?l\u003dhaproxy\u0026m\u003d141684110710132\u0026w\u003d1"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"defaults"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_7f97fa39","line":623,"range":{"start_line":623,"start_character":54,"end_line":623,"end_character":64},"updated":"2016-11-09 21:01:04.000000000","message":"Initial spelling here was correct","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"394b0912e05a0433cd296fa79b9c623396f3e527","unresolved":false,"context_lines":[{"line_number":619,"context_line":"{% endif %}"},{"line_number":620,"context_line":"{% endif %}"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"# (NOTE): This defaults section deletes forwardfor as recomended by:"},{"line_number":623,"context_line":"#         https://marc.info/?l\u003dhaproxy\u0026m\u003d141684110710132\u0026w\u003d1"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"defaults"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7a77a97e_38030844","line":622,"range":{"start_line":622,"start_character":54,"end_line":622,"end_character":64},"updated":"2016-11-16 13:31:06.000000000","message":"still curious here -- original was correct","commit_id":"6eda0166244d80a8266e2f56ac8ef0f854071ed1"}],"ansible/roles/trove/defaults/main.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6102ca9d69704193c778edb06be6187f9cf5d81f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"####################"},{"line_number":5,"context_line":"# Trove conf"},{"line_number":6,"context_line":"####################"},{"line_number":7,"context_line":"trove_api_workers: 2"},{"line_number":8,"context_line":"nova_proxy_admin_password: \"588051a0f802450d\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_14ba67c0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2016-08-22 17:33:02.000000000","message":"Remove from this file and put it{{ openstack_service_workers }} at trove.conf.j2","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6102ca9d69704193c778edb06be6187f9cf5d81f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Trove conf"},{"line_number":6,"context_line":"####################"},{"line_number":7,"context_line":"trove_api_workers: 2"},{"line_number":8,"context_line":"nova_proxy_admin_password: \"588051a0f802450d\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_b44c3343","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":44},"updated":"2016-08-22 17:33:02.000000000","message":"Clean up the password, move it to etc/kolla/passwords.yml","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6102ca9d69704193c778edb06be6187f9cf5d81f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"trove_api_tag: \"{{ openstack_release }}\""},{"line_number":28,"context_line":"trove_api_image_full: \"{{ trove_api_image }}:{{ trove_api_tag }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"trove_guestagent_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-trove-guestagent\""},{"line_number":31,"context_line":"trove_guestagent_tag: \"{{ openstack_release }}\""},{"line_number":32,"context_line":"trove_guestagent_image_full: \"{{ trove_guestagent_image }}:{{ trove_guestagent_tag }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"trove_taskmanager_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-trove-taskmanager\""},{"line_number":35,"context_line":"trove_taskmanager_tag: \"{{ openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_efa096a1","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":86},"updated":"2016-08-22 17:33:02.000000000","message":"There is not any configuration for guestagent image, is not necessary? When is going to be used?","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4e390b55fbd5ec892e0dc5a1828ab92bb9fa1734","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"trove_guestagent_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-trove-guestagent\""},{"line_number":31,"context_line":"trove_guestagent_tag: \"{{ openstack_release }}\""},{"line_number":32,"context_line":"trove_guestagent_image_full: \"{{ trove_guestagent_image }}:{{ trove_guestagent_tag }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"trove_taskmanager_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-trove-taskmanager\""},{"line_number":35,"context_line":"trove_taskmanager_tag: \"{{ openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5da102_2f877613","line":32,"updated":"2016-11-06 05:47:45.000000000","message":"guestagent should run in guest OS. no need add it here.","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"f7a58d066d4ad019b62072721a7ede1e1c6dd7ea","unresolved":false,"context_lines":[{"line_number":27,"context_line":"trove_api_tag: \"{{ openstack_release }}\""},{"line_number":28,"context_line":"trove_api_image_full: \"{{ trove_api_image }}:{{ trove_api_tag }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"trove_guestagent_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-trove-guestagent\""},{"line_number":31,"context_line":"trove_guestagent_tag: \"{{ openstack_release }}\""},{"line_number":32,"context_line":"trove_guestagent_image_full: \"{{ trove_guestagent_image }}:{{ trove_guestagent_tag }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"trove_taskmanager_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-trove-taskmanager\""},{"line_number":35,"context_line":"trove_taskmanager_tag: \"{{ openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_91c12d57","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":86},"in_reply_to":"1ac06dbe_efa096a1","updated":"2016-08-23 04:24:33.000000000","message":"guest agent seems a necessary component according to [1]\n\n[1] http://docs.openstack.org/mitaka/install-guide-rdo/trove-install.html#install-and-configure-components","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"####################"},{"line_number":5,"context_line":"# Trove conf"},{"line_number":6,"context_line":"####################"},{"line_number":7,"context_line":"trove_api_workers: {{ openstack_service_workers }}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"####################"},{"line_number":10,"context_line":"# Database"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_bffb52c0","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":50},"updated":"2016-11-09 20:17:57.000000000","message":"Missing double quotes","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":33,"context_line":"####################"},{"line_number":34,"context_line":"# OpenStack"},{"line_number":35,"context_line":"####################"},{"line_number":36,"context_line":"trove_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3\""},{"line_number":37,"context_line":"trove_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3\""},{"line_number":38,"context_line":"trove_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ trove_api_port }}/v3\""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_c4975f46","line":36,"range":{"start_line":36,"start_character":92,"end_line":36,"end_character":95},"updated":"2016-11-09 20:17:57.000000000","message":"Is trove v3? As of trove docs is v1 and also they add tenant_id\nhttp://docs.openstack.org/developer/trove/dev/manual_install.html","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# OpenStack"},{"line_number":35,"context_line":"####################"},{"line_number":36,"context_line":"trove_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3\""},{"line_number":37,"context_line":"trove_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3\""},{"line_number":38,"context_line":"trove_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ trove_api_port }}/v3\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"trove_logging_debug: \"{{ openstack_logging_debug }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_448a6f1c","line":37,"range":{"start_line":37,"start_character":99,"end_line":37,"end_character":101},"updated":"2016-11-09 20:17:57.000000000","message":"ditto","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":35,"context_line":"####################"},{"line_number":36,"context_line":"trove_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3\""},{"line_number":37,"context_line":"trove_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3\""},{"line_number":38,"context_line":"trove_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ trove_api_port }}/v3\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"trove_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_c47e7f18","line":38,"range":{"start_line":38,"start_character":95,"end_line":38,"end_character":97},"updated":"2016-11-09 20:17:57.000000000","message":"ditto","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"####################"},{"line_number":29,"context_line":"# OpenStack"},{"line_number":30,"context_line":"####################"},{"line_number":31,"context_line":"trove_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}\""},{"line_number":32,"context_line":"trove_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}\""},{"line_number":33,"context_line":"trove_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ trove_api_port }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"trove_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a629dbe_de98d17a","line":33,"range":{"start_line":31,"start_character":92,"end_line":33,"end_character":95},"updated":"2016-11-10 21:28:08.000000000","message":"As said in my previous command, trove docs explicitly set tenant_id call at the endpoint. Have you verified it?","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"####################"},{"line_number":29,"context_line":"# OpenStack"},{"line_number":30,"context_line":"####################"},{"line_number":31,"context_line":"trove_admin_endpoint: \"{{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}\""},{"line_number":32,"context_line":"trove_internal_endpoint: \"{{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}\""},{"line_number":33,"context_line":"trove_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ trove_api_port }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"trove_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a629dbe_3a735de9","line":33,"range":{"start_line":31,"start_character":92,"end_line":33,"end_character":95},"in_reply_to":"9a629dbe_de98d17a","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"ansible/roles/trove/meta/main.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common }"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a629dbe_be287d34","line":4,"updated":"2016-11-10 21:28:08.000000000","message":"Endline not needed. Gate error probably came from a weird character from your text editor","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - { role: common }"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a629dbe_5a80118c","line":4,"in_reply_to":"9a629dbe_be287d34","updated":"2016-11-13 10:32:10.000000000","message":"ok i try again","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"ansible/roles/trove/tasks/bootstrap_service.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4e390b55fbd5ec892e0dc5a1828ab92bb9fa1734","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/trove-api/:{{ container_config_directory }}/:ro\""},{"line_number":17,"context_line":"      - \"trove:/var/lib/trove/\""},{"line_number":18,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":19,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":20,"context_line":"  run_once: True"},{"line_number":21,"context_line":"  delegate_to: \"{{ groups[\u0027trove-api\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5da102_0f9c7268","line":19,"updated":"2016-11-06 05:47:45.000000000","message":"order this in alphabeta","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"}],"ansible/roles/trove/tasks/config.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6102ca9d69704193c778edb06be6187f9cf5d81f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Ensuring config directories exist"},{"line_number":2,"context_line":"  file:"},{"line_number":3,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}\""},{"line_number":4,"context_line":"    state: \"directory\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_545e9f76","line":1,"updated":"2016-08-22 17:33:02.000000000","message":"Missing --- at the beginning of the file","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    src: \"{{ item }}.conf.j2\""},{"line_number":24,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/{{ item }}.conf\""},{"line_number":25,"context_line":"  with_items:"},{"line_number":26,"context_line":"    - \"trove-conductor\""},{"line_number":27,"context_line":"    - \"trove-api\""},{"line_number":28,"context_line":"    - \"trove-taskmanager\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Copying over trove.conf"},{"line_number":31,"context_line":"  merge_configs:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_ff6a2a80","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":25},"updated":"2016-11-09 20:17:57.000000000","message":"This files are copied to all containers, but are not present in templates/\u003cservice\u003e.json","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"}],"ansible/roles/trove/templates/trove-api.json.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_8433a761","line":11,"updated":"2016-11-09 20:17:57.000000000","message":"Please, add thefix for permission issue.\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/heat/templates/heat-api.json.j2#L11","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \"owner\": \"trove:trove\","},{"line_number":20,"context_line":"            \"recurse\": true"},{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":"    ]    "},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_ded451ed","line":22,"range":{"start_line":22,"start_character":5,"end_line":22,"end_character":9},"updated":"2016-11-10 21:28:08.000000000","message":"Please, remove blank characters","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \"owner\": \"trove:trove\","},{"line_number":20,"context_line":"            \"recurse\": true"},{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":"    ]    "},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_7a7dd5b0","line":22,"range":{"start_line":22,"start_character":5,"end_line":22,"end_character":9},"in_reply_to":"9a629dbe_ded451ed","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"ansible/roles/trove/templates/trove-conductor.conf.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6102ca9d69704193c778edb06be6187f9cf5d81f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"rpc_backend \u003d rabbit\r"},{"line_number":6,"context_line":"trove_auth_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3\r"},{"line_number":7,"context_line":"conductor_manager \u003d trove.conductor.manager.Manager\r"},{"line_number":8,"context_line":"\r"},{"line_number":9,"context_line":"control_exchange \u003d trove\r"},{"line_number":10,"context_line":"nova_proxy_admin_user\u003dtrove\r"},{"line_number":11,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}\r"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_0f78928e","line":8,"updated":"2016-08-22 17:33:02.000000000","message":"Missing keystone_auth? Is not necessary?","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"48e3ee1e5d1fada5373339c11e63359ad1e0a6ee","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[database]\r"},{"line_number":16,"context_line":"connection \u003d mysql+pymysql://{{ trove_database_user }}:{{ trove_database_password }}@{{ trove_database_address }}/{{ trove_database_name }}\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"[oslo_messaging_rabbit]\r"},{"line_number":19,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}\r"},{"line_number":20,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}\r"},{"line_number":21,"context_line":"rabbit_ha_queues \u003d true\r"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa7ab95a_3b1e62bb","line":18,"updated":"2016-09-02 06:28:05.000000000","message":"Please use transport_url for rabbitmq configuration\n\n\u003e\u003e https://review.openstack.org/#/c/356449/3","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\r"},{"line_number":4,"context_line":"log_dir \u003d /var/log/kolla/trove\r"},{"line_number":5,"context_line":"rpc_backend \u003d rabbit\r"},{"line_number":6,"context_line":"trove_auth_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3\r"},{"line_number":7,"context_line":"conductor_manager \u003d trove.conductor.manager.Manager\r"},{"line_number":8,"context_line":"\r"},{"line_number":9,"context_line":"control_exchange \u003d trove\r"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_641933d7","line":6,"range":{"start_line":6,"start_character":89,"end_line":6,"end_character":92},"updated":"2016-11-09 20:17:57.000000000","message":"Same for port in defaults/main.yml","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"conductor_manager \u003d trove.conductor.manager.Manager\r"},{"line_number":8,"context_line":"\r"},{"line_number":9,"context_line":"control_exchange \u003d trove\r"},{"line_number":10,"context_line":"nova_proxy_admin_user\u003dtrove\r"},{"line_number":11,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}\r"},{"line_number":12,"context_line":"nova_proxy_admin_tenant_name \u003d services\r"},{"line_number":13,"context_line":"nova_proxy_admin_user \u003d trove\r"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_041f97b7","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":22},"updated":"2016-11-09 20:17:57.000000000","message":"Add spaces before and after \u003d","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":19,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}\r"},{"line_number":20,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}\r"},{"line_number":21,"context_line":"rabbit_ha_queues \u003d true\r"},{"line_number":22,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_2451fbd8","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":12},"updated":"2016-11-09 20:17:57.000000000","message":"please, use transport_url for rabbit connection, also, gates are failing because the %for% is trailing newline.","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\r"},{"line_number":10,"context_line":"control_exchange \u003d trove\r"},{"line_number":11,"context_line":"nova_proxy_admin_user \u003d trove\r"},{"line_number":12,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}\r"},{"line_number":13,"context_line":"nova_proxy_admin_tenant_name \u003d services\r"},{"line_number":14,"context_line":"nova_proxy_admin_user \u003d trove\r"},{"line_number":15,"context_line":"\r"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_fe3d952b","line":12,"range":{"start_line":12,"start_character":27,"end_line":12,"end_character":52},"updated":"2016-11-10 21:28:08.000000000","message":"This password is the same as troves\u0027s keystone password","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\r"},{"line_number":10,"context_line":"control_exchange \u003d trove\r"},{"line_number":11,"context_line":"nova_proxy_admin_user \u003d trove\r"},{"line_number":12,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}\r"},{"line_number":13,"context_line":"nova_proxy_admin_tenant_name \u003d services\r"},{"line_number":14,"context_line":"nova_proxy_admin_user \u003d trove\r"},{"line_number":15,"context_line":"\r"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_9a48e98c","line":12,"range":{"start_line":12,"start_character":27,"end_line":12,"end_character":52},"in_reply_to":"9a629dbe_fe3d952b","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\r"},{"line_number":29,"context_line":"memcache_security_strategy \u003d ENCRYPT\r"},{"line_number":30,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}\r"},{"line_number":31,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\r"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_be5cfd7d","line":31,"updated":"2016-11-10 21:28:08.000000000","message":"Probably this will fail to render because the %for% will trail a line which does not exists. Can you check it? In the case i\u0027m correct, adding a new line is good.","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\r"},{"line_number":29,"context_line":"memcache_security_strategy \u003d ENCRYPT\r"},{"line_number":30,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}\r"},{"line_number":31,"context_line":"memcached_servers \u003d {% for host in groups[\u0027memcached\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ memcached_port }}{% if not loop.last %},{% endif %}{% endfor %}\r"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_ba4dad9b","line":31,"in_reply_to":"9a629dbe_be5cfd7d","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"ansible/roles/trove/templates/trove-conductor.json.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_2473bb16","line":11,"updated":"2016-11-09 20:17:57.000000000","message":"Same as api.json, permission issue","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/trove/trove-conductor.conf\","},{"line_number":7,"context_line":"            \"owner\": \"trove\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"},{"line_number":11,"context_line":"    \"permissions\": ["},{"line_number":12,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_9ee739ab","line":9,"updated":"2016-11-10 21:28:08.000000000","message":"trove.conf is also copied to taskmanager according to config.yml","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/trove/trove-conductor.conf\","},{"line_number":7,"context_line":"            \"owner\": \"trove\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"},{"line_number":11,"context_line":"    \"permissions\": ["},{"line_number":12,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_da426168","line":9,"in_reply_to":"9a629dbe_9ee739ab","updated":"2016-11-13 10:32:10.000000000","message":"i fix it now","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \"recurse\": true"},{"line_number":16,"context_line":"        },"},{"line_number":17,"context_line":"        {"},{"line_number":18,"context_line":"            \"path\": \"/var/lib/trove\","},{"line_number":19,"context_line":"            \"owner\": \"trove:trove\","},{"line_number":20,"context_line":"            \"recurse\": true"},{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":"    ]"},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_1efc093d","line":20,"range":{"start_line":18,"start_character":4,"end_line":20,"end_character":27},"updated":"2016-11-10 21:28:08.000000000","message":"Volume not mounted into taskmanager container","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            \"recurse\": true"},{"line_number":16,"context_line":"        },"},{"line_number":17,"context_line":"        {"},{"line_number":18,"context_line":"            \"path\": \"/var/lib/trove\","},{"line_number":19,"context_line":"            \"owner\": \"trove:trove\","},{"line_number":20,"context_line":"            \"recurse\": true"},{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":"    ]"},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_fa472575","line":20,"range":{"start_line":18,"start_character":4,"end_line":20,"end_character":27},"in_reply_to":"9a629dbe_1efc093d","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"ansible/roles/trove/templates/trove-taskmanager.conf.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6102ca9d69704193c778edb06be6187f9cf5d81f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"guest_config \u003d /etc/trove/trove-guestagent.conf"},{"line_number":31,"context_line":"nova_proxy_admin_tenant_name\u003dservices"},{"line_number":32,"context_line":"use_syslog\u003dFalse"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[database]"},{"line_number":35,"context_line":"connection \u003d mysql+pymysql://{{ trove_database_user }}:{{ trove_database_password }}@{{ trove_database_address }}/{{ trove_database_name }}"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_6f7dc66d","line":33,"updated":"2016-08-22 17:33:02.000000000","message":"Missing keystone config?","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":10,"context_line":"trove_auth_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"trove_volume_support \u003d True"},{"line_number":13,"context_line":"block_device_mapping \u003d vdb"},{"line_number":14,"context_line":"device_path \u003d /dev/vdb"},{"line_number":15,"context_line":"mount_point \u003d /var/lib/mysql"},{"line_number":16,"context_line":"volume_time_out\u003d30"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_c4567f5b","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":26},"updated":"2016-11-09 20:17:57.000000000","message":"Hardcoded device?","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"trove_volume_support \u003d True"},{"line_number":13,"context_line":"block_device_mapping \u003d vdb"},{"line_number":14,"context_line":"device_path \u003d /dev/vdb"},{"line_number":15,"context_line":"mount_point \u003d /var/lib/mysql"},{"line_number":16,"context_line":"volume_time_out\u003d30"},{"line_number":17,"context_line":"server_delete_time_out\u003d480"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_44626f3f","line":14,"range":{"start_line":14,"start_character":14,"end_line":14,"end_character":22},"updated":"2016-11-09 20:17:57.000000000","message":"Hardcoded device?","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":13,"context_line":"block_device_mapping \u003d vdb"},{"line_number":14,"context_line":"device_path \u003d /dev/vdb"},{"line_number":15,"context_line":"mount_point \u003d /var/lib/mysql"},{"line_number":16,"context_line":"volume_time_out\u003d30"},{"line_number":17,"context_line":"server_delete_time_out\u003d480"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}"},{"line_number":20,"context_line":"nova_proxy_admin_tenant_name \u003d services"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_a4eb4b77","line":17,"range":{"start_line":16,"start_character":15,"end_line":17,"end_character":26},"updated":"2016-11-09 20:17:57.000000000","message":"spaces before/after \u003d","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":28,"context_line":"network_label_regex \u003d .*"},{"line_number":29,"context_line":"template_path \u003d /etc/trove/templates/"},{"line_number":30,"context_line":"guest_config \u003d /etc/trove/trove-guestagent.conf"},{"line_number":31,"context_line":"nova_proxy_admin_tenant_name\u003dservices"},{"line_number":32,"context_line":"use_syslog\u003dFalse"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[database]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_04fb1748","line":31,"range":{"start_line":31,"start_character":28,"end_line":31,"end_character":29},"updated":"2016-11-09 20:17:57.000000000","message":"ditto","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":29,"context_line":"template_path \u003d /etc/trove/templates/"},{"line_number":30,"context_line":"guest_config \u003d /etc/trove/trove-guestagent.conf"},{"line_number":31,"context_line":"nova_proxy_admin_tenant_name\u003dservices"},{"line_number":32,"context_line":"use_syslog\u003dFalse"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[database]"},{"line_number":35,"context_line":"connection \u003d mysql+pymysql://{{ trove_database_user }}:{{ trove_database_password }}@{{ trove_database_address }}/{{ trove_database_name }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_24f81b49","line":32,"range":{"start_line":32,"start_character":10,"end_line":32,"end_character":11},"updated":"2016-11-09 20:17:57.000000000","message":"ditto","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":34,"context_line":"[database]"},{"line_number":35,"context_line":"connection \u003d mysql+pymysql://{{ trove_database_user }}:{{ trove_database_password }}@{{ trove_database_address }}/{{ trove_database_name }}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[oslo_messaging_rabbit]"},{"line_number":38,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":39,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":40,"context_line":"rabbit_ha_queues \u003d true"},{"line_number":41,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[mysql]"},{"line_number":44,"context_line":"tcp_ports \u003d 3306"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_4497cfeb","line":41,"range":{"start_line":37,"start_character":0,"end_line":41,"end_character":202},"updated":"2016-11-09 20:17:57.000000000","message":"use transport_url","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"block_device_mapping \u003d vdb"},{"line_number":13,"context_line":"device_path \u003d /dev/vdb"},{"line_number":14,"context_line":"mount_point \u003d /var/lib/mysql"},{"line_number":15,"context_line":"volume_time_out\u003d30"},{"line_number":16,"context_line":"server_delete_time_out\u003d480"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}"},{"line_number":19,"context_line":"nova_proxy_admin_tenant_name \u003d services"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_fe8755b2","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":26},"updated":"2016-11-10 21:28:08.000000000","message":"Add spaces between \u003d","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"block_device_mapping \u003d vdb"},{"line_number":13,"context_line":"device_path \u003d /dev/vdb"},{"line_number":14,"context_line":"mount_point \u003d /var/lib/mysql"},{"line_number":15,"context_line":"volume_time_out\u003d30"},{"line_number":16,"context_line":"server_delete_time_out\u003d480"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}"},{"line_number":19,"context_line":"nova_proxy_admin_tenant_name \u003d services"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_3a5a7d51","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":26},"in_reply_to":"9a629dbe_fe8755b2","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"volume_time_out\u003d30"},{"line_number":16,"context_line":"server_delete_time_out\u003d480"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}"},{"line_number":19,"context_line":"nova_proxy_admin_tenant_name \u003d services"},{"line_number":20,"context_line":"nova_proxy_admin_user \u003d trove"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_7ec265ea","line":18,"range":{"start_line":18,"start_character":27,"end_line":18,"end_character":52},"updated":"2016-11-10 21:28:08.000000000","message":"trove\u0027s password","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"volume_time_out\u003d30"},{"line_number":16,"context_line":"server_delete_time_out\u003d480"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}"},{"line_number":19,"context_line":"nova_proxy_admin_tenant_name \u003d services"},{"line_number":20,"context_line":"nova_proxy_admin_user \u003d trove"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_7a54f520","line":18,"range":{"start_line":18,"start_character":27,"end_line":18,"end_character":52},"in_reply_to":"9a629dbe_7ec265ea","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"network_label_regex \u003d .*"},{"line_number":28,"context_line":"template_path \u003d /etc/trove/templates/"},{"line_number":29,"context_line":"guest_config \u003d /etc/trove/trove-guestagent.conf"},{"line_number":30,"context_line":"nova_proxy_admin_tenant_name\u003dservices"},{"line_number":31,"context_line":"use_syslog\u003dFalse"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"transport_url \u003d rabbit://{% for host in groups[\u0027rabbitmq\u0027] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_7e6985f8","line":31,"range":{"start_line":30,"start_character":28,"end_line":31,"end_character":16},"updated":"2016-11-10 21:28:08.000000000","message":"spaces","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"network_label_regex \u003d .*"},{"line_number":28,"context_line":"template_path \u003d /etc/trove/templates/"},{"line_number":29,"context_line":"guest_config \u003d /etc/trove/trove-guestagent.conf"},{"line_number":30,"context_line":"nova_proxy_admin_tenant_name\u003dservices"},{"line_number":31,"context_line":"use_syslog\u003dFalse"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"transport_url \u003d rabbit://{% for host in groups[\u0027rabbitmq\u0027] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_9a2f09a7","line":31,"range":{"start_line":30,"start_character":28,"end_line":31,"end_character":16},"in_reply_to":"9a629dbe_7e6985f8","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"ansible/roles/trove/templates/trove-taskmanager.json.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_646a13f0","line":11,"updated":"2016-11-09 20:17:57.000000000","message":"Apply permission issue too","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/trove/trove-taskmanager.conf\","},{"line_number":7,"context_line":"            \"owner\": \"trove\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"},{"line_number":11,"context_line":"    \"permissions\": ["},{"line_number":12,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_de61b106","line":9,"updated":"2016-11-10 21:28:08.000000000","message":"trove.conf is copied to taskmanager too.","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"ansible/roles/trove/templates/trove.conf.j2":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"f7a58d066d4ad019b62072721a7ede1e1c6dd7ea","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[mysql]"},{"line_number":44,"context_line":"root_on_create \u003d False"},{"line_number":45,"context_line":"tcp_ports \u003d 3306"},{"line_number":46,"context_line":"volume_support \u003d True"},{"line_number":47,"context_line":"device_path \u003d /dev/vdb"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_715471c9","line":45,"updated":"2016-08-23 04:24:33.000000000","message":"This should be a configurable variable. Default values can be added in trove/defaults/main.yml","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"6102ca9d69704193c778edb06be6187f9cf5d81f","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"[keystone_authtoken]"},{"line_number":84,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":85,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":86,"context_line":"memcached_servers \u003d {{ kolla_internal_fqdn }}:{{ memcached_port }}"},{"line_number":87,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":88,"context_line":"project_domain_name \u003d Default"},{"line_number":89,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_4f5c4aed","line":86,"range":{"start_line":84,"start_character":0,"end_line":86,"end_character":66},"updated":"2016-08-22 17:33:02.000000000","message":"Other services put memcache after auth info, move it there to keep an standard between templates","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":12,"context_line":"trove_auth_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}/v3"},{"line_number":13,"context_line":"{% if enable_nova | bool %}"},{"line_number":14,"context_line":"nova_compute_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ nova_api_port }}/v2"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":"{% if enable_cinder | bool %}"},{"line_number":17,"context_line":"cinder_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ cinder_api_port }}/v2"},{"line_number":18,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_a447cb75","line":15,"updated":"2016-11-09 20:17:57.000000000","message":"add newlines after every endif, otherwise it will trail the line causing errors","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":"{% if enable_cinder | bool %}"},{"line_number":17,"context_line":"cinder_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ cinder_api_port }}/v2"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"{% if enable_swift | bool %}"},{"line_number":20,"context_line":"swift_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ swift_api_port }}/v1"},{"line_number":21,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_c4603f04","line":18,"range":{"start_line":18,"start_character":3,"end_line":18,"end_character":8},"updated":"2016-11-09 20:17:57.000000000","message":"ditto","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"network_label_regex \u003d .*"},{"line_number":24,"context_line":"trove_volume_support \u003d True"},{"line_number":25,"context_line":"block_device_mapping \u003d vdb"},{"line_number":26,"context_line":"device_path \u003d /dev/vdb"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"trove_dns_support \u003d False"},{"line_number":29,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_242bbb95","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":22},"updated":"2016-11-09 20:17:57.000000000","message":"Hardcoded devices? Are this devices the disks trove will create at the instances or are used by the host? if are for the instances i\u0027m OK as they are but if are for the host need to be a variable","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"[keystone_authtoken]"},{"line_number":84,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":85,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":86,"context_line":"memcached_servers \u003d {{ kolla_internal_fqdn }}:{{ memcached_port }}"},{"line_number":87,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":88,"context_line":"project_domain_name \u003d Default"},{"line_number":89,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_9f0cce3c","line":86,"range":{"start_line":84,"start_character":0,"end_line":86,"end_character":66},"updated":"2016-11-09 20:17:57.000000000","message":"Wrong memcached configuration, also move it after auth configuration.\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/heat/templates/heat.conf.j2#L51","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":93,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v3"},{"line_number":94,"context_line":"auth_type \u003d password"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"[oslo_messaging_rabbit]"},{"line_number":97,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":98,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":99,"context_line":"rabbit_ha_queues \u003d true"},{"line_number":100,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[service_credentials]"},{"line_number":103,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_df12c656","line":100,"range":{"start_line":96,"start_character":1,"end_line":100,"end_character":11},"updated":"2016-11-09 20:17:57.000000000","message":"use transport_url","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":100,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[service_credentials]"},{"line_number":103,"context_line":"auth_url \u003d {{ internal_protocol  }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":104,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":105,"context_line":"password \u003d {{ trove_keystone_password }}"},{"line_number":106,"context_line":"username \u003d {{ trove_keystone_user }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a629dbe_1f30bee7","line":103,"range":{"start_line":103,"start_character":67,"end_line":103,"end_character":87},"updated":"2016-11-09 20:17:57.000000000","message":"This connection is internal or public? my guess is that is internal API","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"rpc_backend \u003d rabbit"},{"line_number":6,"context_line":"port \u003d {{ trove_api_port }}"},{"line_number":7,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":8,"context_line":"trove_api_workers \u003d {{ trove_api_workers }}"},{"line_number":9,"context_line":"auth_strategy \u003d keystone"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"transport_url \u003d rabbit://{% for host in groups[\u0027rabbitmq\u0027] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_5e34c1fa","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":40},"updated":"2016-11-10 21:28:08.000000000","message":"can use openstack workers variable.","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"rpc_backend \u003d rabbit"},{"line_number":6,"context_line":"port \u003d {{ trove_api_port }}"},{"line_number":7,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":8,"context_line":"trove_api_workers \u003d {{ trove_api_workers }}"},{"line_number":9,"context_line":"auth_strategy \u003d keystone"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"transport_url \u003d rabbit://{% for host in groups[\u0027rabbitmq\u0027] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_fa3e45d9","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":40},"in_reply_to":"9a629dbe_5e34c1fa","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"db_api_implementation \u003d \"trove.db.sqlalchemy.api\""},{"line_number":14,"context_line":"trove_auth_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}"},{"line_number":15,"context_line":"{% if enable_nova | bool %}"},{"line_number":16,"context_line":"nova_compute_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ nova_api_port }}/v2"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"{% if enable_cinder | bool %}"},{"line_number":19,"context_line":"cinder_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ cinder_api_port }}/v2"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"{% if enable_swift | bool %}"},{"line_number":22,"context_line":"swift_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ swift_api_port }}/v1"},{"line_number":23,"context_line":"{% endif %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"network_label_regex \u003d .*"},{"line_number":26,"context_line":"trove_volume_support \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_5e1be180","line":23,"range":{"start_line":15,"start_character":0,"end_line":23,"end_character":11},"updated":"2016-11-10 21:28:08.000000000","message":"Add newline between every if","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"db_api_implementation \u003d \"trove.db.sqlalchemy.api\""},{"line_number":14,"context_line":"trove_auth_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ trove_api_port }}"},{"line_number":15,"context_line":"{% if enable_nova | bool %}"},{"line_number":16,"context_line":"nova_compute_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ nova_api_port }}/v2"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"{% if enable_cinder | bool %}"},{"line_number":19,"context_line":"cinder_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ cinder_api_port }}/v2"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"{% if enable_swift | bool %}"},{"line_number":22,"context_line":"swift_url \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ swift_api_port }}/v1"},{"line_number":23,"context_line":"{% endif %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"network_label_regex \u003d .*"},{"line_number":26,"context_line":"trove_volume_support \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_ba34cdfb","line":23,"range":{"start_line":15,"start_character":0,"end_line":23,"end_character":11},"in_reply_to":"9a629dbe_5e1be180","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"device_path \u003d /dev/vdb"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"trove_dns_support \u003d False"},{"line_number":31,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}"},{"line_number":32,"context_line":"nova_proxy_admin_tenant_name \u003d services"},{"line_number":33,"context_line":"nova_proxy_admin_user \u003d trove"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_de0ff134","line":31,"range":{"start_line":31,"start_character":27,"end_line":31,"end_character":52},"updated":"2016-11-10 21:28:08.000000000","message":"trove user password","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"device_path \u003d /dev/vdb"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"trove_dns_support \u003d False"},{"line_number":31,"context_line":"nova_proxy_admin_pass \u003d {{ nova_proxy_admin_password }}"},{"line_number":32,"context_line":"nova_proxy_admin_tenant_name \u003d services"},{"line_number":33,"context_line":"nova_proxy_admin_user \u003d trove"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_da3981f4","line":31,"range":{"start_line":31,"start_character":27,"end_line":31,"end_character":52},"in_reply_to":"9a629dbe_de0ff134","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"api_strategy \u003d trove.common.strategies.cluster.experimental.vertica.api.VerticaAPIStrategy"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"[keystone_authtoken]"},{"line_number":85,"context_line":"memcache_security_strategy \u003d ENCRYPT"},{"line_number":86,"context_line":"memcache_secret_key \u003d {{ memcache_secret_key }}"},{"line_number":87,"context_line":"memcached_servers \u003d {{ kolla_internal_fqdn }}:{{ memcached_port }}"},{"line_number":88,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}/v3"},{"line_number":89,"context_line":"project_domain_name \u003d Default"},{"line_number":90,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a629dbe_09121557","line":87,"range":{"start_line":85,"start_character":0,"end_line":87,"end_character":66},"updated":"2016-11-10 21:28:08.000000000","message":"Move memcached config after auth configuration, also memcached servers is wrong. There is a list of memcached nodes\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/heat/templates/heat.conf.j2#L51","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"ansible/site.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4e390b55fbd5ec892e0dc5a1828ab92bb9fa1734","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    - trove-conductor"},{"line_number":259,"context_line":"    - trove-taskmanager"},{"line_number":260,"context_line":"    - rabbitmq"},{"line_number":261,"context_line":"    - memcached"},{"line_number":262,"context_line":"  roles:"},{"line_number":263,"context_line":"    - { role: trove,"},{"line_number":264,"context_line":"        tags: trove,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5da102_cf919a54","line":261,"updated":"2016-11-06 05:47:45.000000000","message":"remove rabbitmq and memcached.","commit_id":"34011eba62f999b7bbcd04e38471a23b98b0f6c9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    - trove-api"},{"line_number":355,"context_line":"    - trove-conductor"},{"line_number":356,"context_line":"    - trove-taskmanager"},{"line_number":357,"context_line":"    - rabbitmq"},{"line_number":358,"context_line":"    - memcached"},{"line_number":359,"context_line":"  roles:"},{"line_number":360,"context_line":"    - { role: trove,"},{"line_number":361,"context_line":"        tags: trove,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_bfb19249","line":358,"range":{"start_line":357,"start_character":0,"end_line":358,"end_character":15},"updated":"2016-11-09 20:17:57.000000000","message":"Please, remove rabbit and memached.","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    - trove-api"},{"line_number":355,"context_line":"    - trove-conductor"},{"line_number":356,"context_line":"    - trove-taskmanager"},{"line_number":357,"context_line":"  serial: \u0027{{ serial|default(\"0\") }}\u0027 "},{"line_number":358,"context_line":"  roles:"},{"line_number":359,"context_line":"    - { role: trove,"},{"line_number":360,"context_line":"        tags: trove,"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a629dbe_89a1c5fa","line":357,"range":{"start_line":357,"start_character":37,"end_line":357,"end_character":38},"updated":"2016-11-10 21:28:08.000000000","message":"Please, remove whitespace","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    - trove-api"},{"line_number":355,"context_line":"    - trove-conductor"},{"line_number":356,"context_line":"    - trove-taskmanager"},{"line_number":357,"context_line":"  serial: \u0027{{ serial|default(\"0\") }}\u0027 "},{"line_number":358,"context_line":"  roles:"},{"line_number":359,"context_line":"    - { role: trove,"},{"line_number":360,"context_line":"        tags: trove,"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a629dbe_1a24d9c4","line":357,"range":{"start_line":357,"start_character":37,"end_line":357,"end_character":38},"in_reply_to":"9a629dbe_89a1c5fa","updated":"2016-11-13 10:32:10.000000000","message":"done","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}],"etc/kolla/passwords.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a856454343adeaaf6eebabbc5569228cd818a2ad","unresolved":false,"context_lines":[{"line_number":123,"context_line":"####################"},{"line_number":124,"context_line":"# Gnocchi options"},{"line_number":125,"context_line":"####################"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"gnocchi_user_id:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_5f895674","line":126,"updated":"2016-11-09 20:17:57.000000000","message":"Why remove it?","commit_id":"bafb89e879f2ba60b64602f14c7582fd9f51e7b9"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c50436ba5572adf82337e47796aa486c34a685e0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"####################"},{"line_number":136,"context_line":"## Trove options"},{"line_number":137,"context_line":"#####################"},{"line_number":138,"context_line":"nova_proxy_admin_password:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"####################"},{"line_number":141,"context_line":"# HAProxy options"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a629dbe_69d39160","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":26},"updated":"2016-11-10 21:28:08.000000000","message":"In someplaces is used trove_keystone_password and in other nova_proxy_admin_password.\nAs long I can see, is the same password, both for trove user.\n\nPlease unify both in trove_keystone_password and add it at line 104. This section is not necessary and other services password are there","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"249de4770f879f83524c6c347a2ec4a0283f541d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"####################"},{"line_number":136,"context_line":"## Trove options"},{"line_number":137,"context_line":"#####################"},{"line_number":138,"context_line":"nova_proxy_admin_password:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"####################"},{"line_number":141,"context_line":"# HAProxy options"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a629dbe_3a219db5","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":26},"in_reply_to":"9a629dbe_69d39160","updated":"2016-11-13 10:32:10.000000000","message":"fix it now","commit_id":"d269cfe54ab9d53b6c21517c064e8952d2d3e18f"}]}