)]}'
{"ansible/roles/horizon/templates/local_settings.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"b86ed54e535ff8de2ffab7d6faf6bcc528b35d7c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# If Horizon is being served through SSL, then uncomment the following two"},{"line_number":40,"context_line":"# settings to better secure the cookies from security exploits"},{"line_number":41,"context_line":"#CSRF_COOKIE_SECURE \u003d True"},{"line_number":42,"context_line":"#SESSION_COOKIE_SECURE \u003d True"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The absolute path to the directory where message files are collected."},{"line_number":45,"context_line":"# The message file must have a .json file extension. When the user logins to"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3ac371cc_d5f7d1d0","line":42,"updated":"2016-08-18 08:24:42.000000000","message":"Why is it not longer necessary to set those parameter when kolla_enable_tls_external is true?","commit_id":"9e01d5539589ebab63c404eea737f380d6a2acc8"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7a94eac963636645219f3e7c261fa62aa3c5c5f1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# If Horizon is being served through SSL, then uncomment the following two"},{"line_number":40,"context_line":"# settings to better secure the cookies from security exploits"},{"line_number":41,"context_line":"#CSRF_COOKIE_SECURE \u003d True"},{"line_number":42,"context_line":"#SESSION_COOKIE_SECURE \u003d True"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The absolute path to the directory where message files are collected."},{"line_number":45,"context_line":"# The message file must have a .json file extension. When the user logins to"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3ac371cc_38f29c9a","line":42,"updated":"2016-08-18 08:44:42.000000000","message":"thanks for pointing this. It is my fault. will fix this in next PS.","commit_id":"9e01d5539589ebab63c404eea737f380d6a2acc8"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4e52a96b9df9819cdcbe319cba0e2ef649e28c67","unresolved":false,"context_lines":[{"line_number":173,"context_line":"#    (\u0027http://cluster2.example.com:5000/v2.0\u0027, \u0027cluster2\u0027),"},{"line_number":174,"context_line":"#]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"OPENSTACK_HOST \u003d \"{{ kolla_external_address }}\""},{"line_number":177,"context_line":"OPENSTACK_KEYSTONE_URL \u003d \"{{ public_protocol }}://%s:{{ keystone_public_port }}/v3\" % OPENSTACK_HOST"},{"line_number":178,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_ROLE \u003d \"_member_\""},{"line_number":179,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3ac371cc_4ebcf2ba","line":176,"updated":"2016-08-18 09:13:42.000000000","message":"I think this is also wrong. Why should Horizon use the external API services and not the internal API services?","commit_id":"1c242657e561fe5f3fd73dfad42da4b3e839b318"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"db6e2be48fbd815d9f5ef0f6ebfde73ecb4cde1d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"#    (\u0027http://cluster2.example.com:5000/v2.0\u0027, \u0027cluster2\u0027),"},{"line_number":174,"context_line":"#]"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"OPENSTACK_HOST \u003d \"{{ kolla_external_address }}\""},{"line_number":177,"context_line":"OPENSTACK_KEYSTONE_URL \u003d \"{{ public_protocol }}://%s:{{ keystone_public_port }}/v3\" % OPENSTACK_HOST"},{"line_number":178,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_ROLE \u003d \"_member_\""},{"line_number":179,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3ac371cc_baae7c2b","line":176,"updated":"2016-08-18 10:15:00.000000000","message":"thanks. will fix in following PS.","commit_id":"1c242657e561fe5f3fd73dfad42da4b3e839b318"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4595aa2eb60a5f28857a3732c91dd3acdbdbe9b6","unresolved":false,"context_lines":[{"line_number":381,"context_line":"# OPENSTACK_ENDPOINT_TYPE specifies the endpoint type to use for the endpoints"},{"line_number":382,"context_line":"# in the Keystone service catalog. Use this setting when Horizon is running"},{"line_number":383,"context_line":"# external to the OpenStack environment. The default is \u0027publicURL\u0027."},{"line_number":384,"context_line":"#OPENSTACK_ENDPOINT_TYPE \u003d \"publicURL\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"# SECONDARY_ENDPOINT_TYPE specifies the fallback endpoint type to use in the"},{"line_number":387,"context_line":"# case that OPENSTACK_ENDPOINT_TYPE is not present in the endpoints"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3ac371cc_abca716c","line":384,"updated":"2016-08-19 07:17:55.000000000","message":"I will revert his. we shoud fix this in another PS if this really need fix.","commit_id":"bdbcad7b0316231b70b72409b65017d58de5d609"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"81ec71c8ce3afcb0eb94cd5fdea8d3a5611b9b5b","unresolved":false,"context_lines":[{"line_number":381,"context_line":"# OPENSTACK_ENDPOINT_TYPE specifies the endpoint type to use for the endpoints"},{"line_number":382,"context_line":"# in the Keystone service catalog. Use this setting when Horizon is running"},{"line_number":383,"context_line":"# external to the OpenStack environment. The default is \u0027publicURL\u0027."},{"line_number":384,"context_line":"#OPENSTACK_ENDPOINT_TYPE \u003d \"publicURL\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"# SECONDARY_ENDPOINT_TYPE specifies the fallback endpoint type to use in the"},{"line_number":387,"context_line":"# case that OPENSTACK_ENDPOINT_TYPE is not present in the endpoints"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3ac371cc_b6d5e9e5","line":384,"updated":"2016-08-18 13:23:11.000000000","message":"Should we change this?","commit_id":"bdbcad7b0316231b70b72409b65017d58de5d609"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"688fefc231f7a36684b152579850819c8e5fd571","unresolved":false,"context_lines":[{"line_number":381,"context_line":"# OPENSTACK_ENDPOINT_TYPE specifies the endpoint type to use for the endpoints"},{"line_number":382,"context_line":"# in the Keystone service catalog. Use this setting when Horizon is running"},{"line_number":383,"context_line":"# external to the OpenStack environment. The default is \u0027publicURL\u0027."},{"line_number":384,"context_line":"#OPENSTACK_ENDPOINT_TYPE \u003d \"publicURL\""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"# SECONDARY_ENDPOINT_TYPE specifies the fallback endpoint type to use in the"},{"line_number":387,"context_line":"# case that OPENSTACK_ENDPOINT_TYPE is not present in the endpoints"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3ac371cc_c068718a","line":384,"in_reply_to":"3ac371cc_b6d5e9e5","updated":"2016-08-19 02:26:47.000000000","message":"Paul,\n\nMy take is yes, internalURL is wrong.  It only ever worked because folks didn\u0027t have proper network isolation.  This specific change itself probably needs a backport but I am not certain.","commit_id":"bdbcad7b0316231b70b72409b65017d58de5d609"}]}