)]}'
{"ansible/roles/iscsi/tasks/start.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e9a62a624322015322d5ba2e91424df3fea042ab","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":40,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":41,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":42,"context_line":"  when: inventory_hostname in groups[\u0027tgtd\u0027] and enable_cinder_backend_lvm | bool"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ac06dbe_c43b6a9b","line":42,"updated":"2016-08-19 14:53:33.000000000","message":"when using multi and condition, following is better.\n\nwhen:\n  - condition 1\n  - condition 2","commit_id":"3a32caf47e0ccf0fe2eadb365f48e1308dc19492"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"16475b091f4b2cdcee4440508b952559c6db8a24","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":40,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":41,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":42,"context_line":"  when: inventory_hostname in groups[\u0027tgtd\u0027] and enable_cinder_backend_lvm | bool"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ac06dbe_4897e839","line":42,"in_reply_to":"1ac06dbe_c43b6a9b","updated":"2016-08-23 14:30:16.000000000","message":"thanks Jeffrey,\nin one of my next patchsets I am going to propose a removal of tgtd in favour of targetcli - there won\u0027t be any need for this container.","commit_id":"3a32caf47e0ccf0fe2eadb365f48e1308dc19492"}],"ansible/site.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e9a62a624322015322d5ba2e91424df3fea042ab","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  roles:"},{"line_number":60,"context_line":"    - { role: iscsi,"},{"line_number":61,"context_line":"        tags: iscsi,"},{"line_number":62,"context_line":"        when: enable_iscsid | bool }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- hosts:"},{"line_number":65,"context_line":"    - multipathd"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ac06dbe_e43666b3","line":62,"updated":"2016-08-19 14:53:33.000000000","message":"this seems not right.\n\nThe when condition should be:\n\nwhen:\n  - enabled_iscsid | bool\n  - enable_cinder_backend_lvm | bool","commit_id":"3a32caf47e0ccf0fe2eadb365f48e1308dc19492"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"16475b091f4b2cdcee4440508b952559c6db8a24","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  roles:"},{"line_number":60,"context_line":"    - { role: iscsi,"},{"line_number":61,"context_line":"        tags: iscsi,"},{"line_number":62,"context_line":"        when: enable_iscsid | bool }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- hosts:"},{"line_number":65,"context_line":"    - multipathd"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ac06dbe_48424869","line":62,"in_reply_to":"1ac06dbe_e43666b3","updated":"2016-08-23 14:30:16.000000000","message":"enable_cinder_backend_lvm will only work if enable_iscsid is used. In the role there is an \"if\" check specially for tgtd. Here we want iscsid running disregarding volume backend. Probably combining both client iscsi and target backend is not good idea here. tgtd should go away eventually - targetcli and kernel based iscsi targets can and should remove need for this container.","commit_id":"3a32caf47e0ccf0fe2eadb365f48e1308dc19492"}]}