)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"460b95360ec8482cdbbc725ab4dc907d0e663688","unresolved":false,"context_lines":[{"line_number":231,"context_line":"enable_multipathd: \"no\""},{"line_number":232,"context_line":"enable_murano: \"no\""},{"line_number":233,"context_line":"enable_neutron_lbaas: \"no\""},{"line_number":234,"context_line":"enable_neutron_qos: \"no\""},{"line_number":235,"context_line":"enable_swift: \"no\""},{"line_number":236,"context_line":"enable_tempest: \"no\""},{"line_number":237,"context_line":"enable_watcher: \"no\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_e809f932","line":234,"updated":"2016-08-20 07:07:39.000000000","message":"I would add enable_neutron_dvr here.","commit_id":"b2c11f7bc1538b9ffd6284805152e08f8ed52110"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"eacce0e3bbe9f82ce9c1db1d8e27413fd910608b","unresolved":false,"context_lines":[{"line_number":231,"context_line":"enable_multipathd: \"no\""},{"line_number":232,"context_line":"enable_murano: \"no\""},{"line_number":233,"context_line":"enable_neutron_lbaas: \"no\""},{"line_number":234,"context_line":"enable_neutron_qos: \"no\""},{"line_number":235,"context_line":"enable_swift: \"no\""},{"line_number":236,"context_line":"enable_tempest: \"no\""},{"line_number":237,"context_line":"enable_watcher: \"no\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_9b5c837e","line":234,"in_reply_to":"1ac06dbe_e809f932","updated":"2016-08-23 15:03:32.000000000","message":"agree","commit_id":"b2c11f7bc1538b9ffd6284805152e08f8ed52110"}],"ansible/roles/neutron/tasks/do_reconfigure.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0086f4e24f9624a6ee0858ae9ef2ec69da8a35c2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    - { name: neutron_server, group: neutron-server }"},{"line_number":13,"context_line":"    - { name: neutron_dhcp_agent, group: neutron-dhcp-agent }"},{"line_number":14,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":15,"context_line":"    - { name: neutron_l3_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"},{"line_number":16,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":17,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":18,"context_line":"    - { name: neutron_metadata_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_5efd466d","line":15,"updated":"2016-08-31 14:06:20.000000000","message":"the enabled variable never be used.\ni think it should be added into when condition.","commit_id":"57d0c962e13ca5b2c1d5a347710fb144fb68a643"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"069c66fd99113006ffba86ea38bb071546497d0b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    - { name: neutron_server, group: neutron-server }"},{"line_number":13,"context_line":"    - { name: neutron_dhcp_agent, group: neutron-dhcp-agent }"},{"line_number":14,"context_line":"    - { name: neutron_l3_agent, group: neutron-l3-agent }"},{"line_number":15,"context_line":"    - { name: neutron_l3_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"},{"line_number":16,"context_line":"    - { name: neutron_lbaas_agent, group: neutron-lbaas-agent, enabled: \"{{ enable_neutron_lbaas | bool }}\" }"},{"line_number":17,"context_line":"    - { name: neutron_metadata_agent, group: neutron-metadata-agent }"},{"line_number":18,"context_line":"    - { name: neutron_metadata_agent, group: compute, enabled: \"{{ enable_neutron_dvr | bool }}\" }"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_00a3509f","line":15,"in_reply_to":"fa7ab95a_5efd466d","updated":"2016-08-31 15:53:43.000000000","message":"can you please clarify your question? \nwe already have item.enabled check in when clause","commit_id":"57d0c962e13ca5b2c1d5a347710fb144fb68a643"}],"ansible/roles/neutron/tasks/start.yml":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"230f7641865364209b65a41903f6f317ab42db3f","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":170,"context_line":"  when:"},{"line_number":171,"context_line":"    - (inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":172,"context_line":"       or (inventory_hostname in groups[\u0027compute\u0027] and enable_neutron_dvr | bool))"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"- name: Starting neutron-l3-agent container"},{"line_number":175,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ac06dbe_beed60b9","line":172,"updated":"2016-08-25 11:05:35.000000000","message":"I think it is not necessary to run the dhcp agents on all compute nodes when using DVR.","commit_id":"ed6af0215f85dd243a37bea8a29c56286cb42a23"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"8dac36952272eff6e8f112e5681a665177a4c9c0","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":170,"context_line":"  when:"},{"line_number":171,"context_line":"    - (inventory_hostname in groups[\u0027neutron-dhcp-agent\u0027]"},{"line_number":172,"context_line":"       or (inventory_hostname in groups[\u0027compute\u0027] and enable_neutron_dvr | bool))"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"- name: Starting neutron-l3-agent container"},{"line_number":175,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ac06dbe_7e07681d","line":172,"in_reply_to":"1ac06dbe_beed60b9","updated":"2016-08-25 11:14:39.000000000","message":"you are right, dhcp runs on controllers. Computes should only run l3 and meta agents","commit_id":"ed6af0215f85dd243a37bea8a29c56286cb42a23"}],"ansible/roles/neutron/templates/l3_agent.ini.j2":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"f332cfaaa1453cccf3daf94b6000efa961332653","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# l3_agent.ini"},{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"{% if enable_neutron_dvr | bool %}"},{"line_number":4,"context_line":"{% if inventory_hostname in groups[\u0027network\u0027] %}"},{"line_number":5,"context_line":"agent_mode \u003d dvr_snat"},{"line_number":6,"context_line":"{% else %}"},{"line_number":7,"context_line":"agent_mode \u003d dvr"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_6dd51b42","line":4,"updated":"2016-08-20 04:31:09.000000000","message":"Do you mind adding appropriate indent for the nested if? Thanks.","commit_id":"b2c11f7bc1538b9ffd6284805152e08f8ed52110"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0086f4e24f9624a6ee0858ae9ef2ec69da8a35c2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% if enable_neutron_dvr | bool %}"},{"line_number":4,"context_line":"    {% if inventory_hostname in groups[\u0027network\u0027] %}"},{"line_number":5,"context_line":"agent_mode \u003d dvr_snat"},{"line_number":6,"context_line":"    {% else %}"},{"line_number":7,"context_line":"agent_mode \u003d dvr"},{"line_number":8,"context_line":"    {% endif %}"},{"line_number":9,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa7ab95a_7e020a71","line":6,"updated":"2016-08-31 14:06:20.000000000","message":"please use {% elif inventory_hostname in groups[\u0027compute\u0027] %}","commit_id":"57d0c962e13ca5b2c1d5a347710fb144fb68a643"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0086f4e24f9624a6ee0858ae9ef2ec69da8a35c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa7ab95a_9ef7ce8b","line":13,"updated":"2016-08-31 14:06:20.000000000","message":"add \u0027\\n\u0027 add the last line","commit_id":"57d0c962e13ca5b2c1d5a347710fb144fb68a643"}],"ansible/roles/neutron/templates/ml2_conf.ini.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"460b95360ec8482cdbbc725ab4dc907d0e663688","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"{% if enable_neutron_dvr | bool %}"},{"line_number":54,"context_line":"enable_distributed_routing \u003d True"},{"line_number":55,"context_line":"l2_population \u003d True"},{"line_number":56,"context_line":"arp_responder \u003d True"},{"line_number":57,"context_line":"{% endif %}"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_7304da14","line":55,"updated":"2016-08-20 07:07:39.000000000","message":"Line 55 \u0026 56 is a duplicate of 50 \u0026 51.","commit_id":"b2c11f7bc1538b9ffd6284805152e08f8ed52110"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"eacce0e3bbe9f82ce9c1db1d8e27413fd910608b","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"{% if enable_neutron_dvr | bool %}"},{"line_number":54,"context_line":"enable_distributed_routing \u003d True"},{"line_number":55,"context_line":"l2_population \u003d True"},{"line_number":56,"context_line":"arp_responder \u003d True"},{"line_number":57,"context_line":"{% endif %}"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_9b3da3df","line":55,"in_reply_to":"1ac06dbe_7304da14","updated":"2016-08-23 15:03:32.000000000","message":"agree","commit_id":"b2c11f7bc1538b9ffd6284805152e08f8ed52110"}],"ansible/roles/neutron/templates/neutron.conf.j2":[{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"f6a137613abad062f2b7b9852c8a35f05230178e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_dvr | bool %}"},{"line_number":41,"context_line":"l3_ha \u003d True"},{"line_number":42,"context_line":"dhcp_agents_per_network \u003d 2"},{"line_number":43,"context_line":"router_distributed \u003d True"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":47,"context_line":"[service_providers]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3ac371cc_98c01e52","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":11},"updated":"2016-08-17 15:27:30.000000000","message":"Paul, this will not work if we have non-l3-ha neutron. I would rather introduce two flags - for l3-ha and for dvr. Both can work independently. For l3-ha we need 2+ controllers, for dvr we need external nic on compute nodes","commit_id":"b2c11f7bc1538b9ffd6284805152e08f8ed52110"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"460b95360ec8482cdbbc725ab4dc907d0e663688","unresolved":false,"context_lines":[{"line_number":37,"context_line":"core_plugin \u003d ml2"},{"line_number":38,"context_line":"service_plugins \u003d router{% if enable_neutron_lbaas | bool %},neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2{% endif %}{% if enable_neutron_qos | bool %},qos{% endif %}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"{% if enable_neutron_dvr | bool %}"},{"line_number":41,"context_line":"l3_ha \u003d True"},{"line_number":42,"context_line":"dhcp_agents_per_network \u003d 2"},{"line_number":43,"context_line":"router_distributed \u003d True"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% if enable_neutron_lbaas | bool %}"},{"line_number":47,"context_line":"[service_providers]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_9326b6b8","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":11},"in_reply_to":"3ac371cc_98c01e52","updated":"2016-08-20 07:07:39.000000000","message":"Makes sense to me. I should be possible to use L3 HA without enabling DVR.","commit_id":"b2c11f7bc1538b9ffd6284805152e08f8ed52110"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"1e719f179bffb7da61dd8c1a5f70f390dad13ea0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service_provider \u003d LOADBALANCERV2:Haproxy:neutron_lbaas.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default"},{"line_number":55,"context_line":"{% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"transport_url \u003d rabbit://{% for host in groups[\u0027rabbitmq\u0027] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{% if orchestration_engine \u003d\u003d \u0027KUBERNETES\u0027 %}rabbitmq{% else %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}{% endif %}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[nova]"},{"line_number":60,"context_line":"auth_url \u003d {{ keystone_admin_url }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"9a89bdaa_e8409e61","line":57,"updated":"2016-09-13 09:18:00.000000000","message":"transport url two times?","commit_id":"f447fc4d86a8f5bf8cd0d3fba45d0e7aeb69ef4d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"107e1ea15d02e40febb6281b875d424b13395255","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service_provider \u003d LOADBALANCERV2:Haproxy:neutron_lbaas.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default"},{"line_number":55,"context_line":"{% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"transport_url \u003d rabbit://{% for host in groups[\u0027rabbitmq\u0027] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{% if orchestration_engine \u003d\u003d \u0027KUBERNETES\u0027 %}rabbitmq{% else %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}{% endif %}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[nova]"},{"line_number":60,"context_line":"auth_url \u003d {{ keystone_admin_url }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7a8ec9b2_d503100e","line":57,"in_reply_to":"9a89bdaa_e8409e61","updated":"2016-09-14 02:45:43.000000000","message":"Done","commit_id":"f447fc4d86a8f5bf8cd0d3fba45d0e7aeb69ef4d"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"59a8730a0e2200943b1eb8d597da39447012e4ab","unresolved":false,"context_lines":[{"line_number":54,"context_line":"service_provider \u003d LOADBALANCERV2:Haproxy:neutron_lbaas.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default"},{"line_number":55,"context_line":"{% endif %}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"transport_url \u003d rabbit://{% for host in groups[\u0027rabbitmq\u0027] %}{{ rabbitmq_user }}:{{ rabbitmq_password }}@{% if orchestration_engine \u003d\u003d \u0027KUBERNETES\u0027 %}rabbitmq{% else %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}{% endif %}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[nova]"},{"line_number":60,"context_line":"auth_url \u003d {{ keystone_admin_url }}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"7a8ec9b2_1dfae842","line":57,"updated":"2016-09-14 11:54:33.000000000","message":"i think this should be removed :)","commit_id":"f6b9338f6a2484a79a12d1d4ccfd6ec18d38250f"}],"etc/kolla/globals.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0086f4e24f9624a6ee0858ae9ef2ec69da8a35c2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#neutron_plugin_agent: \"openvswitch\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Enable DVR (distributed virtual routing) in Neutron"},{"line_number":81,"context_line":"#enable_neutron_dvr: \"no\""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_3e088291","line":81,"updated":"2016-08-31 14:06:20.000000000","message":"why not move this into the enable_* list?","commit_id":"57d0c962e13ca5b2c1d5a347710fb144fb68a643"}]}