)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"d034dba3cf1b8abf32917d9aa95c9631e06c7640","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers \\"},{"line_number":262,"context_line":"    \u0026\u0026 groupadd kolla \\"},{"line_number":263,"context_line":"    \u0026\u0026 rm -f /tmp/kolla_bashrc \\"},{"line_number":264,"context_line":"    \u0026\u0026 curl -sSL https://github.com/Yelp/dumb-init/releases/download/v1.1.3/dumb-init_1.1.3_amd64 -o /usr/local/bin/dumb-init \\"},{"line_number":265,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/dumb-init"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3ac371cc_45cad66f","line":264,"range":{"start_line":264,"start_character":60,"end_line":264,"end_character":68},"updated":"2016-08-19 00:31:58.000000000","message":"Can we install this via pip, rather than curl+github?\n\n(Other alternatives in this space are pidunu and Tini)","commit_id":"61db561e6ce72ced5aa943ef53a2f541c0ccb99d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c7f77e3d42d58287849fc597fe7892d3c4122ea2","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers \\"},{"line_number":262,"context_line":"    \u0026\u0026 groupadd kolla \\"},{"line_number":263,"context_line":"    \u0026\u0026 rm -f /tmp/kolla_bashrc \\"},{"line_number":264,"context_line":"    \u0026\u0026 curl -sSL https://github.com/Yelp/dumb-init/releases/download/v1.1.3/dumb-init_1.1.3_amd64 -o /usr/local/bin/dumb-init \\"},{"line_number":265,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/dumb-init"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3ac371cc_933ed127","line":264,"updated":"2016-08-19 03:18:34.000000000","message":"Yes we can.\n\nBut \n\n1. there is no pip in base image. it is installed in the openstack-base\n2. the pip is installed in the source install only.\n3. different distro has different pip version when install through system package management\n\nAnd\n\n1. we install heka and rabbitmq from github directly, too.\n\nSo, do u still insist on doing this?\n\nthe alternatives seems the same, i choose the one(dumb-init) with most starts :)","commit_id":"61db561e6ce72ced5aa943ef53a2f541c0ccb99d"}],"docker/base/start.sh":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d719f5001141220740f58e11399bae636f139d04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/dumb-init /bin/bash"},{"line_number":2,"context_line":"set -o errexit"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Wait for the log socket"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3ac371cc_00d72924","line":1,"updated":"2016-08-19 02:30:05.000000000","message":"I was never really keen on having the python runtime run as PID1.  Can we find a C solution?\n\nThanks\n-steve","commit_id":"61db561e6ce72ced5aa943ef53a2f541c0ccb99d"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c7f77e3d42d58287849fc597fe7892d3c4122ea2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/local/bin/dumb-init /bin/bash"},{"line_number":2,"context_line":"set -o errexit"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Wait for the log socket"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3ac371cc_733b5539","line":1,"updated":"2016-08-19 03:18:34.000000000","message":"dumb-init is a C program. Even though it can be installed through pip\n\n[0] https://github.com/Yelp/dumb-init/blob/master/dumb-init.c","commit_id":"61db561e6ce72ced5aa943ef53a2f541c0ccb99d"}]}
