)]}'
{"docker/neutron/neutron-openvswitch-agent/start_neutron_ovs_agent.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"6d36e38f91d53ed9021e52a064080bd18dda0e02","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"orchestration\u003d$1"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ ! -e $orchestration ]; then"},{"line_number":6,"context_line":"# NOTE: (sbezverk) This part is executed only by kubernetes deployment,"},{"line_number":7,"context_line":"# it modifies ml2_conf.ini with correct ip address of compute node where"},{"line_number":8,"context_line":"# neutron-openvswitch-agent runs."}],"source_content_type":"text/x-sh","patch_set":1,"id":"3ac371cc_d36b2984","line":5,"updated":"2016-08-19 03:13:45.000000000","message":"please use the specific condition. i.e.\n\nif [[ $orchestration \u003d\u003d kubernetes ]]; then","commit_id":"4dde6d12b58ee6463abbaaf3f8413bf809f3e694"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"6d36e38f91d53ed9021e52a064080bd18dda0e02","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# neutron-openvswitch-agent runs."},{"line_number":9,"context_line":"    ip\u003d$(hostname -i)"},{"line_number":10,"context_line":"    sed -i \u0027s|^ovsdb_connection.*\u003d.*|ovsdb_connection\u003dtcp:\u0027$ip\u0027:6640|g\u0027 /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":11,"context_line":"    sed -i \u0027s|^local_ip.*\u003d.*|local_ip\u003d\u0027$ip\u0027|g\u0027 /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":12,"context_line":"    neutron-openvswitch-agent --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":13,"context_line":"else"},{"line_number":14,"context_line":"# NOTE: (sbezverk) This part is executed only by kolla-ansible deployment."}],"source_content_type":"text/x-sh","patch_set":1,"id":"3ac371cc_b3edcdf1","line":11,"updated":"2016-08-19 03:13:45.000000000","message":"no idea how the kolla-kube generate the config files. isn\u0027t it can generate the config differently on each node/PetSet? Or share the same configuration file in all nodes?\n\nbeside, there are more work to do. the neutron-server and neutron-dhcp-agent also need change the ovsdb_connection and local_ip, because that need connect with ovs, too.","commit_id":"4dde6d12b58ee6463abbaaf3f8413bf809f3e694"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"e6459c76e0a5b1c6832b0fe59afee8a0fcb78b21","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# neutron-openvswitch-agent runs."},{"line_number":9,"context_line":"    ip\u003d$(hostname -i)"},{"line_number":10,"context_line":"    sed -i \u0027s|^ovsdb_connection.*\u003d.*|ovsdb_connection\u003dtcp:\u0027$ip\u0027:6640|g\u0027 /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":11,"context_line":"    sed -i \u0027s|^local_ip.*\u003d.*|local_ip\u003d\u0027$ip\u0027|g\u0027 /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":12,"context_line":"    neutron-openvswitch-agent --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":13,"context_line":"else"},{"line_number":14,"context_line":"# NOTE: (sbezverk) This part is executed only by kolla-ansible deployment."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_322b9732","line":11,"in_reply_to":"3ac371cc_b3edcdf1","updated":"2016-08-19 16:36:15.000000000","message":"Its generated once by ansible and shipped via configmap to all the pods.\n\nSo the debate right now is does the kube pod update the config via init-container for stuff like this, or push the updating logic into the main container like this patchset does.\n\nPlease see patchset https://review.openstack.org/#/c/356114 for an example of doing it the init-container way.","commit_id":"4dde6d12b58ee6463abbaaf3f8413bf809f3e694"}],"docker/openvswitch/openvswitch-db-server/start_ovsdb_server.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"6d36e38f91d53ed9021e52a064080bd18dda0e02","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# to launch ovsdb-server and to create the initial external bridge in one step."},{"line_number":17,"context_line":"# It is required in order to be able to use DaemonSet."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [ ! -e $ovs_bridge  ] \u0026\u0026 [ ! -e $ovs_ext_intf  ]; then"},{"line_number":20,"context_line":"# NOTE: (sbezverk) This part is executed only by kubernetes deployment."},{"line_number":21,"context_line":"# Creating external bridge"},{"line_number":22,"context_line":"    /usr/sbin/ovsdb-server /etc/openvswitch/conf.db --remote\u003dpunix:/var/run/openvswitch/db.sock --run\u003d\"ovs-vsctl --no-wait --db\u003dunix:/var/run/openvswitch/db.sock add-br $ovs_bridge\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3ac371cc_f392a54a","line":19,"updated":"2016-08-19 03:13:45.000000000","message":"even though this is not related, but could we use the coincident test for which orchestration we are in. \n\nlike:\n\nif [[ $orchestration \u003d\u003d \u0027kubernets\u0027 ]]; then\n\nelif [[ $orchestration \u003d\u003d \u0027ansible\u0027 ]]; then\n\nelse\n\nexit 1\n\nfi","commit_id":"4dde6d12b58ee6463abbaaf3f8413bf809f3e694"}]}