)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e29e20a517898f87d9b381147802556e1b4e327d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"{% set base_yum_url_packages \u003d ["},{"line_number":47,"context_line":"   \u0027http://repo.percona.com/release/7/RPMS/x86_64/percona-release-0.1-3.noarch.rpm\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":"{% for package in base_yum_url_packages| customizable(\u0027base_yum_url_packages\u0027) %}"},{"line_number":50,"context_line":"RUN yum -y install {{ package }}"},{"line_number":51,"context_line":"{% endfor %}"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_2d797594","line":49,"updated":"2016-08-19 19:23:11.000000000","message":"nitpick: put a space in there","commit_id":"486f9f7654ffc6f3eefa2d0b10e63b4aa8991658"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e29e20a517898f87d9b381147802556e1b4e327d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   \u0027http://repo.percona.com/release/7/RPMS/x86_64/percona-release-0.1-3.noarch.rpm\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":"{% for package in base_yum_url_packages| customizable(\u0027base_yum_url_packages\u0027) %}"},{"line_number":50,"context_line":"RUN yum -y install {{ package }}"},{"line_number":51,"context_line":"{% endfor %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"{% set base_yup_repo_keys \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_ed175deb","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":32},"updated":"2016-08-19 19:23:11.000000000","message":"Doing different RUNs for each yum will overload with image layers in the case of multiple packages(not for now). Would be better to make the for in RUN yum -y install {% for...  %}.\nAlso, the macro cannot handle this task?","commit_id":"486f9f7654ffc6f3eefa2d0b10e63b4aa8991658"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e29e20a517898f87d9b381147802556e1b4e327d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    \u0027centos-release-qemu-ev\u0027,"},{"line_number":96,"context_line":"] %}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"RUN yum -y install {% for package in base_centos_yum_repo_packages | customizable(\u0027centos_yum_repo_packages\u0027) %} {{ package }}{% endfor %}"},{"line_number":99,"context_line":"RUN true \\"},{"line_number":100,"context_line":"{% for key in base_centos_yum_repo_keys | customizable(\u0027yum_centos_repo_keys\u0027) %} \u0026\u0026 rpm --import {{ key }}{% endfor %} \u0026\u0026 yum clean all"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_cd7701d3","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":138},"updated":"2016-08-19 19:23:11.000000000","message":"Macro can be used here","commit_id":"486f9f7654ffc6f3eefa2d0b10e63b4aa8991658"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e29e20a517898f87d9b381147802556e1b4e327d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        \u0027iscsi-initiator-utils\u0027"},{"line_number":178,"context_line":"] %}"},{"line_number":179,"context_line":"# Install base packages"},{"line_number":180,"context_line":"RUN yum -y install {% for package in base_centos_binary_packages | customizable(\u0027centos_binary_packages\u0027) %}{{ package }}{% endfor %}\u0026\u0026 yum clean all"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    {% endif %}"},{"line_number":183,"context_line":"    {# Endif for install_type binary #}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_7046a224","line":180,"range":{"start_line":180,"start_character":0,"end_line":180,"end_character":149},"updated":"2016-08-19 19:23:11.000000000","message":"Ditto","commit_id":"486f9f7654ffc6f3eefa2d0b10e63b4aa8991658"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e29e20a517898f87d9b381147802556e1b4e327d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    \u0027iscsi-initiator-utils\u0027"},{"line_number":195,"context_line":"] %}"},{"line_number":196,"context_line":"# Update packages"},{"line_number":197,"context_line":"RUN yum -y install {% for package in base_centos_source_packages | customizable(\u0027centos_source_packages\u0027) %}{{ package }} {% endfor %}\u0026\u0026 yum clean all"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    {% endif %}"},{"line_number":200,"context_line":"    {# endif for install type is source for RPM based distros #}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1ac06dbe_d0e79610","line":197,"range":{"start_line":197,"start_character":0,"end_line":197,"end_character":150},"updated":"2016-08-19 19:23:11.000000000","message":"ditto","commit_id":"486f9f7654ffc6f3eefa2d0b10e63b4aa8991658"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b4cf47126373f36caadcd3c0fae69ebc280d8c7e","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"{% set base_centos_yup_repo_keys \u003d ["},{"line_number":80,"context_line":"    \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7\u0027,"},{"line_number":81,"context_line":"    \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Storage\u0027"},{"line_number":82,"context_line":"    \u0027/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Virtualization\u0027"},{"line_number":83,"context_line":"] %}"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_a8bb9f74","line":81,"range":{"start_line":81,"start_character":52,"end_line":81,"end_character":53},"updated":"2016-08-25 20:43:28.000000000","message":"Missing comma","commit_id":"404a6314b1a6846c1a43e87a450547af0087c278"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b4cf47126373f36caadcd3c0fae69ebc280d8c7e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \u0027epel-release \u0027,"},{"line_number":87,"context_line":"    \u0027yum-plugin-priorities\u0027,"},{"line_number":88,"context_line":"    \u0027centos-release-ceph-hammer\u0027,"},{"line_number":89,"context_line":"    \u0027centos-release-qemu-ev\u0027,"},{"line_number":90,"context_line":"] %}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"{{ macros.install_packages(base_centos_yum_repo_packages | customizable(\"yum_centos_repo_packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_48ff7334","line":89,"range":{"start_line":89,"start_character":28,"end_line":89,"end_character":29},"updated":"2016-08-25 20:43:28.000000000","message":"Unnecessary comma","commit_id":"404a6314b1a6846c1a43e87a450547af0087c278"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b4cf47126373f36caadcd3c0fae69ebc280d8c7e","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Enable couple required repositories for all RHEL builds"},{"line_number":102,"context_line":"# Turn on EPEL throughout the build"},{"line_number":103,"context_line":"RUN yum -y install \\"},{"line_number":104,"context_line":"        https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/epel-release-7-5.noarch.rpm \\"},{"line_number":105,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7 \\"},{"line_number":106,"context_line":"    \u0026\u0026 yum -y install \\"},{"line_number":107,"context_line":"           yum-plugin-priorities \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_88a7bb4e","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":97},"updated":"2016-08-25 20:43:28.000000000","message":"Can be with the macro","commit_id":"404a6314b1a6846c1a43e87a450547af0087c278"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"9a2feeff867079b4b238b813490fcf90723f44f4","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Enable couple required repositories for all RHEL builds"},{"line_number":102,"context_line":"# Turn on EPEL throughout the build"},{"line_number":103,"context_line":"RUN yum -y install \\"},{"line_number":104,"context_line":"        https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/epel-release-7-5.noarch.rpm \\"},{"line_number":105,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7 \\"},{"line_number":106,"context_line":"    \u0026\u0026 yum -y install \\"},{"line_number":107,"context_line":"           yum-plugin-priorities \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_d71cfe79","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":97},"in_reply_to":"fa7ab95a_88a7bb4e","updated":"2016-08-26 18:42:46.000000000","message":"I specifically didn\u0027t change anything with rhel, I\u0027ll leave this for later.","commit_id":"404a6314b1a6846c1a43e87a450547af0087c278"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b4cf47126373f36caadcd3c0fae69ebc280d8c7e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"RUN yum -y install \\"},{"line_number":104,"context_line":"        https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/epel-release-7-5.noarch.rpm \\"},{"line_number":105,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7 \\"},{"line_number":106,"context_line":"    \u0026\u0026 yum -y install \\"},{"line_number":107,"context_line":"           yum-plugin-priorities \\"},{"line_number":108,"context_line":"    \u0026\u0026 yum clean all \\"},{"line_number":109,"context_line":"    \u0026\u0026 yum-config-manager --enable rhel-7-server-optional-rpms \\"},{"line_number":110,"context_line":"    \u0026\u0026 yum-config-manager --enable rhel-7-server-extras-rpms"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_a862bf14","line":108,"range":{"start_line":106,"start_character":0,"end_line":108,"end_character":22},"updated":"2016-08-25 20:43:28.000000000","message":"Ditto","commit_id":"404a6314b1a6846c1a43e87a450547af0087c278"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b4cf47126373f36caadcd3c0fae69ebc280d8c7e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    {% if base_distro \u003d\u003d \u0027oraclelinux\u0027 %}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"COPY oraclelinux-extras.repo /etc/yum.repos.d/oraclelinux-extras.repo"},{"line_number":118,"context_line":"RUN yum -y install \\"},{"line_number":119,"context_line":"        tar \\"},{"line_number":120,"context_line":"        yum-utils \\"},{"line_number":121,"context_line":"        http://mirror.centos.org/centos-7/7/extras/x86_64/Packages/epel-release-7-5.noarch.rpm \\"},{"line_number":122,"context_line":"    \u0026\u0026 rpm -Uvh --nodeps \\"},{"line_number":123,"context_line":"        http://buildlogs.centos.org/centos/7/cloud/x86_64/openstack-mitaka/centos-release-openstack-mitaka-1-3.el7.noarch.rpm \\"},{"line_number":124,"context_line":"        http://mirror.centos.org/centos-7/7/extras/x86_64/Packages/centos-release-ceph-hammer-1.0-5.el7.centos.noarch.rpm \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_e86cc70a","line":121,"range":{"start_line":118,"start_character":0,"end_line":121,"end_character":96},"updated":"2016-08-25 20:43:28.000000000","message":"Ditto","commit_id":"404a6314b1a6846c1a43e87a450547af0087c278"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b4cf47126373f36caadcd3c0fae69ebc280d8c7e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Storage \\"},{"line_number":131,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Virtualization \\"},{"line_number":132,"context_line":"    \u0026\u0026 yum-config-manager --enable ol7_optional_latest ol7_addons \\"},{"line_number":133,"context_line":"    \u0026\u0026 yum -y install \\"},{"line_number":134,"context_line":"           yum-plugin-priorities \\"},{"line_number":135,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_887edbac","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":34},"updated":"2016-08-25 20:43:28.000000000","message":"Ditto","commit_id":"404a6314b1a6846c1a43e87a450547af0087c278"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"b4cf47126373f36caadcd3c0fae69ebc280d8c7e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if base_distro in [\u0027fedora\u0027, \u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] #}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"RUN yum -y update \\"},{"line_number":159,"context_line":"    \u0026\u0026 yum -y install \\"},{"line_number":160,"context_line":"           yum-plugin-versionlock \\"},{"line_number":161,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":162,"context_line":"COPY versionlock.list /etc/yum/pluginconf.d/"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    {% if install_type \u003d\u003d \u0027binary\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"fa7ab95a_e83a07e7","line":161,"range":{"start_line":159,"start_character":0,"end_line":161,"end_character":20},"updated":"2016-08-25 20:43:28.000000000","message":"Ditto","commit_id":"404a6314b1a6846c1a43e87a450547af0087c278"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"c617865746dfb99242cc94a77bf5233522749110","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    \u0026\u0026 groupadd kolla \\"},{"line_number":278,"context_line":"    \u0026\u0026 rm -f /tmp/kolla_bashrc"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa7ab95a_aa9de55a","line":280,"updated":"2016-08-29 04:56:40.000000000","message":"Add named footer block for base","commit_id":"19f0de7f96ce469ad9f712ab84263f78458b3cf3"}]}