)]}'
{"docker/designate/designate-base/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c865eb6266b263f35799e9a15d93d31a3b0d7e34","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{% block designate_base_footer %}{% endblock %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"RUN usermod -a -G kolla designate"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa7ab95a_df13db0b","line":54,"updated":"2016-08-28 01:04:11.000000000","message":"Good catch. I think this should move to above the footer block too.","commit_id":"b41157cdff35e97b236507c6cbda345907e54b01"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"42ef308544819d29708473aedefc2b9466954d95","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{% block designate_base_footer %}{% endblock %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"RUN usermod -a -G kolla designate"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_03b9c1cb","line":54,"updated":"2016-08-25 10:52:48.000000000","message":"In the other files this is above the footer. I think this should be added to the RUN statement starting in line 49.","commit_id":"b41157cdff35e97b236507c6cbda345907e54b01"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"10e9d30d8b3bb08b5b17ce118e2a66d25a8b3e6b","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{% block designate_base_footer %}{% endblock %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"RUN usermod -a -G kolla designate"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa7ab95a_b3b48bd1","line":54,"in_reply_to":"fa7ab95a_df13db0b","updated":"2016-08-28 15:54:20.000000000","message":"agree - please fix throughout tree.","commit_id":"b41157cdff35e97b236507c6cbda345907e54b01"}],"docker/manila/manila-base/Dockerfile.j2":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"42ef308544819d29708473aedefc2b9466954d95","unresolved":false,"context_lines":[{"line_number":55,"context_line":"RUN touch /usr/local/bin/kolla_manila_extend_start \\"},{"line_number":56,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_manila_extend_start"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"RUN usermod -a -G kolla manila"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% block manila_base_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1ac06dbe_e3dbc519","line":58,"updated":"2016-08-25 10:52:48.000000000","message":"Can you add this to the previous run statement.","commit_id":"b41157cdff35e97b236507c6cbda345907e54b01"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"10e9d30d8b3bb08b5b17ce118e2a66d25a8b3e6b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"RUN touch /usr/local/bin/kolla_manila_extend_start \\"},{"line_number":56,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_manila_extend_start"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"RUN usermod -a -G kolla manila"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% block manila_base_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa7ab95a_93e867b6","line":58,"in_reply_to":"1ac06dbe_e3dbc519","updated":"2016-08-28 15:54:20.000000000","message":"sounds reasonable but a micro-optimization - especially if needed for every container.  Use best judgement - to get an implementation merged asap.","commit_id":"b41157cdff35e97b236507c6cbda345907e54b01"}]}